[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #228 from Jonathan Druart --- Could you describe please, I cannot reproduce: % git remote update % git checkout master % git reset --hard c34017336c3cd03f471b1c5100b9f6b4dbe589db HEAD is now at c340173 Bug 7167: Set final updatedatabase.pl version % perl Makefile.PL By default, Koha can be installed in one of three ways: standard: Install files in conformance with the Filesystem Hierarchy Standard (FHS). This is the default mode and should be used when installing a production Koha system. On Unix systems, root access is needed to complete a standard installation. single: Install files under a single directory. This option is useful for installing Koha without root access, e.g., on a web host that allows CGI scripts and MySQL databases but requires the user to keep all files under the user's HOME directory. dev: Create a set of symbolic links and configuration files to allow Koha to run directly from the source distribution. This mode is useful for developers who want to run Koha from a git clone. Installation mode (dev, single, standard) [standard] ^C -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9323] Untranslatable string in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9323] Untranslatable string in serials search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323 --- Comment #4 from Jonathan Druart --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #229 from Chris Cormack --- Do it on a fresh machine with no Koha installed (like you would when installing), or make sure your KOHA_CONF variable is not set (like it would be when installing). eg $ git checkout c340173 HEAD is now at c340173... Bug 7167: Set final updatedatabase.pl version $ echo $KOHA_CONF /home/chrisc/koha-dev/etc/koha-conf.xml perl Makefile.PL Works fine $ KOHA_CONF='' perl Makefile.PL unable to locate Koha configuration file koha-conf.xml at /home/chrisc/git/catalyst-koha/C4/Context.pm line 372. unable to locate Koha configuration file koha-conf.xml at /home/chrisc/git/catalyst-koha/C4/Context.pm line 372. Can't call method "config" on unblessed reference at /home/chrisc/git/catalyst-koha/C4/Context.pm line 790. $ git checkout kc/master HEAD is now at 5a61a3b... Revert "Bug 8378 - syntax not working on overdues anymore" $ KOHA_CONF='' perl Makefile.PL Works fine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Pierre Angot changed: What|Removed |Added CC||tredok.pie...@gmail.com --- Comment #41 from Pierre Angot --- I've got a problem with the file to test import (bib-237.utf8). I'v added it to a basket from a staged file, but the price is not filled. I think the price is include in the file (947$c ?). There is no problem with quantity (10 books). After mys first test, I've noticed a software error. - Manage staged MARC records - create a new basket - add an order from a staged file - select file - clic on "add order" (to access ) = software error Can't call method "raw" on an undefined value at /home/koha/src/C4/Search.pm line 272. If I dont clic on "add order", there is no software error. Note : I've tested on a sandbox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #9 from laurenthdl --- Created attachment 14308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14308&action=edit biblio record This file contains UNIMARC bibliorecords as example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #10 from laurenthdl --- Created attachment 14309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14309&action=edit authorities linked to biblio records Beware that when importing, the authorities ids may change. So you may have to change the related imported records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #230 from Jonathan Druart --- Created attachment 14310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14310&action=edit Bug 7167 follow-up: allow Makefile.PL to work $dbh should not be declared at the package level unless one is *sure* that there will be a valid context. TODO: fix the following noise when running perl Makefile.PL: unable to locate Koha configuration file koha-conf.xml at /home/esi/koha/C4/Context.pm line 372. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jonathan Druart changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7167] updatedatabase improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 Jonathan Druart changed: What|Removed |Added Status|NEW |In Discussion CC||jonathan.dru...@biblibre.co ||m --- Comment #1 from Jonathan Druart --- I understand what we discuss yesterday :) It is the normal behavior: A new version is available, you execute it. This version is an already executed file (same md5) so you must mark it as "ok" . The execute routine checks the md5 before any operation and returns this error if the same md5 already exists in DB. It is not a bug for me. What do you propose? Do you have a better way to manage this kind of files? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 --- Comment #2 from Jared Camins-Esakov --- (In reply to comment #1) > I understand what we discuss yesterday :) > > It is the normal behavior: > A new version is available, you execute it. > This version is an already executed file (same md5) so you must mark it as > "ok" . > The execute routine checks the md5 before any operation and returns this > error if the same md5 already exists in DB. > > It is not a bug for me. > > What do you propose? Do you have a better way to manage this kind of files? Since it is impossible to rerun the update even if you want to, the MD5 needs to be checked prior to deciding that there are database updates to run. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #30 from Jared Camins-Esakov --- (In reply to comment #29) > 4) The patches are also missing unit tests for the new routines > FindSuggestions and FindBiblios. > > As these patches are quite old (June 2012), I am not sure if 4) is a failed > QA - leaving this decision to Jared. I will accept this patch without unit tests, though it will not make me happy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #49 from Jonathan Druart --- Hi Katrin, Yes it is normal. Try with : my $log = C4::Context->logger; the constructor Koha::Utils::Logger->new takes a level parameter. If it does not exist, the normal level is used. C4::Context->logger uses the level from the syspref LogLevel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 Magnus Enger changed: What|Removed |Added Summary|debian/templates/koha-conf- |Search is broken for 3.10 |site.xml.in is hardcoded to |package-installs when |retrieval syntax = usmarc |marcflavour != marc21 --- Comment #7 from Magnus Enger --- Trying to find a more descriptive (and fetching) title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9256] Search is broken for 3.10 package-installs when marcflavour != marc21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9256 --- Comment #8 from Chris Cormack --- > > There is one big question, though: Since I had to edit non-instance specific > files like /etc/koha/zebradb/retrieval-info-bib-dom.xml - does that mean we > will only be able to support one MARC dialect on one server? If that is true bug 3087 should be reverted. We have broken Koha to get an z3950 server going for external use. We should not break core like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9169] Wrap relator code in to allow for CSS customization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 --- Comment #9 from Magnus Enger --- (In reply to comment #4) > (QUESTION TO MAGNUS : don't you need the same patch for NORMARC ?) No, it does not look like NORMARC uses relator codes. But thanks for thinking about us! :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209 Jared Camins-Esakov changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #14 from Jared Camins-Esakov --- Although I would not usually do this, since QAing these patches presents a problem for the QA team, and I am able to, I am going to go ahead and mark these patches as Passed QA. The test is now a no-op for systems that do not have DBD::Mock installed from CPAN and so are safe, and without them we will have no way to spot if further work on the calendar code breaks things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 --- Comment #1 from Jonathan Druart --- Created attachment 14311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14311&action=edit Bug 9328, 7167: Remove the File::Find::Rule dependency F::F::Rule doesn't introduce functionality that is not available to File::Find, just some (admittedly useful) syntactical sugar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9328] File::Find::Rule should not be a mandatory dependency for installation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9328 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #2 from Jonathan Druart --- To apply on top of patches for Bug 7167 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #42 from Jonathan Druart --- (In reply to comment #41) > I've got a problem with the file to test import (bib-237.utf8). I'v added it > to a basket from a staged file, but the price is not filled. I think the > price is include in the file (947$c ?). > There is no problem with quantity (10 books). Does it work on master? > After mys first test, I've noticed a software error. > - Manage staged MARC records > - create a new basket > - add an order from a staged file > - select file > - clic on "add order" (to access ) = software error > > Can't call method "raw" on an undefined value at /home/koha/src/C4/Search.pm > line 272. > > If I dont clic on "add order", there is no software error. I cannot reproduce, could you give me the url of the basket please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9326] New database update system suggests running duplicate updates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9326 --- Comment #3 from Jonathan Druart --- It would be possible to let the user choose what to do: "version xxx already executed in version yyy, [mark as OK] or [apply anyway]" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Nicole C. Engard changed: What|Removed |Added Attachment #14277|0 |1 is obsolete|| --- Comment #5 from Nicole C. Engard --- Created attachment 14312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14312&action=edit Bug 9306: Update descriptions for the 4 SeparateHoldings prefs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Nicole C. Engard changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Nicole C. Engard --- Sorry! Third time's a charm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Nicole C. Engard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Failed QA Patch complexity|--- |Small patch --- Comment #4 from Nicole C. Engard --- I was testing and it did prevent me from being able to submit 100 times :) but when I clicked the 'Pay' button next to one line it instead acted like the 'Pay Amount' button and showed me all that was due. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] New: Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Bug ID: 9329 Summary: Wrong message for already expired cards Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: adrien.sau...@biblibre.com Reporter: adrien.sau...@biblibre.com When a library uses the NotifyBorrowerDeparture to give warning about expiration dates, the warning stay the same even "after" the actual expiration. For a borrower connecting now, in December 2012, the OPAC display this king of message : "Please note: Your card will expire on 20/08/2012. Please contact the library for more information." In this case, a new message should be added. When the card has expired, the message should be simply : "Please note: Your car has expired. Please contact the library for more information." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9272] Plack goes into paroxysms of horror when faced with deleting an authorized value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9272 --- Comment #6 from Elliott Davis --- Created attachment 14313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14313&action=edit Bug 9272: Eliminate error when deleting authorized value Try to delete an authorized value. if you don't get any error, this patch works. Signed-off-by: Mirko Tietgen Enabled debug, tried with and without Plack, works fine for both. Signed-off-by: Elliott Davis Works as advertised. Follows coding guidelines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9272] Plack goes into paroxysms of horror when faced with deleting an authorized value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9272 Elliott Davis changed: What|Removed |Added Attachment #14106|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9272] Plack goes into paroxysms of horror when faced with deleting an authorized value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9272 Elliott Davis changed: What|Removed |Added Status|Signed Off |Passed QA CC||elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9301] Search to Hold no longer passing through patron name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9301 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | --- Comment #2 from Owen Leonard --- I checked out origin/3.8.x and could not reproduce the problem. Is there a specific version I should test? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 --- Comment #1 from Adrien SAURAT --- Created attachment 14314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14314&action=edit proposed patch TEST PLAN : The best way to test would to have at the same time : - a SQL client to change the expiry date of a borrower - an OPAC session opened for the same patron. Case 1: expiry date is set in the future -> no warning Case 2: expiry date is set in the near future (within the "NotifyBorrowerDeparture" system preference range) -> a warning says the card will expire on **date** Case 3: expiry date is set in the past -> before patch, same warning as Case 2 -> after patch, new warning indicating that the card has expired -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Adrien SAURAT changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9306] update SeparateHoldings preference descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9306 Owen Leonard changed: What|Removed |Added Attachment #14312|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 14315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14315&action=edit [SIGNED-OFF] Bug 9306: Update descriptions for the 4 SeparateHoldings prefs Patch updates the text of the SeparateHoldings and OpacSeparateHoldings preference descriptions to be more readable. To test, apply the patch and check the text of the preferences. Signed-off-by: Owen Leonard Description and test plan added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #10 from Jonathan Druart --- Just a comment after a quick look at the patch, there is a bad copy/paste: +DROP TABLE IF EXISTS sessions; +CREATE TABLE `sms_providers` ( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Owen Leonard changed: What|Removed |Added Attachment #14314|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 14316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14316&action=edit [SIGNED-OFF] Bug 9329: Wrong message for already expired cards Previously users would see the same message whether their card was about to expire or was already expired. This patch adds a new message to handle cards which are about to expire, following the NotifyBorrowerDeparture system preference. TEST PLAN : The best way to test would to have at the same time : - a SQL client to change the expiry date of a borrower - an OPAC session opened for the same patron. Case 1: expiry date is set in the future -> no warning Case 2: expiry date is set in the near future (within the "NotifyBorrowerDeparture" system preference range) -> a warning says the card will expire on **date** Case 3: expiry date is set in the past -> before patch, same warning as Case 2 -> after patch, new warning indicating that the card has expired Signed-off-by: Owen Leonard Added description to the patch and copied test plan from the bug report. Patch passes test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6574] js error in en-GB template breaks circulation toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6574 Owen Leonard changed: What|Removed |Added Attachment #14304|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 14317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14317&action=edit [SIGNED-OFF] Bug 6574 - js error in en-GB and en-NZ translations due to improper quoting To replicate: * install en-NZ translation (or en-GB) * activate the new language, and select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * without the patch, the toolbar will be incorrect. The toolbar will also be incorrect on moremember.pl. To test: * apply the patch * re-generate the en-NZ or en-GB translation * activate the new language, or select it for use * pretend you are going to issue a book to a member (search for a member from "check out" in header) * with the patch, the toolbar will appear to be correct. It will also be correct on moremember.pl. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9075] Show material type and item type on staff detail (with xslt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075 --- Comment #6 from Owen Leonard --- Confusion about what this patch does would be helped by adding a description of the problem, a description of the solution, and a clear test plan to the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- This appears to be working at first glance, but I see that there is a problem somewhere with the markup, causing the language-switcher menu not to "stick" to the bottom of the screen. This is probably caused by an unclosed somewhere. I hate to say it, but I really think this patch needs to be submitted without all the whitespace changes. addbiblio.pl is a complex page, and not being able to carefully review the relevant changes makes me nervous. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
--- Comment #50 from Chris Cormack ---
Created attachment 14318
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14318&action=edit
Bug 8190: Koha::Utils::Logger, Logging module
use Koha::Utils::Logger qw/$log/;
$log = Koha::Utils::Logger->new;
$log->debug("This is a debug message");
$log->info("This is an information");
$log->error("This is an error !");
The Logger constructor can take an hash reference with "file" and
"level" to define a filepath or a log level.
For a log level >= warning, a call stack is printed.
Prerequisite:
- set an environment variable KOHA_LOG in your virtual host:
SetEnv KOHA_LOG /home/koha/var/log/opac.log
- set a write flag for www-data on this file
Please have a look at t/Logger.t for more details.
Signed-off-by: Mason James
Signed-off-by: Kyle M Hall
Bug 8190: Followup Logger: FIX perlcritic
Signed-off-by: Mason James
Signed-off-by: Kyle M Hall
Bug 8190 - Followup - Add cached logger, output messages to template
* Add C4::Context->logger
* Embed logged messageds to a comment in the template html,
controlled by the system preference LogToHtmlComments\
* Add both new system preferences to sysprefs.sql
Signed-off-by: Paul Poulain
Bug 8190 follow-up moving updatedatabase part at the right place
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What|Removed |Added Attachment #13925|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What|Removed |Added Attachment #13926|0 |1 is obsolete|| --- Comment #51 from Chris Cormack --- Created attachment 14319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14319&action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What|Removed |Added Attachment #14294|0 |1 is obsolete|| --- Comment #52 from Chris Cormack --- Created attachment 14320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14320&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What|Removed |Added Attachment #14296|0 |1 is obsolete|| --- Comment #53 from Chris Cormack --- Created attachment 14321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14321&action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #43 from Pierre Angot --- Yep. Test on master (Koha version : 3.11.00.014) I've created a new basket to verify before adding a comment ^^ Ex : basketno=8 http://pro.pelardon.biblibre.com/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=402&basketno=8&booksellerid=4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #54 from Chris Cormack --- Patches rebased so they all apply on master. Tests pass. However it is currently not plack safe, follow up to come. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9316] Add Nginx install options with plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis changed: What|Removed |Added Attachment #14257|0 |1 is obsolete|| --- Comment #3 from Elliott Davis --- Created attachment 14322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14322&action=edit Bug 9316: Add ability to install/configure nginx To Test: 1) Ensure that you have nginx installed 2) Esure that you have the following packages installed libplack-perl libcgi-emulate-psgi-perl libcgi-compile-perl 3) Apply patch 4) Run through the make file, you will notice 5 new configuration options. 5) Make sure you choose NGiNX as your webserver 6) You may choose whatever ports you wish and also whatever DNS entries you wish 7) After you're done configuring run make 8) Run make install (you may need sudo if you've used sudo before) 9) Start plack (you may wish to copy the script to init.d) with the script in koha-dev/bin/koha-plack.sh (requires sudo) 10) TURN OFF APACHE, and start NGiNX 11) go to your web browser and see if everything fires up as normal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9316] Add Nginx install options with plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 Elliott Davis changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8877] MARC21 field 511 missing from XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8877 Katrin Fischer changed: What|Removed |Added Attachment #12697|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 14323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14323&action=edit [SIGNED-OFF] Bug 8877 [ENH] MARC21 field 511 missing from XSLT Adds MARC21 field 511 to the OPAC XSLT file. Signed-off-by: Marc Veron Contents of field 511 appears as expected. Signed-off-by: Katrin Fischer Patch changes OPAC XSLT display, 511 is shown as defined by the MARC21 standard. If 1st indicator is 1, the label cast is shown in front of the 511 field. If 1st indicator is 0 or empty, no label is shown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8877] MARC21 field 511 missing from XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8877 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8877] MARC21 field 511 missing from XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8877 --- Comment #9 from Katrin Fischer --- Mirko, you have persuaded me ;) Could you please provide a follow-up to the intranet display to make it match with OPAC display? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Please provide a test plan, problem description and some notes on how this patch is solving the problem. Also, I would like to see Vitor's question addressed (comment 7). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #55 from Chris Cormack --- I started trying to tidy it, but didn't get super far, attached is the patch, for interest sake. I might try another approach if time allows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #56 from Chris Cormack --- Created attachment 14324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14324&action=edit DO NOT USE - Partial rewrite of Logger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9272] Plack goes into paroxysms of horror when faced with deleting an authorized value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9272 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8877] MARC21 field 511 missing from XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8877 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #57 from Jared Camins-Esakov --- I think I favor Log4Perl over LogLite, since it allows us to cut down dramatically on the amount of code that we are maintaining. However, I do not have a strong opinion on that. There are five issues that absolutely must be fixed: 1) The ->debug() level needs to work. 2) Private variable need to be eliminated from the module level and the code made thread-safe. 3) The unit test must be changed to not require the database. 4) The $log package variable should not be in Koha::Utils::Logger. Any static configuration should be handled entirely in C4::Context. 5) If Koha::Utils::Logger is object-oriented, it must not be an Exporter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190
Chris Cormack changed:
What|Removed |Added
Status|ASSIGNED|In Discussion
--- Comment #58 from Chris Cormack ---
If we are going to always access the logger object via C4::Context, we could do
this all without the need of a new module.
if in C4::Context we added something very similar to
use Log::Log4perl qw(:levels get_logger);
my $layout_class = "Log::Log4perl::Layout::PatternLayout";
my $layout_pattern = "[%d] %p - %M - %m - %T%n";
my $config = <<"END";
log4perl.logger = INFO, Logfile, Screen
log4perl.appender.Logfile = Log::Log4perl::Appender::File
log4perl.appender.Logfile.filename = $ENV{KOHA_LOG}
log4perl.appender.Logfile.mode=append
log4perl.appender.Logfile.layout = $layout_class
log4perl.appender.Logfile.layout.ConversionPattern=$layout_pattern
log4perl.appender.Screen = Log::Log4perl::Appender::Screen
log4perl.appender.Screen.layout = $layout_class
log4perl.appender.Screen.layout.ConversionPattern = $layout_pattern
END
Log::Log4perl->init( \$config );
and then in there a sub
sub logger
{
my $self = shift;
if ( defined( $context->{"logger"} ) ) {
return $context->{"logger"};
}
$context->{"logger"} = Log::Log4perl->get_logger('C4::Context');
$context->{"logger"}->level(C4::Context->preference("LogLevel"));
return $context->{"logger"};
}
We would have a logger logging to stderr and to the file defined. We would need
to change our numeric loglevels to strings, like FATAL, WARN etc but that is
easily done. And if we did want our 2 extra ones, we can add these 2 lines
# set up our custom log leves CRIT and NORMAL
Log::Log4perl::Logger::create_custom_level( 'CRIT', 'FATAL');
Log::Log4perl::Logger::create_custom_level( 'NORMAL', 'WARN' );
Before we do the init.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
