[Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9116 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9116 M. de Rooy changed: What|Removed |Added Attachment #13928|0 |1 is obsolete|| --- Comment #3 from M. de Rooy --- Created attachment 14726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14726&action=edit Patch Signed off. Tested with CreateItem=Placing an order and neworderempty.pl. QA Comment: Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9116 M. de Rooy changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9116 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9116] Code cleaning: Remove some useless temp variables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9116 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #4 from M. de Rooy --- Please resolve merge conflict on template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9208] overdue letters (pdf) are not correctly encoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9208 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co |ity.org |m QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9208] overdue letters (pdf) are not correctly encoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9208 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy --- QA Comment: Trivial change. Did not test it; requires specific Python library. The added encoding parameter seems to be in line with xhtml2pdf specs. Will not harm anyone :) Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9263] Trim barcodes in offline circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9263 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA CC||m.de.r...@rijksmuseum.nl --- Comment #7 from M. de Rooy --- QA Comment: Trivial patch. Did not test offline circ. But this patch is just housekeeping and trims spaces from barcode and cardnumber. Looks good to me. Will not hurt anyone. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Patch complexity|--- |Medium patch QA Contact|koha.sek...@gmail.com |m.de.r...@rijksmuseum.nl --- Comment #40 from M. de Rooy --- Problem with third patch: Applying: Bug 7825: Followup values are 1, 0 or 'force' /usr/share/koha/testclone/.git/rebase-apply/patch:32: tab in indent. [% IF OPACItemHolds == '1' or OPACItemHolds == 'force' %] fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #33 from M. de Rooy --- Looking at this one.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What|Removed |Added Attachment #14068|0 |1 is obsolete|| --- Comment #34 from M. de Rooy --- Created attachment 14727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14727&action=edit Patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #35 from M. de Rooy --- Tested the cronjob with various settings of email parameter. QA Comment: This patch unfortunately took some time to reach this point. But hopefully we do now. Just some minor comments. (Thanks for paying attention to various details along the way!) The (double) use of $email in prepare_letter_for_printing is still little bit confusing. But could be taken care of in a followup. (In both cases there is no e-mail.) Could the email parameter be removed or just be empty in those two lines? Not an error, but just a thought: If I run perl misc/cronjobs/overdue_notices.pl -email email,emailpro I get: Use of uninitialized value in string ne at misc/cronjobs/overdue_notices.pl line 491. I know that I should do -email email -email emailpro and that works fine. But is it an idea to make it work too? Or should you better check the contents of this parameter and warn? (This may be somewhat hypothetical for a cronjob, I realize..) Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7678] Statistics wizard: patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7678] Statistics wizard: patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 Katrin Fischer changed: What|Removed |Added Attachment #14710|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 14728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14728&action=edit [SIGNED-OFF] Bug 7678: Adds extended patron attributes in patron reports Fix bug that prevented zero values to be shown in the results. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Fixes the problem with differentiating 0 and NULL values. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8215] Add Course Reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #75 from Katrin Fischer --- Hi Kyle, I would like to see the last 3 patches signed off. Also, they don't have any useful commit messages. Please add information about what they are supposed to fix and how to test it. Once they are signed off I will try to come back to this as soon as possible. Failing QA for the commit messages - switch to 'Needs Signoff' once that is fixed. Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9236] deleting an order when receiving redirects to closed basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9236] deleting an order when receiving redirects to closed basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236
Katrin Fischer changed:
What|Removed |Added
Attachment #14047|0 |1
is obsolete||
Attachment #14048|0 |1
is obsolete||
--- Comment #16 from Katrin Fischer ---
Created attachment 14729
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14729&action=edit
[SIGNED-OFF] Bug 9236: FIX delete order when receiving
Before this patch the "delete order" links were broken on the receiving
page (parcel.pl)
Signed-off-by: mathieu saby
Before applying the patch, when recieving a parcel,
if you delete an order line, Koha tries to open the
page of the basket linked to that order, but can
not find it. Koha displays "Vendor not found".
With the patch, Koha finds the right basket.
I Sign off this patch, to be applied with the other patch ("Redirect to the
parcel page after deleting an item/order")
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9236] deleting an order when receiving redirects to closed basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #17 from Katrin Fischer --- Created attachment 14730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14730&action=edit [SIGNED-OFF] Bug 9236 : Redirect to the parcel page after deleting an item/order Signed-off-by: mathieu saby Signed-off-by: Katrin Fischer 1) Receive shipment for a previously created basket with multiple order lines 2) Verify 'Delete order' links only have 2 parameters and when you delete an order, you are not redirected to the basket. 3) Verify the same is true for 'Delete order and catalog record'. 4) Apply both patches from Bug 9236. 5) Redo tests and verify page redirects correctly now. Links now also show the basket number as third parameter. Also: make sure orders/items and records are deleted correctly. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281 --- Comment #9 from Katrin Fischer --- Hi Jonathan, I am not sure I did it right, as my output looks quite different to yours. I added it at the beginning of the GetMembers routing, but the line number was totally different to the one you noted in your comment. Could you check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9281] Impossible to create an order from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9281
--- Comment #10 from Katrin Fischer ---
[Sun Jan 20 23:24:55 2013] [error] [client 127.0.0.1] [Sun Jan 20 23:24:55
2013] basket.pl: $VAR1 = {, referer:
http://localhost:8080/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=12&basketno=9&booksellerid=2
[Sun Jan 20 23:24:55 2013] [error] [client 127.0.0.1] [Sun Jan 20 23:24:55
2013] basket.pl: 'borrowernumber' => '1', referer:
http://localhost:8080/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=12&basketno=9&booksellerid=2
[Sun Jan 20 23:24:55 2013] [error] [client 127.0.0.1] [Sun Jan 20 23:24:55
2013] basket.pl: };, referer:
http://localhost:8080/cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=12&basketno=9&booksellerid=2
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #75 from Bernardo Gonzalez Kriegel --- Created attachment 14731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14731&action=edit [SIGNED OFF] Bug 7804 - Add Koha Plugin System - Unit Tests Tests Ok ~/kohaclone$ perl t/db_dependent/Plugins.t 1..15 ok 1 - use Koha::Plugins; ok 2 - use Koha::Plugins::Handler; ok 3 - use Koha::Plugins::Base; ok 4 - use Koha::Plugin::Test; ok 5 - Test can_load ok 6 - Test plugin class isa Koha::Plugin::Test ok 7 - Test plugin parent class isa Koha::Plugins::Base ok 8 - Test plugin can report ok 9 - Test plugin can tool ok 10 - Test plugin can configure ok 11 - Test plugin can install ok 12 - Test plugin can install ok 13 - Test $plugin->get_metadata() ok 14 - Test $plugin->get_qualified_table_name() ok 15 - Test $plugin->get_plugin_http_path() (and all others as well) Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9190] Problem with holds - allow place a hold without all items checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9190 vinod changed: What|Removed |Added CC||vinod_librarian@rediffmail. ||com --- Comment #5 from vinod --- This requirement seems some time good, but if the items is multi-volume which cataloged under one bibliography, than in that case this option is needed to place hold on that particulate Pt./Vol. etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
