[Koha-bugs] [Bug 5888] opac-detail subject/author links improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #41 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA: Looking at this one again.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14763|0 |1 is obsolete|| --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 15153 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15153action=edit Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable $period is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8034] Enable server print queue selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #31) (In reply to comment #27) QA comment: * The DB update, you write ALTER TABLE branches MODIFY branchprinter varchar(20) NULL, ADD FOREIGN KEY (branchprinter) REFERENCES printers (printqueue) ON UPDATE CASCADE = why not also add ON DELETE SET NULL (on delete cascade would be a strong mistake, you don't want to delete branches just because you deleted a printer !!!) ? Because we don't want to leave branches without their default printer, so only unused printers can be removed. So you must catch the error raised by mysql if a printer is deleted and some branches use it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5888] opac-detail subject/author links improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment on 5888: Still have my doubts on this feature. The usability is IMO the biggest issue. Please note my earlier comment 13. If I just want to search on the author I click on, I do not want to click again on Search. If I have some more authors and subject, the page even needs to be scrolled down before reaching the buttons. This would mean 1 click, 1 scroll and another click instead of the previous 1 click. If I want to search on two subjects, I will type them just as fast in the search box as selecting them in the menu? All together, I would prefer this option to be controlled by a syspref (default disabled), or offer the new menu in a different way. You could e.g. add a last option to the subject line like Combined subject search (only if #subjects1) and present the menu then. Comment 16 suggests that this is less readable. But note that is only one extra link at the end. No large effect on readability, but usability is kept or even improved. Another minor point: If I want to remove the menu again, it should be possible without the need to scroll and click. In the case of more authors and subjects, the Cancel button cannot be reached rightaway. Could you add a Close or X button at the top to remove the menu? Another minor point: It is working on normal view only, but not on xslt. Since all comments are on a functional level, I will set this patch to In Discussion and first send a mail to the QA team. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8034] Enable server print queue selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #33 from Srdjan Jankovic srd...@catalyst.net.nz --- (In reply to comment #32) (In reply to comment #31) (In reply to comment #27) QA comment: * The DB update, you write ALTER TABLE branches MODIFY branchprinter varchar(20) NULL, ADD FOREIGN KEY (branchprinter) REFERENCES printers (printqueue) ON UPDATE CASCADE = why not also add ON DELETE SET NULL (on delete cascade would be a strong mistake, you don't want to delete branches just because you deleted a printer !!!) ? Because we don't want to leave branches without their default printer, so only unused printers can be removed. So you must catch the error raised by mysql if a printer is deleted and some branches use it. I can do that if you insist, however current version does not do that, ie does not check anything at all. This is an improvement as is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5888] opac-detail subject/author links improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think a syspref would make sense to me - libraries are sensitive about such things, so giving them a choice is always good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7518] searches with quotation marks don't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|koha.sek...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9213] Implement analytics for NORMARC XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9213 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9213] Implement analytics for NORMARC XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9213 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14842|0 |1 is obsolete|| --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 15154 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15154action=edit Bug 9213 - Implement analytics for NORMARC XSLT Problem: Links between anaytics records were not being displayed for NORMARC setups. What this patch does: 1. Add indexing for 773 subfield a, w and 9; both for GRS-1 and DOM indexing (The DOM indexing config was generated from the GRS-1 record.abs) 2. Add analytics links to NORMARC XSLT files, both for OPAC and intranet To test: - Make sure you have a NORMARC installation - Set UseControlNumber = Use - Create a parent record with LDR/07=c. Leave 001 empty. - In the Normal view, do New New child record and create another record. Do this twice (so you get a list of hits when you click on the Show anaytics links later on). - Do the following steps both in the OPAC and the Intranet: - Search for the parent record in such a way that you can see the record in a *result list* - Check that the Show analytics link is displayed, and uses the title of the parent record for linking: ?q=Host-item:Title of parent record - Clik on the Show analytics link and check that you get a result list with the two child records you created earlier - Go back to the result list and click on the parent record, so you get the *detail view* - Check that the Show analytics link is displayed, and uses the title of the parent record for linking: ?q=Host-item:Title of parent record - Clik on the Show analytics link and check that you get a result list with the two child records you created earlier - Search for one or both of the child records in such a way that you can see the record(s) in a *result list* - Check that the In: Title of parent record link is displayed, and that it uses the biblionumber of the parent record for linking: ?q=Control-number:biblionumber of parent record - Click on the In: Title of parent record link, and check that the parent record is displayed - Go back to the result list and click on the child record, so you get the *detail view* - Check that the In: Title of parent record link is displayed, and that it uses the biblionumber of the parent record for linking: ?q=Control-number:biblionumber of parent record - Click on the In: Title of parent record link, and check that the parent record is displayed - Now edit the parent record and put it's biblionumber in 001. Repeat the steps above, and check that everything still works, but that the links are different: - The Show analytics link on the parent record should look like this: ?q=rcn:biblionumber of parent record+and+(bib-level:a+or+bib-level:b) - The In: Title of parent record link on the child records should be the same as it was earlier - Now set UseControlNumber = Don't use and repeat all of the steps above - All of the links should still be displayed and work, of course - The In: Title of parent record link on the child records should look like this: ?q=ti,phr:Title of parent record - The Show analytics link on the parent record should look like this: ?q=Host-item:Title of parent record - Change LDR/07 to s and repeat all of the steps above - Do all of this both for GRS-1 indexing and for DOM indexing... Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7518] searches with quotation marks don't work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #15 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA comment: I would welcome an improved handling of quotes. But look at this simple test: Searching for vermeer did work without this patch but now gives: Can't call method sort on an undefined value t /usr/share/koha/testclone/C4/Search.pm line 407. From the zebra log: WARNING: query problem with kw,wrdl= \\vermeer\\ ZOOM error 10014 CCL parsing error from diag-set 'ZOOM' at /usr/share/koha/testclone/C4/Search.pm line 359 Any chance of different results due to different Zebra config under MARC21/UNIMARC? Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9045] Adding some parameters to export_borrowers.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9045 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8034] Enable server print queue selection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #33) So you must catch the error raised by mysql if a printer is deleted and some branches use it. I can do that if you insist, however current version does not do that, ie does not check anything at all. This is an improvement as is. It is essential. The current version of this script is not reachable from any page. Without this catch, I get an error: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`branches`, CONSTRAINT `branches_ibfk_1` FOREIGN KEY (`branchprinter`) REFERENCES `printers` (`printqueue`) ON UPDATE CASCADE) at /home/koha/src/C4/Printer.pm line 144. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5888] opac-detail subject/author links improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Since some people find this feature cool and others not, I follow Katrin : a syspref could be an easy way to gain consensus. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Very useful patch! It adds a drop-down list with the number of displayed lines. Perhaps we would like to have a all entry, but browsers won't like this idea :) Code clean, few code. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9045] Adding some parameters to export_borrowers.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9045 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Nice addition! Two points of attention: Looking for a cardnumber that does not exist produces: DBD::mysql::st fetchrow_array failed: fetch() without execute() at ./export_borrowers.pl line 112. Please check if your query still has result records. Note that you should already do that on line 91 (first fetchrow). This may already give no results and a uninit warning in the log. Documentational note: Using a condition on a character field requires using quotes like: ./export_borrowers.pl -s @ -where surname='De Rooy' I would suggest explaining this in the usage statement with a simple example (not using the previous one :) Just for the record: The where clause coming from the command line is not checked, so could be misused (sql injection). Note that does not block this patch; more command-line scripts in misc contain similar constructs. Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #6) longoverdue.pl has its own command line switch to decide if a lost item should be returned or not. This patch only affects items marked as lost via moredetail.pl. I think it is easy to set the default value for the mark-returned parameter to the syspref's value instead of 0. Is there a good reason not to use it in this cronjob script? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Attachment #8233|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #14135|0 |1 is obsolete|| --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 15156 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15156action=edit Bug 9222: manual history reversed in subscription-detail.pl Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Trivial patch. Works as advertised. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Looks good. The patch removes some warning in the log file under Plack. No behavior changed under Apache. Note: some others warnings still exist (subroutine foo redefined). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15153|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15157 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15157action=edit Bug 9451: Quiet warnings and Plackify borrower_stats.pl There are several warnings and one non-Plack-compatible variable in reports/borrower_stats.pl. To test: 1) Apply patch 2) Use the borrower report wizard to create a report that includes an extended patron attribute. 3) Check the logs, and make sure that you don't see any of the following messages: Variable $period is not available at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 265. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 375. Use of uninitialized value in hash element at /home/jcamins/kohaclone/reports/borrowers_stats.pl line 376. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #14 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #12) Kyle: What do you think about this last patch? Do you agree with it? Fridolyn: Why do you remove the circulate_remaining_permissions permission? I think circulate_remaining_permissions is not needed when a permission exists for a page. Like it says in its name circulate_remaining_permissions is for pages that do not have a dedicated permission. Of course, giving only overdues permission will rarely be used. But we can imagine a librarian having only reports permissions, he can have only overdues permission to access the page (via a bookmark maybe) and not the rest of circulation module. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | QA Contact||m.de.r...@rijksmuseum.nl --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA: Looking at this one.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #14116|0 |1 is obsolete|| --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 15158 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15158action=edit Bug 9283 - Change structure of export checkouts form This patch changes the structure of the export checkouts form so that it is a little more linear. This change moves generation of the export options from JavaScript to the markup, eliminating an instance of dependence on YUI menus. To test, enable checkout exports by specifying a value for ExportWithCsvProfile or ExportRemoveFields. Load a patron with checkouts in circulation. Try the various checkout export options. Each should function correctly. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Looks even better now. Presentation moved to template instead of javascript/yui. Works as advertised. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Simple patch, it adds a new message at the OPAC if the borrower's card is nearly expired (depending on the NotifyBorrowerDeparture syspref). Works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14316|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15159 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15159action=edit Bug 9329: Wrong message for already expired cards Previously users would see the same message whether their card was about to expire or was already expired. This patch adds a new message to handle cards which are about to expire, following the NotifyBorrowerDeparture system preference. TEST PLAN : The best way to test would to have at the same time : - a SQL client to change the expiry date of a borrower - an OPAC session opened for the same patron. Case 1: expiry date is set in the future - no warning Case 2: expiry date is set in the near future (within the NotifyBorrowerDeparture system preference range) - a warning says the card will expire on **date** Case 3: expiry date is set in the past - before patch, same warning as Case 2 - after patch, new warning indicating that the card has expired Signed-off-by: Owen Leonard oleon...@myacpl.org Added description to the patch and copied test plan from the bug report. Patch passes test plan. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #12) Plack is not ready for production in my opinion, so I wasn't going to suggest it. Hi Jared, Why are you saying Plack is not ready for production ? we've it for the OPAC since 2 years. We're about to deploy it on staff interface at SAN-Ouest Provence. If there's some trouble I should expect, I prefer to know it ASAP ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Martin Renvoize martin.renvo...@ptfs-europe.com --- So i've been running through some customisations and patches that require rebuilding these dom config files... I'm using the script make_zebra_dom_cfg_from_record_abs as directed on http://wiki.koha-community.org/wiki/Switching_to_dom_indexing to create my new marc21 biblio-koha-indexdefs.xml config file: ~/kohaclone/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/record.abs --output ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xml However each time I run the script the ID line is removed from the resulting file and so this bug reasserts itself.. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9572] New: Opac info tooltip from branches is not well positioned
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9572 Bug ID: 9572 Summary: Opac info tooltip from branches is not well positioned Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de Created attachment 15160 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15160action=edit screenshot While testing new features in 3.10.2 I added following HTML code (sample opening times in German) to the OPAC info field of one of the branches: bÖffnungszeiten/b table tr tdMontag - Donnerstag/tdtd8-20 Uhr/td /tr tr tdFreitag/tdtd8-18 Uhr/td /tr /table In OPAC the tooltip shows up when hovering the mouse over the library name, but it's below the footer on the page and for that sometimes outside of view depending on the size of the browser window (see screenshot). It would be nice if the tooltip could be positioned closer to the library name/items table/mouse cursor. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Very simple patch. It fixes a specific case about holds. If a reserve is waiting, it is useless to display it in the holds to pull table. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14295|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15161 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15161action=edit Bug 9320 Pending reserves report should not show waiting items Test plan : * chose an item reserved by multiple patrons. * return the item and confirm reservation = item is waiting to be picked up * run circ/pendingreserves.pl = without patch, this item is shown in the list = with the patch, only really available items are show. Signed-off-by: Owen Leonard oleon...@myacpl.org Works according to test plan. The title with one waiting item appeared in pending holds report before the patch, doesn't appear after the patch. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665 --- Comment #17 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #16) So i've been running through some customisations and patches that require rebuilding these dom config files... I'm using the script make_zebra_dom_cfg_from_record_abs as directed on http://wiki.koha-community.org/wiki/Switching_to_dom_indexing to create my new marc21 biblio-koha-indexdefs.xml config file: ~/kohaclone/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/record.abs --output ~/kohaclone/etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xml However each time I run the script the ID line is removed from the resulting file and so this bug reasserts itself.. Am I missing something? Yes. You should not use the make_zebra_dom_cfg_from_record_abs script. I will update the wiki page to clarify that the script should not be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- That makes sense to me! (In reply to comment #14) (In reply to comment #12) Kyle: What do you think about this last patch? Do you agree with it? Fridolyn: Why do you remove the circulate_remaining_permissions permission? I think circulate_remaining_permissions is not needed when a permission exists for a page. Like it says in its name circulate_remaining_permissions is for pages that do not have a dedicated permission. Of course, giving only overdues permission will rarely be used. But we can imagine a librarian having only reports permissions, he can have only overdues permission to access the page (via a bookmark maybe) and not the rest of circulation module. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14680|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15162 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15162action=edit Bug 6898 - circulation librarians can't run overdues without reports permissions This patch adds a new user permission overdues_report for the circulation module, and requires this permission to run the overdue items report, rather than requiring full reports permissions. Test plan : With a user with permissions circulate_remaining_permissions : - Add overdues_report permission to user - Go to circulation home = you see Overdues link - Clik on it = you are allowed to access and use this page - Remove overdues_report permission to user - Go to circulation home = you do not see Overdues link - Edit URL : server/cgi-bin/koha/circ/overdue.pl = you are not allowed to access this page - Go to main page = you don't have access to reports module Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #17 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- I have to create a follow-up to have a better updatedatabase : when a user has report permissions, this new permission must be set. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170 --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #14) (In reply to comment #12) Plack is not ready for production in my opinion, so I wasn't going to suggest it. Hi Jared, Why are you saying Plack is not ready for production ? we've it for the OPAC since 2 years. We're about to deploy it on staff interface at SAN-Ouest Provence. If there's some trouble I should expect, I prefer to know it ASAP ! As I have said many, many times, there are still a lot of problems with Plack, especially on the staff client. I patch them as soon as I find them, of course, but libraries expect all the pages to Just Work. The largest problem I am having with running the staff client under Plack at this point are to do with holds. Many times when I try to delete a hold either manually or by filling it I get a MySQL error, and the hold gets stuck. I haven't debugged the problem enough to file a bug report yet, so my workaround has just been deleting all holds every so often. There is also the problem with staging MARC files for importing (I get a parseerror dialog every so often, but the upload works, and I still haven't figured out why). On top of that, almost every time I test a patch that touches a script I haven't used before, I have run into Plack problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9573] New: ability to download items lost report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Bug ID: 9573 Summary: ability to download items lost report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com It would be nice if the items lost report had downloadable results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7170] Remove use of XML::Simple
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7170
--- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com ---
(In reply to comment #11)
Hello
Does someone still work on this bug?
XML::Simple is still used by a lot of files.
Any change that could improve performances would be a good thing! (And yes,
I know Plack and Memcached ;-) )
Using Yaml instead of XML in some cases (particulary for Koha-conf) would
also be a GREAT thing ( some libraries don't want to use Memcached).
I did a lot of testing, and my conclusions were as follows:
1. YAML is much faster than XML.
2. XML::Simple with $ENV{'XML_SIMPLE_PREFERRED_PARSER'} == 'XML::SAX::ExpatXS'
is probably the best option for parsing the XML. XML::LibXML::Simple is a
more-or-less drop-in replacement, but it's not appreciably faster.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9332] Display call number in Holds waiting notice (checkout page)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9332 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: On the checkout page, the holds waiting list display the callnumber for each item (if exists). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9332] Display call number in Holds waiting notice (checkout page)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9332 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9332] Display call number in Holds waiting notice (checkout page)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9332 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #14339|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 15163 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15163action=edit Bug 9332: Display call number in Holds waiting notice When checking out from a patron page, a notice Holds waiting appears if a biblio (on hold) is waiting for this borrower. This patch adds the call number information to this warning. Signed-off-by: Owen Leonard oleon...@myacpl.org Nice little improvement, thanks. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9320] Pending reserves is showing reserves already waiting
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9320 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9329] Wrong message for already expired cards
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- Fridolyn, in the future please be sure to include commit messages, following the guidelines at http://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222 --- Comment #6 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #5) Fridolyn, in the future please be sure to include commit messages, following the guidelines at http://wiki.koha-community.org/wiki/Commit_messages Yes, I'm aware of it. This patch must have been made before I knew about it. Best regards. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9574] New: serials/subscription-add.pl does not work right under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574 Bug ID: 9574 Summary: serials/subscription-add.pl does not work right under Plack Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jcam...@cpbibliography.com When editing a subscription under Plack, the area for entering manual history appears regardless of whether you enabled manual history or not. I also get the following warnings in the log, one of which, presumably, is related to the problem: Use of uninitialized value $firstissuedate in string eq at /home/jcamins/kohaclone/serials/subscription-add.pl line 92. Use of uninitialized value $firstissuedate in substr at /home/jcamins/kohaclone/serials/subscription-add.pl line 105. Use of qw(...) as parentheses is deprecated at /home/jcamins/kohaclone/serials/subscription-add.pl line 95. Subroutine letter_loop redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 180. Subroutine _get_sub_length redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 195. Subroutine redirect_add_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 205. Variable $firstissuedate is not available at /home/jcamins/kohaclone/serials/subscription-add.pl line 338. Subroutine redirect_mod_subscription redefined at /home/jcamins/kohaclone/serials/subscription-add.pl line 274. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basket name in closed baskets reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 --- Comment #2 from Nicole C. Engard neng...@gmail.com --- Yes you are right. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9332] Display call number in Holds waiting notice (checkout page)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9332 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9551] OPACMobileUserCSS being overriden by OPACUserCSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9551 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9558] Customize CSS for mobile
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6035] Mobile interface for OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6035 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8620] Barcode searching not working correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 15164 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15164action=edit Patch for barcode missing in keyword search. This patch was worked through with Ian Bays using his suggestion of adding barcode to the any index for searching. To test 1. A pre patch search from the standard search box (either staff client or opac) for a barcode will not yield results. 2.A post patch search from the standard search box (either staff client or opac) for a barcode should yield the single record as a result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 15165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15165action=edit Proposed patch See commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #77 from Kyle M Hall k...@bywatersolutions.com --- The patch does not add permissions and userflags in the .sql files. I will address this + the datepicker module does not appear with your last patch (in my previous test, it worked!). That's odd, it's still working for me. Do you have the line Alias /plugin/ /var/lib/koha/plugins/ is you koha-http.conf file? Also, you'll need pluginsdir/var/lib/koha/plugins/pluginsdir enable_plugins1/enable_plugins in your koha-conf.xml file, so the plugins dir needs to match between the two. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9566] Only run analytics code if analytics are enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9566 --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Note that this problem can cause a really long response time (or even a timeout) for records with a lot of items like serials (because of search on hi index). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9283] Change structure of export checkouts form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9283 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14545|0 |1 is obsolete|| --- Comment #78 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15166 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15166action=edit [SIGNED-OFF] Bug 7804 - Add Koha Plugin System Adds support for custom plugins. At the moment the Plugins feature supports two types of plugins, reports and tools. Plugins are installed by uploading KPZ ( Koha Plugin Zip ) packages. A KPZ file is just a zip file containing the perl files, template files, and any other files neccessary to make the plugin work. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Create the directory /var/lib/koha/plugins 4) Add the lines pluginsdir/var/lib/koha/plugins/pluginsdir enable_plugins1/enable_plugins to your koha-conf.xml file 5) Add the line Alias /plugin/ /var/lib/koha/plugins/ to your koha-httpd.conf file 6) Restart your webserver 7) Access the plugins system from the More pulldown 8) Upload the example plugin file provided here 9) Try it out! Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14731|0 |1 is obsolete|| --- Comment #79 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15167 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15167action=edit [SIGNED-OFF] Bug 7804 - Add Koha Plugin System - Unit Tests Tests Ok ~/kohaclone$ perl t/db_dependent/Plugins.t 1..15 ok 1 - use Koha::Plugins; ok 2 - use Koha::Plugins::Handler; ok 3 - use Koha::Plugins::Base; ok 4 - use Koha::Plugin::Test; ok 5 - Test can_load ok 6 - Test plugin class isa Koha::Plugin::Test ok 7 - Test plugin parent class isa Koha::Plugins::Base ok 8 - Test plugin can report ok 9 - Test plugin can tool ok 10 - Test plugin can configure ok 11 - Test plugin can install ok 12 - Test plugin can install ok 13 - Test $plugin-get_metadata() ok 14 - Test $plugin-get_qualified_table_name() ok 15 - Test $plugin-get_plugin_http_path() (and all others as well) Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 --- Comment #80 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15168 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15168action=edit Bug 7804 - Add Koha Plugin System - QA Followup - Add flags and permissions sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #17) I have to create a follow-up to have a better updatedatabase : when a user has report permissions, this new permission must be set. Good point. Setting to 'Failed QA' for now. Kyle -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15169 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15169action=edit Bug 8484 - Add ability to choose if lost items are removed from a borrowers record. - Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15169|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15170 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15170action=edit Bug 8484 - Add ability to choose if lost items are removed from a borrowers record. - Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- I agree it would be better to control this behavior from one place in Koha. This patch removes the --mark-returned from longoverdue.pl and replaces it with the system preference. I think we should just note this in the upgrade instructions, as trying to support them both will end up with confusing behavior if the flag is not enabled, but the system pref is. Plus, it just adds more cruft to the code base. I've also renamed the system preference to be more in lie with Bug 7639, which ass the system preferences WhenLostForgiveFine and WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7639 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8484 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8733] Adding critic reviews to book pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #33 from Nicole C. Engard neng...@gmail.com --- I was going to document this, I have the preferences, but don't see the content when i turn them on ... is there maybe an updatedatabase problem here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9403] Material type icons not showing for XSLT default view in intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9403 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9403] Material type icons not showing for XSLT default view in intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9403 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #14683|0 |1 is obsolete|| --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Created attachment 15171 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15171action=edit [SIGNED-OFF] Bug 9403: Follow-up: Move Type in XSLT result list to match OPAC result list Moves the line starting with Type: upwards to show below the author line like it is in the OPAC XSLT result list. To test: 1) Make sure XSLTResultsDisplay and DisplayIconsXSLT are turned on. 2) Check that the line starting with Type is showing up below the title and 'by' lines. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9575] New: Serious Holds Problem with IndependantBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Bug ID: 9575 Summary: Serious Holds Problem with IndependantBranches Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com CC: gmcha...@gmail.com If IndependantBranches is enabled, all holds for an item display the currently logged in library no matter what, and modifying the holds will set all pickup locations for all the holds to that logged in library! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15172 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15172action=edit Bug 9575 - Serious Holds Problem with IndependantBranches Test plan: 1) Disable IndependantBranches 2) Place 3 holds on a record with 3 different pickup locations 3) Enable IndependantBranches 4) Refresh the holds page for that record, all the holds show now show a pickup location of the logged in branch 5) Modify the order of the holds 6) Disable IndependantBranches 7) Refresh the holds, verify the holds all now have a pickup location of the logged in branch 8) Apply the patch 9) Repeat steps 1-3 10) Refresh the holds page for that record, all the holds should now show the correct pickup branch, but it cannot be changed as IndependantBranches is enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 15173 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15173action=edit Bug 9571 [Alternate] Fix width for textareas in Edit Item screen This alternative patch modifies the script where the input markup is built and adds an alternative configuration for textareas. This gives the textareas explicit cols and rows attributes. I think this solution is preferable to a style fix because it solves the bug while eliminating some invalid markup (no size or maxlength attributes on textareas, which are invalid without explicit dimensions). To test, add a nice big chunk of text to an existing item's item field like Public note (952$z), save, and edit again. The field should now be displayed in a more comfortably-sized textarea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15152|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15174 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15174action=edit [SIGNED-OFF] Bug 9571 - Fix width for textareas in Edit Item screen This patch adds a style for textareas on the Edit Item screen of addbiblio.pl so that they are roughly the same length as the other input elements around it on the page. To test: Before applying patch... 1) Create a new item for any biblio with a URL (subfield u) of over 100 characters (you can use www.lettercount.com to count the number of characters in your URL). 2) In any browser (I've already looked at IE, Firefox, and Chrome on Windows), edit the item (either by clicking Edit Items from the Normal view of the bib record then clicking Edit next to the applicable item, or clicking on the Items view in the bib record and clicking Edit item next to the relevant item). 3) Notice that the textarea for the url is absolutely tiny. Difficult to read and difficult to interact with. Apply patch. 1) Notice that the textarea is roughly the same size as the other input elements on the page. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15173|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15175 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15175action=edit [SIGNED-OFF] Bug 9571 [Alternate] Fix width for textareas in Edit Item screen This alternative patch modifies the script where the input markup is built and adds an alternative configuration for textareas. This gives the textareas explicit cols and rows attributes. I think this solution is preferable to a style fix because it solves the bug while eliminating some invalid markup (no size or maxlength attributes on textareas, which are invalid without explicit dimensions). To test, add a nice big chunk of text to an existing item's item field like Public note (952$z), save, and edit again. The field should now be displayed in a more comfortably-sized textarea. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Both patches solve the issue. I'll leave it to QA to decent which one to use. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9555] Template files contain single quote strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15107|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15176 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15176action=edit Bug 9555: Template files contain single quote strings Test plan: - launch the test xt/single_quotes.t, there are 3 occurrences - apply this patch - launch the test. It will pass with success - Check that there is no regression on the 2 modified intranet files and the calendar still works at the OPAC. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9555] Template files contain single quote strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9555 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9554] single quote in didyoumean
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9554 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #15095|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15177action=edit Bug 9554: single quote in didyoumean When using url or uri template toolkit filters, I noticed that double quotes are escaped (%22), but not single quotes. This causes sometimes a problem when URL is written in JavaScript code, in a string delimited by single quotes. This patch corrects by using double quotes for js strings. Also, adds a test for didyoumean feature : when feature is not activated, do not add corresponding javascript. Test plan : - activate OpacHighlightedWords syspref - activate didyoumean feature for OPAC - perform a search begining with a single quote (ie 'sport) = look for javascript errors (you may use firebug) Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9554] single quote in didyoumean
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9554 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |normal --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- I'm upgrading this to a bug, as the existing behavior causes incompatibility with many SIP devices and services ( such as Overdrive ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9487] Allow items fields to be used in the HOLDPLACED notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9487 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9480] Set barcode width and height configurable with system preferences in patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9480 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Vitor, I'm not sure you understood Owen's question correctly. We think that instead of the height and width being set at the system wide level, they should be set in the same place you set font settings, barcode offset, etc. ( that is, in patroncards/edit-layout.pl ). I agree with Owen that this would be a better solution. (In reply to comment #5) Hi Owen, The height and width of barcode are automatically calculated by Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- I think giving patrons the freedom to type in anything will make it more complicated and confusing for some patrons. We could just add a new authorised value category instead. (In reply to comment #4) Do we need to have the purchase suggestion form ask for the item type in the first place? Not all libraries use item types that double as material types -- for example, if your item types are 'NORMAL', 'SHORT', 'NO_LOAN', that's not going to be of much use to the patron. So here's my counter-proposal: since suggestions.itemtype is a varchar(30) anyway, why not give it text input widgets instead of a drop-down list of item types, and maybe relabel it to make it clear that the library is asking for the preferred format (e.g., print, ebook, video, etc.). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9467] Use DataTables on catalog by item type report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9467 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14800|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15178 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15178action=edit Bug 9467 - Use DataTables on catalog by item type report page Replace the tablesorter plugin with the DataTables plugin on the catalog by item type report page. To test, run the catalog by item type report (Reports - Catalog by item type). Confirm that table sorting works correctly. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9467] Use DataTables on catalog by item type report page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9467 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9465] Use DataTables on update child to adult patron page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9465 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14798|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 15179 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15179action=edit Bug 9465 - Use DataTables on update child to adult patron page Replace the tablesorter plugin with the DataTables plugin on the update child to adult patron page. Added default sort by patron category description (ascending). To test, open a patron with a child category type. Choose the 'Update child to adult patron' item from the 'More' menu. Confirm that table sorting works correctly in the popup. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
