[Koha-bugs] [Bug 9581] New: physics

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9581

Bug ID: 9581
   Summary: physics
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: gmcha...@gmail.com
  Reporter: mrnoral...@hotmail.com
CC: m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4266] encumbrance and expenditure not used in code

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4266

--- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Yes, the data is saved. I tested it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9581] physics

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9581

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9380] branch not recording right on writeoff

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9380

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9582] New: Unused code in members/pay.pl

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9582

Bug ID: 9582
   Summary: Unused code in members/pay.pl
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: jcam...@cpbibliography.com

The subroutines writeoff() and get_writeoff_sth() (and the two package
variables $writeoff_sth and $add_writeoff_sth) defined in members/pay.pl do not
seem to be used at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9582] Unused code in members/pay.pl

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9582

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9582] Unused code in members/pay.pl

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9582

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 15208
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15208action=edit
Bug 9582: Remove unused code from members/pay.pl

The subroutines writeoff() and get_writeoff_sth() (and the two package
variables $writeoff_sth and $add_writeoff_sth) defined in members/pay.pl
are not used at all.

To test:
1) View members/pay.pl by looking at the record of a patron who has
   at least seven fines/fees and clicking the Pay fines tab after
   clicking the Fines tab on the left side
2) Write off a single item in the table on members/pay.pl using the
   button labelled Write off
3) Pay a single fine by clicking the Pay button
4) Pay a portion of a fine by selecting a checkbox on one of the lines
   in the table and clicking the Pay amount button
5) Select two lines in the table and click the Pay selected button
6) Write off all remaining fines

If all your actions show up in the table on the Account tab, this patch
works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9511] DOM indexing problem

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9511

Paul A pau...@aandc.org changed:

   What|Removed |Added

 CC||pau...@aandc.org

--- Comment #7 from Paul A pau...@aandc.org ---
I can confirm (3.8.5) that rebuild_zebra with the incremental option -z, the
biblio deletion does not occur; a full rebuild -b (with or without -x) is fully
functional but is a *necessity*.

This bug is [seriously?] compounded by overwriting a biblio with a Z39.50
import. This creates a second record in Zebra (not MySQL), identical
biblionumber, callnumber, intemnumber: see
http://opac.navalmarinearchive.com/cgi-bin/koha/opac-search.pl?idx=callnumq=GRLK-GREE-10

If a staff cataloguer is unaware of this bug and deletes the apparently
incorrect (old) record, this deletes the good MySQL record.

I therefore suggest upgrading this bug to critical.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Actually, the area for entering manual history always shows up, regardless
whether you're running under Plack or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9222] manual history reversed in subscription-detail.pl

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9222

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 15209
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15209action=edit
Bug 9574: Plack fixes for serials/subscription-add.pl

This patch fixes the following warnings under Plack:
* Use of uninitialized value $firstissuedate in string eq at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 92.
* Use of uninitialized value $firstissuedate in substr at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 105.
* Use of qw(...) as parentheses is deprecated at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 95.
* Variable $firstissuedate is not available at \
/home/jcamins/kohaclone/serials/subscription-add.pl line 338.

To test:
1) Create a subscription. Ensure that setting the first issue's
   publication date works.
2) Edit a subscription. Ensure that the first issue's publication
   date shows up.
3) Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9574] serials/subscription-add.pl does not work right under Plack

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9574

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
The manual history block showing up was already reported as bug 7608.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7608] Manual history is always 'enabled'

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608

--- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This was previously reported and supposedly fixed on bug 3908.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7608] Manual history is always 'enabled'

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7608] Manual history is always 'enabled'

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 15210
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15210action=edit
Bug 7608: Manual history should not always be enabled

When editing a subscription, the manual history block is visible even
if the subscription was created with manual history off.

To test:
1) Create a subscription and do not check the Manual history checkbox.
2) Save the subscription.
3) Edit the subscription. Note that the manual history section does not
   appear.
4) Enable manual history. Note the appearance of the manual history
   section.
5) Save the subscription.
6) Edit the subscription. Note that the manual history section appears.
7) Click [cancel manual history]. Note the disappearance of the manual
   history section, and the unchecking of the Manual history checkbox.
8) Sign off on patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9301] Search to Hold no longer passing through patron name

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9301

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Seems to be working in all circumstances in current master. Will reopen if I
come across it again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9090] Cannot add item without barcode

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9090

Liz Rea (CatalystIT) l...@catalyst.net.nz changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from Liz Rea (CatalystIT) l...@catalyst.net.nz ---
Unable to replicate - no reason to have it hanging out there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9451] borrower_stats.pl gives off warnings and is not Plack-compatible

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9451

--- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz ---
Comment on attachment 15157
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15157
Bug 9451: Quiet warnings and Plackify borrower_stats.pl

Review of attachment 15157:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9451attachment=15157)
-

::: reports/borrowers_stats.pl
@@ +56,4 @@
  $filters[3]=format_date_in_iso($filters[3]);
  $filters[4]=format_date_in_iso($filters[4]);
  my $digits = $input-param(digits);
 +our $period = $input-param(period);

Hmm, i still think our is kinda hacky, but it works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Tigran,

try increasing the value in the system preference FacetLabelTruncationLength.
Your broken characters always show up where the system cuts of the string - so
this could fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results'

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Please reopen if that does not solve your problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I confirm the data loss upon edit/save. I recently ran into it again...
I think adding the missing fields and hiding unused/deprecated fields would be
great.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] New: OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

Bug ID: 9583
   Summary: OPAC cart button display problem in Chromium
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de

Created attachment 15211
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15211action=edit
screenshot

In chromium the cart button is node wide enough for the icon and the text.
(see screenshot)

This appeared in Chromium 0.88.1 in Ubuntu.
In Firefox 18.0.2 on the same system the display is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8661] break out additional authors in opac like in staff

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
A few notes about this feature:

1) I am not a big fan about the punctuation at the end, I think for the normal
OPAC user this does not look right (given you don't know about MARC and all
that). Plus: they are explicitly added and not in my data.

+  xsl:when
test=position()=last()xsl:text./xsl:text/xsl:whenxsl:otherwise

2) Author(s) - the way we indicate plural/singular here is not used for any
other label. For the other labels we just use plural form or singular. So this
is a bit inconsistent.

3) I would love if it would be possible to hide the [edt] and similar from
display. The codes are not translatable and a lot of them are not an easy guess
for a normal user.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8661] break out additional authors in opac like in staff

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15146|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15212
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15212action=edit
[SIGNED-OFF] Bug 8661 [Revised] break out additional authors in opac like

This patch takes the simple route of copying over the markup
for displaying authors from the staff client XSL to the OPAC.

Revision moves the position of the authority detail icon so
that it falls inside delimiting punctuation.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.
Some notes about possible enhancements were added to the bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9582] Unused code in members/pay.pl

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9582

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Comment on attachment 15208
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15208
Bug 9582: Remove unused code from members/pay.pl

Review of attachment 15208:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9582attachment=15208)
-

This code looks ok, I haven't tested it you though so not signing off, but
passing initial code review

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

--- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Testing this now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8913] Improve acquisitions navigation

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8913

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Owen,

I found a problem:
1) Delete vendor button shows up on some pages. The button should only show
up when no baskets have been created for vendor yet.

Pages I found the problem are:
/cgi-bin/koha/acqui/uncertainprice.pl?booksellerid=2owner=1
/cgi-bin/koha/admin/aqcontract.pl?booksellerid=2

2) The new invoices page is missing the toolbar. If you want to add it there
too, this could be a separate bug.

Failing QA, because 1) could cause trouble. Can you please fix in a follow-up?
Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9323] Untranslatable string in serials search

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9323] Untranslatable string in serials search

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9323

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
(In reply to comment #0)
 Created attachment 15211 [details]
 screenshot
 
 In chromium the cart button is node wide enough for the icon and the text.
 (see screenshot)
 
 This appeared in Chromium 0.88.1 in Ubuntu.
 In Firefox 18.0.2 on the same system the display is correct.

I've had the same problem with Chrome 24.0.1312.57 m on Windows Vista and
Windows 8.

IE 9 and Firefox 18.0.2 were fine. 

Last I checked, 8 Feb 2013, 3.10.x was displaying the cart fine. It was just
not working on the most recent master.

Using the Chrome dev tool, I noticed that one of the i elements in the cart
span had a height of 18px (for reasons I cannot explain), and that seemed to be
messing things up. If I deleted that element, it looked perfect again. 

The height doesn't seem to come from any CSS that I can see though, so I assume
there was an update to the Javascript at some point recently, and that had an
impact on Chrome/Chromium, although I'm not sure why. 

I wonder if this happened before or after the Jquery libraries were moved?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
All is normal if you go back before Bug 9265 were pushed
(git reset --hard a8355ce), so is something on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

--- Comment #3 from David Cook dc...@prosentient.com.au ---
(In reply to comment #2)
 All is normal if you go back before Bug 9265 were pushed
 (git reset --hard a8355ce), so is something on it.

Agreed, Bernardo. I found the same thing when I did some trial and error in
master. 

When I change the DOCTYPE back to the XHTML transitional, the OPAC cart button
displays correctly again. When I revert it back to the HTML5 short doctype, it
creates the display problem again.

I tried the !DOCTYPE html SYSTEM about:legacy-compat doctype as well in
case Chrome might be happier with that, but the display problem still occurs. 

In the HTML5 differences from HTML4, I noticed the following bit of text: 

The i element now represents a span of text in an alternate voice or mood, or
otherwise offset from the normal prose in a manner indicating a different
quality of text, such as a taxonomic designation, a technical term, an
idiomatic phrase from another language, a thought, or a ship name in Western
texts.

While I assumed this was more of a policy difference, I wonder if it's
possible that Chrome treats the i element differently because of the different
doctype?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9571] Fix width for textareas in Edit Item screen

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9571

--- Comment #7 from David Cook dc...@prosentient.com.au ---
(In reply to comment #3)
 Created attachment 15173 [details] [review]
 Bug 9571 [Alternate] Fix width for textareas in Edit Item screen
 
 This alternative patch modifies the script where the input markup is
 built and adds an alternative configuration for textareas. This gives
 the textareas explicit cols and rows attributes. I think this
 solution is preferable to a style fix because it solves the bug while
 eliminating some invalid markup (no size or maxlength attributes on
 textareas, which are invalid without explicit dimensions).
 
 To test, add a nice big chunk of text to an existing item's item field
 like Public note (952$z), save, and edit again. The field should now
 be displayed in a more comfortably-sized textarea.

I like the idea of using explicit cols and rows. I wasn't sure whether it
would be preferable to do that or use CSS, so I went with the latter.

I think it might be an idea to increase the number of cols to 69 or so, so
that it is closer to the length of the other input fields, but I might just be
in favour of that number, because it looks better on my monitor. The same might
not be true for others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
The extra markup added by JavaScript in doc-head-close.inc is extraneous and
should have been removed when we changed the way the buttons are constructed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9583] OPAC cart button display problem in Chromium

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9583

--- Comment #5 from David Cook dc...@prosentient.com.au ---
(In reply to comment #4)
 The extra markup added by JavaScript in doc-head-close.inc is extraneous and
 should have been removed when we changed the way the buttons are constructed.

Owen, is the extra mark-up the 2 empty i elements, and 2 empty span elements
(one with an id of carticon)?

If so, I'll submit a patch to remove them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9584] New: Remove problematic IE CSS Hacks in staff client

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584

Bug ID: 9584
   Summary: Remove problematic IE CSS Hacks in staff client
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au

Currently, there are several CSS rules, which are hacks for IE versions 7 and
older, in staff-global.css. 

Within these, the hidden overflow property for *HTML BODY is cutting off
lengthy content in search results, managing labels, etc. This prevents users
from seeing the full pages of results, and prevents them from paging over for
more results. 

While we might not want to support older versions of IE, this is problematic
behaviour, and it shouldn't be happening. I'm not sure of the origin of these
hacks, but it looks like we should remove them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9584] Remove problematic IE CSS Hacks in staff client

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9584

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 15214
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15214action=edit
Bug 9584 - Remove problematic IE CSS Hacks in staff client

To test:

Before applying patch...

1) Open up Internet Explorer 6 or a newer version of Internet Explorer and
use the F12 Developer Tools to change the Document Mode to Quirks Mode
2) Conduct a search on the staff client that will generate a high number of
hits. (e.g. e as an unlimited query, if you have a maximum of a few thousand
records.)
3) Note that you can't access the page options at the bottom of the page
and that your result list is cut off at the bottom, and thus inaccessible.

Apply patch...

4) Refresh your browser (preferably using F5 or whatever other method you
use to bypass the browser's cache), and re-run the search if necessary
5) Note that you are now able to see the full page of search results, plus
the paging at the bottom

As far as I can tell, there are no regressions, but feel free to search for
them. Afaik, there are no doc1 or doc2 ids, and I can't see any problems with
any elements with doc3 IDs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9585] New: Fix spelling mistake in default tab conditional for opac-detail

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585

Bug ID: 9585
   Summary: Fix spelling mistake in default tab conditional for
opac-detail
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au

There is just a small typo where one of the results of a conditional is
subscription rather than subscriptions.

If this comes up, the correct tab (subscriptions) will not be chosen. 

I'm not sure what will happen...it'll probably just have the holdings,
subscriptions, and serial collection tabs all default to closed with none
of them being open.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9585] Fix spelling mistake in default tab conditional for opac-detail

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9585

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 15215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15215action=edit
Bug 9585 - Fix spelling mistake in default tab conditional for opac-detail

Test Plan:

The easiest way to test is just to double-check the other strings in the
conditional which say subscriptions rather than subscription.

You can also look at opac-detail.tt where the param is shown, and note that
there is no condition for subscription - just subscriptions.

Any tests other than that would be overly complex for such a trivial patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9586] New: Remove $ENV{DEBUG} info from Member Template

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586

Bug ID: 9586
   Summary: Remove $ENV{DEBUG} info from Member Template
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: dc...@prosentient.com.au

Currently, if $ENV{DEBUG} is set (for example to 1), the debug level will be
printed on the Add/Edit Patron pages (memberentrygen.tt) in the form of: Debug
is on (level 1).

While many if not most folks might not set $ENV{DEBUG} on a production system,
there is no reason to have this information printing on the member template(s).

No where else in Koha is there a template that prints $ENV{DEBUG} information,
with the exception of calendar.inc, although that doesn't activate until at
least debug level 2 or 5, so it might be worth holding on to. It is certainly
more complicated than simply printing the debug level. I don't do development
on the calendars, so I'm not going to address that one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9586] Remove $ENV{DEBUG} info from Member Template

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9586

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 15216
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15216action=edit
Bug 9586 - Remove $ENV{DEBUG} info from Member Template

Test Plan:

Before applying patch...

1) Modify koha-httpd.conf, and add the following line, in the virtualhost
(if it does not already exist):

SetEnv DEBUG 1

2) Restart/reload Apache

3) Go to Add a New Patron
4) Note that the message Debug is on (level 1) appears at the top of the
page above the patron entry form

After applying patch...

5) Reload the patron add/edit page
6) Note that the message Debug is on (level 1) no longer appears

7) Change your koha-httpd.conf settings back as necessary...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15063|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15217action=edit
[SIGNED-OFF] Bug 9395: Problem with callnumber and standard number searches

This problem happens because there isn't a operator phr in the values
of callnumber and standard number search. So many results aren't the
corrects ones.

Test plan:

- Apply the patch
- In the dropbox search menu of OPAC main page header, the callnum
  should have only callnum
- In OPAC advanced search the callnumber and standard number options
  shouldn't have phr
- In staff client advanced search the callnumber and standard number
  options shouldn't have phr
- Change OPACNumbersPreferPhrase and IntranetNumbersPreferPhrase to use
- The options listed before should use now the operator phr
- This will resolve the problems with the searches of callnumbers and
  standard numbers in OPAC and staff client (spaces problems, no
  results, inconsistent results, etc...)

Sponsored-by: KEEP SOLUTIONS
Signed-off-by: Owen Leonard oleon...@myacpl.org

I don't know how to reproduce the searching problems described in the
bug, but I can confirm that the patch works correctly to enable/disable
the use of 'phr' in the searches described in the test plan.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
System preferences work as described, switching indexes in
OPAC and staff.
All tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9395] Problem with callnumber and standard number search in OPAC and Staff Client

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9395

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6413] Notes in Fines doing wonky things

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #57 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
The patch conflicts now because the fix for recording payments in the logs.
Kyle or Chris - can you please resolve the conflicts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

--- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15219
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15219action=edit
Bug 7253: followup : manage toolbar for fastcataloging

During fast cataloging, hide some toolbar menus of biblio edition page :
- Save and view record
- Z3950 Search
- Framework change
Also display (fast cataloging) in biblio and item editon.

Signed-off-by: koha.aixmarseille koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.

Tested:
- adding a fast add with duplicate and without
- adding a new record, checked toolbar showed up correctly
- editing existing record, checked toolbar showed up correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15218|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15220action=edit
Bug 7253: fast cataloging not always checking out

When using fast cataloguing to create a biblio and item on the fly, workflow
looses datas when a duplicate is detected.
This comes from the use of a mix of circborrowernumber and borrowernumber in
forms.

This patch corrects by using always circborrowernumber in fast cataloguing
workflow.
Also adds html and uri escape for barecode where necessery.

Test plan :
With duplicate :
- Go to a borrower circulation page
- Enter a non existing barcode
- Enter a due date
- Click on Check Out
= a message says the barcode was not found
- Click on Fast cataloguing
= The biblio edition page appears with fast cataloguing framework
- Fill mandatory fields by using an existing ISBN
- Click on Save
= a yes/no message says Duplicate record suspected
(Choosing yes will brake fast caloguing workflow, in this case librarian should
create an item and checkout again)
- Click on No
= The item edition page appears with barcode already filled
- Fill mandatory datas
- Click on Add item
= Borrower circulation page appears again, check that item has been checked
out with the specified due date

You may test without duplicate

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
Tested following the plan and by fast cataloging a non-duplicate.
All works as expected.

Signed-off-by: koha.aixmarseille koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #15219|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15221
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15221action=edit
Bug 7253: followup : manage toolbar for fastcataloging

During fast cataloging, hide some toolbar menus of biblio edition page :
- Save and view record
- Z3950 Search
- Framework change
Also display (fast cataloging) in biblio and item editon.

Signed-off-by: koha.aixmarseille koha.aixmarsei...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script.

Tested:
- adding a fast add with duplicate and without
- adding a new record, checked toolbar showed up correctly
- editing existing record, checked toolbar showed up correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7253] fast cataloging not always checking out

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7253

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|koha.sek...@gmail.com   |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9105] Moving Z3950 search code to Breeding.pm

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #14701|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 15222
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15222action=edit
9105: Followup for closing Zoom connections

Housekeeping: close the results sets and connections from Z3950 searches.
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
No regression found, all tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9105] Moving Z3950 search code to Breeding.pm

2013-02-10 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9105

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact|paul.poul...@biblibre.com   |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/