[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Srikanth Dhondi  changed:

   What|Removed |Added

  Attachment #13385|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Srikanth Dhondi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Srikanth Dhondi  ---
Fixed the typos and done some testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

--- Comment #5 from Srikanth Dhondi  ---
Created attachment 15312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15312&action=edit
Bug 9043 - Changes to the advanced search page

Added system preferences to enable control of elements that are to be displayed
on the advanced search page.

* New system preferences were added to control the display of

a) Publication date range
b) Item type selection
c) Language selection
d) Location and Availability
e) Sorting options
f) Subtype limits

elements.

* This patch preserves the current default settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Srikanth Dhondi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #1 from Srikanth Dhondi  ---
Created attachment 15311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15311&action=edit
Bug 9611 - Changing the hashing algorithm from MD5 to Bcrypt

What this patch aims to accomplish?

 * All new passwords are stored as Bcrypt-hashes

 * For password verification:

 - If the user was created before this patch was applied then use MD5 to
hash the entered password <-- backwards compatibility

 - If the user was created after this patch was applied then use Bcrypt to
hash the entered password

 * Any password change will be automatically Bcrypt-hashed, this applies to old
members whose passwords were stored as MD5 hashes previously

Test plan:

  1) Add new users and check whether their passwords are stored as Bcrypt
hashes or not

  2) To test that authentication works for both old as well as new members

   a) Login as an existing user whose password is stored as a MD5 hash

   b) Login as an existing user whose password is stored as a Bcrypt hash

  3) Change the password of an existing member whose password is stored as an
MD5 hash

a) Check the new password is stored as a Bcrypt-hash in the database

b) Try to login with the new password

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Srikanth Dhondi  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Nicole C. Engard  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #9 from Nicole C. Engard  ---
I got asked about this again today, this is still a desired enhancement.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #38 from David Cook  ---
(In reply to comment #36)
> > 1) This patch doesn't apply to the staff client, so library staff are still
> > restricted to 1 hold per patron per record, even with the new system
> > preference set to 3.
> 
> It sounds like you forgot to apply the patch for Bug 9394 first, this bug
> depends on bug 9394.
>  
> > 2) This patch does apply to the OPAC. You are able to place holds (as the
> > patron) on 3 items in a record when you have the system preference set to 3.
> > However, when you try to place a 4th hold, the error message that appears 
> > is:
> > 
> > "Sorry, none of these items can be placed on hold."
> > 
> > "Title / by Author. This title cannot be requested."
> 
> Fixed!
> 
> > Stylistically, I think the Javascript warning on the staff client when
> > exceeding the maximum number of holds could be improved.
> > 
> > Currently, it is:
> > 
> > "This patron has already placed the maximum number of holds for this record
> > Please cancel a previous hold first"
> > 
> > These two sentences should have periods at the end and be separated with
> > another new line. 
> 
> Also fixed!

As a side note, it might be helpful to include "first apply Bug 9394" in the
test plan :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #37 from David Cook  ---
(In reply to comment #36)
> > 1) This patch doesn't apply to the staff client, so library staff are still
> > restricted to 1 hold per patron per record, even with the new system
> > preference set to 3.
> 
> It sounds like you forgot to apply the patch for Bug 9394 first, this bug
> depends on bug 9394.
>  
> > 2) This patch does apply to the OPAC. You are able to place holds (as the
> > patron) on 3 items in a record when you have the system preference set to 3.
> > However, when you try to place a 4th hold, the error message that appears 
> > is:
> > 
> > "Sorry, none of these items can be placed on hold."
> > 
> > "Title / by Author. This title cannot be requested."
> 
> Fixed!
> 
> > Stylistically, I think the Javascript warning on the staff client when
> > exceeding the maximum number of holds could be improved.
> > 
> > Currently, it is:
> > 
> > "This patron has already placed the maximum number of holds for this record
> > Please cancel a previous hold first"
> > 
> > These two sentences should have periods at the end and be separated with
> > another new line. 
> 
> Also fixed!

Thanks for the style changes. Much appreciated!

However, there still seem to be some bugs:

Staff Client: It is possible to put 3 holds on the same item.

OPAC: It is possible to put 3 holds on the same item. PLUS, it is impossible to
cancel any holds (N.B. you can still cancel holds in the staff client though).
I'm not sure if this is a result of 7710 or 9394 though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9394] Use reserve_id where possible

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9611] New: Changing the password hashing algorithm from MD5 to more secure Bcrypt

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Bug ID: 9611
   Summary: Changing the password hashing algorithm from MD5 to
more secure Bcrypt
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: srika...@catalyst.net.nz
CC: dpav...@rot13.org

In the current version of Koha, the passwords are stored as md5 hashes. MD5
hashing has its limitations, changing the hashing method to Bcrypt will improve
in more secure password storage.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9394] Use reserve_id where possible

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #7 from David Cook  ---
(In reply to comment #6)
> Created attachment 14863 [details] [review]
> Bug 9394 - Use reserve_id where possible
> 
> This patch switches from using a combination of
> biblionumber/borrowernumber to using reserve_id where possible.
> 
> Test Plan:
> 1) Apply patch
> 2) Run t/db_dependent/Holds.t

I tried running the test, but it spat out quite a few errors/fails. I'm not
sure if this is a problem with the test or my database though...

Here are the test results:

t/db_dependent/Holds.t .. 1/18 # Creating biblio instance for testing.
# Creating item instance for testing.
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`...`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY
(`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at
.../lib//C4/Items.pm line 2105.
t/db_dependent/Holds.t .. 2/18
#   Failed test 'Test GetReservesFromItemnumber()'
#   at t/db_dependent/Holds.t line 68.

#   Failed test 'Test CancelReserve()'
#   at t/db_dependent/Holds.t line 80.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 92.

#   Failed test 'Test GetReserve(), priority changed correctly'
#   at t/db_dependent/Holds.t line 92.

#   Failed test 'Test GetReserve(), suspend hold'
#   at t/db_dependent/Holds.t line 93.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 94.

#   Failed test 'Test GetReserve(), suspend until date'
#   at t/db_dependent/Holds.t line 94.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 102.

#   Failed test 'Test ToggleSuspend(), with date'
#   at t/db_dependent/Holds.t line 102.
DBD::mysql::st execute failed: Column 'borrowernumber' cannot be null at
.../lib//C4/Reserves.pm line 198.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 126.
Use of uninitialized value $itemnumber in string eq at t/db_dependent/Holds.t
line 126.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 130.
Use of uninitialized value in string eq at t/db_dependent/Holds.t line 130.
# Deleting holds.
# Deleting item testing instance.
DBD::mysql::st execute failed: You have an error in your SQL syntax; check the
manual that corresponds to your MySQL server version for the right syntax to
use near '' at line 1 at .../lib//C4/Items.pm line 2295.
# Deleting biblio testing instance.
# Looks like you failed 6 tests of 18.
t/db_dependent/Holds.t .. Dubious, test returned 6 (wstat 1536, 0x600)
Failed 6/18 subtests

Test Summary Report
---
t/db_dependent/Holds.t (Wstat: 1536 Tests: 18 Failed: 6)
  Failed tests:  3, 6-9, 11
  Non-zero exit status: 6
Files=1, Tests=18,  2 wallclock secs ( 0.05 usr  0.01 sys +  0.82 cusr  0.15
csys =  1.03 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5366] Standing enh req for code changes enabling database agnosticism

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366

Dobrica Pavlinusic  changed:

   What|Removed |Added

 CC||dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9610] Spanish translation of MARC21 default bibliographic framework

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9610

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9610] Spanish translation of MARC21 default bibliographic framework

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9610

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 15310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15310&action=edit
Bug 9610 - Spanish translation of MARC21 default bibliographic framework

This (large) patch adds spanish translation to default
MARC21 bibliographic frameworks.

Based on final EN default framework of Bug 5858,
strings from http://www.bne.es/es/Micrositios/Guias/Marc21/index.html

Automated substitution of strings, to change as
little as possible the original file and ensure
that no entry is removed.

Only to new installs.

To test
1) Delete default framework.
2) Load
installer/data/mysql/es-ES/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.sql
   into database. Must load without errors.
3) Edit a record y choose default framework, legends must be in spanish
   (save for obsoleted fields, left untranslated on pourpose)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9610] New: Spanish translation of MARC21 default bibliographic framework

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9610

Bug ID: 9610
   Summary: Spanish translation of MARC21 default bibliographic
framework
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P1 - high
 Component: I18N/L10N
  Assignee: bgkrie...@gmail.com
  Reporter: bgkrie...@gmail.com
CC: frede...@tamil.fr

Default bibliographic framework needs Spanish translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9408] make test fails on master

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9607] pagination wrong if OPACShowUnusedAuthorities set to "don't show"

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #3 from Chris Cormack  ---
(In reply to comment #2)
> Can't it be low priority instead of 'wontfix'? A fix would be good.

Awesome you are volunteering to fix it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9408] make test fails on master

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9408

abhijit  changed:

   What|Removed |Added

 CC||myd...@yahoo.in

--- Comment #3 from abhijit  ---
same error occured


PERL_DL_NONLAZY=1 KOHA_CONF=blib/KOHA_CONF_DIR/koha-conf.xml /usr/bin/perl
"-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/PERL_MODULE_DIR',
'blib/arch')" t/*.t
t/00-checkdatabase-version.t  ok   
t/00-deprecated.t ... ok   
t/00-load.t . 1/? "my" variable $stylesheet masks
earlier declaration in same scope at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Record.pm line 313.
t/00-load.t . 51/? Subroutine main::GetContract
redefined at /usr/share/perl/5.14/Test/More.pm line 885.
Too late to run INIT block at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/hbyymmincr.pm line 41.
Too late to run INIT block at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/External/BakerTaylor.pm line 42.
"my" variable $DEBUG masks earlier declaration in same scope at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 43.
"my" variable $DEBUG masks earlier declaration in same scope at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 77.
t/00-load.t . ok 
t/00-merge-conflict-markers.t ... ok  
t/00-testcritic.t ... skipped: Author test. Set $ENV{TEST_QA}
to a true value to run
t/00-valid-xml.t  ok 
t/AuthoritiesMarc_MARC21.t .. ok   
t/AuthoritiesMarc_UNIMARC.t . ok   
t/Barcodes_annual.t . ok   
t/Barcodes_EAN13.t .. ok   
t/Barcodes_hbyymmincr.t . ok   
t/Barcodes_incremental.t  ok   
t/Barcodes_PrinterConfig.t .. 1/6 Use of uninitialized value
$labelHeigth in division (/) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 113.
Use of uninitialized value $marginBottom in addition (+) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 113.
Use of uninitialized value $labelHeigth in multiplication (*) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 115.
Use of uninitialized value $rows in numeric lt (<) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 117.
Use of uninitialized value $labelWidth in division (/) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $marginLeft in addition (+) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $labelWidth in multiplication (*) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 86.
Use of uninitialized value $columns in numeric lt (<) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 88.
Use of uninitialized value $labelHeigth in division (/) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 113.
Use of uninitialized value $marginBottom in addition (+) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 113.
Use of uninitialized value $labelHeigth in multiplication (*) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 115.
Use of uninitialized value $labelWidth in division (/) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $marginLeft in addition (+) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 84.
Use of uninitialized value $labelWidth in multiplication (*) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 86.
Use of uninitialized value $rows in numeric le (<=) at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/PrinterConfig.pm line 193.
t/Barcodes_PrinterConfig.t .. ok   
t/Barcodes_ValueBuilder.t ... "my" variable $DEBUG masks earlier
declaration in same scope at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 43.
"my" variable $DEBUG masks earlier declaration in same scope at
/build/koha-3.10.02/blib/PERL_MODULE_DIR/C4/Barcodes/ValueBuilder.pm line 77.
t/Barcodes_ValueBuilder.t ... ok 
t/Bookseller.t .. ok   
t/Boolean.t . 1/13 The given value does not seem to be
interpretable as a Boolean value at t/Boolean.t line 20.
The given value does not seem to be interpretable as a Boolean value at
t/Boolean.t line 21.
The given value does not seem to be interpretable as a Boolean value at
t/Boolean.t line 22.
t/Boolean.t . ok 
t/Branch.t .. ok   
t/Breeding.t  ok   
t/Budgets.t . ok   
t/Cache.t ..

[Koha-bugs] [Bug 7710] multiple holds per title

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9522] Koha returns <, >, etc in the record instead of <, >, etc when fulfilling a Z39.50 request

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522

--- Comment #5 from Joseph Alway  ---
I ran the command "sudo koha-rebuild-zebra -f kohatest" in a test machine and
that seemed to fix the problem. When I ran the command for my production
machine it did not do anything. They both should be setup the same.

The only thing I did different in my test machine is that I commented out the
opt_xml lines in the file /usr/sbin/koha-rebuild-zebra. That didn't seem to do
anything, so I put it back the way it was originally by removing the comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2352] Improve information about uninstalled CPAN modules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2352

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Chris Cormack  ---
Yep, I agree

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9502] famfamfam: wrongly placed in package 3.8.8/9

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9502

Chris Cormack  changed:

   What|Removed |Added

  Attachment #15308|0   |1
is obsolete||
 Status|Needs Signoff   |Signed Off
   Assignee|ro...@catalyst.net.nz   |ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack  ---
Created attachment 15309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15309&action=edit
Signed off patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9502] famfamfam: wrongly placed in package 3.8.8/9

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9502

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Severity|major   |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9502] famfamfam: wrongly placed in package 3.8.8/9

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9502

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Patch complexity|--- |Trivial patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9502] famfamfam: wrongly placed in package 3.8.8/9

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9502

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 15308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15308&action=edit
Bug 9502 - famfamfam wronly linked in 3.8.x

famfamfam icon set was moved from 'prog' to 'lib' but there still are wrong
references to the old path. This patch fixes it.

Note: it is not a .deb packages problem but a more general one.

Sponsored-by: Universidad Nacional de Córdoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9608] white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9608] white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #15306|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 15307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15307&action=edit
[SIGNED-OFF] Bug 9608 - White background on header on check in

The white background behind the header search form on the checkin
page appears because the search include is missing a  which carries
the background gradient CSS. This patch adds the missing markup to the
checkin search header include file and 6 others.

To test, view the following pages and confirm that the normal gradient
background appears behind the header search form:

- Checkin
- Contracts administration
- Currencies administration
- Notices and slips
- Printers administration (admin/printers.pl)
- Stop words administration (admin/stopwords.pl)
- Adding an order to a basket from a suggestions (Acquisitions -> Basket
  -> Add order to basket -> From a suggestions).

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9607] pagination wrong if OPACShowUnusedAuthorities set to "don't show"

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607

--- Comment #2 from Nicole C. Engard  ---
Can't it be low priority instead of 'wontfix'? A fix would be good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

--- Comment #27 from Zeno Tajoli  ---
Hi Elliot,
 could check the instructions to test the patch ?
I will the the commit but I need instructions.
I don't know EDIfact

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2352] Improve information about uninstalled CPAN modules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2352

Fridolyn SOMERS  changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolyn SOMERS  ---
This is fixed by koha_perl_deps.pl no ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9608] white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

--- Comment #1 from Owen Leonard  ---
Created attachment 15306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15306&action=edit
Bug 9608 - White background on header on check in

The white background behind the header search form on the checkin
page appears because the search include is missing a  which carries
the background gradient CSS. This patch adds the missing markup to the
checkin search header include file and 6 others.

To test, view the following pages and confirm that the normal gradient
background appears behind the header search form:

- Checkin
- Contracts administration
- Currencies administration
- Notices and slips
- Printers administration (admin/printers.pl)
- Stop words administration (admin/stopwords.pl)
- Adding an order to a basket from a suggestions (Acquisitions -> Basket
  -> Add order to basket -> From a suggestions).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9608] white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9608] white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

Owen Leonard  changed:

   What|Removed |Added

  Attachment #15287|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 15305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15305&action=edit
[SIGNED-OFF] Bug 9603 - Fix layout of Patron Card Creator Layout screen for
display in IE

Currently, the layout for the Edit/Add Layout screen of the Patron Card
Creator is in complete disarray, when viewed in Internet Explorer (of
any version).

This patch removes empty and extraneous fieldset and li elements. It
also adds ol elements to all of the nested li elements, which were
creating layout problems in IE, especially when they were interwoven
with div elements. IE had problems opening and closing tags, which
created some major chaos.

This patch also adds stylistic spacing/nesting to the HTML, so that it
is easier to visually separate elements when debugging. 99.9% of the
mods in this patch are actually just whitespace alterations.

Test Plan:

Before applying the patch:

1) Open Koha using any version of Internet Explorer
2) Go to the Patron Card Creator in the Tools module
3) Go to Manage Layouts
4) Add or Edit a layout
5) Note that all the elements on the page are presented in haphazard
   fashion with the navbar pushed to the bottom of the page.

Apply the patch.

6) Refresh the page
7) Note that the elements are now laid out on the page in the same
   way that they would appear in a modern browser like Firefox or
   Chrome (look at the same page in one of those browsers to
   confirm).

Signed-off-by: Owen Leonard 

I don't like all the whitespace changes in this patch. Making whitespace
changes as well as code/markup changes is generally speaking a violation
of coding guidelines. However, this is not a frequently-modified
template and a diff which ignores whitespace changes shows that the real
changes are minor and effective.

I'm signing off and correcting the commit message to include a
description of the fix and the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout screen for display in IE

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Elliott Davis  changed:

   What|Removed |Added

  Attachment #12467|0   |1
is obsolete||

--- Comment #26 from Elliott Davis  ---
Created attachment 15304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15304&action=edit
Bug 7736: EDI Edifact quote and order functionality

Rebased for current master.  I will be adding unit tests in a follow up patch

This is a patch brining together the original
work by Mark Gavillet and the subsequent patches
by Mark, Martin Renvoize and myself

It contains the code as currently runnng in
production

In addition I've added updatedatebase entries to
installer and replaced the hardcoded currency with
a currency extraction. As the db currently does not
force the standard codes we check if that is 3 uppercase
ascii characters before using it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #17 from Jonathan Druart  ---
(In reply to comment #15)
> Hi Jonathan, thx for taking my comments into account! The follow up looks
> good to me, but I think the commit message belongs to another patch?

Hi Katrin,
In fact I forgot to add the new file :-/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #15302|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  ---
Created attachment 15303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15303&action=edit
Bug 8365: Add unit tests and fix QA issues

This patch adds some unit tests for CalcDateDue and GetLoanLength

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #15 from Katrin Fischer  ---
Hi Jonathan, thx for taking my comments into account! The follow up looks good
to me, but I think the commit message belongs to another patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #14 from Jonathan Druart  ---
I switch back to needs signoff, I made some modifications into the CalcDateDue
routine (in my second patch).
The main modification is I removed the return statement (return $dt) when the
syspref useDaysMode eq 'Days'. I think we want to check the ReturnBeforeExpiry
syspref value in all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #13 from Jonathan Druart  ---
Created attachment 15302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15302&action=edit
Bug 8365: Add unit tests

This patch adds some unit tests for CalcDateDue and GetLoanLength

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #15300|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  ---
Created attachment 15301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15301&action=edit
Bug 8365: Add a renewal duration in the issuing rules

Renew an issue for a number of days (filled in the issuing rules).

Test if rules work for any i[item]types and if there is no regression.

- new column issuingrules.renewalperiod
- remove all occurrences of an already removed syspref (globalDueDate)
- remove an unused routine (Overdues::GetIssuingRules)

How it works:
- On existing installations, the issuingrules.renewalperiod =
  issuingrules.loanlength. So the behaviour is the same before and after
  this patch.
- when you add a rule, you can choose a renewal period (the unit value
  is the issuingrules.unit). So you can have a renewal period in hours
  or days.
- The default value for the renewal period is 21 days (same as
  loanlength)

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #14142|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  ---
Created attachment 15300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15300&action=edit
Bug 8365: Add unit tests

This patch adds some unit tests for CalcDateDue and GetLoanLength

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9609] Rebuild zebra reports double numbers for exported records with -z option

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9609

M. de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9609] Rebuild zebra reports double numbers for exported records with -z option

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9609

--- Comment #1 from M. de Rooy  ---
Created attachment 15299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15299&action=edit
Bug 9609: Rebuilding zebra reports double number of exported records.

Test plan:
Clear the zebra queue (run rebuild). Update one biblio.
Rebuild zebra (again) with -z. Check zebra log: note 2 exported records.
Now apply patch, and repeat: You will see 1 exported record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9609] New: Rebuild zebra reports double numbers for exported records with -z option

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9609

Bug ID: 9609
   Summary: Rebuild zebra reports double numbers for exported
records with -z option
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl

If you update 10 records, you will have 10 additional record in zebraqueue.
Rebuild zebra with -z (process queue).
Without this patch, you will see 20 exports in your zebra log.

Simple solution forthcoming.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9607] pagination wrong if OPACShowUnusedAuthorities set to "don't show"

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Nicole, Jared noted this in his commit message and documentation for the
feature. It's the same problem as with opachiddenitems where the numbering is
off and therefore probably a WONTFIX for now. 
Using the option is optional and OFF by default, so libraries can choose to use
it or not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #10 from Fridolyn SOMERS  ---
Datatables looks for datas to choose the default sort algorithm.
When looking at Checked Out and dates, it will use alphabetical sort algorithm.
Date format must be forced for metric ('uk_date') AND us format ('date').

Note that ISO format sorted by alphabetical order is correct.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9591] Set Library changes after viewing Holds Queue >> reserves item

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9591

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9608] New: white background on header on check in

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9608

Bug ID: 9608
   Summary: white background on header on check in
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/circ/returns.pl
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com

Created attachment 15298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15298&action=edit
white background

On the check in page /cgi-bin/koha/circ/returns.pl the header has a white
background instead of the usual blue found everywhere else.

This is in master and 3.10.2 (probably others as well)

Tested on Mac in the most recent FF and Chrome browsers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #9 from Fridolyn SOMERS  ---
(In reply to comment #7)
> Very odd, datatables.js method "dt_add_type_uk_date" does not use UK format
> "MM/DD/" but metric format "DD/MM/".

My coworkers explained me : UK = metric format (for dates only), it is US
format who is "MM/DD/".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9607] New: pagination wrong if OPACShowUnusedAuthorities set to "don't show"

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9607

Bug ID: 9607
   Summary: pagination wrong if  OPACShowUnusedAuthorities  set to
"don't show"
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/opac-authorities-home.pl?op=do_search&ty
pe=opac&operator=contains&value=a&marclist=any&and_or=
and&orderby=HeadingAsc
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com

Created attachment 15297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15297&action=edit
authorities results

See attached. When you search authorities with  OPACShowUnusedAuthorities set
to "don't show" it doesn't show the usual 20 per page instead it only shows
those on the page that are used and it makes for a very ugly search results
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9545] Fix Import Marc Bibliographic Framework Text Label

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9545

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4901] Title & Subtitle w/out space in Zotero

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4901

Nicole C. Engard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Nicole C. Engard  ---
I think this is fixed (not sure how) because I'm not seeing it anymore.

Nicole

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #8 from Nicole C. Engard  ---
Still an issue in 3.8.8.

Nicole

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9606] New: If you export to Ris the page information is not included

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9606

Bug ID: 9606
   Summary: If you export to Ris the page information is not
included
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: herwig.borrem...@inbo.be

If you export to Ris the page information is not included (in the OPAC)

i also tested bibtex same problem

i did a test by exporting all  the koha marc fields to RIS (filled them all up
with a number) and then importing the ris file in endnote

the page information was not transfered ... the page information in endnote
stayed empty 

(the marc field i use is 300 a checked library off congress they use the same
field)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9498] Update encoding for Norwegian sample Z39.50 servers

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498

Magnus Enger  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9498] Update encoding for Norwegian sample Z39.50 servers

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9498

--- Comment #1 from Magnus Enger  ---
Created attachment 15296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15296&action=edit
Bug 9498 - Update encoding for Norwegian sample Z39.50 servers

The encoding for sample Z39.50 servers loaded when doing a nb-NO
install has been wrong all along, resulting in "norwegian vowels"
(æøå) being displayed as weird chars when records are fetched via
Z39.50.

This patch
- Updates the sample servers installed by the web installer
- Does a database upgrade that changes the encoding for the servers
  in question

To test:
- Do a Norwegian installation and make sure to choose the optional
  sample Z39.50 targets
- Check that encodings for the Norwegian targets (BIBSYS, SAMBOK,
  NORBOK and DEICHMAN) are all set to ISO_6937 (which is the wrong
  encoding)
- Apply this patch and make sure updatadatabase.pl is run
- Check that the encoding for the four targets mentioned above are
  now ISO_8859-1
- Do one search against each target and check that there are no
  "strange" chars in the result list. Searching each of the targets
  for "hessen" should give results that include "norwegian vowels"
- Log on to the MySQL of the test installation and empty the table
  of Z39.50 targets:
  mysql> delete from z3950servers;
- Load this file into MySQL from the command line:
  installer/data/mysql/nb-NO/2-Valgfritt/z3950servers.sql
  and check that it loads without errors and that the four
  Norwegian targets are still set to have encoding = ISO_8859-1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8620] Barcode searching not working correctly

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620

--- Comment #8 from Martin Renvoize  ---
As an aside.. the patch I've created only patches the relevant files for
MARC21.. though I imagine it's very simple to also patch the ones for UNIMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #36 from Kyle M Hall  ---
> 1) This patch doesn't apply to the staff client, so library staff are still
> restricted to 1 hold per patron per record, even with the new system
> preference set to 3.

It sounds like you forgot to apply the patch for Bug 9394 first, this bug
depends on bug 9394.

> 2) This patch does apply to the OPAC. You are able to place holds (as the
> patron) on 3 items in a record when you have the system preference set to 3.
> However, when you try to place a 4th hold, the error message that appears is:
> 
> "Sorry, none of these items can be placed on hold."
> 
> "Title / by Author. This title cannot be requested."

Fixed!

> Stylistically, I think the Javascript warning on the staff client when
> exceeding the maximum number of holds could be improved.
> 
> Currently, it is:
> 
> "This patron has already placed the maximum number of holds for this record
> Please cancel a previous hold first"
> 
> These two sentences should have periods at the end and be separated with
> another new line. 

Also fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15253|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall  ---
Created attachment 15295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15295&action=edit
Bug 7710 - multiple holds per title

Adds the ability to allow multiple holds
on the same record for the same borrower.

Adds new system preference MaxHoldsPerRecord,
which controls how many holds one person can
have on items for the same record.

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Attempt to place 2 holds for the same patron on the same record,
   you should not be able to ( default is 1 per record )
4) Set MaxHoldsPerRecord to 3
5) Attempt to place multiple holds for one patron on one record,
   you should be able to place 3 holds for one patron on a given
   record. A 4th hold should result in a message stating the patron
   has placed the max number of holds allowed on this record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9382] Bold necessary permissions for staff client access.

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9382

--- Comment #14 from Katrin Fischer  ---
Bug should not be reopened because it's already been pushed, so I think another
patch has to go on a new bug? Should I file one?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9605] rotating collections permissions are wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9605

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9605] rotating collections permissions are wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9605

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #15292|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 15294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15294&action=edit
Bug 9605: rotating collections permissions are wrong

In tools / rotating collections, permissions are 'parameters => 1'.
But there is a dedicated permission : tools => rotating_collections.

Test plan :
- Disable tools/rotating_collections permission to your connected user
- Check you dont have access to those pages :
  rotating_collections/addItems.pl
  rotating_collections/editCollections.pl
  rotating_collections/rotatingCollections.pl
  rotating_collections/transferCollection.pl
- Enable tools/rotating_collections permission to your connected user
- Check you have access to above pages

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||9605

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9605] rotating collections permissions are wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9605

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Depends on||8836

--- Comment #2 from Katrin Fischer  ---
Hi Fridolyn, while the code for rotating collections is in Koha it was
deactivated last minute before release due to some security concerns. Kyle has
opened a bug to resurrect it bug 8836. I have linked your bug with Kyle's.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8365] Renewal duration in issuingules

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365

--- Comment #10 from Katrin Fischer  ---
I learned that iff is not a typo, so ignore that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9522] Koha returns <, >, etc in the record instead of <, >, etc when fulfilling a Z39.50 request

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522

--- Comment #4 from Gaetan Boisson  ---
It seems this is linked to a zebra problem indeed, see bug 3326 for more info.
This also affects result pages when they are displayed via XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3326] xml entity refs display incorrectly in results page if exported and indexed as xml

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3326

Gaetan Boisson  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9522

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9522] Koha returns <, >, etc in the record instead of <, >, etc when fulfilling a Z39.50 request

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522

Gaetan Boisson  changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=3326

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8620] Barcode searching not working correctly

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620

--- Comment #7 from Martin Renvoize  ---
The new patch re-adds a line that got missed and caused issues in the original
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8620] Barcode searching not working correctly

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8620

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #15164|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 15293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15293&action=edit
Patch for barcode missing in keyword search.

This patch was worked through with Ian Bays using his suggestion of adding
barcode to the any index for searching.

To test

1. A pre patch search from the standard search box (either staff client or
opac) for a barcode will not yield results.

2.A post patch search from the standard search box (either staff client or
opac) for a barcode should yield the single record as a result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967

Chris Cormack  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967

--- Comment #7 from Pongtawat  ---
I just found that setting this charset option broke some Z39.50 servers. For
example, for OhioLink server, it will freeze. Horizon Z39.50 server here seem
to not like it either. So, it shouldn't be set unless needed.

Since I need to set this option for OCLC to work properly for Thai language, so
locally, I just hacked it to have a new option "UTF-8 with negotiation" to do
this. 

Since it seems no one else has this problem, maybe the code should be leave
as-is and this bug closed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9605] rotating collections permissions are wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9605

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolyn SOMERS  ---
Created attachment 15292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15292&action=edit
Proposed patch

See commit comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #5 from mathieu saby  ---
Hello
> 
> Your solution will not work on prices with such pattern as :
> 
> 1 000 EUR :
> To get it work you must add a space in first alternative here
> ( $price ) = $price=~ m/([\d\,\. ]+[\,|\.\d\d]?)/;
> and there :
>  my @parts = split(/[\,\. ]/, $price);


You must be right!
I only tested on a few records (10 EUR ; 10,50 EUR ; 10.50 EUR)


> 
> 125 € :
> You must delete the first part of the routine until the regular expression
> (may be it was implied in what you showed ?).
> Otherwise, when the symbol had been entered in mysql symbol field as "active
> currency" and is typed after the digit(s), the variable $price in $price =
> $parts[1]  will be undef.
> 
> £ 10 :
> I don't know if it could be frequent but in case, the result will be ".10".
> To avoid this, I add a mandatory digit at the beginning of regexp and
> replace + by * after the first alternative.
> 

Yes, I did not think of symbols...

I think Biblibre is going to take part in this discussion.

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9605] New: rotating collections permissions are wrong

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9605

Bug ID: 9605
   Summary: rotating collections permissions are wrong
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com

In tools / rotating collections, permissions are 'parameters => 1'.
But there is a dedicated permission : tools => rotating_collections.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9604] filter overdues with homebranch and holdingbranch

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604

Fridolyn SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9604] filter overdues with homebranch and holdingbranch

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co
   |ity.org |m

--- Comment #1 from Fridolyn SOMERS  ---
Created attachment 15291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15291&action=edit
Proposed patch

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #4 from Koha Team Lyon 3  ---
(En réponse au commentaire 3)
> My solution was changing these lines in MungeMarcPrice routine:
> 
> - ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/;
> + ( $price ) = $price =~ m/([\d\,\.]+[\,|\.\d\d]?)/;
>  ## Split price into array on periods and commas
>  my @parts = split(/[\,\.]/, $price);
>  ## If the last grouping of digits is more than 2 characters, assume
> there is no decimal value and put it back.
>  my $decimal = pop( @parts );
> - if ( length( $decimal ) > 2 ) {
> + if ((scalar @parts == 0) or ( length( $decimal ) > 2 )) { 
> 
> 
> 
> 
> M. Saby

Bonjour Mathieu

Your solution will not work on prices with such pattern as :

1 000 EUR :
To get it work you must add a space in first alternative here
( $price ) = $price=~ m/([\d\,\. ]+[\,|\.\d\d]?)/;
and there :
 my @parts = split(/[\,\. ]/, $price);

125 € :
You must delete the first part of the routine until the regular expression (may
be it was implied in what you showed ?).
Otherwise, when the symbol had been entered in mysql symbol field as "active
currency" and is typed after the digit(s), the variable $price in $price =
$parts[1]  will be undef.

£ 10 :
I don't know if it could be frequent but in case, the result will be ".10". To
avoid this, I add a mandatory digit at the beginning of regexp and replace + by
* after the first alternative.

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703

--- Comment #15 from Jonathan Druart  ---
Created attachment 15290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15290&action=edit
Biblio without item

Hi Kyle,
This biblio contains no item.
When I search 'vifs', this title appears on the first page of results.
I click on the checkbox and on the "place holds' button.
I still got the same error.

reserve/request.pl: I pass into the following if statement:
if (!@itemnumbers) {
$template->param('noitems' => 1);
$biblioloopiter{noitems} = 1;
}
and just after the GetItemInfosOf routine is called with @itemnumbers which is
empty.
I think we want to skip the current biblionumber if it does not contain any
item. But maybe we want to raise this problem for the user too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9604] New: filter overdues with homebranch and holdingbranch

2013-02-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9604

Bug ID: 9604
   Summary: filter overdues with homebranch and holdingbranch
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolyn.som...@biblibre.com
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Add in overdues.pl filters on item home branch and holding branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/