[Koha-bugs] [Bug 9765] Remove unused include file: budgetperiods-admin.inc
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9765 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7596] System preferences editor JavaScript contains untranslatable English string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4266] encumbrance and expenditure not used in code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4266 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #22 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #37 from Nicole C. Engard --- How would I force another update database? Like I said it did prompt me to upgrade and I did, but there was no note about the new permission and the new permission is not showing at all on my patron records. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #36 from Jared Camins-Esakov --- Shows up in updatedatabase for me. "Add circ permission overdues_report" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4964] design of news in opac could be better
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4964 --- Comment #2 from Nicole C. Engard --- Yes, it can be resolved with CSS, but it's still ugly without CSS. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #35 from Nicole C. Engard --- I did a pull from master just now and I don't see a new permission. I was prompted to upgrade my database, but the upgrade notes said nothing about adding a new permission. Are we sure that this new permission is added properly on upgrade? Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8365] Renewal duration in issuingules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #24 from Jared Camins-Esakov --- This no longer applies. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4906] Allow fine calculation to exclude grace period
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #75 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16154|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16155|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16152|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16153|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16150|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16149|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16151|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16148|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16147|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16145|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16146|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16143|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16141|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16142|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov changed: What|Removed |Added Attachment #16140|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #74 from Jared Camins-Esakov --- Created attachment 16195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16195&action=edit Bug 9239 QA follow-up: fix overeager quote escaping The quote escaping added two follow-ups ago was a little too eager, and escaped perfectly valid quotes in some instances. This patch moves the escaping deeper into the loop so that no needed quotes will be escaped. Signed-off-by: Katrin Fischer Test plan included here, as this is the last patch in the series: All tests pass. OPAC Simple search - Keyword searches using boolean operators || and && - OK - Pubdate searches using pubdate() - OK - Using different search options: keyword, title, etc. - OK Facets - limit to available from a query parser simple search - OK - Other facets - OK Advanced search - Date range search - OK - Itemtype limits - OK - Language limit - OK - Combining various serach options with and without 'more' options and using boolean operators - OK Authorities - Searching for partial and complete names like "M", "Benedictus" works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. INTRANET Staged MARC import - Import records using various matching points - OK Serials - Search for a serial in subscription form - OK Acquisitions - Search for existing record from basket - OK Authorities - Running the linker script with QP on works. - OK - Searching for authorities works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. NOTE: As agreed with Jared in chat, query parser should be off by default for the next release. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #73 from Jared Camins-Esakov --- Created attachment 16194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16194&action=edit Bug 9239 QA follow-up: amend error handling Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #72 from Jared Camins-Esakov --- Created attachment 16193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16193&action=edit Bug 9239 QA follow-up: escape quotes in searches This patch escapes quotes in searches for those rare instances where there is a literal quote inside a search term. Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #71 from Jared Camins-Esakov --- Created attachment 16192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16192&action=edit Bug 9239 QA follow-up: better error handling * Fix a long-standing bug in the linker that could crash the linker when run against odd data. * Sanitize input to SimpleSearch. * Correctly handle CCL indexes with QP. Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #70 from Jared Camins-Esakov --- Created attachment 16191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16191&action=edit Bug 9239 QA follow-up: remove stray debug code Remove a line of debug code from EG, provide better error handling when presented with weird data in the authority linker, and correct queryparser configuration to reflect the correct configuration for Zebra. Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #69 from Jared Camins-Esakov --- Created attachment 16190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16190&action=edit Bug 9239 QA follow-up: don't fall back to kw if field is specified Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #68 from Jared Camins-Esakov --- Created attachment 16189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16189&action=edit Bug 9239 QA follow-up: the last QA follow-up was missing a require This patch also corrects the definition of the an= index, which was missing exactness. Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #67 from Jared Camins-Esakov --- Created attachment 16188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16188&action=edit Bug 9239 QA follow-up: escape CGI input Koha was not previously escaping CGI input, which caused problems for highlighting and is a security issue. Signed-off-by: Katrin Fischer Thx for fixing this. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9829] New: star ratings won't save on mobile ccsr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9829 Bug ID: 9829 Summary: star ratings won't save on mobile ccsr Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com When on an ipad or an android clicking the stars (which don't show as stars on android but as radio buttons) does nothing to save a rating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #66 from Jared Camins-Esakov --- Created attachment 16187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16187&action=edit Bug 9239 QA-follow-up: quiet warnings and fix problem with limits Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #65 from Jared Camins-Esakov --- Created attachment 16186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16186&action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with && broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Fixes some problems raised during QA successfully. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #64 from Jared Camins-Esakov --- Created attachment 16185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16185&action=edit Bug 9239 follow-up: update koha-conf.xml The previous patches were missing the koha-conf.xml updates. This patch updates koha-conf.xml and makes the changes neccessary to include the QueryParser configuration file in the packages. To test: 1) Run Makefile and check generated koha-conf.xml to confirm that the line ... is there with an absolute path. 2) That was it. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Tested update successfully - new line now shows up and query parser is used. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #63 from Jared Camins-Esakov --- Created attachment 16184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16184&action=edit Bug 9239 follow-up: POD and perlcritic fixes There were several perlcritic violations for returning explicit undef, and splitting up the various driver classes resulted in POD compliance errors, where the POD was starting with head2 rather than head1. This patch fixes those errors (but has no functional impact). Signed-off-by: Elliott Davis Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #62 from Jared Camins-Esakov --- Created attachment 16183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16183&action=edit Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. Signed-off-by: Chris Cormack Signed-off-by: Elliott Davis Searching still works as expected for variuos places. QueryParser syspref seemed to be enabled by default Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #61 from Jared Camins-Esakov --- Created attachment 16182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16182&action=edit Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context->queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. Signed-off-by: Chris Cormack Signed-off-by: Elliott Davis Fixed merge conflict in sysprefs.sql and updatedatabase.sql Signed-off-by: Katrin Fischer Fixed merge conflict in sysprefs.sql und updatedatabase.pl Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #60 from Jared Camins-Esakov --- Created attachment 16181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16181&action=edit Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: && * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. Signed-off-by: Chris Cormack Signed-off-by: Elliott Davis Test Passed successfully after installing missing dep for Test::Deep Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #59 from Jared Camins-Esakov --- Created attachment 16180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16180&action=edit Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. Signed-off-by: Chris Cormack Signed-off-by: Elliott Davis Signed-off-by: Katrin Fischer Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9784] koha-shell missing from koha-common man page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9784 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9695] Use alphabet system preference on page used to browse patrons for patron card batches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9695 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 mathieu saby changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #3 from mathieu saby --- Please don't test that for the moment. I fear I made some mistakes :( I will rewrite it when other bugs about UNIMARC are passed. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8853] clicking basketgroup name in closed basketgroups reopens it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8853 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 mathieu saby changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 mathieu saby changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #2 from mathieu saby --- Created attachment 16179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16179&action=edit [PATCH] Bug 9828: More specific indexing of UNIMARC 6XX fields Most of 6XX may contain a $2 that identifies the system used for indexing. It should not be indexed. In French libraries, $2 contains "rameau". So searching books about the music composer "Rameau" retreive thousands of records! For some 6XX fiels, other subfields should not be indexed, for example dates of persons and familiy, or adresses. In unimarc guide, 600$t,601$t,602$t are said to exist but to be "not used". I keep them indexed. Additionnally, subject indexing could be improved by using specific indexes for each 6XX if possible : In ccl.properties : - su-to, su-geo and su-ut are defined as aliases of Subject. - a specific index are defined, but not used in record.abs : Subject-name-personal, alis su-na We can use this index and create new specific indexes by using existing bib1 attributes. We could also index $j,$x,$y,$z subdivision in specific indexes. This patch does the following changes : 1) Add comments in record.abs 2) For all 6XX : Not indexing $2 (LSCH, Rameau...), $3 and $5 3) Not indexing specific subfields 600 : Personal name used as a subject // see Marc21 600 not indexing c (additional elements),f (dates),p (address/affiliation) 602 : Family name used as a subject // see Marc21 600 3X not indexing f (dates) 616 : Trademark not indexing c,f 3) For all 6XX : index $j,$x,$y,$z in several indexes in addition to the specfific index for their 6XX field: # 6XX$j : Genre/form : indexed in Subject, Subject-subdivision, Subject-genre-form # 6XX$x : Subject : indexed in Subject, Subject-subdivision # (could be topical subject or genre/form subject, so don't index in Subject-topical) # 6XX$y : Geographical subject: indexed in Subject, Subject-subdivision, Subject-name-geographical # 6XX$z : Chronological subject : indexed in Subject, Subject-subdivision, Subject-chronological 4) Define in ccl.properties some specific indexes : Subject-name-conference 1=1073 => alias su-conf Subject-name-corporate 1=1074 => alias su-corp Subject-genre-form 1=1075 => alias su-genre and su-form Subject-geographical 1=1076 => alias su-geo Subject-chronological 1=1077 => alias su-chrono Subject-title 1=1078 => alias su-ut and su-ti Subject-topical 1=1079 => alias su-to 5) Adding new aliases in Search.pm : su-chrono, su-form, su-genre, su-corp, su-conf, su-ti 6) Using these new indexes in record.abs for 600 : all field in Subject and Subject-Personal-Name all subfields except subdivisions in Personal-name 601 : all field in Subject, Subject-name-conference and Subject-name-corporate and Subject-name-conf all subfields except subdivisions in Corporate-name and Conference-name 602 : same as 600 but could be improved later 604 : all field in Subject and Subject-title ; $a in Subject-Personal-Name all subfields except subdivisions in Name-and-Title 605 : all field in Subject and Subject-title 606 : all field in Subject and Subject-topical 607 : all field in Subject and Subject-geographical all subfields except subdivisions in Name-geographic 608 : all field in Subject and Subject-genre-form To test : A. In a GRS 1 environment 1) Apply the patch 2) Rebuild zebra 3) Create a record A with - the string "bz9828" in 600$c 600$f 600$p, 602$f, 616$c, 616$f - the string "subform" in 602$j 4) Create a record B with the string "subgeo" in 606$y 5) Create a record C with the string "subdate" in 606$z 6) try to search "su:bz9828". You should have no results 7) try to search "su-geo:subgeo". You should have 1 result : record A 8) try to search "su-genre:subform". You should have 1 result : record B 9) try to search "su-chrono:subdate". You should have 1 result : record C 10) on existing records, try su-ut, su-to, su-na, su-form, su-corp, su-geo indexes, and see it results are relevant B. In a DOM environment same operations M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207 Chris Cormack changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9207] Improve z39.50 speed slowdowns for sites with many records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9207 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 --- Comment #1 from mathieu saby --- Additionnally, subject indexing could be improved by using specific indexes for each 6XX if possible. In ccl.properties, a specific index is defined, but not used in record.abs : Subject-name-personal, alias su-na Other aliases are defined, but as synonyms to Subject index : su-to, su-geo and su-ut. We can use index Subject-name-personal and create new specific indexes by using existing bib1 attributes. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #17 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8054] can hit submit twice when paying fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8054 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Pushed to 3.8.x and 3.10.x will be in 3.8.11 and 3.10.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9377] itemtype in duplicate biblio search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9377 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7804] Add Koha Plugin System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #98 from Jared Camins-Esakov --- (In reply to comment #97) > I noticed this error in your log: > #Error: Undefined subroutine &main::/home/jcamins/koha-dev/plugins called > at (eval 37) line 2. > > I'm wondering if there are any 'crufty' files left over in your plugins > directy. Maybe you should try deleting everything in there and then run the > unit test. Sorry, you responded at the same time you rebased so I didn't notice the comment before. I have nothing in that directory. Marking as "In Discussion" until we get this figured out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #14 from Jared Camins-Esakov --- This does not work for me. It creates links like: http://www.facebook.com/sharer.php?u=https://kohadev.cpbibliography.com/cgi-bin/koha/opac-detail.pl?biblionumber=80&t=M%C3%A1dam%20President,%20I%20think%20this%20title%20is%20much%20too%20long%20to%20fit%20on%20a%20book%20cover%20and%20that%20troubles%20me;%20moreover,%20the%20quick%20brown%20fox%20jumped%20over%20the%20lazy%20dog%20over%20and%20over%20and%20over%20and%20over%20/ even though kohadev does not use https. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 906] ISBN Check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 906] ISBN Check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #16170|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 16178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16178&action=edit [SIGNED-OFF] Bug 906 - ISBN Check In the MARC editor, have the ISBN checked. This feature is syspref-driven [1]. The patch adds the following javascript functions to cataloguing/addbiblio.tt: - _NormalizeISBN (for sanitizing the ISBN before algorithm checking) - _CheckISBNChecksum10 (for validating the checksum digit) - _CheckISBNChecksum13 (idem) - IsISBNOk (extract the isbn from the corresponding field, call the proper checker functions, return the string message) The Check function was hooked to call IsISBNOk and build a proper message dialog. AreMandatoriesNotOk got its message string rearranged too. To test: - Apply the patch, run updatedatabase.pl so the new syspref gets included on the DB. - Try adding a record: no matter what you introduce on the corresponding ISBN field Koha will behave as usual. - Go to the Sysprefs editor, under 'Cataloguing' set RequireValidISBN to 'Require'. - Reload your marc editor - Try different ISBN to see how it behaves: -- test cases -- * Empty ISBN should not stop you from saving your record. * Valid ISBN idem [2]. * Wrong ISBN should make Koha warn you and ask you to fix it [3]. [1] Added RequireValidISBN syspref. [2] Valid ISBN10: 291409891X ISBN13: 9784873113685 [3] Try To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Tested with 10 and 13 ISBN, and random string. Suggestion: If problem is in check digit, could suggest correct value? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9367] Code optimization: CheckReserves is too often called
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9367 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9827] Remove 'insecure' system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9827 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9827] Remove 'insecure' system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9827 Tomás Cohen Arazi changed: What|Removed |Added Attachment #16175|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi --- Created attachment 16177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16177&action=edit Bug 9827: remove 'insecure' system preference This patch removes 'insecure' system preference. Also removes remaining code that make use of the preference. It's broken anyway. Only remains a reference in POD of C4/Boolean.pm To test: 1) If you like, enable 'insecure' syspref. Broken system. WARN: be prepared to revert value in database. 2) Apply the patch 3) Run updatedatabase.pl 4) Check that Staff login proceeds as usual. 5) Check that 'insecure' syspref is no more. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9426] Add itemtype description template plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9426
Jared Camins-Esakov changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #10 from Jared Camins-Esakov ---
This patch looks good, except it doesn't add unit tests for the new code in C4/
and Koha/.
What about something like this in t/ItemType.t (obviously a resultset will have
to be added to the mocked dbh before this test):
my $itype = C4::ItemType->new_from_code('BK');
is(ref $itype, 'C4::ItemType', 'new_from_code creates correct type of object');
is($itype->description, 'Books', 'new_from_code retrieved correct itemtype');
And, of course, there also need to be tests for
Koha::Template::Plugin::ItemType. If you look at
t/db_dependent/Koha_template_plugin_KohaDates.t you'll see an example of a unit
test for a TT filter (and bonus points if you test by way of C4::Template as
well).
A follow-up adding the unit tests need not go through the entire sign off/QA
process again. If the coverage is good (and the tests pass), I will review it
myself and push it, so you can set this bug back to "Passed QA" after your
follow-up is attached.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 mathieu saby changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 mathieu saby changed: What|Removed |Added Assignee|gmcha...@gmail.com |mathieu.saby@univ-rennes2.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9828] New: Zebra indexes useless subfields in UNIMARC 6XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 Bug ID: 9828 Summary: Zebra indexes useless subfields in UNIMARC 6XX Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: mathieu.s...@univ-rennes2.fr Most of 6XX may contain a $2 that identifies the system used for indexing. It should not be indexed. In French libraries, $2 contains "rameau". So searching books about the music composer "Rameau" retreive thousands of records! For some 6XX fiels, other subfields should not be indexed, for example 600$t (dates of persons). And indexing of $j,$x,$y,$z subdivision could be improved by indexing them in specific indexes M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 --- Comment #2 from mathieu saby --- See also 9352 for 7XX fields and 8252 for 1XX fields. Still some corrections to do for 9XX fields and 6XX fields. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 mathieu saby changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r, ||paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 mathieu saby changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 mathieu saby changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821
--- Comment #1 from mathieu saby ---
Created attachment 16176
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16176&action=edit
[PATCH] Bug 9821: Make indexing of UNIMARC 5XX and 205 more specific
511 field ("false title") is not indexed.
519 field is indexed but does not belong to unimarc standard.
Indexing the whole 500/501 make search noisy because of $k (date) and $m
(language). $b is useless.
Indexing some subfields of 520/530/532/560 could sometimes be harmfull too.
In 500/501, $j,$x,$y,$z are subdivisions used of the record is not about a
title, but about a subject linked to a title.
For example :
500$aBible$xTranslations
So they should be indexed in subjects indexes rather than title index.
Regarding 205 (edition statement), it is currently indexed in title index.
But some subfields of 205 ($f and $g) contain information about the authors of
that edition, so only $a,$b,$d should be indexed in title index.
An other patch is made for indexing $f $g in author index.
This patch does the following changes :
1) Indexing only 205$a,$b,$d in title index
2) Commenting all the 5XX in record.abs
3) Indexing 511
4) Keeping 519 for the moment, but commenting
5) For 500 and 501, indexing subject subfield in subjects index :
500/501$j Subject,Subject:p
500/501$x Subject,Subject:p
500/501$y
Subject-name-geographical:w,Subject-name-geographical:p,Subject,Subject:p
500/501$z Subject-chronological:w,Subject-chronological:p,Subject,Subject:p
6) Unindexing the following subfields :
500 and 501 (uniform title)
not indexing $b (type of ressource), $k (date), $m (language), $2 (system
code),$3 (authority record number)
So that
500 $aBible $iNew Testament $mEnglish $qRevised Standard Version $k1972
should be indexed as
500 $aBible $iNew Testament $qRevised Standard Version
520 : preceding title (used for serials)
non indexing $j and $x
$j is intended for displaying notes. Ex of content : "Issue nos. 1 (summer
1974)-5 (autumn 1975)"
$x contains ISSN of former title. Maybe it could be indexed in issn index, but
it should not be in Title
530 : key title (used for serials)
non indexing $j
$j contains volume and date of key title. Could be used if the record contains
several 530, to precise the volumes or dates associated with each key title.
Nobody will use it in ordinary search.
532 : Developped Title
non indexing $z (language of title)
560 : Artificial Title
not indexing $5 (code for institution to which the field applies)
To test :
In a GRS1 environment
1) Create a record with
511$a FalseTitle
205$a Edition $f bz9821 $g bz9821
500$a Bible $b bz9821 $k bz9821 $m bz9821 $j bz9821subject $x bz9821subject $y
bz9821subject $z bz9821subject $2 bz9821 $3 bz9821
501$a Bible $b bz9821 $k bz9821 $m bz9821 $j bz9821subject $x bz9821subject $y
bz9821subject $z bz9821subject $2 bz9821 $3 bz9821
520$a PTitle $x bz9821 $j bz9821
530$a KTitle $v bz9821
532$a DTitle $z bz9821
560$a DTitle $5 bz9821
2) Apply
3) Rebuild zebra
4) Search in title index : FalseTitle => you should find it
5) Search in title index : bz9821* => you should have no result
6) Search in subject index : bz9821subject => you should have 1 result
Do the same in a DOM environment
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 --- Comment #2 from Katrin Fischer --- Hi Galen, thank you for your patch :) I am a bit worried about showing the dates from $d. I suspect our libraries would not like the change and using data from the union catalog $d is probably filled in a lot of records. Could we remove this field from display again or wrap it in a span with id so it can be hidden? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
