[Koha-bugs] [Bug 10180] New: [master] Diacritics in Z39.50 search results in acquisitions are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Bug ID: 10180 Summary: [master] Diacritics in Z39.50 search results in acquisitions are broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de To reproduce: - Create a basket - Add order line from external source - Search LOC for wetter - Verify that diacritics in the result list are broken This only occurs on the current master branch, not on 3.12.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|normal |major --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This is especially bad because the data imported has broken diacritics too, so it's not only a display problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- There are a lot more problems I note now while testing - like XSLT detail pages. I think something is seriously going wrong here and will stop filing bugs for now until someone had a chance to look into this one and bug 10179. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] New: Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Bug ID: 10181 Summary: Improve message shown for deleted records in basket summary page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de When you delete a record that is used in an order, the basket summary displays: Deleted bibliographic notice, can't find title. While it would be nice if it showed a note about the deletion and the title from the deletedbilbio table, it would be better if it used 'record' instead of notice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #17700|0 |1 is obsolete|| Attachment #17833|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 17913 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17913action=edit [PASSED QA] Bug 7593: Move orders on the destination record when merging 2 records Revised patch according to QA comments. No more dependent from bz 9780. At present, merging records breaks the link order/record, except if an item of the deleted record is used in the order. This is a serious issue for libraries creating items on receipt. This patch moves existing orders from deleted record to destination record. It creates a new function Acquisitions::GetOrdersByBiblionumber, that could be used by other patches later. To test : Check the problem : 1. Set syspref AcqCreateItem = Create an item when receiving an order 1. Create a basket with one order 2. Put the record used by this order in a list 3. Put an other record in the list 4. Merge the 2 records, keeping as a reference the record NOT used in the order 5. In the order, you will see for that order Deleted bibliographic information... 6. Apply the patch 7. Repeat steps 1-4 8. In the order, you will see the title/author of the kept record. 9. Set syspref AcqCreateItem = Create an item when placing an order 10. Repeat steps 1-4 (an item will be created) 11. In the oreder, you will see the title/author of the kept record (it is already the case at present. the patch should not alter this behavior) Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Test plan, test suite and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 17914 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17914action=edit [PASSED QA] Bug 7593 : QA followup : restores deleted line in C4::Acquisition This patch restores the line exporting GetOrderNumber that I accidentally suppressed. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Restores a line that was deleted by the first patch. Was not sure if patches should be squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- So the problem is, that the biblionumber is wrong for the hold placed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16815|0 |1 is obsolete|| Attachment #16816|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17915 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17915action=edit Bug 9508: Standardize the dateformat value from C4::Auth - the dateformat value is send to all templates (from C4::Auth::get_template_and_user) - remove all assignment of dateformat in all .pl files - Remove all occurrences (those I found!) of dateformat_* From now the only way to get the date format is a string comparaison (dateformat == metric) Checked with the command: git grep \(dateformat_us\|dateformat_metric\|dateformat_iso\) | grep -v translator Signed-off-by: Kyle M Hall k...@bywatersolutions.com Tested all the datepickers I could find, looks good. Signed-off-by: Paul Poulain paul.poul...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17916 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17916action=edit Bug 9508 follow-up : replacing tabs by spaces This patch fixes tabs and replace them by spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #5 from Paul Poulain paul.poul...@biblibre.com --- Feedback: we're running plack in production at SAN Ouest Provence since last week. They are facing this problem. I can reproduce it on their test platform too. However, when trying to reproduce it on a master/3.11, it's working well. I spent more than 3 hours trying to understand the differences, and can't find any patch that explain this behaviour change. Jared, is your comment 4 applying on master or 3.10 ? (I fear it's master, that would just add some mystery...) Side comment = it seems that, despite the error, the file is uploaded correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #6 from Paul Poulain paul.poul...@biblibre.com --- Feedback 2 : suspecting a problem with background jobs, I've tested tools/upload-cover-image.pl, on a 3.10 and got the same problem. So it relies on background-job. I tried on a master, and it worked ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com --- Could you export the 2 dataTable sorting functions into the datatables.js file please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970
--- Comment #7 from Paul Poulain paul.poul...@biblibre.com ---
still trying to figure out why it works for me on a master.
Here are the log I get on plack:
seek() on closed filehandle _GEN_5 at /usr/share/perl5/CGI/Emulate/PSGI.pm line
31.
Undefined subroutine CGI::Emulate::PSGI::croak called at
/usr/share/perl5/CGI/Emulate/PSGI.pm line 31.
(and nothing more)
I checked configurations files on both servers, and couldn't see any
difference.
How I run starman:
starman -M FindBin --max-requests 50 --workers 6 --port 5001 --pid
/path/starman_pro.pid koha.psgi
my koha.psgi is:
#!/usr/bin/perl
use Plack::Builder;
use Plack::App::CGIBin;
use Plack::Middleware::Debug;
use Plack::App::Directory;
#use Plack::Middleware::Debug::MemLeak;
use lib(/home/paul/koha.dev/koha-community);
use C4::Context;
use C4::Languages;
use C4::Members;
use C4::Dates;
use C4::Boolean;
use C4::Letters;
use C4::Koha;
use C4::XSLT;
use C4::Branch;
use C4::Category;
my $app=Plack::App::CGIBin-new(root = /home/paul/koha.dev/koha-community/);
builder {
#enable 'Debug', panels = [
#qw(Environment Response Timer Memory),
# [ 'Profiler::NYTProf', exclude = [qw(.*\.css .*\.png .*\.ico
.*\.js .*\.gif)] ],
# [ 'DBITrace', level = 1 ],
#];
enable Plack::Middleware::Static,
path = qr{^/intranet-tmpl/}, root =
'/home/paul/koha.dev/koha-community/koha-tmpl/';
enable Plack::Middleware::Static::Minifier,
path = qr{^/intranet-tmpl/},
root = './koha-tmpl/';
#enable 'StackTrace';
mount /cgi-bin/koha = $app;
};
(note that I also tried to uncommand enable 'StackTrace', no difference, still
work on my laptop)
my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985
On the (faulty) server : Debian + Plack version 1.0013
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231
--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Comment on attachment 17910
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17910
Bug 9231 - Batch revert staged MARC records fails if one or more records in a
batch have been deleted.
Review of attachment 17910:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9231attachment=17910)
-
::: C4/Items.pm
@@ +619,4 @@
# backup the record
my $copy2deleted = $dbh-prepare(UPDATE deleteditems SET marc=? WHERE
itemnumber=?);
+eval { $copy2deleted-execute( $record-as_usmarc(), $itemnumber ); };
warn $@ if $@;
If the error is caused by $record being undefined, wouldn't it be better to do
if ($record){
my $copy2deleted = $dbh-prepare(UPDATE deleteditems SET marc=? WHERE
itemnumber=?);
$copy2deleted-execute( $record-as_usmarc(), $itemnumber );
}
To save creating a handle and hitting the db when we don't need to, could even
do an
else {
log deleted one here to tell the user
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9806] Show more information on basketgroups lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- I agree with the Fridolyn's proposal. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 17917 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17917action=edit Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Not only does this make the strings translatable it makes the template a lot easier to read -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #17444|0 |1 is obsolete|| --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 17918 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17918action=edit Bug 10052: Db revision for intranetstylesheet Report 10052 makes the intranetstylesheet prefs behave like the opac ones. This patch contains an optional db revision: If the pref intranetstylesheet is not blank, and does not start with http, https or /, then prefix it with a slash to make it an absolute path. Test plan: Before applying this patch: 1) Put intranet-tmpl/prog/en/css/staff-global.css into intranetstylesheet. This works in the current staff client, but will be interpreted as relative as soon as both patches for this report have been applied. Apply the patch. And run: /cgi-bin/koha/installer/install.pl?step=3op=updatestructure Check the webinstaller warning and the pref value. There should be a slash in front now. The css should still work. Continue after applying this patch with: 2) Clear the intranetstylesheet pref. Run updatestructure again. No message: OK 3) Put /intranet-tmpl/prog/en/css/staff-global.css in intranetstylesheet. Run updatestructure again. No message: OK 4) Prefix intranetstylesheet with http://[your-server-here]. Test again. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9806] Show more information on basketgroups lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #16 from mathieu saby mathieu.s...@univ-rennes2.fr --- I had forgotten this bug... Will take a look later and rewrite it. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #17445|0 |1 is obsolete|| --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 17919 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17919action=edit Bug 10052: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts Allow a relative path (within theme/css) in intranetstylesheet too. Allow a full path, local or remote with http(s), in intranetcolorstylesheet. This restores consistency between opac and staff. Test plan: First: the patch with the db revision should have been applied. And also the updatestructure step from the web installer should have been run. Clear intranetstylesheet. Check included stylesheet with page source in browser. Enter a full path with http or / in intranetstylesheet. Check again. Enter a relative path (such as staff-global.css). Check again. Clear intranetcolorstylesheet. Check if there is no reference with page source. Enter a full path with http or / in intranetcolorstylesheet. Check reference. Enter a relative path (such as blue.css). Check again. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #17465|0 |1 is obsolete|| --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 17920 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17920action=edit Bug 10052 Followup for edithelp.tt and help-top.inc A grep on the stylesheet names revealed that similar code was used in those template files. This patch moves the code from doc-head-close.inc to a new include file. Now, doc-head-close and the help templates refer to that one file. Test plan: If you tested the preceding two patches, now you only need to: 1) Check included css via page source in browser from staff main page. 2) Check it also from some other location. 3) Check again from Help: e.g. /cgi-bin/koha/help.pl 4) Check again from Edit Help: /cgi-bin/koha/edithelp.pl Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9891] Current suspend holds have disappeared
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- What was the version you updated from? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7883] save and continue editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Works as expected. This patch allows to do a save and to continue editing the same notice. An improvement could be to stay on the same tab after saving. I will open a new report for that. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7883] save and continue editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16224|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17921 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17921action=edit Bug 7883 - Save and continue editing for cataloging Patch reworked from Elliot Davis' original patch - but using bootstrap instead of YUI. This patch adds the ability for catalogers to save and continue editing when adding new biblios. To Test: Select an existing item or create a new item in cataloging using your favorite framework. Edit the bib From the save menu in the dropdown, select the new option of Save and continue editing If you are missing required fields you should still be prompted to fill them in before saving Once all required fields are in place you should be allowed to save, and you will be redirected to tab 0. The original patch claims to redirect to the original tab, but I never observed that behaviour from it - this patch merely takes what was in the original and makes it boostrap. Signed-off-by: Alex Arnaud alex.arn...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10182] New: Save and continue editing should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Bug ID: 10182 Summary: Save and continue editing should be improved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com CC: m.de.r...@rijksmuseum.nl When editing a biblio, the bug 7883 introduces the save and continue editing feature. After saving, the page is loaded with the first tab selected. It would be great to stay on the same tab after saving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10182] Save and continue editing should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||7883 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7883] save and continue editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||10182 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10182] Save and continue editing should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10182] Save and continue editing should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17922 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17922action=edit Bug 10182: Stay on the same tab after saving a biblio When editing a biblio, the bug 7883 introduces the save and continue editing feature. After saving, the page is loaded with the first tab selected. This patch refresh the page with the same tab selected. Test plan: 1/ Edit a biblio. 2/ Clic on the 5th tab. 3/ Clic on the Save and continue editing button. 4/ You are redirected on the same page with the same tab selected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10182] Save and continue editing should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #5 from mathieu saby mathieu.s...@univ-rennes2.fr --- Your followup looks strange : it contains the same strings as the main patch. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #15615|0 |1 is obsolete|| --- Comment #18 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 17923 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17923action=edit Bug 9593 Prices not imported correctly from a staged file Hello I redid test with prices like $2 and €24, and it worked well for me. As far as regex is concerned, I see no reason that it would work for a price like '€ 22' and not for '$42'. I suspect an error during importation process, may be an encoding issue ? So I 've kept this part of the patch as it was, but, following your different observations, I restablished the possibility of choosing an 'active currency' when existing. I also add the ability to choose it from the isocode instead of symbol currency. However, I fear that it couldn 't treat every possible form of not normalized multicurrency price strings that may appear in price zone. So it's a little better than it was under this aspect but not completly satisfying. For example, it will work for string like this $2, £5 2$, 6£ $2 USD, $4 LRD 2 EUR, 5 GBP 13.5 EUR, 15 GBP but it will not for : $800 LRD, $10 US $15, 18 EUR Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #4 from Nicole C. Engard neng...@gmail.com --- Video: http://www.screencast.com/t/3ASTIyJ6JSB -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #5 from Nicole C. Engard neng...@gmail.com --- Yes! I think that's the problem - great way to boil it down :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I guess the problem is that it's not a general yes/no thing. If your analytic has not only the analytics item, but also a real item, that can be placed on hold, a biblio level hold on this would be ok. But we have no way to decide which record should be chosen then. If the record has only the analytical item, only a bib level hold on the parent would be ok. Maybe we could say that analyticals should only be availabable for item level holds? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #7 from Nicole C. Engard neng...@gmail.com --- I'd be okay with that. I do see how this is a very difficult issue ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #5) Jared, is your comment 4 applying on master or 3.10 ? (I fear it's master, that would just add some mystery...) Master. Side comment = it seems that, despite the error, the file is uploaded correctly. Confirmed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554
--- Comment #107 from Jonathan Druart jonathan.dru...@biblibre.com ---
Galen,
I don't know why, a remainder of the first patch still exists on master, which
cause some trouble with encoding.
The binmode routine is called in master:
sub output_html_with_http_headers {
binmode( STDOUT, :encoding(utf8) );
my ( $query, $cookie, $data, $status ) = @_;
output_with_http_headers( $query, $cookie, $data, 'html', $status );
}
This line was not deleted by the revert commit.
commit d542740ab8877234d043c8a11cb19a6004e72656
Author: Dobrica Pavlinusic dpav...@rot13.org
Date: Sun Jun 10 15:18:42 2012 +0100
Bug 6554 - make Koha internally utf-8 clean
git show d542740ab8877234d043c8a11cb19a6004e72656 C4/Output.pm
+++ b/C4/Output.pm
@@ -308,6 +308,7 @@ sub output_with_http_headers {
}
sub output_html_with_http_headers {
+binmode( STDOUT, :encoding(utf8) );
commit a7eb34f2c8a281ef83f711e581079a2232296c88
Author: Galen Charlton g...@esilibrary.com
CommitDate: Mon Apr 29 15:12:32 2013 -0700
Revert Bug 6554 - make Koha internally utf-8 clean
git show a7eb34f2c8a281ef83f711e581079a2232296c88 C4/Output.pm
returns nothing
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Janusz Kaczmarek janus...@gmail.com changed: What|Removed |Added Attachment #17850|0 |1 is obsolete|| --- Comment #10 from Janusz Kaczmarek janus...@gmail.com --- Created attachment 17924 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17924action=edit Improved patch - v. 0.3 I have omitted one case: it could be, that UNIF_TITLE authority will used to control bibliographic 240. In this case 2nd indicator from UNIF_TITLE authority should be copied to 2nd indicator of bibliographic 240. A modified patch is provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #11 from Janusz Kaczmarek janus...@gmail.com --- Bernardo, Thank you for your efforts in testing this patch. In general, the results are correct, i.e. it is what I would expect—with one exception: e) GENRE/FOMR 155 BIB IND1 IND2 655 -0|7 With your data set (GENRE/FORM 155a, ind1=1, ind2=2), according to my code and to my tests results, the 1st indicator should become 1. So, please, could you check it again. BUT in fact the 1st indicator in authority records 148, 150, 151, 158 is undefined by definition (and should be your records), so I do not pay attention on it (precisely speaking, a default action is taken, i.e. to copy). Now, I have omitted one case: it could be, that UNIF_TITLE authority will used to control bibliographic 240. In this case 2nd indicator from UNIF_TITLE authority should be copied to 2nd indicator of bibliographic 240. A modified patch has been provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] New: Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Bug ID: 10183 Summary: Serials collection table is displayed with a single pixel before and after Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com CC: colin.campb...@ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #108 from Dobrica Pavlinusic dpav...@rot13.org --- (In reply to comment #103) This should not be viewed as a permanent reversion, although I have reservations about turning on CGI.pm's -utf8 switch across the board -- but I have even stronger reservations about the ensuant game of whack-a-mole we've been playing with new bugs arising from this patch. Would you mind to elaborate your objections to CGI.pm's -utf8 switch? I think that it's cleaner to take extra care about code which uses file upload than to hand-decode every single parameter we are passing into Koha code. This is only my personal preference, and I am fine with whatever solution gets eventually prefered, but I main question is if I should re-submit my patches without -utf8 in them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9791] Some tables are displayed with a pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9791 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10183 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9791 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17925 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17925action=edit Bug 10183: Remove single pixel on the serials collection page Test plan: Go on the serials collection page Check that the single pixels before and after the table have disappeared. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: The patches works as expected. But it does not change the data in the DB, so the issue still exists until user change status for a missing serial. It's too bad not to deal with existing data. I pass QA this patch until it fixes a bug but it would be great to have a followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #14433|0 |1 is obsolete|| --- Comment #34 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 17926 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17926action=edit Bug 8236 Block renewing for overdue items At the end , I found more convenient to deal with the restriction case in same patch. I keep what seems to be the existing logic - a patron can't renew when he's restricted (his opac file is freezen) - making it more consistent. Any renewal for a restricted patron is now also blocked from webservice and clearly not possible from the pro interface unless by checking 'override_limit'. If someone would like to allowed renewal for restricted patrons, I think it would be not very complicated to add a syspref ( a line of code in HasWhateverRenewalToBeBlocked and some addings in opac-user.tt) As for the main object of the patch - blocking for late document - I made some ajustements you pointed out and one change in the logic : rather than hiding the 'Renew all' button, I move the checking in renewscript.pl. So, this button is always available in case of big list of checkouts items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #17365|0 |1 is obsolete|| Attachment #17577|0 |1 is obsolete|| --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17927 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17927action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Regex needs a followup. More comments on Bugzilla. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17928 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17928action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Amended: does now only look at separating colons(;) not commas(,). Amended: two index expressions in direct context replaced by same regex for consistency. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #16301|0 |1 is obsolete|| --- Comment #6 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 17929 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17929action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Patch modified. It's now possible to link a sort1 criteria to several borrower categories -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17925|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 17930 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17930action=edit [SIGNED-OFF] Bug 10183: Remove single pixel on the serials collection page Test plan: Go on the serials collection page Check that the single pixels before and after the table have disappeared. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 17931 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17931action=edit Bug 9533: Use default values by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9533] batch item modification should ignore defaults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17884|0 |1 is obsolete|| --- Comment #7 from Owen Leonard oleon...@myacpl.org --- Created attachment 17932 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17932action=edit [SIGNED-OFF] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard oleon...@myacpl.org This revised patch works fine for me, thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #35 from Koha Team AMU koha.aixmarsei...@gmail.com --- So sad. It seems we can't test it on a sandbox : Something went wrong ! Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging opac/opac-renew.pl CONFLICT (content): Merge conflict in opac/opac-renew.pl Auto-merging opac/opac-user.pl Auto-merging reserve/renewscript.pl Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10184] New: Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Bug ID: 10184 Summary: Circulation History reverses sort order Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The script members/readingrec.pl specifically requests the users issues ordered with the most recent (by due date) first. But they are displayed in approximately the reverse order to this. The cause is that unless explicitly disabled the datatables sort their data and not being given a specification they do so in ascending order by the first column. The pre display sort of already sorted data needs disabling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #36 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Yes, I think it's not possible, on the sandbox because of the versioning in updatedatabase.pl file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #36) Yes, I think it's not possible, on the sandbox because of the versioning in updatedatabase.pl file. Yes it is possible, but you should provide a patch rebased against master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10184] Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 17933 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17933action=edit proposed patch Patch: to test Without the patch issues in patron circulation history will show oldest first. With patch applied issues will initially display most recent first (ordered by duedate) Users ability to sort the table should not be impaired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10184] Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Severity|enhancement |trivial --- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com --- oops forgot to change status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #109 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #107) Galen, I don't know why, a remainder of the first patch still exists on master, which cause some trouble with encoding. The binmode routine is called in master: Thanks for catching this. I've pushed a patch to master to complete the revert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #14 from Paul Poulain paul.poul...@biblibre.com --- I think there's something wrong with attachments: the #2 is octet-stream, it should be a patch I think. isn't the #1 obsoleted by the #2 too ? To answer the main question : I think it's more a bugfix than an ENH : baskets that are 100% received are supposed not to be displayed anymore on this page. Side comment: we must display baskets that are not closed, whatever the # of items still to receive. Otherwise, empty baskets will disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #38 from Koha Team Lyon 3 k...@univ-lyon3.fr --- ?! I am surely missing something (much indeed) about git, but I did this patch today on top of master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] New: updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Bug ID: 10185 Summary: updatedatabase.pl remove all reserves Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Database Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com Update number 3.09.00.025 can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id @ai This can be fixed easily by using COALESCE INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id COALESCE(@ai, 0) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10186] New: Typo in subscription-add.tt (years vs year)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Bug ID: 10186 Summary: Typo in subscription-add.tt (years vs year) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: mathieu.s...@univ-rennes2.fr Typo to fix in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt replace 2/years with 2/year in this block : [% IF ( periodicity9 ) %] option value=9 selected=selected2/years/option [% ELSE %] option value=92/year/option [% END %] M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #1 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 17934 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17934action=edit Bug 10185: Fix update 3.09.00.025 It can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id @ai -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10187] New: precision needed in subscription-add.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Bug ID: 10187 Summary: precision needed in subscription-add.tt (1/quarter) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: mathieu.s...@univ-rennes2.fr A precision is needed in subscription-add.tt : 1/quarter is used 2 times. I suppose there is some difference, but I do not know which... [% IF ( subscription.periodicity7 ) %] 1/quarter [% END %] [% IF ( subscription.periodicity8 ) %] 1/quarter [% END %] M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10187] precision needed in subscription-add.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr --- Oups, not in subscription-add.tt but in serials-collection.tt ! In subscription-add.tt there are the same values, but with this comment : periodicity8 is 1/quarter, exactly like periodicity7 but will use it for seasonal option So in serials-collection.tt we should have : periodicity7 1/3 months (1/quarter) periodicity8 1/quarter (seasonal) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10187] precision needed in subscription-add.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Assignee|oleon...@myacpl.org |mathieu.saby@univ-rennes2.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Summary|precision needed in |precision needed in |subscription-add.tt |serials-collection.tt |(1/quarter) |(1/quarter) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #2 from Julian Maurice julian.maur...@biblibre.com --- Note that this bug concern version 3.10, but also 3.12 and master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #17904|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 17935 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17935action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to automatically. 4) Search for har. Note that it returns results with words like Harry (i.e. with right truncation). 5) Search for har*. Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to only when * is added. 7) Search for har. Note that it returns only records that have the exact word har in them (most likely there will be none unless you have Hebrew items). 8) Search for har*. Note that once again it returns results for Harry (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- I suspect the difference does not come from Koha version, but from Plack version. my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985 On the (faulty) server : Debian + Plack version 1.0013 I suspect that it's Plack that is responsible of the different behaviour. Jared, which plack version do you have ? (i'll try to update, but on ubuntu, by default, it's 0.9985) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #9) I suspect the difference does not come from Koha version, but from Plack version. my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985 On the (faulty) server : Debian + Plack version 1.0013 I suspect that it's Plack that is responsible of the different behaviour. Jared, which plack version do you have ? (i'll try to update, but on ubuntu, by default, it's 0.9985) I have Plack 0.9985 and Starman 0.2014. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #17597|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 17937 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17937action=edit [Signed-Off] Bug 8278: build the structure with to_json instead of manually. Test plan: Same as previously. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10036] adding header search to additem page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10036] adding header search to additem page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #17854|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 17938 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17938action=edit Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #17934|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 17939 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17939action=edit Bug 10185: Fix update 3.09.00.025 It can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id @ai Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593
--- Comment #19 from Kyle M Hall kyle.m.h...@gmail.com ---
Comment on attachment 17923
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17923
Bug 9593 Prices not imported correctly from a staged file
Review of attachment 17923:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=9593attachment=17923)
-
::: installer/data/mysql/updatedatabase.pl
@@ +6785,5 @@
}
+$DBversion = 3.11.00.XXX;
+if ( CheckVersion($DBversion) ) {
+$dbh-do(ALTER TABLE currncy ADD isocode VARCHAR(5) default NULL AFTER
symbol;);
Typo!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
