[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Liz, I think it's still better to open a new bug when a new problem arises and link it to the old one. If Rafal doesn't beat me to it, I will do it later when doing QA. My reasoning is that this has been pushed to a long released version of Koha and it takes a lot of time to process bugs like this when you are testing because there are so many comments and other things to look for. Also we have many different people working on this, a new bug is really cleaner. If the same patch works on master I would say we should use it for now. It looks like an easy fix to a longer existing problem and we shouldn't force people to rewrite lots of code in that case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 mr_mega...@hotmail.com changed: What|Removed |Added CC||mr_mega...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] New: Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Bug ID: 10256 Summary: Remove some unused subs from Overdues module, or do not export them Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Did a grep on the following exported subs: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules As it appears, they are not even used anywhere (anymore). My proposal is now to remove them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18165 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18165action=edit Bug 10256: Remove some unused subs from Overdues module Removes the following exported but unused subs from Overdues.pm: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules Test plan: It is hard to test the removal of something that was not used :) Try this: Do a recursive grep on these routine names in the Koha codebase. Compile some scripts that use the Overdues module. And just to be sure we do not break something: Go to Circulation: Do a checkout, checkin, place and confirm a hold. Go to Patrons: Goto Check out. Goto Fines. Run the command line scripts: fines.pl and overdue_notices.pl. Go to opac-user.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10257] New: Make OpacSeparateHoldings work for non-logged in users
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 Bug ID: 10257 Summary: Make OpacSeparateHoldings work for non-logged in users Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mag...@enger.priv.no Depends on: 7674 OpacSeparateHoldings is a great enhancement, but only works for logged in users, which means it is less useful on e.g. public access computers in the library, used for quickly looking up what books are on the shelf in the library. It would be nice to have a way to choose a library without being logged in. This could probably work very similar to how the language chooser works (with a cookie). It would also be nice to be able to specify the chosen library in a URL, so you could link to a shared OPAC with a special link and have the chosen library be your library. (See bug 9735 for a parallel development for languages.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Blocks||10257 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] New: Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258
Bug ID: 10258
Summary: Remove erroneous call to haspermission in basket.pl
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: minor
Priority: P5 - low
Component: Acquisitions
Assignee: m.de.r...@rijksmuseum.nl
Reporter: m.de.r...@rijksmuseum.nl
Current code in basket.pl contains an invalid call of haspermission:
if ($basket-{closedate} haspermission({ acquisition = 'group_manage'} ))
{
The first parameter should be userid, the second should be flagsrequired.
Looking at the code, it is useless to just insert the first parameter here via
$member-{userid}, since this would result in an empty basket group list.
To resolve this, more should be done in the template.
Currently, the erroneous call results in getting back some hash probably filled
with zeroes. But the hash makes the if test above prove true for a closed
basket. So in reality, any user will see here all basket groups. Removing this
erroneous call for haspermission will therefore not make a difference.
The proposed patch adds a FIXME.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18166 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18166action=edit Bug 10258: Remove erroneous call to haspermission in basket.pl First parameter (userid) was not passed making the test useless. Removed the test for now. Current behavior does not change. Just adding the first parameter here does not make sense. Using the permission here needs more than that. Test plan: Open a closed basket in Acquisition. Check if you see all available basketgroups in the combo at the right side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10184] Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #6 from Colin Campbell colin.campb...@ptfs-europe.com --- (In reply to comment #5) The sorting algorithm doesn't take into account the 'dateformat' system preference. We just have a string sort. It works when dateformat = /mm/dd. It doesn't for dd/mm/. The sort is done by mysql on a mysql date column the koha system preference is not relevant. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #44 from Jared Camins-Esakov jcam...@cpbibliography.com --- We are still getting failures from jenkins on master. I am going to need to revert this today if we (well, someone who isn't me) can't figure out and fix the problem quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #45 from mathieu saby mathieu.s...@univ-rennes2.fr --- Did you test the patch of Jonathan (18114)? I suppose I cannot sign it off, as I am the main contributor to this bug? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #46 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #45) Did you test the patch of Jonathan (18114)? I suppose I cannot sign it off, as I am the main contributor to this bug? Yes. I pushed it, but we're still getting errors. Could it be a data issue? Is there particular data that is needed for those steps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #47 from mathieu saby mathieu.s...@univ-rennes2.fr --- I do not know how Jenkins is working. Does it precise which test is wrong? The reason why I added unit test is that P. Poulain said me new function, new unit test during Hackfest (the new function was on an other bug at that time) ;-) So, you can suppress some of these tests if you think they are not necessary... Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #48 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #47) I do not know how Jenkins is working. Does it precise which test is wrong? Jenkins just has all the sample data on a Debian Squeeze server and runs the entire build/test process every time there is a change to the source code. http://wiki.koha-community.org/wiki/Continuous_Integration If you look at http://jenkins.koha-community.org/job/Koha_master/lastCompletedBuild/testReport/ it gives you a summary, and you can get a bit more information in the log at http://jenkins.koha-community.org/job/Koha_master/lastCompletedBuild/console The reason why I added unit test is that P. Poulain said me new function, new unit test during Hackfest (the new function was on an other bug at that time) ;-) So, you can suppress some of these tests if you think they are not necessary... The test is definitely necessary, and looks good. I would not have pushed it without unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593
--- Comment #49 from mathieu saby mathieu.s...@univ-rennes2.fr ---
OK, so if I understand Jenkins logs, the 2 tests are failing.
Maybe my function is wrong, or maybe the 2 lines in unit test
my $testorder = @$orders[0];
my $testbiblio = $testorder-{'biblionumber'};
I am looking at it right now.
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10256 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10021 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Marcel, I think this is related to a bug I filed - only I was concentrating on the database relicts that are connected to those subs: bug 10021 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10257] Make OpacSeparateHoldings work for non-logged in users
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Maybe this could work similar as bug 7740? If set to OpacURLBranch, the library is chosen based on the Apache environment variable BRANCHCODE. For example, this could be added to the OPAC section of koha-httpd.conf: SetEnv BRANCHCODE CPL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #50 from mathieu saby mathieu.s...@univ-rennes2.fr --- I updated my Koha instance, and launch $prove -v Acquisition.t Acquisition.t .. ok 5 - GetOrdersByBiblionumber : no argument, return undef ok 6 - GetOrdersByBiblionumber : result is defined ok 7 - GetOrdersByBiblionumber : result contains at least one element I don't understand : How is it possible that Jenkins fails and not my instance? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #50) I don't understand : How is it possible that Jenkins fails and not my instance? Theses tests are db dependent. As Jared said, you should insert the sample data before launching them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593
--- Comment #52 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I checked everything is correct by adding warns in my Acquisition.t
warn 'record number : '.$testbiblio;
my @listorders = GetOrdersByBiblionumber($testbiblio);
ok( @listorders ,'GetOrdersByBiblionumber : result is defined' );
ok( scalar (@listorders) 0,'GetOrdersByBiblionumber : result contains at
least one element' );
warn 'nborders in listorders : '.scalar (@listorders);
warn 'record number in listorders[0] : '.@listorders[0]-{biblionumber};
= everything is correct
record number : 2090 at Acquisition.t line 45.
ok 6 - GetOrdersByBiblionumber : result is defined
ok 7 - GetOrdersByBiblionumber : result contains at least one element
nborders in listorders : 1 at Acquisition.t line 49.
record number in listorders[0] : 2090 at Acquisition.t line 50.
So, as you say, the pbm must come from the test database.
Is there a way to look at its data ?
Mathieu
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #2) I think this is related to a bug I filed - only I was concentrating on the database relicts that are connected to those subs: bug 10021 Good catch, Katrin. Well, this patch could remove the first code. Your report is somewhat broader in scope. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Remove some unused subs |Remove some unused subs |from Overdues module, or do |from Overdues module |not export them | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #53 from mathieu saby mathieu.s...@univ-rennes2.fr --- Jonathan I did not see you answer. I never did that, and I am not sure it could be done in a few lines (need to find a biblio or create it, find a fund, a vendor etc). So if it is necessary, I could not do that today, and Jared need to revert the bug. Maybe the easier solution would be to take a look at Jenkins sample database, but I don't know where it is. I suppose there must already be some orders in it, because other tests of Acquisiton.t do not fail. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 --- Comment #9 from Owen Leonard oleon...@myacpl.org --- Created attachment 18167 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18167action=edit Bug 10166 [3.10.x] Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the no titles available for holds variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A Place hold button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A Place hold button should appear at the bottom. - No titles can be placed on hold Sorry, none of these items can be placed on hold. should appear at the top of the page. All titles should appear with warning messages. There should be no Place hold button. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17947|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10257] Make OpacSeparateHoldings work for non-logged in users
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 --- Comment #2 from Magnus Enger mag...@enger.priv.no --- (In reply to comment #1) Maybe this could work similar as bug 7740? If set to OpacURLBranch, the library is chosen based on the Apache environment variable BRANCHCODE. For example, this could be added to the OPAC section of koha-httpd.conf: SetEnv BRANCHCODE CPL Yeah, that is cool! But as far as I can understand, if you have say 50 libraries in one instance, you have to create 50 new apache configs, one for each library. I still think it would be nice to have a way to set the library based on a URL that does not require tweaking the Apache configs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #22 from Owen Leonard oleon...@myacpl.org --- Created attachment 18168 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18168action=edit [SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by bookseller Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #16639|0 |1 is patch|| Attachment #16639|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #17767|0 |1 is obsolete|| --- Comment #9 from Owen Leonard oleon...@myacpl.org --- Created attachment 18169 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18169action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a td isn't getting picked up by the translator unless it's inside a span. This patch adds the span and tidies up the text. To test, apply the patch and translate update a translation. Searching the po file for In transit from should return a result from detail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Version|master |3.14 --- Comment #12 from Jared Camins-Esakov jcam...@cpbibliography.com --- String changes, so this will be held for 3.14/3.12.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #48) Jenkins just has all the sample data on a Debian Squeeze server and runs the entire build/test process every time there is a change to the source code. http://wiki.koha-community.org/wiki/Continuous_Integration Hello Jared, In fact I don't understand at all why tests fail. Maybe I missed something. What are sample data? Is it sql files in installer/data/mysql/en/optional? I don't find any insert into the acquisition tables and t/db_dependent/Acquisition.t does not add orders. How is created this order? I suspect that the biblionumber key (l.44) is empty but I cannot check it :-/ (I include Chris in the loop) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] New: koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Bug ID: 10259 Summary: koha-*-zebra scripts are expected to run without warnings if no instance name passed Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com CC: ro...@catalyst.net.nz This files where modified to check the parameters for instance names. This sounds fine, but the init scripts expect the start script not to complain on missing instance parameters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 18170 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18170action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacionald de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #18170|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 18171 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18171action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10174] Digest is confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- I just got a suggestion - why not have it so that when you mouse over 'digest' it explains what it is? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Status|NEW |RESOLVED CC||me...@bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #6 from Melia Meggs me...@bywatersolutions.com --- I think was resolved with the patch for Bug 10243, so I am closing this out. *** This bug has been marked as a duplicate of bug 10243 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 --- Comment #6 from Melia Meggs me...@bywatersolutions.com --- *** Bug 9906 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4012] Can't place hold on specific copy if selecting more than 1 title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4012 --- Comment #4 from Nicole C. Engard neng...@gmail.com --- This is still a desired function. Since you can do it in the OPAC it only makes sense that the staff should be able to do it via the staff client. This came up in training today so I'm bumping this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10260] New: way to enter a note when writing off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260 Bug ID: 10260 Summary: way to enter a note when writing off Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be nice to have a way to have a note attached to the write off. A way to enter why you wrote off the fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10261] New: On pay fines tab patron tabs are missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Bug ID: 10261 Summary: On pay fines tab patron tabs are missing Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: cgi-bin/koha/members/pay.pl?borrowernumber=96 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com If you're on the pay fines tab you don't see the following tabs on the left as you should: Files Routing List Statistics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] New: fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Bug ID: 10262 Summary: fine calculation at checkin not respecting CircControl Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: me...@bywatersolutions.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The fine calculation at checkin is not respecting CircControl the way fines.pl does. (More details and test plan coming with a patch soon.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18172 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18172action=edit Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to the library you are logged in at 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to the library you are logged in at but it does make sense. The rules used are from the library you are logged in at when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using system have branches that charge fines, and others that don't, so a patron could just return any overdue item's to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18172|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18173 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18173action=edit Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to the library you are logged in at 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to the library you are logged in at but it does make sense. The rules used are from the library you are logged in at when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] New: Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Bug ID: 10263 Summary: Add ability to limit which branch can edit a bibliographic record Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: kyle.m.h...@gmail.com CC: m.de.r...@rijksmuseum.nl Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18174 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18174action=edit Bug 10200 - Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an empty choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the Edit record and Delete record options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Depends on||10206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10206] Add Koha TT Plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Blocks||10263 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10200] Add more Independent Branches options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Mickey Coalwell mcoalw...@nekls.org changed: What|Removed |Added CC||mcoalw...@nekls.org --- Comment #3 from Mickey Coalwell mcoalw...@nekls.org --- The problem was first identified by a situation in which fines were applied to an overdue item which was checked out an no-fines library was checked in at a fining library. I would want to see this situation tested as well. Did the overdue returned item check in fine-free at a fining library? Thanks, Mickey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7593] merging bib records loses connection to order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #55 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #54) (In reply to comment #48) Jenkins just has all the sample data on a Debian Squeeze server and runs the entire build/test process every time there is a change to the source code. http://wiki.koha-community.org/wiki/Continuous_Integration Hello Jared, In fact I don't understand at all why tests fail. Maybe I missed something. What are sample data? Is it sql files in installer/data/mysql/en/optional? I don't find any insert into the acquisition tables and t/db_dependent/Acquisition.t does not add orders. How is created this order? I suspect that the biblionumber key (l.44) is empty but I cannot check it :-/ (I include Chris in the loop) The tests fail, because they are dependent on orders existing for an existing supplier, but the test does not set up any of this up, so they work coincidentally on systems that have it set up, skip on others that have no orders, fail on others that have some orders but not the ones the test is expecting. I will make jenkins have data to make these tests pass, in future it would be good to make the tests test creating and deleting orders too, so that they can pass on any database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #4 from Mickey Coalwell mcoalw...@nekls.org --- I tested an overdue item checked out at a non-fining library and checked it in at a fining library. No fines accrued. Works for me. Mickey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Attachment #18173|0 |1 is obsolete|| --- Comment #5 from Melia Meggs me...@bywatersolutions.com --- Created attachment 18175 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18175action=edit [Signed off] Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to the library you are logged in at 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to the library you are logged in at but it does make sense. The rules used are from the library you are logged in at when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. Signed-off-by: Mickey Coalwell mcoalw...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs me...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Melia Meggs me...@bywatersolutions.com --- Mickey has done before and after tests on his production server, and this patch is working, so I am helping with the Git part of the sign off. Thanks, Mickey! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #18171|0 |1 is obsolete|| --- Comment #3 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 18176 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18176action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Robin Sheat ro...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10264] New: amazon cover not showing on results, but is on details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10264 Bug ID: 10264 Summary: amazon cover not showing on results, but is on details Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com Created attachment 18177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18177action=edit results - no image See attached. The amazon cover is showing on the bib detail page but not the results for some titles. Are they using a different way to look for images? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10264] amazon cover not showing on results, but is on details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10264 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Created attachment 18178 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18178action=edit details page - image -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10265] New: 830 needs spaces in opac display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Bug ID: 10265 Summary: 830 needs spaces in opac display Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com Created attachment 18179 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18179action=edit series display The subfields of the 830 are showing up without spaces in the series tag on the opac. See attached -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10265] 830 needs spaces in opac display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Created attachment 18180 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18180action=edit marc for 830 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] New: Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Bug ID: 10266 Summary: Restricted status doesn't show in OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: r...@poczta.onet.pl Reporter: katrin.fisc...@bsz-bw.de To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of Library Staff Only It should have been shown under status on the detail page of the OPAC, but was not -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Blocks||4173 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Depends on||10266 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18181 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18181action=edit Proposed patch Moved patch and bug description to a new bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #18181|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 18182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18182action=edit [PASSED QA] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of Library Staff Only It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea l...@catalyst.net.nz http://bugs.koha-community.org/show_bug.cgi?id=10266 Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and test plan. Simple change fixing a display problem, no string changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
