[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Signed off by packaging manager and packages related... passing QA.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6802] with IndependantBranches on can still edit items

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6802

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mag...@enger.priv.no
 Resolution|--- |DUPLICATE

--- Comment #5 from Magnus Enger mag...@enger.priv.no ---
Looks like this has been fixed on bug 10225.

*** This bug has been marked as a duplicate of bug 10225 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225

--- Comment #6 from Magnus Enger mag...@enger.priv.no ---
*** Bug 6802 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18202|0   |1
is obsolete||
  Attachment #18204|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18222
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18222action=edit
[PASSED QA] Bug 10270: GetOrdersByBiblionumber needs better unit tests

prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t

Signed-off-by:Mathieu Saby mathieu.s...@univ-rennes2.fr
I made 2 tests :
$prove -v t/db_dependent/Acquisition/GetOrdersByBiblionumber.t
and
$prove -v t/db_dependent/Acquisition.t
The 2 tests are successful.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
All tests and QA script pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18223action=edit
[PASSED QA] Bug 10270: Fix shebang

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10280] New: Extend SeparateHoldings functionality to the Add items screen

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10280

Bug ID: 10280
   Summary: Extend SeparateHoldings functionality to the Add
items screen
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@enger.priv.no
CC: gmcha...@gmail.com

If you have IndependantBrnaches turned on, the table of items at the top of the
Add items screen still displays all the items from all the libraries (with
the Edit/Delete links missing for the items that belong to other libraries then
the library of the logged in user). This can be a long and not very useful list
if there are a lot of libraries and copies. 

It would be nicer if this display was governed by the SeparateHoldings syspref,
and items from other libraries were e.g. put in a second tab (so they are
available to look at, but not in your face immediately).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma'

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This works on the results and details screen for tagging a single record. 
We also have options for tagging in the cart, the lists and in the result list
menu - maybe we should add a hint there too? I like the initial idea of a
tooltip, but I agree that on the detail pages having it directly in the label
is more obvious.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18176|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18224
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18224action=edit
[PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma'

Some sites split tags on spaces, some on commas. Since Koha splits on a
comma, we should make that clear to the patron. This patch adds
additional text to the New tag(s) label.

To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList.
Click Add tag on both OPAC search results and an OPAC detail page.
Confirm that the revised label appears correctly.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com
all tests pass

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
All tests pass. There are some more places where we can
add tags to multiple records at once, I noted them on the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma'

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma'

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18176|1   |0
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 18176
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18176
Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no
instance name passed

Sorry, had the wrong bug number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18224|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master and 3.12.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jared Camins-Esakov jcam...@cpbibliography.com ---
This patch has been pushed to master and 3.12.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] New: Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

Bug ID: 10281
   Summary: Search domains do not seem to work
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: mag...@enger.priv.no

I added two libraries and added them to a search domain (with code NARVIK).
One of them owns The hobbit and the other owns Lord of the rings. 

- When I search for hobbit in the first library I get one hit as expected. 
- When I search for rings in the second library I also get one hit as
expected. 
- When I search for tolkien in the group I get no results. 
- When I search for hobbit or rings in the group I get no results.
- When I search for tolkien in all libraries I get two hits, as expected. 

Are search domains (a.k.a search groups of libraries) broken or is there some
missing config step? The documentation does not seem to mention anything of
that sort. 

The URLs for the search limited to the search domain looks like this:

OPAC, simple search (with OpacAddMastheadLibraryPulldown activated):
/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK

OPAC, advanced search:
/opac-search.pl?idx=kwq=tolkienidx=kwidx=kwdo=Søkmultibranchlimit=NARVIKsort_by=relevance

Intranet search:
/cgi-bin/koha/catalogue/search.pl?idx=kwq=tolkienidx=kwidx=kwmultibranchlimit=NARVIKsort_by=relevance

I have tried a full sudo koha-rebuild-zebra -f -v instancename, but that
did not change anything.

Tested on 3.12 rc2 package install, no memcached or anything else fancy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

--- Comment #1 from Magnus Enger mag...@enger.priv.no ---
Here are the errors I get when I limit to a group and get no results:

OPAC, simple search:

[Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK
[Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK
[Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01
2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and ()
ZOOM error 10014 CCL parsing error (addinfo: Search word expected) from
diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK

OPAC, advanced search:

[Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK
[Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkienbranch_group_limit=multibranchlimit-NARVIK
[Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl
[Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22
2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl
[Sat May 18 14:04:23 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:23
2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and ()
ZOOM error 10014 CCL parsing error (addinfo: Search word expected) from
diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer:
http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

  Attachment #17756|0   |1
is obsolete||

--- Comment #4 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18226
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18226action=edit
[PATCH]  Bug 10135 : Add the ability to define customised basketgroups pdf
layouts

correction of a typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

--- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 18227
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18227action=edit
Bug 10281: searching for a search domain fails

For reasons I cannot fathom, the split() in handling multi-branch
limits was not coming up with a valid search group code. Replacing
the split() with a substr() and creating the CGI parameter as a string
rather than as an arrayref fixes the problem. This problem may not
affect all installations, since I tested this exact feature just under
two months ago and it worked fine, and none of the relevant code has
been changed since then that I can see.

To test:
1) Create search group, and add at least one library to it, in
   /cgi-bin/koha/admin/branches.pl
2) Apply patch
3) Try doing a search limited to your search group, making sure that
   the search will match items that belong to a library in the search
   group
4) Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9806] Show more information on basketgroups lists

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806

--- Comment #17 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 18228
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18228action=edit
[PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names

With this followup, instead of passing the real names of the branches to
template file, only the branchcodes are passed.
The branchcodes are translated into branchnames in template file, using the
KohaBranchName template plugin.

To test :
do the same test as for main patch :
1) make some basketgroups with 0, 1, 2 baskets
2) make some basketgroups with different billing and deliveryplace
3) check the list of open and closed basketgroups
4) check action buttons are working like before

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9806] Show more information on basketgroups lists

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Nicole C. Engard neng...@gmail.com ---
The link is there now but the link doesn't include the borrowernumber so it
doesn't open right: /cgi-bin/koha/members/files.pl?borrowernumber=

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #18227|0   |1
is obsolete||

--- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 18229
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18229action=edit
Bug 10281: searching for a search domain fails

For reasons I cannot fathom, the split() in handling multi-branch
limits was not coming up with a valid search group code. Replacing
the split() with a substr() and creating the CGI parameter as a string
rather than as an arrayref fixes the problem. This problem may not
affect all installations, since I tested this exact feature just under
two months ago and it worked fine, and none of the relevant code has
been changed since then that I can see.

To test:
1) Create search group, and add at least one library to it, in
   /cgi-bin/koha/admin/branches.pl
2) Apply patch
3) Try doing a search limited to your search group, making sure that
   the search will match items that belong to a library in the search
   group
4) Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18100|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18230
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18230action=edit
[PASSED QA] Bug 9452: C4::Letters not Plack-compatible

Prior to this patch, at more-or-less random intervals pages working
with notices will cease to function. To test:

1) Apply patch.
2) Try to edit some notices.
3) Trigger some notices.
4) If you were able to edit the notices and trigger the notices, sign
   off.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
All tests and QA script pass.
I did a regression script without Plack:
- edit, add, delete and copy notice
- trigger checkout/checkin notice
- print issueslip
No problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9452] C4::Letters does not function under Plack

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10230] Match points do not work with authorities

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #18101|0   |1
is obsolete||
  Attachment #18102|0   |1
is obsolete||
  Attachment #18103|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18231
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18231action=edit
[PASSED QA] Bug 10230: no need to use SimpleSearch for matching auths

When introducing QueryParser, I introduced a check for QueryParser at
too high a level, causing authority matching to try and use SimpleSearch
for authorities prematurely, when SearchAuthorities should be handling
it. This patch corrects the level of the check. This patch only moves
three lines, but thanks to the change in if level, it adjusts the
indentation quite a bit.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Comments on third patch of this series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10230] Match points do not work with authorities

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10230] Match points do not work with authorities

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18232
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18232action=edit
[PASSED QA] Bug 10230: Don't limit valid matches to bibs

The patch for bug 9523 added a JOIN to the biblio table when identifying
the best match so that if a matched record had been deleted it would
not hold up the import process. Unfortunately, this broke all authority
matching, since of course authorities don't appear in the biblio table.
This patch adds a join to auth_header as well, and decides which to
check based on the record type.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Comment on third patch of this series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10230] Match points do not work with authorities

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10230] Match points do not work with authorities

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 18233
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18233action=edit
[PASSED QA] Bug 10230: show correct matching record

The correct matching record was not always shown on the manage staged
MARC page. This patch corrects the issue and provides the template with
the appropriate ID for the matched record regardless what type of record
it is.

To test:
1) Create a matching record for authorities. For MARC21, the following
   is a good choice:
   Matching rule code:  AUTHPER
   Description: Personal name main entry
   Match threshold: 999
   Record type: Authority record
   [Match point 1:]
Search index:   mainmainentry
Score:  1000
Tag:100
Subfields:  a
2) Create a record that has the appropriate fields for being matched
   with that rule (if you don't already have one).
3) Save the authority record as MARC (Unicode/UTF-8).
4) Stage the file choosing your new matching rule.
5) Note that with these patches, you get a link to the existing
   authority and without them you could get any number of strange
   things.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes all tests and QA script. Additional tests done:
- staged bibliographic records and matched with different
  rules and actions. Undid the import.
- staged autohrity recods and matched with the example rule.
  Undid the import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

  Attachment #18229|0   |1
is obsolete||

--- Comment #4 from Magnus Enger mag...@enger.priv.no ---
Created attachment 18234
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18234action=edit
Bug 10281: searching for a search domain fails

For reasons I cannot fathom, the split() in handling multi-branch
limits was not coming up with a valid search group code. Replacing
the split() with a substr() and creating the CGI parameter as a string
rather than as an arrayref fixes the problem. This problem may not
affect all installations, since I tested this exact feature just under
two months ago and it worked fine, and none of the relevant code has
been changed since then that I can see.

To test:
1) Create search group, and add at least one library to it, in
   /cgi-bin/koha/admin/branches.pl
2) Apply patch
3) Try doing a search limited to your search group, making sure that
   the search will match items that belong to a library in the search
   group
4) Sign off

Signed-off-by: Magnus Enger mag...@enger.priv.no
I have failed to recreate the problem on three different dev installs,
both on Ubuntu and Debian, but the current patch does not break
anything as far as I can tell, so I'm signing off.

I tested with two libraries in the same search domain, with each
library owning a different book by the same author. Searching for
the author in
- all libraries,
- individual libraries and
- the search domain that contains both libraries
all return the expected results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10281] Search domains do not seem to work

2013-05-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/