[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m

--- Comment #13 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
As described in Koha Manual, 

1.12.12. EnhancedMessagingPreferences

Default: Allow

Asks: ___ patrons to choose which notices they receive and when they receive
them.

Values:

Allow

Don't allow

Important

This only applies to certain kinds of notices, overdue notices will be sent
based on the library's rules, not the patron's choice.

So this syspref is defined to allow patrons to choose the notifications they
want to receive. What Victor describes as a problem is not one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18376
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18376action=edit
Bug 10298: Followup: Adapt existing code

This unit tests file does not need the t::lib::Mocks::Context module.

To test:
prove t/db_dependent/Circulation_issuingrules.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] New: Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Bug ID: 10328
   Summary: Rename opaccolorstylesheet to OpacColorStyleSheet
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Blocks||10327

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Depends on||10328

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18377
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18377action=edit
Bug 10328 - Rename opaccolorstylesheet to OpacColorStyleSheet

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Verify the system pref OpacColorStyleSheet still works
   i.e. no change should be noted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] New: Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

Bug ID: 10329
   Summary: Rename system preference marcflavour to MarcFormat
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks||10329

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Depends on||10327
   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18378
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18378action=edit
Bug 10329 - Rename system preference marcflavour to MarcFormat

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) View and edit some records
4) You should not see any change in functionality

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks||10328
 Depends on|10328   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks|10327   |
 Depends on||10327

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks||10327
 Depends on|10327   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks|10328, 10329|
 Depends on||10328, 10329

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Blocks||10327
 Depends on|10327   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10330] New: Rename system preference authoritysep to AuthoritySeperator

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330

Bug ID: 10330
   Summary: Rename system preference authoritysep to
AuthoritySeperator
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Depends on||10330

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Blocks||10327
   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18379
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18379action=edit
Bug 10330 - Rename system preference authoritysep to AuthoritySeperator

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) View some records with authorities
4) Note your previously set authority separator should still be in use

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #18378|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 18380
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18380action=edit
Bug 10329 - Rename system preference marcflavour to MarcFormat

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) View and edit some records
4) You should not see any change in functionality

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] New: Little errors in unimarc_field_4XX.pl (punctuation)

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Bug ID: 10331
   Summary: Little errors in unimarc_field_4XX.pl (punctuation)
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: janus...@gmail.com
CC: m.de.r...@rijksmuseum.nl

The punctuation in subfield $a in linking fields 4XX is wrong when filling it
up with the unimarc_field_4XX.pl

To reproduce:

A.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $f filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to fetch data
from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (no closing bracket)

B.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 700 $a, $b, $c, $f filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to fetch data
from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (dash instead of semicolon
between original $c and $f, no closing bracket)

C.
1) have $a active in one of the linking fields (like 461, 463, etc.).
2) have a biblio record with the field 702 $a, $b, $c filled up
3) go to cataloguing - field 4XX of your choice, use the plugin to fetch data
from biblio rec. mentioned in b)
4) see the punctuation in $a -- it will be wrong (unnecessary semicolon after
original $c, n.b. lacking space).

A patch will follow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |janus...@gmail.com

--- Comment #1 from Janusz Kaczmarek janus...@gmail.com ---
Created attachment 18381
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18381action=edit
Proposed patch

The patch corrects the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] New: UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Bug ID: 10332
   Summary: UT: CourseReserves.t needs to create its own data
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/Acquisition/CourseReserves.t depends on the Jenkins database.
We should create the data we want and delete them at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10332

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18382
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18382action=edit
Bug 10332: CourseReserves.t needs to create its own data

prove t/db_dependent/CourseReserves.t
t/db_dependent/CourseReserves.t .. ok
All tests successful.
Files=1, Tests=20,  2 wallclock secs ( 0.02 usr  0.00 sys +  0.43 cusr
0.03 csys =  0.48 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10184] Circulation History reverses sort order

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #8 from Owen Leonard oleon...@myacpl.org ---
I set to Failed QA because of the issue with the table header sort indicator.
I see your point about the forced re-sort. In my tests there was a minor
difference in processing time, but I didn't test with an account with a large
history (only ~120). The indicator is a minor point, so I'll give the re-sort
question the benefit of the doubt and say it's not worth the extra processing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10184] Circulation History reverses sort order

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10184] Circulation History reverses sort order

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

  Attachment #17933|0   |1
is obsolete||

--- Comment #9 from Owen Leonard oleon...@myacpl.org ---
Created attachment 18383
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18383action=edit
[SIGNED-OFF] Bug 10184 - Circulation History reverses sort order

Issue data is passed to the readingrec template ordered
most recent due date first. Datatables unless specified
otherwise do a presort on the data they will display
the default results in an order the reverse of what was
intended. Disabling the presort preserves the initial sort
order until the user selects a different sort

http://bugs.koha-community.org/show_bug.cgi?id=10184
Signed-off-by: Owen Leonard oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
If we're renaming this one, maybe we should rename it to something which better
describes its use? It's not really a stylesheet for color, even though that was
the original intention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10333] New: UT: Labels/t_Batch.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

Bug ID: 10333
   Summary: UT: Labels/t_Batch.t needs to create its own data
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/Labels/t_Batch.t depends on the Jenkins database.
We should create the data we want and delete them at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10273
 Depends on|10273   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks|10332   |
 Depends on||10332

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10333

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||10273
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18384
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18384action=edit
Bug 10333: Labels/t_Batch.t needs to create its own data

prove t/db_dependent/Labels/t_Batch.t
[14:53:09]
t/db_dependent/Labels/t_Batch.t .. 1/32 # Testing Batch-new() method.
t/db_dependent/Labels/t_Batch.t .. 13/32 # Testing Batch-retrieve()
method.
t/db_dependent/Labels/t_Batch.t .. ok
All tests successful.
Files=1, Tests=32,  3 wallclock secs ( 0.02 usr  0.00 sys +  0.48 cusr
0.03 csys =  0.53 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10334] New: UT: t/db_dependent/needs_user_input/* are unusable

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334

Bug ID: 10334
   Summary: UT: t/db_dependent/needs_user_input/* are unusable
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/needs_user_input/Auth.t and
t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I
refer to the git history, it seems that they are antiquated tests.

The first one is not compilable:
perl -wc t/db_dependent/needs_user_input/Auth.t
Can't locate override_context_prefs.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||10273
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10334

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18385
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18385action=edit
MT10334: t/db_dependent/needs_user_input/* are unusable

t/db_dependent/needs_user_input/Auth.t and
t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful.
If I refer to the git history, it seems that they are antiquated tests.

The first one is not compilable:
perl -wc t/db_dependent/needs_user_input/Auth.t
Can't locate override_context_prefs.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10335] New: UNIMARC authorities search doesn't display properly information on parallel form

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Bug ID: 10335
   Summary: UNIMARC authorities search doesn't display properly
information on parallel form
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Authority data support
  Assignee: gmcha...@gmail.com
  Reporter: janus...@gmail.com

UNIMARC authorities can contain translated headings.  The language is coded in
$8 subfield:

Subfield $8 contains 6 character positions (designated as $8/0, 8/1, etc.) 
The first group of three characters specifies the language of catalogue into
which the heading in the field is designed to fit; the second group of three
characters specifies the language of the base heading. The language codes are
listed in the ISO 639-2 standard and in Appendix A of the UNIMARC Manual -
Bibliographic Format.  (cf. UNIMARC manual : authorities format. -- 2nd rev.
and enl. ed. -- München : Saur, 2001, p. 66)

I.e. it is the second triple designates the language of in which the actual
parallel form is entered. 

Currently the information is displayed wrongly.  

To reproduce:
1) Create an authority record with main heading (100) in Latin script (e.g.
Oppenheimer, Aharon -- subfields $a and $b) and parallel form (700) in Hebrew
(אופנהיימר, אהרן -- subfields $a and $b). Mark it correctly in $8 with freheb
(or engheb if you like);
2) reindex and search;
3) you will see: 

Oppenheimer Aharon
freheb: אופנהיימר 

Whereas you would rather like to see (mind language and lack of $b above):

Oppenheimer, Aharon 
Hebrew: אופנהיימר, אהרן 

A patch will follow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |janus...@gmail.com

--- Comment #1 from Janusz Kaczmarek janus...@gmail.com ---
Created attachment 18386
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18386action=edit
Proposed patch

The patch corrects the issue and should not harm those who (improperly) put
only one triple in $8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9864] systematic searching error : can't call method raw

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864

--- Comment #7 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I made the update (it's already some weeks ago) as you suggested in comment 3
perl Makefile.PL --prev-install-log /home/[USER]/koha-dev/misc/koha-install-log

but seems there's a problem with dev install update :
What happens is that files present in our /home/[USER]/koha-dev/etc/zebradb
repertory are saved and postfixed with current version number (something like
retrieval-info-auth-grs1.xml_3.08.88 ) but new retrieval and mar files are not
copied from /home/[USER]/src/etc/zebradb in it. Moreover, record.abs and
koha-conf.xml aren't updated.

So I made the minimum necessary modifications by hands (only for unimarc
flavour et grs1 indexation) :
first I deleted all saved files then
copied the 2 unimarc retrieval files (unimarc-retrieval-info-auth-grs1.xml and
unimarc-retrieval-info-bib-grs1.xml) from /home/[USER]/src/etc/zebradb in
/home/[USER]/koha-dev/zebradb
copied unimarc.mar file in /home/[USER]/koha-dev/zebradb/etc
replaced 'marc usmarc.mar' line by 'marc unimarc.mar' in record.abs 
replaced all occurrences of syntax=usmarc by syntax=unimarc in
koha-conf.xml
reindexed and it's ok 

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

--- Comment #22 from Janusz Kaczmarek janus...@gmail.com ---
(In reply to comment #20)
 I do not think this is correct. Subfield 'e' is not authority-controlled,
 but Koha treats all non-numeric subfields in authority-controlled fields as
 if they are. Or am I misunderstanding what this bug does, and there is a
 workaround for this?

OK, the action of the modified merge procedure is based on Select to display
or not (i.e. auth_subfield_structure.hidden) and of course one has to be
cautious about it.  If a subfield of the heading is hidden in authority editor
== it not supposed to be controlled == will never be overwriten.  This would be
the case of auth. 100 applied on biblio. 700 with $e present.  $e will stay
untouched provided it is not active in the authorities framework.

Why I now think it is really important: a very common case for my libraries
(participating in a cooperative cataloguing program) are personal headings with
duplicated family name + surname.  So, if the librarian who creates the entry
does no know the dates, he/she adds a qualifier like $c.  But then another
librarian who found the dates (maybe after some months or even years) exchanges
$c for $d in the authority data.  Now, without this enhancement you will have
$c and $d in bibliographic records, which is what you don't want. 

Another reason is the case when wrongly entered data was propagated to several
dozens of biblio recs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Janusz Kaczmarek janus...@gmail.com changed:

   What|Removed |Added

   Attachment #7264|0   |1
is obsolete||

--- Comment #23 from Janusz Kaczmarek janus...@gmail.com ---
Created attachment 18387
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18387action=edit
Proposed patch - refreshed

Applies smoothly to master (as on 24th May 2013)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5943

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5943] Merging Authorities

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5943

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5572

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] New: UT: HoldsQueue.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Bug ID: 10336
   Summary: UT: HoldsQueue.t needs to create its own data
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

t/db_dependent/HoldsQueue.t depends on the Jenkins database.
We should create the data we want and delete them at the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10336

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||10273
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18388
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18388action=edit
WIP: HoldsQueue.t needs to create its own data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

--- Comment #29 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #28)
  Perhaps we have fines logic in too many places. Maybe MaxFines logic needs
  to be moved to CalcFine as well.
 
 I agree with Galen that moving them both out of the prefs would be great.
 But adjusting a lot of troublesome circulation code would be great too.

The thing is, not taking the time to set a new circ policy switch at the right
level of specificity just adds to the refactoring work that has to be done
later.

Setting back to in discussion to ask the question of Kyle directly: are you
willing to prepare a version of this patch that adds this limit as a
issuingrules policy, not a system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hi Kyle,

I tried to pass HoldsQueue unit tests but I am not able to do :-/
The idea is to create all data the tests need before launching them in order
not to be dependent on the Jenkins database.

Could you take a look at it please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] New: UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Bug ID: 10337
   Summary: UT: The unit tests cannot be launched by everyone
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com

Currently, only jenkins is able to launch tests successfully.
It would great to have a file in the db_dependent directory to initialize the
database structure with sample data.
Like that all developers will be able to launch unit tests and check if a
development breaks something.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10273

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10337

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10298

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10337

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18389
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18389action=edit
Bug 10337: Unit tests is based on an existing database

This patchs adds a new unit tests file which will launched before all
others db_dependent tests.
It will drop and recreate the database with sample data.

Prerequisite:
The database 'koha_ut' have to be created with
  CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
I create a new database containing sample data with script submitted on bug
10337.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10206] Add Koha TT Plugin

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #11 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Please note that I adjusted the commit message to include
the example usage found in the POD.

Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
This patch is proposed for discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18389|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 18390
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18390action=edit
Bug 10337: Unit tests is based on an existing database

This patchs adds a new unit tests file which will launched before all
others db_dependent tests.
It will drop and recreate the database with sample data.

Prerequisite:
The database 'koha_ut' have to be created with
  CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120

--- Comment #14 from Galen Charlton gmcha...@gmail.com ---
For future reference, the IRC discussion in question starts at

http://irc.koha-community.org/koha/2013-04-25#i_1239245

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120

--- Comment #15 from Galen Charlton gmcha...@gmail.com ---
And a general comment: perhaps we should consider having loan records either
store a copy of the circ policy that applies to the loan (e.g., issuelength,
lengthunit, fine, finedays, etc.) or a reference to it (e.g,. by first giving
issuingrules an opaque PK, then adding that as a FK to issues).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120

--- Comment #16 from Galen Charlton gmcha...@gmail.com ---
And of course, Chris already suggested that. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #17 from Galen Charlton gmcha...@gmail.com ---
I have pushed the main patch to master, though with a bit of reluctance as I
suspect the need for this syspref will go away if/when the underpinnings of
fine accounting are improved.

I have *not* pushed the follow-up whitespace patch; it might just be me, but I
found that it made that section of code *less* readable, not more.  Among other
reasons, I really prefer that comments be indented at the same level as the
block they apply to.

I suggest that we just plan on running C4/Circulation.pm through perltidy at
some point in the near future.

Thanks, Chris!

RMaint 3.12 please take note: I believed that this is considered a blocker by
at least one library to upgrading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9161] Translate only specific files

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #11 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9424] Move JavaScript out of header include

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9424] Move JavaScript out of header include

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #18358|0   |1
is obsolete||

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Created attachment 18391
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18391action=edit
Bug 9424: Move JavaScript out of header include

This patch removes JavaScript onlick attributes from header.inc and
moves the functionality to staff-global.js. This is in keeping with the
idea of progressive enhancement.

To test, be sure to clear your browser cache after applying the patch.

- Test the help link.
- Test the logout link with the intranetbookbag preference on and off.
- Open a patron's account and click search to hold. Log out, and log
  in again. Koha should not remember the patron you chose before
  logging out (as seen from a search results page).

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #10 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #9)
 Maybe we could just copy from opacheader into the new preference on database
 update and preserve the current customizations that way?

Wouldn't copying over the contents of 'opacheader' to a new preference cause a
bit of a surprise (in the form of duplicate text or the like) for libraries
that aren't using CCSR?

Also, that begs the question of whether a new system preference is needed --
shifting logos around could be done via OpacUserCSS, and at the moment I'm not
convinced that we need to maintain backwards compatibility for what appears to
simply have been an oversight.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
We should probably decide on some ground rules for this.  I'm not opposed to
the idea in general terms, as choosing better names for some system preferences
can improve Koha's polish.  However, I think it safe to assume that there are
no system preferences so poorly named that it's worth risking functionality
breakage.

Here are my preferences regarding system preference names:

- They should make positive assertions.  Consequently, noItemTypeImages and
noissuescharge should be considered for renaming.
- They should be fully spelled out except for very well-known acronyms (e.g.,
MARC is OK in a syspref name)
- They should describe their current purpose.

And some caveats:

- If a system preference name is also used for other purposes, particularly
database column names, the bar is going to be higher for accepting the patch. 
I'm thinking of 'marcflavour' in particular.  I value consistency in the code
base pretty highly; I would rather have a non-optimal name be used throughout
than mixing old and new names for the same concept.
- Patches that just rename system preferences are much more likely to be
accepted at the beginning of a release than at the end.
- It is OK for Koha to have a few idiosyncrasies.  Unless there's evidence that
a given name is *actually* confusing to users, these patches are never going to
be high priority.

One thing for folks to keep in mind is that system preference lookup (as with
everything else in MySQL) is case-INsensitive.  Consequently, if you're
grepping for a system preference name, remember to use -i

By the way, thanks, Kyle, for creating the omnibus bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5380] an end to copy-and-paste-itis

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5380

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #6)
 I am tempted to close this as it has not seen any attention in quite a
 while. It might be worth doing individual bugs for removing code as this can
 always have dangerous side effects.

I agree -- obviously I'm keen to extirpate copy-pasta on sight, but I don't
think this omnibus bug needs to remain open.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Just noting that as of today, the patch series still applies cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10039] the systempreferences.variable column should be a unique key

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10039

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #3)
 (In reply to comment #2)
  Same conclusion here, the variable names are already unique.
 These primary keys nowadays are no longer what they used to be :)

I don't trust them!

In the cold light of today, I have no idea why I opened this.  I can only
assume that I had run into a database that had dropped the PK for some reason.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5324] bring out the dead! in C4

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5324

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WISHLIST

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #1)
 I think this was thought to be an umbrella bug, but it has not got any
 attention. Maybe we should close and start over? Or can we find some bugs to
 link to this? :)

Why bring an umbrella to the desert? :)

I agree; I'm closing this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9864] systematic searching error : can't call method raw

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #8 from mathieu saby mathieu.s...@univ-rennes2.fr ---
I never notice this problem, that's strange.
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4306] Label manage batch listing should show item-level itemtype

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4306

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
(In reply to comment #3)
 Now the list shows the item type if it has been set at the biblio level and
 the collection code if it has not. I don't think this is the intended
 outcome.

Do you still see this happening?  I'm not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10338] New: Search history can cause Out of memory errors

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338

Bug ID: 10338
   Summary: Search history can cause Out of memory errors
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P3
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jwea...@bywatersolutions.com

After a certain number of searches, thawing the search history cookie (line
~296 of C4/Auth.pm) can cause an Out of memory error, causing all OPAC
scripts to stop working. This seems to occur after a certain number of
searches, but does not seem to be related to corruption or truncation due to
the max cookie size.

The current workaround is to disable OPAC search history (the 
EnableOpacSearchHistory syspref).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320

Jesse Weaver jwea...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10327] Rename poorly named system preferences

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
I would also urge folks to write test cases exercising each syspref that get
srenamed, as that would make the benefit not just cosmetic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #18303|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 18392
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18392action=edit
Bug 10293 - Bug 9930 needs to be reverted for 3.10.x

The patch for bug 9930 needs to be reverted for 3.10.x, as the patron
self registration feature is not part of 3.10.x. With the patch applied,
the OPAC patron details link may redirect to a non-existent page (
opac-memberentry.pl ).

Test Plan:
1) Set OPAC to use CCSR theme.
2) Log into the OPAC.
3) Click the link for your username.
4) Click the my personal details tab.
5) Note the error page you get
6) Apply this patch
7) Refresh the page
8) You should now see the user details update page

This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
One for you Bernardo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
Version|3.10|master

--- Comment #9 from Chris Cormack ch...@bigballofwax.co.nz ---
This bug is present on 3.12.x and master also

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Depends on||10120

--- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz ---
In order to QA this patch on master, I needed to fix a conflict with bug 10120.
This makes this patch now dependent on it.

If 10120 is not pushed to 3.12.x and 3.10.x then the original patch would work
(I'd of course prefer 10120 to be pushed as it is blocking some of my libraries
from upgrading)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Blocks||10262

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl

2013-05-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >