[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755
--- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Jared, could you tell my why you exclude 999 field in this line of
createMarcHash ?
I don't know how the 999 is used by Koha...
+if ((!defined($tagslib) || $tagslib-{$fieldtag}-{'tab'} = 0)
$fieldtag ne '995' $fieldtag ne '999') {
M. Saby
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10368] New: Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Bug ID: 10368 Summary: Added price in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: amit.gu...@osslabs.biz Added price in overdue report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr --- As 995 is excluded (for UNIMARC), I suppose 952 should have do (for Marc21) ? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8015] Add MARC Modifications Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #96 from Jonathan Druart jonathan.dru...@biblibre.com --- I updated the git branch just now. All patches (submitted on this report) are rebased against master (just 2 conflicts with the first patch on updatedatabase.pl and kohastructure.sql). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755
--- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to comment #10)
Jared, could you tell my why you exclude 999 field in this line of
createMarcHash ?
I don't know how the 999 is used by Koha...
+if ((!defined($tagslib) || $tagslib-{$fieldtag}-{'tab'} = 0)
$fieldtag ne '995' $fieldtag ne '999') {
M. Saby
999 is where the biblioitemnumber and biblionumber are stored (at least in
MARC21) 999$c and 999$d
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #11) As 995 is excluded (for UNIMARC), I suppose 952 should have do (for Marc21) ? M. Saby 995 was excluded originally (if you look at merge.pl). So we are still excluding it. However for quite a while the item data has not been stored in the MARCXML, and the way we fetch the MARC biblio is by calling my $record = GetMarcBiblio($biblionumber); So the item data is not added, if it was called with my $record = GetMarcBiblio($biblionumber, 1); Then items would be added so 952. So in our case, we have the MARC object, with no item data ie no 952 (in theory no 995 as well, but im not sure about that so left that exclusion in there). So no need to exclude the 952. I hope this helps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #14 from mathieu saby mathieu.s...@univ-rennes2.fr --- OK, I thought it was in 090a, like in UNIMARC. So, if it useful NOT to merge 999 for Marc21, maybe it will be usefull NOT t to merge 090 too, for UNIMARC? But 999 could also be used for other purpose I suppose, in Marc21 and in UNIMARC. For example, in UNIMARC, Academic libraries can use this subfield freely, for their own use. Cette zone peut être utilisée librement pour des données ne correspondant à aucune zone du format d'échange standard, suivant les besoins de chaque bibliothèque. http://documentation.abes.fr/sudoc/formats/loc/zones/999.htm#UtilisationActuelle M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #14) OK, I thought it was in 090a, like in UNIMARC. So, if it useful NOT to merge 999 for Marc21, maybe it will be usefull NOT t to merge 090 too, for UNIMARC? But 999 could also be used for other purpose I suppose, in Marc21 and in UNIMARC. For example, in UNIMARC, Academic libraries can use this subfield freely, for their own use. Cette zone peut être utilisée librement pour des données ne correspondant à aucune zone du format d'échange standard, suivant les besoins de chaque bibliothèque. http://documentation.abes.fr/sudoc/formats/loc/zones/999. htm#UtilisationActuelle M. Saby It could but that would be dangerous of them, because 999 is used for Koha specific data, and merging them makes no sense, you cant have a record that has 2 biblionumbers that would break things badly. Maybe you could send a follow up patch that doesn't exclude 999 if the flavour is UNIMARC. This is still a major improvement though, and makes it much less likely for the merge to create an invalid record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10369] New: Added Sort1 in circulation page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Bug ID: 10369 Summary: Added Sort1 in circulation page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: amit.gu...@osslabs.biz CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Added Sort1 in circulation page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10368] Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Assignee|gmcha...@gmail.com |amit.gu...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10369] Added Sort1 in circulation page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |amit.gu...@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10370] New: Adding Callno barcode on circulation print page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Bug ID: 10370 Summary: Adding Callno barcode on circulation print page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: amit.gu...@osslabs.biz CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Adding Callno barcode on circulation print page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |amit.gu...@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10369] Added Sort1 in circulation page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10368] Added price in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #16 from mathieu saby mathieu.s...@univ-rennes2.fr --- OK, so the solution could probably be - exclude merge of 999 for MARC21 / NORMARC - exclude merge of 090 for UNIMARC Am I right? For the 995, as you said, it is no more in main marc record, so I suppose we could drop the exclusion of 995. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
CC||jonathan.dru...@biblibre.co
||m
--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
1/ There is no unit tests for new subroutines introduced in C4::Charset and
C4::AuthoritiesMarc packages.
2/ There is no call to C4::Charset::SanitizeEntity, where it is used?
3/ The C4::AuthoritiesMarc::_process_subfcode_4_merge checks if a string
exists: q{S'emploie uniquement en subdivision chronologique} but there is no
comment to explain what is it.
Marked as Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #17 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #16) OK, so the solution could probably be - exclude merge of 999 for MARC21 / NORMARC - exclude merge of 090 for UNIMARC Am I right? For the 995, as you said, it is no more in main marc record, so I suppose we could drop the exclusion of 995. M. Saby Yep I'd wait for this improvement to be pushed, then open a new bug to do that follow up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18450 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18450action=edit Bug 8304: UT for new subroutines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- 3 unit tests in t/Charset do not pass, I think there is a bug in C4::Charset::SanitizeEntity. I cannot provide unit tests for the C4::AuthoritiesMarc::_process_subfcode_4_merge routine, I don't understand what it does. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on||10298 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||8304 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Just move a js line some lines before. No regression possible. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18440|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18451 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18451action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $(select[name='idx']).append(option value='Host-item,wrdl'Journal title/option); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18442|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18452 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18452action=edit bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch Assignee|oleon...@myacpl.org |gmcha...@gmail.com QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch fixes a bug and improves the code. No regression found. Thanks for unit tests! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This couldn't be pushed, because it caused another bug on 10088. I would like to see this solved with a patch for 3.10 specifically and the patch being signed off also making sure the problem from 10088 doesn't occur. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch replaces the YUI AJAX stuff with jQuery. It is a more readable and adds a new step to get rid of YUI. There is no more occurrence of 'YAHOO' in the cataloguing/value_builder directory. I tested the unimarc plugin and it works like as before. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18444|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18453 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18453action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the ... link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried 245_subfield_c instead of 210c_subfield_c. Nonsensical, but useful for testing. Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Tried the 3 MARC21 plugins. Did not try the Unimarc one, but it's exactly the same code change. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #9 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #7 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10371] New: Show item status in cart list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Bug ID: 10371 Summary: Show item status in cart list Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: amit.gu...@osslabs.biz Show item status in cart list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10371] Show item status in cart list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Assignee|oleon...@myacpl.org |amit.gu...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10371] Show item status in cart list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18454 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18454action=edit Bug 9902 - item subfields not populating Test Plan: 1) Create a new serial with a default location, call number, and library ( the library will need to be any but the one you are logged in as ) 2) Click the Recieve button for this serial 3) Click Click to add item 4) Note those values are not populated 5) Apply the patch 6) Reload the page 7) Click Click to add item 8) Note those values are now populated Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass! Signed-off-by: Chris Cormack chr...@catalyst.net.nz This seems to restore the former behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #17257|[PASSED QA] Bug 9902 - item |[PUSHED 3.12master][PASSED description|subfields not populating|QA] Bug 9902 - item ||subfields not populating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18454|Bug 9902 - item subfields |[3.10.X] Bug 9902 - item description|not populating |subfields not populating -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #17114|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Jonathan, did you see my comment 17? Bit worried about the problems with bug 10088. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10088] software error when filling a basket with staged record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10088 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9902 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||jonathan.dru...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10088 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #12 from Chris Hall chr...@catalyst.net.nz --- A quick look through this patch shows that it seems to be applicable for 3.8.x, however the patch in its current form does not apply cleanly. It is possible for you to rebase and submit a version for 3.8.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9902] item subfields not populating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Nicole, I submit a patch for the 3.10 branch. Could you test it please? Patch for 10088 has to be applied too! @Katrin, No I did not see your comment before submitting the patch, sorry :-/ But if 2 patches are pushed together, I expect not to have problem. Don't you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8304] composed authorities Rameau management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r --- Comment #24 from mathieu saby mathieu.s...@univ-rennes2.fr --- I don't know what _process_subfcode_4_merge does, but it is only dealing with some fields (600, 606, 607, 700, 701, 710, 711, 712). Maybe it should deal other subject fields (like 604, 605, 608, 616) ? M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10372] New: SIP2- Ability to use both userid and cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10372 Bug ID: 10372 Summary: SIP2- Ability to use both userid and cardnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: amit.gu...@osslabs.biz CC: colin.campb...@ptfs-europe.com SIP2- Ability to use both userid and cardnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10373] New: Added sort1 and sort2 in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Bug ID: 10373 Summary: Added sort1 and sort2 in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: amit.gu...@osslabs.biz Added sort1 and sort2 in overdue report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10373] Added sort1 and sort2 in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10372] SIP2- Ability to use both userid and cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10372 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Assignee|koha-b...@lists.koha-commun |amit.gu...@osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10373] Added sort1 and sort2 in overdue report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Amit Gupta amit.gu...@osslabs.biz changed: What|Removed |Added Assignee|gmcha...@gmail.com |amit.gu...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16373|0 |1 is obsolete|| Attachment #16374|0 |1 is obsolete|| Attachment #16409|0 |1 is obsolete|| Attachment #16457|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18455 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18455action=edit Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18456 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18456action=edit Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patches (the second one is become useless). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #10 from Gaetan Boisson gaetan.bois...@biblibre.com --- Created attachment 18457 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18457action=edit [SIGNED OFF] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a td isn't getting picked up by the translator unless it's inside a span. This patch adds the span and tidies up the text. To test, apply the patch and translate update a translation. Searching the po file for In transit from should return a result from detail.pl. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Gaetan Boisson gaetan.bois...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||gaetan.bois...@biblibre.com --- Comment #11 from Gaetan Boisson gaetan.bois...@biblibre.com --- On a 3.10 instance, before applying the patch, the string In transit from is found only once in the French po file (for request.pl). After applying the patch and running updating the French po file, the string is found twice, once for request.pl and once for detail.pl. Signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9763] Add callnumber column to print summary for moremember.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #15956|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18458 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18458action=edit Bug 9763 - Add callnumber column to print summary for moremember.pl Test plan: 1) Apply patch 2) Check out some items to a borrower 3) Choose Print summary from the Print pulldown 4) Observe the new callnumber column after Author and before Item type 5) Note that the totals in the footer are still aligned correctly Signed-off-by: Eli Anthony library.ass...@taylorcountygov.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9763] Add callnumber column to print summary for moremember.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: This patch adds a new column to the 'print summary' page. Simple patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: I confirm the proposed patch works for 3.10 branch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18169|0 |1 is obsolete|| Attachment #18457|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18459 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18459action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a td isn't getting picked up by the translator unless it's inside a span. This patch adds the span and tidies up the text. To test, apply the patch and translate update a translation. Searching the po file for In transit from should return a result from detail.pl. Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: # cat /etc/debian_version 7.0 # aptitude search tinymce p python-django-tinymce - replacement text widget for Django web framework p tinymce - platform independent web based Javascript/HTML WYSIWYG editor # aptitude search libfile-slurp-perl i A libfile-slurp-perl - single call read write file routines # aptitude search libtest-www-mechanize-perl i A libtest-www-mechanize-perl # git grep tinymce2 returns no result. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18449|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18460 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18460action=edit Bug 10367 - update the rules and control file for wheezy This updates the control file to use tinymce rather than tinymce2, as tinymce2 is deprecated and no longer in Debian. Also a general dependencies update. Note that this is suitable for master only. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #15 from Kyle M Hall kyle.m.h...@gmail.com --- First we'll have to figure out what we want _GetCircControlBranch to do. However, it might be as simple as passing it an optional issues hash so that it handle the special PickupLibrary case for loans. So, _GetCircControlBranch returns the following: * If CircControl is set to PickupLibrary, it returns the currently logged in library branchcode. * If CircControl is set to 'PatronLibrary', it returns the patron's home library branchcode * If CircControl is set to 'ItemHomeLibrary', it uses the system preference HomeOrHoldingBranch to return either the item's homebranch or its holdingbranch. So _GetCircControlBranch is actually a bit more configurable than the other code ( it behaves exactly the same except it can use either the hold or the holding branch ). In addition, if CircControl is set to ItemHomeLibrary and HomeOrHoldingBranch is set to Holding branch we will get very unexpected behavior for some items, as we will have some code using the item's holding branch, and some of the code using the item's home branch for circulation rule purposes. So, for _GetCircControlBranch, if we add $issue to the parameters list, and returned the branchcode of the issuing library in cases where a) CircControl is set to 'ItemHomeLibrary' and b) $issue is not undefined, I think everything will be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Blocks||10178 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Depends on||6709 --- Comment #13 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Chris, to apply this you need first Bug 6709 (and one more at least, read the final comments). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #18426|0 |1 is obsolete|| --- Comment #11 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 18461 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18461action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Jean-Manuel really sorry, my fault : I squeezed 2 lines of updatedatabase.pl when rebasing Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10262 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10374 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] New: Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Bug ID: 10374 Summary: Clean up and unify CircControl related code Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kyle.m.h...@gmail.com As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18462 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18462action=edit Bug 10374 - Clean up and unify CircControl related code As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. Test Plan: 1) Apply this patch 2) Find some overdue items 2) Test the different settings for CircControl setting the system preference, returning an item, and verifying the correct rule was used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10375] New: add a tool to Koha, to check for zebra problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10375 Bug ID: 10375 Summary: add a tool to Koha, to check for zebra problems Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com this bug will track a tool that checks for zebra problems patch coming... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9991] De-duplicate no cover image available (currently in lieu of prioritizing cover image sources)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9991 Serhij Dubyk du...@library.lviv.ua changed: What|Removed |Added CC||du...@library.lviv.ua -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #12 from jmbroust jean-manuel.bro...@univ-lyon2.fr --- Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/authorised_values.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Bug 9836 - Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] New: Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Bug ID: 10376 Summary: Printing cart does not work under IE9 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl This problem may be older than IE9; I do not know. Cannot check that for now. Since many patrons have IE9, it would be nice if they could print the contents of the cart on opac. Somehow this does not work now. See discussions like http://stackoverflow.com/questions/2555697/window-print-not-working-in-ie?rq=1 The proposed patch adds some code for IE. Works with setting a small timeout, calling window.print instead of print, and changing location on receiving focus back. Note that this last trick is also browser dependent. I do not favor browser dependent code, but at least we reach the goal of enabling the print function again for IE users.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18462|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18463 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18463action=edit Bug 10374 - Clean up and unify CircControl related code As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. Test Plan: 1) Apply this patch 2) Run perl t/db_dependent/Circulation.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18464 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18464action=edit Bug 10376: Printing cart does not work under IE9 Test plan: 1) Test with Firefox (or any other browser except IE): Add biblio to cart Go to Cart and click Print Does the Cart window come back to its original state after confirm/cancel Print? 2) Test with Internet Explorer (I used IE9; testing another version is fine) Do the same as above. Is behavior now more or less the same? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10376] Printing cart does not work under IE9
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: It's a great patch Kyle, well done! I found some problems while testing your patch, I will provide a followup. I tested some use cases but not all. It would be good if this patch is QAed by someone else from the QA team (in order to have another pair of eyes on this patch). Having this patch into master asap would permit to have a lot of testers. I think it is better than blocking this patch any longer. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18318|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18465 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18465action=edit Bug 9394 - Use reserve_id where possible This patch switches from using a combination of biblionumber/borrowernumber to using reserve_id where possible. Test Plan: 1) Apply patch 2) Run t/db_dependent/Holds.t Signed-off-by: Maxime Pelletier maxime.pellet...@libeo.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18466 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18466action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9394] Use reserve_id where possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 5696 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5696] Hold deletion should use reservenumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5696 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED CC||jonathan.dru...@biblibre.co ||m Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- *** This bug has been marked as a duplicate of bug 9394 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18467 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18467action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18467|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18468 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18468action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18468|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18469 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18469action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18469|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18470 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18470action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10374] Clean up and unify CircControl related code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18470|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18471 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18471action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10377] New: fix_unimarc_100 could be improved with 210$d values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 Bug ID: 10377 Summary: fix_unimarc_100 could be improved with 210$d values Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: paul.poul...@biblibre.com The misc/migration_tools/rebuild_zebra.pl script includes a fix_unimarc_100 sub. This sub rewrites 100 field in case it has an invalid length. However, the copyright dates, that are stored in 210$d are also in 100, positions 9-12 Koha could try to retrieve the 210$d values in case the 100 must be rebuilt because it's wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com --- Julian, Could you add a unit test for the new subroutine (C4::Acquisition::TransferOrder) please ? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7498] Cloning a budget, enable change of description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|koha.sek...@gmail.com | --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: All look good. I have just a little remark: after click on 'duplicate', the description field is prefilled with the original description's budget. But if the user does not change it, nothing append (no error and no creation). It would be good if a message appears (JS on submitting or after reloading the page ). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 18472 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18472action=edit Bug 10366: Alert librarian if an invoice number is duplicated Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. To test: 1) Apply patch and run database update. 2) Make sure that you have created at least one invoice on acqui/parcels.pl and take note of the invoice number. 3) Try to create an invoice with the same invoice number. 4) Note that without changing your configuration this works exactly the same as before. 5) Turn on the AcqWarnOnDuplicateInvoice system preference. 6) Try to create a new invoice with the same number as the one you noted earlier. 7) Make sure you get a warning about a duplicate invoice. 8) Choose to receive on the existing invoice. 9) Confirm that you are receiving on said existing invoice. 10) Start the receiving process over, and this time choose Create new invoice anyway. 11) Confirm that you are now receiving on a new invoice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 Janusz Kaczmarek janus...@gmail.com changed: What|Removed |Added CC||janus...@gmail.com --- Comment #1 from Janusz Kaczmarek janus...@gmail.com --- Or I would suggest to consider keeping (transferring to the new 100$a) bytes 100$a/08 and 100$a/09-12, if 100$a/08 contains a meaningful code for the date and 100$a/09-12 looks like a date (i.e. 4 digits, forming a number greater or equal than, say, 1455 and lesser or equal the current year). What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18415|0 |1 is obsolete|| --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18473 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18473action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18473|0 |1 is obsolete|| --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18474 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18474action=edit Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes Renames the pref for install and upgrade. Test plan: See the other patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #5 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18475 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18475action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 --- Comment #2 from Paul Poulain paul.poul...@biblibre.com --- I agree with the idea of keeping the value if it's meaningful. What does meaningful mean though ? I would say keep 9-12 if they contain only 4 numbers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
