[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #23 from Mason James  ---
(In reply to comment #20)
> Created attachment 18584 [details] [review]
> Bug 5858 - Default frameworks missing many MARC21 tags
>
> Signed-off-by: Mason James 

i've taken a look a Bernardo's patch, and tested it

it looks good

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #22 from Mason James  ---
(In reply to comment #9)
> I am not sure deleting them is a good idea - I would have to test it, but is
> there a chance we loose data if someone imports data that uses fields that
> are not defined in the default framework? I think I would prefer to see them
> hidden and marked [OBSOLETE] to be sure no data can be lost.

it looks like the official MARC21 spec does this too
-> http://www.loc.gov/marc/bibliographic/ecbdlist.html

ie: it does not delete old fields/subfields, but just marks them [OBSOLETE]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826

--- Comment #6 from Mason James  ---
> Signed-off-by: Mason James 

i've given this patch a good eyeball, and tested it
it looks good! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826

Mason James  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826

Mason James  changed:

   What|Removed |Added

  Attachment #16174|0   |1
is obsolete||

--- Comment #5 from Mason James  ---
Created attachment 18586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18586&action=edit
Bug 9826 - Missing fields in MARC21 authority framework

This patch updates MARC21 authority framework adding
missing tags/subtags up to Update No. 15 (September 2012)

Missing tags and corresponding subtags only added to
default authority framework.

For present authtypes only missing subtags are added.

Also updates a few legends to match those from LOC.

No deletions except for a few not relevant tags in
present authtypes without subfields.

Only to new installs.

To test:
1) Delete present authority frameworks
2) Load new frameworks. On default there are
many new tags/subtags. On present authtypes
only a few new/renamed subtags.

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
Summary|Default frameworks missing  |Update default MARC21
   |many MARC21 tags|framework to Update No. 16
   ||(April 2013)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #21 from Mason James  ---
Created attachment 18585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18585&action=edit
[FOLLOWUP] Bug 5858 - Default frameworks missing many MARC21 tags

This patch is a *followup* to the previous patch

Update MARC21 fields/subfields to version 16
http://www.loc.gov/marc/bibliographic/bdapndxg.html

Only to new installs.

To test:
1) Delete MARC21 default framework
2) Apply patch
3) Test that new default framework loads without problem

Rebased to master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Mason James  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Mason James  changed:

   What|Removed |Added

  Attachment #17352|0   |1
is obsolete||

--- Comment #20 from Mason James  ---
Created attachment 18584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18584&action=edit
Bug 5858 - Default frameworks missing many MARC21 tags

This patch replaces previous ones.
Only adds missing tags/subtags or update descriptions.

Only to new installs.

To test:
1) Delete MARC21 default framework
2) Apply patch
3) Test that new default framework loads without problem

Rebased to master.

Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Mason James  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

 CC||me...@bywatersolutions.com

--- Comment #53 from Melia Meggs  ---
Helping Paul add his sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18571|0   |1
is obsolete||

--- Comment #48 from Melia Meggs  ---
Created attachment 18579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18579&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 4 - Add saving/editing of published end date for bound volumes

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18575|0   |1
is obsolete||

--- Comment #52 from Melia Meggs  ---
Created attachment 18583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18583&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 8 - Perltidy serials/subscription-add.pl again

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18570|0   |1
is obsolete||

--- Comment #47 from Melia Meggs  ---
Created attachment 18578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18578&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 3 - Add date pickers to serials-edit.pl

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18573|0   |1
is obsolete||

--- Comment #50 from Melia Meggs  ---
Created attachment 18581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18581&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 6 - Perltidy serials/subscription-add.pl

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18574|0   |1
is obsolete||

--- Comment #51 from Melia Meggs  ---
Created attachment 18582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18582&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 7 - Add backend processing of field labels.

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18572|0   |1
is obsolete||

--- Comment #49 from Melia Meggs  ---
Created attachment 18580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18580&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 5 - Add label fields to subscription editor.

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18569|0   |1
is obsolete||

--- Comment #46 from Melia Meggs  ---
Created attachment 18577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18577&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 2 - Store x, y and z in DB when generating new serials

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18568|0   |1
is obsolete||

--- Comment #45 from Melia Meggs  ---
Created attachment 18576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18576&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 1 - Add fields to DB

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18561|0   |1
is obsolete||

--- Comment #44 from Melia Meggs  ---
Created attachment 18575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18575&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 8 - Perltidy serials/subscription-add.pl again

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18558|0   |1
is obsolete||

--- Comment #41 from Melia Meggs  ---
Created attachment 18572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18572&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 5 - Add label fields to subscription editor.

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18560|0   |1
is obsolete||

--- Comment #43 from Melia Meggs  ---
Created attachment 18574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18574&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 7 - Add backend processing of field labels.

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18559|0   |1
is obsolete||

--- Comment #42 from Melia Meggs  ---
Created attachment 18573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18573&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 6 - Perltidy serials/subscription-add.pl

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18556|0   |1
is obsolete||

--- Comment #39 from Melia Meggs  ---
Created attachment 18570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18570&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 3 - Add date pickers to serials-edit.pl

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18557|0   |1
is obsolete||

--- Comment #40 from Melia Meggs  ---
Created attachment 18571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18571&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 4 - Add saving/editing of published end date for bound volumes

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18555|0   |1
is obsolete||

--- Comment #38 from Melia Meggs  ---
Created attachment 18569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18569&action=edit
[Signed off] Bug 8956 - Split serials enumeration data into separate fields -
Part 2 - Store x, y and z in DB when generating new serials

Signed-off-by: Paul Landers 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Melia Meggs  changed:

   What|Removed |Added

  Attachment #18554|0   |1
is obsolete||

--- Comment #37 from Melia Meggs  ---
Created attachment 18568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18568&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add
fields to DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10388] New: acq edited items showing 'null's

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388

Bug ID: 10388
   Summary: acq edited items showing 'null's
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com

Created attachment 18567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18567&action=edit
edited item says null

When editing items on the receipt page in acquisitions you see 'null' in all
fields that have no value. This used to be a blank - or clear column, but now
in 3.10.x and 3.12 and master it's showing null. It should be blank instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854

--- Comment #1 from Galen Charlton  ---
Created attachment 18566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18566&action=edit
bug 9854: add ttf-dejavu as dependency for Debian packages

ttf-dejavu (i.e., the core and extra DejaVu TrueType) fonts
are used by the proposed fix for bug 8375.

To test, build and install the Koha packages for Debian
and verify that the ttf-dejavu package is installed.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma'

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
Pushed to 3.10.x, will be on 3.10.7

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #32 from Galen Charlton  ---
I've switched the dependencies around since folks are requesting patches for
9854 and 9856 before signing off on this one, although I wonder if all three
bugs should just be merged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com
 Blocks|9854, 9856  |
 Depends on||9854, 9856

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854

Galen Charlton  changed:

   What|Removed |Added

 Blocks||8375
 Depends on|8375|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9856] Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375)

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856

Galen Charlton  changed:

   What|Removed |Added

 Blocks||8375
 Depends on|8375|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378

--- Comment #4 from Galen Charlton  ---
Exploring the consequences a bit ... the libraries in question are OK with the
possibility that the loan might incur overdue fines while in transit back to
the owning library?  And they *always* want manual transits to not check the
item in?

If the answer to the second question is along the lines of "on a case-by-case
basis", I wonder if the syspref should simply enable the _option_ of transiting
without returning, in conjunction with a checkbox (and possibly a user
permission) for a circ staffer to indicate that a particular loan should not be
checked in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Galen Charlton  changed:

   What|Removed |Added

  Attachment #18337|0   |1
is obsolete||

--- Comment #93 from Galen Charlton  ---
Created attachment 18565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18565&action=edit
Bug 7143: Release team 3.14 on about page

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10384] Software error when LDAP connexion fails

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384

--- Comment #2 from Galen Charlton  ---
Comment on attachment 18540
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18540
Proposed patch

Review of attachment 18540:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10384&attachment=18540)
-

::: C4/Auth_with_ldap.pm
@@ +103,5 @@
>  my ($dbh, $userid, $password) = @_;
>  my @hosts = split(',', $prefhost);
>  my $db = Net::LDAP->new(\@hosts);
> +unless ( $db ) {
> +$debug and warn "LDAP connexion failed";

I think this might be better as a plain warn -- being unable to connect to the
LDAP server is an operational problem that should be logged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #3 from Galen Charlton  ---
(In reply to comment #0)
> This bug needs reverted, this explanation was given to me by a librarian:

I don't think a revert is the way to do it, particularly since we're talking
about a patch that's been pushed to several stable branches.  Simply reverting
would create a regression for the folks who filed bug 8781 in the first place.

I think the key words in your customer's statement is "for our group".  I
suspect it is not every user of IndependentBranches who needs to "fix" items on
a regular basis, but I certainly understand and appreciate that some do.  To
me, this situation calls for either a new user permission or YASP.

Setting to "in discussion".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

paul.land...@ttuhsc.edu changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paul.land...@ttuhsc.edu

--- Comment #36 from paul.land...@ttuhsc.edu ---
Kyle, after review by our serials staff I now sign off on this dev.

Paul Landers
Texas Tech University Health Sciences Center
Library I.T.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9890] Fix the new plugin system for package installs

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #18417|0   |1
is obsolete||

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 18564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18564&action=edit
Bug 9890 - Fix koha-create and koha-create-dirs

As noted in the bug, there were three things to do:

1) koha-create: fill in __PLUGINS_DIR__
2) leave the enable_plugins as off (at least for now)
3) koha-create-dirs: create the directory, set permissions (writeable by the
koha user)

- Fixed generate_config_file from koha-create so it correctly fills
__PLUGINS_DIR__ in every installed file.
- koha-create-dirs now creates the relevant dir.
- enable_plugins is set to 0 currently, no action required here.

Regarding the apache configurations, I'm not sure what you mean.

Regards
To+

Edit: got some minutes to test and re-check and found that the substitution
didn't put the right data. Fixed

Sponsored-by: Universidad Nacional de Córdoba

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541

Galen Charlton  changed:

   What|Removed |Added

  Attachment #18038|0   |1
is obsolete||

--- Comment #5 from Galen Charlton  ---
Created attachment 18563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18563&action=edit
Bug 9541 - Opac-user doesn't load correct CSS for multiple branches

When clicking the login link for opac-user.pl in a multiple branch
scenario the environment variable for OPAC_CSS_OVERRIDE is ignored from
the koha-conf.xml file.  It seems like is is working on every page in
the opac except for the login page.

Test Plan:
1) Set up a Koha server with 2 separate catalog configurations
   ( e.g. opac1.kohatest, opac2.kohatest )
2) Set the OPAC_CSS_OVERRIDE directive for separate css files
   in each opac
3) Browse to the opac login page, note the css is not applied
4) Apply this patch
5) Reload the page, note the css is now applied

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10387] New: checkauth and get_template_and_user have copy-pasta for setting template variables

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10387

Bug ID: 10387
   Summary: checkauth and get_template_and_user have copy-pasta
for setting template variables
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com

Both checkauth and get_template_and_user set a bunch of template variables
based on system preferences.  For the vast majority of cases, creating a new
default template variable means updating both routines; failing to do this
results in bugs like bug 9541.

Setting default template variables should be refactored into a common routine
in order to avoid repetition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541

Galen Charlton  changed:

   What|Removed |Added

 Blocks||10387

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10387] checkauth and get_template_and_user have copy-pasta for setting template variables

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10387

Galen Charlton  changed:

   What|Removed |Added

 Depends on||9541

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #3 from Galen Charlton  ---
Another thing that occurred to me -- some system preference names contain
hyphens and colons, neither of which can be used as part of environment
variable names.  Not a huge deal, but perhaps the override mechanism should do
some normalization of the syspref name before checking the environment.  

For example, it could normalize hyphens and colons to underscores, so that
$context->preference('ILS-DI:AuthorisedIPs') would check for an environment
variable named OVERRIDE_SYSPREF_ILS_DI_AuthorisedIPs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

--- Comment #2 from Galen Charlton  ---
Comment on attachment 18374
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18374
Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf

Review of attachment 18374:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10325&attachment=18374)
-

I can see the utility of this, and it would have applications for the command
line, too.

I can imagine an edge case, though -- there's nothing stopping one from using
this in the *intranet* virtual host definitions (and I could imagine a Koha
administrator wanting to do this to allow local admins access to system
preferences while locking down ones such as 'marcflavour' that should never be
changed).  But that could really confuse somebody who is wondering why their
system preference change isn't having the desired effect.

Perhaps the system preference editor should be taught how to recognize
overriden sysprefs?

::: C4/Context.pm
@@ +548,5 @@
>  
>  my $dbh  = C4::Context->dbh or return 0;
>  
> +my $value;
> +if ( defined $ENV{"OVERRIDE_SYSPREF_$var"} ) {

The test should be 'exists', no?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779

--- Comment #1 from Owen Leonard  ---
Created attachment 18562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18562&action=edit
Bug 9779 - Remove global include of YUI assets from the staff client

There are no pages in the staff client which use YUI JS assets other
than basketgroups.tt. The links to YUI assets can therefore be removed
from the global include and put directly into the basket groups
template.

To test, view the basketgroups page and confirm using a JS
debugger that no JS errors are triggered. Perform various basket
group options: Open, close, modify, drag-and-drop. Operations
should complete successfully and without JS errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton  ---
Alas, it can't be quite that simple -- MySQL doesn't allow default values for
text and blob columns:

mysql> ALTER TABLE subscriptionhistory CHANGE librariannote librariannote TEXT
NOT NULL DEFAULT '';
Query OK, 1 row affected, 1 warning (0.15 sec)
Records: 1  Duplicates: 0  Warnings: 0

mysql> show warnings;
+-+--+-+
| Level   | Code | Message
|
+-+--+-+
| Warning | 1101 | BLOB/TEXT column 'librariannote' can't have a default value
|
+-+--+-+
1 row in set (0.00 sec)

Admittedly, by default this is just a warning; MySQL will blithely supply a
default value (of '') for text columns.  However, if we ever feel inspired to
turn on stricter modes like STRICT_TRANS_TABLES (which I believe MariaDB does
by default), problems will occur.

I think making those two columns TEXT (and nullable) is the way to go.  There
might be a bit of additional code warranted to make sure that the Apache error
log doesn't display spurious warnings about undef opacnote and librariannote.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952

--- Comment #28 from M. de Rooy  ---
(In reply to comment #27)
> (In reply to comment #25)
> > Jonathan:
> > With another patch, I face the same problem as we do here. Should we add
> > http or https to OPACBaseURL?
> 
> It's a valid configuration to make the OPAC available via both HTTP and
> HTTPS, so using OPACBaseURL to define the protocol gives me a bit of a
> twitch.

Well, probably this is a misunderstanding.
Currently, http or https should not be inserted into the pref.
But Koha does add at some places http by default (which is wrong indeed) and at
other places tries to know what to prefix (see using_https in Auth.pm). But the
last test does not work correctly under Plack.

What I did mean, was: If we let the user just once insert http or https for his
server, and we do not prefix it anymore, we have a solution..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386

M. de Rooy  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||10290

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386

M. de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10290

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386

M. de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290

M. de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10386

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290

M. de Rooy  changed:

   What|Removed |Added

 Blocks||10386

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10386] New: UT: VirtualShelves.t needs some more adjustments

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386

Bug ID: 10386
   Summary: UT: VirtualShelves.t needs some more adjustments
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: gmcha...@gmail.com
  Reporter: m.de.r...@rijksmuseum.nl

Will build upon the changes proposed in bug 10290.
IMO this unit test should not just delete all records at the start. (Why ruin
my test database for lazy programming :) ?
Furthermore, the unique name test for lists is not completely correct.
Will also add two small new tests for AddShare from bug 9032.
Note also that a test db may not even contain 10 borrowers..
And some room for more refinements, when working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10385] New: item-level_itype checks need to be refactored

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385

Bug ID: 10385
   Summary: item-level_itype checks need to be refactored
Classification: Unclassified
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com

Checks on the item-level_itypes system preference are scattered throughout the
code, and there have been a large number of bugs concerning cases where such a
check is missing.

I propose checks of this system preference be moved as far down the stack as
possible.  Specifically, all routines that fetch items from the database should
check the syspref to determine the correct item type column and return it via
(say) an "item_type" key in the response, to distinguish it from 'itemtype' and
'itype'.  The only code that would see 'itype' or 'itemtype' would be code
directly related to modifying items.  Further, the syspref would be checked in
as few places as possible.

I further propose pinning down the semantics of the item-level_itypes as
follows:

- when ON, the item type is *always* taken from items.itype for all display and
circulation purposes
- when OFF, the item type is *always* taken from biblioitems.itemtype

In particular, the current behavior of GetItem (fetch the itype from the item
if it's not blank, otherwise fall back to the biblioitem itemtype), would be
modified.

Related bugs include:

- Bug 7491
- Bug 7492

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #6 from Galen Charlton  ---
(In reply to comment #5)
> Indeed, but it works for both item and biblio level : 
> In C4::Circualtion::AddIssue : 
>   my $item = GetItem('', $barcode)
> and C4::Items::GetItem sets itype with itemtype from items or biblioitems if
> needed.

Please take a look at CanBookBeIssued -- it fetches the item via GetItem, but
also fetches the biblioitem and explicitly checks item-level_itypes.  

What GetItem does when fetchingitype isn't quite the same: it doesn't check the
syspref, but it also assumes that one should fall back to the biblio item type
if the item-level item type is blank.  I'm not quite sure that's the correct
behavior, but that discussion certainly belongs on a separate bug.

> So $items->{'itype'} is used for both item and biblio level, like in many
> other places in C4::Circualtion.

But many other places in C4::Circulation explicitly check item-level_type, and
I think the fix for this should be doing that explicit check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Fridolyn SOMERS  ---
Indeed, but it works for both item and biblio level : 
In C4::Circualtion::AddIssue : 
  my $item = GetItem('', $barcode)
and C4::Items::GetItem sets itype with itemtype from items or biblioitems if
needed.
So $items->{'itype'} is used for both item and biblio level, like in many other
places in C4::Circualtion.

Maybe C4::Items::GetItem should use item-level_itypes system preference, but
this would be a very sensitive modification with a huge test plan, it shall be
for another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10348] When using SeparateHoldings OPAC shows number of items, but staff doesn't

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348

Owen Leonard  changed:

   What|Removed |Added

  Component|OPAC|Templates
   Severity|trivial |enhancement

--- Comment #2 from Owen Leonard  ---
This isn't related to the SeparateHoldings preference. The staff client never
shows a count of items in the holdings tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16351|0   |1
is obsolete||

--- Comment #33 from Kyle M Hall  ---
Created attachment 18559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18559&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 6 -
Perltidy serials/subscription-add.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16353|0   |1
is obsolete||

--- Comment #35 from Kyle M Hall  ---
Created attachment 18561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18561&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 8 -
Perltidy serials/subscription-add.pl again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16348|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 18556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18556&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add
date pickers to serials-edit.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16349|0   |1
is obsolete||

--- Comment #31 from Kyle M Hall  ---
Created attachment 18557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18557&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add
saving/editing of published end date for bound volumes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16350|0   |1
is obsolete||

--- Comment #32 from Kyle M Hall  ---
Created attachment 18558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18558&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add
label fields to subscription editor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16352|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall  ---
Created attachment 18560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18560&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add
backend processing of field labels.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16347|0   |1
is obsolete||

--- Comment #29 from Kyle M Hall  ---
Created attachment 18555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18555&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store
x, y and z in DB when generating new serials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #16346|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 18554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18554&action=edit
Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add
fields to DB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #27 from Galen Charlton  ---
(In reply to comment #25)
> Jonathan:
> With another patch, I face the same problem as we do here. Should we add
> http or https to OPACBaseURL?

It's a valid configuration to make the OPAC available via both HTTP and HTTPS,
so using OPACBaseURL to define the protocol gives me a bit of a twitch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350

Galen Charlton  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349

--- Comment #1 from Owen Leonard  ---
Created attachment 18553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18553&action=edit
Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff

The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC reocrd or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Galen Charlton  ---
Trivial typo fix, easily verified; pushing directly to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350

--- Comment #1 from Owen Leonard  ---
Created attachment 18552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18552&action=edit
Bug 10350 - Capitalization: Home Library column in staff detail items table

"Home library" is incorrectly capitalized on the catalog detail page.
This patch corrects it.

To test, view the normal view of record in the staff client catalog.
The "Home library" table header in the holdings table should be
correctly capitalized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10351] Typo: Missing parenthesis in download options in staff detail pages

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10351

Owen Leonard  changed:

   What|Removed |Added

 Depends on||9665

--- Comment #1 from Owen Leonard  ---
A fix for this is in the patch for Bug 9665.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

 Blocks||10351

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

--- Comment #6 from Owen Leonard  ---
Created attachment 18551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18551&action=edit
Bug 9665 [Revised] Staff client bibliographic record export missing some
options available in the OPAC

The OPAC offers RIS and BIBTEX as choices for bibliographic downloads,
but the staff client is missing these options. This patch adds them.

To test, view a record in the staff client (detail.pl, MARCdetail.pl,
etc.) and click the "Save..." toolbar button. BIBTEX and RIS should be
available and functional.

Revision reimplements the changes on the new Bootstrap version of the
menu and corrects a couple of typos.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

  Attachment #18549|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Owen Leonard  changed:

   What|Removed |Added

   Priority|P2  |P5 - low
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766

Owen Leonard  changed:

   What|Removed |Added

  Attachment #18538|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 18550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18550&action=edit
[SIGNED-OFF] Bug 766 Remove CGI::scrolling_list from request.pl

Let the template take care of generating the display.
Lets at least part of request.pl be more succinct.

To test, place a hold and search for the patron using a partial name.
You should get a dropdown select list of patrons and be able to select
the patron to hold for from there.

The functionality should remain unimpaired after this patch is applied.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

  Attachment #15651|0   |1
is obsolete||

--- Comment #5 from Owen Leonard  ---
Created attachment 18549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18549&action=edit
Bug 9665 [Revised] Staff client bibliographic record export missing some
options available in the OPAC

The OPAC offers RIS and BIBTEX as choices for bibliographic downloads,
but the staff client is missing these options. This patch adds them.

To test, view a record in the staff client (detail.pl, MARCdetail.pl,
etc.) and click the "Save..." toolbar button. BIBTEX and RIS should be
available and functional.

Revision reimplements the changes on the new Bootstrap version of the
menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712

--- Comment #7 from Galen Charlton  ---
(In reply to comment #6)
> I agree, it is a drastic measure. This action has become necessary where 
> bugs in Koha have caused loans to have an incorrect due date. Another good
> case is where a library has incorrectly set up circulation rules and needs
> to fix their due dates. Often in these cases, the correct due date has been
> stamped in the book, but the incorrect due date is set in Koha.

OK, that makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

--- Comment #23 from David Burke  ---
I did mean 3.12. 

I know from experience that Zentyal changed this from version 2.2 > 3.0. They
used to allow anon searching. It broke quite a few things for me. In any case
it seems reasonable not to allow anon users to see what users exist in LDAP.

I'd be happy to test anything with my AD server. Thanks for being so responsive
to the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712

--- Comment #6 from Kyle M Hall  ---
I agree, it is a drastic measure. This action has become necessary where  bugs
in Koha have caused loans to have an incorrect due date. Another good case is
where a library has incorrectly set up circulation rules and needs to fix their
due dates. Often in these cases, the correct due date has been stamped in the
book, but the incorrect due date is set in Koha.

(In reply to comment #5)
> What is the use case you see for this?  Particularly in a production
> situation, retroactively changing due dates on patrons seems a bit drastic
> (particularly if the loan period gets shortened).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

--- Comment #4 from Galen Charlton  ---
(In reply to comment #2)
> Created attachment 18545 [details] [review]
> Proposed patch
> 
> See commit message

Upon reading the patch, I think there's a problem -- it doesn't take the
item-level_itypes system preference into account.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973

--- Comment #22 from Rolando Isidoro  ---
Dobrica, it's been sometime since I wrote the patch, but if I recall it
correctly I didn't overwrite the old method for LDAP auth that worked for you.

Have you tried setting ´auth_by_bind´ to 0 in your koha-conf.xml? Let me know
if it works for your that way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton  ---
Pushed to master.  Thanks, Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8662] Remove unused famfamfam icons

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662

Owen Leonard  changed:

   What|Removed |Added

  Attachment #18530|0   |1
is obsolete||

--- Comment #13 from Owen Leonard  ---
Created attachment 18548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18548&action=edit
[SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons

This patch removes images in the famfamfam directory
which are unused by Koha. Files to delete were chosen
based on a search of the Koha source.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8662] Remove unused famfamfam icons

2013-05-31 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662

--- Comment #12 from Jonathan Druart  ---
I got another error using --ignore-whitespace:

# git am -3 --ignore-whitespace /tmp/BZ8662.patch
Applying: Bug 8662 - Remove unused famfamfam icons
error: corrupt binary patch at line 7593:
z^9Bhttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >