[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #17979|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18861 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18861action=edit Bug 10212: Columns configuration for tables commit a5942aa75818830145886b9d4cc4af5521867d7f Author: Jonathan Druart jonathan.dru...@biblibre.com AuthorDate: Tue May 7 14:09:59 2013 +0200 Commit: Jonathan Druart jonathan.dru...@biblibre.com CommitDate: Wed Jun 12 09:15:06 2013 +0200 Bug 10212: Columns configuration for tables Erk, I forgot to add the .tt file to the patch :-/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Depends on||9755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Blocks||8064 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #19 from Chris Hall chr...@catalyst.net.nz --- (In reply to comment #18) Thank you very much for that Jonathan :) Followed the test plan and it worked perfectly, you just have to make sure to select the form before hitting enter as the search box has focus (this is not a critique of your patch but a note to others testing it). Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #20 from Chris Hall chr...@catalyst.net.nz --- Apply perfectly since the 9507 fixup. Pushed both patches to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #16 from Chris Hall chr...@catalyst.net.nz --- Cherry picking this patch from 3.10.x didn't apply cleanly, had some issues around debian/control and debian/control.in Is it possible for you to submit a version for 3.8.x? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #10 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7368] General staff client typo omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #88 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 Nuño López Ansótegui nu...@masmedios.com changed: What|Removed |Added Attachment #18707|0 |1 is obsolete|| --- Comment #12 from Nuño López Ansótegui nu...@masmedios.com --- Created attachment 18862 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18862action=edit Bug 9921 - Make it possible to force 001 = biblionumber The previous patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to comment #9) (In reply to comment #8) Just noting that as of today, the patch series still applies cleanly. Galen, yes but they depend on bug 6281 which fails qa. Its now in master, so QAing this now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #13 from Nuño López Ansótegui nu...@masmedios.com --- Created attachment 18863 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18863action=edit autoControNumber preview Field 001 is controlled by a system preference, which will have three options: If it to be generated as biblionumber will generate the 001 as the biblionumber of the bibliographic record (if you don´t manually enter a value in the 001). If you select the option generated in the form 1, 2, 3, 001 is generated from a number specified in the system preference 'incrementalControlNumber', which will automatically increase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15778|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18864 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18864action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15355|0 |1 is obsolete|| --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18865 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18865action=edit bug 9370: test case for splitting LC call number QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz http://bugs.koha-community.org/show_bug.cgi?id=9730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15356|0 |1 is obsolete|| --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18866action=edit bug 9370: add invalid call number to LC splitting test cases '123 ABC FOO BAR' is intentionally *not* a valid LC call number, but in order to preserve legacy behavior, it should be split on whitespace. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz http://bugs.koha-community.org/show_bug.cgi?id=9730 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15357|0 |1 is obsolete|| --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 18867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18867action=edit bug 9370: improve splitting of LC call numbers for labels Use the Perl module Library::CallNumber::LC to parse and split LC call numbers when generating spine labels. For example, QH541.15.C6 C25 2012 should be split as follows: QH 541.15 .C6 C25 2012 To test, create an item with call number QH541.15.C6 C25 2012 and classification source LC, then create a spine label for that item using a layout of type 'biblio' that has the split call numbers option enabled. The call number should be split as indicated above. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15778|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9730] The sub 'AnonymiseIssueHistory' fails quietly if 'AnonymousPatron' is not a valid entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9730 --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz --- The content of attachment 18864 has been deleted by Chris Cormack ch...@bigballofwax.co.nz without providing any reason. The token used to delete this attachment was generated at 2013-06-12 21:47:50 NZST. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #56 from Chris Cormack ch...@bigballofwax.co.nz --- I can't QA this as its a Catalyst patch, can someone else please look at it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||ch...@bigballofwax.co.nz --- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz --- Lots of conflicts in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #57 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #56) I can't QA this as its a Catalyst patch, can someone else please look at it And I proposed a patch + SO from BibLibre, I cannot either. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16978|0 |1 is obsolete|| Attachment #16979|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18868 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18868action=edit Bug 9366: On cataloguing each user can easily display tags or not If the syspref hide_marc is set to don't display, tags are not shown by default. This patch adds a checkbox to hide/show tags directly on the cataloguing page. Test plan: Enable/disable the sysprefs hide_marc and advancedMARCeditor in order to check if the display is according with what the user want. Bonus: This patch removes the link Show MARCtag documentation links if the syspref advancedMARCeditor is enabled. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass. http://bugs.koha-community.org/show_bug.cgi?id=9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18869 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18869action=edit Bug 9366: FIX typo s/class/style It replaces the vertical-align with a margin-left Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com http://bugs.koha-community.org/show_bug.cgi?id=9803 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #58 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #57) (In reply to comment #56) I can't QA this as its a Catalyst patch, can someone else please look at it And I proposed a patch + SO from BibLibre, I cannot either. Luckily, we have more people on the QA team :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #85 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #84) Did you add any logging code to an opac script to test it? I just added this to my opac-main.pl to test: C4::Context-logger-debug(This is a debug message); C4::Context-logger-error(This is an error !); Found what happened: In opac-search Jonathan creates a logger object in opac-search (that's the one I was looking for). But C4/Auth also initialized a logger ALREADY. So the second logger got my message, but the template asked it to the first logger and got nothing. Still following? Will send a small followup for this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18799|0 |1 is obsolete|| Attachment #18800|0 |1 is obsolete|| Attachment #18801|0 |1 is obsolete|| Attachment #18802|0 |1 is obsolete|| Attachment #18803|0 |1 is obsolete|| Attachment #18819|0 |1 is obsolete|| Attachment #18820|0 |1 is obsolete|| --- Comment #86 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18870 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18870action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger-new; $log-debug(This is a debug message); $log-info(This is an information); $log-error(This is an error !); The Logger constructor can take an hash reference with file and level to define a filepath or a log level. For a log level = warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context-logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain paul.poul...@biblibre.com Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #87 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18871 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18871action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #88 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18872 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18872action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #90 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18874 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18874action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Add a logging module to |Add a logging module to |Koha, that can report log |Koha |message to staff interface | |(for developer use) | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|Small patch |Medium patch QA Contact|katrin.fisc...@bsz-bw.de|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #91 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18875action=edit Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #89 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18873 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18873action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #93 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18877action=edit Bug 8190: Followup for opac-search Script should not create a second logger object, but use the one that the Auth module already made. Works fine now. Only question is: Should we leave it here. This is somewhat of a debug statement. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha, that can report log message to staff interface (for developer use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #92 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18876 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18876action=edit Bug 8190: Add the 'alert' level. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #59 from Kyle M Hall k...@bywatersolutions.com --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18435|0 |1 is obsolete|| Attachment #18436|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18878action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane stephane.del...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18879action=edit Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane stephane.del...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #62 from Kyle M Hall k...@bywatersolutions.com --- It looks like there is a value conflict here. The database update is assuming the syspref value of '1' should be converted to 'yes', but the code is still assuming it that it is '1'. I think leaving 'no' as an empty value makes the template code cleaner, but I think it would be better to keep the alteration of '1' to 'yes'. However, it's probably much easier to alter the database update, so I wouldn't fail qa just for keeping '1' instead of 'yes'. I hope this makes sense! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #94 from M. de Rooy m.de.r...@rijksmuseum.nl --- Some QA observations: The first patch commit message should preferably be edited. Since we initialize the logger in Auth.pm, you do not need: use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger-new; Just say: $log= C4::Context-logger; (This was actually the reason for the last followup.) Will take the liberty now to edit these comments. Forgive me for that.. The first patch seems to delete a SetVersion line in updatedatabase for an older dbrev (3.9.0.45?). This is a blocker. Will amend this one if nothing more follows. The hardcoded 5 in Koha::Utils::Logger in new routine is not very nice :) Strange, because it was a constant in earlier patch than patch 5. Thanks for adding the alert level. When looking trough the code I still noticed a mention of 7 levels instead of 8 now. Another set of patches coming.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18870|0 |1 is obsolete|| --- Comment #95 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18880 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18880action=edit Bug 8190: Koha::Utils::Logger, Logging module Use the logger like: $logger= C4::Context-logger; $logger-debug(This is a debug message); $logger-info(This is an information); $logger-error(This is an error !); The Logger constructor can take an hash reference with file and level to define a filepath or a log level. For a log level = warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Includes (apparently from squashed patches): Bug 8190: Followup Logger: FIX perlcritic Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context-logger * Embed logged messages to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Mason James m...@kohaaloha.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Paul Poulain paul.poul...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Amended the patch for a updatedatabase problem. Edited the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #98 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18883 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18883action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18871|0 |1 is obsolete|| Attachment #18872|0 |1 is obsolete|| Attachment #18873|0 |1 is obsolete|| Attachment #18874|0 |1 is obsolete|| --- Comment #96 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18881 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18881action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #97 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18882 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18882action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #99 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18884 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18884action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18885 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18885action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18875|0 |1 is obsolete|| --- Comment #100 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18886 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18886action=edit Bug 8190: Followup - Add html embedded logs to OPAC Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #18876|0 |1 is obsolete|| Attachment #18877|0 |1 is obsolete|| --- Comment #101 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 18887 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18887action=edit Bug 8190: Add the 'alert' level. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #102 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 1 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1action=edit Bug 8190: Followup for opac-search Script should not create a second logger object, but use the one that the Auth module already made. Works fine now. Only question is: Should we leave it here. This is somewhat of a debug statement. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #103 from M. de Rooy m.de.r...@rijksmuseum.nl --- 'final' comment for RM: Code looks good to me now. (See QA comments before.) I am wondering if we should by default put the level to 5 (normal) at install or upgrade. When someone does not want to use it, we could set it to zero (emerge or unusable level) and have around zero messages. Robin should still have a look for the packaging stuff. Jonathan will probably send a few trivial followups for housekeeping (e.g. correcting 7-8 levels; also in pref desc in db). Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #18739|0 |1 is obsolete|| --- Comment #4 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18889 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18889action=edit Proposed patch (new help page) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10425] Help page missing for Local Use preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10425 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to comment #3) For simplification, I would suggest not to copy information and create redundancy ;) but just explain what is a local use preference. Your right, I've rewritten the patch to provide in help page some explanations on local use system preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10450] New: Editing serials predicts wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10450 Bug ID: 10450 Summary: Editing serials predicts wrong Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: colin.campb...@ptfs-europe.com I have seen this happen since Koha 3.8 but thought it was just me - now I'm going to report a bug in case someone can track down the problem. Here's an example: I have the July issue of Food Wine in hand. I am in the Food Wine serials record and filling in the date of next publication and the '# starts with' for predictions. I put 07/01/2013 for next publication and I put a 7 in the predictions chart (since I am starting these records off now) But when I go to check in the July issue, it gives 2013:8 for the issue and publication date as 08/01/2013. This always happens when you edit an existing serial record's prediction pattern. No matter what you put in it always generates the next one - not the one you entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #104 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18890 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18890action=edit Bug 8190: FIX description and values for the LogLevel pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #105 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #95) Amended the patch for a updatedatabase problem. Edited the commit message. Thanks for that Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18767|0 |1 is obsolete|| Attachment #18768|0 |1 is obsolete|| Attachment #18769|0 |1 is obsolete|| Attachment #18770|0 |1 is obsolete|| --- Comment #98 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18891 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18891action=edit [SIGNED-OFF] Bug 6874: File upload in MARC Rebased on master Squash of 4 signed-off patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18771|0 |1 is obsolete|| Attachment #18772|0 |1 is obsolete|| Attachment #18773|0 |1 is obsolete|| Attachment #18774|0 |1 is obsolete|| --- Comment #99 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18892 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18892action=edit [SIGNED-OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain paul.poul...@biblibre.com Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Attachment #18775|0 |1 is obsolete|| Attachment #18777|0 |1 is obsolete|| --- Comment #100 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18893 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18893action=edit [SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #101 from Julian Maurice julian.maur...@biblibre.com --- Created attachment 18894 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18894action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #102 from Julian Maurice julian.maur...@biblibre.com --- The last patch introduces a subroutine in t/lib/Mocks/Context.pm that is also introduced by Bug 10298. But there are quite similar and resolving the conflicts will be very easy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #63 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #62) It looks like there is a value conflict here. The database update is assuming the syspref value of '1' should be converted to 'yes', but the code is still assuming it that it is '1'. I think leaving 'no' as an empty value makes the template code cleaner, but I think it would be better to keep the alteration of '1' to 'yes'. However, it's probably much easier to alter the database update, so I wouldn't fail qa just for keeping '1' instead of 'yes'. I hope this makes sense! Hum... whaou, not easy to understand :) In fact yes and no are transformed to 1 and (see comment 15 and bug 7854). So if we want to have 1 and 0 in DB, we will got 1, 0 and force which is not really cleaner I think. We cannot set yes, no and force in the DB and to test strings (yes, no, force) in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #14624|0 |1 is obsolete|| --- Comment #15 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18895 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18895action=edit Bug 9312: strict perl for picture-upload.pl Patch rebased master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #14625|0 |1 is obsolete|| --- Comment #16 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18896 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18896action=edit Bug 9312: whitespace cleanup for picture-upload.pl Patch rewritten. No need to rebase, it is a code formatting using perltidy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #14626|0 |1 is obsolete|| --- Comment #17 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 18897 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18897action=edit Bug 9312: fix a couple more uninitialized variable warnings Patch rebased master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- All patches rebased master. There are a lot of changes so I set to needs signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10451] New: Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Bug ID: 10451 Summary: Firefox prints only first page of table with shrink to fit option Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleon...@myacpl.org Reporter: dpav...@rot13.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10064] add category filter to Top Most-circulated items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10064 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org --- Easier solution (since we need custom columns anyway) was to create SQL report like this: SELECT count(s.datetime) AS circs, b.title, b.author, i.ccode FROM statistics s JOIN items i USING (itemnumber) LEFT JOIN biblio b USING (biblionumber) WHERE i.itype=Item type|itemtypes AND i.homebranch=Home branch|branches AND i.ccode=Collection|CCODE GROUP BY b.biblionumber ORDER BY circs DESC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18856|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18898 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18898action=edit Bug 10406 - (followup) YUI-ac related code Some other stuff that might be removed. To test: - Apply, the search form doesn't break. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10452] New: AllowHoldsOnDamagedItems should control using damaged items to fulfill holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Bug ID: 10452 Summary: AllowHoldsOnDamagedItems should control using damaged items to fulfill holds Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com CC: gmcha...@gmail.com AllowHoldsOnDamagedItems will stop item-specific holds from being placed on damaged items, but does not stop Koha from using damaged items to fill holds. This seems like incorrect behavior. If we don't want holds placed on damaged items, why would we want damaged items to be used to fill a hold? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18899 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18899action=edit Bug 10452 - AllowHoldsOnDamagedItems should control using damaged items to fulfill holds AllowHoldsOnDamagedItems will stop item-specific holds from being placed on damaged items, but does not stop Koha from using damaged items to fill holds. This seems like incorrect behavior. Test Plan: 1) Set 'AllowHoldsOnDamagedItems' to Don't Allow 2) Pick an item, set it to damaged 3) Place a bib-level hold on this item's record 4) Scan the item though the returns system 5) Koha will ask to use this item to fill the hold, click ignore 6) Apply this patch 7) Repeat step 4 8) Koha will not ask to use this item to fill the hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10452] AllowHoldsOnDamagedItems should control using damaged items to fulfill holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10452 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Patch complexity|--- |Small patch Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18901|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18902 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18902action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18901 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18901action=edit Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #64 from Kyle M Hall k...@bywatersolutions.com --- Thanks for the clarity! I should have remembered that! Kyle (In reply to comment #63) (In reply to comment #62) It looks like there is a value conflict here. The database update is assuming the syspref value of '1' should be converted to 'yes', but the code is still assuming it that it is '1'. I think leaving 'no' as an empty value makes the template code cleaner, but I think it would be better to keep the alteration of '1' to 'yes'. However, it's probably much easier to alter the database update, so I wouldn't fail qa just for keeping '1' instead of 'yes'. I hope this makes sense! Hum... whaou, not easy to understand :) In fact yes and no are transformed to 1 and (see comment 15 and bug 7854). So if we want to have 1 and 0 in DB, we will got 1, 0 and force which is not really cleaner I think. We cannot set yes, no and force in the DB and to test strings (yes, no, force) in the template. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18851|0 |1 is obsolete|| Attachment #18852|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18900 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18900action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href=# to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to Advanced Search and then More options. - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Add the onclick event on the 2 links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton gmcha...@gmail.com --- Pushed the follow-up (with rewording of the commit message) to master. Thanks, Tomás! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Works as expected except for the click reset the scroll at the top. I amended the patch in order to add a onclick and to trigger the event. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8771] Something wrong with databse update 3.09.00.044
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8771 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl --- Funny to stumble across this today. Had a problem with a patch in bug 8190 that unintentionally removed a line at 3.9.0.45 ... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10432] Display of enabled status on course list is not accessible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10432 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m, ||k...@bywatersolutions.com --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Maybe it would be better to add the missing alt attribute. I let Kyle does qa on this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10453] New: updating child to adult loses password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10453 Bug ID: 10453 Summary: updating child to adult loses password Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Tested in 3.10.x and master. When you update a child to an adult it loses the password (or changes it) - the patron can no longer log in to the OPAC after using the 'update child to adult' in the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8190] Add a logging module to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #106 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #6) (In reply to comment #4) Perhaps also take a look at Log4Perl http://search.cpan.org/~mschilli/Log-Log4perl-1.37/lib/Log/Log4perl.pm I had a look at several perl logging modules. My conclusion is LogLite is the easier for what we need into Koha. That begs a question, though -- what do we need in Koha? One part of the answer to that question, for me, and I suspect for most folks who administer more than one Koha database or who administer services in addition to Koha, is syslog support. Log::LogLite doesn't provide such support, whereas Log4Perl does in addition to supporting appending to traditional log files. Also, Chris in comment 58 all but proposed a counter-patch. Would the original patch submitter respond to that comment, please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10297] categorycode and branchcode should be required when adding patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m Patch complexity|--- |Trivial patch QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Logical patch, branchcode and categorycode cannot be null. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #9 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #8) QA comment: Works as expected except for the click reset the scroll at the top. I amended the patch in order to add a onclick and to trigger the event. Marked as Passed QA. I'm not quite sure that your amendment was attached to this bug -- please double-check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18879|0 |1 is obsolete|| --- Comment #66 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18904 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18904action=edit Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18878|0 |1 is obsolete|| --- Comment #65 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 18903 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18903action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane stephane.del...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10451] Firefox prints only first page of table with shrink to fit option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451 --- Comment #1 from Dobrica Pavlinusic dpav...@rot13.org --- Created attachment 18905 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18905action=edit Bug 10451 - Firefox prints only first page of table with shrink to fit option According to Firefox bug tracker, versions up to 21 doesn't print tables correctly when using shrink to fit option. See: https://bugzilla.mozilla.org/show_bug.cgi?id=684622 However, even with v21 or newer, we still need to add css to print media which instruct it not to break table tag to print all pages of table. This has a side-effect that table starts always on next page, wasting some space on first printed page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10444] In advanced search(more), [+] and [-] should behave like links on hover
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10444 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18900|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18906 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18906action=edit Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover This patch add href=# to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to Advanced Search and then More options. - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see the cursor changes - Functionality should remain unchanged Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Amended patch: Add the onclick event on the 2 links -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18879|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
