[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
Frédéric Demians changed:
What|Removed |Added
CC||frede...@tamil.fr
--- Comment #6 from Frédéric Demians ---
Great idea and implementation!
The patch doesn't apply anymore on HEAD. Their is a conflict on
staff-global.css.
Reading the code, I have one question and one remark:
(1) How does IndexedDB scale? Your synchronization stores locally
patrons and issues (if I understand correctly). So is there a limit to
the borrowers and issues Koha tables size?
(2) Few lines in offline.tt won't be translatable:
item.title = item.title || "(Unknown)";
item.author = item.author || "(Unknown)";
$('#alerts').append('Check in
message');
$(".loading-overlay div").text(_("Loading page " + page + ", please wait..."));
$('#alerts').append('Check out
message');
alert("You are offline and therefore cannot sync your database");
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged MARC records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Amit changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10477] New: Increased flexibility for upload of Staged MARC records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477 Bug ID: 10477 Summary: Increased flexibility for upload of Staged MARC records Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng...@gmail.com Increased flexibility for upload of Staged MARC records. When uploading bulk MARC records against existing records - need further option to allow the process to just add/merge extra MARC tags rather than having to completely overwrite an existing record or just leave the existing record unchanged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10476] New: Guarantor Search Not Limiting by Category Type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10476
Bug ID: 10476
Summary: Guarantor Search Not Limiting by Category Type
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: dc...@prosentient.com.au
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Currently, the guarantor search is not being limited by category type.
In guarantor_search.pl, there is code that says the search of the borrowers
table should be limited by the category_type "A" (i.e. Adult) (or "I" (i.e.
Institution) in the event that the patron being guaranteed has a category_type
of "P" (i.e. Professional).
Here is the code:
my $search_category = 'A';
if ($category_type eq 'P'){
$search_category = 'I';
}
$results = Search({''=>$member, category_type=>$search_category},$orderby);
However! If you investigate the "Search" sub and the subsequent "SearchInTable"
sub, there is no reference to the "categories" table where the "category_type"
column is located. Moreover, if you actually do a search for guarantors, you
will always be able to retrieve any patron.
That means that professionals can guarantee professionals, and children and
guarantee children.
It looks like this bug was introduced when Search and SearchMember were unified
into the one Search sub.
--
Now...for our purposes at Prosentient...we actually want professionals to be
able to guarantee professionals, so this bug is actually "beneficial".
However, I imagine lots of people in public libraries might not like having a
guarantor search that doesn't weed out the children.
I probably won't work on this bug (at least not any time soon), but it might an
idea to create a system preference that allows users to decide what type of
guarantor->guarantee relationship they want to set up in terms of category
types.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Tomás! A refactoring to consider in the near future is tweaking the patron search auto-complete JavaScript so that it can be contained in an include template rather than duplicating it among the following templates: koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course.tt p Local template variables can be set via a TT include directive to set the form element IDs to apply the JavaScript to. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Galen Charlton changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #14 from Galen Charlton --- Created attachment 19054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19054&action=edit Bug 10258: offer to create basket group only when staff user has correct permission If the staff user does not have the group_manage acquisition permission, do not offer to create a new basket group when closing an order basket. This avoids a situation where if a staff member without that permission tries to close a basket and chose the option to create a bakset group, they would be redirected to the login page. To test: [1] Log in as a staff user that does not have the acquisition/group_manage permission. [2] Create a new order basket, attach at least one order line to it, then close it. [3] Verify that the confirmation page does not offer to create a basket group with the same name as the order basket. [4] Log in as a staff user that has the acquisition/group_manage permission. [5] Create and close an order basket. [6] Verify that this time, the confirmation page *does* offer to create a basket group. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Galen Charlton changed: What|Removed |Added Attachment #18944|0 |1 is obsolete|| --- Comment #13 from Galen Charlton --- Created attachment 19053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19053&action=edit Bug 10258: fix permissions check for setting basket group for order basket Improve the code that displays and allows staff to set the basket group from the basket details page for a closed basket. Prior to this patch, a staff member who did not have the group_manage acquisition permission would still see a control to change the group that the basket belongs to; attempting to change the group would present with with a login page. This patch also does some tidying of how basket group details are passed to the template. To test: [1] Create an order basket and close it. Do not assign it to a basket group. [2] View the basket details while logged in as a staff user who has the order_manage acquisitions permission but not the group_manage. The displayed basket group should be "No group". [3] Switch to a staff user who also has the group_manage permission, then view the basket details again. The basket group field should now be a select input that allows you to change the basket group. [4] Change the basket group. Verify that the basket group you selected is now displayed as the current group for that order basket. The basket group delivery and billing place fields should also now be displayed. [5] Close the basket group set in the previous step, then view the basket details again. This time, the basket group name should be displayed with a suffix of " (closed)", and no input to change the group should be displayed. [6] Swith to a staff user who does not have the group_manage permission, view the basket details, and verify that the basket name is displayed with a suffix of " (closed)". Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #15 from Galen Charlton --- (In reply to comment #12) > Created attachment 19039 [details] > screenshot of dialog described in comment > > I think we are almost there, but there is one little thing I am still > worried about: When I close the basket with the user that has not > group_manage permission, I still get offered the yellow dialog on closing > the basket that asks me if I want to create a basket group with the same > name as the order and put my order in it. If you check the checkbox and save > you go to an error page: Error: You do not have permission to access this > page. Click to log out... > I think ideally we should not have this happen, but remove that bit from the > dialog. I've added a follow-up patch to do exactly that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--- Comment #2 from Marc Véron ---
I did a search for GetRecordValue and found one place with other values
than 'subtitle'.
(BTW: I did not find any calls to GetRecordValue where the first parameter
was a variable.)
C4\HoldsQueue.pm
sub GetHoldsQueueItems
Line 141: $row->{parts} =
GetRecordValue('parts',$record,'')->[0]->{subfield};
Line 142: $row->{numbers} =
GetRecordValue('numbers',$record,'')->[0]->{subfield};
GetHoldQueItems then is used in circ\view_holdsqueue.pl
But the values 'parts' and 'numbers' are not used in view_holdsque.tt
With other words we have:
'subtitle': used at many places
'parts': not (yet?) used
'numbers': not (yet?) used
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Owen! Besides basketgroup.tt, there are a few remaining references to JavaScript widgets in the YHAOO namespace: - koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt This template is used by a script that is no longer linked to the administration page, and per bug 9819 it looks like there's an active effort underway to remove the last of the legacy stopwords code. - koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt The only reference is in in a FIXME comment that can probably just be removed. - koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt The references are in commented-out code that appears to be the beginning of an attempt to add a course reserve search option to the global search box. This code can probably just be removed; adding such a search option for real can be the topic of a separate bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What|Removed |Added Attachment #19046|0 |1 is obsolete|| --- Comment #95 from Galen Charlton --- Comment on attachment 19046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19046 [PASSED QA] Bug 7143: Release team 3.14 on about page Latest pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8684] Duplicate check for creating items on order broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684 --- Comment #4 from Katrin Fischer --- The checks for duplicate values within the order work, but it's not correctly checking the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 --- Comment #1 from Katrin Fischer --- Created attachment 19052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19052&action=edit screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10475] New: Item form in acquisition not hiding subfields properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Bug ID: 10475 Summary: Item form in acquisition not hiding subfields properly Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de It seems Bug 7116 has made some kind of reapparance in the order screen when ordering from existing records. If you hide subfields in your ACQ framework, these will be hidden in the item form when ordering items (AcqCreateItem = on order) but there is blank space where they used to be. This leaves the form quite long, while you want to hide fields to make it shorter and easier to handle. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Katrin Fischer changed: What|Removed |Added Severity|major |critical --- Comment #2 from Katrin Fischer --- Eeek, I found it. While the invoice is linked to the right item, so the items tab in staff is correct, the replacement and purchase price are on the wrong item. Upping severity - weird bug! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.10|master --- Comment #1 from Katrin Fischer --- Hi Nicole, I had watched the video a while ago, but it's no longer available :( I have tried to reproduce this on current master, but couldn't. I was using AcqCreateItem set to on order and received only one item to which I had added a barcode from the receive screen. Do you have an idea what I could have done differently? Can you still reproduce the problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9891] Current suspend holds have disappeared
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer --- Bug 10185 fixed this problem and is closed fixed, so this should be too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9891] Current suspend holds have disappeared
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7295] list of librarian managing a basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Katrin Fischer changed: What|Removed |Added Version|3.14|master QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9366] On cataloguing each user can easily display tags or not
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10405] User-editable sections should have ids
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405
Katrin Fischer changed:
What|Removed |Added
Attachment #18831|0 |1
is obsolete||
--- Comment #5 from Katrin Fischer ---
Created attachment 19051
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19051&action=edit
[PASSED QA] Bug 10405: add IDs for custom regions
This patch adds unique IDs for:
opaccredits
opacheader
OPACMobileUserCSS
OpacNavBottom
OpacUserCSS
opacuserjs
This is an amended patch which includes the changes to CCSR which I
forgot to commit before. The patch does not add a unique ID for
opacheader to CCSR, since opacheader is positioned wrong.
This is most useful for previewing changes you make in the OPAC
preferences using the following javascript in your IntranetUserJS:
function showPreview(url) {
$('#preview-loading').show();
document.getElementById('opac-preview').src = url;
$('#opac-preview').load(function () {
$('#opac-preview').show();
$('#region-opaccredits',
$('#opac-preview').contents()).html($('#pref_opaccredits').val());
$('#region-opacheader',
$('#opac-preview').contents()).html($('#pref_opacheader').val());
$('#opacmainuserblock',
$('#opac-preview').contents()).html($('#pref_OpacMainUserBlock').val());
$('#opacmainuserblockmobile',
$('#opac-preview').contents()).html($('#pref_OpacMainUserBlockMobile').val());
$('#region-opacnav',
$('#opac-preview').contents()).html($('#pref_OpacNav').val());
$('#region-opacnavbottom',
$('#opac-preview').contents()).html($('#pref_OpacNavBottom').val());
$('#opacrightsidebar',
$('#opac-preview').contents()).html($('#pref_OpacNavRight').val());
$('#noresultsfound',
$('#opac-preview').contents()).html($('#pref_OPACNoResultsFound').val());
$('#opacresultssidebar',
$('#opac-preview').contents()).html($('#pref_OPACResultsSidebar').val());
$('#region-opacusercss',
$('#opac-preview').contents()).replaceWith('' + $('#pref_OPACUserCSS').val() + '');
$('#region-opacuserjs',
$('#opac-preview').contents()).replaceWith('' + $('#pref_opacuserjs').val() + '');
$('#preview-loading').hide();
});
}
$(document).ready(function () {
if ($('#pref_OpacNav').size() > 0) {
$('#doc3').after('Preview changesMain pageResultsDetailsHide');
$('#preview-main').click(function () {
showPreview('/cgi-bin/koha/opac/opac-main.pl');
});
$('#preview-results').click(function () {
showPreview('/cgi-bin/koha/opac/opac-search.pl?idx=&q=pqf%3D%40attr+1%3D_ALLRECORDS+%40attr+2%3D103+%22%22&branch_group_limit=');
});
$('#preview-details').click(function () {
showPreview('/cgi-bin/koha/opac/opac-detail.pl?biblionumber=1');
});
$('#preview-hide').click(function () {
$('#opac-preview').hide();
$('#preview-loading').hide();
});
}
});
Signed-off-by: Srdjan
Signed-off-by: Katrin Fischer
Note: The provided JavaScript didn't work for me and resulted in an
error in Firebug. Ater talking to Jared it seems like there is more needed
than the bit of Javascript so make this work, but it might be a good
starting point, so I am leaving it in the commit message.
Passes all tests and QA script.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10405] User-editable sections should have ids
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Katrin Fischer changed: What|Removed |Added Status|Signed Off |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |FIXED --- Comment #93 from Katrin Fischer --- Just getting this out of the signed off list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Jonathan, I just checked master to find out which plugins we now got and there already is an ItemTypes plugin (and 2 plugins for authorised values?) Could you take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 --- Comment #1 from Jared Camins-Esakov --- Created attachment 19050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19050&action=edit Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jared Camins-Esakov changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov changed: What|Removed |Added Blocks||10403 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jared Camins-Esakov changed: What|Removed |Added Depends on||10274 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff CC||ve...@veron.ch Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 --- Comment #3 from Marc Véron --- Created attachment 19049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19049&action=edit Bug 5652 - Patron checkout and holds summary should show subtitles This patch adds subtitles (from Keyword to MARC mapping) to following tables on the checkout page: - Checkouts - Previous checkouts - Relative's checkouts - Relative's previous checkouts - Holds Additionaly it suppresses the appearence of the superfluous word "by" in cases where the biblio has no author. Test scenario: -- 1) Make sure that you have one or more fields mapped to subtitle in: Home . Administration . Keyword to MARC mapping (e.g. 245 b) 2) Test the checkout page with patrons having - current checkouts (today) - previous checkouts - relatives (e.g. kids) with current /previous checkouts - holds on items - holds on biblios ...with items having: - title, subtitle, author - title, no subtitle, author - title, subtitle, no author - title, no subtitle, no author 3) Do the same on patron's detail page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off CC||katrin.fisc...@bsz-bw.de Patch complexity|Small patch |--- --- Comment #8 from Katrin Fischer --- Nice work Owen! Can we also get a patch for the authority frameworks? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer changed: What|Removed |Added Attachment #18943|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 19048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19048&action=edit [PASSED QA] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Looks nice, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Katrin Fischer changed: What|Removed |Added Attachment #18636|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 19047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19047&action=edit [PASSED QA] Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes all tests and QA script. Really nice to see YUI go. Checked that the drag&drop functionality in basket groups still works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #15 from Katrin Fischer --- 5) Oh, before I forget: I had added the bug number to the database update when fixing the conflicts. Please add it when you do a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Hm, testing this I have am a little worried about a few things in this approach: 1) These patches remove the batch edit and delete options from the Edit menu, but the system preference added is by default off. So we actually take away a feature with the update. 2) The interface seems not quite right to me. Instead of having to select an option from a pull down and then click on go, I think having 2 links instead would save one click and be less fiddly. 3) The first column has the little arrow for sorting, but sorting doesn't work, whether you have seleted checkboxes or not. Also if you activate the filters, it has an added search box that doesn't make sense for this column. Failing for 1) and 3). My personal opinion is that it would be nice to deal with it like with the "activate filters" option. So it's not a "all or nothing" option using the system preference as only switch, but also something people can choose to activate easily on demand. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer changed: What|Removed |Added Attachment #16708|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Attachment #18565|0 |1 is obsolete|| --- Comment #94 from Katrin Fischer --- Created attachment 19046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19046&action=edit [PASSED QA] Bug 7143: Release team 3.14 on about page Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Template change only, looks all ok to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317
Katrin Fischer changed:
What|Removed |Added
Attachment #18491|0 |1
is obsolete||
--- Comment #4 from Katrin Fischer ---
Created attachment 19045
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19045&action=edit
[PASSED QA] Bug 10317: The parcel page display whatever if the invoiceid is
unknown
This patch fixes some stuffs on the parcel page.
1/ Removes dead code
2/ Display an error message if invoiceid is unset or not to refer to an
invoice
3/ Fix a bug in the note ("change note" and "add note" links)
Test plan:
1/ Try to call the invoice page with an existing invoiceid and check
that order results are consistent.
2/ Try without invoiceid or a bad invoiceid and check that an error
message is displayed.
3/ Add and change notes.
Signed-off-by: Cedric Vita
Signed-off-by: Katrin Fischer
Works nicely for all tests done.
- parcel.pl with invalid invoicenumber gives a nice error message
- parcel.pl with a valid invoicenumber looks normal
- changing and editing order notes works well
Passes QA script.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Katrin Fischer changed: What|Removed |Added Attachment #18830|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 19044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19044&action=edit [PASSED QA] Bug 10439: FIX modify the library for a notice. 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - switch on the IndependentBranches pref - try to change the library for a notice. Before the patch, no change is applied. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Note: only a superlibrarian can change the library or create new notices for every library. This bug can only be reproduced with superlibrarian permissions. Tested with independentbranches on/off. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10439] Cannot modify the notice's library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10439 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Katrin Fischer changed: What|Removed |Added Attachment #18591|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 19043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19043&action=edit [PASSED QA] Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10405] User-editable sections should have ids
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--- Comment #4 from Katrin Fischer ---
I'd love to test this with the provided javascript, but it doesn't work for me,
I get an error about this line:
$('#region-opacuserjs', $('#opac-preview').contents()).replaceWith('' + $('#pref_opacuserjs').val() +
'');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer changed: What|Removed |Added Attachment #19041|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 --- Comment #6 from Katrin Fischer --- Created attachment 19042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19042&action=edit [PASSED QA] Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber || borrower_list ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Adding a nice new autocomplete feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Tomás Cohen Arazi changed: What|Removed |Added Attachment #18982|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 19041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19041&action=edit Bug 10464 - Patron search on placing a hold should provide autocomplete We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version on reserve/request.tt and also adjusts form and input id's to match those configured in the autocomplete call. This changes where needed due to name collisions with the patron-search-box.inc that is present everywhere. To test: - On a biblio record, go to the Holds tab, mine looks like /cgi-bin/koha/reserve/request.pl?biblionumber=2 - A search box is shown for patron searching. - Search for a patron: it works as usual. - Make sure CircAutocompl is 'Don\'t try' - Apply the patch - Click the Holds tab again, and do the same search: functionality should remain intact. - Change CircAutocompl to 'Try' - Click the Holds tab again - Autocomplete should show you the possible options, and once you choose one result, it should work as usual. Note: once you apply the patch the width of the search input field will be doubled. If you are oleonard and prefer to stick with size=20, please amend the patch, I just prefered how it looked at size=40. Regards To+ Edit: Wrapped the JavaScript code with [% UNLESS ( borrowernumber || borrower_list ) %] to fix the behaviour on the case of rendering the placing hold page instead. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Katrin Fischer changed: What|Removed |Added Attachment #18394|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 19040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19040&action=edit [PASSED QA] Bug 10029 - CAS authentication fails in OPAC reserve If OPAC reserve page is accessed without being logged-in, login form is displayed as well as a CAS authentication link (if enabled). A click on this link will lead to CAS server but one comming back to Koha, page shows an error : "ERROR: No biblionumber received". This is because CAS link only contains the query path "/cgi-bin/koha/opac-reserve.pl", not the query parameters. This patch adds query parameters to URI sent to CAS. Test plan : - Enable CAS - Go to opac without been logged-in - Try to place hold on a record => You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing authentication page => Check that CAS link contains query param "biblionumber" - Click on CAS link and log in => Check you return well logged-in to reserve page with biblionumber param Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer I have followed the test plan as far as I could and the links contain the biblionumber now, which they didn't before. I couldn't check the CAS login, but my normal login worked as expected. All tests and the QA script pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Katrin Fischer changed: What|Removed |Added Attachment #17609|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #12 from Katrin Fischer --- Created attachment 19039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19039&action=edit screenshot of dialog described in comment I think we are almost there, but there is one little thing I am still worried about: When I close the basket with the user that has not group_manage permission, I still get offered the yellow dialog on closing the basket that asks me if I want to create a basket group with the same name as the order and put my order in it. If you check the checkbox and save you go to an error page: Error: You do not have permission to access this page. Click to log out... I think ideally we should not have this happen, but remove that bit from the dialog. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #35 from Jared Camins-Esakov --- Created attachment 19038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19038&action=edit Bug 9755 QA follow-up: fix template compliance Fix the following test failure: * koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.incFAIL forbidden patterns OK tt_validFAIL lines 10, 24 valid_template OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer --- Looking at this now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Katrin Fischer changed: What|Removed |Added Attachment #18635|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 19037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19037&action=edit [PASSED QA] Bug 10366: Alert librarian if an invoice number is duplicated Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. To test: 1) Apply patch and run database update. 2) Make sure that you have created at least one invoice on acqui/parcels.pl and take note of the invoice number. 3) Try to create an invoice with the same invoice number. 4) Note that without changing your configuration this works exactly the same as before. 5) Turn on the AcqWarnOnDuplicateInvoice system preference. 6) Try to create a new invoice with the same number as the one you noted earlier. 7) Make sure you get a warning about a duplicate invoice. 8) Choose to receive on the existing invoice. 9) Confirm that you are receiving on said existing invoice. 10) Start the receiving process over, and this time choose "Create new invoice anyway." 11) Confirm that you are now receiving on a new invoice. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Passes all tests and QA script. I have followed the test plan, but also checked some more things: - Checking the duplicate check works when you have the entered invoice number in your database multiple times already. - Checking that no duplicate message is shown if you enter the invoice number and it's already been used for an invoice from another vendor. Looks all good. I think the only thing we could argue about here is if this could be activated by default for new installations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Srdjan, please keep the test plans in the commit messages, thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10390] Add ability to delete unused invoices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10390] Add ability to delete unused invoices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Katrin Fischer changed: What|Removed |Added Attachment #18596|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 19036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19036&action=edit [PASSED QA] Bug 10390: Add ability to delete empty invoices There is currently no way to delete unused invoices (for example, invoices created by mistake), and there really should be, since errors and absent-mindedness can result in numerous empty invoices over the course of years. To test: 1) Apply patch. 2) Create three invoices in the Acquisitions module. For one of them, receive at least one item. For the other two, do not receive any items. 3) View one of the invoices that does not have any items on it. 4) Try to delete it. This should succeed. 5) View the invoice that has an item. There should not be any option to delete it. 6) Do an invoice search that brings up the other invoice with no items on it. Try to delete it from the results page. This should succeed. 7) Run the unit test: > prove t/Acquisition/Invoice.t 8) Sign off. Signed-off-by: Srdjan Signed-off-by: Katrin Fischer All tests and QA script pass. I also did another test: I cancelled all receipts from an existing invoice and then could successfully delete it in the last step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de Assignee|oleon...@myacpl.org |tomasco...@gmail.com --- Comment #4 from Katrin Fischer --- Hi Tomas, I really like the idea :) But I have found something that I'd like you to investigate: When sending the form without waiting for the autocomplete to take place (I used 's') you get to the suggestion list that Koha already did before your patch. This is good because I think it works without Javascript, so is a good fallback. But when I am on this screen, there is a Javascript error in my Firebug console: $(...).autocomplete(...).data(...) is undefined Line 335 Could you take a look? If it's not too much of a rewrite to fix, you can switch back to 'signed off'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10464] Patron search on placing a hold doesn't use jqueryui.autocomplete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10464 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10246] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Katrin Fischer changed: What|Removed |Added Attachment #18996|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 19035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19035&action=edit [PASSED QA][3.10] bug10246 adding OPAC details items table classes for 3.10 (3.12 version is bug10245) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer This patch applies cleanly to the 3.10.x codebase. It's adding additional classes to the elements. Template only CSS related change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10246] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack changed: What|Removed |Added Attachment #19033|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 19034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19034&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9755] Record merge code needs to be refactored
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #34 from Katrin Fischer --- The QA script points out a problem with template validity that I think was introduced with these patches. Bit hard to make out the changes here, as large parts of the code have been deleted, rewritten and moved. * koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.inc FAIL forbidden patterns OK tt_validFAIL lines 10, 24 valid_template OK Jared, please fix in a follow up and switch back to signed-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack changed: What|Removed |Added Attachment #18057|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 19033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19033&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- I am a bit torn here. While I don't doubt Julian's sign-off, we have set up the rules to be apply to all. For this reason only, I would like to see another sign-off here. Please don't take it personally, as it's not meant to be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Owen, not sure if it's a false positive, but the QA script found something to complain about: * koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt FAIL forbidden patterns OK tt_validOK valid_template FAIL patroncards-batches-toolbar.inc: not found Could you please take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 --- Comment #11 from Katrin Fischer --- Just a note to the release maintainers: I have seen this problem in 3.10.2 as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- I think Srdjan forgot to switch this to signed off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Katrin Fischer changed: What|Removed |Added Attachment #18832|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 19032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19032&action=edit [SIGNED-OFF] Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form Signed-off-by: Srdjan Signed-off-by: Katrin Fischer Removes datepickers from fields where they are not needed. When the new datepickers were added Owen made them so they show up when you use certain keywords in your markup. That's great, but by accident this older form was affected. Template only change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #14 from Katrin Fischer --- This script is potentially dangerous as it deletes data in an unrecoverable way. Maybe we should have a very clear warning about the consequences of this in the script before you can run it. Deleting orders and baskets has some consequences like losing the acquisition history shown in the items tab in staff detail page. Also if you are not careful with the date, you will mess up the amounts in your funds and budgets for a fiscal year. Really bad. I never had this request from one of our libraries and I can't help but wonder why you wouldn't want to keep the data. I wonder if it's display problems being the reason for this request or some law requirement? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10448] Changing framework when cataloguing clears all fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10448 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Jonathan, since we have moved to GPL3+ can I update the license text when QAing this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10246] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Catalyst patch, can someone else please QA this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9890] Fix the new plugin system for package installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 --- Comment #21 from Katrin Fischer --- Robin, could you ake a look at this maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10388] acq edited items showing 'null's
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Just a note that this bug goes back quite far - I have encountered it in 3.10.2 recently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10364] add a way to partially receive an order without creating a new order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10364 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I think that this would be quite hard to do if we want to keep the history right. For example you want to link to the right invoice number for each received item from the items tab in the staff detail page. But the current database structure wouldn't allow that for multiple items received on different invoices being in the same order line... (hope that makes some sense) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 --- Comment #1 from Katrin Fischer --- Created attachment 19031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19031&action=edit Bug 10474: Translate some English strings in German sample notices This translates 2 strings missed doing the initial translation in ISSUESLIP. To test: - Run the web installer in German. Altnernatively: - Truncate your letters table and run the SQL against the database. Check that the notices were added correctly, especially ISSUESLIP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10474] Translate some missed English strings in German sample notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10474] New: Translate some missed English strings in German sample notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10474 Bug ID: 10474 Summary: Translate some missed English strings in German sample notices Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: katrin.fisc...@bsz-bw.de Reporter: katrin.fisc...@bsz-bw.de CC: gmcha...@gmail.com There are still some English strings in the German sample notices waiting for translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Kyle, I think we both know that your test plan here is a bit too optimistic? ;) marcflavor is used in like a gazillion places to make things work correctly, so there is probably no way at all to test this from the GUI. Marcel++ for thinking about case insensitivity! I am not sure if the win here is worth the risk. The system preference name doesn't contain critical characters like underscores or hyphens and it's only to be set at installation time. Might it be more confusing for developers to change it now that we have been using the term for so long? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
