[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240
Frédéric Demians frede...@tamil.fr changed:
What|Removed |Added
CC||frede...@tamil.fr
--- Comment #6 from Frédéric Demians frede...@tamil.fr ---
Great idea and implementation!
The patch doesn't apply anymore on HEAD. Their is a conflict on
staff-global.css.
Reading the code, I have one question and one remark:
(1) How does IndexedDB scale? Your synchronization stores locally
patrons and issues (if I understand correctly). So is there a limit to
the borrowers and issues Koha tables size?
(2) Few lines in offline.tt won't be translatable:
item.title = item.title || (Unknown);
item.author = item.author || (Unknown);
$('#alerts').append('div class=dialog alerth3Check in
message/h3/div');
$(.loading-overlay div).text(_(Loading page + page + , please wait...));
$('#alerts').append('div class=dialog alerth3Check out
message/h3/div');
alert(You are offline and therefore cannot sync your database);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #6 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19055 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19055action=edit Bug 9998: QA Followup for comparing sysprefs Only cosmetic stuff: Perltidied with xt/perltidyrc. Replaced most double quotes by single quotes around SQL statements. Moved the usage into POD for pod2usage. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #4) Note: I did not test the feature! Too bad, but thanks anyway.. 1/ It would be good to use perltidy on this new file. Fixed that 2/ Don't you think it is better to have a pod instead of the print _USAGE_ stuff (and to use Pod2Usage)? Not sure, but moved it to pod. 3/ SQL strings should be between simple quotes. Also not sure about that. I replaced most of them. But had one case: AND COALESCE(explanation,'')='' AND COALESCE(options,'')='' where I could not replace them.. Back to Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10184] Circulation History reverses sort order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #14 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #7) To be clear, I wasn't calling for the creation of a list of system preferences that should not be overridden; what I was proposing was that a system administrator might choose to override marcflavour to prevent staff who only have access to the staff interface from changing its value. If these are two individuals, you will not always know who should prevent who from doing what.. I don't think this is necessary. To use the proposed mechanism, one has to have root access in order to change the Apache configuration, which is itself a higher bar to mischief than what YASP would provide. Agreed, it is not essential but changing the Apache config and restarting http services will perhaps be not as easy as 'stop overriding this pref' by changing a koha preference.. What we do need in addition to this patch, is a way to make very clear in the preferences editor that a specific preference has been overridden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10478] New: Do we need a sequential number generator?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 Bug ID: 10478 Summary: Do we need a sequential number generator? Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl Copy and past from report 9921: --- Comment #15 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #14) 3) I feel that incrementalControlNumber is not (really) a pref. I can imagine more cases where we might need a sequential number. Would it be interesting to move it perhaps to Tools in a more general context such as a sequence number engine with its own table (id, keyname, seqnumber, date)? There are more fields like callnumber (with plugins) that could use such an approach.. This does again not block your patch, but we could trigger the discussion on a more general solution. This idea (creating a sequence engine) is worth elevating to a new enhancement bug. There's been some chatter on #koha the past few days about this in the context of improving how sequential patron cardnumbers are assigned. [END-OF-QUOTE] Note: Since this bug is not yet in assigned status, you are welcome to write some code :) It would probably be interesting too to add another column subkey or something that allows you to have sequence number for the combination key, subkey. You could e.g. have numbers then for 'shelf', '1 A' and 'shelf','2 C', etc. But this idea could have many more applications. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #85 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10381] Hide basket links should be improved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #10 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #5 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10157] koha-email-enable error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #5 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10146] koha-stop-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10094] koha-list should have an --disabled option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10144] koha-start-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #9 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10149] koha-restart-zebra error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10149 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #11 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #11 from Chris Hall chr...@catalyst.net.nz --- Thank you for your notes Tomas Pushed to 3.8.x, will be in 3.8.14 along with all dependencies as I think they are a very useful addition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #14 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16403|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19056 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19056action=edit Bug 9811: Patron search improvement This patch add DataTables using server-side processing for the patrons search. It adds: - 1 module C4/Utils/DataTables/Members.pm - 1 service svc/members/search - 1 template members/tables/members_results.tt - 1 new practice which is to add template for DataTables in a subdirectory named 'tables'. Impacted scripts: members/members-home.pl and members/members.pl To go further: We can imagine that all patrons searches use the same service with no big changes: 1 little template creates a JSON file and to implement DataTables on the template page, that's all. Test plan: - Check that there is no regression on searching patrons. - Try filters on the left of the screen - Try to sort each column - Try the Browse by last name links. - Check that the Clear button clears yours filters. - Try with IndependantBranches ON and OFF Signed-off-by: Cedric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16957|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19057 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19057action=edit Bug 9811: Add unit tests for C4::Utils::DT::Members -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #7 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #8 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10296] UT: db schemas are useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #7 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10413] Odd space character brakes translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Chris Hall chr...@catalyst.net.nz changed: What|Removed |Added CC||chr...@catalyst.net.nz --- Comment #17 from Chris Hall chr...@catalyst.net.nz --- Pushed to 3.8.x, will be in 3.8.14 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #13) Test 10 at the least may fail if there is any data already in the courses table. This patch removes the truncations that ensure the tables are empty. Yes, good catch. I will provide a followup. We could require an empty table but it is a useless restriction. (In reply to comment #14) If we required the tables to be empty, would that mean that you could never run the test on a installation where you have played around with course reserves? It agrees with bug 10273, bug 10337 and my mail on koha-devel (subject: Where are we on unit tests?, date: June, 4th 2013 16:53). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19058 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19058action=edit Bug 10332: Data could exist in the courses table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19058|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19059 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19059action=edit Bug 10332: Data could exist in the courses table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #14) This script is potentially dangerous as it deletes data in an unrecoverable way. Maybe we should have a very clear warning about the consequences of this in the script before you can run it. Deleting orders and baskets has some consequences like losing the acquisition history shown in the items tab in staff detail page. Also if you are not careful with the date, you will mess up the amounts in your funds and budgets for a fiscal year. Really bad. A confirm flag is needed for deleting records. Without it, a list of orders and baskets is displayed. I never had this request from one of our libraries and I can't help but wonder why you wouldn't want to keep the data. I wonder if it's display problems being the reason for this request or some law requirement? I don't know, I asked Mathieu Saby to explain why this script is useful for them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8368] List email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #16 from mathieu saby mathieu.s...@univ-rennes2.fr --- Hello It was made for us, but before my arrival in Rennes 2, so I don't have all the informations. I will ask our team. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.7 (had forgotten to tell, thanks cjh) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10413] Odd space character brakes translation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 --- Comment #18 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.7 (had forgotten to tell, thanks cjh) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19060 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19060action=edit Bug 9044: QA followup 1/ Remove filter and sort for the checkboxes column. 2/ Enable the pref by default. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #14) Hm, testing this I have am a little worried about a few things in this approach: 1) These patches remove the batch edit and delete options from the Edit menu, but the system preference added is by default off. So we actually take away a feature with the update. 2) The interface seems not quite right to me. Instead of having to select an option from a pull down and then click on go, I think having 2 links instead would save one click and be less fiddly. 3) The first column has the little arrow for sorting, but sorting doesn't work, whether you have seleted checkboxes or not. Also if you activate the filters, it has an added search box that doesn't make sense for this column. Failing for 1) and 3). 1 and 3 fixed with the qa followup. For 2, the idea is to add others actions in this drop-down list. So it will be difficult to deal with more than 2 links. Back to Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- What other actions do you have in mind? I think unless we really have another idea there would be no reason to overcomplicate the interface. Maybe we could ask Owen nicely to take a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- The last patch deals with the existing plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18599|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19061 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19061action=edit Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #18) What other actions do you have in mind? No one for now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 Nuño López Ansótegui nu...@masmedios.com changed: What|Removed |Added Attachment #18862|0 |1 is obsolete|| --- Comment #19 from Nuño López Ansótegui nu...@masmedios.com --- Created attachment 19062 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19062action=edit Bug 9921 - Make it possible to force 001 = biblionumber Added 'use Modern::Perl;' in cataloguing/value_builder/marc21_field_001.pl Update if there is no plugin attached. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 Nuño López Ansótegui nu...@masmedios.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10479] New: Heading for location facet shows up even when there are no locations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10479 Bug ID: 10479 Summary: Heading for location facet shows up even when there are no locations Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de Created attachment 19063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19063action=edit screenshot The location facet shows up always, althought the library in question is not using locations in their item data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail because there is no use strict ( or use Modern::Perl ). Could you amend your followup to include one of those. After that I think it will be good to pass QA! FAIL t/db_dependent/CourseReserves.t OK pod OK forbidden patterns OK valid FAIL critic # TestingAndDebugging::RequireUseStrict: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #15) This idea (creating a sequence engine) is worth elevating to a new enhancement bug. There's been some chatter on #koha the past few days about this in the context of improving how sequential patron cardnumbers are assigned. See bug 10478 please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #19) Created attachment 19062 [details] [review] Bug 9921 - Make it possible to force 001 = biblionumber Thanks for doing so. Added 'use Modern::Perl;' in cataloguing/value_builder/marc21_field_001.pl This will not really work. You will have lots of redefine warnings. I will add yet another report to have another way of adding plugins without redefines. Please wait, I will submit within a few minutes. Update if there is no plugin attached. Great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Now I tested :) 1/ There is no error if the -file parameter is missing. 2/ Explanations are not restored, why don't you store them in the backup file? (explanations are useful when you search a pref without to know its name). 3/ 17 Run with -cmd compare -file zz02 -del. pref zz02 should not be deleted. returns Adjusted (at most) 2 prefs from this compare. = but no change done. I think you should change in HandleCompareChanges: ++$t DeleteOnePref($k) if $compare_del; with $t += DeleteOnePref($k) if $compare_del # But need to check 0E0 for 0 Maybe 2 first patches could be squashed. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] New: Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Bug ID: 10480 Summary: Cataloging plugins without redefining Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: m.de.r...@rijksmuseum.nl Reporter: m.de.r...@rijksmuseum.nl CC: m.de.r...@rijksmuseum.nl From bug 9921, Galen: All the more reason to stick to our coding guidelines, if the additional warning messages in the log annoys somebody enough to inspire them to fix that issue with the cataloging plugins, then. :) I am submitting a proposal here. May not be perfect yet, but we loose the redefines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19064action=edit Bug 10480: New cataloging plugin style without redefining This reports adds the way we handle cataloging plugins. Currently, three functions are redefined: plugin_parameters, plugin_javascript and plugin. In this new proposal, communication between addbiblio and the plugin goes via a global variable. The plugin script detects that way if we are building the plugin or executing it. A example plugin is added just to illustrate the concept. Plugin marc21_leader.pl is adjusted to the new style (plus some cosmetic changes: removing tabs etc.) Test plan: Run the MARC editor and test your current plugins. If you use marc21_leader, test it again. Temporarily connect new_example_plugin to some field and test that. Check the log for warnings about redefines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #18) Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail because there is no use strict ( or use Modern::Perl ). Could you amend your followup to include one of those. After that I think it will be good to pass QA! FAIL t/db_dependent/CourseReserves.t OK pod OK forbidden patterns OK valid FAIL critic # TestingAndDebugging::RequireUseStrict: Got 1 violation(s). Kyle, Looks good here: $ qa -c 2 -v 2 testing 2 commit(s) (applied to 77a5e3e 'Bug 10439: fix bug preventing the lib') OKt/db_dependent/CourseReserves.t OK pod OK forbidden patterns OK valid OK critic the file contains use Modern::Perl;. Your t/perlcriticrc (Koha src) file should contain [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl [TestingAndDebugging::RequireUseWarnings] equivalent_modules = Modern::Perl Maybe your qa tools repository is not up-to-date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #19005|0 |1 is obsolete|| --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 19065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19065action=edit Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the AllowOfflineCirculation system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the Offline circulation interface link on the Circulation home page, choosing Synchronize (must be online), and clicking the Download records button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the Check in tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the Check out tab. 8. Set a due date (the Remember for session box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the Synchronize link and choose Upload transactions to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #18) (In reply to comment #17) (In reply to comment #16) New code *must* enable the warnings pragma; please use Modern::Perl. This could still be a problem with the way the plugins work in the marc editor. The routine is redefined iirc.. All the more reason to stick to our coding guidelines, if the additional warning messages in the log annoys somebody enough to inspire them to fix that issue with the cataloging plugins, then. :) I actually disagree here. We cannot block development, because we already have a bad construct in Koha and a new developer should solve that first. We need to be somewhat pragmatic. As long as the construct is in, we are more or less obliged to support it. We would not encourage people to submit patches, if they should start solving our old problems. But I looked a little bit, sufficiently annoyed :) and submitted a proposal for this under bug 10480. Have a look! BTW It will not be possible to phase out all old plugins directly, because we have to keep in mind that people may have also written custom plugins this way. Bug 10480 supports both ways therefore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #6) Great idea and implementation! The patch doesn't apply anymore on HEAD. Their is a conflict on staff-global.css. Rebased on latest master. Reading the code, I have one question and one remark: (1) How does IndexedDB scale? Your synchronization stores locally patrons and issues (if I understand correctly). So is there a limit to the borrowers and issues Koha tables size? There is not really a limit that I was able to identify. Downloading naturally takes longer the more records you have, but modern web browsers will just ask the user if they are willing to allow the application to increase the size of the IndexedDB database for that particular site, and the consensus online is that you can easily store a few million records in IndexedDB without it showing any performance issues. (2) Few lines in offline.tt won't be translatable: I fixed those (and a couple others). Thanks for spotting that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 --- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Someone to QA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16014|0 |1 is obsolete|| Attachment #16566|0 |1 is obsolete|| Attachment #16613|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19066 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19066action=edit Bug 7180: Order from staged file improvements This patch adds: - 1 syspref MarcFieldsToOrder - 1 ajax script acqui/ajax-getauthvaluedropbox.pl - 1 routine C4::Budgets::GetBudgetByCode Before this patch you were not able to order 1 or all the records from your staged file. You were allowed to specify some information (Import All and Accounting details areas) for the order. With this patch, the previous behaviours still exist. But now you can *select* which records you want to ordered. For these ones you can specify independently informations (Quantity, price, budget, sort1 and sort2). The cherry on the cake is that you can pre-fill these information with values Test plan: 1. Fill the new syspref MarcFieldsToOrder with something like: ==BEGIN== price: 947$c quantity: 969$h budget_code: 922$a rrp: 010$d discount: 969$d sort1: 923$a sort2: 924$a ==END== The empty line at the end is mandatory! The budget (corresponding to your budget_code) can be filled with authorized value categories (statistic 1 and 2). The sort1 and sort2 values can be filled with the an authorized value (of the category previously selected) 2. Choose randomly one or more biblio(s) and fill fields with what is relevant. 3. Export the biblio and import it (with the Stage MARC records for import tool). 4. Go on a basket and add an order from a staged file. Select your staged file. 5. Well. Now you can see your biblio (or biblios if your had exported more than one). For each one, informations should be pre-filled with the biblio values. The budget should be selected on the budget corresponding to the budget_code (in the field 922$a) and the planning values too (with fields 923$a and 924$a). You can modify these values (or not) and choose a default value for budget and planning values (in the Accounting details area). 6. Save and check the prices values. Modify the order and check that budget and sort* are good Prices are calculated following some parameters: if there is no price = listprice = 0 else = - the gstrate value for your order is the gstrate value of the bookseller - discount = if filled : the discount value / 100 else: the discount value of the bookseller - if the bookseller includes tax( List item price includes tax: Yes ) if a discount exists: ecost = price rrp = ecost / ( 1 - discount ) else: # a discount does not exist ecost = price * ( 1 - discount ) rrp = price else # the bookseller does not include tax if a discount exists: ecost = price / ( 1 + gstrate ) rrp = ecost / ( 1 - discount ) else: # a discount does not exist rrp = price / ( 1 + gstrate ) ecost = rrp * ( 1 - discount ) - in all cases: listprice = rrp / currency rate unitprice = ecost total = ecost * quantity 7. Retry with different parameters 8. Check the 'Import all' action still works -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19067 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19067action=edit Bug 7180: FIX getAuthValueDropbox should display the selected value If the no AV match the name/category or if no category is defined, the input field should contain the value. Signed-off-by: Pierre Angot tredok.pie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19068 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19068action=edit Bug 7180: Add UT for C4::Budgets::GetBudgetByCode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com --- Rebased patch. Unit tests from t/db_dependent/Budgets.t pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #7) Someone to QA ? I will if someone does not beat me to it. Note that adding a comment drops you from top of the list to the very end (when sorting by Change date). Will try to remember. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off Assignee|kyle.m.h...@gmail.com |ve...@veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #19049|0 |1 is obsolete|| --- Comment #4 from Nicole C. Engard neng...@gmail.com --- Created attachment 19069 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19069action=edit [SIGNED-OFF] Bug 5652 - Patron checkout and holds summary should show subtitles This patch adds subtitles (from Keyword to MARC mapping) to following tables on the checkout page: - Checkouts - Previous checkouts - Relative's checkouts - Relative's previous checkouts - Holds Additionaly it suppresses the appearence of the superfluous word by in cases where the biblio has no author. Test scenario: -- 1) Make sure that you have one or more fields mapped to subtitle in: Home . Administration . Keyword to MARC mapping (e.g. 245 b) 2) Test the checkout page with patrons having - current checkouts (today) - previous checkouts - relatives (e.g. kids) with current /previous checkouts - holds on items - holds on biblios ...with items having: - title, subtitle, author - title, no subtitle, author - title, subtitle, no author - title, no subtitle, no author 3) Do the same on patron's detail page Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 --- Comment #3 from Nicole C. Engard neng...@gmail.com --- Here's the video again: http://screencast.com/t/a71HEUjuzZFs Now I'm going to test on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #23 from Nuño López Ansótegui nu...@masmedios.com --- (In reply to comment #21) (In reply to comment #19) Created attachment 19062 [details] [review] [review] Bug 9921 - Make it possible to force 001 = biblionumber Thanks for doing so. Added 'use Modern::Perl;' in cataloguing/value_builder/marc21_field_001.pl This will not really work. You will have lots of redefine warnings. I will add yet another report to have another way of adding plugins without redefines. Please wait, I will submit within a few minutes. Update if there is no plugin attached. Great. Ok, I wait, thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #23) Ok, I wait, thanks. You do no longer need to wait. Click bug 10480 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 --- Comment #4 from Nicole C. Engard neng...@gmail.com --- I do believe you are right and this is fixed in the current master. I'd like to know how/when though so that it can be fixed in 3.10.x Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, did you see comment 2? I managed to recreate it in the end, just confused that the invoice links correctly, but the data is entered into the wrong item (or so it seemed). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19070action=edit Bug 9998: QA Followup for comparing sysprefs Only cosmetic stuff: Perltidied with xt/perltidyrc. Replaced most double quotes by single quotes around SQL statements. Moved the usage into POD for pod2usage. Passing no file shows help screen too. Counting the db updates more accurately with return value of do. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #8) Now I tested :) Great. 1/ There is no error if the -file parameter is missing. Shows help now. 2/ Explanations are not restored, why don't you store them in the backup file? (explanations are useful when you search a pref without to know its name). This is intentional. See bug 10199. Depends on solution there. This script got the -ign-opt parameter just for this reason. 3/ 17 Run with -cmd compare -file zz02 -del. pref zz02 should not be deleted. returns Adjusted (at most) 2 prefs from this compare. = but no change done. At most is a maximum :) Replaced this lazy programming with your suggestion. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- Oh darn!! Well then it's still a bug and I was using my Monday brain - which should never be used to find and report bugs :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- I bet you're right. Thanks! Kyle (In reply to comment #19) (In reply to comment #18) Thanks for the followup Jonathan! Everything looks, except koha-qa.pl fail because there is no use strict ( or use Modern::Perl ). Could you amend your followup to include one of those. After that I think it will be good to pass QA! FAIL t/db_dependent/CourseReserves.t OK pod OK forbidden patterns OK valid FAIL critic # TestingAndDebugging::RequireUseStrict: Got 1 violation(s). Kyle, Looks good here: $ qa -c 2 -v 2 testing 2 commit(s) (applied to 77a5e3e 'Bug 10439: fix bug preventing the lib') OK t/db_dependent/CourseReserves.t OK pod OK forbidden patterns OK valid OK critic the file contains use Modern::Perl;. Your t/perlcriticrc (Koha src) file should contain [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl [TestingAndDebugging::RequireUseWarnings] equivalent_modules = Modern::Perl Maybe your qa tools repository is not up-to-date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] New: No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Bug ID: 10481 Summary: No enrollment fee when changing patron category Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When a patron changes to a category with enrollment fee, they are not generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to comment #20) Maybe your qa tools repository is not up-to-date. Could be the perlcritic version too.. Version 1.116 warns about Modern Perl :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- adds the way = changes the way -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19071action=edit Bug 10481: FIX No enrollment fee when changing patron category. When a patron changes to a category with enrollment fee, they are not generated. Test plan: - Choose a category without fee (e.g. Kid) - Add an enrollment fee for another category (e.g. Young adult) - Choose a kid and change his category to Young adult. - Note the warning message Fees Charges: Patron has Outstanding fees charges of XX on the check out page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #19064|0 |1 is obsolete|| --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 19072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19072action=edit Bug 10480: New cataloging plugin style without redefining This reports adds the way we handle cataloging plugins. Currently, three functions are redefined: plugin_parameters, plugin_javascript and plugin. In this new proposal, communication between addbiblio and the plugin goes via a global variable. The plugin script detects that way if we are building the plugin or executing it. A example plugin is added just to illustrate the concept. Plugin marc21_leader.pl is adjusted to the new style (plus some cosmetic changes: removing tabs etc.) Test plan: Run the MARC editor and test your current plugins. If you use marc21_leader, test it again. Temporarily connect new_example_plugin to some field and test that. Check the log for warnings about redefines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10482] New: add items limit and sort to rebuild zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Bug ID: 10482 Summary: add items limit and sort to rebuild zebra Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com When indexing biblio records, the items are added into MARC format during database export (MARCXML or ISO2709). For some records, there is a huge number of items, mainly serials creating an item for each issue. There should be an option in rebuild_zebra.pl to limit the number of items added to record and an option to define a sort of those items. This will speed-up some indexing and avoid a known bug : when Zebra has a record with size too big for ISO2709 format this record returned as search result is broken (some items fields contains odd characters). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6435 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19073action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] False no items in search results [intranet]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10482 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] False no items in search results [intranet]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #8 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- I think this bug is a consequence of removing items form MARC. When using rebuild_zebra.pl, in get_raw_marc_record() : - without --noxml option the items are added to MARC::Record in GetMarcBiblio() call. - with --noxml option, MARC::Record is build from biblioitems.marc and items are not added. This might be corrected by Bug 10482. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #9 from Galen Charlton gmcha...@gmail.com --- (In reply to comment #8) (In reply to comment #7) To be clear, I wasn't calling for the creation of a list of system preferences that should not be overridden; what I was proposing was that a system administrator might choose to override marcflavour to prevent staff who only have access to the staff interface from changing its value. If these are two individuals, you will not always know who should prevent who from doing what.. Well, ultimately that's up to the Koha consortium or library to work out. In practice, however, I suspect most consortial users of Koha would be hesitant to let local library sysadmins have access to system preference until such time as Koha support per-library syspref values. What we do need in addition to this patch, is a way to make very clear in the preferences editor that a specific preference has been overridden. Agreed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think the RM's opinion on this was clearly stated and I tend to agree with him ;) We leave the Modern::Perl in, but don't require to fix all the warns immediately. Ultimately we should fix those and always keep an eye on the logs to avoid adding more noise with new features. If 10480 does achieve that - even better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #12 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9133] We need a data set for db dependent tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9133 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Closing this bug. Mocked tests are provided, and jenkins takes care of real DB tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10483] New: check_uniqueness.pl does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483
Bug ID: 10483
Summary: check_uniqueness.pl does not work
Classification: Unclassified
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolyn.som...@biblibre.com
When syspref UniqueItemFields is defined, the item uniqueness is tested in
acquisition by an Ajax call to check_uniqueness.pl.
I noticed that it does not work, item is always created without alert even on
existing barcode.
I have looked in perl debug mode and found that in check_uniqueness.pl :
my $input = new CGI;
my @field = $input-param('field');
my @value = $input-param('value');
@field and @value are always empty.
It is because in CGI the params are named field[] and value[].
It seems to be because of the ajax serialization of a Javascript Array.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10405] User-editable sections should have ids
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- Just a general comment -- it may take me a bit longer than normal to test this; because this patch adds divs wrapping all of the user-editable sections -- whether the sysprefs have contents or not -- I'm going to be checking whether any CSS tweaks may be called for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: Just some minor things: 1/ I hate the $_ variable loop... :) 2/ the die would be replaced with pod2usage 3/ pod2usage has a message param (in order to display No filename given, etc.) 4/ I think that verbose = 1 would be more appropriate for warning messages. 5/ use Modern::Perl instead of warnings ad strict I don't know if it is blocker. Let the RM takes the decision. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Marcel, I squashed the 2 patches, I hope it is ok for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19075 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19075action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9998] Import/export and compare system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19006|0 |1 is obsolete|| Attachment #19055|0 |1 is obsolete|| Attachment #19070|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19074 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19074action=edit Bug 9998: Import/export and compare system preferences This patch adds a new maintenance script: cmp_sysprefs.pl Test plan: 1 Run with -cmd backup -file zz01. Check that file. Run with -cmd test -file zz01. Check zz01.sav. 2 Run with -cmd compare -file zz01. No differences expected. 3 Edit zz01: delete two prefs, change two prefs and add two new prefs. 4 Run with -cmd compare -file zz01. Are all six changes reported? 5 Add local use preference zz02 in the staff client (no explanation, options). 6 Run with -cmd backup -file zz02. 7 Delete local use pref zz02 from the staff client. 8 Run with -cmd restore -file zz02. Check if local pref zz02 came back. 9 Delete local use pref zz02 again from the staff client. 10 Run with -cmd compare -file zz02 -add. Check if local pref zz02 came back. 11 Change the value of zz02 in the staff client. 12 Run with -cmd compare -file zz02 -add. Check the value: not updated? 13 Run with -cmd compare -file zz02 -upd. Check the value: updated now? 14 Edit file zz02. Add a comment line and delete the line for pref zz02. 15 Run with -cmd compare -file zz02 -del. Is pref zz02 deleted? 16 Add local use preference zz02 in the staff client (WITH explanation). 17 Run with -cmd compare -file zz02 -del. pref zz02 should not be deleted. 18 Run with -cmd compare -file zz02 -del -ign-opt. zz02 should be deleted now. Do the next steps only on a restorable test db: 19 Create file zz03. Leave it empty. Compare with: -cmd compare -file zz03 -del -ign-opt. All prefs gone except Version? 20 Restore with: -cmd restore -file zz01.sav. Compare with -cmd compare -file zz01.sav. Nothing reported? Note: The explanation or options are not recovered. (See also BZ 10199.) This affects local use preferences only. If you need them, restore your test db. Remove the zz files. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Amended patch Only cosmetic stuff: Perltidied with xt/perltidyrc. Replaced most double quotes by single quotes around SQL statements. Moved the usage into POD for pod2usage. Passing no file shows help screen too. Counting the db updates more accurately with return value of do. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10483] check_uniqueness.pl does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7178 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
