[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #15 from Frédéric Demians  ---
Your patch contains:

  sleep 5;

This must be configurable. 5 seconds is too small for large catalogs.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #14 from Doug Kingston  ---
Created attachment 19267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19267&action=edit
Patch to add daemon mode to rebuild_zebra.pl

This diff adds a daemon mode to rebuild_zebra.pl.  By polling the queue every
few seconds from a running process, we can achieve very fast indexing response
with low system overhead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10454

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9921

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #13 from Doug Kingston  ---
OK, I have gone to the cron job.  I will look into an alternative wrapper
daemon that just checks the mysql queue and calls rebuild only when necessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19261|0   |1
is obsolete||

--- Comment #44 from Chris Cormack  ---
Created attachment 19266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19266&action=edit
QAed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type.

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mag...@enger.priv.no
   Assignee|koha-b...@lists.koha-commun |mag...@enger.priv.no
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #12 from Jared Camins-Esakov  ---
zebraqueue_daemon is broken and was removed from Koha several versions ago. Do
not use it. Your best bet would be to either use rebuild_zebra and teach your
staff to deal with the delay, or to find someone who can troubleshoot the
koha-index-daemon from Tamil.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #11 from Doug Kingston  ---
I was using koha-index-daemon
(http://search.cpan.org/~fredericd/Koha-Contrib-Tamil-0.029/bin/koha-index-daemon)
but clearly this does not correctly export all records.  So I have stopped and
reverted back to the less elegant (but functioning) koha-zebraqueue-daemon
(zebraqueue-daemon.pl).  We should either get this other daemon fixed or
removed.  I forget how I got pointed to it originally.
Our problem is now resolved.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #12 from M. de Rooy  ---
> In that case you will need to call German (or any lang) file first so i18n()
> function it is correctly defined.

Yes and no :) Actually when running the English sql file that contains the i18n
calls, I first pass the German i18n definition to mysql. This will make the
English install insert German strings. But you could say that I only have one
sql file to run, and I 'source' (read: run) the i18n definition first.

For English, I would have a fake i18n that returns the same string, so no
translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #18 from M. Tompsett  ---
Though I would really like to fix up memberentry.pl and the javascript that is
associated with cardnumber checking, I have decided against it. That way people
can actually look at and potentially use Koha::Sequence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

M. Tompsett  changed:

   What|Removed |Added

  Attachment #19264|0   |1
is obsolete||

--- Comment #17 from M. Tompsett  ---
Created attachment 19265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19265&action=edit
Bug 10454 - Duplicate card numbers may be generated

Previously, there was a gap in time between the insertion of
the card number into borrowers and the generation. This gap
meant that the same card number could be calculated by two
different processes resulting in two different members being
added with the same card number.

By creating a Koha::Sequence class, the requests are serialized
and prevent duplication. And this class allows for flexibility
with other sequences that may wish to be maintained.

The fixup_cardnumber now merely uses the Koha::Sequence to get
the next numerical portion of the cardnumber. If checkdigit is
'katipo', the new cardnumber is calculated out of the numeric
portion.

Perfect serialization leads to another problem: gaps. Gaps which
are generated by deletion of old records are to be expected, but
gaps generated by continually clicking refresh are not. This is
an outstanding problem to now solve on the patron entry screen.
This is beyond the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Galen Charlton  changed:

   What|Removed |Added

  Attachment #19258|0   |1
is obsolete||

--- Comment #95 from Galen Charlton  ---
Comment on attachment 19258
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19258
Bug 7368: Followup for columns names in userflags.sql

Pushed latest to master.  Thanks, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

M. Tompsett  changed:

   What|Removed |Added

  Attachment #19196|0   |1
is obsolete||

--- Comment #16 from M. Tompsett  ---
Created attachment 19264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19264&action=edit
Bug 10454 - Duplicate card numbers may be generated

Previously, there was a gap in time between the insertion of
the card number into borrowers and the generation. This gap
meant that the same card number could be calculated by two
different processes resulting in two different members being
added with the same card number.

By creating a Koha::Sequence class, the requests are serialized
and prevent duplication. And this class allows for flexibility
with other sequences that may wish to be maintained.

The fixup_cardnumber now merely uses the Koha::Sequence to get
the next numerical portion of the cardnumber. If checkdigit is
'katipo', the new cardnumber is calculated out of the numeric
portion.

Perfect serialization leads to another problem: gaps. Gaps which
are generated by deletion of old records are to be expected, but
gaps generated by continually clicking refresh are not. This is
an outstanding problem to now solve on the patron entry screen.
This is beyond the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495

--- Comment #7 from Jonathan Druart  ---
(In reply to Galen Charlton from comment #6)
> Pushed to master.

Thanks, Galen! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Galen Charlton  ---
Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #15 from Jonathan Druart  ---
Fridolyn,

I reproduce the issue and your patch fixes something, but it is not perfect. I
got:
Checked Out
20/04/2012
13/04/2012
19/03/2013
Checked Out
12/09/2012
Checked Out
12/09/2012
12/09/2012

In fact when the sort plugin find something else than a date, it get all mixed
up.


But try (members/readingrec.tt ~l.83):

-[% issue.returndate | $KohaDates %]
+[% issue.returndate |
$KohaDates %]

It works for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6279] Can't delete lists from the second page of lists in the OPAC

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6279

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 CC||jonathan.dru...@biblibre.co
   ||m
 Resolution|--- |FIXED

--- Comment #6 from Jonathan Druart  ---
Works for me on master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9253] If an item is reserved, at the opac it is marked as available

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9253

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@biblibre.co |oleon...@myacpl.org
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Patch complexity|--- |Small patch
   Assignee|alex.arn...@biblibre.com|jonathan.dru...@biblibre.co
   ||m

--- Comment #11 from Jonathan Druart  ---
I removed the $commandline variable. Script in tools are only for the Koha
interface, not command line.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #4589|0   |1
is obsolete||
  Attachment #10023|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  ---
Created attachment 19263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19263&action=edit
Bug 5771 : Adds a download link for big error reports to import_borrowers

If the import patrons tools produced a lot of errors(e.g. 1000), the
browser will crash or not be glad.

This patch allow to download an error file for report producing at least
25 errors.

Test plan:
Import patrons with at least 25 errors and check that a "Download
report" button appears and produce a text file to download.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
In that case you will need to call German (or any lang) file first so i18n()
function it is correctly defined.

That's not reversing the order?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #11746|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  ---
Created attachment 19262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19262&action=edit
Bug 8436: Add limit on branch in checkexpiration.pl

This limit is only available for superlibrarians and patrons that have
superserials permission. Other patrons will only see subscriptions of
their branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #43 from Jonathan Druart  ---
Only the last patch (unit tests) needs QA. The first one already passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #42 from Jonathan Druart  ---
Rebased patches. Fix conflicts with bug 10080.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #16944|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart  ---
Created attachment 19261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19261&action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #16943|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart  ---
Created attachment 19260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19260&action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904

Jonathan Druart  changed:

   What|Removed |Added

   Priority|PATCH-Sent (DO NOT USE) |P5 - low
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|paul.poul...@biblibre.com   |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904

Jonathan Druart  changed:

   What|Removed |Added

   Attachment #3364|0   |1
is obsolete||
   Attachment #3365|0   |1
is obsolete||
   Attachment #3809|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  ---
Created attachment 19259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19259&action=edit
Bug 5904: ysearch.pl members improvements (Independent branches behaviour)

Test plan:
- Add a staff user foo in a library A
- Add a staff user bar in a library B
- log in as foo and try to search 'bar'
- Switch on (Prevent) the new pref IndependentBranchPatron
- the search returns no result
- log in as a superlibrarian
- Check that you are allow to search all patrons.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10509] Using updates instead of inserts in translated mysql files

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #10 from M. de Rooy  ---
Just thinking about this, we could do something else too :)
What do you think about running the English file with i18n calls while defining
i18n for the German translation in this case with something as:

DELIMITER //
DROP FUNCTION IF EXISTS i18n//
CREATE FUNCTION i18n (d text) RETURNS text DETERMINISTIC
BEGIN
RETURN CASE d
WHEN 'Remaining circulation permissions'
'Übrige Ausleihberechtigungen'
WHEN 'Override blocked renewals'
'Gesperrte Verlängerungen überschreiben'
WHEN 'Execute overdue items report'
'Überfälligkeiten-Report ausführen'
[ etc. etc.]
WHEN 'Configure plugins'
'Plugins konfigurieren'
ELSE d
END;
END //

This file could also be very easily created from a POD file..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10513] New: Light up a warning/message when returning a chosen item type.

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513

Bug ID: 10513
   Summary: Light up a warning/message when returning a chosen
item type.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: viktor.sa...@regionhalland.se
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We plan to use a specific item type to keep track of ILLs. The possibility to
chose a message to display when returning specific item types would be highly
useful to make sure that the ILLs isn't shelved at the local library. I imagine
others could find other uses for it so building it as general as possible would
be good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19230|0   |1
is obsolete||

--- Comment #94 from Jonathan Druart  ---
Created attachment 19258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19258&action=edit
Bug 7368: Followup for columns names in userflags.sql

An insert statement should contain the column names to avoid confusion and
future problems with table definition changes.
I have updated the English default file.
Will send updates for the other languages in connection with replacing inserts
by updates for the additional languages (where possible). For userflags this
will be possible.

Test plan:
Do an install (English).

Or -- as a dangerous(!) alternative--:
Do this ONLY on a restorable database.
Delete all records in userflags. (Note: This cascades to permissions a.o.)
Run this file from command line.
Check if you have records again in userflags. (You also messed up your Koha.)
Restore your database.

Signed-off-by: Marcel de Rooy 
Tested both ways myself :)

Signed-off-by: Bernardo Gonzalez Kriegel 

Comment: Work as described. No errors.
Tested using second alternative

Just a note: if you update other lang files replacing INSERTs for UPDATEs
then you must install using EN and later apply lang files by hand.
If you do a translate first before webinstaller, and finish your install
in your lang, then that kind of file will fail.

Signed-off-by: Jonathan Druart 

mysql> create database test;
Query OK, 1 row affected (0.00 sec)

% mysql -u koha -p test < installer/data/mysql/kohastructure.sql
% mysql -u koha -p test < installer/data/mysql/en/mandatory/userflags.sql

mysql> select count(*) from userflags;
+--+
| count(*) |
+--+
|   19 |
+--+
1 row in set (0.00 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7368] General staff client typo omnibus

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462

--- Comment #4 from M. de Rooy  ---
(In reply to Jonathan Druart from comment #3)
> Hi Marcel,
> 
> On searching isbn=2070518426 on the BNF Z3950 server, I got
> on master:
>   Harry Potter à l'école des sorciers # J. K. Rowling #  # 2070518426 |
> 9782070612369
> and, on master + your patch:
>   Harry Potter à l'école des sorciers # J. K. Rowling # 1998 # 2070518426
> 
> I separate fields with '#'.
> 
> With your patch, the date is get back but the isbn field seems truncated: on
> master I got 2 isbn separated with a pipe, now I get only one isbn.
> 
> Looking at the code, I cannot explain this change.

Will soon have a look at this. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
Hi Marcel,

On searching isbn=2070518426 on the BNF Z3950 server, I got
on master:
  Harry Potter à l'école des sorciers # J. K. Rowling #  # 2070518426 |
9782070612369
and, on master + your patch:
  Harry Potter à l'école des sorciers # J. K. Rowling # 1998 # 2070518426

I separate fields with '#'.

With your patch, the date is get back but the isbn field seems truncated: on
master I got 2 isbn separated with a pipe, now I get only one isbn.

Looking at the code, I cannot explain this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #90 from Galen Charlton  ---
(In reply to Paul Poulain from comment #89)
> > I think we should focus on getting DBIx::Class::Schema::Loader support
> > ready, including sussing out any necessary schema updates and dealing with
> > the DBIx::Class maintainer's recommendation to not use
> > DBIC_DONT_VALIDATE_RELS.  I think for the moment code that exercises
> > DBIx::Class can rely on $schema->resultset('Table'), although if people have
> > a real problem with the length of that construct, I think some AUTOLOAD
> > magic would be preferable to manually maintaining an extra layer of DB
> > access classes.
> what do you mean by "length of that construct" ? it's slow (length=duration)
> ? verbose ? something else ?

I mean verbosity, i.e., the textual length.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Chris Nighswonger  changed:

   What|Removed |Added

 CC||d.ly...@thebeijingcenter.or
   ||g

--- Comment #33 from Chris Nighswonger  ---
*** Bug 10512 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10512] Label PDF Export Corrupted

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10512

Chris Nighswonger  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Chris Nighswonger  ---
Opening the attached pdf file in a plain text editor shows this error:

Software error:
Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 819


For help, please send mail to the webmaster (mailto:[no address
given]">[no address given]), giving this error message 
and the time and date of the error.



This is probably related to bug 8375, so I'm marking it as a duplicate of that
bug.

*** This bug has been marked as a duplicate of bug 8375 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #48 from Jonathan Druart  ---
Since this patch has 3 signoffs and I cannot recreate the issue described by
Jared, I switch the status to Signed Off. The issue is not relevant, as I said,
I don't affect the lateissues-export.pl script.

I retested feature and it works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19173|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 19257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19257&action=edit
bug 10495: set precondition for HoldsQueue test

t/db_dependent/HoldsQueue.t assumed, but did not check,
that the AutomaticItemReturns system preference was off
at the beginning of the test un.  This patch makes sure
that that assumption is met.

To test:

[1] Make sure that at least one item is on loan (this is
another assumption that the test case makes, one
that should be corrected with the work proposed
for bug 10336.
[2] Turn the AutomaticItemReturn system preference on.
[3] Run the test:

prove -v t/db_dependent/HoldsQueue.t

[4] Tests 4 and 6 should fail.
[5] Apply the patch.
[6] Run the test case again; this time, all tests should pass.

Signed-off-by: Galen Charlton 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19191|0   |1
is obsolete||

--- Comment #17 from Chris Cormack  ---
Created attachment 19256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19256&action=edit
Bug 10336: HoldsQueue.t needs to create its own data

After applying this patch and the patch submitted in bug 10495, you can
run prove t/db_dependent/HoldsQueue.t and admire that all tests pass.

This patch creates a borrower and uses Koha routines instead of directly
request the database.

Signed-off-by: Kyle M Hall 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #89 from Paul Poulain  ---
(In reply to Galen Charlton from comment #87)
> I'm setting this bug back to 'In discussion', as I believe that the Unicode
> issue that Paul was running into is a red herring.
> 
> I have significant reservations about the the POC patches proposed earlier
> today.  In particular they assume that the namespace RFC has been agreed to
> -- and at this point, I do not believe that we actually have consensus on it.
> 
> More immediately, I have reservations about the Koha::DB layer. 
> DBIx::Class::Schema::Loader already provides pre-built data acccess classes
> -- which is the point of using it in the first place.  The Koha::DB::Branch
> class as proposed would add yet another file to edit whenever a new column
> is added to a table.  Rather than doing that, I think we should rely on
> misc/devel/update_dbix_class_files.pl, and correct the schema as needed so
> that we can avoid ever doing manual updates to the files under Koha/Schema.
We spoke of it already, at KohaCon12 In Edinburgh, and on koha-devel. See
http://wiki.koha-community.org/wiki/Koha_Namespace_RFC

However, I agree it's worth taking time to discuss it, because a lot of things
will depend on the decision we take here.

> I think we should focus on getting DBIx::Class::Schema::Loader support
> ready, including sussing out any necessary schema updates and dealing with
> the DBIx::Class maintainer's recommendation to not use
> DBIC_DONT_VALIDATE_RELS.  I think for the moment code that exercises
> DBIx::Class can rely on $schema->resultset('Table'), although if people have
> a real problem with the length of that construct, I think some AUTOLOAD
> magic would be preferable to manually maintaining an extra layer of DB
> access classes.
what do you mean by "length of that construct" ? it's slow (length=duration) ?
verbose ? something else ?

I'll have a look at any proposal & make counter-proposals or additions, until
we reach the optimal way to do it.
Chris, you're probably more experienced than I'm, so, your help is warmly
welcomed ;-)

> I think that bug 8309 (and the mailing list) is a better place for the
> discussion of the proposed namespace scheme.  To help keep the discussion in
> this bug focused, I've obsoleted all of the patches except for the squash
> (and thanks for doing that, Paul!)

No problem, I was not expecting those patches to be pushed though, they were
more a POC than real code.
(I think those patches are still usefull to address the encoding problem)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #88 from Paul Poulain  ---
(In reply to Galen Charlton from comment #86)
> I'm not seeing UTF8-releated breakage -- try running this program after
> applying the squashed patch.  The output (not counting a DBIx::Class::Carp
> about the nullability of borrowers.cardnumber that should be addressed at
> some point) is correct:
> 
> Institut Protestant de Théologie
I tried your small program, and confirm it works. So where does the problem
come from... If anyone has an idea...
I still think that we should have the mysql_enable_utf8 flag set, as the
documentation suggests that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10478] Do we need a sequential number generator?

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478

--- Comment #8 from M. Tompsett  ---
(In reply to M. de Rooy from comment #7)
> Looking forward to your code. Could you perhaps extend the generation of
> this number for the combination range, subrange as describe earlier here?

The table is made up of sequence_name and value pairs.
If you want subranges, I suppose you could take the range and subrange together
to form a sequence name.


> Do you plan to add code under Tools or Administration to show this table?

Card numbers don't need it.


> Viewing the values would at least be interesting.

I agree.


> But perhaps initializing a new sequence from a certain number,

Done.


> or resetting a sequence

I have a reset_everything method, which if modified for every sequence known to
mankind as they are added, could potentially be broken out to reset_sequence.


> is probably
> needed too in the long run.. But these functions might need some more
> thought, because they are pretty dangerous too.

If there's a way to calculate the number to use, resetting to that number isn't
so dangerous.


> Note also that there is a direct interest in your code for using it in bug
> 9921 that requires sequence numbers too.

Take a look at my sample test suite and output there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #48 from M. Tompsett  ---
Koha::Sequence will be added as part of bug 10454. This may be useful in this
context for incrementing something automatically.

Here's a preliminary sample test suite for it, and the output.
--- BEGIN ---
#!/usr/bin/perl

use strict;
use warnings;

use Test::More tests => 15;

BEGIN {
use_ok('Koha::Sequence' , 'check to use Koha::Sequence');
}

my $seq = Koha::Sequence->new('blah');
ok ( defined($seq) , 'created sequence called blah');
my $rv = $seq->reset_everything;
ok ( $rv , 'triggered reset of everything' );

$seq = Koha::Sequence->new('id1');
ok ( defined($seq) , 'created sequence called id1');

$rv = $seq->del_sequence;
ok ( $rv , 'deleted sequence called id1');

my $seq1 = Koha::Sequence->new('cardnumber_katipo');
my $seq2 = Koha::Sequence->new('cardnumber_none');
ok ( $seq1->is_sequence, 'Confirmed cardnumber_katipo sequence' );
ok ( $seq2->is_sequence, 'Confirmed cardnumber_none sequence' );

my $value;
ok ( $value = $seq1->get_next_value, "Value $value" );
ok ( $value = $seq1->get_next_value, "Value $value" );
ok ( $value = $seq2->get_next_value, "Value $value" );
ok ( $value = $seq2->get_next_value, "Value $value" );

$seq = Koha::Sequence->new('blah');
ok ( defined($seq) , 'created sequence called blah');
$rv = $seq->reset_everything;
ok ( $rv , 'triggered reset of everything' );

ok ( $value = $seq1->get_next_value, "Value $value" );
ok ( $value = $seq2->get_next_value, "Value $value" );
--- END ---

t$ prove -v Sequence.t
Sequence.t ..
1..15
ok 1 - use Koha::Sequence;
ok 2 - created sequence called blah
ok 3 - triggered reset of everything
ok 4 - created sequence called id1
ok 5 - deleted sequence called id1
ok 6 - Confirmed cardnumber_katipo sequence
ok 7 - Confirmed cardnumber_none sequence
ok 8 - Value 100
ok 9 - Value 101
ok 10 - Value 162
ok 11 - Value 163
ok 12 - created sequence called blah
ok 13 - triggered reset of everything
ok 14 - Value 100
ok 15 - Value 162
ok
All tests successful.
Files=1, Tests=15,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.10 cusr  0.00
csys =  0.12 CPU)
Result: PASS

the reset_everything rebuilds the cardnumber_katipo and cardnumber_none
sequences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6435] False "no items" in search results [intranet]

2013-06-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #10 from Fridolyn SOMERS  ---
You mean zebraqueue-daemon.pl ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/