[Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Amit, I am not sure how this link is a shortcut to the current behaviour? Searching for the vendor for example by sending an empty search and then clicking the receive shipment link there? To me it seems to just reverse the order of things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #92 from Galen Charlton --- (In reply to Magnus Enger from comment #91) > (In reply to Paul Poulain from comment #89) > > We spoke of it already, at KohaCon12 In Edinburgh, and on koha-devel. See > > http://wiki.koha-community.org/wiki/Koha_Namespace_RFC > > > > However, I agree it's worth taking time to discuss it, because a lot of > > things will depend on the decision we take here. > > How do we move this forward? Are there competing proposals? Should it be a > topic for an IRC meeting? The namespace question is not a blocker for DBIx::Class support -- the main blocker at the moment is addressing the concern of the DBIC maintainer about the current patch's use of DBIC_DONT_VALIDATE_RELS. I will be looking at this over the next couple weeks. As far as the namespace questions are concerned, because of the potential complexity, in my view an IRC meeting is not well-suited to discussing it; as I previously stated, bug 8309 and/or koha-devel are more suitable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton --- (In reply to Owen Leonard from comment #0) > The course reserves entry form shows an error message instead of a form > field for the department if no departments are defined: "No DEPARTMENT > authorised values found! Please create one or more authorised values with > the category DEPARTMENT." A question about the premise of this patch, possibly for Kyle: is there a functional reason why setting a department is absolutely required? If so, why is courses.department a nullable column? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #18 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Galen Charlton changed: What|Removed |Added Status|Passed QA |Needs Signoff CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 --- Comment #7 from Galen Charlton --- Comment on attachment 19296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296 [PASSED QA] Bug 10442 - Remove references to non-standard "error" class Review of attachment 19296: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10442&attachment=19296) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -171,5 @@ > [% END %] > > > - > - I'm not sure whether simply removing this is OK. There is code in additem.js that looks for the existence of a div whose CSS class is "error"; if such a div is not present, an error message (e.g., when trying to add a duplicate item) would have no place to be displayed. Setting bug back to "Signed-off" for QA to look into this. If I'm right, additem.js will need to be modified, e.g., to use a div ID rather than a div class to locate the placeholder for an error message. It may be necessary to apply the patch for bug 10483 to be able to test a situation where attempting to add an item during the process of creating a new order results in an error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Derryn changed: What|Removed |Added CC||derr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5390] library choice not remaining when searching opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5390 Chris Cormack changed: What|Removed |Added Attachment #3388|0 |1 is patch|| Attachment #3388|application/octet-stream|text/plain mime type|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5336] Acq history search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Katrin Fischer changed: What|Removed |Added QA Contact|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | --- Comment #52 from Katrin Fischer --- Hi Jonathan, I really like the idea of this. Starting with a code review and running the automated tests on the codes I found a few things: 1) The updatedatabase states: +print "Upgrade to $DBversion done (Add category ORDRSTATUS values in authorised_values table)\n"; But it does not actually add an authorised value? And it looks like we don't need one and can have the values in the template, so it might just be enough to correct the line. Please also add the bug number :) 2) Hm not sure about this line, does it maybe belong to 5394? order.internalnotes ) %][% order.internalnotes %][% END %][% order.isbn %] 3) Capitalization: Search Orders +Order Status: 4) Patches fail the QA script: FAILt/db_dependent/Acquisition/close_reopen_basket.t OK pod OK forbidden patterns FAIL valid Use of qw(...) as parentheses is deprecated OK critic 5) Checking my database and comparing it to kohacstructure in your patch, the order of subscriptionid and parent_ordernumber are reversed. Not really sure how to explain that right now, so just noting. Will continue to test as nothing is severe so far, but can you please provide a follow-up? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7162] Factorize code for order cancellation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #36 from Katrin Fischer ---
Starting with some tests and a code review for these patches:
1) There are some problems with those patches pointed out by the QA script:
FAILacqui/addorder.pl
OK pod
FAIL forbidden patterns
forbidden pattern: tab char (line 126)
OK valid
OK critic
FAILacqui/cancelorder.pl
OK pod
OK forbidden patterns
FAIL valid
Use of qw(...) as parentheses is deprecated
OK critic
2) cancelorder.pl notes this:
+# FIXME: C4::Search is needed by C4::Items::GetAnalyticsCount, which is called
+# by C4::Acquisition::DelOrder. But C4::Search is not imported by C4::Items.
+# Once this problem is resolved, the following line can be removed.
+# See Bug 7847.
+use C4::Search;
7847 is now marked resolved, can this line be removed?
3) From looking at the code it seems like you no longer have the choice to
delete the bibliographic record or to keep it.
4) Some little typos:
canceled -> cancelled
occured -> occurred
5) Just a pet peeve of mine: a linked 'here' is not friendly if you are quickly
scanning a page for the right link. It's always better to link the words that
actually describe what the link will do:
Click here to return to previous page
Could just be a linked: Return to previous page
Or maybe just a 'OK'?
6) A bad one: Please please, don't add untranslatable strings to the database:
+if($reason) {
+$query .= "
+, notes = IF(notes IS NULL,
+CONCAT('Cancellation reason: ', ?),
+CONCAT(notes, ' - Cancellation reason: ', ?)
+)
+";
+}
We really need to take care of that in a nicer way or at least not have any
hardcoded string in there or have it in the template.
It might be worth having an authorized value and a separate field to store
cancellation reasons as you might want to look up the reasons in reports in a
nice way later on.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #20 from Katrin Fischer --- I think change the display when we actually have more options :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7180] Order from staged file improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer --- I have tested this, but there are a lot of small and bigger things I am not quite happy with. I really feel like this needs a bit more work. 1) The green color for selected lines seems debatable given the overall look and feel of the Koha GUI. Can you please reconsider? 2) The form has a few design issues - the labels and fields are not properly aligned in a smaller window, making it hard to figure out what goes where. It might fit a bit better into 2 columns and smaller fields for quantity, price and discount. I think the fields should ideally match the formatting on the normal order page. Also required fields should be highlighted and the input should be validated. Like there is no complaint if you don't input the quantity. 3) The label budget is wrong and should be fund instead. Also the list shows funds from inactive budgets. 4) In comparison to the normal form we are missing the option to set the currency in the form. I think it might be safe to assume that all records in that list will be one and the same currency, but it's not clear how to indicate the currency to be used. 5) When you select a fund that is connected to an authorised value list and then undo the selection, you end up with the string "undefined" in the input field. Some ideas: - I think instead of having the full form on each entry it would save a lot of space if we could only display it for selected records and keep the smaller layout for when now records are selected. - There is no option to see more about the record and we are only displaying 245$a it seems, which is not really helpful if you have lots of similar records. Showing a link to the ISBD/MARC preview might help that. - Instead of no_match we should be displaying a nicer text for the librarian. - It might be worth adding an option to pick the right tax rate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- This fails the QA script in 2 places, can you please take a look? FAILC4/Acquisition.pm OK pod FAIL forbidden patterns forbidden pattern: IndependantBranches is now known as IndependentBranches (line 1553) FAILt/db_dependent/lib/KohaTest/Acquisition/GetPendingOrders.pm OK pod OK forbidden patterns OK valid FAIL critic # Modules::RequireFilenameMatchesPackage: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer --- I really like the idea to use datatables for the patron search page, but I found a few problems with the patches. 1) The patches don't pass the QA script: * koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (95) The patch introduces a forbidden pattern: tabulation character (94) * C4/Utils/DataTables/Members.pm FAIL pod OK forbidden patterns OK valid FAIL Use of qw(...) as parentheses is deprecated 2) The new C4/Utils/DataTables/Members.pm adds mysqlisms: my $select = "SELECT SQL_CALC_FOUND_ROWS "SELECT FOUND_ROWS()"; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10484] serials-edit.pl not checking for barcode field before checking for barcode subfield
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10484 Katrin Fischer changed: What|Removed |Added Attachment #19199|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 19304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19304&action=edit [PASSED QA] Bug 10484 - serials-edit.pl not checking for barcode field before checking for barcode subfield The script serials-edit.pl is not checking for the existence of the barcode field before checking for barcode subfield for autoBarcode = incremental. If the barcode field doesn't exist, the script dies with errors. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes tests and QA script. Checked that adding items on serial receive still works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5349] Moving an order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #66 from Katrin Fischer ---
Hi Julian,
It looks to me like the design of internalnotes is not a good idea:
+$order->{'internalnotes'} = "Transfered from $booksellerfromname on
$today";
+$sth->execute("Cancelled and transfered to $booksellertoname on $today",
$ordernumber);
This won't ever be translatable. We should never store composed English strings
in the database.
Also I think that for a column named internalnotes I would expect a different
use. Like a internal note that a librarian can set and edit.
Other solutions I can think of are to store the transferdate and the original
vendor in separate columns and compose the message in the templates.
Or it might be worth having a column for a cancellation reason that is filled
via an authorized value list.
This way we could also give other reasons, like out of print, etc. But the date
and vendor would still have to be stored somewhere else if you want to keep
that information. Maybe action_log?
Maybe a quick discussion about this could help to find the best solution.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi fridolyn, I have some concerns about your patch: 1) The patch works nicely according to the description, but it limits on branchcode and so suggestions created for _ANY_ library are always left out. The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. But that doesn't change anything about 1) :) 2) I am also wondering if superlibrarians should see the total count instead of a branch related one, but I think showing them the count for the branch they are logged in at is probably right. Failing QA for 1). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #4 from Katrin Fischer --- Ok, forget that... I had confused my bug numbers :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I am sorry, but this does no longer apply due to a conflict in the VirtualShelves.t: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10499: VirtualShelves.t - wrap tests in a database connection Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/VirtualShelves.t CONFLICT (content): Merge conflict in t/db_dependent/VirtualShelves.t Failed to merge in the changes. Patch failed at 0001 Bug 10499: VirtualShelves.t - wrap tests in a database connection When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer changed: What|Removed |Added Attachment #18445|0 |1 is obsolete|| --- Comment #17 from Katrin Fischer --- Created attachment 19303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19303&action=edit [PASSED QA] Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer XSLT change adding quotes. Search now matches search in the intranet. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer changed: What|Removed |Added Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10431] Spanish Zebra language definition file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10431 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Katrin Fischer changed: What|Removed |Added Attachment #19292|0 |1 is obsolete|| Attachment #19293|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 19301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19301&action=edit [PASSED QA] Bug 10494: test cases for the KohaBranchName plugin To test, in a test database that has the sample branches loaded, run prove -v t/db_dependent/Koha_template_plugin_KohaBranchName.t Note that this includes regression tests for the issues reported in bug 10494; these won't pass without applying the patch that fixes them. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 --- Comment #6 from Katrin Fischer --- Created attachment 19302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19302&action=edit [PASSED QA] Bug 10494: remove spurious warnings from the KohaBranchName plugin The KohaBranchName plugin now returns an empty string if given a NULL (undefined) library code or a library code that is not present in the database (e.g., the '__ANY__' placeholder that purchase suggestions can use). To test: [1] Create a purchase suggestion, setting the library to 'Any'. Create a second one setting the library to a specific one. [2] Go to the suggestions overview page in the staff interface. When you do so, the Apache logs should contain a warning that looks like this: [Wed Jun 19 07:13:06 2013] [error] [client 192.168.1.10] [Wed Jun 19 07:13:06 2013] suggestion.pl: Use of uninitialized value in concatenation (.) or string at /home/koha/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt line 487., referer: http://koha-staff.metaquarry/cgi-bin/koha/acqui/acqui-home.pl [3] Apply the patch. [4] Refresh the suggestions overview page. This time, there should be no new warning logged. [5] Verify that the library names for the two pending suggestions created in step 1 are displayed correctly. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Also adds new tests! Note: For the test plan to work you have to add the suggestion from the intranet, as Any is not an available option in OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10519] Suggestions: 'Ordered' shows up in tab 'Unknown'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 --- Comment #1 from Katrin Fischer --- Actually, there is a lot of weirdness in the tab display going on there for me, there might be more wrong about it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10519] New: Suggestions: 'Ordered' shows up in tab 'Unknown'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519 Bug ID: 10519 Summary: Suggestions: 'Ordered' shows up in tab 'Unknown' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de Created attachment 19300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19300&action=edit screenshot When organising tabs by status the 'ordered' suggestion shows up in a tab labelled 'Unknown'. I think there might be something missing in the templates here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10517] kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Robin, could you maybe take a look at this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton --- Pushed to master along with the follow-up. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|oleon...@myacpl.org |gmcha...@gmail.com QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #6 from Katrin Fischer --- Created attachment 19299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19299&action=edit Bug 10409: Follow up - improving strings for easier translation Fixing this line: [% IF course_id %] Edit [% ELSE %] Create [% END %] course As grammar works different in different languages, having single strings like that in a predefined order makes having a nice translation unnecessarily hard. This will make it a little easier: [% IF course_id %]Edit course[% ELSE %]Create course[% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- There are still some things that are a bit problematic: [% IF course_id %] Edit [% ELSE %] Create [% END %] course 'Lazy' constructs like that make it unnecessarily hard to translators, because grammar works different in different languages and having single strings like that in a predefined order is not nice. Even in German it does not really work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Katrin Fischer changed: What|Removed |Added Attachment #19278|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 19298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19298&action=edit [PASSED QA] Bug 10409 - Do not show course entry form if no departments are found The course reserves entry form should not be shown if there are no DEPARTMENT authorized values, since this prevents the form from being submitted. This patch replaces the form with an error message when no DEPARTMENT authorized values are found. Also corrected: - Corrected grid structure for more standard display - Converted labels with no corresponding inputs to - Closed unclosed tags - Corrected incorrect capitalization This patch contains whitespace changes, so please ignore whitespace when examining changes. To test, delete any DEPARTMENT authorized values, if present. Create a new course in Course Reserves. You should see a warning that no DEPARTMENT values were found. If you are logged in with the correct permission, the warning should contain a link to the correct authorized value page. If you do no, the warning should refer the problem to an administrator. After creating one or more DEPARTMENT values, the form should display and submit correctly. Signed-off-by: Jared Camins-Esakov After this patch has been applied, I get an error message and no form if I don't have any DEPARTMENTs defined, which makes sense given that the form can't be submitted without a DEPARTMENT. Signed-off-by: Katrin Fischer Passes all tests and QA script. You now see a useful error message, when no departments have been defined. Else you are taken to the correct form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10518] Relevance option for non-Latin scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 --- Comment #1 from Tigran --- Created attachment 19297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19297&action=edit After activating the option 'Relevance'->'Title A-Z' Armenian and Cyrillic records are mixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10518] New: Relevance option for non-Latin scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 Bug ID: 10518 Summary: Relevance option for non-Latin scripts Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcha...@gmail.com Reporter: tig...@flib.sci.am In Koha system (versions 3.08, 3.10, 3.12) for multi script records (e.g. titles are in Latin, in Cyrillic, in Armenian)after search, when from relevance drop down menu selecting 'Title (A-Z)' the display for non-Latin records is not in correct order. If for Latin records they are displayed in correct alphabetical order, Armenian and Cyrillic records are mixed, between the records with Armenian titles starting with the letter 'A' you can see records for which the title is starting with the letters 'M', 'H', then again 'A', then Cyrillic records are coming, and after those again records with Armenian letters. Is this a Zebra problem? Any ideas? thanks Tigran -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer changed: What|Removed |Added Attachment #19281|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 19296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296&action=edit [PASSED QA] Bug 10442 - Remove references to non-standard "error" class The CSS for is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard . This patch also corrects some minor HTML validity and capitalization errors in the changed templates. Testing each error condition in all the modified temlates is probably overkill for the minor changes made in this patch. Markup has simply been changed to use alternate existing styles. Visual confirmation of the markup changes is probably sufficient. Signed-off-by: Liz Rea confirmed the changes - no obvious errors, functionality seems fine. Signed-off-by: Katrin Fischer Passes all tests and QA script. I read the changes and did a few tests in Koha. Some of the error conditions are pretty hard to reproduce, I did manage for lateorders, but didn't succeed for memberentrygen and parcel. But changes appear to be save and I spotted no problems, so passing QA. Patch also fixes a few capitalization errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I am sorry, but I can't get this to work for me. I have tested in Firefox and Chromium, deleting my browser cache and it still shows the little bit from the other icon. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer changed: What|Removed |Added Attachment #19280|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 19295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19295&action=edit [PASSED QA] Bug 10497 - star ratings not showing right in ccsr detail Star ratings do not appear correctly in the CCSR theme because it lacks the image sprite used to display them. This patch adds the required file. To test, apply the patch and view a search results set which includes titles which have an existing rating. Ratings should appear correctly. View a detail page for an title which has a rating, and add a rating to a title which has no rating. Ratings should look correct and work correctly. Signed-off-by: Nicole C. Engard All tests pass - including leaving a rating on the newly visible stars Signed-off-by: Katrin Fischer In order to test this, make sure you have set OpacStarRatings set to 'results and details'. The star images show up in OPAC results with the correct amount of stars after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer changed: What|Removed |Added Attachment #19280|0 |1 is patch|| Attachment #19280|application/mbox|text/plain mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10497] star ratings not showing right in ccsr detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10497 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Hi Nicole, please remember to tick the 'patch' checkbox when uploading a patch manually. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer changed: What|Removed |Added Attachment #19279|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 19294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19294&action=edit [SIGNED OFF] Bug 10496 - CCSR theme OPAC tabs to not show correct active state When jQueryUI was updated in the CCSR theme the corresponding CSS changes were not copied over at the same time, causing style problems with jQueryUI widgets. This patch makes the necessary changes. To test, apply the patch, clear your browser cache, and view any page which uses jQueryUI tabs (advanced search, bibliographic detail page). Tabs should look correct and correctly show which tab is active. Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer CSS changes only. Confirmed problem in CCSR OPAC templates. Tested advanced search and detail pages in CCSR and prog. In order to fully test advanced search I added location and collection to AdvancedSearchTypes. Also tested the branch tooltip as I spotted some CSS added for that. Works beautifully, no problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer changed: What|Removed |Added QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Katrin Fischer changed: What|Removed |Added Attachment #19279|0 |1 is patch|| Attachment #19279|application/mbox|text/plain mime type|| CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Chris Cormack changed: What|Removed |Added Attachment #19157|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 19292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19292&action=edit Bug 10494: test cases for the KohaBranchName plugin To test, in a test database that has the sample branches loaded, run prove -v t/db_dependent/Koha_template_plugin_KohaBranchName.t Note that this includes regression tests for the issues reported in bug 10494; these won't pass without applying the patch that fixes them. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Chris Cormack changed: What|Removed |Added Attachment #19158|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 19293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19293&action=edit Bug 10494: remove spurious warnings from the KohaBranchName plugin The KohaBranchName plugin now returns an empty string if given a NULL (undefined) library code or a library code that is not present in the database (e.g., the '__ANY__' placeholder that purchase suggestions can use). To test: [1] Create a purchase suggestion, setting the library to 'Any'. Create a second one setting the library to a specific one. [2] Go to the suggestions overview page in the staff interface. When you do so, the Apache logs should contain a warning that looks like this: [Wed Jun 19 07:13:06 2013] [error] [client 192.168.1.10] [Wed Jun 19 07:13:06 2013] suggestion.pl: Use of uninitialized value in concatenation (.) or string at /home/koha/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt line 487., referer: http://koha-staff.metaquarry/cgi-bin/koha/acqui/acqui-home.pl [3] Apply the patch. [4] Refresh the suggestions overview page. This time, there should be no new warning logged. [5] Verify that the library names for the two pending suggestions created in step 1 are displayed correctly. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10494] KohaBranchName sends useless warnings to log if supplied library code is null or not present
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10494 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- I think as Chris is not planning to do more work on Goodreads it would be good to remove the system preference so there is no confusion on how to use this feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Katrin Fischer changed: What|Removed |Added Attachment #19283|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 19291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19291&action=edit [PASSED QA] Bug 10475 - Item form in acquisition not hiding subfields properly Subfields hidden in your ACQ framework leave a gap where they used to be in the item entry form when adding an item to an order. This patch makes the same change made by 7116 to services/itemrecorddisplay.tt to correct the problem. To test: - Edit your ACQ framework and set some item subfields to hidden in the editor. - Set your AcqCreateItem system preference to "when placing an order." - Add a title to an existing basket from an existing record. The item entry form should display correctly with your hidden subfields hidden. No whitespace should be left behind where the subfields were hidden. Also changed: Invalid "size" attributes on hidden form fields in neworderempty.tt, stray . Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works nicely, passes all tests and QA script. Thx Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10510] OPAC's renew selected link has glitchy icon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10510 Chris Cormack changed: What|Removed |Added Attachment #19246|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 19290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19290&action=edit Bug 10510 - OPAC's renew selected link has glitchy icon The "renew selected" link on the list of a user's checkouts looks bad because the next icon in the sprite shows through. This patch modifies the sprite to give it proper spacing and corrects the CSS to accommodate the change. To test, apply the patch, clear your browser cache, and view the following pages to confirm that the change works: - With TagsEnabled and TagsInputOnList enabled, view a search results page when logged in and when not logged in. Tag links should be styled correctly. - With OpacBrowseResults enabled, open the detail page for any record and click the "browse shelf" link. The "forward" and "back" arrows should be styled correctly. - With OpacRenewalAllowed enabled, log in to the OPAC and view your checked out items. The "renew selected" and "renew all" links should look correct. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Chris Cormack changed: What|Removed |Added Attachment #19015|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 19289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19289&action=edit Bug 5894 - Adding multiple items from a cart to a list shows only the first title Adds missing code that splits biblios before calling template. To test: Add some items to cart Open cart, select some or all items Add to list With patch, following window shold show something like "Add 3 items to a list:", followed by list of items Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #3 from Chris Cormack --- opac/opac-addbybiblionumber.pl and virtualshelves/addbybiblionumber.pl Duplicate a lot of subroutines, and code that should be in a subroutine, it would be a great job for a person new to Koha to write tests for the subroutines and then refactor them into a module. However this won't stop me signing off on this patch that does fix the problem -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5894] Adding multiple items from a cart to a list shows only the first title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5894 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
