[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19580|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19686 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19686action=edit [SIGNED-OFF] Bug 7598 - Acquisitions JavaScript contains untranslatable English strings English strings in acq.js cannot be processed by the translation script. This patch moves the strings to the templates to be set as JS variables for use by the script. To test: - On the uncertain prices page, enter an invalid price and click save. You should see a JavaScript alert pointing this out. - When adding a fund to an existing budget, enter an amount which exceeds the amount in the parent budget. You should see a JavaScript alert pointing this out. There is a similar function which has been corrected, checkBudgetParent(), but I don't know how to trigger it for testing. The closebasketgroup function has been updated but as far as I can tell it's not actually in use. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 --- Comment #18 from Julian Maurice julian.maur...@biblibre.com --- Only the syspref name change between the two patches. Maybe you can test only one and sign off both ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10543] false mandatory warning in additem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10543 --- Comment #13 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to Srdjan Jankovic from comment #12) Fridolyn, The last one, shouldn't it be just CheckMandatorySubfields()? The last patch ? No, the CheckMandatorySubfields() has an argument which is the parent object to use for searching subfield lines. This is necessary for the serial edition where there are hidden subfield lines, one must not check all line of the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Srdjan, Thanks for your signoff but this patch already passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19546|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19688 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19688action=edit Bug 10508: branchprinter will be a foreign key Bug 8034 will introduces a foreign key on branches.branchprinter. This patch set branchprinter values to undef. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19338|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 19687 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19687action=edit Bug 10508 : C4::Branch.pm needs unit tests. Unit tests are wrap in a transaction. NOTE: the field issuing isn't used in the database To test: prove t/db_dependent/Branch.t t/db_dependent/Branch.t .. ok All tests successful. Files=1, Tests=31, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.13 cusr 0.00 csys = 0.16 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Srdjan Jankovic from comment #9) prove t/db_dependent/Branches.t Cannot detect source of 't/db_dependent/Branches.t'! at Yes, it is Branch.t, not Branches.t. I modified the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Srdjan Jankovic from comment #6) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. Use of uninitialized value in pattern match (m//) at C4/SQLHelper.pm line 407. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at C4/SQLHelper.pm line 184. It seems you don't have the good category codes. You have to insert sample data before executing this unit tests file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz --- Omg, how did I miss that? Sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz --- installer/data/mysql/sample_only_param_tables.sql? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19684|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19595|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Srdjan Jankovic from comment #8) installer/data/mysql/sample_only_param_tables.sql? The patch for bug 10337 creates a DB with all sample data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Srdjan Jankovic from comment #2) There's something wrong with the patch: Did you applied dependent patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10566] Improve OPAC course reserves pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #19521|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19689 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19689action=edit Bug 10566 - Improve OPAC course reserves pages This patch makes various improvements to the OPAC course reserve pages: - Descriptive page titles for both pages. - More compact display of course information on course detail page (a list instead of a table, consistent with other displays of similar information in Koha). - Correct capitalization. - Added label and fieldset to course reserve search form. - Added breadcrumb navigatio nto course reserve detail page as a path back to course reserves main page. To test, apply the patch and confirm that the changes haven't broken anything and are an improvement. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10566] Improve OPAC course reserves pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10566 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co ||m --- Comment #1 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Created attachment 19690 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19690action=edit Bug 10588 - opac-topissues first branch always selected in filters See test plan in commit message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9928] no way to see all purchase suggestions at all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9928 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10588 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9928 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #2 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- Code inspired by Bug 9928 which introduced the code __ANY__. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10595] New: OpacTopissue page still accessible when system preference is turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Bug ID: 10595 Summary: OpacTopissue page still accessible when system preference is turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The page for most popular titles should not be accessible when the feature is turned off in the system preferences (OpacTopissues). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- I don't think that is possible, at least not to my knowledge. What you are asking for is for one website ( the intranet ) to know the internal settings of another website ( the opac ). The only thing I can think of is to add an callable ajax function for the opac and intranet that can be passed each system preference and return true if it is overridden and false otherwise. We'd need to add a section to koha to list all the opacs and intranets in the system, and then for each system preference iterate though the list of opacs and intranets and check each one to see if the system preference is overridden. If it is, then we display some kind of not by the preference with the opac's url and new preference value. This seems terribly and overly complicated just to see which system preferences are overridden. Is there a simpler way I am not seeing? (In reply to M. de Rooy from comment #11) Kyle: Reading the comments now, we seem to reach consensus that this patch just needs an additional change in the pref editor to make visible that the pref is overridden. Changing status to reflect that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl --- This seems terribly and overly complicated just to see which system preferences are overridden. Is there a simpler way I am not seeing? When initializing the form, you could check %ENV for all OVERRIDE_SYSPREF keys and mark what you find in a special way? Would that be simpler? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl --- Too fast: yes too simple. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10524] Dependency updates to account for liblibrary-callnumber-lc-perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10524 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Puched to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10590] in opac-topissues limit param is not protected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10590 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #23 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #16 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- (In reply to M. de Rooy from comment #13) This seems terribly and overly complicated just to see which system preferences are overridden. Is there a simpler way I am not seeing? When initializing the form, you could check %ENV for all OVERRIDE_SYSPREF keys and mark what you find in a special way? Would that be simpler? Yes, the would unfortunately only work for staff intranet the preference editor is being used on. Since we have a minimum of two virtual hosts per koha installation ( one opac, one staff ) it won't work. I'm wondering if maybe a simpler/better solution would be to add a parameter to koha-conf.xml to control if this feature is enabled or not, and if it is enabled, display a nice big warning at the top of the system preferences edit along the lines of Warning: You have the system preferences override feature enabled, please check your apache configuration files before assuming a change in a system preference will affect your installation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10495] t/db_dependent/HoldsQueue.t can fail unnecessarily
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10495 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
1/ On tools/manage-marc-import.pl, I got a JS error:
aoData.push( { name: import_batch_id, value: } );
The table should not be displayed if there is no import_batch_id parameter.
2/ I got another JS error clicking on the title
SyntaxError: syntax error: void()
Prefer a href=#
3/ The DT aLengthMenu parameter should contain an All entry (git grep
aLengthMenu.*All)
4/ Why do you comment lines in tools/manage-marc-import.pl instead of deleting
them?
5/ Why do you add a show_marc JS function instead of using the classic way
(link to showmarc.pl)?
6/ Permissions: manage-marc-import.pl needs the tools=manage_staged_marc
permission and the ajax script needs editcatalogue. Don't you think we should
have the same one in both?
Marked as Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #20 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 --- Comment #1 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 19691 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19691action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Initial commit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19692 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19692action=edit Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax DataTable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558
--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
1/ On tools/manage-marc-import.pl, I got a JS error:
aoData.push( { name: import_batch_id, value: } );
The table should not be displayed if there is no import_batch_id parameter.
Fixed!
2/ I got another JS error clicking on the title
SyntaxError: syntax error: void()
Prefer a href=#
By bad, the call is supposed to be void(0). This appears to be the preferred
practice these days. The problem with href=# is that it causes the page to
jump back to the top when clicked. This isn't a problem when the page does not
scroll vertically, but in this case it often will.
3/ The DT aLengthMenu parameter should contain an All entry (git grep
aLengthMenu.*All)
Fixed!
4/ Why do you comment lines in tools/manage-marc-import.pl instead of
deleting them?
Fixed!
5/ Why do you add a show_marc JS function instead of using the classic way
(link to showmarc.pl)?
The classic way uses greybox, which isn't compatible with DataTables built
from an ajax source. On the plus side, I'm using jQuery UI instead, and if we
switched all of them to jQuery UI, we could drop greybox as a dependency.
6/ Permissions: manage-marc-import.pl needs the tools=manage_staged_marc
permission and the ajax script needs editcatalogue. Don't you think we
should have the same one in both?
Fixed!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7240] Cleaning up import tables and action_logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7240 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||dev_patc...@biblibre.com --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 6793 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6793] imported and cleaned basket should be regularly deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6793 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- I suspect it is a duplicate of bug 7240. I think the idea was to clean the import table. *** This bug has been marked as a duplicate of bug 7240 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #19 from Owen Leonard oleon...@myacpl.org --- (In reply to Kyle M Hall from comment #18) 5/ Why do you add a show_marc JS function instead of using the classic way (link to showmarc.pl)? The classic way uses greybox, which isn't compatible with DataTables built from an ajax source. On the plus side, I'm using jQuery UI instead, and if we switched all of them to jQuery UI, we could drop greybox as a dependency. ...which is something I would like to be able to do if we could (See Bug 8290). I find that in this case the jQueryUI dialog works well. In other cases I have found that it isn't as easy to implement as Greybox, hence the lack of progress on that bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558 --- Comment #20 from Owen Leonard oleon...@myacpl.org --- (In reply to Kyle M Hall from comment #18) My bad, the call is supposed to be void(0). This appears to be the preferred practice these days. The problem with href=# No, using javascript: is not the preferred practice. More frequently you'll see return false added to the onclick (at least in cases where return false is what you want). The ideal way to handle something like this is to design the inserted markup so that the click event can be moved into the main JavaScript block (even better, into a separate JavaScript file). Then the outcome of the click event can be handled by something like this: http://css-tricks.com/return-false-and-prevent-default/ This isn't an issue that should block QA, but is something to think about next time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558
--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #18)
1/ On tools/manage-marc-import.pl, I got a JS error:
aoData.push( { name: import_batch_id, value: } );
The table should not be displayed if there is no import_batch_id parameter.
Fixed!
Still got the JS error.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #11 from Galen Charlton gmcha...@gmail.com --- (In reply to kenza from comment #3) The patch 10386 doesn't add the rollback, so i think these two patches are complementary. As a general note, it is not necessary to explicitly call $dbh-rollback. When AutoCommit is off, DBD::mysql automatically issues a rollback when the script ends, and if the script gets killed, the transaction never gets committed either. That said, it doesn't hurt anything to have the explicit rollback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10499] UT: VirtualShelves.t needs a database transaction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10499 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Attachment #19691|0 |1 is obsolete|| --- Comment #2 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 19693 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19693action=edit Bug 10195 Records hidden with OpacSuppression can still be accessed Records hidden with OpacSuppression are filtered from the search results, but the opac-detail page is still visible if you know the biblio number. This patch hides the detail page for suppressed biblios by redirecting (controlled by the syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining that the record is blocked (including optional explanatory text from the syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a biblio with that number exists in the system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Does this depend on another patch? It doesn't apply on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10556] deliverytime is not inserted on adding a supplier
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10556 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton gmcha...@gmail.com --- Thanks, Jonathan! I've pushed the part of the patch that changed AddBookSeller to master, along with a follow-up that adds a regression test. However, I have not pushed the part that updates ModBookSeller on the following grounds: [1] That routine is not actually related to the bug. [2] The proposed change to that routine is purely cosmetic. Cosmetic and source reformatting patches really ought to be separate from ones that change functionality or fix bugs. [3] The proposed reformatting has issues -- in particular, I simply do not see the point of the changes proposed to lines 240-254. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #16 from Galen Charlton gmcha...@gmail.com --- My proposal, as I agree that it's impossible for one vhost to be 100% sure about the configuration of another one: - only check the environment passed to the staff interface virtual host to determine if a syspref is overridden - add a (commented-out) example to koha-httpd.conf that alerts the the sysadmin that they probably want to override any syspref in an OPAC vhost in the staff interface vhost as well. Since overriding sysprefs via the Apache configuration would be an advanced feature, having a couple rough edges is not a showstopper IMO as long as we document them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19556|0 |1 is obsolete|| --- Comment #10 from Owen Leonard oleon...@myacpl.org --- Created attachment 19694 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19694action=edit [SIGNED-OFF] Bug 10481: FIX No enrollment fee when changing patron category. When a patron changes to a category with enrollment fee, they are not generated. Test plan: - Choose a category without fee (e.g. Kid) - Add an enrollment fee for another category (e.g. Young adult) - Choose a kid and change his category to Young adult. - Note the warning message Fees Charges: Patron has Outstanding fees charges of XX on the check out page. Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6254] can't set patron privacy by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #11 from Galen Charlton gmcha...@gmail.com --- There are two separate requests in this bug to have the default be per-patron category. Kyle, are you amenable to redoing the patch to have the default privacy value be an attribute of patron category? Consider this part of my sometimes a global YASP is not the right level of configurability hobbyhorse. Setting to in discussion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6254] can't set patron privacy by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 --- Comment #12 from Galen Charlton gmcha...@gmail.com --- (In reply to Katrin Fischer from comment #10) Functionality wise this works and passes QA, but I am not so happy about the system preference description: NewPatronPrivacySetting: New patrons should have a privacy setting of default|never|forever I don't thinks this explains what this setting will do to a librarian trying to configure Koha and without deeper knowledge about the features and terminology. Also Privacy is a pretty broad term and this only affects how long we keep the reading history. I share Katrin's concerns about the description and feel that it could be expanded a bit. If we end up running with a syspref (but see my previous comment), I also think that DefaultPatronPrivacySetting would be a better name. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Adrien! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10402] Add multiple contacts for vendors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard oleon...@myacpl.org --- Auto-merging C4/Bookseller.pm CONFLICT (content): Merge conflict in C4/Bookseller.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10573] French translation for printing a basketgroup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10573 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Shouldn't pdfformat::layout3pagesfr be added as a choice to the pref file? For that matter, shouldn't pdfformat::layout2pages and pdfformat::layout3pages also be built into the pref file for selection, or do I misunderstand how this preference works? Is there a reason why pdfformat isn't selectable at the time of printing? Why should it be a global preference? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19529|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 19695 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19695action=edit [SIGNED-OFF] Bug 10563: Fix broken 'Edit' link on check expiration page This fixes the broken 'Edit' (subscription) link on the check expiration page in serials. To test: - Add a subscription - Go to the check expiration page - Search for your subscription, use an expiration date in the far future - Verify the edit link on the result list doesn't work right before applying the patch, but works after Signed-off-by: Owen Leonard oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10596] New: make expiration date an option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10596 Bug ID: 10596 Summary: make expiration date an option Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Right now on patron records you need an expiration date but not all libraries use that type of function and the expiration date actually gets in their way. It would be nice if you could choose if your library cares about expiration dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] New: Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Bug ID: 10597 Summary: Search to hold button broken on record details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The holds button in cat-toolbar is broken for search to hold. It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19696 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19696action=edit Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for search to hold. It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the Place hold button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4907] Suggestions organize by menu doesn't reflect current choice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4907 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Katrin! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #46 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Bernardo and Marcel! Note: I added an entry in updatedatabase.pl for 3.12.x, that tells the user about this, just in case they want to apply it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9519] Wrong language code for Italian in the advanced search language limitations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9519 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Sonia! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #21 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- First patch pushed to 3.10.x, will be in 3.10.8 Second does not apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195
Mirko Tietgen mi...@abunchofthings.net changed:
What|Removed |Added
Attachment #19693|0 |1
is obsolete||
--- Comment #3 from Mirko Tietgen mi...@abunchofthings.net ---
Created attachment 19697
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19697action=edit
Bug 10195 Records hidden with OpacSuppression can still be accessed
Records hidden with OpacSuppression are filtered from the search results, but
the opac-detail page is still visible if you know the biblio number. This patch
hides the detail page for suppressed biblios by redirecting (controlled by the
syspref OpacSuppressionRedirect) either to opac-blocked (default), explaining
that the record is blocked (including optional explanatory text from the
syspref OpacSuppressionMessage) or to Koha's 404 page, giving no hint that a
biblio with that number exists in the system.
Test plan:
Make sure you have at least one record with 942$n == 1.
Set OpacSuppression to Don't hide.
Do an OPAC search that should bring up your hidden record and other records.
Observe that your record is found.
Open the detail page for the record.
Observe that it is accessible. Copy the URL for later(!).
Set OpacSuppression to Hide.
Leave OpacSuppressionByIPRange blank.
Set OpacSuppressionRedirect to an explanatory page ('This record is
blocked').
Leave OpacSuppressionMessage blank for now.
Disable queryparser(!) (because of bug 10542).
Do a full zebra reindex.
Do an OPAC search that should bring up your hidden record and other records.
Observe that your record is not found.
Open the opac-detail URL of the record (the one you copied before).
Observe that you are redirected to opac-blocked and it displays a short
standard message.
Edit OpacSuppressionMessage and input some text.
Open the opac-detail URL of the record again (the one you copied before).
Observe that the text you entered in OpacSuppressionMessage is displayed
under the standard text you have seen before.
Set OpacSuppressionRedirect to the 404 error page ('Not found').
Open the opac-detail URL of the record again (the one you copied before).
Observe that you are redirected to Koha's 404 error page.
Sign off the patch. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10496] CCSR theme OPAC tabs to not show correct active state
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10496 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10490] Overdue fines cap (amount) in circulation rules is saved incorrectly (rounded)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10490 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10535] by default sort funds by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- The first patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10560] No way to disable english
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10560 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Robin! Note: i think the webinstaller didn't get fixed. After I push the latest patches to 3.12.x i'll try to re-test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10548] koha_perl_deps.pl miscounts dependencies displayed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 --- Comment #1 from Mirko Tietgen mi...@abunchofthings.net --- Created attachment 19698 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19698action=edit Bug 10595 - OpacTopissue page still accessible when system preference is turned off When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to opac-topissues.pl next to Advanced search etc. Follow that link, observe that opac-topissues.pl is loading Disable OpacTopissue Observe the link is gone Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled Apply patch (OpacTopissue still diabled) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|NEW |Needs Signoff CC||mi...@abunchofthings.net Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10529] Dollar sign hardcoded in patron message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Pushed to Master|Pushed to Stable --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10475] Item form in acquisition not hiding subfields properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10475 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10507] Typo when warning about creating duplicate patron attribute
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10507 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10447] Language definitions for 'ru' and 'uk' are not available during install
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10447 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10598] New: self check shouldn't link out to catalog
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598 Bug ID: 10598 Summary: self check shouldn't link out to catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org When you use self check the titles you check out are linked to the opac, the problem here is that most libraries set their self check machines to not allow visiting pages outside of the self check. If you click a title and get in to the opac then you might not be able to get back to the self check if those safeguards are in place. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481 --- Comment #11 from Srdjan Jankovic srd...@catalyst.net.nz --- The patch for bug 10337 creates a DB with all sample data. Sorry, did not know of that. It is in discussion, what is the instruction for using it atm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528 --- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz --- Yes. 10556 should not be applied any more I guess, it has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19499|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19699 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19699action=edit [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused branch parameter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10508] UT: C4::Branch.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10508 --- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz --- Same result (same 2 failed tests). Do you think I should try on an empty database, or you'd rather make it work on any database. I can see merits in the latter, but if there's consensus that tests should run against some initial data, I'm fine with that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19544|0 |1 is obsolete|| --- Comment #19 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19700 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19700action=edit [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2394] canreservefromotherbranches preference not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2394 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19545|0 |1 is obsolete|| --- Comment #20 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19701 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19701action=edit [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10597] Search to hold button broken on record details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19696|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 19702 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19702action=edit [SIGNED-OFF] Bug 10597 - Search to hold button broken on record details The holds button in cat-toolbar is broken for search to hold. It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click 'search to hold' 3) Search for something 4) On the results page, click a result line's title link ( catalogue/detail.pl ) 5) Note the Place hold button is a split button, click the left half of the button, note it redirects you to the editor. 6) Apply this patch 7) Repeat steps 1-5 Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns' syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554 Bob Birchall b...@calyx.net.au changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10358 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Bob Birchall b...@calyx.net.au changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10554 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
