[Koha-bugs] [Bug 10576] Untranslatable strings in additem.js

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19796|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 19818
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19818&action=edit
Bug 10576 - Untranslatable strings in additem.js

There are a couple of untranslatable strings in additem.js. This patch
moves the strings out of the script and into the include file which has
been created for this purpose.

To test, apply the patch and test the process for adding an item to an
existing or new basket (with AcqCreateItem set to "when placing an
order."

The add item form should be correctly labeled "Add item." After adding
an item, click to edit it again. The form should now be labeled "Update
item."

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10576] Untranslatable strings in additem.js

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10604] two columns in the courses table aren't wide enough

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10604

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19729|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 19817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19817&action=edit
Bug 10604: increase width of two columns in the courses table

The department and term columns in the courses table started
as varchar(20), but since they refer to authorized values, need
to be varchar(80) to match authorised_values.authorised_value.  This
patch increases the width of those columns.

To test:

[1] Create two DEPARTMENT authorised values, one whose code
is shorter than 20 characters and one whose code is longer
than 20 characters.
[2] Create two courses; give one course the short department and
the other the long department.
[3] Go to the courses list.  Observe that the department column is
displays the department name only for the short course.
[4] Apply the patch.
[5] Edit the course with the long department and assign that long
department to it again.
[6] Go back to the courses list.  Observe that both of the courses
now display their assigned department.

Signed-off-by: Galen Charlton 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592

Chris Cormack  changed:

   What|Removed |Added

  Attachment #19676|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 19815
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19815&action=edit
bug 10592: fix MARC21 006/008 cataloging plugins

Move the XML and XSD data files so that access to them
(particularly the XML files) is not blocked by the Apache
configuration change introduced by the patch for bug 9812.

To test, after applying the patch.

[1] Open a MARC21 bibliographic record in the cataloging editor.
[2] Click on the plugin link for the 008 field.  Verify that
that the form for all of the fixed field positions is displayed,
and verify that you can change the type of material.
[3] Repeat step 2 for the 006 field.
[4] Verify that there are no entries in the Apache error log that contain

client denied by server configuration:
{...}/cataloguing/value_builder/marc21_field_008.xml

or

client denied by server configuration:
{...}/cataloguing/value_builder/marc21_field_006.xml

Signed-off-by: Galen Charlton 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10592] Apache configuration is blocking fetch of certain icons and XML files

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10592

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10617] Init script cleanup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 19811
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19811&action=edit
Bug 10617 - koha-common tnit script cleanup

Removed unused stuff, added a new config file /etc/default/koha-common
to control the init script behaviour. Currently is only a stub. The config
file could be put on /etc/sysconfig on RedHat and friends. The init script
should work them too.

To test:
- Apply the patch on master, build your own packages and install.
- The init script should continue to work as expected.
(it can be tested replacing the /etc/init.d/koha-common file with
debian/koha-common.init on a packages install).
- The absence of the /etc/default/koha-common file should not prevent
the init script from working.

Regards
To+

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10617] Init script cleanup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969

Liz Rea  changed:

   What|Removed |Added

  Attachment #19795|0   |1
is obsolete||

--- Comment #4 from Liz Rea  ---
Created attachment 19814
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19814&action=edit
Bug 2969 - Report Name should be mandatory for saved reports

This patch re-implements the database changes from the original patch
and adds an update for existing reports. It also reimplements the
client-side validation using the new built-in validation plugin and adds
coverage for SQL reports.

I have also added the "required" attribute to the SQL report textarea
since saving a report with no SQL triggers an error.

To test:

- Create a new guided report. Confirm that you cannot save your guided
  report without a report name.
- Create or edit a saved SQL report. Confirm that you cannot save your
  report without a name or without SQL.
- Confirm that the saved_sql table structure has been updated.

Signed-off-by: Liz Rea 
Functional tests pass, database tables look correct to me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615

--- Comment #3 from Liz Rea  ---
Probably towards the end of the table where the links used to be, would be my
preference I think. I found it a bit disorienting to find them the first time I
used it, I can imagine a lot of librarians would find it to be so too.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10617] New: Init script cleanup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10617

Bug ID: 10617
   Summary: Init script cleanup
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

The debian/koha-common.init file needs some cleanup.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||l...@catalyst.net.nz

--- Comment #2 from Liz Rea  ---
Hi Owen,

I like where your head is at here, but I think the actions might be a bit too
hidden for my taste.

A compromise might be a column with the dropdown in it, with table header
"actions?"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #68 from Katrin Fischer  ---
Hi Kyle - there are some conflicts, can you please rebase and answer Jonathan's
question?

I wonder if we should offer an option to show only the items of one selected
branch in the list of items? But couldn't take a look at how this effects the
display of items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586

Liz Rea  changed:

   What|Removed |Added

  Attachment #19802|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 19813
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19813&action=edit
Bug 10586 - Printing cart from Firefox seems to be missing CSS

When printing the Cart from Firefox the styling is off even though it
looks correct in preview. I think this may be because the preview is
including stylesheets designated for screen.

This patch removes special handling of JS and CSS assets for the Cart's
print view, letting the page handle print styling like other pages in
the OPAC.

To test, put items in your Cart in the OPAC. Open your Cart and click
the "print" link. Your printout should be correctly styled and match the
preview.

Signed-off-by: Liz Rea 
Tested both fail condition and condition with patch - display is much improved.
Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516

Liz Rea  changed:

   What|Removed |Added

  Attachment #19807|0   |1
is obsolete||

--- Comment #2 from Liz Rea  ---
Created attachment 19812
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19812&action=edit
Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50
server adds and updates

The template for adding/editing Z39.50 servers shows the same title,
breadcrumbs, etc. for add and edit operations. This patch creates
separate text for each case.

To test, try both adding and editing a Z39.50 server. The page title,
breadcrumb, and heading should correctly reflect the operation you
perform.

Signed-off-by: Liz Rea 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10616] hold warning needs design work

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #1 from Liz Rea  ---
How do you think this should work instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19603|0   |1
is obsolete||

--- Comment #13 from Jared Camins-Esakov  ---
Created attachment 19809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19809&action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19604|0   |1
is obsolete||

--- Comment #14 from Jared Camins-Esakov  ---
Created attachment 19810
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19810&action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
> prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

  Attachment #19233|0   |1
is obsolete||

--- Comment #12 from Jared Camins-Esakov  ---
Created attachment 19808
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19808&action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
> prove t/db_dependent/Bookseller.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516

--- Comment #1 from Owen Leonard  ---
Created attachment 19807
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19807&action=edit
Bug 10516 - Improve titles, breadcrumbs, and confirmation messages for Z39.50
server adds and updates

The template for adding/editing Z39.50 servers shows the same title,
breadcrumbs, etc. for add and edit operations. This patch creates
separate text for each case.

To test, try both adding and editing a Z39.50 server. The page title,
breadcrumb, and heading should correctly reflect the operation you
perform.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

--- Comment #1 from Owen Leonard  ---
Created attachment 19803
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19803&action=edit
Bug 10609 - Use branch name rather than branch code in serials-collection.pl

The serials collection page displays branchcode instead of library name.
This patch uses the Branches template plugin to display the library name
instead.

Also corrected: Added missing datatables config include to prevent a
JavaScript error.

To test, view the serials collection page for a subsciption with
existing issues. Library names should be displayed instead of
branchcodes. There should be no JavaScript errors reported by the
browser.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10609] Use branch name rather than branch code in serials-collection.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10516] Improve titles, breadcrumbs, and confirmation messages for Z39.50 server adds and updates

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10516

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3134] Ability to selelct multiple reports to delete at once

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134

--- Comment #7 from Owen Leonard  ---
Created attachment 19806
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19806&action=edit
Bug 3134 - Ability to selelct multiple reports to delete at once

This patch adds the option to select multiple saved reports for
deletion.

To test you must have two or more saved reports to delete. Deletion
should work properly when:

- Selecting one report for deletion by checking the box.
- Selecting more than one report for deletion by checking boxes.
- Clicking the old "Delete" link

Clicking the delete button should prompt you to confirm. Clicking cancel
should cancel.

Clicking the delete button when no boxes are checked should trigger an
alert asking you to select reports for deletion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #19800|0   |1
is obsolete||

--- Comment #35 from Tomás Cohen Arazi  ---
Created attachment 19805
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19805&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables[1].

Also provide command line tools to manage the running indexer daemons
for your instances.

Edit: fixed koha-create to call the koha-indexer script instead, and added
-q to make koha-inxeder quiet (useful for the init script).
Added references to /etc/default/koha-common at koha-create to test for
the indexer daemon configuration.

Regards
To+

[1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html
[2] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519
[3] The default cronjob that is set using the debian/koha-common.cron.d file
is being disbaled by this patch to avoid collision.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694

Owen Leonard  changed:

   What|Removed |Added

  Attachment #11871|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694

Owen Leonard  changed:

   What|Removed |Added

  Attachment #11907|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10616] New: hold warning needs design work

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10616

Bug ID: 10616
   Summary: hold warning needs design work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 19804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19804&action=edit
holds warning

The attached image is confusing.  The radio buttons only apply if you click the
'yes' button. But if you click the 'no' button the radio buttons are ignored. 
The functionality is good! But it's confusing to the user because it makes it
look like the radio buttons apply no matter what button you choose and both
buttons end up messing with the hold so users don't want to choose anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586

--- Comment #1 from Owen Leonard  ---
Created attachment 19802
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19802&action=edit
Bug 10586 - Printing cart from Firefox seems to be missing CSS

When printing the Cart from Firefox the styling is off even though it
looks correct in preview. I think this may be because the preview is
including stylesheets designated for screen.

This patch removes special handling of JS and CSS assets for the Cart's
print view, letting the page handle print styling like other pages in
the OPAC.

To test, put items in your Cart in the OPAC. Open your Cart and click
the "print" link. Your printout should be correctly styled and match the
preview.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10586] Printing cart from Firefox seems to be missing CSS

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10615] New: Move saved reports action items into dropdown menu

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615

Bug ID: 10615
   Summary: Move saved reports action items into dropdown menu
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/reports/guided_reports.pl?phase=Use
saved
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 19799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19799&action=edit
Proposed menu on saved reports page

The table of saved reports has five or six "actions" which can be performed on
each report. These links are jammed together in two columns at the right of the
table, often forcing the user to scroll to reach the links.

I propose to move all these links into a dropdown menu triggered by clicking on
the report name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10615] Move saved reports action items into dropdown menu

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10615

--- Comment #1 from Owen Leonard  ---
Created attachment 19801
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19801&action=edit
Bug 10615 - Move saved reports action items into dropdown menu

This patch moves saved reports "action" links (view, edit, run, etc)
into a dropdown menu triggered by clicking the name of the report.

To test you must have saved reports. View the saved reports page and
click the name of a saved report. This should trigger a menu. All
options in the menu should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10614] New: have add order form at top and bottom

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614

Bug ID: 10614
   Summary: have add order form at top and bottom
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

When in a basket and you're ordering if you have a lot of items you have to
scroll to the bottom each time to add more - it would be nice if there were an
add option at the top of your list of titles as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #19798|0   |1
is obsolete||

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 19800
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19800&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables[1].

Also provide command line tools to manage the running indexer daemons
for your instances.

Long:

Using an indexing daemon avoids launching a new interpreter each time
the cron triggers the indexing, and also allows sub-minute incremental
reindexing, a requirement from our librarians.[2]

Using the indexer daemon should remain "experimental" so is disabled by
default. To enable the use of the indexer the user has to tweak the
/etc/default/koha-common config file (introduced by this patch). Specifically
the USE_INDEXER_DAEMON variable, which is clearly explained in the file.

Update frecquency defaults to 30 sec, and can be changed by tweaking the
/etc/default/koha-common config file too.

This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3],
but could be easily adjusted to use another if we got a new one (SolR?).
As Robin proposed it checks for availability of the relevant files before
trying to spawn the daemon.

If there's something I could change to make this patches better just let me
know.

Note: there was a problem Robin found regarding the spawned processes
forgetting
the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version
with the inclusion of the 'export' keyword for the relevant variables.

Edit: fixed koha-create to call the koha-indexer script instead, and added
-q to make koha-inxeder quiet (useful for the init script).

Regards
To+

[1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html
[2] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519
[3] The default cronjob that is set using the debian/koha-common.cron.d file
is being disbaled by this patch to avoid collision.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #19794|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 19798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19798&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables.

Also provide command line tools to manage the running indexer daemons
for your instances.

Edit: fixed koha-create to call the koha-indexer script instead, and added
-q to make koha-inxeder quiet (useful for the init script).

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

--- Comment #22 from Srdjan Jankovic  ---
Oh what a mess... Terribly sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #19787|0   |1
is obsolete||

--- Comment #21 from Srdjan Jankovic  ---
Created attachment 19797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19797&action=edit
[SIGNED-OFF] Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded

prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t
t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t .. ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.38 cusr
0.01 csys =  0.41 CPU)
Result: PASS

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10576] Untranslatable strings in additem.js

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10576] Untranslatable strings in additem.js

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10576

--- Comment #1 from Owen Leonard  ---
Created attachment 19796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19796&action=edit
Bug 10576 - Untranslatable strings in additem.js

There are a couple of untranslatable strings in additem.js. This patch
moves the strings out of the script and into the include file which has
been created for this purpose.

To test, apply the patch and test the process for adding an item to an
existing or new basket (with AcqCreateItem set to "when placing an
order."

The add item form should be correctly labeled "Add item." After adding
an item, click to edit it again. The form should now be labeled "Update
item."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2969] Report Name should be mandatory for saved reports

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969

Owen Leonard  changed:

   What|Removed |Added

   Attachment #2366|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 19795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19795&action=edit
Bug 2969 - Report Name should be mandatory for saved reports

This patch re-implements the database changes from the original patch
and adds an update for existing reports. It also reimplements the
client-side validation using the new built-in validation plugin and adds
coverage for SQL reports.

I have also added the "required" attribute to the SQL report textarea
since saving a report with no SQL triggers an error.

To test:

- Create a new guided report. Confirm that you cannot save your guided
  report without a report name.
- Create or edit a saved SQL report. Confirm that you cannot save your
  report without a name or without SQL.
- Confirm that the saved_sql table structure has been updated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

--- Comment #32 from Tomás Cohen Arazi  ---
Now we're going live with 3.12 deb packages at UNC, I found a few glitches on
the scripts, fixed them. Also unified the scripts into one with action switches
after an IRC poll. Thanks Galen and Mark :-D

If anyone is willing to give this patches a ride, feel free to contact me.
Also, I've set a repository for 3.12 with this patches applied for our internal
usage, but it is public, and everything is explained here
http://blogs.unc.edu.ar/koha/lang/es/2013/07/18/llega-koha-3-12-a-la-unc-nuestro-propio-repositorio-deb-tambienkoha-3-12-arrives-to-unc-our-own-deb-repo-too/

Thanks for any input on this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #18258|0   |1
is obsolete||

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 19794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19794&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables[1].

Also provide command line tools to manage the running indexer daemons
for your instances.

Long:

Using an indexing daemon avoids launching a new interpreter each time
the cron triggers the indexing, and also allows sub-minute incremental
reindexing, a requirement from our librarians.[2]

Using the indexer daemon should remain "experimental" so is disabled by
default. To enable the use of the indexer the user has to tweak the
/etc/default/koha-common config file (introduced by this patch). Specifically
the USE_INDEXER_DAEMON variable, which is clearly explained in the file.

Update frecquency defaults to 30 sec, and can be changed by tweaking the
/etc/default/koha-common config file too.

This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3],
but could be easily adjusted to use another if we got a new one (SolR?).
As Robin proposed it checks for availability of the relevant files before
trying to spawn the daemon.

If there's something I could change to make this patches better just let me
know.

Note: there was a problem Robin found regarding the spawned processes
forgetting
the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version
with the inclusion of the 'export' keyword for the relevant variables.

Regards
To+

[1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html
[2] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519
[3] The default cronjob that is set using the debian/koha-common.cron.d file
is being disbaled by this patch to avoid collision.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821

--- Comment #4 from Owen Leonard  ---
Created attachment 19793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19793&action=edit
Bug 8821 - Receive shipment page should hide inactive funds like new order form

This patch adapts the fund-handling code from neworderempty.pl
in order to limit the display of funds by default to active ones,
with the option to check a box to display all funds.

This patch also adds "(inactive)" to the display of funds on this and
the neworderempty.tt template because it seemed like that was useful
information.

To test, make sure you have both active and inactive funds.
Start the process of receiving a shipment. The "fund" option
in the receive shipment form should show only active funds.
Checking the "show all" checkbox should allow you to choose
from both active and inactive funds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #9 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #3 from Jonathan Druart  ---
QA comment:

removeAttr takes only 1 parameter.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

--- Comment #24 from Fridolyn SOMERS  ---
(In reply to Srdjan Jankovic from comment #23)
> opendir RECDIR, $recursive_dir
> 
> is much better written as
> 
> opendir my $recdir, $recursive_dir
> 
Ok, I thought is was not possible. Ok to use vars with those names.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410

--- Comment #10 from Jonathan Druart  ---
I think template plugin is much more appropriate in this case. What do you
think about this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19792|Bug 9410: Draft: TT Plugin  |[ALT] Bug 9410: Draft: TT
description|for formatting prices, etc. |Plugin for formatting
   ||prices, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410

--- Comment #9 from Jonathan Druart  ---
Created attachment 19792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19792&action=edit
Bug 9410: Draft: TT Plugin for formatting prices, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #18022|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart  ---
Created attachment 19790
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19790&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA
Followup

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19672|0   |1
is obsolete||

--- Comment #44 from Jonathan Druart  ---
Created attachment 19791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19791&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA
Followup 2

Adds the note "GST exc." for subtotals by fund.

Signed-off-by: Pierre Angot 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #18021|0   |1
is obsolete||

--- Comment #42 from Jonathan Druart  ---
Created attachment 19789
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19789&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

Signed-off-by: Pierre Angot 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|paul.poul...@biblibre.com   |jonathan.dru...@biblibre.co
   ||m

--- Comment #41 from Jonathan Druart  ---
QA comment:

Looks good to me.

minor:
- a css class named font-weight-normal is not well chosen.
- unit test inserts manually an order instead of calling C4::Acq::AddOrder

Inconsistent things still exist on this page but this patch does not introduce
regression neither add another inconsistency.

I validated this patch with Sonia (from the Koha Team Lyon 3), thanks to her!

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #1 from Jonathan Druart  ---
Created attachment 19788
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19788&action=edit
Bug 10613: The gst rate is not correctly calculated on the invoice page.

Test plan:
Defined a gst rate on creating an order, receive it and check that all
prices are correctly calculated.
/!\ Behavior change function of supplier parameters (Include/Don't
include tax for list prices and invoice prices)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5335] define VAT/taxes at orderline level, with default value for supplier and list of valid tax rates

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10613

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5339] Parcel closing in acq

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10613

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5335,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=5339
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] New: Gst is not calculated correctly on the invoice page

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Bug ID: 10613
   Summary: Gst is not calculated correctly on the invoice page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

The gst used is the gst defined at the supplier level. We should use the gst
defined at the order level (if exists).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965

--- Comment #3 from Katrin Fischer  ---
There is another bug about the inconsistency of display for discount rates and
tax rates - probably a bigger project: bug 10253, bug 9410

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8286] Enhancing tax and shipping calculation

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8286

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED

--- Comment #1 from Katrin Fischer  ---
Ther is an option now to add a shipping fee on the order receive page and taxes
can be modified on order line level. I am closing this bug as we seem to have
implemented what is asked for here. If you are still missing functionality,
please open a new bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2865] Acquisitions: GST not calculating correctly.

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2865

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #8 from Jonathan Druart  ---
This issue is certainly fixed by bug 5335.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7495] Tax calculations problem for new orders.

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495

--- Comment #4 from Jonathan Druart  ---
Frédérick, could you check if the issue still exists on master please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Jonathan Druart  ---
On the current master, I get:

Discount: 0.0 %
Tax rate: 5.0 %

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

--- Comment #20 from Jonathan Druart  ---
Srdjan, Thanks for signing off this patch! But you did not sent the good one :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #19557|0   |1
is obsolete||

--- Comment #19 from Srdjan Jankovic  ---
Created attachment 19787
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19787&action=edit
[SIGNED-OFF] Bug 10337: Unit tests is based on an existing database

This patchs adds a new unit tests file which will launched before all
others db_dependent tests.
It will drop and recreate the database with sample data.

Prerequisite:
The database 'koha_ut' have to be created with
  CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #23 from Srdjan Jankovic  ---
opendir RECDIR, $recursive_dir

is much better written as

opendir my $recdir, $recursive_dir

That way no close is needed, it closes itself when goes out of scope (globs are
passe :)

If you choose to stick with globs, I'll sign it off as is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

--- Comment #8 from Jonathan Druart  ---
Created attachment 19786
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19786&action=edit
Bug 7598 [Follow-up] Acquisitions JavaScript contains untranslatable English
strings

This follow-up addresses QA comments and moves punctuation and line
breaks out of the string to be translated.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Jonathan Druart  ---
second patch does not need a signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #19686|0   |1
is obsolete||
  Attachment #19772|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 19785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19785&action=edit
Bug 7598 - Acquisitions JavaScript contains untranslatable English strings

English strings in acq.js cannot be processed by the translation script.
This patch moves the strings to the templates to be set as JS variables
for use by the script.

To test:

- On the uncertain prices page, enter an invalid price and click save.
  You should see a JavaScript alert pointing this out.

- When adding a fund to an existing budget, enter an amount which
  exceeds the amount in the parent budget. You should see a JavaScript
  alert pointing this out. There is a similar function which has been
  corrected, checkBudgetParent(), but I don't know how to trigger it for
  testing.

The closebasketgroup function has been updated but as far as I can tell
it's not actually in use.

Signed-off-by: Srdjan 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #5 from Jonathan Druart  ---
QA comment:

Works as expected, all strings are in the po file.
It is a pity not to have js file translatable.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10481] No enrollment fee when changing patron category

2013-07-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

--- Comment #18 from Jonathan Druart  ---
The branchcode "CPL" does not exist in your DB (added by
installer/data/mysql/en/optional/sample_libraries.sql).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/