[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10588] opac-topissues first branch always selected in filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588 --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20103 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20103action=edit [SIGNED-OFF] Bug 10588 - opac-topissues first branch always selected in filters In OPAC most popular items page: With user is logged-in his branch should be selected. When a branch is manually selected and form is submitted, this branch should be selected in results page. When looking at HTML, you see that all options are selected in combobox. This patch corrects by using the hidden input 'do_it' to distinguish form display and no branch filter selected. Test plan : - Make sure there are issues on records created in the past 3 month - Go to OPAC not logged-in - Click on Most popular = You get to page with results, All libraries is selected - Select a branch and submit = You get to page with results, the branch is selected [testing opac-topissues.inc from] - Select a branch and perform a search that does not have results (for example an item type never issued) = You get to page without results, the branch is selected [testing opac-topissues.tt form] - Log-in with a user - Click on Most popular = You get to page with results, user's branch is selected - Select All libraries and submit = You get to page with results, All libraries is selected [testing opac-topissues.inc from] - Select All libraries and perform a search that does not have results (for example an item type never issued) = You get to page without results, All libraries is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10078] show location facet for all
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19331|0 |1 is obsolete|| --- Comment #2 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20104 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20104action=edit [SIGNED-OFF] Bug 10078 - show location facet for all Currently, the location facet only shows if you have singlebranch mode enabled. In other words, you can either see the library branch or the shelving location. This patch simply changes the location facet so that it will always show the shelving location (if one is available), regardless of the singlebranch system preference. Test Plan: BEFORE APPLYING: 0) Disable singlebranch mode if it is on 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you can see the library branch facet under Libraries but no shelving locations. 3) Enable singlebranch mode 4) Repeat your search 5) Note that you can no longer see the library branch facet under Libraries. However, you can see the shelving location under Location N.B. If you don't have more than one branch or the search results are all from one branch, you might not get a library branch facet. If this is the case, create additional branches and/or change the branch for items in your search results so that you have multiple branches to prompt the appearance of a library branch facet. AFTER APPLYING 1) Do an OPAC or Staff Client search for a record that has items with shelving locations. 2) Note that you see a facet under Location on the left sidebar, regardless of there being a singlebranch mode or the number of branches there are being represented in the search results. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 kenza kenza.z...@biblibre.com changed: What|Removed |Added Attachment #19948|0 |1 is obsolete|| --- Comment #4 from kenza kenza.z...@biblibre.com --- Created attachment 20105 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20105action=edit Bug 10643: Inappropriate uses of $sth-finish() in C4::ClassSource.pm This patch gets rid of finish() and replace prepare_cached by prepare. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 kenza kenza.z...@biblibre.com changed: What|Removed |Added Attachment #19986|0 |1 is obsolete|| --- Comment #5 from kenza kenza.z...@biblibre.com --- Created attachment 20106 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20106action=edit Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 csys = 1.13 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7013] required format is not enforced for authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Assignee|adrien.sau...@biblibre.com |christophe.croullebois@bibl ||ibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #6 from kenza kenza.z...@biblibre.com --- (In reply to kenza from comment #5) Created attachment 20106 [details] [review] Bug 10653: C4::RotatingCollections.pm needs unit tests The tests are wrap in a database transaction. Test plan: prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.04 usr 0.02 sys + 0.99 cusr 0.08 csys = 1.13 CPU) Result: PASS I add the deletion of 'categories' ,'branches' and 'branchcategories'. It should work but it still not: if i do : prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at t/db_dependent/RotatingCollections.t line 41. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at t/db_dependent/RotatingCollections.t line 41. # Looks like you planned 41 tests but ran 2. # Looks like your test exited with 255 just after 2. t/db_dependent/RotatingCollections.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 39/41 subtests Test Summary Report --- t/db_dependent/RotatingCollections.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 41 tests but ran 2. Files=1, Tests=2, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.34 cusr 0.02 csys = 0.38 CPU) Result: FAIL But if i do: sudo prove t/db_dependent/RotatingCollections.t t/db_dependent/RotatingCollections.t .. 1/41 attempting to use non-existent class sorting routine Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_class in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. Use of uninitialized value $cn_item in concatenation (.) or string at C4/ClassSortRoutine.pm line 118. t/db_dependent/RotatingCollections.t .. ok All tests successful. Files=1, Tests=41, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.37 cusr 0.00 csys = 0.39 CPU) Result: PASS I really don't understand ! So if someone has an idea which can help me... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7469] Focus on 1st field of creation form instead of search textbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7469 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m Assignee|adrien.sau...@biblibre.com |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m Assignee|adrien.sau...@biblibre.com |christophe.croullebois@bibl ||ibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7013] required format is not enforced for authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think in order to fix this properly we need to fix how MANUAL_INV works. It uses the code as description and the description for the amount. We could use the code as a real code and then the description as description... and the opac description for the amount. But it would still be bending something to do what it was not supposed to do in the first place. And do we still need to fix the security issue?? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10237] Enforce authorized value character limitations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** This bug has been marked as a duplicate of bug 7013 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7013] required format is not enforced for authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||oleon...@myacpl.org --- Comment #21 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** Bug 10237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7013] required format is not enforced for authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7013 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] New: Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 Bug ID: 10681 Summary: Inappropriate uses of finish() in C4::Circulation.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20107 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20107action=edit Bug 10681: Inappropriate uses of finish() in C4::Circulation.pm This patch gets rid of finish(). From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] New: Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 Bug ID: 10682 Summary: Inappropriate uses of finish() in C4::Reserve.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #31 from Paul Poulain paul.poul...@biblibre.com --- (In reply to Katrin Fischer from comment #30) Funcionaltiy wise this works well for me, so found nothing to not pass QA :) - I'd just like to get some more comments and eyes on this. Hi Katrin, you're asking for more eyes, but I don't see any mail to warn/ask on mailing lists, so I fear that your request will stay as is. Maybe sending a mail to koha@ mailing list (with some screenshots to present the feature, and/or link to sandboxes for ppl to test it) ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #32 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Sounds like a good idea :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added CC||kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20108 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20108action=edit Bug 10682 : Inappropriate uses of finish() in C4::Reserves This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10682] Inappropriate uses of finish() in C4::Reserve.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682 kenza kenza.z...@biblibre.com changed: What|Removed |Added CC||kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10683] New: CRUD routines in C4::Circulation need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 Bug ID: 10683 Summary: CRUD routines in C4::Circulation need unit tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org Unit tests for Add*, Get* and Del* routines in C4::Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza kenza.z...@biblibre.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10681 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10683 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10680] Modification log gives wrong data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #33 from Owen Leonard oleon...@myacpl.org --- I just tried this out with a copy of our production database of patrons (62,000+ records) and I don't get any results. When I first load the page it looks like the table is trying to process *all* patron records? The POST response has this: iTotalRecords: 62459, iTotalDisplayRecords: 62459, ...but they are never displayed. I don't get any results from clicking on the browse by last name alphabet links, and I don't get any results after performing a simple search by last name. In all cases I see the processing message on the screen but nothing is ever displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- (In reply to M. de Rooy from comment #1) Isn't it so that the variable is set to true as long as it is possible that this user might be able to delete at least some items of this list? Why would it be possible that I might be able to delete some items from a list which I didn't create and which wasn't created with permission for others to add items? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Two comments I made in IRC that I will copy here so they are not forgotten: - I would put browser.js in intranet-tmpl/js rather than intranet-tmpl/lib/koha. Generally speaking /lib/ is for 3rd-party libraries, /js/ is for scripts written for Koha. - There is commented-out code in results.tt, [% dumper.dump(SEARCH_RESULTS) %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] New: Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Bug ID: 10684 Summary: Koha search dies on undecodable records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 20109 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20109action=edit Bug 10684 - Koha search dies on undecodable records When a record fails to decode during a search, Koha dies with an error. Koha should ignore bad records and continue on ( and log the error ). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] New: Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 Bug ID: 10685 Summary: Inappropriate uses of finish() in C4::Accounts.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton gmcha...@gmail.com --- Pushed latest patches to master. Thanks, Nicole. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #20098|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #20097|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- None of these $sth-finish() patches have a test plan. I assume there's no way to detect an improvement, but how can we confirm that this change hasn't broken anything? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10685] Inappropriate uses of finish() in C4::Accounts.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20110 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20110action=edit Bug 10685: Inappropriate uses of finish in C4::Accounts.pm This patch gets rid of finish. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #4 from Owen Leonard oleon...@myacpl.org --- Could you look at this again Katrin? I'm not getting any errors from the QA script when I run it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Please add a test plan. How can one load/modify a record so as to reproduce the error and confirm the fix? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 --- Comment #6 from kenza kenza.z...@biblibre.com --- (In reply to Owen Leonard from comment #5) None of these $sth-finish() patches have a test plan. I assume there's no way to detect an improvement, but how can we confirm that this change hasn't broken anything? For this patch , the t/db_dependent/ClassSource.t exists. So we can be sure that nothing is broken by doing 'prove t/db_dependent/ClassSource.t' after applying this patch: t/db_dependent/ClassSource.t .. 1/24 attempting to use non-existent class sorting routine routine1 t/db_dependent/ClassSource.t .. ok All tests successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.06 cusr 0.01 csys = 0.09 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10652] Ajaxfileupload.js failing in IE9 for local image upload
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10652 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #19971|0 |1 is obsolete|| --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Created attachment 20111 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20111action=edit [SIGNED-OFF] Bug 10652 - Ajaxfileupload.js failing in IE9 for local image upload This patch adds a try/catch to the Javascript for adding the iframe element. The try will work for IE8 and older versions, while newer versions and other browsers will be covered by the check. Test Plan: 1) Try uploading a local cover image in IE9 2) Notice that your page is reloaded with no result (except the pop-up of a Javascript error, if you have error reporting on in your browser). 3) Apply the patch 4) Trying uploading a local cover image again 5) Notice that it uploads correctly 6) Repeat steps 4 and 5 for IE8, IE7, and/or other modern browsers. Signed-off-by: Owen Leonard oleon...@myacpl.org Tested in IE10 in IE10 browser mode and IE9 mode as well as in Firefox. Uploads work correctly with book cover images and in MARC uploads. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10430] status filter not working in serial claims when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430 Fridolyn SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #7 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- I set back to Need Signoff. The QA validation will say if using a class is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6030 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10679] Lists interface offers delete option when user doesn't have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10679 --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Owen Leonard from comment #2) Why would it be possible that I might be able to delete some items from a list which I didn't create and which wasn't created with permission for others to add items? Just thinking: Permissions can be changed at any time. So if I just disallowed adding items by others on my list, there could still be items added earlier on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- That is something I've yet to figure out. This is a fix I wrote for a production server where the database marc and marcxml are valid, but the marc sent by zebra is bad. I have no idea how to intentionally cause this issue. However, one can prove the patch is not deleterious simply by applying the patch and searching for records within Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6455] Warning message Patron card creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6455 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard oleon...@myacpl.org --- This doesn't appear to be a problem in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6382] Automatic Status Changing on Check In
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6382 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- This would be completely contrary to the way my library uses the notforloan status. I think you'd have to design a system which allowed you to create specific status workflows: If item with status A is checked in, move to status B, if item with status B is checked in, move to status C. I think that's the only way you could make it flexible enough that libraries who are used to Koha's existing workflow wouldn't object. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6567] adding and removing advanced search options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6567 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5920] remove html from downloaded reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5920
--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
You would probably have to fully re-build the SQL for output as CSV. If you
simply stripped out the concatenated text you would potentially be outputting
two or more fields crammed together in one column:
SELECT
biblionumber,
CONCAT('a
href=\/cgi-bin/koha/catalogue/detail.pl?biblionumber=',biblionumber,'\',title,'/a')
AS Title
| biblionumber | Title |
| 29839| 29839The stand|
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5678] Translations Manager
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5678 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Status|NEW |RESOLVED CC||z.taj...@cineca.it Resolution|--- |WONTFIX --- Comment #3 from Zeno Tajoli z.taj...@cineca.it --- After more than 2 years no one writes a line of code for a feature like this. I close the bug with a 'WontFix'. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #18990|0 |1 is obsolete|| --- Comment #15 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20113 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20113action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #18743|0 |1 is obsolete|| --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20112 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20112action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #19651|0 |1 is obsolete|| --- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20114 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20114action=edit Bug 10419: Add the branchcode parameter. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10419] There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #17 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20115 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20115action=edit Bug 10419 : Fixing license number -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5652] Patron checkout and holds summary should show subtitles
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5652 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #20042|0 |1 is obsolete|| --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 20116 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20116action=edit Bug 5652 - Patron checkout and holds summary should show subtitles This patch adds subtitles (from Keyword to MARC mapping) to following tables on the checkout page: - Checkouts - Previous checkouts - Relative's checkouts - Relative's previous checkouts - Holds Additionaly it suppresses the appearence of the superfluous word by in cases where the biblio has no author. Test scenario: -- 1) Make sure that you have one or more fields mapped to subtitle in: Home . Administration . Keyword to MARC mapping (e.g. 245 b) 2) Test the checkout page with patrons having - current checkouts (today) - previous checkouts - relatives (e.g. kids) with current /previous checkouts - holds on items - holds on biblios ...with items having: - title, subtitle, author - title, no subtitle, author - title, subtitle, no author - title, no subtitle, no author 3) Do the same on patron's detail page Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass Signed-off-by: Owen Leonard oleon...@myacpl.org Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Signed Off |Patch doesn't apply --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Conflicts now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20118 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20118action=edit Bug 9820 follow-up: fix a typo Although the XSLT template was renamed to nameABCQ, one instance of the old name (nameABCDQ) was not corrected. This patch corrects that. To test: Follow test plan on previous patch Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16822|0 |1 is obsolete|| --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20117 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20117action=edit bug 9820: display titles in MARC21 name headings better in XSLT mode Prior to this patch, if a 100/700 had a $c, it would be displayed with no space between the contents of $a and $c in XSLT mode. For example, 100 1#$aSeuss,$cDr. would be displayed as SeussDr The problem was caused by the original version of the stylesheets drawing a bit too much from the MARC21 to MODS transformation. To test: [1] In a MARC21 database, turn on XSLT display mode for staff and OPAC. [2] Create or identify a bib that has a 100 or 700 field with both a $a and a $c. [3] Before applying the patch, verify that the name is displayed in bib details and search results with the name and title squashed together. For example, SeussDr [3] After applying the patch, verify that the name displays in bib details and search results with a space and intervening punctuation between the name and the title. For example, Seuss, Dr. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10686] New: Fielded searches confuse highlighter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Bug ID: 10686 Summary: Fielded searches confuse highlighter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: jcam...@cpbibliography.com Reporter: jcam...@cpbibliography.com QA Contact: testo...@bugs.koha-community.org If you do a fielded search like au:smith, Smith will not get highlighted on the results page because the Javascript is looking for the exact string au:smith -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10686] Fielded searches confuse highlighter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10686] Fielded searches confuse highlighter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10686 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20119 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20119action=edit Bug 10686: Remove fields from searches for highlighting If you do a fielded search like au:smith, Smith will not get highlighted on the results page because the Javascript is looking for the exact string au:smith. To test: 1) Turn on OpacHighlightedWords. 2) Do a simple keyword search. 3) Confirm that the word is highlighted on the results and details page. 4) Do a fielded search by entering au:smith (or whatever). 5) Confirm that the word is highlighted on the results and details page. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10643] Inappropriate uses of $sth-finish() in C4::ClassSource.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10643 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #20105|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20120 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20120action=edit [SIGNED-OFF] Bug 10643: Inappropriate uses of $sth-finish() in C4::ClassSource.pm This patch gets rid of finish() and replace prepare_cached by prepare. From the man page finish() Indicate that no more data will be fetched from this statement handle before it is either executed again or destroyed. You almost certainly do not need to call this method. Adding calls to finish after loop that fetches all rows is a common mistake, don't do it, it can mask genuine problems like uncaught fetch errors. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10687] New: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bug ID: 10687 Summary: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Tab information for subtags of 86a and 86b is incorrect. They are listed on tab 0, when they belong to tab 6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #34 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Owen Leonard from comment #33) I just tried this out with a copy of our production database of patrons (62,000+ records) and I don't get any results. When I first load the page it looks like the table is trying to process *all* patron records? The POST response has this: iTotalRecords: 62459, iTotalDisplayRecords: 62459, ...but they are never displayed. I don't get any results from clicking on the browse by last name alphabet links, and I don't get any results after performing a simple search by last name. In all cases I see the processing message on the screen but nothing is ever displayed. Ouch, let me test that on a big database also. Testing now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 20121 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20121action=edit Bug 10687 - Incorrect tab information for tags 86a and 86b on default MARC21 auth framework This patch correct tab information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) run on database select distinct tagfield from auth_subfield_structure where cast(substr(tagfield,1,1) as unsigned) tab; 68a and 68b should be listed 2) apply the patch 3a) delete all auth frameworks and reload file ... OR ... 3b) run updatedatabase.pl 4) repeat step 1, no tags should be listed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10687] Incorrect tab information for tags 86a and 86b on default MARC21 auth framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #35 from Chris Cormack ch...@bigballofwax.co.nz --- Before the patches, 2.1s to load the page After the patches, up around 3 mins before I hit stop, and yes it was loading every single borrower. This is simply unusable with a library with a decent number of borrowers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Bob Birchall b...@calyx.net.au changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Bob Birchall b...@calyx.net.au --- Works for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #19259|0 |1 is obsolete|| --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 20122 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20122action=edit [SIGNED-OFF] Bug 5904: ysearch.pl members improvements (Independent branches behaviour) Test plan: - Add a staff user foo in a library A - Add a staff user bar in a library B - log in as foo and try to search 'bar' - Switch on (Prevent) the new pref IndependentBranchPatron - the search returns no result - log in as a superlibrarian - Check that you are allow to search all patrons. Signed-off-by: Srdjan srd...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant branches behaviour)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #11 from Srdjan Jankovic srd...@catalyst.net.nz --- I've signed this off, but not sure how much sense it makes. It is just for auto-complete, so used only for the checkouts. If you search eg patrons on /members/member.pl it is not used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10688] New: QueryParser doesn't recognize QP queries when used in a fielded search box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Bug ID: 10688 Summary: QueryParser doesn't recognize QP queries when used in a fielded search box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: jcam...@cpbibliography.com Reporter: jcam...@cpbibliography.com QA Contact: testo...@bugs.koha-community.org If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10688] QueryParser doesn't recognize QP queries when used in a fielded search box
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10688 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 20123 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20123action=edit Bug 10688: Don't prefix index inappropriately If you select an index in the search dropdown and then enter in a QP query starting with the field, Koha will prepend the index you do not want to use at the beginning of the search, resulting in a search that problem does not match what you were hoping for. To test: 1) Select an index in the search dropdown in the OPAC. Author is fine. 2) Enter a search term using manually entered indexes. For example: ti:cat in the hat 3) Note that the search fails. 4) Apply patch. 5) Repeat steps 1 and 2. 6) Note that the search succeeds. 7) Sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653 --- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz --- That's because you have DELETE FROM branches. You can try placing DELETE FROM borrowers before branches, but then you'll have problems with issues. And if you add DELETE FROM issues it will take forever to do that. I think that deleting from base tables is a bad idea. Unlike deleting from specific purpose tables, eg issuingrules, which is ok. I can see that test have progressed in the past couple of years, so this may not be relevant, but what I used to do is either: a) create my own data b) use random existing data, ie SELECT * FROM branches WHERE some_condition ORDER BY random, and take the top one; some_condition is eg has borrowers etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
