[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10698 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10681 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs return value
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #3 from kenza kenza.z...@biblibre.com --- (In reply to Chris Cormack from comment #2) I cant get this to apply, even after apply 10692 Sorry i forgot to mention it, but this patch also needs to apply 10681. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10034] kw,rld: in Z39.50 research
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10034 --- Comment #5 from Silvia Simonetti s.simone...@cineca.it --- I see the kw,rld: in the title field of Z39.50 search when I find in simple search and I have no result, or with Advanced search in keyword field and I have no result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Owen, Could you explain why this patch adds dataTables.fnReloadAjax.js and jquery.dataTables.columnFilter.js? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com --- I am not able to reproduce Owen and Chris issues. (In reply to Owen Leonard from comment #33) I just tried this out with a copy of our production database of patrons (62,000+ records) and I don't get any results. When I first load the page it looks like the table is trying to process *all* patron records? The POST response has this: iTotalRecords: 62459, iTotalDisplayRecords: 62459, ...but they are never displayed. I don't get any results from clicking on the browse by last name alphabet links, and I don't get any results after performing a simple search by last name. In all cases I see the processing message on the screen but nothing is ever displayed. Without any errors in your koha logs (or js error)? (In reply to Chris Cormack from comment #40) I think you may be misunderstanding, these patches add datatables, but they also change the behaviour so when you visit the members page it fetches every single borrower from the database. This is not acceptable, hence the failed qa, nor will an index fix it. It either needs to be rewritten to lazy load, or to not fetch all borrowers, or some other fix This patch normally does that! :) Of course, the goal of this patch is to retrieve only the xx first results, not all. After applying these patches, I go on members/members-home.pl and the generated sql query is: SELECT borrowers.borrowernumber, borrowers.surname, borrowers.firstname, borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode, borrowers.country, CAST(borrowers.cardnumber AS UNSIGNED) AS cardnumber, borrowers.dateexpiry, borrowers.borrowernotes, borrowers.branchcode, categories.description AS category_description, categories.category_type, branches.branchname FROM borrowers LEFT JOIN branches ON borrowers.branchcode = branches.branchcode LEFT JOIN categories ON borrowers.categorycode = categories.categorycode ORDER BY borrowers.surname asc,borrowers.firstname asc LIMIT 0,20 The limit clause exists! You can display this query in the log, warning the $query var in C4::Utils::DataTables::Members l.102. Maybe the executing time issue is caused by the 2 COUNT(*) queries. But since we don't want the SELECT SQL_CALC_FOUND_ROWS mysqlism, I don't know how we can do that on a different way. I will submit a patch replacing the count(*) with count(borrowers.borrowernumber), but I am not sure it could be useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20266 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20266action=edit Bug 9811: use count(primary_key) instead of count(*) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- With 35k patrons in the DB, the table is displayed in 2sec (on my dev instance). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] New: OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 Bug ID: 10710 Summary: OfflineOperation's routines in C4/Circulation.t need unit tests. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org AddOfflineOperation, GetOfflineOperation, GetOfflineOperations, DeleteOfflineOperation need unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kenza.z...@biblibre.com Blocks||10681 Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Depends on||10710 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza kenza.z...@biblibre.com changed: What|Removed |Added Summary|OfflineOperation's routines |UT : OfflineOperation's |in C4/Circulation.t need|routines in |unit tests. |C4/Circulation.t need unit ||tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20267 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20267action=edit Bug 10710 : OfflineOperation's routines in C4/Circulation.pm need unit tests. This patch test AddOfflineOperation,GetOfflineOperation and DeleteOfflineOperation in C4/Circulation.pm. The tests are wrap in a transaction. Note: Currently, GetOfflineOperations is not tested because we cannot mock C4::Context-userenv in unit tests To test: prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.01 usr 0.01 sys + 0.33 cusr 0.02 csys = 0.37 CPU -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] New: GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 Bug ID: 10711 Summary: GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kenza.z...@biblibre.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10711 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10681] Inappropriate uses of finish() in C4::Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681 kenza kenza.z...@biblibre.com changed: What|Removed |Added Blocks||10711 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||kenza.z...@biblibre.com Depends on||10681, 10710 Assignee|gmcha...@gmail.com |kenza.z...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10614] have add order form at top and bottom
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10614] have add order form at top and bottom
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 20268 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20268action=edit Bug 10614 - have add order form at top and bottom If a basket has a lot of items it may be inconvenient to scroll to the bottom of the patch to reach the add to basket form. This patch adds as Add to basket button to the toolbar which uses JavaScript to copy the form into a modal dialog for quick access. To test, apply the patch and view an open basket. You should be able to click the Add to basket button to trigger a modal dialog with the full Add to basket list of options. All options in the list should function normally. If you view a closed basket the new button should not appear. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 kenza kenza.z...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711 --- Comment #1 from kenza kenza.z...@biblibre.com --- Created attachment 20269 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20269action=edit Bug 10711: GetOfflineOperation in C4/Circulation.pm should returns $sth-fetchrow_hashref instead of $result To test : prove t/db_dependent/Circulation_OfflineOperation.t t/db_dependent/Circulation_OfflineOperation.t .. ok All tests successful. Files=1, Tests=7, 19 wallclock secs ( 0.02 usr 0.01 sys + 0.24 cusr 0.02 csys = 0.29 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649 --- Comment #5 from Owen Leonard oleon...@myacpl.org --- (In reply to Jonathan Druart from comment #4) Owen, Could you explain why this patch adds dataTables.fnReloadAjax.js and jquery.dataTables.columnFilter.js? They already exist, I'm just copying them to the new location. I thought it was sensible to move them at the same time I moved the other DataTables library js even though the templates where they are used (detail.tt and quotes.tt) are not affected by this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9456] Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #76 from Jonathan Druart jonathan.dru...@biblibre.com --- I get a really weird js error when I click on the Items header: TypeError: y[((string + -) + m[Q][1])] is not a function Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9652] Call number column on list view displays commas when no callnumbers exist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9652 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Fixed by Bug 9757 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10614] have add order form at top and bottom
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10614] have add order form at top and bottom
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10614 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #20268|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard neng...@gmail.com --- Created attachment 20270 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20270action=edit [SIGNED-OFF] Bug 10614 - have add order form at top and bottom If a basket has a lot of items it may be inconvenient to scroll to the bottom of the patch to reach the add to basket form. This patch adds as Add to basket button to the toolbar which uses JavaScript to copy the form into a modal dialog for quick access. To test, apply the patch and view an open basket. You should be able to click the Add to basket button to trigger a modal dialog with the full Add to basket list of options. All options in the list should function normally. If you view a closed basket the new button should not appear. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass and I love it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20272 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20272action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled - QA Followup Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- QA comment: The described ergonomic issue has been fixed. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19783|0 |1 is obsolete|| Attachment #19850|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20271 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20271action=edit Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled An error in the onclick for phone notices causes the Do not notify checkbox to be checked when the phone checkbox is checked. Also, checking Do not notify does not uncheck the phone checkbox. Test plan: 1) Enable TalkingTechItivaPhoneNotification 2) Browse to the new patron screen ( memberentry.pl ) 3) In the patron messaging preferences check the Phone checkbox 4) Not the do not notify checkbox is then checked 5) Uncheck the do not notify checkbox, and check the Email checkbox as well 6) Now check the do not notify checkbox, note the Phone checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan srd...@catalyst.net.nz Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6711] 'No more renewals' message has empty pull down
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6711 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Is this fixed now? I can't reproduce the problem by following the steps listed above, and Bug 6712 is marked as resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10611] C4::Context-dbh checks if the DB is still running
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10611] C4::Context-dbh checks if the DB is still running
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #19765|0 |1
is obsolete||
--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20273
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20273action=edit
Bug 10611: Use mysql_auto_reconnect instead of ping
DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a
ping.
Benchmarks:
use Modern::Perl;
use C4::Context;
for ( 1 .. 1000 ) {
$dbh = C4::Context-dbh;
}
* without this patch on a local DB:
perl t.pl 0,49s user 0,02s system 98% cpu 0,525 total
* without this patch on a remote DB:
perl t.pl 0,52s user 0,05s system 1% cpu 37,358 total
* with this patch on a local DB:
perl t.pl 0,46s user 0,04s system 99% cpu 0,509 total
* with this patch on a remote DB:
perl t.pl 0,49s user 0,02s system 56% cpu 0,892 total
Testing the auto reconnect:
use Modern::Perl;
use C4::Context;
my $ping = $dbh-ping;
say $ping;
$dbh-disconnect;
$ping = $dbh-ping;
say $ping;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10611] C4::Context-dbh checks if the DB is still running
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #2) This patch breaks test cases that mock C4::Context-_new_dbh() Good catch, the db_driver variable was not defined! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6604] without OPACXSLTResultsDisplay, some entries are no items available in opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6604 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard oleon...@myacpl.org --- This bug is quite old, so it's hard to tell what was going on here. However it sounds as if it was a simple indexing problem. If Zebra hasn't indexed newly-added items how can they be displayed? If someone knows better and can explain, please re-open. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|paul.poul...@biblibre.com |jonathan.dru...@biblibre.co ||m --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Looks good to me. Can be tested on tools/import_borrowers.pl?sample=1 Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7785] MySQL-specific syntax in C4::Members columns()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7785
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #19901|0 |1
is obsolete||
--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20274
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20274action=edit
Bug 7785 - MySQL-specific syntax in C4::Members columns()
The initial thought was to remove this function. However,
tools/import_borrowers.pl uses it. So rather than remove
it to solve the problem, it was reworked to a more generic
solution which runs faster.
By accessing $sth-{NAME} directly, the driver becomes
responsible for filling it correctly. This happens when a SELECT
is done on the borrowers table. It does not even have to have
data in the result set!
The columns method could be more generic and used elsewhere too.
Comparison between the old method and the STH method showed a
significant time difference. The old method took 35 seconds
for 40k iterations versus 19 seconds for the same amount of
iterations with the STH method regardless of the size of the
borrowers table.
Signed-off-by: Srdjan srd...@catalyst.net.nz
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||5766 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||7019 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #19764|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20275 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20275action=edit iBug 10610: sysprefs.sql should be sorted by syspref names By sorting the sql syspref file, the developpers will be happy to avoid conflicts on this file each time a patch modifying it is pushed. Test plan: - create a new DB with a new table named systempreferences (with the same structure as the one you know). - insert the current sysprefs.sql file into this table. - note the number of rows in the systempreferences table. - apply this patch. - delete all rows of the systempreferences table. - insert the new sysprefs.sql file. - verify the number of rows is the same as the previous. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10511] Odd behavior for messaging preferences with Talking Tech enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10511 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Srdjan Jankovic from comment #6) Do I need some setup first? No, this should be done by this unit tests file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 20276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20276action=edit Bug 10333: remove_item should be called just one time If there is no remaining items, the retrieve routine returns -2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Stable --- Comment #4 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10712] New: Some values not saved in koha install log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Bug ID: 10712 Summary: Some values not saved in koha install log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcha...@gmail.com Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org when running perl Makefile.PL --prev-install-log for an upgrade you are still prompted to choose the authorities indexing mode and the tokenizer value they should be saved with the other variables in the koha-install-log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10246] OPAC items table CSS classes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com Assignee|chr...@catalyst.net.nz |bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10712] Some values not saved in koha install log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 20277 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20277action=edit Proposed Patch To test. On a system installed/upgraded without the patch running 'perl Makefile.PL --prev-install-log /path/to/koha-install-log' will still prompt you to choose authorities indexing mode and select between chr and icu, after upgrading with this patch applied the same command should get the responses from the install log and not require user intervention. The values can be seen written into misc/koha-install-log -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #3 from Galen Charlton gmcha...@gmail.com --- Noting that a Koha user recently reported an instance of purchase suggestion spam: http://lists.katipo.co.nz/pipermail/koha/2013-July/036898.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7741] Clear search terms in Z3950 search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7741 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Is there a patch forthcoming? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7075] Fine in days values are returned for patrons with past overdues when fine in days is set to 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7075 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Galen Charlton gmcha...@gmail.com --- This bug was made moot by the patch for bug 6328. Setting to RESO/INVALID. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8031] get rid of older notices from the patron notices tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8031 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7536] delete permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7881] display additional fields in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7881 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7536] delete permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7536 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7881] display additional fields in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7881 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7032] can select multiple layouts to edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|ASSIGNED|In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7032] can select multiple layouts to edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7032 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||gmcha...@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #11 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- (In reply to David Cook from comment #5) Why don't we call the new reorder function on patron delete? I see that there is already a function for handling patron deletes in regards to Lists/VirtualShelves. That probably makes the most sense. I prefer this option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8031] get rid of older notices from the patron notices tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8031 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #12726|0 |1 is obsolete|| --- Comment #8 from Galen Charlton gmcha...@gmail.com --- Created attachment 20278 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20278action=edit Bug 8887: only display desired result when doing exact syspref search This patch fixes an issue where entering the complete name of a system preference when doing a syspref search in the staff interface resulted in the display of *all* preferences belonging to the desired one's module. Since providing a more specific search string should result in getting back more specific results, the previous behavior was not intuitive. Test scenario: a) In sysprefs, do a search with partial match (e.g. intranetcolor) - Result shows one entry: intranetcolorstylesheet b) Do an exact search. e.g. intranetcolorstylesheet - Result shows all Staff Client preferences Apply patch, test again. Now b) behaves like a). Signed-off-by: Mirko Tietgen mi...@abunchofthings.net Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with exact matches (default instead of custom favicon used, displays to much results)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887 --- Comment #9 from Galen Charlton gmcha...@gmail.com --- (In reply to Jonathan Druart from comment #6) I don't know if it is what the users want. It is what *this* user wants -- this has been annoying me for years, albeit not enough to do anything about it. I do not find it intuitive that providing a more specific search string yields more hits, not fewer. The existing behavior was intentional -- see commit cdb3d52423f9 -- but IMO the jump to preference is only effective if the module (e.g., Circulation) has enough preferences to make the page long enough that the desired preference is scrolled to the top of the browser viewport. For most sysprefs, though, I end up having the scan the page for the one I just searched for, and it would be easier if the search just gave me only the one I was looking for. I recognize that opinions can differ on this, but thus far no contrary ones have actually been expressed. I've signed off on the patch and adjusted the wording of the commit description a bit. I did remove mention of the favicon, as I wasn't able to reproduce it and I think it's a moot issue. Status = Signed Off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7136] language inconsistency on serials status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 --- Comment #4 from Owen Leonard oleon...@myacpl.org --- I still don't know what to do with this. If an issue goes from expected to waiting to late like the help file says, how can we replace waiting with expected? Or are they really the same, and the help file is inaccurate? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton gmcha...@gmail.com --- (In reply to claire.hernan...@biblibre.com from comment #5) We are currently working on this patch, please do not consider this submission for the moment Any updates? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #3 from Galen Charlton gmcha...@gmail.com --- (In reply to claire.hernan...@biblibre.com from comment #2) We are currently working on this patch, please do not consider this submission for the moment Any updates? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6833] Notifications Rewrite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6833 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |RESOLVED CC||gmcha...@gmail.com Resolution|--- |WISHLIST --- Comment #4 from Galen Charlton gmcha...@gmail.com --- As it is approaching nearly two years since the bug was opened with no sign that the notifications RFC is being worked on, setting to RESOLVED/WISHLIST. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6697] Empty Organisation(s) field for organisational patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard oleon...@myacpl.org --- If the display problem is fixed, isn't this bug fixed? If there is functionality which hasn't been implemented that belongs in another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7207] Cannot export label batches in IE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7207 Bug 7207 depends on bug 6697, which changed state. Bug 6697 Summary: Empty Organisation(s) field for organisational patrons http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9904] Link to plugins management should not be in global navigation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9904 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |RESOLVED CC||gmcha...@gmail.com Resolution|--- |FIXED --- Comment #7 from Galen Charlton gmcha...@gmail.com --- (In reply to Kyle M Hall from comment #6) I also think this is a bad move. It's going to confuse, not clarify. Both the tool and report plugin links filter some of the plugins and aren't meant to be for full plugin management. I believe this commit should be reverted. I won't be the one to revert it, and I'm setting the status accordingly. From the POV of an ordinary user, plugins are *not* a separate module -- they are simply a mechanism by which additional tools and reports can be made available. There really should be no separate plugins home page, just: - an admin page to upload and manage them - list of tool plugins (with Home Tools Tool Plugins as the breadcrumb list and the tools sidebar) - list of report plugins (with Home Reports Report Plugins as the breadcrumb list and the reports sidebar) The later two pages should *not* offer the upload link in the sidebar -- that is purely an administrative function. I'll file a separate bug for the above. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5766] Add configuration for excluding articles from jQuery table sorter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5766 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10713] New: integrate tools and reports plugins into staff interface better
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10713 Bug ID: 10713 Summary: integrate tools and reports plugins into staff interface better Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com From the POV of an ordinary user, plugins are *not* a separate module -- they are simply a mechanism by which additional tools and reports can be made available. Consequently, they should integrate better with the tools and reports sections of the staff interface. There should be no separate plugins home page, just: - an admin page to upload and manage them - list of tool plugins (with Home Tools Tool Plugins as the breadcrumb list and the tools sidebar) - list of report plugins (with Home Reports Report Plugins as the breadcrumb list and the reports sidebar) The later two pages should *not* offer the upload link in the sidebar -- that is purely an administrative function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #21 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10563] Link to edit subscription from 'check expiraton' page is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10563 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6124] In transferstoreceive.pl some biblios are empty.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6124 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #7 from Galen Charlton gmcha...@gmail.com --- Setting to RESOLVED/INVALID -- it's been over a year since the question was posed, and the FK on branchtransfers.itemnumber should make the bug impossible unless the wrong storage engine was being used. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #22 from Galen Charlton gmcha...@gmail.com --- (In reply to Kyle M Hall from comment #21) 2) Solve at the .tt level: i.e. use Koha::Template::Plugin::KohaAuthorisedValues and patch as we go along at the template level. We can patch this sub to check for an authorised value mapping and return either the correct mapping or the original passed in data. The will greatly simplify the amount of code necessary to support the use of authorised values mapping. I prefer this option. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10712] Some values not saved in koha install log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10712] Some values not saved in koha install log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Attachment #20277|0 |1 is obsolete|| --- Comment #2 from Galen Charlton gmcha...@gmail.com --- Created attachment 20279 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20279action=edit Bug 10712: Save missing config variables to install log The variables for AUTH_INDEX_MODE and ZEBRA_TOKENIZER were not being saved to the koha_install_log file. As a result when using the --prev-install-log option in Makefile.PL the user was still prompted to select them. This patch adds the appropriate variables to the list saved in the install log. To test: On a (non-package) system installed/upgraded without the patch running 'perl Makefile.PL --prev-install-log /path/to/koha-install-log' will still prompt you to choose authorities indexing mode and select between chr and icu, after upgrading with this patch applied the same command should get the responses from the install log and not require user intervention. The values can be seen written into misc/koha-install-log Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811
--- Comment #46 from Galen Charlton gmcha...@gmail.com ---
I've spent a bit of time with the current patch series, and I've *not* been
able to reproduce the problem where going to members/member.pl induced
DataTables to try loading the entire patron database.
Chris, Owen, could you try again? I'd be particularly interested to know exact
browser versions if you're still encountering the problem.
Looking at the code, I do see a place in C4/Utils/DataTables/Members.pm where
some defensive coding is in order:
my $limit;
if(defined $dt_params-{iDisplayStart} and defined
$dt_params-{iDisplayLength}) {
# In order to avoir sql injection
$dt_params-{iDisplayStart} =~ s/\D//g;
$dt_params-{iDisplayLength} =~ s/\D//g;
$limit = LIMIT
$dt_params-{iDisplayStart},$dt_params-{iDisplayLength};
}
The problem is that if iDisplayStart is never passed as a CGI parameter
(because of a DataTables bug or some unrelated JavaScript bug interfering with
the proper initialization of the DataTables object), the patron query will be
unlimited.
To avoid that, a LIMIT clause should *always* be added to the patron query,
with sensible default values if iDisplayStart and/or iDisplayLength are not
supplied. 0 and 20, respectively, I'd say.
We may also want to consider hardcoding an absolute cap (say 100?) on
iDisplayLength.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #47 from Galen Charlton gmcha...@gmail.com --- (In reply to Jonathan Druart from comment #43) Maybe the executing time issue is caused by the 2 COUNT(*) queries. But since we don't want the SELECT SQL_CALC_FOUND_ROWS mysqlism, I don't know how we can do that on a different way. And FWIW, even if we allowed the MySQLism, it might not actually be any faster than running two queries: http://www.mysqlperformanceblog.com/2007/08/28/to-sql_calc_found_rows-or-not-to-sql_calc_found_rows/ That blog post is pretty old, of course, so things may have changed, but benchmarking would be in order either way. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #48 from Galen Charlton gmcha...@gmail.com --- As a final comment, for the moment, I think it is best if merely going to the patron home page does not do a search -- retrieving 20 records isn't a huge performance hit, of course, but the first 20 records are very unlikely to be useful. It would be better to omit the search so that the search form can be rendered more quickly. This should be distinguished (by checking for POST vs. GET, presumably) from the case where the staff user intentionally does a blank patron search as a way of bringing up a list of all patrons. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8324] User created lists sort by title just after editing sort order (call by opac-shelves.pl without sort parameter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #49 from Galen Charlton gmcha...@gmail.com --- I lied, one more comment: there is a minor but annoying change of behavior. Prior to the patch, if you start from the patron home page and do a search that retrieves a single hit, it automatically redirects to the details page for that patron. You can then use the back button to get back to the patrons home page. After the patch, the back button is effectively broken -- you can go back, but it will then immediately re-run the search and redirect you back to the patron record. It would be *really* nice if it didn't do that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 20280 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20280action=edit Bug 8324 - Redisplay OPAC list with correct sort after edit If you are viewing the contents of a list, edit it, change the default sort, and save your list will be redisplayed sorted by title no matter what default sort you chose. Lists do not automatically sort by their default sort, they must be opened with the sort parameter. This patch adds the list's sort parameter to the redirect after editing. To test, open an existing list in the OPAC which contains items. Click the Edit list link at the top of the list contents view. Change the default sort to something new. Click Save. If the list is redisplayed using the new default sort the patch worked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Summary|User created lists sort by |Redisplay OPAC list with |title just after editing|correct sort after edit |sort order (call by | |opac-shelves.pl without | |sort parameter) | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10714] New: Redirect to list contents view upon save after initiating edit from list contents view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Bug ID: 10714 Summary: Redirect to list contents view upon save after initiating edit from list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Lists Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl In the OPAC, if you edit a list from the list contents view you are redirected to the contents of that same list after you save your changes. In the staff client you are redirected back to the list of lists. The staff client interface should match the OPAC in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 20281 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20281action=edit Bug 10714 - Redirect to list contents view upon save after initiating edit from list contents view In the staff client, if you initiate a list edit from the list contents view you should be redirected to that same view after saving your changes. The OPAC already works this way. To test, view the contents of an existing list. Click the Edit list item under the Edit menu. Click save on the list edit form and you should be redirected back to the contents view of that list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9798] Add html id to the Online Resources label of the OPAC detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9798 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|In Discussion |RESOLVED CC||neng...@gmail.com Resolution|--- |FIXED --- Comment #3 from Nicole C. Engard neng...@gmail.com --- This seems to be done in master already. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10059] admin user can't see budgets on acq page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton gmcha...@gmail.com --- (In reply to Nicole C. Engard from comment #3) The warning is good - and it should be there for the average user, but this development has made it difficult as a company supporting libraries to continue to support them. Wouldn't it suffice to create a normal superlibrarian account, but hang on to the root DB credentials in case you need to recreate the superlibrarian account? Also, the normal patron purge specifically excludes patron records whose category type is staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10059] admin user can't see budgets on acq page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- Well library staff can manually delete any users they want .. so they could (and probably will by accident) delete the user we don't want deleted. Of course we're creating users for this - I just think that it will effect other companies out there. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612
--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 19767
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19767
Bug 10612 - Add ability to delete patrons with batch patron modification tool
Review of attachment 19767:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10612attachment=19767)
-
::: tools/modborrowers.pl
@@ +259,5 @@
+{ error = fees_owed, borrower = $borrower } );
+}
+else {
+MoveMemberToDeleted($borrowernumber);
+DelMember($borrowernumber);
This is missing a call to C4::VirtualShelves::HandleDelBorrower.
Also, with the proposed patron purging cronjob (bug 10419) also in play, I am
getting concerned about the number of different places in the code that (a)
check whether a patron record is allowed to be deleted and (b) do the deletion,
particularly since the original patch series for bug 10419 had also missed
HandleDelBorrower.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10059] admin user can't see budgets on acq page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Nicole C. Engard from comment #6) Well library staff can manually delete any users they want .. so they could (and probably will by accident) delete the user we don't want deleted. Of course we're creating users for this - I just think that it will effect other companies out there. Nicole Catalyst is cool with it, we tell our clients not to delete the test/catalyst users. And we also ask them to create them. Works for us. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10059] admin user can't see budgets on acq page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 --- Comment #8 from Galen Charlton gmcha...@gmail.com --- (In reply to Chris Cormack from comment #7) (In reply to Nicole C. Engard from comment #6) Well library staff can manually delete any users they want .. so they could (and probably will by accident) delete the user we don't want deleted. Of course we're creating users for this - I just think that it will effect other companies out there. [snip] Catalyst is cool with it, we tell our clients not to delete the test/catalyst users. And we also ask them to create them. Works for us. The current state of affairs works for Equinox as well. IOW, the support company I work for also sees no need to regularly use the DB credentials to log into Koha, particularly since the staff interface nowadays explicitly recommends against doing that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10715] New: MARC21 007 Plugin Editor doesn't load position 01
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Bug ID: 10715 Summary: MARC21 007 Plugin Editor doesn't load position 01 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently, position 01 isn't loaded into the plugin editor for the 007 field in MARC21. This is because the template expects 1 character but the perl script is trying to pass in 4 characters. I can see no reason for this and when I do a git blame, it looks like this might be an accidental holdover from a past implementation of the plugin editor. If we switch the perl script to pass 1 character instead of 4, the plugin editor works as it should and I see no undesirable behaviours. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
