[Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222

--- Comment #46 from David Cook dc...@prosentient.com.au ---
Maybe it's worth teasing apart what needs to happen here...

Architecture:
1) Add nonpublicnote to the items and deleteditems tables for all installs
using updatebase.pl (it shouldn't matter if the column is in the items table
for old installs). 
2) Change kohastructure and default framework SQL so that new installs map
952$x (and the other flavour equivalents) to the nonpublicnote DB column.

Display (Show on):
1) detail page
2) moredetail page
3) circulation pages
4) returns pages
5) serial collections pages?


Utilities:
1) Iterate through all frameworks
- If a mapping for item Non-public note is found, copy the data into the
nonpublicnote column. 
- If no mapping is found, use the subfield in the framework (probably X) to
interrogate the more_subfield_xml for an element with that subfield, and copy
that data into the publicnote column.
2) Set the mapping for all frameworks for Non-public note to nonpublicnote DB
column.

--

Concerns:

When iterating through the frameworks, we need to have a way of defining the
entry for which we're looking. I don't think it's enough to look for the string
Non-public note as that might be changed (or translated?).

Is it enough to look for the 952$x? This probably only applies to MARC21 so
we'll need to take into account the other marc tags used for the other MARC
flavours.

It might be an idea to make the utility interactive to make sure that the 952$x
(or whatever) is the right framework entry to be analyzing...although if the
script is interactive, it might make it more difficult for some people to do
upgrades.

Thoughts anyone?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222

--- Comment #47 from David Cook dc...@prosentient.com.au ---
Another idea would be to just parse the data from more_subfields_xml (rather
than changing the architecture of the database), but I think that would bring
us back to the possibility that we might not necessarily know for sure that
952$x is always the MARC21 field/subfield for the non-public note. 

I'd be happy for someone to prove me wrong on that one though, as that might
just be the easiest way to do this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20275|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20323
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20323action=edit
iBug 10610: sysprefs.sql should be sorted by syspref names

By sorting the sql syspref file, the developpers will be happy to avoid
conflicts on this file each time a patch modifying it is pushed.

Test plan:
- create a new DB with a new table named systempreferences (with the
  same structure as the one you know).
- insert the current sysprefs.sql file into this table.
- note the number of rows in the systempreferences table.
- apply this patch.
- delete all rows of the systempreferences table.
- insert the new sysprefs.sql file.
- verify the number of rows is the same as the previous.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10610] sysprefs.sql is really boring to rebase

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10610

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Srdjan Jankovic from comment #5)
 I got 414 with the current script (master
 a36b3ad43a6a91f800d0d8a148a217d738236d7e), and 416 with the patch. Can you
 please check, and if you don't get the same I'll dump and compare.

Oops, I suspect I was not on master when I generate the file.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7308] new column in admin/aqbudgets

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Srdjan Jankovic from comment #9)
 Use of uninitialized value $encoding in string eq at C4/Biblio.pm line 3281.
 Use of uninitialized value $encoding in pattern match (m//) at C4/Biblio.pm
 line 3301.

I have no idea where is the problem. But there 2 lines intrigues me. $encoding
is C4::Context-preference(marcflavour). Don't you have the marcflavour
syspref in your DB?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10722] New: The log in bar Log in to your account floats incorrectly in the middle of the page on iPhone

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10722

Bug ID: 10722
   Summary: The log in bar Log in to your account floats
incorrectly in the middle of the page on iPhone
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: Other
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: viktor.sa...@regionhalland.se
QA Contact: testo...@bugs.koha-community.org

Created attachment 20324
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20324action=edit
Screenshot of how 3.13 looks in Safari on iPhone 5 and 4S

The bar to log into ones account in Opac floats inccorectly at the middle of
the page overlaying the content. It seems to occur at least on Koha 3.12 and
3.13 in Safari running on iPhone 4S and iPhone 5. The 3.12 release has had some
CSS-modifications but it also occurs on 3.13 updated daily with the latest
code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Katrin Fischer from comment #29)
 I have spent some time looking at those patches and I am worried that they
 try to do too many things. I think i have identified what they do, but I am
 not sure (which is not a good sign :) ). I think we have 3 things here, that
 ideally should be broken up into 3 different bugs to make this easier
 testable:
 
 - Merging GetPendingOrders and GetOrders + regression tests
 - Adding basket group name search
 - Adding datatables to the pending oders page
 
 Jonathan, do you think you could break it up on different bugs with test
 plans for each?

The 3 patchs can be tested together so I don't think it is relevant, but I will
do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] New: GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Bug ID: 10723
   Summary: GetPendingOrders and SearchOrders can be merged
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

There two routines does the same thing. They can be merge into one routine and
improved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10723

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||10124
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||10124
 Depends on||10723
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10724

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10724

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] New: Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Bug ID: 10724
   Summary: Search by basket group on the parcel page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10725] New: Add filters on the pending orders table

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Bug ID: 10725
   Summary: Add filters on the pending orders table
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Datatable allows to easily adds filters on the table headers. It would be great
to have them on the pending orders table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||10725

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10725

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10725] Add filters on the pending orders table

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
URL||acqui/parcel.pl
 Blocks||10124
 Depends on||10724
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20325
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20325action=edit
Bug 10723: Merge GetPendingOrders and SearchOrders routines

In the C4::Acquisition module, 2 routines do the same work. This patch
merges these 2 routines.

Test plan:
test the acqui/orderreceive.pl, acqui/uncertainprice.pl
and serials/acqui-search-result.pl, acqui/parcel.pl scripts.

Note: on acqui/parcel the basket filter is a search on basket name (was
on basket id, which was not relevant).

Signed-off-by: Pierre Angot tredok.pie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20326
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20326action=edit
Bug 10724: Pending orders: add basket group name in filters

This patch adds a new filter basket group name for pending orders
searches.

Test plan:
Try different filters and check that results are consistent.
Try to filter by basket group name.

Signed-off-by: Pierre Angot tredok.pie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
URL||acqui/parcel.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10724] Search by basket group on the parcel page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10725] Add filters on the pending orders table

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10725] Add filters on the pending orders table

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10725] Add filters on the pending orders table

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20327
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20327action=edit
Bug 10725: Add filters on the pending orders table

Since the parcel.pl script get *all* pending orders, there is no reason
not to display all of them.

Like that, DataTable manages pagination and sorting correctly (on all
data).
This patch adds filters on the table header (using columnFilter).

Test plan:
Try filters on the left of the screen and filters on the table header.

Signed-off-by: Pierre Angot tredok.pie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |MOVED

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
Please see bug 10723, bug 10724 and bug 10725.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10726] New: Default Unimarc framework in accordance with new edition of the Unimarc manual

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

Bug ID: 10726
   Summary: Default Unimarc framework in accordance with new
edition of the Unimarc manual
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: sonia.lema...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

On November 4th 2013, bibliographic and authorities unimarc formats will
change.
Default unimarc frameworks should be adapted to these changes.

Affected fields for Unimarc/ Biblio:

- 205$d and 208$d generate =
- 4XX$t is repeatable
- 501: new subfields $m and $r added
- 503: new subfield $o
- 510, 512, 513, 514, 515, 516, 517, 518, 520, 540: new subfield $n
- 545: new subfields $e $h $i $j $n $z
- 930: new subfields $w and $z

Affected fields for Unimarc/ Authorities

- 033: new field

(Thoses changes are also needed for versions 3.08 and 3.10)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

Sonia Lemaire sonia.lema...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |sonia.lema...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

1/ The screen is not obvious:

  Last borrowed:14/08/2013 
  Last returned by: 23529001223640 
  Last borrower: 23529001223640 
  Previous borrower: 23529001223641

The last returned by and the last borrower is the same value when
AnonymousPatron is not in use.

2/ Could you use the template plugin to get the syspref value (rather than to
pass it from the pl script).

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Kyle, the js error still occurred.

To reproduce:
- open firebug on the console tab
- go to tools/tools-home.pl
- click on the Staged MARC record management link

caused by tools/manage-marc-import.tt l. 49:
  aoData.push( { name: import_batch_id, value: [% import_batch_id %] } );

The import_batch_id var is not defined on this view.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20328
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20328action=edit
Bug 10558 [QA Follow-up 2] - Fix JavaScript Error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20329
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20329action=edit
Bug 9011 - QA Followup

* Use template plugin to get syspref values
* Hide last returned by if AnonymousPatron is not set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10727] New: Replace carriage return with br / when writing hold notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727

Bug ID: 10727
   Summary: Replace carriage return with br / when writing hold
notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

This patch replaces carriage return with br / in the content of hold notices
for printing. This is necessary to convert html file into well formatted pdf
file.

Test plan : 
- return an item reserved by a borrower that has not activated email
notification
- verify in message_queue table that you've got a new HOLD_PRINT notice with
status 'pending'
- run gather_print_notices.pl directory

Without the patch, the script generates a html file without br / tags. If you
run printoverdues.sh directory, the text in the resulting pdf file is all on
one line

With the patch, the script generates a html file with br/ tags and pdf file
created by printoverdues.sh is well formatted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10727] Replace carriage return with br / when writing hold notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727

--- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com ---
Created attachment 20330
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20330action=edit
Bug 10727 : Replace carriage return with br / when printing hold notices

This patch replaces carriage return with br / in the content of
hold notices for printing. This is necessary to convert html file
into well formatted pdf file.

Test plan :
  - checkin an item reserved by a borrower
that has not activated email notification
  - verify in message_queue table that you've got a
new HOLD_PRINT notice with status 'pending'
  - run gather_print_notices.pl directory

Without the patch, the script generates a html file without br / tags.
If you run printoverdues.sh directory, the text in the resulting pdf file
is all on one line

With the patch, the script generates a html file with br/ tags and
pdf file created by printoverdues.sh is well formatted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10727] Replace carriage return with br / when writing hold notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6030

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10727

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10727] Replace carriage return with br / when writing hold notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727

Sophie MEYNIEUX sophie.meyni...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |sophie.meyni...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10081] IndependentBranches error message missing the library name

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20321|0   |1
is obsolete||

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20331
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20331action=edit
Bug 10081: add library name to IndependentBranches error message

With IndependentBranches turned on, if you try to check out an item
which belongs to another library you will get an error message which is
missing the library name. This patch corrects the problem by passing the
necessary variable to the template and outputting the library name using
the KohaBranchName TT plugin.

To test, turn on IndependentBranches and try to check out an item
belonging to another library (note that you must test with a staff user
who is not a superlibrarian). The error message you see should include
the name of the library to which the item belongs:

This item belongs to Nelsonville and cannot be checked out from this
location.

Checkouts of items belonging to the library should be unaffected.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10728] New: subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Bug ID: 10728
   Summary: subscription-renew generates unnecessary warnings in
logs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

subscription-renew.pl generates warnings in the logs if mode is undefined, set
a default value to cut down the noise. Can use the mode variable which is
otherwise created for no reason

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
A customer asked me the same request then I developed a patch and completely
forgot this one.
So I will provide a followup with what I needed some months ago :)

But after a little reflexion, I don't know if it is relevant. I think it is not
pleasant not to let the choice to the user.

Are you sure it is legal not to let the user deactivate notifications?

Switch to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20332
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20332action=edit
Bug 9254: redirect to 404 if at least 1 pref is off

And set the value of EnhancedMessagingPreferencesOPAC =
EnhancedMessagingPreferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10606] MySQLism in GetUpcomingDueIssues

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10606

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20311|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20333
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20333action=edit
Bug 10606: Remove MySQLism in GetUpcomingDueIssues

To test:

[1] Arrange to have at least one loan in your test database due
one day from now.
[2] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2
and note the number of loans reported.
[3] Apply the patch.
[4] Run misc/cronjobs/advance_notices.pl -c -n -v -m=2 again
and verify that the number of loans reported remains the same.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7598] Acquisitions JavaScript contains untranslatable English strings

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7598

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9801] location facet shows even if no locations

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9801

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20282|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20334
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20334action=edit
Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01

This patch changes the MARC21 007 plugin editor so that it uses
1 character instead of 4 characters for position 01.

TEST PLAN:

1) Create new record/edit an existing record
2) Using the tag editor for the 007 field, choose Videorecording
3) Click OK
4) Change the second character in the 007 from c to d
5) Open the tag editor again
6) Note that position 01 will still say c - Videocartridge rather
than d - Videodisc.
7) Exit tag editor

8) Apply patch

9) Reload the page (Shift + Refresh is always useful)
10) Open the tag editor again
11) Note that position 01 will now say d - Videodisc

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #24 from Tomás Cohen Arazi tomasco...@gmail.com ---
Latest patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10559] noisy statement handle still active warnings when generating notices

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10559

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Galen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load position 01

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe.
   |ity.org |com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 20335
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20335action=edit
Proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10597] Search to hold button broken on record details

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10597

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10595] OpacTopissue page still accessible when system preference is turned off

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10595

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

1/ There is no pod in the new file (yes I know, I am not the best person to
make this remark...).

2/ The license version should be replaced with the GPLv3.

3/ I don't know why but the ajax script is called twice! (maybe can you have a
look at my patch for bug 9811 where I use a script to populate a table with the
server side processing method).

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20239|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20336
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20336action=edit
Bug 10587: fix HTML errors on authority detail page in OPAC

A validator check of the OPAC's authority detail returns a few minor
errors. This patch corrects the errors.

To test, apply the patch and run an OPAC authority detail page through
an HTML validator. There should be no errors which are specific to the
authorities detail template (as opposed to header and footer includes).

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20335|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20337
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20337action=edit
Bug 10728: fix log noise generated by subscription-renew.pl

Error log is showing warnings because mode is undefined
and we are doing string comparisons on it.

Set it to a default value (we were already assigning it a variable
which we were not using) and use the the result in the comparison

To test, after applying the patch:

[1] Use the renew link from the subscription detail page to renew
a subscription.
[2] Verifying that doing this did not add a warning containing
'subscription-renew.pl: Use of uninitialized value $mode in string eq '
to the Apache error log.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10728] subscription-renew generates unnecessary warnings in logs

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20338
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20338action=edit
bug 10728: fix additional log noise generated by subscription-renew.pl

To test:

[1] Use the renew link to bring up the subscription renewal form.
[2] Verify that a warning message containing the text
'Problem = a value of 1 has been passed to param without key'
was not added to the Apache error log.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests.

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10716] The booksellers template generates a JS error

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20293|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20340
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20340action=edit
Bug 10716: fix JavaScript error on basket groups page

To test:

Go on acqui/basketgroup.tt and verify a js error occurred
(ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined).
Apply the patch and verify the error does not appear anymore.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10487] UT: GetMaxPickupDate needs unit tests.

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10487

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #19183|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20339
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20339action=edit
Bug 10487: UT: GetMaxPickupDate needs unit tests

GetMaxPickupDate is introduced by bug 8367. It needs unit tests.

$ prove t/db_dependent/Reserves.t
should produce:
 t/db_dependent/Reserves.t .. 1/14 #
 # Creating biblio instance for testing.
 # Creating item instance for testing.
 ERROR: GetMaxPickupDate is called without reserve and without itemnumber
 ERROR: GetMaxPickupDate is called without reserve and without itemnumber
 t/db_dependent/Reserves.t .. 11/14 # Deleting item testing instance.
 # Deleting biblio testing instance.
 # Deleting borrower.
 t/db_dependent/Reserves.t .. ok
 All tests successful.
 Files=1, Tests=14,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.42 cusr
 0.06 csys =  0.51 CPU)
 Result: PASS

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10716] The booksellers template generates a JS error

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10716

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #19849|0   |1
is obsolete||

--- Comment #77 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20341
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20341action=edit
Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on
callnumber only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

--- Comment #78 from Kyle M Hall k...@bywatersolutions.com ---
Please check again to see if this error still occurs.

(In reply to Jonathan Druart from comment #76)
 I get a really weird js error when I click on the Items header:
   TypeError: y[((string + -) + m[Q][1])] is not a function
 
 Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|paul.poul...@biblibre.com   |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Last patch fixes the issues. Thanks Kyle.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20344
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20344action=edit
Bug 9011: Update GPL license

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20329|0   |1
is obsolete||

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20343
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20343action=edit
Bug 9011 - QA Followup

* Use template plugin to get syspref values
* Hide last returned by if AnonymousPatron is not set

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] New: Support phrases-icu.xml in install and upgrade

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Bug ID: 10729
   Summary: Support phrases-icu.xml in install and upgrade
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

While resolving some indexing probs for customers using icu in zebra, noted
that recommendations for using icu suggested copying phrases-icu.xml from the
zerbra install into koha. That procedure is a bit at odds with standard install
and upgrade procedure. Need to add a useable phrases-icu.xml to koha and to
ensure that install now updates default.idx correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #20181|0   |1
is obsolete||

--- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 20342
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20342action=edit
Bug 9011 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the field items.last_borrower, foreign key to
  borrowers.borrowernumber
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha set this new
  field to the patron who last returned this item.
* If this new field has a value, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
should be a new field in the history list 'Last returned by' with a link
to the given borrowernumber.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Owen Leonard oleon...@myacpl.org

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9456] Add callnumber column to the cart

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

--- Comment #79 from Owen Leonard oleon...@myacpl.org ---
I just tested this and got an error at first because I didn't clear my browser
cache. After a shift-reload it worked without errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20345
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20345action=edit
Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 20346
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20346action=edit
Proposed patch

Testing: 
With icu enabled, default.idx will now use icuchain phrases-icu.xml for phrase
indexes after a make install or make upgrade. word indexes will state icuchain
words-icu.xml
The new file will be copied to etc/zebradb/etc by install/upgrade

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10558] Convert records table in manage-marc-import.pl to ajax DataTable

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Kyle M Hall k...@bywatersolutions.com ---
Is this followup 3 what you are looking for? I examined the network access of
the page and did find two calls to batch_records_ajax.pl, but the first was a
302 redirect that did not send any content, with the second one being a 200
that does send content.

(In reply to Jonathan Druart from comment #28)
 QA comment:
 
 1/ There is no pod in the new file (yes I know, I am not the best person to
 make this remark...).
 
 2/ The license version should be replaced with the GPLv3.
 
 3/ I don't know why but the ajax script is called twice! (maybe can you have
 a look at my patch for bug 9811 where I use a script to populate a table
 with the server side processing method).
 
 Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10730] Use DataTables on the tag review page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Depends on||10649

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Blocks||10730

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10730] New: Use DataTables on the tag review page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10730

Bug ID: 10730
   Summary: Use DataTables on the tag review page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/tags/review.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

The tag review page in the staff client could benefit from having a sortable
table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20281|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20347
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20347action=edit
Bug 10714: Redirect to list contents view upon save after initiating edit from
list contents view

In the staff client, if you initiate a list edit from the list contents
view you should be redirected to that same view after saving your
changes. The OPAC already works this way.

To test, view the contents of an existing list. Click the Edit list
item under the Edit menu. Click save on the list edit form and you
should be redirected back to the contents view of that list.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10714] Redirect to list contents view upon save after initiating edit from list contents view

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10714

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20280|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20348
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20348action=edit
Bug 8324 - Redisplay OPAC list with correct sort after edit

If you are viewing the contents of a list, edit it, change the default
sort, and save your list will be redisplayed sorted by title no matter
what default sort you chose. Lists do not automatically sort by their
default sort, they must be opened with the sort parameter.

This patch adds the list's sort parameter to the redirect after editing.

To test, open an existing list in the OPAC which contains items. Click
the Edit list link at the top of the list contents view. Change the
default sort to something new. Click Save. If the list is redisplayed
using the new default sort the patch worked.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8324] Redisplay OPAC list with correct sort after edit

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #20267|0   |1
is obsolete||

--- Comment #2 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20349
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20349action=edit
Bug 10710: add unit tests for OfflineOperation's routines in C4/Circulation.pm

This patch test AddOfflineOperation,GetOfflineOperation and
DeleteOfflineOperation in C4/Circulation.pm.

The tests are wrapped in a transaction.

Note: Currently, GetOfflineOperations is not tested because we cannot
mock C4::Context-userenv in unit tests

To test:

prove t/db_dependent/Circulation_OfflineOperation.t
t/db_dependent/Circulation_OfflineOperation.t .. ok
All tests successful.
Files=1, Tests=7, 19 wallclock secs ( 0.01 usr  0.01 sys +  0.33 cusr  0.02
csys =  0.37 CPU

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10710] UT : OfflineOperation's routines in C4/Circulation.t need unit tests.

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10710

--- Comment #3 from Galen Charlton gmcha...@gmail.com ---
Created attachment 20350
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20350action=edit
Bug 10710: (follow-up) perltidy new code

Also, I prefer the use of parentheses for function
calls, even when no arguments are being passed.
One missed comma turns

is(GetOfflineOperation, ...)

into

is(GetOfflineOperation ...)

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8609] Add an URL validation plugin for authority and biblio frameworks

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8609

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #4 from Galen Charlton gmcha...@gmail.com ---
Two thoughts:

- I think using Regexp::Common::URI to get the regular expressions would be
easier to maintain.
- What about having the plugin also actively verify that the link is good?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #100 from Tomás Cohen Arazi tomasco...@gmail.com ---
Latest patches have been pushed to 3.12.x, will be in 3.12.4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10197] Add CSS classes to patron info list in patron account

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
This patch has been pushed to 3.12.x, will be in 3.12.4.

Thanks Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10731] New: IntranetSlipPrinterJS is not working for hold slips

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731

Bug ID: 10731
   Summary: IntranetSlipPrinterJS is not working for hold slips
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Hold slips aren't printing automatically with JS Print Setup because it appears
the system preference IntranetSlipPrint is never being passed to the template.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10732] New: use a stricter SQL_MODE

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10732

Bug ID: 10732
   Summary: use a stricter SQL_MODE
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It would be nice to have Koha use a stricter MySQL/MariaDB SQL_MODE. 
Currently, Koha essentially expects that SQL_MODE is NULL.

In particular, STRICT_TRANS_TABLES would add better type checking -- for
example, no more inserting strings into an int field and expecting things to
magically work.

Another mode to consider is NO_ZERO_DATE [2].

It appears that MySQL on OS X ships with SQL_MODE set to a value that includes
STRICT_TRANS_TABLES; a user report indicates that at least one seed data script
cannot be loaded as a consequence. [3]

[1]
http://dev.mysql.com/doc/refman/5.6/en/server-sql-mode.html#sqlmode_strict_trans_tables
[2]
http://dev.mysql.com/doc/refman/5.6/en/server-sql-mode.html#sqlmode_no_zero_date
[3] http://lists.katipo.co.nz/pipermail/koha/2013-August/037031.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips

2013-08-14 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 20351
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20351action=edit
Bug 10731 - IntranetSlipPrinterJS is not working for hold slips

Hold slips aren't printing automatically with JS Print Setup because it
appears the system preference IntranetSlipPrint is never being passed to
the template.

Test Plan:
1) Set up JSPrintSetup
  
http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silently
2) Place a hold
3) Check the item in to capture the hold
4) Click Print and confirm
5) Note the slip does not print automatically
6) Apply this patch
7) Repeat steps 2 through 4
8) Observe that the slip now prints automatically

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >