[Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 --- Comment #1 from Liz Rea --- Created attachment 20545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20545&action=edit Bug 10776 - subscription notification screen has awkward wording to test: - make a subscription available to be notified about - log into the opac, click the subscriptions tab, then More details - click "Subscribe to email notification on new issues" - observe the text without the patch - there seems to be an extra "arrive?" - apply the patch, refresh - wording should flow a bit better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10776] New: Subscription notification screen has awkward wording
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Bug ID: 10776 Summary: Subscription notification screen has awkward wording Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org There is a bit of awkwardness in the wording on the "receive notifications when a new volume of this serial arrives?" screen. Patch incoming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #49 from David Cook --- (In reply to Koha Team Lyon 3 from comment #48) > Hello Fridolyn, > I'm not sure that the patch of bug 6739 has the same goal : > - with this patch we want to prevent renewing if patrons have overdues or > restriction. > - with bug 6739, it wants to prevent renewing if patrons who have a card no > more valid. > > It's not the same behaviour. Can you confirm that I have understood well and > switch back this patch "need signoff" ? > Sonia I agree with Sonia's evaluation of the patches, Fridolyn. It seems like they are doing quite different things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10772] IE7 not loading reset-fonts-grids.css in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 --- Comment #2 from David Cook --- (In reply to Owen Leonard from comment #1) > Official we don't even support "modern" versions of IE, but in practice we > do our best to fix bugs as they are reported. > > I have no interest in making dramatic changes to support IE7, but I don't > object to a conditional comment in doc-head-close.inc targeting < IE7 in > order to load reset-fonts-grids.css: > > That sounds like a reasonable suggestion to me :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #6 from David Cook --- (In reply to Katrin Fischer from comment #5) > Another reason to keep the title might be that you can probably expect the > Z39.50 target to support title search, but probably not all support raw? Mmm, I suppose that's a possibility, although I think the Bib-1 attribute for raw (1016) is fairly ubiquitous. I'm not too fussed either way. I just thought it might be worth raising :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Galen Charlton changed: What|Removed |Added Attachment #11400|1 |0 is obsolete|| CC||gmcha...@gmail.com --- Comment #44 from Galen Charlton --- Comment on attachment 11400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11400 Bug 8089: Use Koha::Cache for all caching Un-obsoleting the latest version of the "Use Koha::Cache for all caching" patch. My aim is to write some test cases and have another go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10733] Memcached on package installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 20544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20544&action=edit Bug 10733: Follow-up - Forgot apache-site.conf.in I just forgot to put the SetEnv definitions there. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10775] New: Create humans.txt from the history document
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10775 Bug ID: 10775 Summary: Create humans.txt from the history document Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Inspired by http://humanstxt.org/ - we should create this so every OPAC has one of these. Just a nice way to (again) recognise the people who contribute and give time/money/resources to Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What|Removed |Added Attachment #20540|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 20543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20543&action=edit Patch to add syspref controlled stopwords to highlighting Followup patch: Adds same stopwords to Staff Client Search Results page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #12 from Martin Renvoize --- That's a relief, I hadn't got a clue why it wasn't working otherwise. Patch coming up to also add the stopwords to the staff client.. to be honest, I'de completely forgotten the staff client also does the highlighting.. looking through it, the code is very inconsistent with the opac method and doesn't apply to the detailed result view, only the search results page. Anywho.. I'll patch the results page as is. Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- Another reason to keep the title might be that you can probably expect the Z39.50 target to support title search, but probably not all support raw? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #11 from Kyle M Hall --- Martin, I've retested and discovered my problem. I had assumed this would affect the staff intranet! It works great in the OPAC. Do you think you could provide a followup to add this functionality to the staff intranet as well? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #10 from Kyle M Hall --- I'm using chrome. Enabling the feature and setting it to "OR|or|Or" did not stop the "or"s in my results from being highlighted. I'll retest and let you know if I find any errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|oleon...@myacpl.org |b...@calyx.net.au OS|Linux |All -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 --- Comment #8 from Owen Leonard --- (In reply to Katrin Fischer from comment #6) > > +[% INCLUDE 'patroncards-batches-toolbar.inc' %] I think this was caused by a merge error following Bug 9697. I have corrected the patch but kept the signoff. I hope that's okay. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9924] Simplify and rename patron card creator error message include
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9924
Owen Leonard changed:
What|Removed |Added
Attachment #17404|0 |1
is obsolete||
--- Comment #7 from Owen Leonard ---
Created attachment 20542
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20542&action=edit
[SIGNED-OFF] Bug 9924 - Simplify and rename patron card creator error message
include
The patron card creator error message include uses a non-standard method
for displaying error messages, and is poorly-named.
This patch converts the method of displaying error messages for various
patron card creator options to the standard one ('') and renames the include file to make it clear that it relates
only to patron card creator operations.
To test, perform various operations:
- Go to 'manage images' and try to upload a file which exceeds the
500KBfile size limit
- Go to the edit batch page and manually append an error code to the
URL: /cgi-bin/koha/patroncards/edit-batch.pl?op=new&error=403
- Go to one of the manage pages and manually append an error code to the
URL:
/cgi-bin/koha/patroncards/manage.pl?card_element=profile&error=201
Correct display of an error message indicates that the include file is
being found.
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7478] Template/translation problem in catalogue_out.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478 Owen Leonard changed: What|Removed |Added Assignee|frede...@tamil.fr |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #48 from Koha Team Lyon 3 --- Hello Fridolyn, I'm not sure that the patch of bug 6739 has the same goal : - with this patch we want to prevent renewing if patrons have overdues or restriction. - with bug 6739, it wants to prevent renewing if patrons who have a card no more valid. It's not the same behaviour. Can you confirm that I have understood well and switch back this patch "need signoff" ? Sonia -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10773] Replace item-level codes with names/descriptions for Label Printing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773 Owen Leonard changed: What|Removed |Added Attachment #20520|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 20541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20541&action=edit Bug 10773 - Replace item-level codes with names/descriptions for Label Printing This patch replaces item-level codes for certain fields so that names and descriptions are printed out instead of codes when using the Label Creator. The fields in question are "ccode", "homebranch", "holdingbranch", "location", and "permanent_location". Test Plan: 1) Edit a layout in the Label Creator so that it includes any of these fields. I suggest including "homebranch" and perhaps "ccode" if you have them in your item data. 2) Add items to a batch in the Label Creator. 3) Export the batch using the layout, and view as PDF 4) Note how the codes for homebranch (and ccode if available) come up instead of the name of the homebranch (and ccode). 5) Apply patch 6) Export the batch again 7) Note how the branch name and category name are now displaying instead of the codes that showed before. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10743] add style to privacy rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10743 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Galen Charlton changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #26 from Galen Charlton --- (In reply to Jonathan Druart from comment #25) > Galen, I change the status to Passed QA. Like that, you will show this > report in your list. > > I can provide unit tests for changed routines but before, I would like to > get your opinion on comment 18-22 and on this change in general. Thanks! My general opinion of the change as a whole: I would hate to lose the foreign key constraints, the change doesn't seem to have any user-visible benefit, and I don't see that the goal of reducing the number of tables involved is worth the risk of regressions. I'm not fond of the use of '*' in issuing rules, either -- I'd rather that NULL be usable to signal "don't care/matches any" and that brancode, itemtype, and categorycode be FKs -- but composite UKs don't enforce uniqueness if one of the values is NULL. We could dispense with the composite PK on issuingrules, perhaps, but then would have to write more code to ensure that duplicate rows couldn't slip in. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 --- Comment #9 from Martin Renvoize --- Thanks for the comments Kyle, I've done as asked with regard to silly mistakes in the sql update files and using the TT Plugin to fetch the preference now. (I didn't realise we had that yet.. oops) As for 'It's not working!', could you elaborate at all? What browser are you using, is javascript enabled (without it highlighting won't work at all)? Cheers Martin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Martin Renvoize changed: What|Removed |Added Attachment #20469|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 20540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20540&action=edit Patch to add syspref controlled stopwords to highlighting Patch updated to reflect Kyles comments: 1. OpacHightlightedStopWords used consistently throughout files 2. TT Plugin used for sysprefs inside the template instead of adding logic to koha pl files where not required. 3. See follow-up comment. Patch also rebased against master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2693] Tagging: Add filter by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 --- Comment #1 from Owen Leonard --- Created attachment 20539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20539&action=edit Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2693] Tagging: Add filter by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #32 from M. de Rooy --- (In reply to Magnus Enger from comment #29) > But isn't it possible to have the same domain available both with and > without HTTPS? So both of these can work at the same time: > http://koha.example.org/ > https://koha.example.org/ > > Then it would seem to be a bad idea to "hard code" the protocol in a > syspref, and better to figure it out on a per request basis, perhaps? Yes, both could be available. I think that bug 10325 can help us out here. It allows you to override a systempreference via koha-httpd.conf. In that case you could override the base url for the https port. At the same time I am wondering if both are available, would it be so bad to let opacbaseurl redirect to one of the two? (Just a pragmatic thought.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2693] Tagging: Add filter by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Hardware|PC |All Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton --- Pushed to master, along with a follow-up to explicitly return from C4::Reports::Guided::delete_report(). Thanks, Kenza and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #25 from Galen Charlton --- Pushed to master. Thanks, Owen and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #15 from Katrin Fischer --- Could you describe domain and origin in a sentence or two? I am really confused what to put in those fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #14 from Matthias Meusburger --- Hi ! The new field previousitemtype is used to automatically set a given item type to the previously received serial (when a new one is received). The fields domain origin and ccode are used to provide statistics, like counting the number of items per domain, origin and ccode. As for the 995l, yes, it should be marc-agnostic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #53 from Kyle M Hall --- (In reply to Katrin Fischer from comment #52) > I fixed a redundant 'my' that the QA script pointed out. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5968] News display on opac-main.pl is particular about browser language settings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5968 Owen Leonard changed: What|Removed |Added CC||frede...@tamil.fr Component|OPAC|I18N/L10N Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Kyle M Hall --- 1) OpacHighlightStopWords is used the database update and sysprefs sql file, but OpacHighlightedStopWords is used everywhere else. 2) Please use the TT plugin function Koha.Preference() to get the preference, rather than passing it it from the perl script 3) It's not working for me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #13 from Katrin Fischer --- Hm, I see now that I had already commented in comment 7... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10460] way to stop a run away report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10460 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall --- This is a pretty complicated process. I think it would require something likes this: a) Add a system preference "StopReports" ( or something similar ) and/or a new staff permission. b) When enabled, running a report would immediately send a partial html page with a "Stop Report" button at the top, along with the PID of the process that is generating the report. c) Clicking the "Stop Report" button would launch another script via ajax which sends the PID to a new script that does nothing but kill processes. d) The script would attempt to kill the process generating the report and send back a confirmation to the requester. e) If the processes cannot be killed, the web page would pop up an alert, if the process was killed successfully, the page would redirect back to the report that had been run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Katrin Fischer changed: What|Removed |Added Blocks|7677| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
Depends on|8435|
Assignee|matthias.meusburger@biblibr |colin.campbell@ptfs-europe.
|e.com |com
QA Contact||koha.sek...@gmail.com
--- Comment #12 from Katrin Fischer ---
Hi Jonathan and Frederic,
could you please add some documentation about the use of the new fields? Also
the commit message states that 995... will be automatically filled. And this is
indeed hardcoded:
+// Also prefilling 995$l
+subfieldid = "subfield" + itemid.substr(4) + "l";
+$("#" + subfieldid + " input[type='text']").val($("#serialseq" +
serialId).val());
+// And prefilling for supplemental issue
+$("#subfieldNEWl input[type='text']").val($("#serialseqNEW").val());
+
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off CC||jonathan.dru...@biblibre.co ||m Depends on||8435 Assignee|colin.campbell@ptfs-europe. |matthias.meusburger@biblibr |com |e.com QA Contact|koha.sek...@gmail.com | --- Comment #11 from Jonathan Druart --- attachment 20537 is a rebased patch. attachment 20538 is the unit tests for GetPreviousSerialid Now this patch depends on bug 8435 (in order to avoir conflicts on the unit tests). Needs QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 Jonathan Druart changed: What|Removed |Added Blocks||7677 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #10 from Jonathan Druart --- Created attachment 20538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20538&action=edit Bug 7677: UT: add unit tests for GetPreviousSerialid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart changed: What|Removed |Added Attachment #16456|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 20537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20537&action=edit Bug 7677: New areas in subscriptions and new functions when receiving. When enabling the makePreviousSerialAvailable syspref, the previously received serial's itemtype is set as defined in the subscription. (Please note that the item-level_itypes syspref must be set to specific item.) It is also made available. You can define the serialsFieldsToAV syspref to associate authorized values to the domain, origin and/or support fields. 995$l is automatically prefilled when receiving. Signed-off-by: Frederic Durand http://bugs.koha-community.org/show_bug.cgi?id=8435 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10772] IE7 not loading reset-fonts-grids.css in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10772 --- Comment #1 from Owen Leonard --- Official we don't even support "modern" versions of IE, but in practice we do our best to fix bugs as they are reported. I have no interest in making dramatic changes to support IE7, but I don't object to a conditional comment in doc-head-close.inc targeting < IE7 in order to load reset-fonts-grids.css: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8435] new permissions on subscriptions "superserials"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435 --- Comment #46 from Jonathan Druart --- Created attachment 20536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20536&action=edit Bug 8435: The unit tests should create the biblio Previous version does not create the biblio. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What|Removed |Added Attachment #20534|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 20535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20535&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #1 from Kyle M Hall --- Created attachment 20534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20534&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10774] New: Allow individual holds to be suspended and resumed from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Bug ID: 10774 Summary: Allow individual holds to be suspended and resumed from the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10625] Inventory/Stocktaking tool cannot handle windows file uploads
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10625 --- Comment #9 from Kyle M Hall --- > Since the use of File::Slurp means loading the entire input barcode file > into memory, this patch also changes the performance characters of the > inventory tool when processing very large files. Admittedly, this may not > be a big deal in practice, but I would appreciate confirmation as to whether > there are barcode scanners or other utilities that are *actually* producing > files that use \r as a delimiter. I agree, that using File::Slurp was also a concern of mine, but one would need to upload a barcode file with hundreds of thousands of barcodes to have a plain text file of any appreciable size, right? I can confirm at least one library is having this issue in practice, as the example file of barcodes was provided by the library having this issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA --- Comment #25 from Jonathan Druart --- Galen, I change the status to Passed QA. Like that, you will show this report in your list. I can provide unit tests for changed routines but before, I would like to get your opinion on comment 18-22 and on this change in general. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What|Removed |Added Attachment #14931|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 20533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20533&action=edit Bug 8369: Followup: indent sql queries in admin/smart-rules.pl Signed-off-by: Kyle M Hall Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart changed: What|Removed |Added Attachment #14930|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 20532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20532&action=edit Bug 8369: Merge tables for circulation rules. This patch adds 3 new tables: - circ_rules - borrower_circ_rules - item_circ_rules It removes 6 tables: - default_borrower_circ_rules - default_branch_circ_rules - default_branch_item_rules - default_circ_rules - branch_borrower_circ_rules - branch_item_rules The goal is to merge circulations rules into 3 tables instead of 6 without add or remove features. Previous behaviours do not change. The wildcard '*' character is a rule for the default values. Then it is possible to merge 2 tables into one if we consider that the default value is the value with a branchcode eq '*'. I removed the foreign key constraint with branchcode and added 3 queries in the C4::Branch::DelBranch routine in order to remove records about a deleted branch. Signed-off-by: Kyle M Hall Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 --- Comment #4 from Fridolyn SOMERS --- (In reply to David Cook from comment #3) > Perhaps "Title" makes the most sense, as people might be more likely to > search for titles using the simple search than anything else? It makes sense for me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Jonathan Druart changed: What|Removed |Added CC||koha.sek...@gmail.com --- Comment #111 from Jonathan Druart --- *** Bug 3681 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3681] No bimonthly frequency option for serials subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3681 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED CC||jonathan.dru...@biblibre.co ||m Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- Will be fixed by bug 7688. *** This bug has been marked as a duplicate of bug 7688 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #37 from MJ Ray (software.coop) --- "I find strange to pay again to fix a feature broken by somebody's code 2 or 3 years ago." - ah well, this happens with most software, where a feature is added without a good-enough test set for it, or where some other design change is seen as desirable enough to be breaking other features, which is maybe what happened here (security is good). Customers are paying for this sort of maintenance in other software - some developers joke "plan to throw one away - you will anyway" - and it's just more visible in open software like Koha. So if this feature is readded (maybe with a task-runner script something like drupal's cron.php, maybe with a proper cronjob), it should be added with some test to help avoid breaking it again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook --- The only thing I wonder about is whether the contents of the simple search should go into "Title" or "Raw (any)", since "Raw" is more of a "keyword" search. I looked a bit at how to make it go into "Raw (any)" instead of "Title" but couldn't get it to work so I guess it would require more poking around. Perhaps "Title" makes the most sense, as people might be more likely to search for titles using the simple search than anything else? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart changed: What|Removed |Added Attachment #20515|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 20530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20530&action=edit Bug 10761:UT:save_report and delete_report in C4::Reports::Report_Guided.pm need unit tests The test are wrap in a transaction. Note : The last test (in comment) currently doesn't pass because it needs some modifications of delete_report. To test: prove t/db_dependent/Reports_Guided.t t/db_dependent/Reports_Guided.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.28 cusr 0.02 csys = 0.32 CPU) Result: PASS Signed-off-by: Katrin Fischer Works nicely, tested with patch for bug 10761 applied. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 --- Comment #6 from Jonathan Druart --- Created attachment 20531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20531&action=edit Bug 10761: UT: Improvement for Reports_guided.t 1/ delete_report should return undef is no parameter is given. 2/ delete_report returns the number of affected rows. 3/ delete_report should be tested with 1 and more parameters. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742 David Cook changed: What|Removed |Added Attachment #20409|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 20529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20529&action=edit Bug 10742 - simple search to z39.50 search keeps index In intranet, when search does not return results, there is a button to perform the same search on Z39.50 servers. This works well when coming from advanced search. But when using simple search from header, in the Z39.50 search box "kw,wrdl" is added to the operand in title. This patch simply adds kw as default value when the cgi does not have idx parameter. Test plan : - In intranet, perform a search from header that does not return any result. For example "afalseword" - Click on "Z39.50 Search" => you get a popup with the searched word in title. For example : Title: afalseword - Go to advanced search page - Enter the same word into first input and submit - Click on "Z39.50 Search" => you get a popup with the searched word in title. Signed-off-by: David Cook Patch works as described. This is much nicer than before. Thanks, Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10761] UT: saved_report and delete_report in C4::Reports::Report_Guided.pm need unit tests.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10761 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA CC||jonathan.dru...@biblibre.co ||m QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #4 from Jonathan Druart --- QA comment: I found some improvements for this routine, I will submit a qa followup. If the $sth->finish statement is removed (see bug 3134 comment 24), it is possible to know how many rows are affected by the DELETE query. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #21 from Jonathan Druart --- Created attachment 20525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20525&action=edit Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Katrin Fischer This works really nicely, passes all tests and the QA script. There is one little thing to note: If you delete a single report using the option from the menu, the line you want to delete is highlighted in red. It would be nice to do that also for deleting multiple reports. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #23 from Jonathan Druart --- Created attachment 20527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20527&action=edit Bug 3134: ID and Report name columns are not well sorted. The sort for ID is alpha instead of numerical, same for the report names. To test: create id=1, name=Report 1 create id=2, name=Report 2 create id=10, name=Report 10 create id=11, name=Report 11 Sorting by id: without this patch 1, 10, 11, 2 with this patch: 1, 2, 10, 11 Sorting by name: without this patch: Report 1, Report 10, Report 11, Report 2 with this patch: Report 1, Report 2, Report 10, Report 11 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart changed: What|Removed |Added Attachment #20516|0 |1 is obsolete|| Attachment #20517|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 20524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20524&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #24 from Jonathan Druart --- Created attachment 20528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20528&action=edit Bug 3134: Reindent delete_report The first patch add a bad indentation for this routine. This patch fixes that. The $sth->finish statement is useless and should be removed. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #22 from Jonathan Druart --- Created attachment 20526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20526&action=edit Bug 3134: Add the warn class on tr elements This patch adds the same behavior when deleting 1 or more reports. When checkboxes are checked and the "delete selected" button is pressed, checked lines are hightlighted in red. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3134] Ability to select multiple reports to delete at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m --- Comment #19 from Jonathan Druart --- QA comment: These patches add the ability to delete multiple reports. The second one fixes the ergonomic issue (described in comment 14). I will provide 3 followups: 1/ Fix the following issue: (In reply to Katrin Fischer from comment #18) > There is one little thing to note: If you delete a single report > using the option from the menu, the line you want to delete > is highlighted in red. It would be nice to do that also for > deleting multiple reports. 2/ Fix the sort on id and report name 3/ Reindent the delete_report routine (shouldn't it be delete_reports?) and remove the $sth->finish statement. Note for RM: feel free to push only the 2 first patches and to ask for a new report for the 3 followups. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 David Cook changed: What|Removed |Added Attachment #20322|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 20523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20523&action=edit Bug 10721 - Improve DataTables configuration on transfers to receive report I noticed this template used a hidden span to allow correct sorting of titles--a relic of the previous table sorting plugin. I have removed that and added an improved DataTables configuration. To test apply the patch and view the transfers to receive report for a library which has multiple transfers to receive. Sorting should work correctly on all columns, including correct date sorting regardless of dateformat system preference. Title sorting should correctly exclude articles. Signed-off-by: David Cook There is no observable difference. The funcitonality is still there. I notice the hidden span is gone when I look at the source. Looks good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10721] Improve DataTables configuration on transfers to receive report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10656] shelving locations not alpha on search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10656 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9782] Cancel button doesn't work when importing MARC bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9782 David Cook changed: What|Removed |Added Attachment #20355|0 |1 is obsolete|| --- Comment #2 from David Cook --- Created attachment 20522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20522&action=edit Bug 9782 - Cancel button doesn't work when importing MARC bibliographic frameworks When importing frameworks the "cancel" button should be hidden once an import is initiated since it is not possible to cancel the import in progress. This patch uses this bug as an excuse to replace the old import/export pop-ups with modal dialogs for all import/export functions. To test: - Try exporting both the default framework and at least one other framework. - Try importing both a default framework and at least one other framework. - When importing, observe that the modal dialog controls are hidden as soon as the import is initiated. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
