[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use ti, phr indexes like other linking entries

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793

David Cook  changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #2 from David Cook  ---
Just changing this away from an enhancement to "minor" as it's really more of a
bug fix than an enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

--- Comment #13 from David Cook  ---
(In reply to David Cook from comment #12)
> Mohammad Nashbat's comment on the listserv is also interesting:
> 
> "I’m trying to upload a deletion batch from ebrary to our Koha LMS, this
> batch changes the records status in the leader tag to “d” delete, which used
> to delete the bib records using our old library system “Dynix” after
> indexing. But now in Koha it do change the status but without deleting the
> bib records even  after indexing, am I missing something?"
> 
> I think at a bare minimum records with a "d" need to be suppressed in the
> OPAC. 
> 
> However, actual deletions...I'm not sure what I think of this "batch
> deletion" idea. I haven't done a lot yet with MARC dumps from vendors like
> EBSCO, but I could see how re-uploading records with a "d" in the leader to
> do a batch delete might be an idea. 
> 
> While it's only tangentially related to this discussion, I wonder what sorts
> of best practices people have for maintaining MARC records in Koha that come
> from electronic service providers (for services like electronic journals and
> e-books). 
> 
> We have a homecooked solution here that my boss takes care of but I wonder
> what the optimal way of doing it would be. 
> 
> I'm sure people in a union catalogue situation/those who use OCLC or other
> interconnected cataloguing tools must also encounter situations where the
> original record has changed and now they either need to update or delete
> their existing records.
> 
> (I know this is a problem I've also encountered in developing the OAI-PMH
> harvester. It seems like it could be a pervasive issue.)

Jared Camins-Esakov has mentioned that using the import/revert features in
Koha, a person could revert a batch of MARC records from an electronic
subscription, then just import the latest full reload file. That seems to me to
be a very reasonable solution. The only problem would be if someone added items
to those records, but as he pointed out...with a large enough load (say 50k
records), the likelihood of items being added is probably fairly low.

That said, I think some of our libraries have items automatically added to some
of their electronic holdings. However, perhaps that's a practice that should
just be eliminated, since the process Jared describes seems quite robust.

In the case where you unsubscribe from a subscription, you'd just revert your
records and that's that. So long as you have a full MARC record dump, you're
covered for additions/updates/deletes.

--

In the union catalog/online cataloging tool scenario, additions/updates
shouldn't be much of a problem (provided that there haven't been local
changes), but I imagine that deletes are still an issue...and that perhaps you
would still want a record marked "d" in your catalogue (although not in your
OPAC).

Ok. That's it from me. Sorry for spamming all of you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

--- Comment #12 from David Cook  ---
Mohammad Nashbat's comment on the listserv is also interesting:

"I’m trying to upload a deletion batch from ebrary to our Koha LMS, this batch
changes the records status in the leader tag to “d” delete, which used to
delete the bib records using our old library system “Dynix” after indexing. But
now in Koha it do change the status but without deleting the bib records even 
after indexing, am I missing something?"

I think at a bare minimum records with a "d" need to be suppressed in the OPAC. 

However, actual deletions...I'm not sure what I think of this "batch deletion"
idea. I haven't done a lot yet with MARC dumps from vendors like EBSCO, but I
could see how re-uploading records with a "d" in the leader to do a batch
delete might be an idea. 

While it's only tangentially related to this discussion, I wonder what sorts of
best practices people have for maintaining MARC records in Koha that come from
electronic service providers (for services like electronic journals and
e-books). 

We have a homecooked solution here that my boss takes care of but I wonder what
the optimal way of doing it would be. 

I'm sure people in a union catalogue situation/those who use OCLC or other
interconnected cataloguing tools must also encounter situations where the
original record has changed and now they either need to update or delete their
existing records.

(I know this is a problem I've also encountered in developing the OAI-PMH
harvester. It seems like it could be a pervasive issue.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

--- Comment #11 from David Cook  ---
(In reply to Colin Campbell from comment #10)
> In the past I've come across sites whose databases included a fair propotion
> of records with deleted status in the header, often imported from some
> external source. I'm wondering why you would flag recs in the koha db as
> deleted rather than delete them straight out

I decided to do a quick web search on this topic and here is the first thing I
stumbled across:

"Whether you perform the conversion or we do, consider whether you wish to
retain MARC records carrying the delete flag ("d"  in Leader/05). You may need
to retain these for reporting purposes if your database is part of a union
catalog."

http://www.itsmarc.com/UpgradingFromITS.asp

I imagine that this might be the use case that Katrin was mentioning. 

-- 

Perhaps it would be an institutional policy for library techs to mark a record
as deleted but only "authorized" librarians are allowed to delete the record?

Sort of following along the lines of the ideas mentioned here:
http://www.lib.berkeley.edu/asktico/procedures/deletion-bibliographic-record

--

In the MARC Authority record context, there are actually several different
"deleted" flags such as "s" and "x" which have different reasons attached to
them. 

http://www.loc.gov/marc/authority/adleader.html

d - Deleted
Used when neither code s nor code x is applicable, or when an organization
chooses not to use code s or x.
Some level of manual intervention may be needed to effect the change in
bibliographic records because the deleted heading may or may not be carried as
a 4XX See From Tracing field in other authority records and a 682 field
explaining the delete may be present in the record marked for deletion.

s - Deleted; heading split into two or more headings
Record has been deleted from a file because the heading has been split into two
or more headings, requiring a new authority record for each. The heading from
the deleted record is included in each of the new authority records as a
tracing in a 4XX See From Tracing field. This specialized delete value supports
use of automated systems to carry out any necessary reviews, since when a
heading is split, a computer cannot automatically replace the old heading in
bibliographic records.

x - Deleted; heading replaced by another heading
Record has been deleted from a file and that a new authority record in which
the heading from the deleted record appears as a 4XX See From Tracing field has
been added to the file. (In a system where authority control is linked to the
bibliographic file, a computer can effect the one-to-one replacement indicated
by code x without manual intervention.)

Apparently there is also a code "o" for obsolete but not deleted.

http://www.itsmarc.com/crs/mergedProjects/helpauth/helpauth/idh_leader_05_auth.htm

A person can also use the 682 to provide a reason apparently. 

http://www.loc.gov/marc/authority/ad682.html


Admittedly, the Authority context might not be relevant to this discussion
because it talks about automatic/manual updating of Bibliographic records. But
if you're deleting Bibliographic records...you wouldn't need to worry about a
trickle down effect (except in the case where its linked to another using 7xx
linking fields, but that's a whole 'nother can of worms).

--

In the end...I wonder if it's best to:

1) Not display "deleted" records in the OPAC
2) Have a label saying "deleted" in the staff client
3) Perhaps have a cronjob to clean out "d" records, but only at the behest of a
library administrator. It seems that having this cronjob active by default
might cause issues if only at a policy level (which is an extremely important
level in libraries)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10827] List of holds does not update correctly

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

bondiurbano  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10831] New: QueryParser requires that defaultSortField and defaultSortOrder be set to non-NULL values

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10831

Bug ID: 10831
   Summary: QueryParser requires that defaultSortField and
defaultSortOrder be set to non-NULL values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org

If QueryParser is enabled, the system preferences
defaultSortField/defaultSortOrder (and their OPAC kin
OPACdefaultSortField/OPACdefaultSortOrder) should not be set to NULL values. 
Otherwise, for searches where the sort order is not explicitly specified (e.g.,
searches made from the staff and OPAC global search box), the search can fail.

This is due to several slightly questionable coding constructs collaborating in
the confusion of both the user and the developer:

[1] If a default sort order is not set, catalogue/search.pl and
opac/opac-search.pl can end up setting the @sort_by array to (undef).  This is
because of the construct

@sort_by = $cgi->param('sort_by');

If the sort_by CGI parameter is not passed, the result is not an empty array,
it's an array containing one element whose value is undef.

[2] The following code in C4::Search::parseQuery in turn uses @sort_by to add
QP modifiers:

if ( scalar(@sort_by) > 0 ) {
my $modifier_re =
  '#(' . join( '|', @{ $QParser->modifiers } ) . ')';
$query =~ s/$modifier_re//g;
foreach my $modifier (@sort_by) {
$query .= " #$modifier";
}
}

If the query is "history", the modified version becomes "history #" ... which
in turn results in a query that will not make sense to Zebra.

One solution is to push through a DB update that extends the fix for bug 8012
to  set the system preferences to sensible default values (probably relevance
descending) if they're currently NULL.  Note, by the way, that this means that
the bug manifests itself only in databases old enough to have been created
before the patch for bug 8012 was pushed.

Another part of the solution, however, ought to be make the code in question a
little more robust.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5544] All Notices from Branch Email Address

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

--- Comment #16 from Kyle M Hall  ---
Created attachment 20807
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20807&action=edit
Bug 5544 - All Notices from Branch Email Address - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5544] All Notices from Branch Email Address

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #14 from Galen Charlton  ---
Pushed to master.  Thanks, Marcel!

I note that the RUN_DATABASE_TESTS bits still left in Makefile.PL currently
stand unused, but since they provide a hook for work that Jonathan is doing, I
think they should stay in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828

--- Comment #2 from Pedro Ferreira  ---
Created attachment 20810
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20810&action=edit
blank pdf file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649

Galen Charlton  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649

Galen Charlton  changed:

   What|Removed |Added

  Attachment #20714|0   |1
is obsolete||

--- Comment #14 from Galen Charlton  ---
Comment on attachment 20714
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20714
[PASSED QA] Bug 10649 - Upgrade DataTables and move scripts out of theme
directory

Setting back to assigned as this is an omnibus bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #13 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #9 from Owen Leonard  ---
(In reply to Owen Leonard from comment #8)
> There is a problem with the OPAC non-XSLT detail page.

This is fixed: on a non-XSLT detail page, with OPACPopupAuthorsSearch enabled,
search term selection is now performed from a modal dialog rather than a pop-up
menu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828

Pedro Ferreira  changed:

   What|Removed |Added

  Attachment #20810|0   |1
is obsolete||

--- Comment #3 from Pedro Ferreira  ---
Created attachment 20811
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20811&action=edit
blank pdf file

Batch file created from this record

http://catalogobib.cm-portel.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=2293


catalogobib.cm-portel.pt is our Municipality public library link

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10027] Fine details not showing when printing a fine

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027

--- Comment #6 from Kyle M Hall  ---
Created attachment 20812
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20812&action=edit
Bug 10027 - Fine details not showing when printing a fine - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10027] Fine details not showing when printing a fine

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Kyle M Hall  changed:

   What|Removed |Added

Version|3.8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7898] Browse Results is easily confused

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7898

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Martin Renvoize  ---


*** This bug has been marked as a duplicate of bug 10829 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #14814|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 20808
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20808&action=edit
Bug 7595 - Add branchcode to accountlines

Adds a branchcode column to the accountlines table. For payments,
this inserts the branchcode of the library where the payment was
recorded. For manual invoices, it insert the branchcode of the
library where the manual invoice was created.

Signed-off-by: Nicole C. Engard 

I tested with creating manual invoices, and paying partial fines,
entire fine lines, and writing off fines. All actions record the branch
where the action took place properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10830] New: Add schema.org microdata for UNIMARC

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10830

Bug ID: 10830
   Summary: Add schema.org microdata for UNIMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

Bug 6594 add schema.org microdata for MARC21. This bug will do the same for
UNIMARC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Martin Renvoize  changed:

   What|Removed |Added

 CC||m...@software.coop

--- Comment #2 from Martin Renvoize  ---
*** Bug 7898 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7595] Add branchcode to accountlines

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #14815|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 20809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20809&action=edit
Bug 7595 - Add branchcode to accountlines - Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6594] Add schema.org microdata

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594

--- Comment #15 from mathieu saby  ---
And I added Bug 10830 for Unimarc.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10649] Upgrade DataTables and move scripts out of theme directory

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10649

--- Comment #15 from Galen Charlton  ---
Owen, I just looked at the bugs that you marked this one as blocking.  I'll
leave it to you to indicate whether you want this one set back to 'pushed to
master' (in which case, please open bugs for the remaining modules that need
the new DataTables).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

--- Comment #19 from Kyle M Hall  ---
Created attachment 20806
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20806&action=edit
Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA
Followup 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792

--- Comment #1 from Galen Charlton  ---
Created attachment 20805
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20805&action=edit
Bug 10792: fix sorting of funds table on acquisitions home page

This patch introduces a DataTables sorting plugin, title-numeric,
for sorting cells based on a decimal number embedded in a span title
attribute.  This allows currency amounts to be formatted properly
for display without having to writing a sorting plugin that's
super-smart about removing the formatting, particularly for locales
that use a comma as the decimal mark.

The sorter plugin can be used like this:

- In the DataTables config:

"aoColumns": [
   { "sType": "title-numeric" },
]

- In the table data


[% formatted currency %]


To test:

[1] Go to the acquisitions home page.  Note that changing the sort order
on the amount, ordered, spent, or avail columns results in incorrect
sorting that is either ASCII-betical or which ignores any component
of large numbers that occur after the thousands separator.
[2] Apply the patch.
[3] Verify that the sorting now works correctly and that no JavaScript
errors appear in the JS debug console of your choice.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792

Galen Charlton  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5725] Batch modifications for Biblios

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725

Pierre Angot  changed:

   What|Removed |Added

 CC||tredok.pie...@gmail.com

--- Comment #76 from Pierre Angot  ---
If someone can repair it, we can test it next week.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #13 from Galen Charlton  ---
(In reply to Srdjan Jankovic from comment #7)
> A philosophical question - changes like this, consisting of only removing
> unused/unwanted code, can those be self-signed, and go to QA directly?

A philosophical answer -- no, for two reasons.  If a patch removes an unused
something, having at least two pairs of eyes can help verify that (a) the
something was in fact unused and (b) the something was /completely/ removed. 
Second, it gives folks time to jump in case they question the removal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10426] Remove unused sub GetCcodes from C4::Koha

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426

--- Comment #9 from Galen Charlton  ---
One of the dependent bugs has been pushed to master, leaving bug 10771, which
needs signoff.  I encourage anybody interested in seeing this patch get pushed
to review the patches for 10771.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #10 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817

--- Comment #3 from Colin Campbell  ---
Created attachment 20804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20804&action=edit
Test script

This script can be used to test the patch. Set up a user with some holds. Set
up the configuration in the script and the script should setup a tcp socket
connection to the designated server and will output the requests and responses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10829] Browse across pages breaks for authority searches

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe
   ||.com

--- Comment #1 from Martin Renvoize  ---
Created attachment 20803
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20803&action=edit
Bug 10829 - Browse across pages breaks for authority searches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828

--- Comment #1 from Chris Nighswonger  ---
We'll need a little more information to determine if this is a bug or a problem
with data corruption during your upgrade.

Please attach the following:

1. A pdf file created from your installation which is "blank."

2. Some marc records with the items used on the "blank" form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10829] New: Browse across pages breaks for authority searches

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Bug ID: 10829
   Summary: Browse across pages breaks for authority searches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

OK.. this one was hard to replicate, even harder to trace/debug, but relatively
simple to fix!

Test plan
1. Do an authority search in the OPAC (A search for 'an:49' perhaps.. that
should bring up results for authority number 49, hopefully there are multiple
pages of results, if not try again and find one that gives you multiple pages
of results)
2. Click the final result on any page of results (there must be more results to
follow for this to work)
3. Try clicking the 'Next' button in the 'Browse results' pane on the right of
the page.
4. It should take you to the next result in the search list (i.e the first
result from the next page of results)  Double check it is correct, we found
that it was often not.

5. Apply patch and run same process, this time you should get the correct
paging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #21 from Martin Renvoize  ---
Also noted that these highlighting systems are out of sync between opac and
staff client, including the lack of staff client code for Bug 10686.

Once I've got this bit out of the way, I'm tempted to submit that as a speerate
bug and patch.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10828] Label creator returns empty pdf, xml or csv file

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828

Pedro Ferreira  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10828] New: Label creator returns empty pdf, xml or csv file

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10828

Bug ID: 10828
   Summary: Label creator returns empty pdf, xml or csv file
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label printing
  Assignee: cnighswon...@foundations.edu
  Reporter: pedro.m.ferre...@mail.cm-portel.pt
QA Contact: testo...@bugs.koha-community.org

In "LABEL CREATOR" i choose "NEW BATCH" then "ADD ITEM(S)".
In "Search for items to add to Batch ", i can sucessfully search for an item
and then i can select it to add to the batch. 

I click the "EXPORT BATCH", and then i select the template and the layout. It
is from this point that i detect some problems.

When i choose the "Download as PDF" I always get an empty PDF FILE. No labels
are created

In the error log from apache i have the following messages


[Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep  5 15:23:43
2013] label-create-pdf.pl: "my" variable $template masks earlier declaration in
same scope at /var/www/koha3.12/intranet/cgi-bin/labels/label-create-pdf.pl
line 63., referer:
http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl

[Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep  5 15:23:43
2013] label-create-pdf.pl: regexp failed to match string:  at
/var/www/koha3.12/lib/C4/Labels/Label.pm line 138., referer:
http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl

[Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep  5 15:23:43
2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern
match (m//) at /var/www/koha3.12/lib/C4/Labels/Label.pm line 160., referer:
http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl

[Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep  5 15:23:43
2013] label-create-pdf.pl: Use of uninitialized value $parts[-1] in pattern
match (m//) at /var/www/koha3.12/lib/C4/Labels/Label.pm line 160., referer:
http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl

[Thu Sep 05 15:23:43 2013] [error] [client 213.228.143.2] [Thu Sep  5 15:23:43
2013] label-create-pdf.pl: regexp failed to match string:  at
/var/www/koha3.12/lib/C4/Labels/Label.pm line 165., referer:
http://catalogobib.cm-portel.pt:82/cgi-bin/koha/labels/label-print.pl


I Have KOHA 3.12 and i migrate the Database from version 3.0.6.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Martin Renvoize  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #20715|0   |1
is obsolete||

--- Comment #20 from Martin Renvoize  ---
Created attachment 20802
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20802&action=edit
Bug 6149 - Stopwords for Result Highlighting

Rebased again, and taken Jonathans comments into account.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #19 from Martin Renvoize  ---
Hi Jonathan

(In reply to Jonathan Druart from comment #18)
> It does not work neither for me on the staff interface. Try to use the Koha
> plugin at the top of the results.tt file ([%  USE Koha %]).

Thanks for the heads up regarding calling the Koha plugin in results.tt, I've
now added this and tested. Seems to be working as expected to me.

> Moreover, I think it would be great to have the list of stopwords case
> insensitive, in order to avoid to list all variants (The, the, THE).

I've now taken this into account too, making it case insensitive was a great
idea!

Patch to follow. . .

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

Paola Rossi  changed:

   What|Removed |Added

 CC|paola.ro...@cineca.it   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #20765|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 20801
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20801&action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

Paola Rossi  changed:

   What|Removed |Added

  Attachment #19265|0   |1
is obsolete||

--- Comment #19 from Paola Rossi  ---
Created attachment 20800
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20800&action=edit
sign off of the bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817

Colin Campbell  changed:

   What|Removed |Added

  Attachment #20777|0   |1
is obsolete||

--- Comment #2 from Colin Campbell  ---
Created attachment 20799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20799&action=edit
Revised patch

Revised the patch to deal with a compile time error thrown by older (no longer
supported) versions of perl. (unfortunately debian ships one of these)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10827] New: List of holds does not update correctly

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10827

Bug ID: 10827
   Summary: List of holds does not update correctly
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When an item has many patron's holds and it is checked-in, the first priority
patron hold in the list of holds is set as "waiting". Then when this hold
expires o is cancelled the hole list of holds doesn't update: the next patron
in the list of holds "keeps on hold" but not "waiting" and no email is inserted
in the message queue table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10421] Add cron script to delete deleted records

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #10 from Colin Campbell  ---
In the past I've come across sites whose databases included a fair propotion of
records with deleted status in the header, often imported from some external
source. I'm wondering why you would flag recs in the koha db as deleted rather
than delete them straight out

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10821] label pdf adding in strange breaking

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821

--- Comment #6 from Nicole C. Engard  ---
LCC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10826] Add schema.org microdata for NORMARC

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10826

Magnus Enger  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6594

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6594] Add schema.org microdata

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594

Magnus Enger  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10826

--- Comment #14 from Magnus Enger  ---
I have added "Bug 10826 - Add schema.org microdata for NORMARC"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10826] New: Add schema.org microdata for NORMARC

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10826

Bug ID: 10826
   Summary: Add schema.org microdata for NORMARC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: mag...@enger.priv.no
  Reporter: mag...@enger.priv.no
QA Contact: testo...@bugs.koha-community.org

Bug 6594 add schema.org microdata for MARC21. This bug will do the same for
NORMARC. Since NORMARC is *mostly* a subset of MARC21 it should not be too
hard, I hope.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6149] Operator Highlighted in Search Results

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #17)
> Could you give any errors you see if it's really not working?

Hi Martin,

It does not work neither for me on the staff interface. Try to use the Koha
plugin at the top of the results.tt file ([%  USE Koha %]).
Moreover, I think it would be great to have the list of stopwords case
insensitive, in order to avoid to list all variants (The, the, THE).

Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737

--- Comment #9 from Jonathan Druart  ---
Created attachment 20798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20798&action=edit
Bug 10737: The new column 'Closed' should be sortable.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #20687|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  ---
Created attachment 20797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20797&action=edit
Bug 10737 [Revised] Add "Add to basket" link on vendor search results page

This patch adds an "add to basket" link to the vendor search results
page for each open basket associated with each vendor. Clicking it
triggers a modal window with the "add to basket" choices for that vendor
and basket.

Other changes in this patch:

- The add-to-basket include has been modified in order to make it more
  useful in this context.
- booksellers.pl has been modified to check for an existing budget so
  that the add-to-basket include can properly display a warning if there
  are none.
- "New basket" and "Receive shipment" buttons associated with each
  vendor search result have been converted to Bootstrap-styled buttons.
- Basket closed date has been moved into its own column so that the
  table can be sorted by that value.
- Table columns containing dates now use the "title-string" sort option,
  eliminating the need for a special date sorting algorithm.
- Converted some &'s to &'s

To test, apply the patch and search for a vendor. For each vendor in
your search results baskets which are open should include an "add to
basket" link. Clicking it should open a modal dialog with the same "add
to basket" options offered on the basket page. The correct vendor ID and
basket number should be associated with each link.

The newly-styled "new basket" and "receive shipment" buttons should work
correctly. Table sorting should work correctly, including the new
"closed" column.

Since the add-to-basket include file was modified, the "add to basket"
button on the basket view page should also be tested (acqui/basket.pl).

Signed-off-by: Campbell Reid-Tait 
Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search results page

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co
   |y.org   |m

--- Comment #7 from Jonathan Druart  ---
QA comment:

Thanks for this second patch: all works as expected and there is not duplicated
code.
Note that the Closed column is not sortable, I will provide a followup.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #20787|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  ---
Created attachment 20796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20796&action=edit
Bug 10539: Followup for removing KohaTest unit tests

Makefile.PL: Section for creating file t/test-config.txt removed.
Removes t/Makefile and t/rewrite-config-test too.
Modifies XISBN.t to remove two commented lines.

Test plan:
Grep for KohaTest, database_dependent, config-test, t/Makefile.
Run perl Makefile.PL and include running the test suite.
This may fail on t/00-valid-xml.t and t/QueryParser.t, but that is not the
result of this patch. Same for t/00-load.t with potential error on
Koha::Plugins::Base.
I had this result:

Test Summary Report:
t/00-valid-xml.t  (Wstat: 1792 Tests: 381 Failed: 7)
  Failed tests:  10, 30-31, 169, 181, 201-202
  Non-zero exit status: 7
t/QueryParser.t   (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=92, Tests=12385, 45 wallclock secs ( 1.74 usr  0.15 sys + 26.61 cusr 
1.92 csys = 30.42 CPU)
Result: FAIL
Failed 2/92 test programs. 7/12385 subtests failed.

Signed-off-by: Jared Camins-Esakov 
All tests pass, and I find no mention of the removed test code.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #20786|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  ---
Created attachment 20795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20795&action=edit
Bug 10539: Remove unused unit tests in lib/KohaTest

This patch removes all files in lib/KohaTest and the associated script
t/db_dependent/database_dependent.pl.
The second patch deals with a few consequences.

Note that bug 10540 has been opened to save some interesting code from these
unit tests and inject them in the currently used t/db_dependent suite.

Test plan:
See second patch.

Signed-off-by: Jared Camins-Esakov 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10539] Remove unused unit tests in lib/KohaTest

2013-09-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10539

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #10 from Jonathan Druart  ---
QA comment:

This patch is consistent with the current work in progress on unit tests.
The KohaTest is obsolete, unused, buggy, etc.
The interesting code can be retrieve from the git log.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/