[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #99 from Katrin Fischer  ---
Created attachment 21696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21696&action=edit
... and no pending orders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #98 from Katrin Fischer  ---
Created attachment 21695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21695&action=edit
my orders...

Maybe someone spots something I don't see?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #97 from Katrin Fischer  ---
Hi Pierre, thanks :) What I am trying to do is check the update procedure - but
I am still stuck with receiving orders. I will try again tonight to see what's
going wrong in my installation. It puzzles me quite a bit! Have you tested with
AcqCreateItems "on order"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Pete  changed:

   What|Removed |Added

 CC||pgsengst...@wisc.edu

--- Comment #5 from Pete  ---
Martin, have you made any headway on shib in 3.12?  We're also hoping to get
this running.  Thanks!

-Pete

(In reply to Martin Renvoize from comment #4)
> I'm interested in testing either/both of these patches, and have grabbed a
> copy of Matthias's code for a start and rebased it onto 3.12 (I don't think
> it would be too difficult to rebase onto master, but 3.12 was what I had to
> hand).
> 
> Could one of your put up a test plan please, including any apache steps
> you've undertaken?
> 
> Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #96 from Pierre Angot  ---
Well, it works on sandbox 3 ^^

Test plan :
- Add 2 orders, first with 3 items, second with 2
- Receive 2 of the first order
- cancel one order
- search order

Results :
- isbn : ok (isbn 10 and 13)
- author : ok
- title : ok, even if it is partial
- fund : ok
- basket : ok
- basketgroup : ok
- Bookseller invoice : ok, but label is not correct, it works with invoice
name, not number
- order status : ok for all

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #93 from sandbo...@biblibre.com  ---
Created attachment 21692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21692&action=edit
Bug 5336: Add unit tests for 3 acq routines

Unit tests In C4::Acquisition for:
- CloseBasket
- ReopenBasket
- GetBiblioCountByBasketno
Signed-off-by: Cedric Vita 

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #95 from sandbo...@biblibre.com  ---
Created attachment 21694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21694&action=edit
Bug 5336: Change numbers with understandable codes for orderstatus

This patch uses understandable codes instead of magical numbers for the
aqorders.orderstatus field.

+ execute sql queries in unit tests into a transaction.

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #94 from sandbo...@biblibre.com  ---
Created attachment 21693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21693&action=edit
Bug 5336: QA followup

- fix capitalization
- fix update database message

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #91 from sandbo...@biblibre.com  ---
Created attachment 21690
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21690&action=edit
Bug 5336: Late orders search: don't display deleted order.

Test plan:
Check that deleted orders are not listed in the late orders search
results.
Signed-off-by: Cedric Vita 

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20898|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #92 from sandbo...@biblibre.com  ---
Created attachment 21691
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21691&action=edit
Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by:
Cedric Vita 

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #90 from sandbo...@biblibre.com  ---
Created attachment 21689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21689&action=edit
Bug 5336:Order search (search and UI enhancements)

You can now search orders by
- order status
- fund

New field aqorders.orderstatus, it can contains following values:
  0 => New
  1 => Ordered
  2 => Partial
  3 => Complete
  4 => Deleted

To test: Search and check if results are consistent in histsearch.pl
Signed-off-by: Cedric Vita 

Signed-off-by: Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20897|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20899|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20896|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20895|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #20894|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #89 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Pierre Angot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #88 from Pierre Angot  ---
I can't test on sandbox, there is something wrong with them. I'm waiting for
Jonathan ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10980] New: purchase suggestion doesn't always show

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10980

Bug ID: 10980
   Summary: purchase suggestion doesn't always show
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I have noticed that the 'not finding what you're looking for make a purchase
suggestion' box doesn't appear consistently. I have to admit I don't have much
information on what could be causing this but I wanted to report the issue. 

What I've seen is that on all opacs I've tested the link shows at the bottom of
some searches and not others - and it shows on some 'no results found' pages
and not others.  This is all on one system - not that it works on some and not
others - that it's inconsistent within one system depending on what you search
for and where you search from.

This is with CCSR on Koha 3.12.4 and master in Firefox on Mac & Windows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #20620|0   |1
is obsolete||

--- Comment #3 from Srdjan Jankovic  ---
Created attachment 21688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21688&action=edit
bug_10781: Removed ILSDI::Utility

Test:
This should be a noop. Regression testing required:
/cgi-bin/koha/ilsdi.pl functioanality, in particuler:
GetAvailability - ?service=Describe&verb=GetAvailability
AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron

ILS-DI syspref must be turned on

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time in "from" argument

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824

--- Comment #7 from David Cook  ---
(In reply to Srdjan Jankovic from comment #6)
> Not nitpicking or anything, just curious: why adding T...Z string just to
> strip it off? Wouldn't it be better to do something on the lines of
> 
> $arg = length($date_string) == 10
>   ? ($date_string .= " $time_string") # 00:00:00 or 23:59:59
>   : _strip_UTC_designators($date_string);

Fair question.

I'm adding T...Z string, because it's only stripped off half the time. 

If you read through the code, you'll see that "from" and "until" properties
retain the T and Z designators. It's only the "from_arg" and "until_arg"
properties that have them stripped off.

The reasoning here is that the "from" and "until" properties are used to
generate the actual resumption token, which requires the T and Z designators,
while the "from_arg" and "until_arg" have them stripped off for matching in
MySQL.

Does that make sense? We want the T and Z for the token, but no T and Z for the
database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #12 from Jesse Weaver  ---
Phew, new version, updated to apply on master and with a couple small bugfixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #19227|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #11 from Jesse Weaver  ---
Created attachment 21687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21687&action=edit
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

This adds a new page to the OPAC that can search several Z39.50 targets
using Pazpar2.

Test plan:
1) Apply patches.
2) Update database.
3) Add one or more Z39.50 targets, using the Administration -> External
   targets screen. Note that not all targets support keyword search, but
   here are some that do:
 * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
4) Perform a search on the OPAC, check to see if the "external targets"
   notice pops up at the top.
5) Click on the results link near that message.
6) This should bring back results from all enabled targets, all of which
   should be clickable to bring up a detailed view of the record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #19226|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #19680|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10979] No undef checks in DateUtils

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10979

Srdjan Jankovic  changed:

   What|Removed |Added

   Priority|P5 - low|P4
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10979] New: No undef checks in DateUtils

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10979

Bug ID: 10979
   Summary: No undef checks in DateUtils
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: srd...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

There are many places in Koha::DateUtils where values not undef tested before
matching (ie output_pref(), dt_from_string() etc). This causes unnecessary
processing and gives unsightly warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10843] print a slip can cause an error

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10843] print a slip can cause an error

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #21651|0   |1
is obsolete||

--- Comment #6 from Srdjan Jankovic  ---
Created attachment 21686
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21686&action=edit
[SIGNED-OFF] Bug 10843: the DateTime->add method takes a scalar, not undef

Test plan:
1) set an empty string for the ReservesMaxPickUpDelay pref
2) place a hold on an item
3) check in the item
4) click on "Print and confirm"
5) an error occurs
> The 'days' parameter (undef) to DateTime::Duration::new was an 'undef'
6) apply the patch
7) repeat steps 1 to 4
8) the error does not occur anymore.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

--- Comment #6 from M. Tompsett  ---
(In reply to Chris Cormack from comment #5)
> Maybe we can kill C4::Utils after getting rid of this

That's what 10927 does. I've signed it off. It is awaiting QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #20 from mathieu saby  ---
Hi Owen & Jonathan

I experienced the same bug during my tests.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375

mathieu saby  changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #15 from mathieu saby  ---
Patch 1 and 2 were already signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

Chris Cormack  changed:

   What|Removed |Added

  Attachment #21545|0   |1
is obsolete||

--- Comment #5 from Chris Cormack  ---
Created attachment 21685
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21685&action=edit
Bug 10925: LDAP auth fails if DEBUG is enable

To reproduce:
1/ Edit your apache virtual host and set the DEBUG environment variable
(SetEnv DEBUG 1).
2/ Try to login with an ldap user
3/ You will be redirected to the 500 error page.
The Koha logs contains:
malformed header from script. Bad header=--:
mainpage.pl

The hashdump routine directly punks to the STDOUT (!) and breaks the
headers.
It appears Net::LDAP::?->dump does the same thing.

Signed-off-by: Mark Tompsett 
Signed-off-by: Chris Cormack 

Maybe we can kill C4::Utils after getting rid of this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

Chris Cormack  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

mathieu saby  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #14 from mathieu saby  ---
Created attachment 21684
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21684&action=edit
[PATCH 3] Bug 7791 Followup: add warning after deletion if some records were
not deleted

Here is the followup.

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its order

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl and trigger actions

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21634|0   |1
is obsolete||

--- Comment #44 from Bernardo Gonzalez Kriegel  ---
Created attachment 21683
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21683&action=edit
[SIGNED-OFF] Bug 9044: Set the number of filters according to number of columns

Signed-off-by: Bernardo Gonzalez Kriegel 
Filters now shows correctly. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3032] Enhancement: ability to deny some patrons password resets

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3032

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hm, I have started working on this, but will not be able to finish before the
deadlines for 3.14. I am using a new column in categories, so tying it to the
patron category. (bug 10796)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
This does sound bad - any progress on replicating and squashing the bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #87 from Katrin Fischer  ---
Any hints appreciated... the logs are clean. I am not seeing what I am doing
wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

--- Comment #8 from Robin Sheat  ---
Thanks Uli! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5336] Acq history search

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #86 from Katrin Fischer  ---
I have finally started configuring a shiny new database with examples to test
the update with. I am currently stuck on receiving records - there are no
orders showing up for receiving in the table of pending orders. I have 2 closed
baskets that are assigned to a closed basket group. It's too late to figure out
what's going wrong here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #21632|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #152 from sandbo...@biblibre.com  ---
Created attachment 21682
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21682&action=edit
UTF8 double encoding fixes. Commits squashed into one.

double utf8 encoding fix .. second try

minor formatting updates

enhancement to the previous patch related to utf8 double encoding

added ENCODING=>utf8 to new->

added space which is there in master

added utf8::decode for ms_query

replaced tabs with spaces

replaced tabs with spaces

removed extra space

Signed-off-by: Srdjan 

http://bugs.koha-community.org/show_bug.cgi?id=6554

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #151 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #11 from Katrin Fischer  ---
I am sorry, but this doesn't work for me. 

My installation uses DOM indexing (authority and bibliographic records) and
ICU.

What I did:

- Reindexed my date, search works correctly
- Applied patch
- perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log 
- make upgrade
- restarted Zebra server

Then tried to reindex:
[~/kohaclone (98-10729-icuphrase)âš¡]> ./misc/migration_tools/rebuild_zebra.pl -b
-v -r 
Zebra configuration information

Zebra biblio directory  = /home/katrin/koha-dev/var/lib/zebradb/biblios
Zebra authorities directory = /home/katrin/koha-dev/var/lib/zebradb/authorities
Koha directory  = /home/katrin/kohaclone
BIBLIONUMBER in : 999$c
BIBLIOITEMNUMBER in : 999$d

skipping authorities

exporting biblio

101..
Records exported: 118

REINDEXING zebra

*** stack smashing detected ***: zebraidx terminated
=== Backtrace: =
... lots of unhappiness ...

Without the patch the same database reidexes without any problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #10 from mathieu saby  ---
Hello Lyon3
do you still disagree with me, especially on the last test?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #13 from mathieu saby  ---
(In reply to M. de Rooy from comment #12)
> (In reply to mathieu saby from comment #11)
> > To be clear : does it occur in master without my patch?
> Hi Matthieu,
> Yes it does. So nothing to do with your patch..
> 
> Note that if I am in a basket from some supplier and I delete it, I actually
> would like to return to the basket list of that supplier instead of getting
> a list of all suppliers. But that is outside the scope of this report.

I filled a new bug for that 10978 ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10978] New: redirect to basket list of a supplier after deleting a baset

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978

Bug ID: 10978
   Summary: redirect to basket list of a supplier after deleting a
baset
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

I copy here a remark that M. de Rooy made while QAing bug 7791. It could be a
little improvement 

"Note that if I am in a basket from some supplier and I delete it, I actually
would like to return to the basket list of that supplier instead of getting a
list of all suppliers. But that is outside the scope of this report."

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Owen Leonard  ---
I haven't run across the "Bad request" error again, but I did find this:

1. Perform a search
2. Click a library facet
3. Cancel the library facet
4. Click another library facet

At this point there is no "[x]" by the facet I clicked in step 4. Same results
in the OPAC and staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #10 from Katrin Fischer  ---
Thx for taking a look Robin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #21650|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10948] Some strings in the authority result list turned out untranslatable

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

--- Comment #6 from Katrin Fischer  ---
Created attachment 21681
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21681&action=edit
[PASSED QA] Bug 10948: make reference labels translatable in OPAC auth results

For some reason the translator script was not picking up the see also
and used for/see from labels on the OPAC. This patch fixes the problem.

To test:
1) Apply patch.
2) Generate PO files.
3) Note that "see from" and "used for/see from" appear.
4) Sign off.

Signed-off-by: Nuño López Ansótegui 
Signed-off-by: Katrin Fischer 
Works nicely, thx for the fix.
Tested by updating the German po files, translating the
strings and installing the templates.
Verified strings show up in German in the authority
result list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||10857

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||10952

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial claims

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854

--- Comment #23 from Katrin Fischer  ---
I was thinking maybe not use 'items' as this is confusing in translation and we
are exporting information about issues here. But not sure how to phrase it
best.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

--- Comment #15 from Katrin Fischer  ---
Created attachment 21680
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21680&action=edit
[PASSED QA] Bug 10602 - followup to remove tabs

Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #21664|0   |1
is obsolete||
  Attachment #21665|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 21679
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21679&action=edit
[PASSED QA] Bug 10602: Set a default value for authorities

Some code already exist but the feature does not work.

This patch allows to define default values in the authorities framework.

Test plan:
1/ Choose a framework, field and subfields.
2/ Define a default value.
3/ Create a new authority and check that the subfield is
automatically filled with the default value.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described. koha-qa reports some tabs, fixed in followup

Test
1) Apply patch, run updatedatabase.pl
2) Edit auth framework, put default value someware, save
3) Add new auth, default value present

Signed-off-by: Katrin Fischer 
Passes all tests and QA script.
Verified database update is done correctly.

Controlfields 0xx
- Edited an existing field (001)
- Set a default value for subfield @
- Edited subfield again, checking default was saved correctly
- Verified the default shows up correctly when creating a
  new authority using this authority type

Fields
- Edited an existing field (100)
- Set a default value for subfield e
- Edited subfield again, checking default was saved correctly
- Verified the default shows up correctly when creating a
  new authority using this authority type

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21678|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21660|0   |1
is obsolete||

--- Comment #33 from Bernardo Gonzalez Kriegel  ---
Created attachment 21678
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21678&action=edit
[SIGNED-OFF] Bug 8007: Followup: fix read dir error

This patch fixes:
- an error on reading the discharges directory
- the parameter sent to CancelReserves (API has been changed)
- the parameters sent to output_pref (API has been changed)

Signed-off-by: Bernardo Gonzalez Kriegel 
Reading files problem solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

--- Comment #16 from Bernardo Gonzalez Kriegel  ---
(In reply to Bernardo Gonzalez Kriegel from comment #15)
> sorry, missed one patch. re-uploading
oops, wrong Bug. No problem here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

--- Comment #15 from Bernardo Gonzalez Kriegel  ---
sorry, missed one patch. re-uploading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21396|0   |1
is obsolete||

--- Comment #31 from Bernardo Gonzalez Kriegel  ---
Created attachment 21676
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21676&action=edit
[SIGNED-OFF] Bug 8007: QA Followup

Change GPL version to v3+.

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #32 from Bernardo Gonzalez Kriegel  ---
Created attachment 21677
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21677&action=edit
[SIGNED-OFF] Bug 8007: Followup: fix read dir error

This patch fixes:
- an error on reading the discharges directory
- the parameter sent to CancelReserves (API has been changed)
- the parameters sent to output_pref (API has been changed)

Signed-off-by: Bernardo Gonzalez Kriegel 
Reading files problem solved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21394|0   |1
is obsolete||

--- Comment #29 from Bernardo Gonzalez Kriegel  ---
Created attachment 21674
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21674&action=edit
[SIGNED-OFF] Bug 8007: Discharge management

At the intranet, it is now possible to generate a
discharge for a patron.
At the opac, a patron can request a discharge and download discharges
already generated.

Requirements:
aptitude install python-pisa

New sysprefs:
 - useDischarge: Allows librarians to discharge borrowers and borrowers
   to request a discharge
 - dischargePath: Sets the upload path for the generated discharges
 - dischargeWebPath: Sets the upload path starting from documentroot for the
generated
   discharges

New letter with a letter_code DISCHARGE.

Test plan:
- Switch on the syspref useDischarge.
- Fill the syspref dischargePath (e.g. /home/koha/src/koha-tmpl/discharges)
- Fill the syspref dischargeWebPath (e.g. /discharges)
- For a security reason create a .htaccess in your dischargePath with
  the following content:
  Options -Indexes
  and change the rights:
  sudo chown www-data:www-data /home/koha/src/koha-tmpl/discharges
- Check that a new tab appears in the patron page (intranet and opac)
- Check that the discharge cannot be generated if the patron has issues.
- Check that the patron can request a discharge from it's opac area.
- The request is a mail sent via the sendmail command
- Generate the discharge from the intranet
- Try to download it (from the opac and the intranet)

Sponsored-by: SCD Limoges
Signed-off-by: Bernardo Gonzalez Kriegel 
Works well. No koha-qa errors

Solved merge conflict in updatedatabase.pl

Test following test plan
1) enable sysprefs, put discharges dir somewhere in filesystem,
with correct permissions, for webpath I did a symlink to
koha-tmpl
2) created .htacces as example
3) new tab appears on user OPAC
4) patron can't request discharge with items on loan
5) patron can request dischrage without issues, email sent correct,
6) Discharge generated from intranet, also check that can't be generated
if patron has issues
7) Download correct from OPAC and STAFF

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21395|0   |1
is obsolete||

--- Comment #30 from Bernardo Gonzalez Kriegel  ---
Created attachment 21675
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21675&action=edit
[SIGNED-OFF] Bug 8007: Add a discharges example file

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

--- Comment #30 from Katrin Fischer  ---
Created attachment 21673
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21673&action=edit
[PASSED QA] Bug 10856: Fix cover display in shelf browser

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 
I was able to reproduce the problem with local covers and
the patch fixes it in my tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #21319|0   |1
is obsolete||
  Attachment #21320|0   |1
is obsolete||
  Attachment #21321|0   |1
is obsolete||
  Attachment #21666|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 21670
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21670&action=edit
[PASSED QA] Bug 10856: Improve the previous and next items on the shelf browser

The next and previous links should completely refresh the shelf.

For example:
[<] [1] [2] [3] [4] [5] [6] [>]
Before this patch, the next and previous links were the same as the 1
and 6.
With this patch, after clicking on next, we will get:
[<] [7] [8] [9] [10] [11] [12] [13] [>]

This patch adds a new ajax script to get the shelf browser block.

Test plan:
- On a detail biblio page, click on a "Browse shelf" link.
- Play with the next and previous links.
- Deactivate Javascript (using NoScript for example) and check that you
  get the same behavior (but the page is reloaded).
- Launch the unit tests: prove t/db_dependent/ShelfBrowser.t

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

--- Comment #28 from Katrin Fischer  ---
Created attachment 21671
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21671&action=edit
[PASSED QA] Bug 10856: If callnumbers are equals, order should be on
itemnumbers

If a lot of items has the same callnumber, the order should be on the
itemnumbers. Otherwise the left side is always filled with the same
items.

+ Fix a bad c/p for the next link (when js is disabled).

Signed-off-by: Owen Leonard 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

--- Comment #29 from Katrin Fischer  ---
Created attachment 21672
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21672&action=edit
[PASSED QA] Bug 10856 [Follow-up] Improve the previous and next items on the
shelf browser

In Firefox at least, the shelf browser cannot be reopened after
hiding it with the "close shelf browser" link. This followup improves
the behavior of the "close shelf browser" link so that the shelf browser
can be redisplayed.

To test, open a bibliographic detail page in the OPAC and click a
"browse shelf" link. Click the "close shelf browser" link--the shelf
browser should be hidden. Click the original "browse shelf" link and the
shelf browser should reappear without reloading the page.

Test with Firefox and Chrome (at least).

Signed-off-by: Jonathan Druart 
Signed-off-by: Katrin Fischer 
All tests and QA script pass.

Testing notes:
- New unit tests in t/db_dependent/ShelfBrowser.t pass.
- System preference  OPACShelfBrowser still works as expected.
- Closing and opening the shelf browser works as expected.
- Next and Previous links show new and nicer behaviour.
- Logs are clean.

Tested with Firefox and Chromium under Ubuntu.

Notes: The currently displayed record could maybe be highlighted
a bit better.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21657|0   |1
is obsolete||

--- Comment #14 from Bernardo Gonzalez Kriegel  ---
Created attachment 21669
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21669&action=edit
[SIGNED-OFF] Bug 10611: Followup: remove useless calls to dbh->disconnect

These 3 calls to disconnect are done at the end of the script, they are
useless.

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21656|0   |1
is obsolete||

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
Created attachment 21668
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21668&action=edit
[SIGNED-OFF] Bug 10611: add a "new" parameter to C4::Context->dbh

When dbh->disconnect is called and the mysql_auto_reconnect flag is set,
the dbh is not recreated: the old one is used.

Adding a new flag, we can now force the C4::Context->dbh method to
return a new dbh.

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still running

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21264|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Created attachment 21667
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21667&action=edit
[SIGNED-OFF] Bug 10611: Use mysql_auto_reconnect instead of ping

DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a
ping.

Benchmarks:

use Modern::Perl;
use C4::Context;
for ( 1 .. 1000 ) {
$dbh = C4::Context->dbh;
}

* without this patch on a local DB:
perl t.pl  0,49s user 0,02s system 98% cpu 0,525 total
* without this patch on a remote DB:
perl t.pl  0,52s user 0,05s system 1% cpu 37,358 total
* with this patch on a local DB:
perl t.pl  0,46s user 0,04s system 99% cpu 0,509 total
* with this patch on a remote DB:
perl t.pl  0,49s user 0,02s system 56% cpu 0,892 total

Testing the auto reconnect:
use Modern::Perl;
use C4::Context;
my $ping = $dbh->ping;
say $ping;
$dbh->disconnect;
$ping = $dbh->ping;
say $ping;

Signed-off-by: Bernardo Gonzalez Kriegel 
Comment: Real improvement. No koha-qa errors

prove t/db_dependent/Circulation_issuingrules.t produces no error
prove t/db_dependent/Context.t produces no error

Test
1) dumped Koha DB, load it on a non-local server
2) run sample script whit and without patch, local and remote

use Modern::Perl;
use C4::Context;
for ( 1 .. 10 ) {
my $dbh = C4::Context->dbh;
}

Main difference I note is with remote server
a) without patch
real0m16.357s
user0m2.592s
sys 0m2.132s

b) with patch
real0m0.259s
user0m0.240s
sys 0m0.012s

I think this could be good for DBs placed on
remote servers

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Owen Leonard  changed:

   What|Removed |Added

  Attachment #21508|0   |1
is obsolete||

--- Comment #26 from Owen Leonard  ---
Created attachment 21666
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21666&action=edit
[SIGNED-OFF] Bug 10856: Fix cover display in shelf browser

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10856] Improve the previous and next items on the shelf browser

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
Created attachment 21665
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21665&action=edit
Bug 10602 - followup to remove tabs

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10602] Set a default value for authorities

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #21659|0   |1
is obsolete||

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
Created attachment 21664
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21664&action=edit
[SIGNED-OFF] Bug 10602: Set a default value for authorities

Some code already exist but the feature does not work.

This patch allows to define default values in the authorities framework.

Test plan:
1/ Choose a framework, field and subfields.
2/ Define a default value.
3/ Create a new authority and check that the subfield is
automatically filled with the default value.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described. koha-qa reports some tabs, fixed in followup

Test
1) Apply patch, run updatedatabase.pl
2) Edit auth framework, put default value someware, save
3) Add new auth, default value present

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #28 from Bernardo Gonzalez Kriegel  ---
Worked! :)

Last question:
On a dev install, koha-tmpl is accesible from oapc and staff,
but on a packages/tar install DocumentRoot for opac and staff
do not overlap.

opac  -> DocumentRoot /usr/share/koha/opac/htdocs
staff -> DocumentRoot /usr/share/koha/intranet/htdocs

I solved this doing a symlink of discharges dir to both htdocs
but this must be stated on instructions

Do you plan some followup to remove these files?
I think that if the patron is lifted from a discharge
the files must be removed, or make them inaccesible (from opac)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #19 from Jonathan Druart  ---
Created attachment 21663
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21663&action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10977] New: Connexion Gateway: biblios not importing as a batch

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10977

Bug ID: 10977
   Summary: Connexion Gateway: biblios not importing as a batch
 Change sponsored?: ---
   Product: Koha
   Version: 3.10
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: dr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 21662
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21662&action=edit
screenshot

In Staged MARC Management, when importing multiple records and set to
import_mode: stage, each biblio is staged individually not as a batch.

-

Steps to replicate:
1) Configure Connexion Client.
2) Set connexion.conf to import_mode: stage
3) Import a batch of records.

Each biblio is a separate file in Manage staged MARC records.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

--- Comment #25 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #23)
> I am not sure about including the gone no adress and lost flag - but I like
> manage_restrictions. Maybe we can have a quick poll on IRC?

Oops, I did not wait for your answer.
I think it makes sense to include 3 restrictions, but maybe I'm wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

--- Comment #24 from Jonathan Druart  ---
Created attachment 21661
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21661&action=edit
Bug 10863: Rename lift_restriction with manage_restrictions

The pref manage_restrictions now takes into account "Lost card" and
"Gone no address" restrictions.

Test plan:
- log in with a user with manage_restrictions permission
- verify you can set/unset restrictions when editing a patron
- log in with a user without manage_restrictions permission
- verify you cannot set/unset restrictions when editing a patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

--- Comment #23 from Katrin Fischer  ---
I am not sure about including the gone no adress and lost flag - but I like
manage_restrictions. Maybe we can have a quick poll on IRC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

--- Comment #22 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #21)
> Katrin,
> In fact I completely forgot a staff can change the flags on editing a patron.
> The goal of this patch was to hide/show the "Lift restriction" button on top
> of the circulation page.
> But it is not enough.

Looking at the patch, I did not forget :)
What do you think about changing the lift_restriction permission to
manage_restrictions (including Restricted, Lost and Gone no address)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

--- Comment #21 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #20)
> Hi Jonathan, 
> 
> I have one bigger and some smaller issues with "Lift restriction for
> restricted accounts"
> 
> I think either the description is wrong, or it does not work like it should.
> We have 3 possible restrictions on patron accounts:
> 
> - Restricted
> - Lost
> - Gone no address
> 
> It would be nice if it was clearer that it only affected "Restricted", but
> that is ok. (1)
> 
> What I have a problem with is, that you can also not restrict someone if you
> are missing the permission - which means it's not only for 'lifting' but
> also for 'setting' the restriction. Is this by design? (2)

Katrin,
In fact I completely forgot a staff can change the flags on editing a patron.
The goal of this patch was to hide/show the "Lift restriction" button on top of
the circulation page.
But it is not enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-09-30 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #30 from Jonathan Druart  ---
(In reply to Galen Charlton from comment #28)
> (In reply to Jonathan Druart from comment #23)
> > This patch will be in conflict with bug 8367.
> 
> Can you expand on what sort of conflict?  Just a merge conflict that would
> be resolvable with more or less effort, or conflicting notions of the
> desired functionality or implementation thereof?

When I wrote this note, bug 8367 was signed off. Now, it does not apply :)
In bug 8367 I change the list of returned values for the
GetReservesFromItemnumber routine (I return directly the reserve hashref).
Patches from this report add a returned value too (waitingdate). So I thought
it would be good to base them onto bug 8267's patches.
The first argument was: patches are really (reaally) boring to rebase.
It was certainly not relevant, so please don't take into account this note.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >