[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #166 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Ketan Kulkarni from comment #165) Created attachment 21955 [details] My opac xslt preferences Please see my OPAC preferences. OK That looks good. Will post some more details today about what I came across. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #167 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 21978 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21978action=edit opac-search Please look at mangled characters with diacritics in the XSLT blocks and facets. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #21978|image/jpeg |image/png mime type|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #168 from M. de Rooy m.de.r...@rijksmuseum.nl --- I attached an image for opac-search but opac-detail and opac-MARCdetail contain similar mangled chars. Also opac-shelves.pl, opac-readingrecord.pl, and maybe more.. At staff side: similar problems in catalogue/search, catalogue/detail.pl, virtualshelves/shelves.pl, circ/circulation.pl (confirm checkout had a mangled char), cataloguing/addbiblio.pl (oops: dangerous! saving mangled data), acqui/booksellers.pl (look for é), and maybe more.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11048] New: Fix logout redirection for CAS authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Bug ID: 11048 Summary: Fix logout redirection for CAS authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org The logout redirection function after a CAS authentication was misused. This patch fixes it, and allows the CAS server to redirect the user back to the opac after logout. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 --- Comment #1 from Matthias Meusburger matthias.meusbur...@biblibre.com --- Created attachment 21979 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21979action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11048] Fix logout redirection for CAS authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #169 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 21980 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21980action=edit OPAC search Marcel, I take a screenshot of your devel site. For me it looks right, without mangled chars. That's one the problems with this bug, different people see different things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #170 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Bernardo Gonzalez Kriegel from comment #169) For me it looks right, without mangled chars. I got the impression that the mangled chars are from the Latin subset (diacritics on vowels like a e etc.) Special chars from Chinese or Japanese seem to be correct.. Can you confirm that? Or are Latin chars also correct in your case? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #171 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 21981 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21981action=edit OPAC search 3 (In reply to M. de Rooy from comment #170) I got the impression that the mangled chars are from the Latin subset (diacritics on vowels like a e etc.) Special chars from Chinese or Japanese seem to be correct.. Can you confirm that? Or are Latin chars also correct in your case? Problem is they look correct to me (latin diacritics). Attached same screen but with Firefox. When tested latest patchset I can't reproduce errors, I create patron categories in Chinese, Armenian, Indi, etc. All looked right (on master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #172 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Bernardo Gonzalez Kriegel from comment #171) Created attachment 21981 [details] OPAC search 3 Hi Bernardo This is another image from my server but the 6554 patch is no longer active. That makes a difference :) When tested latest patchset I can't reproduce errors, I create patron categories in Chinese, Armenian, Indi, etc. All looked right (on master) OK. My question actually was: If you have only a few latin chars on your screen (so not combined with *real* eh-eh utf8 chars, are they correct? Do not know if you have such records in YOUR database? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] New: Truncated URLs may mangle output of sending cart email from opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 Bug ID: 11049 Summary: Truncated URLs may mangle output of sending cart email from opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl I stumbled over this in 3.8. A record contains four longer URLs (in MARC 856) that in total exceed the field length of biblioitems.url (255 chars). In saving this info into biblioitems.url the output of TransformMarcToKoha is truncated. When you put this biblio in the opac cart and send the cart, this truncated field is inserted into a html template. After that it should be sent as a plain text email. Somewhere in this process the truncated field causes the email output to be mangled. Information after the URLs like item info and the closing line with dashes do no longer appear. It seems like this bug could be reproduced in master (looking at the code and templates). But unfortunately, in master when sending the basket another error pops up before the form of opac-sendbasket is shown. Can't call method field on an undefined value at /usr/share/koha/testclone/C4/Biblio.pm line 1713. This is in the routine GetMarcNotes and it is actually not really related to the error presented in this report ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #173 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to M. de Rooy from comment #172) OK. My question actually was: If you have only a few latin chars on your screen (so not combined with *real* eh-eh utf8 chars, are they correct? Do not know if you have such records in YOUR database? Yes I have :) And they look correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #25 from Paola Rossi paola.ro...@cineca.it --- As it was written in comment 19, I still get the following message when I click the Merge button: Following required subfields are missing: - 003$@ - 008$@ - 005$@ As it was written in comment 18, there is a problem when you try to copy the LAST field of the record you destroy to the destination record. So I don't sign off, and pass the patch to Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr --- Hi I don't remember having the fist issue you mentionned when I tested with UNIMARC records. Jonathan, is it possible that the patch does not work well with MARC21 records? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #27 from Paola Rossi paola.ro...@cineca.it --- I as worked with MARC21 en. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #11 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- (In reply to Owen Leonard from comment #2) The new include, patron-default-view.inc, outputs the *opening* half of the a so that individual templates can control whether to show full name, barcode, both, etc. In my opinion, it would be better if include contained the full anchor tag. Because templates are hard to read when they are not correct HTML. You could pass to include the content of the tag : [% IF ( PatronDefaultView == 'circ' ) %] a href=/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrowernumber %][% text %]/a [% ELSE %] a href=/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber %][% text %]/a [% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending cart email from opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl --- OK. The error on GetMarcNotes was completely off-scope. But the new template for opac-sendbasket seems to resolve this error on master. So it looks like an old problem (3.8). Marking it as solved. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to control whether patron links go to circ or patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680 --- Comment #12 from Owen Leonard oleon...@myacpl.org --- I'd be happy to pick this up again if others think it's a good idea (and I think it is). I'd like to hear more opinions though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending cart email from opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Version|master |3.8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #5 from Paola Rossi paola.ro...@cineca.it --- The patch doesn't apply cleanly against master. There is a merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt. So I don't sign off the match, and I pass it to failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4880] koha-remove sometimes fails because user is logged in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #4 from Magnus Enger mag...@enger.priv.no --- Not sure if this really adds anything, but here goes: I have been moving some instances around today, and done some koha-removes. In the beginning I was getting errors because the koha user for the given instance was logged in. Now I have tried several times to run koha-stop-zebra before I run koha-remove, and now I'm not getting the error about the logged in user. At least that seems to confirm the theory from comment #2. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending cart email from opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 --- Comment #2 from M. de Rooy m.de.r...@rijksmuseum.nl --- Just a final note: Copying the new template to 3.8 and taking over the change in opac-sendbasket to use encode_qp on body and email_header will 'resolve' the problem under 3.8 too. But not completely by the way :) Note that the message is now complete again, but the URL (remember it were actually four urls) is now presented in the email as one big URL. (And it is still truncated.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated) presented as one URL in opac-sendbasket email message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Summary|Truncated URLs may mangle |Multiple URLs (possibly |output of sending cart |truncated) presented as one |email from opac |URL in opac-sendbasket ||email message --- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl --- So, we can actually reopen this bug for master now. But we need to rephrase it. If you have multiple URLs in a biblio record with tag 856. They are put into one biblioitem field (possibly truncated to 255 chars) and presented as one url in the opac sendbasket email message. Two errors at one time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated) presented as one URL in opac-sendbasket email message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Component|Cataloging |OPAC Assignee|gmcha...@gmail.com |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated) presented as one URL in opac-sendbasket email message
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21932|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21982 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21982action=edit Bug 11023: Toggle new status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||paola.ro...@cineca.it --- Comment #12 from Paola Rossi paola.ro...@cineca.it --- Applying: Bug 8230: Display acquisition details on the catalogue detail page fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8230: Display acquisition details on the catalogue detail page So I don't sign off the patch, and pass it to failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11023] Toggle new status for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21982|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 21983 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21983action=edit Bug 11023: Toggle new status -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #13 from Paola Rossi paola.ro...@cineca.it --- I've applied all the patches for bug 5336 before applying this one. Applying of this patch is OK too. Where is the Acquisition details tab (point 5 of the test plan)? I can't see it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #28 from Fridolyn SOMERS fridolyn.som...@biblibre.com --- What is missing to pass QA ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461 --- Comment #17 from Koha Team Lyon 3 k...@univ-lyon3.fr --- The principle is that the price including the tax has to be deduct from the budget. In fact, there's a bad calculation of the unit in orderreceive.pl. If we are in the case : list price include tax : YES invoice price include tax : NO So to have price including the tax, you have to add the tax to the unit price (unitprice+unitprice*gstrate) If we are in the case : list price include tax : NO invoice price include tax : YES you have to add the tax to the estimated price ecost =ecost+ecost*gstrate this is not the case in orderreceive.pl I prepare a patch for this if everybody is ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11026] in UNIMARC, pubdate index should be based on 100 field and not 210
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11026 --- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr --- An other option would be to declare pubdate index both on 210$d AND 100pos9-12 So, if a library does not have 100 filled, the record will still be indexed with 210. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11050] New: Remove some non UNIMARC fields from UNIMARC Zebra conf files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11050 Bug ID: 11050 Summary: Remove some non UNIMARC fields from UNIMARC Zebra conf files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: mathieu.s...@univ-rennes2.fr QA Contact: testo...@bugs.koha-community.org Fields 603, 630, 631, 632, 633, 634, 635, 636, 646, 400, 401, 403, 414, 415, 416, 417, 418, 419, 420 are not defined in Unimarc, but are defined in Zebra conf files for unimarc (for GRS 1 and DOM). They should be removed to clean conf files. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 --- Comment #1 from Magnus Enger mag...@enger.priv.no --- Created attachment 21984 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21984action=edit Bug 10782 - Add a koha-mysqlcheck script This patch adds the koha-mysqlcheck script, as a frontend for the mysqlcheck command. It can be used to check the integrity of database tables, as well as to repair them. See man mysqlcheck for more information. The script takes a Koha instance name as its only required parameter. Any other parameters provided before the instance name are passed directly to mysqlcheck, which means that all the functionality of mysqlcheck is available through this script. To test the script: - Apply the patch, build your own packages and install them, or - copy koha-mysqlcheck to a server already running off packages - Run some variations of the command, with and without arguments, and check that the output makes sense. E.g.: sudo koha-mysqlcheck myinstance sudo koha-mysqlcheck -e myinstance # Extended checks sudo koha-mysqlcheck -e -v myinstance # Extended checks and verbose - See man mysqlcheck for other relevant options To test the man page: - Run these commands and look at the formatted man page: $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-mysqlcheck.xml $ man -l koha-mysqlcheck.8 - Make sure this test passes: $ prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782 --- Comment #2 from Magnus Enger mag...@enger.priv.no --- Just to be clear: My plan changed a little between the initial comment and the actual commit. Please disregard the description given in the first comment, and focus on the description in the actual commit. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10636] patronimage should have borrowernumber as PK, not cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton gmcha...@gmail.com --- I've pushed to this master, as it's a dependency for the successful inclusion of DBIx::Class. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8798] Add the use of DBIx::Class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #94 from Galen Charlton gmcha...@gmail.com --- At long last, this is in master. I've pushed a few follow-ups, but the only one of particular note is one that requires update_dbix_class_files.pl to get its DB connection parameters from the command line rather than the current Koha context, to reduce the risk that a developer or RM accidentally includes test database schema cruft when doing a schema class update. Thanks, everybody! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Priority|P5 - low|P4 Status|BLOCKED |Needs Signoff Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #14871|0 |1 is obsolete|| --- Comment #17 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 21985 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21985action=edit [PATCH 1/3] Bug 8962: Changes to CCL and templates This patch adds a new index Anywhere in ccl.properties and add any word option in intranet search for using this index. Default OPAC and intranet search in still using CCL Any index. Testing plan : In a Marc21 GRS-1 Koha : 1/ make some biblio searches without selecting any index (Koha will use any index) and note the results. Ex : search fre, eng, book, history, history book 2/ apply the 3 patches 3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth, Unimarc bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ check that a new choice Any word (all indexes) is visible in advanced search. 6/ make the same searches as 1/ : you should see less results (detailed test plan in patchs 2 and 3) 7/ in Staff interface adavanced search, select Any word (all indexes) and make the same searches as 1/ : you should see the same results (maybe with a slight differences, because more notes fields are indexed in Marc21) In a UNIMARC GRS-1 Koha : same test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #14873|0 |1 is obsolete|| --- Comment #18 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 21986 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21986action=edit [PATCH 3/3] Bug 8962: Unimarc biblios and authorithies (GRS1) This patch makes some changes UNIMARC GRS1 indexing, for indexing only some specific fields in any index. The patch is fully testable, and can be signed off if it works. But the list of fields I kept in any is rather subjective, and based as my experience as a library user: It can be discussed in followups. 1. Defines a new index anywhere for indexing all biblio and authorities subfields. 2. Make any index more selective than before : - for authorities : all fields indexed in any except 001 and notes (3XX) - for biblios : fields indexed in any : * biblio fields indexed in any : ** the more user friendly control numbers : 01X, 07X ** authors : 7XX except $9, 200$f$g ** titles : 4XX except $9, 5XX except $9, 200$a$d$e$h$i ** edition statement : 205 ** series : 225, 410, 411 ** subjects : 6XX except $9 and 67X/68X ** notes : only 327, 328, 314, 330 * items fields indexed in any : ** barcode : 995f ** callnumber : 995k Test plan : In a Marc21 GRS-1 Koha : 1/ apply patch 1 and this one 2/ in Staff interface, make some searches on authorities (choose Keyword search tab), including searches of words only present in 3XX fields. 3/ copy the 2 new record.abs files (UNIMARC auth, UNIMARC bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ make the same authorities searches as 2/ : you should get the same results, except for searches based on words only present in 3XX fields : in that case, you should not see the auth records. 6/ in default search (without selecting any index), search for some record by - its isbn - its issn - its title - its author(s) - its series name - its publisher - its summary (330 field) - several subjects - the barcode of one of its items - the callnumber of one of its items = you should find the record each time 7/ in default search (without selecting any index), search for some record by - the content of any 3XX fields (except 327,328,314,330) - the number of pages or volumes (ex : 510 p. or 1 vol) - its language code (eng, fre...) - the value of 200$b (like Texte imprimé) - its publication year - its town of publication - the content of a 670-680 field - the content of a 995 subfield (except barcode and callnumber) - the content of a 099 subfield = you should not find the record each time 8/ regression test : check that specific indexes are working as usual (title, subject, callnum, barcode, pubdate etc) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #14872|0 |1 is obsolete|| --- Comment #19 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 21987 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21987action=edit [PATCH 2/3] Bug 8962: Marc21 biblios and authorithies (GRS1) This patch makes some changes MARC21 GRS1 indexing, for indexing only some specific fields in any index. The patch is fully testable, and can be signed off if it works. But the list of fields I kept in any is rather subjective, and based as my experience as a library user: It can be discussed in followups. 1. Defines a new index anywhere for indexing all biblio and authorities subfields. 2. Make any index more selective than before : - for authorities : all fields indexed in any except 001 - for biblios : fields indexed in any : * biblio fields indexed in any : ** the more user friendly control numbers : 020-030 ** main entries (authors and uniform title) : 1XX ** title and Title-Related Fields : 20X-24X ** publisher : 260$b ** series : 4XX ** some notes : 502 (dissertation), 520 (abstract), 505 (formated content), 511 (participant) ** subjects : 6XX ** added Entry Fields : 70X-75X ** linking Entries-General Information : 76X-78X ** series Added Entry Fields : 80X-83X * item fields indexed in any : ** callnumber : 952$o ** barcode : 952$p 3. Also index all the Marc21 notes (5XX) in Notes index (same logic as current 3XX fields indexing in UNIMARC) - new fields not indexed before : 504,506,507,508,511,513,514,515,516,518,521,522,524,525,530,533,534,535, 536,538,540,541,542,544,545,547,550,552,555,556,561,562,563,567,580,581,583,584,585,586,588 - fields indexed in Notes in addition to a more specific index : 502,505,521,520,510,526 4. Also index all the Marc21 notes (5XX) in Notes index (same logic as current 3XX fields indexing in UNIMARC) 5. Adds a lot of comments to make easier further changes and error checking Test plan : In a Marc21 GRS-1 Koha : 1/ apply patch 1 and this one 2/ in Staff interface, make some searches on authorities (choose Keyword search tab) 3/ copy the 2 new record.abs files (Marc21 auth, Marc21 bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ make the same authorities searches as 2/ : you should get the same results 5/ edit a record to put the value in newly indexed 5XX field (for example in 530) 6/ search note: : you should find the record 7/ edit a record to put the value in a 5XX field index in note in addition to a more specifi index (for example in 520) 8/ search note: : you should find the record 9/ in default search (without selecting any index), search for some record by - its isbn - its issn - its title - its author(s) - its series name - its publisher - its summary (520 field) - several subjects - the barcode of one of its items - the callnumber of one of its items = you should find the record each time 10/ in default search (without selecting any index), search for some record by - the content of any 5XX fields (except 502,505,511,520) - the number of pages (ex : 510p) - its language code (eng, fre...) - its publication year - its town of publication - the content of a 05X-08X field - the content of a 010-018 field - the content of a 942 subfield - the content of a 952 subfield (except barcode and callnumber) = you should not find the record each time 11/ regression test : check that specific indexes are working as usual (title, subject, callnum, barcode, pubdate etc) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #20 from mathieu saby mathieu.s...@univ-rennes2.fr --- I rewrote the patchs and add test plan. Only for GRS1 for the moment. My Koha VM is a UNIMARC DOM, so I cannot test it myself, but I hope it will work. I made 3 patchs so that somebody can test and sign Marc21 patch and somebody else UNIMARC patch. The list of fields I kept in any can be discussed, but once the patch is pushed, each library will have the ability of deleting or adding fields by modifying its zebra conf files. When we all agree on the list of fields to keep, I will make patchs for DOM. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #21 from mathieu saby mathieu.s...@univ-rennes2.fr --- I add Galen, as we had elsewhere some discussion about this patch. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr --- Of course, in test plan of UNIMARC patch, read In a UNIMARC GRS-1 Koha (and not Marc21!) M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Pushed for QA |Pushed to Master --- Comment #38 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with follow-ups, including one that adds a new tools permission for the feature. Note that I did not include your first three follow-ups as they ended up conflicting with the fix for 10636. Thanks, Kyle! I will add, however, that this made it in by the skin of its teeth, and primarily because it exercises DBIx::Class support. In particular, it was rather careless that the patch as submitted did not require staff authentication. This is a BIG deal -- even if the feature were suitable for all staff users (which is debatable for technical services staff) -- it is obviously not suitable for anybody who happens to be good add guessing URL patterns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #28 from Galen Charlton gmcha...@gmail.com --- I've pushed the main patch + all of the follow-ups + a follow-up of my own to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added CC||ro...@catalyst.net.nz Depends on||11051 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Assignee|ro...@catalyst.net.nz |gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Assignee|gmcha...@gmail.com |ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] New: Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Bug ID: 11051 Summary: Performance of opac-search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: ro...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org I did a profile of opac-search and am going to make a few improvements to it. You can see the results here: http://debian.koha-community.org/~robin/opac-search/ This was run on a production 3.12.2 system, with 10 branches, with a database server on a different machine. This means that database latency is more visible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Assignee|gmcha...@gmail.com |ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Blocks||7923 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #1 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 21988 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21988action=edit Bug 11051 - remove unneccessary SQL queries in GetBranches The way GetBranches was written, it will issue one query to get all branches, and then one query per branch for the branch relations. This patch pre-fetches the relations table (as we need it all anyway) and so makes the whole process happen in two queries, rather than take 1+N, where N is the number of branches. This might not seem like much, but when you do a search, GetBranches is called once for each result, so 25. And you might have 10 branches. This causes 275 database requests when you could get away with 50. From profiling, when you run a search, this is the thing that calls DBI::st::execute the most. Refer: http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125 Test Plan: * Have a database with branches and relationships between the branches. (these are 'Lubrary groups' in the UI. * Make sure the relationships show up correctly after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Robin Sheat ro...@catalyst.net.nz changed: What|Removed |Added Attachment #21988|0 |1 is obsolete|| --- Comment #2 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 21989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21989action=edit Bug 11051 - remove unneccessary SQL queries in GetBranches The way GetBranches was written, it will issue one query to get all branches, and then one query per branch for the branch relations. This patch pre-fetches the relations table (as we need it all anyway) and so makes the whole process happen in two queries, rather than take 1+N, where N is the number of branches. This might not seem like much, but when you do a search, GetBranches is called once for each result, so 25. And you might have 10 branches. This causes 275 database requests when you could get away with 50. From profiling, when you run a search, this is the thing that calls DBI::st::execute the most. Refer: http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125 Test Plan: * Have a database with branches and relationships between the branches. (these are 'Lubrary groups' in the UI. * Make sure the relationships show up correctly after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #3 from Robin Sheat ro...@catalyst.net.nz --- Caching on GetMarcStructure seems to actually be slower than running it. Compare: http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78 (uncached) to: http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78 (cached) That function has ~1 second difference across all its calls. Removing the memoization of GetMarcStructure should fix this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #4 from Robin Sheat ro...@catalyst.net.nz --- Created attachment 21990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21990action=edit Bug 11051 - remove caching of GetMarcStructure Profiling suggests that this is actually ~1s slower with caching enabled, probably due to serialisation overheads. Compare uncached: http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78 to cached: http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78 Test plan (please do this, more data points are good): * set up an instance with memcache available but not used * run the profiler on it * enable the use of memcache * run the profiler on it, note that the caching is being used and the code runs slower. * apply the patch * run the profiler again with memcache, note that the caching is not being used and things are back to being speedy. A quick primer to using the profiler: * apt-get install libdevel-nytprof-perl * sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211 MEMCACHED_NAMESPACE=library-koha-opac KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl 'q=a' * this will create nytprof.out in the current dir (use /tmp) * run nytprofhtml to produce HTML output. * remove/include the MEMCACHED variables to turn caching on/off globally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 Waylon Robertson wrobertson1...@gmail.com changed: What|Removed |Added Attachment #13475|0 |1 is obsolete|| --- Comment #10 from Waylon Robertson wrobertson1...@gmail.com --- Created attachment 21991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21991action=edit Multibranch search/security patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 --- Comment #11 from Waylon Robertson wrobertson1...@gmail.com --- Created attachment 21992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21992action=edit Fix for patch, fixes updatedatabase.pl mistake made by WaylonR -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 --- Comment #12 from Waylon Robertson wrobertson1...@gmail.com --- Brought the code up to the current master - 3.14 first alpha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
