[Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than any

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #23 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Maybe I could remove the changes made for authorities, as they are not really
needed, and create an other bug for improving auth indexing (index coded
fields, marc21 notes etc)

M. saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10833] Multi transport types for advanced notices

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
Bot Control|--- |Ignore this bug

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to I'm just a bot from comment #3)
 This bug depends on bug9016 which is in status Needs Signoff but the patches
 for it do not apply cleanly

It applies cleanly (but 9016 has a conflict on updatedatabase.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #18 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Koha Team Lyon 3 from comment #17)
 The principle is that the price including the tax has to be deduct from the
 budget.
 In fact, there's a bad calculation of the unit in orderreceive.pl.
 If we are in the case :
 list price include tax : YES
 invoice price include tax : NO
 So to have price including the tax, you have to add the tax to the unit
 price (unitprice+unitprice*gstrate)
 
 If we are in the case : 
 list price include tax : NO
 invoice price include tax : YES
 you have to add the tax to the estimated price 
 ecost =ecost+ecost*gstrate 
 
 this is not the case in orderreceive.pl
 
 I prepare a patch for this if everybody is ok

Hi
For me the question is : are we supposed to store a corrected price
(with/without gst) in unitprice column, or to calculate dynamicly the right
price at display?
If we store the gst corrected unitprice, it will mabye be more precise for
rounding, and it will mean if we change the vendor settings AFTER having
received a book, the remaining available amount for the fund will stay
unchanged. I suppose it will be a good behavior, but I am not completely sure.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11052] New: Missing field in french unimarc authorities framework

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11052

Bug ID: 11052
   Summary: Missing field in french unimarc authorities framework
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

103 field (date of the entity) is typical from french unimarc as it is used by
academic libraries
It must be add to Koha default auth framework for french locale.
http://documentation.abes.fr/sudoc/formats/unma/zones/103.htm

Note : 106 field and 128 field are also typical from french unimarc as it is
used by academic libraries, but they are already in Koha

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11053] New: Index notes of authorities in MARC21

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11053

Bug ID: 11053
   Summary: Index notes of authorities in MARC21
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

Authorities notes are indexed by Zebra for UNIMARC records, but not for MARC21.
We could index them in note index like for UNIMARC :
667  Nonpublic General Note  (R)
670  Source Data Found  (R)
672  Title Related to the Entity  (R)
673  Title Not Related to the Entity  (R)
675  Source Data Not Found  (NR)
678  Biographical or Historical Data  (R)
680  Public General Note  (R)
681  Subject Example Tracing Note  (R)
682  Deleted Heading Information  (NR)
688  Application History Note  (R)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #19 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Hi
yes, I understand your point of vue but I'm not sure. But, if the settings
change in the middle of year because the vendor really change his behaviour,
the invoices which have been already paid won't change. If the calculation is
dynamic, it will change the spent amount and the available, but it isn't right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #20 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Koha Team Lyon 3 from comment #19)
 Hi
 yes, I understand your point of vue but I'm not sure. But, if the settings
 change in the middle of year because the vendor really change his behaviour,
 the invoices which have been already paid won't change. If the calculation
 is dynamic, it will change the spent amount and the available, but it isn't
 right.

We made mistakes here for the settings of some vendors, and took profit of the
current behavior ;-), BUT I agree with you, the best solution would be to have
gst corrected price stored in database.

And Koha's documentation should maybe be updated to make clear that changing a
vendor setting does not change the prices of received parcels, BUT will change
the price calculation of parcels not yet receveived.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #3 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21993
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21993action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CheckBranchTransferAllowed() as a more convenient
branch transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Unit tests included which test the new C4 function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #21 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 21994
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21994action=edit
Calculation of price with the gst in ordereceive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Deployed the properly formatted patch.
Applied on our testing environment and works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks|11005, 11020, 11024 |
 Depends on||11005

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks||7376
 Depends on|7376|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi
   Assignee|kenza.z...@biblibre.com |olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in C4/Circulation.pm needs return value

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Assignee|olli-antti.kivila...@jns.fi |gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on|7376|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on|7376|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

   Assignee|jonathan.dru...@biblibre.co |olli-antti.kivila...@jns.fi
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #24 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Agreed to fix this bug for Joubu, in exchange for QA stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #21993|0   |1
is obsolete||

--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21995
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21995action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CheckBranchTransferAllowed() as a more convenient
branch transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Unit tests included which test the new C4 function.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

  Attachment #21994|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Can someone delete this attachement Refactored the IsBranchTransferAllowed()
and it's dependencies. Created test cases. and this Comment?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Your patch is marked as obsolete. A mistake?

Also, could you provide a description of what it does, and a test plan, in the
commit message ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Olli-Antti Kivilahti from comment #6)
 Can someone delete this attachement Refactored the
 IsBranchTransferAllowed() and it's dependencies. Created test cases. and
 this Comment?

You cannot delete an attachment but you can obsolete it:
click on Details  edit details  check the 'obsolete' cb and submit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #13)
 I've applied all the patches for bug 5336 before applying this one.
 Applying of this patch is OK too.
 Where is the Acquisition details tab (point 5 of the test plan)? I can't
 see it.

Paola,
On a biblio detail page. There are some tabs (like 'Holdings', 'Descriptions',
'Subscriptions', 'Images').
The 'Acquisition details' tab is between 'Subscriptions' and 'Images'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #23 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I just realize that my patch just corrected unitprice, thus the budget spent.
But I want to check if estimated cost is ok (for budget ordered) before to
propose it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #18537|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 21996
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21996action=edit
Bug 7288: Allow to display only subscriptions in the invoices table

This patch adds a checkbox Show only subscriptions in the invoices
table.
If this checkbox is checked, a filter is added on the table in order to
show only subscription invoices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|koha.sek...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #21924|0   |1
is obsolete||
  Attachment #21925|0   |1
is obsolete||

--- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21997
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21997action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21998
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21998action=edit
Bug 11020 - Transfer limits should be checked when placing a hold/reservation
in Staff client

Extended bug 11005.

Extended C4/Reserves.pm to support checking BranchTransferLimits when
requested. Extension does
in no way disturb existing functionality.

Modified the templates to show branch transfer blocks to the user.
Modified the business layer to re-check branch transfer limits in case user
fools the POST-request.

Created manual test cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks|11020   |
 Depends on||11020

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks||10993
 Depends on|10993   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #21851|0   |1
is obsolete||

--- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 21999
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21999action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22000
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22000action=edit
Bug 10993 - Transfer limits should be checked when placing a hold/reservation
in OPAC.

Depends on bug 11005, 11020

Prevents a user from placing holds on material whose branch transfer is denied.
Displays clear messages that items are
unavailable and re-checks in the business layer in case of UI blocks failing.
Enables choosing another pickup location.

Manual tests included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #21891|0   |1
is obsolete||
  Attachment #21892|0   |1
is obsolete||

--- Comment #7 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22001
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22001action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks|11024   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on|10993   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

--- Comment #1 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22002
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22002action=edit
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl
-script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #25 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
sponsored by Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Depends on||11020

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Blocks||7376

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #24 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
Created attachment 22003
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22003action=edit
correct addorder and orderreceive to store price including gst

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #25 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
This patch correct addorder.pl and orderreceive.pl to store prices including
gst in ecost and unitprice, according to the vendor preference (listinggst and
invoicegst).
The acqui-home.pl the budget summary should take into account the price
including gst.
But invoice table and basket table are not right anymore. I propose to do
others bugzilla ticket to correct this (or to complete bz10313)

Test plan is the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10461] tax not taken in to account in the acq budget summaries

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #26 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Koha Team Lyon 3 from comment #25)
 Test plan is the same.

You mean the same as comment 2?
I did not check, but as you made changes in new places (orderreceived.pl...),
does not it need needs to be updated?
And could you include a description of the patch, and the test plan within
commit message? In a general way, it makes patches more easy to test,
especially if the patch is rewritten after discussion like this one ;-)

I will take a look this evening.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #95 from Jonathan Druart jonathan.dru...@biblibre.com ---
Software error on cgi-bin/koha/members/member.pl:
Base class package DBIx::Class::Schema is empty.
(Perhaps you need to 'use' the module which defines that package first,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11054] New: Creating a child record has problems with accented Latin characters

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bug ID: 11054
   Summary: Creating a child record has problems with accented
Latin characters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When you select New child record from the catalogue detail page. If the data
that will be used to create the host field contains latin characters with
diacritics from the range covered by latin-1 they are incorrectly encoded in
the resulting child record. This is not the case with non-latin characters
(Cyrillic, Arabic and Chinese tested) and I suspect with latin diacritic
combinations that are not in the latin-1 range

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21983|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22004
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22004action=edit
Bug 11023: Toggle new status

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11054] Creating a child record has problems with accented Latin characters

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 22005
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22005action=edit
Proposed Patch

To test. 
Find a record with an accented character in the title e.g. a vowel with an
acute or grave or an n with a tilde in the detail page select new/new child
record the title will be copied into 773 $t (marc21) without the patch garbage
replaces the accented characters with the patch they appear correctly.

I've confirmed that the change does not have any detrimental effects when
copying non-latin characters e.g. Chinese, Cyrillic, Arabic which were already
being correctly copied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11054] Creating a child record has problems with accented Latin characters

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11054] Creating a child record has problems with accented Latin characters

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #22005|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 22006
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22006action=edit
[SIGNED-OFF] Bug 11054: Specify utf8 encoding when creating a child record

When the only non-ascii characters in a new child record
are latin + diacritic in the range covered by Latin-1 they
are not being added to a new child record correctly encoded.
Explicitly setting the record's encodiing ensures that
they are interpreted correctly.

see Unicode Bug in perldoc perlunicode for background on
why these characters are special

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Work as described. No koha-qa errors

Test
search for a record with diacritics on author or title
press New Child Record
without patch, 773's with mangled chars
with patch, all fine

This has nothing to do with major problems of encoding,
here we create a new record and as CPAN page states,
default encoding is MARC-8, so it's the right solution.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Patch still has updatedatabase.pl issues.

However, this comment is about the transition from one system preference to
this set of system preferences. I do think this extends the functionality of
the SearchMyLibraryFirst, but there is no attempt to translate the old system
setting to a newer but equivalent one.

I have not tested the functionalities yet, but perhaps the mapping might be
something like:
SearchMyLibraryFirst:yes = SearchableBranches:preferhome
SearchMyLibraryFirst:no  = SearchableBranches:all

I would expect to see such a transition in the -- updatedatabase.pl section of
code. Also, you can add 3 system preferences in one section of code for
updatedatabase.pl, you don't need 3 XXX sections.

As such, I'll leave the status as is, Patch doesn't apply, and await a newer
version which does apply and that has this mapping in the updatedatabase.pl
code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Comment on attachment 21974
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21974
Bug 10996 Allow numeric subfields to be stripped on export

Review of attachment 21974:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10996attachment=21974)
-

::: tools/export.pl
@@ +365,5 @@
 +my $subfield = $2;
 +
 +# skip if this record doesn't have this field
 +next if not defined $record-field($field);
 +if ($subfield) {

This is not the right test -- consider somebody who wants to exclude a subfield
$0 (zero) from export.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8589] Advanced Search for itemtype and location produces some results that are not useful

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #2 from Blou philippe.blo...@inlibro.com ---
Created attachment 22007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22007action=edit
Bug 10937 - Options to group or hide items in adv. search

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

Modified:
C4/Koha.pmGetItemTypesCategorized
admin/itemtypes.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
opac/opac-search.pl
installer/data/mysql/kohastructure.sql  Added two columns, hideinopac and
searchcategory
installer/data/mysql/updatedatabase.pl

Testing:
0) run updatedatabase.pl to add the two columns to itemtypes
1) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
2) Click button New authorized value for DOCTYPECAT
3) Enter HARDWARE as Atuhorize value, ANything as Description and Hardware
as OPAC description then click SAVE.
4) In Intranet/Koha Amind/Item types, select (at least) two different items
and proceed with the following steps
  a) Click action/Edit on the right column
  b) Third row is the search category list box, select Hardware
  c) click Save changes at the bottom
5) In Intranet/Koha Admin/Item types (again), select a different item type
and click the checkbox Hide in OPAC
6) Go to OPAC/Adv search.
7) Validate that all items modified above do not appear in Item type list
8) Validate that new item type Hardware does appear instead.
9) Select item Hardware, start Search.
10) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8619] Remove hidelostitems syspref

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

--- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr ---
this syspref is still present

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11055] New: Add 'minutes' as a load period unit

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Bug ID: 11055
   Summary: Add 'minutes' as a load period unit
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Our user likes to be able to fine by the (5) minutes for hourly loans (2h, 4h,
etc...).

One solution would be to change (hack) the fine amount and grace and... to
allow for fraction.  An easier solution is simply to add minutes as a unit.

Code change was very simple, but the Calendar and Holiday mechanisms have
changed since, so I'll see how to do it all cute again.

ALSO: One area of discussion with the user was about the meaning of a 24h loan.
 Unit=Hours, Period=24.  If the library is opened only 10h per day, this is not
a 3 day rental.  This should be a same time tomorrow, fines by the hour.

Comments welcomed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Blou philippe.blo...@inlibro.com changed:

   What|Removed |Added

 CC||eric.be...@inlibro.com
   Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] New: dead code in basketgroup.pl : remove code depending on validate param

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

Bug ID: 11056
   Summary: dead code in basketgroup.pl : remove code depending on
validate param
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

Some code is dead in basketgroup.pl
all the block depending on 
($op eq 'validate') clause

the validate parameter is no more used in template, since a Biblibre commit
has rewritten basketgroup template in 2009 : 
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=263961312c1ff7605ed1e28df40191ab01a75af9

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10565] Add a Patron List feature for storing and manipulating collections of patrons

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

--- Comment #39 from Nicole C. Engard neng...@gmail.com ---
Just did a fetch and get this error when trying to open the new tool:


Base class package DBIx::Class::Schema is empty.
(Perhaps you need to 'use' the module which defines that package first,
or make that module available in @INC (@INC contains:
/home/nengard/kohaclone /etc/perl /usr/local/lib/perl/5.10.1
/usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10
/usr/share/perl/5.10 /usr/local/lib/site_perl .).
 at /home/nengard/kohaclone/Koha/Schema.pm line 10
BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Schema.pm
line 10.
Compilation failed in require at /home/nengard/kohaclone/Koha/Database.pm line
38.
BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Database.pm
line 38.
Compilation failed in require at /home/nengard/kohaclone/Koha/List/Patron.pm
line 32.
BEGIN failed--compilation aborted at
/home/nengard/kohaclone/Koha/List/Patron.pm line 32.
Compilation failed in require at /home/nengard/kohaclone/patron_lists/lists.pl
line 26.
BEGIN failed--compilation aborted at
/home/nengard/kohaclone/patron_lists/lists.pl line 26.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10611] C4::Context-dbh checks if the DB is still running

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz
 Blocks||11051

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Depends on||10611

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-15 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #5 from Robin Sheat ro...@catalyst.net.nz ---
Profiling shows a lot of time being spend doing DBI::ping. Bug 10611 has a
solution to this that ought to be under this umbrella too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/