[Koha-bugs] [Bug 11023] Toggle new status for items

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #22004|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  ---
Created attachment 22386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22386&action=edit
Bug 11023: Toggle "new" status

This patch adds:
- a new DB field items.new.
- a new page to configure this new status
  (tools/toggle_new_status.pl).
- a new cronjob script (misc/cronjob/toggle_new_status.pl).

Why this status is useful for some libraries ?
The use cases are:
- to know easily what are the new items (with a simple sql query).
- to display an icon in the search results.
- issuing rules can be adapt for new items. Automatically (using the
  cronjob script), the status change (depending the configuration) and
  the item can be issued, for example.
- a RSS/Atom feeds can be created on these new items.

Test plan:
- log in with a librarian having the tools > items_batchmod permission.
- navigate to Home > Tools > Toggle new status
- click on the edit button
- there are 3 "blocks":
  * duration: the duration during an item is considered as new.
  * conditions: the status will change only if the conditions are meet.
  * substitutions: if there is no substitution, no action will be done.
You can add some change to apply to the matching items.
E.g. ccode=3
 new=''
If the value is an empty string (in other words, the input does not
contain anything), the field will be deleted.
  You can create as many rules as you want.
- test the interface : add/remove rule, conditions, substitutions,
  submit the form, edit, etc.
  (There is a looot of JS everywhere, so certainly a looot of bugs...).
- when you have your rules defined, you can now launch the cronjob
  script without any parameter.
  A report will be displayed with the matching itemnumber and the
  substitutions to apply. Verify results are consistent.
- launch the script with the -c argument and verify values have been
  modified depending the substitution rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #7 from Jonathan Druart  ---
There were been several iterations with Laurence. She found some bugs I fixed.
This last patch is the final version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11139] New: opac-topissues does not work with CCODE

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Bug ID: 11139
   Summary: opac-topissues does not work with CCODE
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

When OPAC most populars uses collection code, it does not work.
There are never results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Fridolyn SOMERS  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolyn SOMERS  ---
Created attachment 22387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22387&action=edit
Bug 11139 - opac-topissues does not work with CCODE

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Fridolyn SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9374] In baskets, prices between 0 and 1 are displayed in red

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9374

--- Comment #9 from Jonathan Druart  ---
(In reply to Galen Charlton from comment #8)
> Bugs 10792 and 10929 are somewhat related, as they touch on the general
> problem of  displaying monetary amounts.

For information, I proposed a similar way in bug 9410.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #32 from Paul Poulain  ---
(In reply to Olli-Antti Kivilahti from comment #30)
> "mmm... this patch has been set to "failed QA" by Aix-Marseille university,
> and a new patch has been attached. Shouldn't the status be reset to "need
> signoff" ? Otherwise, explanation welcomed !" -PP
> 
> It should. I noticed this as well but I decided to leave it as is, since
> someone had already signed this bug off. I knew it wasn't exactly a nice
> thing and was kinda hoping to skip the sign-off part.
> Obviously my behaviour was not very nice. Apologies for the misconduct.
I didn't spot any misconduct, but as long as a patch is "failed QA" no one
takes care of it, except the patch author. So if you submit a new patch, then
you need to change the status.

When a failed QA is caused by a small/minor QA problem, like an indent one,
then, it's OK to switch back to "signed off" if the patch has already been
signed off. Otherwise, back to "need signoff". But not let "failed QA" status
as it is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8199] Search results are contained into a table html element

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #7 from Jonathan Druart  ---
I don't plan to work on it.
Reopen if someone is interested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11019] Adding new category in authorized values

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paul Poulain  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10363

--- Comment #10 from Paul Poulain  ---
Considering Jonathan's patch is a large improvement, I set this one "in
discussion", until the bug 10363 has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10363] There is no package for authorised values.

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Paul Poulain  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11019

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11128] On cancelling receipt, the order is still listed in the received orders

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Paola Rossi  changed:

   What|Removed |Added

  Attachment #22350|0   |1
is obsolete||
 CC||paola.ro...@cineca.it

--- Comment #2 from Paola Rossi  ---
Created attachment 22388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22388&action=edit
On cancelling receipt, the order is still listed in the received orders

the patch is applied again master 3.13.00.032.
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #9 from Jonathan Druart  ---
Created attachment 22389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22389&action=edit
Bug 10613: FIX typo supplierid vs booksellerid

GetInvoiceDetails returns a hashref with a key named booksellerid, not
supplierid.
The bookseller was not retrieved from the DB and the listincgst value
was always false.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

--- Comment #46 from Jonathan Druart  ---
Created attachment 22390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22390&action=edit
Bug 8037: FIX bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #20 from Fridolyn SOMERS  ---
(In reply to mathieu saby from comment #19)
> I don't know at all how to do this
I will provide a QP follow-up for this bug 10740, to add
"date-time-last-modified".
I noticed that in QP all indexes are lowercase.
So in the end I wonder why not use everywhere : "date-time-last-modified" and
not "Date/time-last-modified".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolyn SOMERS  changed:

   What|Removed |Added

  Attachment #22262|0   |1
is obsolete||

--- Comment #21 from Fridolyn SOMERS  ---
Created attachment 22391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22391&action=edit
Bug 10740 - date created and modified indexes in ccl.properties and QP

Revised patch.
Date/time-last-modified converted in date-time-last-modified for QP.
I think using / in an index would have provoke bugs is future.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11009] Do not allow reading records of anonymous patron

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

--- Comment #9 from Fridolyn SOMERS  ---
I've set this as major because it may really block the server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22185|0   |1
is obsolete||

--- Comment #181 from Kyle M Hall  ---
Created attachment 22392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22392&action=edit
Bug 8015 - Add MARC Modifications Templates

The MARC Modification Templates system gives Koha users
the power to make alterations to MARC records automatically
while staging MARC records for import.

This tool is useful for altering MARC records from
various venders work with your MARC framework.

The system essentially allows one to create a basic script
using actions to Copy, Move, Add, Update and Delete fields.

Each action can also have an optional condition to check
the value or existance of another field.

The Copy & Move actions also support Regular Expressions,
which can be used to automatically modify field values during the
copy/move. An example would be to strip out the '$' character
in field 020$c.

Furthermore, the value for an update can include variables
that change each time the template is used. Currently,
the system supports two variables, __BRANCHCODE__ which
is replaced with the branchcode of the library currently
using the template, and __CURRENTDATE__ which is replaced
with the current date in ISO format ( -MM-DD ).

At its simplist, it can perform functions such as:
Copy field 092$a to 952$c
At its most complex it can run actions like:
Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/

Signed-off-by: Leila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22187|0   |1
is obsolete||

--- Comment #183 from Kyle M Hall  ---
Created attachment 22394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22394&action=edit
Bug 8015 - Add MARC Modifications Templates - Followup

Signed-off-by: Leila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22188|0   |1
is obsolete||

--- Comment #184 from Kyle M Hall  ---
Created attachment 22395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22395&action=edit
Bug 8015: Followup Add MARC Modifications Templates

Signed-off-by: Kyle M Hall 
Signed-off-by: Leila 

Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall 
Signed-off-by: Leila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22189|0   |1
is obsolete||

--- Comment #185 from Kyle M Hall  ---
Created attachment 22396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22396&action=edit
Bug 8015: Fix template capitalization amd other template issues

Signed-off-by: Leila 

Bug 8015: Fix error where field object is returned instead of field value for
fields without subfields

Signed-off-by: Leila 

Bug 8015: Fix bad ordering on function parameters

Signed-off-by: Leila 

Bug 8015: Escape escape characters for strings

Signed-off-by: Leila 

Bug 8015: Fix bad parameter list for direct external call to update_field

Signed-off-by: Leila 

Bug 8015: Fix problem with moving existing subfield value to nonexistent
field/subfield

Signed-off-by: Leila 

Bug 8015: FIX QA issues

This patch fixes some stuffs failing qa tests: POD, indentation (tabs),
perlcritic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22190|0   |1
is obsolete||

--- Comment #186 from Kyle M Hall  ---
Created attachment 22397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22397&action=edit
Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines

Signed-off-by: Kyle M Hall 

Bug 8015: Fix complains from qa tools

Signed-off-by: Bernardo Gonzalez Kriegel 

Bug 8015: Get rid of the eval in ModifyRecordWithTemplate

This patch removes the use of eval in the
C4::MarcModificationTemplates::ModifyRecordWithTemplate routine.

Now this routine call the wanted modification routine with the list of
parameters.
This call is done only if the condition is respected.

Signed-off-by: Bernardo Gonzalez Kriegel 

Bug 8015: Get rid of eval for evaluating =~ m//

Koha::SimpleMarc::field_equals uses eval in order to check if a string
matches a pattern.
Now this eval is removed and the "regex" variable does not contain the
regex separated character (/ or |).

Regression: Before this patch, the user was able to user a modifier. Now
it is not possible.

Signed-off-by: Bernardo Gonzalez Kriegel 

Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

Signed-off-by: Bernardo Gonzalez Kriegel 

Bug 8015: FIX ui issue

Signed-off-by: Bernardo Gonzalez Kriegel 

Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22285|0   |1
is obsolete||

--- Comment #188 from Kyle M Hall  ---
Created attachment 22399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22399&action=edit
Bug 8015: Remove references to C4::Koha::Log

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22284|0   |1
is obsolete||

--- Comment #187 from Kyle M Hall  ---
Created attachment 22398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22398&action=edit
Bug 8015: Add user permissions to all languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22293|0   |1
is obsolete||

--- Comment #190 from Kyle M Hall  ---
Created attachment 22401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22401&action=edit
Bug 8015: QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22290|0   |1
is obsolete||

--- Comment #189 from Kyle M Hall  ---
Created attachment 22400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22400&action=edit
Bug 8015: QA Followup

* Add bug number to database update
* Fix capitalization errors
* Fix JavaScript string translation errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22186|0   |1
is obsolete||

--- Comment #182 from Kyle M Hall  ---
Created attachment 22393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22393&action=edit
Bug 8015: Followup: FIX cp and mv if subfields don't exist.

Signed-off-by: Kyle M Hall 
Signed-off-by: Leila 

Bug 8015: Followup: On move, we cant delete existing fields

Signed-off-by: Kyle M Hall 
Signed-off-by: Leila 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21688|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 22402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22402&action=edit
bug_10781: Removed ILSDI::Utility

Test:
This should be a noop. Regression testing required:
/cgi-bin/koha/ilsdi.pl functioanality, in particuler:
GetAvailability - ?service=Describe&verb=GetAvailability
AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron

ILS-DI syspref must be turned on

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22327|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 22403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22403&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21989|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 22405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22405&action=edit
Bug 11051 - remove unneccessary SQL queries in GetBranches

The way GetBranches was written, it will issue one query to get all
branches, and then one query per branch for the branch relations.
This patch pre-fetches the relations table (as we need it all anyway)
and so makes the whole process happen in two queries, rather than take
1+N, where N is the number of branches.

This might not seem like much, but when you do a search, GetBranches is
called once for each result, so 25. And you might have 10 branches. This
causes 275 database requests when you could get away with 50.

>From profiling, when you run a search, this is the thing that calls
DBI::st::execute the most. Refer:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125

Test Plan:
* Have a database with branches and relationships between the branches.
  (these are 'Lubrary groups' in the UI.
* Make sure the relationships show up correctly after applying the
  patch.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22404|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 22406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22406&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

Signed-off-by: Kyle M Hall 
Passes koha-qa.pl and all unit tests. No errors detected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21990|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 22404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22404&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

Signed-off-by: Kyle M Hall 
Passes koha-qa.pl and all unit tests. No errors detected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21431|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 22407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22407&action=edit
Bug 10944 - Mixed content warnings in opac results and detail with Amazon
images on https

It's probably going to become more popular to run Koha in SSL environments.
Currently on ssl, with Amazon images enabled, a SSL enabled site will either
not show Amazon images (IE, some versions of Firefox?), or show a warning to
users about mixed secure and insecure content (Firefox, Chrome).

Since we now have the using_https template variable, it makes sense to use it.

To test:

In each browser you have access to, and preferably with SSL set up
(you can set up a self signed cert for your dev install by following, more or
less, the instructions here: https://wiki.debian.org/Self-Signed_Certificate)

For the apache config, just copy the one for the OPAC, but set it to use 443
instead of 80 for the port, and point it to your keys per the instructions
above.

** note that using a self signed cert on your dev install will prompt you when
you connect the first time
that OMG I CAN'T VERIFY THIS IS COOL. You did it yourself, if you can't trust
yourself... then who can you trust?

* Enable Amazon images in the system preferences
* Do a search that you know will have images for, verify that without SSL
1. the images show
2. the image source is from an Amazon url that uses http://
3. the images are the right size, and look ok
* Do the same using https, verify that with SSL
1. the images show
2. the image source is from an Amazon url that uses https://
3. the images are the right size, and look ok

Clicking on the image should link to the item on Amazon. This patch also
corrects a problem with the Amazon url used on the images -
it was pointing to a feature that is currently unavailable. That's fixed here.
All you need to check is that it goes to a valid Amazon endpoint that doesn't
show an error.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #22403|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #3 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Koha team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #4 from sandbo...@biblibre.com  ---
Created attachment 22408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22408&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

 To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Koha team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21886|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 22409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22409&action=edit
Bug 10944 - Mixed content warnings for covers on staff client

This switches the URLs used to access Amazon's cover images to the SSL image
server, preventing warnings when using this on a secure site.

To test:
* Enable Amazon images in the sysprefs, all other cover images off.
* Do a search in the staff client. Using firebug or similar, inspect the
  images that indicate both "no image found" and the covers.
* Are they all https, and showing correctly?

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #5 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Koha team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #6 from sandbo...@biblibre.com  ---
Created attachment 22410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22410&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

 To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Koha team AMU 

Signed-off-by: Koha team AMU 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron Messaging Preferences Form

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #22408|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11051] Performance of opac-search

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #18 from Kyle M Hall  ---
Looks like the table borrower_password_recovery was left out of the database
update by accident.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11140] New: Centralize all sending of email to one subroutine

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140

Bug ID: 11140
   Summary: Centralize all sending of email to one subroutine
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

To reduce the chances of introducing bugs related to sending emails, and to
follow the DRY principle, we should consolidate all calls to sendmail into a
single subroutine such that any system preferences or other logic that alters
how we send emails can be centralized.

For example, bug 8000 and bug 8753, if both pushed, would introduce a bug into
Koha if nobody noticed, since there would be no merge conflicts or unit test
failures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11141] New: Filters are not kept on receiving

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Bug ID: 11141
   Summary: Filters are not kept on receiving
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

On receiving orders, the librarian has to filter again the pending orders list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11140] Centralize all sending of email to one subroutine

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||8000

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8000] Test mode for notices

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Depends on||11140

--- Comment #9 from Kyle M Hall  ---
(In reply to Blou from comment #8)
> I'd go one step further: All emailing should go through one and only one
> Koha method.
> It's good practice to have system calls isolated so that when upgrade or a
> new platform require adjustment, we don't need to run around touching 10
> files.
> Or when we simply want to improve the process with validation...
> 
> I'd be happy to do that... on a different bug :)

I completely agree, to the point that I think we whould *require* the
centralization of this code, and this patch depend on said centralization.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11141] Filters are not kept on receiving

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

--- Comment #1 from Owen Leonard  ---
Created attachment 22411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22411&action=edit
Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Applying: Sponsor: Vanier college
/home/koha/kohaclone/.git/rebase-apply/patch:24: tab in indent.
LEFT JOIN authorised_values ON searchcategory = authorised_value
WHERE searchcategory > ''
/home/koha/kohaclone/.git/rebase-apply/patch:62: tab in indent.
quantity SMALLINT(6) default NULL, -- suggested quantity to be
purchased
/home/koha/kohaclone/.git/rebase-apply/patch:63: tab in indent.
currency VARCHAR(3) default NULL, -- suggested currency for the
suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:64: tab in indent.
price DECIMAL(28,6) default NULL, -- suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:65: tab in indent.
total DECIMAL(28,6) default NULL, -- suggested total cost
(price*quantity updated for currency)
fatal: sha1 information is lacking or useless (C4/Koha.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Sponsor: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

--- Comment #2 from Owen Leonard  ---
I should specify: This patch is for the prog template. A separate bug will
address the bootstrap template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11142] New: Update Bootstrap theme's place hold form to match the new version in prog

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Bug ID: 11142
   Summary: Update Bootstrap theme's place hold form to match the
new version in prog
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

A change was recently made to the place hold form in the prog theme. This
change needs to be made to the Bootstrap theme as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11141] Filters are not kept on receiving

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11141] Filters are not kept on receiving

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

--- Comment #1 from Jonathan Druart  ---
Created attachment 22412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22412&action=edit
Bug 11141: Filters are not kept on receiving.

On receiving orders, the librarian has to filter again the pending
orders list.

This patch stores the filters in a cookie in order to apply them when
the librarian finish a receive and come back on the pending orders list.

Test plan:
1/ choose a vendor with several baskets and orders.
2/ start to receive an item.
3/ on the pending orders page, add some relevant filters.
4/ receive an item.
5/ you are back on the pending orders page and filters are directly
applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11143] New: Upload Patron Image only loads some images

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11143

Bug ID: 11143
   Summary: Upload Patron Image only loads some images
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: dr...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 22413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22413&action=edit
grep picture-upload.pl

The Upload Patron Image tool does not work with batches as intended.  Some
load. Some do not load. There is no indication of what makes one image load and
another not load. 

The file, DATALINK.TXT, matches the user id to the image name correctly, but
only some of the images in the compressed folder load.   

Error log attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #43 from Nicole C. Engard  ---
Created attachment 22414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22414&action=edit
Bug 10671: Update Reports Help

Update all of the reports related help files.

To test:

* Visit report pages and confirm that text and links
are right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #44 from Nicole C. Engard  ---
Changing back to needs signoff for the new patches - but note that most of
these are signed off and ready for qa

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Owen Leonard  changed:

   What|Removed |Added

  Attachment #20682|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

--- Comment #16 from Kyle M Hall  ---
Initial patch was pushed to master. These followups are covered by bug 10626,
and thus are not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Owen Leonard  changed:

   What|Removed |Added

  Attachment #20582|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22311|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 22416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22416&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

Seems a new file circ/offline-mf.tt got added with hotkeys.js.  I replaced it
but I couldn't find ANY usage of it to fix.

Rebased and fixed.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #21952|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 22415
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22415&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

To old plugin prevents the upgrade to the latest jquery.  By replacing with
openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest.

Changes:
- removed jquery.hotkeys.min.js
- added shortcut.js
- modified the related includes (doc-head-close.inc and help-top.inc)
- modified the calls in staff-global.js

Regression test:
1) apply the patch
2) in the intranet, test the shortcuts alt-q, alt-r, alt-u.

These are the only affected functionalities.  There is no new functionnality.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8074] Define default library for holds to pull report

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
I think this patch has the potential to cause a bit of confusion. The holds to
pull table has a branch filter already, and this adds a second branch filter. I
think it would be better to utilize the existing branch filter. You will need
to trigger it via javascript, either during the generation of the datatable if
possible, or after the datatable has been created if not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6113] enhancement to keep previous ids

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||k...@bywatersolutions.com

--- Comment #24 from Kyle M Hall  ---
Would it be possibly better to solve this using bug 8015 as a basis? It's a
more extensible/flexible system and we could easily modify bulkmarcimport.pl to
allow the use of modification templates. I know it means tossing this existing
work, but I'd say it's usually better to have less code than more code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11005] Centralize the UseBranchTransferLimits-check under one function

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
perl t/db_dependent/Circulation/CanItemBeTransferred.t
1..20
Running tests for ccode
ok 1 - Successful branch transfer, full parameters
not ok 2 - Failing branch transfer, full parameters
#   Failed test 'Failing branch transfer, full parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 25.
#  got: '1'
# expected: 'CPL->IPT->FANTASY'
ok 3 - Successful branch transfer, full parameters, no Biblio defined
not ok 4 - Failing branch transfer, full parameters, no Biblio defined
#   Failed test 'Failing branch transfer, full parameters, no Biblio defined'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 31.
#  got: '1'
# expected: 'CPL->IPT->FANTASY'
ok 5 - Successful branch transfer, using defaults for $fromBranch
not ok 6 - Failing branch transfer, using defaults for $fromBranch
#   Failed test 'Failing branch transfer, using defaults for $fromBranch'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 37.
#  got: '1'
# expected: 'CPL->IPT->FANTASY'
ok 7 - Successful branch transfer, using minimum parameters
not ok 8 - Failing branch transfer, using minimum parameters
#   Failed test 'Failing branch transfer, using minimum parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 43.
#  got: '1'
# expected: 'CPL->IPT->FANTASY'
ok 9 - Successful branch transfer, using minimum parameters
ok 10 - Not failing branch transfer, because CCODE cannot be found from the
item and it is not a part of the biblio.
Running tests for itemtype
ok 11 - Successful branch transfer, full parameters
not ok 12 - Failing branch transfer, full parameters
#   Failed test 'Failing branch transfer, full parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 63.
#  got: '1'
# expected: 'CPL->IPT->BK'
ok 13 - Successful branch transfer, full parameters, no Biblio defined
not ok 14 - Failing branch transfer, full parameters, no Biblio defined
#   Failed test 'Failing branch transfer, full parameters, no Biblio defined'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 69.
#  got: '1'
# expected: 'CPL->IPT->BK'
ok 15 - Successful branch transfer, using defaults for $fromBranch
not ok 16 - Failing branch transfer, using defaults for $fromBranch
#   Failed test 'Failing branch transfer, using defaults for $fromBranch'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 75.
#  got: '1'
# expected: 'CPL->IPT->BK'
ok 17 - Successful branch transfer, using minimum parameters
not ok 18 - Failing branch transfer, using minimum parameters
#   Failed test 'Failing branch transfer, using minimum parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 81.
#  got: '1'
# expected: 'CPL->IPT->BK'
ok 19 - Successful branch transfer, using minimum parameters, itemtype is
pulled from Biblio
not ok 20 - Failing branch transfer, using minimum parameters, itemtype is
pulled from Biblio
#   Failed test 'Failing branch transfer, using minimum parameters, itemtype is
pulled from Biblio'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 87.
#  got: '1'
# expected: 'CPL->IPT->BK'
# Looks like you failed 9 tests of 20.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #20545|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 22417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22417&action=edit
Bug 10776 - subscription notification screen has awkward wording

to test:
- make a subscription available to be notified about
- log into the opac, click the subscriptions tab, then More details
- click "Subscribe to email notification on new issues"
- observe the text without the patch - there seems to be an extra "arrive?"
- apply the patch, refresh - wording should flow a bit better.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22411|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 22418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22418&action=edit
Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2310] Delete grayed out w/out explanation

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2310] Delete grayed out w/out explanation

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22195|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 22419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22419&action=edit
Bug 2310 - Delete grayed out w/out explanation

With some staff client menus options are displayed as disabled when the
logged in user doesn't have permission to perform that function. This
patch adds Bootstrap tooltips to patron menu items with text explaining
why they are disabled.

To test, log in as a user who lacks permission to modify patrons or set
permissions. Open a patron record in circulation or patrons. Hovering
over renew, delete, and set permissions links (in the patron toolbar
"More" menu) should trigger a tooltip with a brief explanation.

Test the "Update child to adult patron" link by viewing an adult patron.

A separate patch will address catalog menu items.

Signed-off-by: Kyle M Hall 
Great design!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22374|0   |1
is obsolete||

--- Comment #46 from Kyle M Hall  ---
Created attachment 22421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22421&action=edit
Bug 10671: Update Offline Circ Help

This patch updates the offline circulation help files.

To test:

Visit the KOC file upload and pending transactions page
Review the help and check the links

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22377|0   |1
is obsolete||

--- Comment #49 from Kyle M Hall  ---
Created attachment 22424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22424&action=edit
Bug 10671: Update holds help

This patch updates the manual link in the holds help
file.

To test:

* Place a hold in the staff client
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22376|0   |1
is obsolete||

--- Comment #48 from Kyle M Hall  ---
Created attachment 22423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22423&action=edit
Bug 10671: Update Reviews Help

This patch updates the link to the manual in the comments
moderation help.

To test:

* Visit comments moderation
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22375|0   |1
is obsolete||

--- Comment #47 from Kyle M Hall  ---
Created attachment 22422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22422&action=edit
Bug 10671: Remove Unused Help File

This patch removes an unused help file in the help/export
folder.

To test:

Just confirm that the file is removed, there were no links
to it anymore.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22414|0   |1
is obsolete||

--- Comment #50 from Kyle M Hall  ---
Created attachment 22425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22425&action=edit
Bug 10671: Update Reports Help

Update all of the reports related help files.

To test:

* Visit report pages and confirm that text and links
are right.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22372|0   |1
is obsolete||

--- Comment #45 from Kyle M Hall  ---
Created attachment 22420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22420&action=edit
Bug 10671: Update Circ Help Files

This patch updates the existing help files and
adds the missing offline circ help file.

To test:

* Visit all circ pages and check the manual links
* Visit the new offline circulation page and confirm text
and link are there (link will work after 10/25)

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
perl t/db_dependent/GetHiddenItems_PatronCategory.t
1..22
ok 1 - use C4::Items;
ok 2 - LIB1 Item linked to correct biblionumber.
ok 3 - LIB1 Item linked to correct biblioitemnumber.
ok 4 - LIB2 Item linked to correct biblionumber.
ok 5 - LIB2 Item linked to correct biblioitemnumber.
$VAR1 = {
  'firstname' => 'Sample',
  'userid' => 'Sample.Borrower',
  'categorycode' => 'PT',
  'phone' => '967-',
  'zipcode' => 'H0H 0H0',
  'surname' => 'Borrower',
  'email' => 'sa...@northpole.com',
  'city' => 'Bogusville',
  'address' => '123 Bogus Street',
  'branchcode' => 'LIB1'
};

# Sample Borrower added.
CHECK: 54
xJZNdcnysc
# 116 - LIB1
# 117 - LIB2
ok 6 - OpacHiddenItems hid everything correctly.
# 116,117
# Borrower number: 54
# Sample Borrower environment variables set up.
not ok 7 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 125.
#  got: 2
# expected: 0
# PatronSingleBranch: SPT
# PatronEveryBranch: SPT
# 116,117
not ok 8 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 133.
#  got: 2
# expected: 1
# PatronSingleBranch: SPT
# PatronEveryBranch: SS
# 116,117
not ok 9 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 141.
#  got: 2
# expected: 1
# PatronSingleBranch: SPT
# PatronEveryBranch: ''
# 116,117
not ok 10 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 149.
#  got: 2
# expected: 0
# PatronSingleBranch: SPT
# PatronEveryBranch: SS|SPT
# 116,117
not ok 11 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 157.
#  got: 2
# expected: 0
# PatronSingleBranch: SS
# PatronEveryBranch: SPT
# 116,117
ok 12 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS
# 116,117
ok 13 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: ''
# 116,117
not ok 14 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 181.
#  got: 2
# expected: 0
# PatronSingleBranch: SS
# PatronEveryBranch: SS|SPT
# 116,117
not ok 15 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 189.
#  got: 2
# expected: 0
# PatronSingleBranch: ''
# PatronEveryBranch: SPT
# 116,117
ok 16 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS
# 116,117
ok 17 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: ''
# 116,117
not ok 18 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 213.
#  got: 2
# expected: 0
# PatronSingleBranch: ''
# PatronEveryBranch: SS|SPT
# 116,117
not ok 19 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 221.
#  got: 2
# expected: 0
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SPT
# 116,117
not ok 20 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 229.
#  got: 2
# expected: 1
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS
# 116,117
not ok 21 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 237.
#  got: 2
# expected: 1
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: ''
# 116,117
not ok 22 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 245.
#  got: 2
# expected: 0
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS|SPT
# 116,117
# 

[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22378|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 22426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22426&action=edit
Bug 11136 - action_logs should be a MyISAM table, not InnoDB

The table action_logs is written too at a higher rate than practically
any other table. Additionally, action_logs has no foreign key
constraints. It seems that this would be a somewhat unique situation
where using MyISAM would provide quite a performance boost for large
sites with many transactions that use the Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11136] action_logs should be a MyISAM table, not InnoDB

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

--- Comment #4 from Kyle M Hall  ---

> 1) In fact it is an DB update, so the patch needs to change also 
>  installer/data/mysql/kohastructure.sql

Yep, I just thought of that too!

> 2)Are we sure that is a good idea to use two different engine of MySQL at
> same time in Koha ?
> Reading those two pagees we can think that mixing InnoDB and MySQL needs a
> quite tuning to be useful:

We already have MyISAM tables, so there is already precedent for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #39 from Paul Poulain  ---
Kyle, could you confirm that/if the problem exist BEFORE the path please ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22267|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 22427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22427&action=edit
Bug 2: Koha::Calendar needs some caching

holidays is built each time a Koha::Calendar object is created.

The Koha::Calendar's builder retrieves all holidays from the database
and create a DateTime::Set object with all holidays.

In one of our customer's DB, there are 11085 special_holidays and 598
repeatable_holidays.
On a return, there are 3 calls to Koha::Calendar->new.

Nytprof benchmarks (on a 3.8.x branch):
In DateTime::Set->from_datetimes:
3 times (5.49ms+4.90s) by Koha::Calendar::_init at line 80 of Koha/Calendar.pm,
avg 1.63s/call
on a total of 7.67s (of 10.2s), executing 635 statements and 3031273
subroutine calls in 147 source files and 36 string evals.
for the circulation/return.pl page.

Comparing the access_log:

Without the patch:
checkout: time=2759838
checkin: time=1832751

Without the patch and with overdues:
checkout: time=1086727 + time=1144706
checkin: time=3928854 (x2)

With the patch and overdues:
checkout: time=1077839 + time=1060886
checkin: time=2420898

Test plan:
- checkout an item with a return date < today
- checkin the item and verify the suspension period is well calculated
  (depending on the holidays).
- prove t/db_dependent/Holidays.t
- t/Calendar.t

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10750] Correct capitalization on suggestion form in OPAC

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #22161|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 22428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22428&action=edit
Bug 10750: Correct capitalization on suggestion form in OPAC

Create a new suggestion from your patron account in the OPAC.
Verify that all strings are correctly capitalized on the form
and submit buttons.

- Copyright date
- Standard number ... and other
- Submit your suggestion

Signed-off-by: Dani Elder 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3934] move test prediction pattern button

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3934] move test prediction pattern button

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

--- Comment #8 from Kyle M Hall  ---
Created attachment 22429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22429&action=edit
Bug 3934 - move test prediction pattern button

On the subscription add/edit screen the buttons related to numbering
patterns are grouped with the "save" button, which is potentially
confusing. This patch moves the buttons into the "serials planning"
region so they are visually grouped with related functionality.

Unrelated changes: Removed a few redundant "javascript:"
pseudo-protocols from event handlers, and added a "Cancel" link.

To test, edit an existing subscription and confirm that the prediction
pattern buttons are grouped inside the "serials planning" region.
Confirm that each button triggers the correct event. Confirm that
clicking the "cancel" link returns you to the subscription detail view.

Also test creating a new subscription. Again buttons should work
correctly. The "Cancel" link should return you to the Serials module
home page.

Signed-off-by: Paola Rossi 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10735] koha-dump not working

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735

Fabio Tiana  changed:

   What|Removed |Added

 CC||fabio.t...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #19 from Blou  ---
Created attachment 22430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22430&action=edit
Bug 8753 - Add forgot password link to OPAC

Added the missing updatedatabase.pl script to add the table
borrower_password_recovery and the preference OpacResetPassword.
Modified kohastructure.sql to use InnoDB

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #20 from Blou  ---
Well, seems I'm fully forgot updatedatabase.pl in first patch.
Rebased and fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from M. Tompsett  ---
This is because you failed to apply bug 10900 first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list

2013-10-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Joy Nelson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >