[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

Bob Birchall b...@calyx.net.au changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22435|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22680
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22680action=edit
Bug 1: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

Signed-off-by: Ed Veal ed.v...@bywatersolutions.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Changed basketgroup to basket group to match spelling on other
pages.
Works as described, passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22681
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22681action=edit
Bug 1: UT: SearchOrders returns keys basketgroupid and basketgroupname

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr ---
(In reply to Fridolyn SOMERS from comment #20)
 (In reply to mathieu saby from comment #19)
  I don't know at all how to do this
 I will provide a QP follow-up for this bug 10740, to add
 date-time-last-modified.
 I noticed that in QP all indexes are lowercase.
 So in the end I wonder why not use everywhere : date-time-last-modified
 and not Date/time-last-modified.

In ccl.properties, there are a lot of aliases differing from the main index
only in terms of capitalisation (Notes notes etc).
I always wondered if it was necessary or not...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22681|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22683
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22683action=edit
Bug 1: UT: SearchOrders returns keys basketgroupid and basketgroupname

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22680|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22682
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22682action=edit
Bug 1: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

Signed-off-by: Ed Veal ed.v...@bywatersolutions.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Changed basketgroup to basket group to match spelling on other
pages.
Works as described, passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

  Attachment #22677|0   |1
is obsolete||

--- Comment #5 from Frédéric Demians frede...@tamil.fr ---
Created attachment 22684
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22684action=edit
Signed-off patch

Print label for search on 106 field is not correct in UNIMARC advanced
search:

- 106 field can be used for non printed ressources (manuscript...)
- Print is ambiguous for translation tool, as it can be understood as
  a verb or a noun.

The official label for 106 field is Type of form.  The offical label
for 106$a subfield is Medium designator.

I think Physical presentation is the best way to describe the content
of 106$a in a user understandable label.

Test plan :

Check the Print label is replaced with Physical presentation in OPAC
(prog theme and Bootstrap theme) and Staff Advanced Search

Signed-off-by: Frédéric Demians f.demi...@tamil.fr

OK for me. Make sense for UNIMARC users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #93 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to mathieu saby from comment #92)
 Are these renaming really needed? Are they made for avoiding confusion
 somewhere in code?

I wrote this patch 18 months ago, so I don't know why I renamed these fields.
Certainly I preferred to use unitpricesupplier rather than rrp. But
unitpricelib is not a good choice...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11198] New: KOHA INSTALLATION

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11198

Bug ID: 11198
   Summary: KOHA INSTALLATION
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: sh...@virtusindia.com
QA Contact: testo...@bugs.koha-community.org

The Koha online catalog is offline for system maintenance. We'll be back soon!
How

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
back to need QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Small patch |Medium patch
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
Looks good.
3 remarks:
1/ format_date should be removed (use the TT plugin) - not introduced by these
patches
2/ CURRENT_DATE is a mysqlism
3/ I would prefer GetReservesFromItemnumber returns only a reserve hashref
(what I did for bug 8367).

I will provide a followup for 1 and 2.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22646|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22688
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22688action=edit
Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22644|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22686
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22686action=edit
Bug 9788: Followup removing the alldates parameter

Before bug 9788 the alldates parameter of GetReservesFromItemnumber was
actually not used in the codebase.
The first patch of bug 9788 did change that and passed true by default.

But a closer look revealed that we do not really need it.
The parameter is removed by this patch; the SQL statement is slightly
adjusted: if reservedate=now or a waitingdate is filled for the
requested itemnumber, GetReservesFromItemnumber will return the reserve.
This includes so-called future waits: a future hold that has been confirmed
ahead of time with pref ConfirmFutureHolds  0 days.

Note that future item-level holds are not really interesting to return; this
just corresponds to original behavior. Future next-available holds are not
in view at all; they do not contain an item number.

Test plan:
Actually, the test plan of the first patch is valid. But for completeness I
repeat it here:

[1] Enable future holds and set ConfirmFutureHolds to 2 days.
[2] Place a future next-available hold for 2 days ahead.
[3] Check item status on catalogue detail. Available? That is fine.
[4] Confirm the future hold by checking it in. ('future wait')
[5] Look at item status again on catalogue detail. Must be Waiting now.
[6] Switch to OPAC and login as another opac user. Goto Place a hold.
[7] Check item status with item level hold info. Is it waiting?
[8] Try to place hold in staff, check item level status again. Waiting?
[9] Make a transfer for the item. Switch branch. Check hold status on
Transfers to receive.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22643|0   |1
is obsolete||

--- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22685
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22685action=edit
Bug 9788: Improvements when calling GetReservesFromItemnumber

Description:
GetReservesFromItemnumber also returns waiting date. Simplifies some code.
Improves item status display on catalogue detail, when placing a hold at
opac-reserve and in staff, and on transfers to receive form.

This patch builds on work from reports 9367 and 9761.

Test plan:
Place a future next-av. hold (enable future holds prefs), say 2 days ahead.
Check item status on catalogue detail. Nothing to see.
Enable ConfirmFutureHolds by inserting a number of days, say 2.
Confirm earlier hold by checking it in. Look at item status again on detail.
Switch to other opac user. Try to place a hold again. Check item status with
item level hold info. Try to place hold in staff, check item level status.
Make a transfer for that item. Switch branch. Look at transfers to receive.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22689
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22689action=edit
Bug 9788: QA followup

1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS
date).
2/ The date formatting should be done in the template (using the TT
plugin).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22645|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22687
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22687action=edit
Bug 9788: Followup for expirationdate in Letter.pm

Pasting comment from the Bugzilla report:
Looking bit longer at this code, it is kind of strange to find it there in the
first place. Adding maxpickupdelay in Letters.pm should not be there, but it
is..

Also this date is not used normally in the default HOLD Available for Pickup
notice (that we are generating in this case). And if it would be undef, the
expiration date should imo be empty instead of today+0. (before adding
maxreservespickupdelay, you should test the allowexpire pref first)
So it is an (invisible) bug on its own.

Test plan:
See former patch. Kyle just discovered this bug, apparently by deleting the
maxpickupdelay pref..

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 QA Contact||jonathan.dru...@biblibre.co
   ||m

--- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
Works as described.
There is a typo in updatedb (wthdrawn vs withdrawn).
The itemlost date (itemlost_on value) should be display only if the itemlost
value is set (!= ).
I will submit a followup.
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21730|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22690
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22690action=edit
Bug 9673 - Track when items are marked as lost or withdrawn

Add date fields to track when an item was marked as lost or withdrawn.
Display those fields on catalogue/moredetail.pl

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Pick a record with items, browse to the 'items' tab ( moredetail.pl )
4) Mark an item as lost, verify the field Lost on: displays below
   the Lost status field with todays date.
5) Mark the item as not lost, verify the field no longer displays
6) Repeat steps 4 and 5 with the Withdrawn field.

Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21731|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22691
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22691action=edit
Bug 9673: QA followup

This followup fixes the wthdrawn typo exist in updatedatabase.pl and
does not display the lostitem date if the lostitem value is not set (!=
).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

--- Comment #54 from Jonathan Druart jonathan.dru...@biblibre.com ---
I forgot to mention: I squashed the 2 patches (second patch fixed the typo and
was not useful for the history).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #22324|0   |1
is obsolete||

--- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22692
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22692action=edit
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl
-script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22689|0   |1
is obsolete||

--- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22693
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22693action=edit
Bug 9788: QA followup

1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS
date).
2/ The date formatting should be done in the template (using the TT
plugin).

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #56 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #49)
 1/ format_date should be removed (use the TT plugin) - not introduced by
 these patches
 2/ CURRENT_DATE is a mysqlism
 3/ I would prefer GetReservesFromItemnumber returns only a reserve hashref
 (what I did for bug 8367).
 
 I will provide a followup for 1 and 2.

Thanks, Jonathan.
I would suggest to open a new report for your third point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #22692|0   |1
is obsolete||

--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22694
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22694action=edit
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl
-script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22684|0   |1
is obsolete||
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22695
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22695action=edit
Bug 11189 : Rename Print label in UNIMARC advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
String patch.
Will be for 3.16
Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #22357|0   |1
is obsolete||

--- Comment #33 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 22696
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22696action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CanItemBeTransferred() call
IsBranchTransferAllowed().
*Made a unit test library out of CanItemBeTransferred.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #21205|0   |1
is obsolete||

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22697action=edit
Bug 10648 - In records merge greatest field can not be added

When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination
record is build using the fields and subfields checked in source records.
When a field is checked, the javascript code searches in destination record a
field with a greater tag number to insert new field before.
When the new field tag number is greater than all existing field tag numbers,
the field is not added.

This patch corrects this by adding at end if no greater field tag number
exists. Also adds a sort of fields by tag number because all mergo code is
based on this.

Test plan :
- Add to a framework a repeatable field with the greater non existing tag
number. For example 998.
- Edit 2 records with this framework and add them a value in this tag.
- Put those records is a list
- Go to this list and check the two records
- Click on Merge selected
- Click on next
- Go to second source record
- Click on the greatest tag number. for example 998.
= The field is added at the end of destination record

Signed-off-by:Mathieu Saby mathieu.s...@univ-rennes2.fr

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment: 
Good catch. No string changes. Looks good to me. No complaints from qa tools.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Component|Lists   |Cataloging
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #46 from Paola Rossi paola.ro...@cineca.it ---
against master 3.13.00.042:
Applying: Bug 10855: New fields on adding/updating a subscription
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging serials/subscription-detail.pl
Auto-merging serials/subscription-add.pl
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription

So I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22604|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22698
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22698action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the Additional fields
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22616|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22703
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22703action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22608|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22702
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22702action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22606|0   |1
is obsolete||

--- Comment #49 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22700
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22700action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22605|0   |1
is obsolete||

--- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22699
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22699action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #22607|0   |1
is obsolete||

--- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22701
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22701action=edit
Bug 10855: FIX: Add additional fields for closed subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22704
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22704action=edit
Update Schema Files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #21922|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22705
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22705action=edit
Bug 6427 - Rewrite of the accounts system - WIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #16256|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22706
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22706action=edit
Bug 9823: Refactor return from GetReservesFromBiblionumber

The return from GetReservesFromBiblionumber contains an unnecessary
extra variable. In scalar context an array returns its element count.
Maintaing a separate count can lead to unforeseen bugs
and imposes ugly constructions on the subroutine's users.

Remove the useless count variable from the return

This patch also changes the parameters: now the routine takes a hashref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on|8918|9788

--- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com ---
I remove the dependencies on bug 8918.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||9823

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22660|0   |1
is obsolete||

--- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22707
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22707action=edit
Bug 10895 - Tests for C4::Items GetHiddenItems

Bug 10589 introduces PatronSingleBranch and PatronEveryBranch
system preferences. This ensures that the visibility of two
dummy records matches expectations. OpacHiddenItems is set
to hide 2 records. The system preferences are then toggled
between four cases ('SPT','SS','','SS|SPT') cross multipled
for the two system preferences to verify the correct visibility.

This will fail for a system with bug 10589 not applied, since
this tests the functionality of that patch. This will fail for a
system with bug 10900 not applied, since the calling convention
for set_userenv was fixed in C4::Context in this patch.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks|9823|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Works as advertised. Impressive number of test cases. Needs the dependent
reports.
Note that these dependencies will make it harder to get everything in. I did
not test the other one (10589) which might be more tricky.. Personally, I would
not mind passing QA on this report, but more formally another QAer should do
that ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. de Rooy from comment #17)
 Note that these dependencies will make it harder to get everything in. I did
 not test the other one (10589) which might be more tricky.. Personally, I
 would not mind passing QA on this report, but more formally another QAer
 should do that ;)

10589 should be 10900 here..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22705|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22708
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22708action=edit
Bug 6427 - Rewrite of the accounts system - WIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22708|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22710
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22710action=edit
Bug 6427 - Rewrite of the accounts system - WIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #22704|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 22709
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22709action=edit
Update Schema Files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Also available at
http://git.bywatersolutions.com/koha.git/shortlog/refs/heads/accounts_rewrite

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co
   |y.org   |m

--- Comment #38 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:

The syspref makes sense for me. It works as described.
The pref should not be filled (syspref.sql and updatedb): it will be displayed
in English for everybody. Since a default message is defined in the template,
the pref value should be empty.
I will provide a followup for that and for 4 tab characters.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #21816|0   |1
is obsolete||
  Attachment #21855|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22711
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22711action=edit
Bug 10951 - Adding NoLoginInstructions to system preferences

On a failed login, the default message is harcorded into opac-auth.tt.

 It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
 The changes modify
 -opac-auth.tt to allow for custom value
 -admin/preferences/opac.pref to add it to the preferences with a
description
 -C4/Auth.pm for the loading of the preference
 -sysprefs.sql
 -updatedatabase.pl

 TESTING
 1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the Don't have a p
 2) Apply the patch
 3) Regression Test: Redo step 1.  Same (default) message should
appear.
 4) Log in to intranet,
 - select NoLoginInstructions in system preferences.
 - Enter new (xml) message.  Possible:
 h5Welcome to Koha, please bring your passport to the front
office/h5
- and save
 5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22712
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22712action=edit
Bug 10951 - Tweaked opac-auth.tt sentence.

The change was causing issue with the next sentence. Adjusted
the start (uppercase) and ending (dot) on self-registration
invitation.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 22713
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22713action=edit
Bug 10951: The new pref NoLoginInstructions should be empty by default.

We don't want to display an English message by default for everybody.
The default message is in the template, so the pref should be empty.

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Note for RM: maybe patron is better than person in the pref description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #21760|0   |1
is obsolete||

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22715
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22715action=edit
Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA
Followup

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #21759|0   |1
is obsolete||

--- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 22714
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22714action=edit
Bug 9468 - Add ability to hide items from purchase suggestions forms

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Add some itemtypes to the new system pref SuggestionsHideItemTypes
4) Make a purchase suggestion
5) Verify those item types set in SuggestionsHideItemTypes do not appear
   in the pulldown menu for Item type

Signed-off-by: Frederic Durand frederic.dur...@unilim.fr

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||m.de.r...@rijksmuseum.nl

--- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comments:
Referring to Jonathan's comments and Kyle's replies: This works as advertised
within its current limited implementation. Could be extended in the future. The
function affects opac only now.
Code looks good to me. No complaints from qa tools.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com ---
Nicole, 
The following files still contain the string 3.12, do you plan to change
them?

help/circ/branchoverdues.tt
help/circ/branchtransfers.tt
help/circ/circulation-home.tt
help/circ/circulation.tt
help/circ/overdue.tt
help/circ/pendingreserves.tt
help/circ/reserveratios.tt
help/circ/returns.tt
help/circ/selectbranchprinter.tt
help/circ/transferstoreceive.tt
help/circ/view_holdsqueue.tt
help/circ/waitingreserves.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||z.taj...@cineca.it

--- Comment #2 from Zeno Tajoli z.taj...@cineca.it ---
Hi,

It is possible to fix the situation with this change on line 63 of
admin/aqbudgets.pl:

From:
my $show = $input-param('show') // 0; # SET TO 1, BY A FORM SUMBIT

to:
$show = $input-param('show') // 1; # SET TO 1 by default, group view. 

But the result is ok only if all budget are from one library/librarian.
Not if your budget are of different libraries/librarians

In fact we need to rethink the interface that now is a mix of cgi, js filter
and css effects show/don't show.

The problem is present in 3.8, 3.12 and master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

Version|3.8 |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11198] KOHA INSTALLATION

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11198

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Bug reports are not a good way to get support for Koha. You could try the Koha
manual (http://koha-community.org/documentation/), Koha mailing lists
(http://koha-community.org/support/koha-mailing-lists/), Koha IRC
(http://koha-community.org/get-involved/irc/), or a support company
(http://koha-community.org/support/paid-support/).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 CC||mathieu.saby@univ-rennes2.f
   ||r

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #22 from mathieu saby mathieu.s...@univ-rennes2.fr ---
It seems very interesting. Will it be in 3.14 ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11199] New: 008 value builder skips invalid characters and collapses remaining data

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11199

Bug ID: 11199
   Summary: 008 value builder skips invalid characters and
collapses remaining data
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: e...@efdss.org
QA Contact: testo...@bugs.koha-community.org
CC: d...@randomnotes.org, m.de.r...@rijksmuseum.nl

This is a problem with imported records where the # character is present
instead of a blank (though it also seems to happen if there is any character
present that is not in the available lists). 
It only happens if you open the 008 value builder to edit the field after the
record has been imported.

Here's an example of a problematic 008:
130515s2006stka###gr#000#0#eng#d

If I edit the record and open the 008 value builder, Koha
automatically changes it to:
130515s2006
It ignores all the # characters, and shifts everything over, thus changing
characters that were valid in their original position into invalid characters
(or incorrect characters, though valid) in their new positions.  If a character
in a new position is invalid, Koha ignores it as well and collapses the data. .
. 
Because the invalid characters are still there (though they are ignored)if you
try to edit the above 008 in the value builder, changes don't always end up
where you think you put them. The only way to be certain all positions are
entered correctly is to return to the MARC editing page, clear the contents of
the 008 and start over.

This is what it looks like after manually clearing the field and entering
the information:
131030s2006stka   gr 000 0 eng d
The # have all been turned into blanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2193] Lost Item Fines - Editable if $0

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2193

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10167] payment not showing what's paid for if not an item

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10167

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952

marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices.

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Blou, you may wish to rebase this, because I can't apply this to master or
3.10.12. Your patches are also not git-bz friendly. Patch 2 bombs badly when
attempting to manually apply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11182] Warnings in circulation

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11183] Warnings in opac

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11184] Fix wrong attribute type cloning

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2013-11-04 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

--- Comment #58 from Bob Birchall b...@calyx.net.au ---
Where is this up to?  Its marked 'Does not apply'.  If it can be re-based, I'm
up for testing it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/