[Koha-bugs] [Bug 11213] New: GetItemsInfo() called twice

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Bug ID: 11213
   Summary: GetItemsInfo() called twice
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: srd...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

Details pages opac/opac-detail.pl and catalogue/detail.pl call GetItemsInfo()
on their own after it being called from XSLTParse4Display() (if
OPACXSLTDetailsDisplay syspref and/or XSLTDetailsDisplay are set). That imposes
severe performance penalty for biblio records with large number of items.

The right way would be to pass the list to XSLTParse4Display(), however that
interface is very complex as is. An alternative is to return the list from
XSLTParse4Display(), which is not elegant at all.

If no one cries foul in the next 24 hours, I'll proceed with changing the
interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11212] New: Using non english characters in patron category description causes double encoding

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11212

Bug ID: 11212
   Summary: Using non english characters in patron category
description causes double encoding
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: beyri...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Using non english characters in patron category description causes double
encoding as a result letters like Ç looks like  Ç etc.

Steps to reproduce:

1. Create a new patron category. (cgi-bin/koha/admin/categorie.pl?op=add_form)
2. Use XYZ (or whatever) as category code.
3. Use non english characters in category description. (e.g ÇİÖŞÜĞ) 
4. From system preferences, add Ç Ş İ Ö Ü Ğ to the alphabet. (A B C Ç D E F G H
I İ J K L M N O Ö P Q R S Ş T U Ü V W X Y Z)
5. Visit patrons page. (cgi-bin/koha/members/members-home.pl)

I could reproduce that on 3.12.06 (debian wheezy, packages from repository) and
3.12.05


I'm not sure if this is related to bug #6554

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11211] New: Move calculation code out of C4::Calendar

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

Bug ID: 11211
   Summary: Move calculation code out of C4::Calendar
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: jwea...@bywatersolutions.com
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 8133

Koha::Calendar should contain all of the calendar calculation code, and
C4::Calendar should only have admin subs.

Created to slim down bug 8133.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Jesse Weaver  changed:

   What|Removed |Added

 Depends on||11211

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Julien Sicot  changed:

   What|Removed |Added

 CC||julien.si...@gmail.com

--- Comment #16 from Julien Sicot  ---
For information, ICU provide already a package for processing similar
transliteration. With just one line in etc/words-icu.xml (and
etc/phrases-icu.xml) :

  

you can convert latin unicode to ascii. Normally, this works for all polish
diacriticals.

You can test icu rules here : http://demo.icu-project.org/icu-bin/translit or
using yaz-icu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11210] New: Allow partial writeoff

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Bug ID: 11210
   Summary: Allow partial writeoff
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

it would be nice to make partial writeoff like a partial fine payment.

Example:
a fine of 3$ is charged because item was late of 3 days. But finaly on the
three days,  library was closed one day. I want to just writeoff 1$.

Thanks,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7205] can't reverse manual credits

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7205

marjorie barry-vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #1 from Kyle M Hall  ---
Created attachment 22757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22757&action=edit
Bug 9303 - relative's checkouts in the opac

This patch gives patrons the option of allowing other
linked relatives to view his or her checkouts from
opac-user.pl in a manner similiar to the patron's own
checkouts tab. By default the setting is not enabled.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create three borrowers, link them as relatives
4) In the OPAC, go to "my privacy" and choose to allow
   relatives to view current checkouts for borrowers A and B
5) Check out some items to each borrower
6) Log into the OPAC as borrower A, you should see a "Relatives'
   checkouts" tab. In this tab you should see the checkouts for
   borrower B
7) Log into the OPAC as borrower C, you should be able to view
   the current checkouts for both borrower A and borrower B

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Patch complexity|--- |Medium patch
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681

--- Comment #11 from Frédérick Capovilla  ---
Having never worked with unimarc or normarc records and Z39.50 servers, we are
not equipped to easily adapt our patch for it to work with these formats.

Could anyone improve this patch so it becomes flexible enough for inclusion on
master?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10718] items with no checkouts report does not work

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5349] Moving an order

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
Galen, this doesn't apply cleanly on 3.12.x.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205

--- Comment #6 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #3)
> If I click on one of the titles in the table where expiration date is blank,
> the following error occurs:
> 
> Date::Calc::PP::Delta_Days(): Usage:
> Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at
> /usr/share/koha/testclone/C4/Serials.pm line 2380
> 
> Could you confirm? If so, we should open a new report for that one..

I think it is not introduced by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205

--- Comment #5 from Jonathan Druart  ---
Marcel, the only page with 2 tables is serials/serials-search.pl?searched=1
There are 2 tabs: opened and closed subscriptions.
On each tabs there is a table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from M. de Rooy  ---
I have a hard time to reproduce the error :)
Somehow the filter on Open and Closed seems to work (also after refreshing)
with and without this patch.
Could you please clarify what you exactly mean with "more than 1 table on the
page"? Or provide some more detailed steps to reproduce the problem
encountered?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #20057|0   |1
is obsolete||
  Attachment #20733|0   |1
is obsolete||

--- Comment #20 from Jonathan Druart  ---
Created attachment 22755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22755&action=edit
Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now()
AS date).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

--- Comment #21 from Jonathan Druart  ---
Created attachment 22756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22756&action=edit
Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by
CAST(now() AS date).

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from M. de Rooy  ---
If I click on one of the titles in the table where expiration date is blank,
the following error occurs:

Date::Calc::PP::Delta_Days(): Usage:
Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at
/usr/share/koha/testclone/C4/Serials.pm line 2380

Could you confirm? If so, we should open a new report for that one..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Galen Charlton  ---
Pushed to master and 3.14.x.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204

M. de Rooy  changed:

   What|Removed |Added

  Attachment #22743|0   |1
is obsolete||

--- Comment #3 from M. de Rooy  ---
Created attachment 22754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22754&action=edit
Bug 11204: pendingreserves should use datatables.inc

A JS error occurs on the pending reserves pages:

ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined
if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){

Test plan:
Apply the patch and verify the error does not appear anymore.

Signed-off-by: Brendan Gallagher 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #13141|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 22753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22753&action=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "&$value"
in the function body.

Also use URI::Escape instead of custom regexps.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are not in OPACHideOpenURLForItemTypes)
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default"
9/ Repeat steps 5 to 7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #8 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #14 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11208
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||11209

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #1 from Jonathan Druart  ---
Created attachment 22752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22752&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] New: Multi transport types: same messages are sent for a patron

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Bug ID: 11209
   Summary: Multi transport types: same messages are sent for a
patron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||11208

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||9016

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

--- Comment #1 from Jonathan Druart  ---
Created attachment 22751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22751&action=edit
Bug 11208: If no smsalertnumber is defined, the message is marked as failed

For DUE message (and PREDUE, etc.) there are no check before sending the
message to the message_queue table.

This check avoids to try to send again and again the same message. Now
it is marked as "failed".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11208] New: Multi transport types: a sms message without sms number should be marked as failed

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208

Bug ID: 11208
   Summary: Multi transport types: a sms message without sms
number should be marked as failed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #15 from Fridolyn SOMERS  ---
(In reply to mathieu saby from comment #14)
> So, why not improving the default etc/words-icu.xml for everybody?
See comment 8.
It may be rediscussed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

mathieu saby  changed:

   What|Removed |Added

  Attachment #22737|0   |1
is obsolete||

--- Comment #15 from mathieu saby  ---
Created attachment 22750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22750&action=edit
Improve UNIMARC biblio indexing

New patch, 1 ligne changed (I had forgotten to replace a Title-host in
record.abs).

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255

Rafal  changed:

   What|Removed |Added

 CC||r...@poczta.onet.pl

--- Comment #10 from Rafal  ---
(In reply to Heather Braum from comment #9)
> There was discussion on this bug more than a year ago--is it going to move
> anywhere? What will it take for that to happen? I see Chris' comment that
> there's a deeper issue going on. Just curious -- this issue is affecting our
> libraries, too.

In our library we are using solution that I've provided in patch for Bug 10770.
So before printing in hold-transfer-slip.pl we call ModReserveAffect. 
Maybe it's not to good to call 2 times (in returns and hold-print-slip) this
function for 1 reserve?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #59 from Paola Rossi  ---
(In reply to Jonathan Druart from comment #58)
> Paola, I find a bug on datatables filters (bug 11205). It is not introduced
> by these patches but maybe it will fix your issue.

Thanks, Jonathan. Applying of 11205 is OK.
In subscriptions' advanced search, yes, bug 11205 fixes the problem.
Now the filters at the bottom of columns such as "ISSN", "Title", "Library",
"Expiration date", work well.
Staying that no value is displayed in the new columns of the table [so nor the
description neither the code can be seen], nothing is found when I use the
filters at the bottom of these columns.

In Claims, no, bug 11205 doesn't fix the problem. The use of filters at the
bottom of columns such as "Vendor", "Library", "Title", "Issue number",
"Status", "af1", always results in a "No matching records found" answer.
When I use the filter "From" and "To", the selection is nearby OK (range [x,y]
selects "Since"' days between [x+1,y-1]).
At the bottom of the table, whereas the "Select CSV profile" is only one
("issues to claim"), selecting "Download selected claims" always results in the
error:
"Please select at least one item to export".
But no checkbox is displayed in the whole page in my test case.

about comment 57:
The master 042 has not filters in CLAIMS' table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11207] Impossibility to remove a sms number

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207

--- Comment #2 from Jonathan Druart  ---
Note: I don't understand the other test
  $input->param('SMSnumber') ne $newdata{'mobile'}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8064] Merge several biblio records

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8064] Merge several biblio records

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #28 from Julian Maurice  ---
Created attachment 22749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22749&action=edit
Bug 8064: Change the way target record is built.

Instead of copying/removing a piece of DOM in target record each time a
checkbox is checked/unchecked, the target record is *entirely* rebuilt
each time a checkbox is checked/unchecked.
This is slower but allow for a more consistent and less error-prone
behaviour.

This patch also fix the mandatory check for subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11207] Impossibility to remove a sms number

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207

--- Comment #1 from Jonathan Druart  ---
Created attachment 22748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22748&action=edit
Bug 11207: No way to remove a sms alert number

Test plan:
1/ edit a patron
2/ set a sms alert number
3/ save
4/ edit the patron
5/ set the sms alert number to a blank value
6/ save
7/ the sms number is now an empty string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11207] Impossibility to remove a sms number

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11207] New: Impossibility to remove a sms number

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207

Bug ID: 11207
   Summary: Impossibility to remove a sms number
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

To reproduce:
1/ edit a patron
2/ set a sms alert number
3/ save
4/ edit the patron
5/ try to remove the sms alert number

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11207] Impossibility to remove a sms number

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

--- Comment #3 from mathieu saby  ---
(In reply to Jonathan Druart from comment #2)
> Mathieu,
> Not sure it is a good idea to factorize like that.
> Now, some routines did 1, 2 or 3 join, with your patch, they will always do
> 8 join.
> That will increase the load in acquisition pages.

In fact, what first disturbed me was that the same fields were not named in the
same way in GetOrder and GetCancelledOrders and GetOrders (publishercode,
rrp...). And working on that, I tried to factorize all the code.
But you are right, in terms of performance it is not a good solution.

Maybe the 2 subs which could be safely factorized are GetCancelledOrders and
GetOrders, as they differ only by the exclusion of an order status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart  ---
Mathieu,
Not sure it is a good idea to factorize like that.
Now, some routines did 1, 2 or 3 join, with your patch, they will always do 8
join.
That will increase the load in acquisition pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #14 from mathieu saby  ---
Fridolyn, we can have Polish records in a french or american catalog.
So, why not improving the default etc/words-icu.xml for everybody?

(same remarks for german umlauts, french ligatures etc)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #13 from mathieu saby  ---
(In reply to Jacek Ablewicz from comment #12)
> I think you only need those two lines in etc/words-icu.xml:
> 
> 

We are currently trying to improve this file in our library, and we use this
solution (with other tricks)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #30 from mathieu saby  ---
I think factorizing code would make things much easier.
Katrin and Jonathan, could you take a look at Bug 11206 please?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

mathieu saby  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

--- Comment #1 from mathieu saby  ---
Created attachment 22747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22747&action=edit
[PATCH] Bug 11206 - Factorize code for getting orders in C4::Acquisitions

This patch adds a new sub C4::Acquisition::_get_orders_with_params
This sub is now called by
- GetOrder
- GetOrders
- GetCancelledOrders
- GetOrdersByBiblionumber
- GetOrderFromItemnumber
- SearchOrder

It also makes changes to  acqui/lateorders-export.pl,
.../prog/en/modules/acqui/csv/lateorders.tt and
.../prog/en/modules/acqui/lateorders.tt to take into account some variable
renaming

Next step : use it in GetLateOrders

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] New: Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

Bug ID: 11206
   Summary: Factorize code for getting orders in C4::Acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mathieu.s...@univ-rennes2.fr
QA Contact: testo...@bugs.koha-community.org

A lot of subs are used in C4::Acquisitions for doing basically the same thing :
searching orders.
Code can be factorized, to improve maintainability, build stronger unit tests,
and make further improvements easier (like using DBIx::Class, or Bug 10758 (   
 Show bibliographic information of deleted records in acquisitions).

First draft patch attached here.
Fully testable, but can maybe be improved, and UT are not written yet.

To test : make a full acquisition workflow, search orders, display uncertain
prices, export baskets, basketgroups and late orders in CSV or PDF when
possible.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

mathieu saby  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f
   |ity.org |r

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #12 from Jacek Ablewicz  ---
I think you only need those two lines in etc/words-icu.xml:




as all other Polish diacritics should behave correctly out of the box.

Polish "l striked" is indeed somehow special (while it shouldn't - general
consensus is that "ł" is NOT a very different letter than "l" etc.). Problem
is: long time ago, some person from Unicode Consortium involved in UCA (Unicode
Collation Algorithm) development made rather questionable decision to not treat
"ł, Ł" as wariants of "l, L". It became a major PITA from than on - for
example, it does also affect mysql utf8_general_ci & utf8_unicode_ci
collations, to name just a few side effects.

BTW, I believe this got finally corrected in subsequent UCA revisions (in
v5.2.0+, AFAIRC), so this workaround may be no longer necessary in Koha
installations with more recent libicu versions (?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10857] Add facets cancellation

2013-11-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #34 from Jonathan Druart  ---
Created attachment 22746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22746&action=edit
Bug 10857: Encode 'limit' parameter values

to allow facets with '&' character.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/