[Koha-bugs] [Bug 11230] New: Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Bug ID: 11230 Summary: Refactor C4::Stats::UpdateStats and add UT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.s...@univ-rennes2.fr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com I am not sure of the right Component for this bug. I want to improve Statistics recording (adding some new fields, adding custom fields, etc). The first preliminary step is in this patch, which improves current code. An other patch will provide new features. This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Also : - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 22850 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22850action=edit [PATCH] Bug 11230 - Refactor C4::Stats::UpdateStats and add UT This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Additionnaly it also - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) To test : 1. run prove t/db_dependant/Stats.t -v 2. make some circulation operations (checkout, checkin, renew, localuse) check the operations are rightly recorded in Statistics table (with a SQL query like SELECT * FROM statistics WHERE datetime LIKE 2013-11-15%, if you run your test on the 15th november) 3. make some fine payments operations (writeoff, payment) check the operations are rightly recorded in Statistics table (with a SQL query like SELECT * FROM statistics WHERE datetime LIKE 2013-11-15%, if you run your test on the 15th november) Note that there is probably an issue to fix in Accounts.pm : the user is saved instead of the branch. But this is not the purpose of this patch, so I kept the previous behavior for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11231] New: notes should be reservenotes in pendingreserves.pl and reserveratios.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Bug ID: 11231 Summary: notes should be reservenotes in pendingreserves.pl and reserveratios.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.s...@univ-rennes2.fr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com In pendingreserves.pl and reserveratios.pl there is SQL query returning notes. The only notes field in the query are from biblio and biblioitems table. I suppose the expected result is the note about the reserve. It is in reserves.reservenote M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #20 from Doug Kingston d...@randomnotes.org --- As noted in chat, these patches are built on those for bug 6435 on which this bug depends. Can you test these 2 together? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #44 from Doug Kingston d...@randomnotes.org --- I addressed the recent QA issue on 10/28 with the updated patch. Can this be re-reviewed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #22457|0 |1 is obsolete|| --- Comment #45 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 22851 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22851action=edit Bug 6435 Add daemon mode to rebuild_zebra.pl This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|ASSIGNED|Needs Signoff CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #22798|0 |1 is obsolete|| --- Comment #3 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 22852 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22852action=edit Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip Test plan: 1. Set the System Preference for CircAutoPrintQuickSlip to clear the screen. Enter a borrower barcode for checkout Press Enter The screen should be cleared. 2. Set the System Preference for CircCircAutoPrintQuickSlip to open a quick slip window Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 3. Apply the patch Update the database using UpdateDatabase.pl 4. Set the System Preference for CircAutoPrintQuickSlip to clear the screen. Enter a borrower barcode for checkout Press Enter The screen should be cleared. 5. Set the System Preference for CircCircAutoPrintQuickSlip to open a quick slip window Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 6. Set the System Preference for CircCircAutoPrintQuickSlip to open a slip window Enter a borrower barcode for checkout Press Enter A Slip is printed. 7. Reload the database using sysprefs.sql Set the System Preference for CircAutoPrintQuickSlip to clear the screen. Enter a borrower barcode for checkout Press Enter The screen should be cleared. 8. Set the System Preference for CircCircAutoPrintQuickSlip to open a quick slip window Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 9. Set the System Preference for CircCircAutoPrintQuickSlip to open a slip window Enter a borrower barcode for checkout Press Enter A Slip is printed. 10. Verify that the Checkout Help includes information about printing Slips. Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5296] Advanced item due notices spam patrons with a large number of items checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5296 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Peggy, you can list item information in the digests too - I think by using items.content. I know we do it, but can't check the templates right now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz --- I believe that's exactly where it shows most benefits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #22 from Srdjan Jankovic srd...@catalyst.net.nz --- No worries mate :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #23 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to Srdjan Jankovic from comment #22) No worries mate :) +1, I thought my signed-by-Petter patch was enough :-D, I welcome anything that makes this warnings away. I'm already focused in other stuff right now :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||l...@catalyst.net.nz --- Comment #10 from Liz Rea l...@catalyst.net.nz --- I am actually seeing this bug - will get test data that can replicate to test the patch. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11232] New: Retrieve facets from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Bug ID: 11232 Summary: Retrieve facets from Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org At Kohacon, a few of us (Jared, Paul P, Tomas, myself, and possibly others) looked at using Zebra's native facetting. After a bit of trial and error, in the final 15 minutes of the hackfest, we were able to get it working using queries in YAZ(high fives all around), but I'm not sure if anyone has followed up on that work (as I've been on holiday). I don't see any existing bug reports for adding this functionality to Koha, but I think it would be preferable to how we build facets at the moment (hence this bug). This method should be: 1) faster (since it is pulling the facets from the search results using indexes rather than iterating through every record); 2) more comprehensive (it is based on the full result set and not just the first 50 or so results [depending on your sysprefs]); 3) able to build facets for control fields and the leader (since it pulls data using indexes, we should be able to easily build facets for publication year, record type, etc.). In terms of customizability (bug 10891), it might be more difficult to change on the fly. This is because we need to explicitly define each facet index in our configuration files for Zebra. I'll need to look over my notes and do a few more experiments, but I'm quite certain this is the case. While we could add a mechanism for allowing users to specify which facets to retrieve and display (probably a good idea), we couldn't do the same for the static XML config file. So we would need to either include all the indexes in the XML config file or mark it as a place for local changes. I'm not sure about the cost/benefit of telling Zebra that every index could be used as a facet. I don't imagine it would be too much of a cost though, since the list of facets would be fed to Zebra on start up and not runtime. -- As I said, I'm not sure if anyone is working on the native facetting at the moment. I would like to but I'll have to look at my workload and chat to my boss. I'll be happy to post my notes in a comment tomorrow on how to get it to work. The config is slightly different for DOM and GRS1 but it works well for both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #1 from Liz Rea l...@catalyst.net.nz --- Should we add a branch at install, that is the equivalent of any in the code, that cannot be deleted? Basically a shadow branch, just for this purpose? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22810|0 |1 is obsolete|| --- Comment #7 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22853 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22853action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
Attachment #22844|0 |1
is obsolete||
--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 22854
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22854action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm
This patch corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query-param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session-param('id') // '';
Indentation does not reflect actual scoping.
And the 'None' is changed to '', since that behaves properly
in the undef case:
my $pki_field = C4::Context-preference('AllowPKIAuth') // '';
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #22853|0 |1 is obsolete|| --- Comment #8 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 22855 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22855action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- This is how I tested it: mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log I then did a simple search 'unhappy' and then clicked an entry know to not have the collection code set. mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=q=unhappybranch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206query_desc=kw%2Cwrdl%3A%20happy%20life opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206query_desc=kw%2Cwrdl%3A%20happy%20life mtompset@ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22855 - bug_11183: get rid of some warninngs Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warninngs mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log I then did a simple search 'unhappy' and then clicked an entry know to not have the collection code set. mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=13896query_desc=kw%2Cwrdl%3A%20unhappy mtompset@ubuntu:~/kohaclone$ Sorry, gmcharlt. I found a bug in MARC::Field. ;) But not this. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22855|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22856 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22856action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22839|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #11 from M. Tompsett mtomp...@hotmail.com --- Okay, the 314 warning bugged me enough, and I hunted it down to line 1838 of the master's C4/Search.pm, which I will add a second patch to this, as the test case triggered the bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz --- I did something with Search.pm too on a different bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22857action=edit Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- The test plan is as given on the original patch: To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) I happen to have two items with unhappy in the title, and so I gave one a collection code, while the other did not have one. 1) Search for unhappy in OPAC 2) Click link 1 3) Browser back 4) Click line 2 These steps are between the clearing of the error log and the viewing unique errors in the error log. The results of my testing: mtompset@ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=q=unhappybranch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/ opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/ mtompset@ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22856 - [SIGNED OFF] bug_11183: get rid of some warnings 22857 - Bug 11183 - Warnings in opac Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warnings Applying: Bug 11183 - Warnings in opac mtompset@ubuntu:~/kohaclone$ echo ~/koha-dev/var/log/koha-opac-error_log mtompset@ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u mtompset@ubuntu:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11182] Warnings in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |srd...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11184] Fix wrong attribute type cloning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |srd...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Assignee|gmcha...@gmail.com |srd...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 22858 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22858action=edit [SIGNED OFF] bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #22678|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11233] New: testing development
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233 Bug ID: 11233 Summary: testing development Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: vishal.pa...@osslabs.biz QA Contact: testo...@bugs.koha-community.org creating patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11233] testing development
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233 vishal vishal.pa...@osslabs.biz changed: What|Removed |Added Hardware|All |PC OS|All |Linux -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- I dropped my koha database, and did a fresh install from master. Indeed it was missing. I changed the version number back to 3.600 in the systempreferences table and forced an upgrade. Lo and behold it appeared. I dropped my koha database again, applied the patch, and did a fresh install again. This time the system preference was there as expected. I even discovered Frameworksloaded, marcflavor, and Version are all created by the installer, when I deleted everything in the system preferences table and sourced the sql file directly. It was disorienting to see that the variable count had dropped. No worries, though. This all was a test system. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
