[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #84 from Galen Charlton --- After clearing it with the translation manager, I've pushed this to master and 3.14.x. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What|Removed |Added Attachment #22420|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #31 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com Severity|enhancement |minor --- Comment #6 from Galen Charlton --- I consider this a bugfix, not an enhancement, so I've pushed this to master and 3.14.x. Thanks, Dobrica! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 --- Comment #5 from Srdjan Jankovic --- Omg, what a blunder... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Srdjan Jankovic changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Srdjan Jankovic changed: What|Removed |Added Attachment #22924|0 |1 is obsolete|| --- Comment #4 from Srdjan Jankovic --- Created attachment 22953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22953&action=edit bug_11247: Removed unused params from TransformHtmlToXml() $indicator and $ind_tag should not be TransformHtmlToXml() params. TransformHtmlToXml() is only used for items: - $indicator is always empty - $ind_tag was not even used in the function To test: Check that integrity of following functions is preserved: * Acquisition - ordering and receiving, needs setting AcqCreateItem to placing and receiving an order * Cataloging - create/modify an item * Batcih modify in Tools * Serials receiving -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11240] Adding a restriction does not save the date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11240 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Chris! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Robin Sheat changed: What|Removed |Added Component|Architecture, internals,|Packaging |and plumbing| Assignee|gmcha...@gmail.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Robin Sheat changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Robin Sheat --- A small, harmless, and useful change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Robin Sheat changed: What|Removed |Added Version|3.6 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Robin Sheat changed: What|Removed |Added Attachment #20035|0 |1 is obsolete|| --- Comment #4 from Robin Sheat --- Created attachment 22952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22952&action=edit Bug 10670 - koha-common fails to start zebra without log permissions If koha-common is started when zebra log files are owned by root it will fail to start without any useful message (since zebra can't write errors in log files because it lacks permissions to do so). This patch creates empty log files and ensure they have correct permissions. I can't pin-point why log files gets owned root, but I suspect it has something to do with zebra crashing and logrotate, but this is just theory. We have seen this behaviour since koha 3.1 every few months, and every time it happends we have root owned logs and crashed zebra so this patch will at least help sites which have some kind of automatic koha-common start if it's not running. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start zebra due to log permission problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ro...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7030] maximum number of holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7030 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett changed: What|Removed |Added Assignee|gmcha...@gmail.com |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #9 from M. Tompsett --- Okay, I've reviewed and I think this test plan should be good. 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Go to Tools->News - Are the locations properly display? 6) Add a News item, for 'All' interfaces for 'All Branches'. 7) Add a News item, for 'OPAC' interface at your user branch. 8) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 9) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 10) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 11) Log in as a user with the branch you added the news item for. - Does that piece of News display now too? (Both things added should be displayed) 12) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222
--- Comment #9 from Zeno Tajoli ---
Last option:
do you use QueryParser ?
Because with QueryParser on the bug is not present.
See from master, labels/label-item-search.pl:
94 $dateto = C4::Dates->new($dateto);
95 if ($QParser) {
96 $ccl_query .= ' && ' if ( $ccl_textbox || $datefrom );
97 $ccl_query .= "acqdate(-" . $dateto->output("iso") . ')';
98 } else {
99 $ccl_query .= ' and ' if ( $ccl_textbox || $datefrom );
100 $ccl_query .= "acqdate,st-date-normalized,le=" .
$datefrom->output("iso");
101 }
In fact line 97 [QueryParser on] is OK.
Line 100 [QueryParser off] has the bug
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #8 from Owen Leonard --- I do not see the bug in master. I do not get errors when searching by date. However, I also get no results when searching by date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11179] opac-course-details.pl shows item as available when it is checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 --- Comment #3 from Owen Leonard --- Created attachment 22951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22951&action=edit Bug 11179 [Follow-up] opac-course-details.pl shows item as available when it is checked out This follow-up applies the same fix to the Bootstrap theme. This patch also includes the changes to item-status.inc in the Bootstrap theme which were made to the prog theme in Bug 10820: display item status as lost if item is both lost and on loan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11179] opac-course-details.pl shows item as available when it is checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179 Owen Leonard changed: What|Removed |Added Attachment #22659|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 22950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22950&action=edit [SIGNED-OFF] Bug 11179 - opac-course-details.pl shows item as available when it is checked out If an item is listed for a course and is checked out, the item will still show as being available from the course details page which lists all the items that are part of a course. This is due to the way the course reserves system handles items and issues separately, while item-status.inc assumes the due date has been embedded in items.datedue Test Plan: 1) Create a course 2) Add an item to that course 3) Check the item out to a patron 4) View the course details from the opac 5) Note the status says "Available" 6) Apply this patch 7) Repeat step 4 8) Note the status no longer says "Available" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #22948|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 22949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22949&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #5 from Barry Cannon --- There is also argument for a third option - "AllowOnShelfHoldsFromRemoteBranchOnly". That is, allow an item to be reserved when the item is not in the users homebranch. I think the real benefit is the extra choice the library might require. It is a tricky matrix though and this patch is really only the first step to allowing the preference to be a bit more granular. Just an On/Off toggle seems a little limited, I feel. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #8 from Liz Rea --- Cool, thanks. I'm actually quite interested in this patch - it's great functionality. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #22940|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 22948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22948&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] New: tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 Bug ID: 11253 Summary: tools/inventory.pl output_pref ignores 'iso' parameter passed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org I found this as a result of looking briefly at bug 11240. When the parameter was changed to a hash reference in bug 10380, I believe tools/inventory.pl was missed. It currently allowed for a non-hash to be passed, but assumes that is just the date. Any other parameters would be ignored. I am unsure of the correct course of action, whether the parameter needs to be passed, or whether the system preference is the preferred result. I'm looking further into this. I figure this is minor, since most people probably don't change the dateformat system preference to non-iso, and don't run tools/inventory.pl frequently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #7 from Zeno Tajoli --- I'm sorry for my bad english, but i don't understand the situation. Is not present the bug in your installation ? All work without problem ? And your test version is ? Thank you -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #50 from Doug Kingston --- I can try to pull that patch together this weekend. -Doug- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11240] Adding a restriction does not save the date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11240 Brendan Gallagher changed: What|Removed |Added Attachment #22895|0 |1 is obsolete|| --- Comment #5 from Brendan Gallagher --- Created attachment 22947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22947&action=edit [PASSED-QA] Bug 11240 : Date of restriction not saved on Patron Edit screen To test: 1/ Edit a patron 2/ Add a restriction with a date (in any format other than iso) 3/ Not the date is not saved 4/ Apply patch 5/ Add restriction again, note it is saved The problem is output_pref was being called with the wrong parameters Signed-off-by: Jonathan Druart Note: The issue in on the memberentry form only (not the restriction form on the check out page). Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11240] Adding a restriction does not save the date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11240 Brendan Gallagher changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11240] Adding a restriction does not save the date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11240 --- Comment #4 from Galen Charlton --- For the sake of having a keyword: manual restriction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton --- Since this is easy to test and quiets log noise, I've pushed this to master and 3.14.x. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #4 from Katrin Fischer --- Hi Owen, I think it would be a big change from current behaviour - or do you mean just make it a third option? Maybe just hard to do that in a grammatically nice way :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Owen Leonard changed: What|Removed |Added Attachment #22906|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 22946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22946&action=edit [SIGNED-OFF] Bug 11243: Supplier list should distinct canceled items On the supplier result list, the "Item count" columns contain the sum of all items ordered for a basket. But if an order is canceled, the item count is not really meaningful. This patch just adds, in parenthesis, the number of items canceled. Test plan: - create a basket and 3 orders with different number of items - cancel 1 order - verify on the supplier list that the number of items is correct and the number of canceled items is correct too. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11183] Warnings in opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #3 from Owen Leonard --- I'm confused about the necessity of having a second preference. Why would it not be the case that the 'AllowOnShelfHolds' applies to any available item? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11252] rebuild_zebra.pl should not have --munge-config
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 --- Comment #1 from Galen Charlton --- Created attachment 22944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22944&action=edit Bug 11252: remove deprecated -munge-config switch from rebuild_zebra.pl The -munge-config switch has been deprecated for years, and trying to use it would either not work at all or, if it did "work", almost certainly damage one's Zebra configuration for Koha. This patch removes this switch. To test: [1] Run rebuild_zebra.pl and verify that no mention is made of -munge-config. [2] Run rebuild_zebra.pl to index records in one's test database and verify that there are no regressions. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #5 from Maxime Pelletier --- Created attachment 22945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22945&action=edit Patch to fix and use OPACBaseURL on all send list and send basket pages Fix use of OPACBaseURL on send list(shelf) and send basket of OPAC and staff client. To test, try sending a list and a basket in both opac and staff pages. All links should contains http:// followed by OPACBaseURL. If OPACBaseURL isn't set in the preferences, no links should be in the email. I hardcoded "http://"; everywhere because no decision were taken in bug #7770, so the preference description still says that the http:// shouldn't be in OPACBaseURL. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11252] rebuild_zebra.pl should not have --munge-config
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Galen Charlton changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11252] New: rebuild_zebra.pl should not have --munge-config
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11252 Bug ID: 11252 Summary: rebuild_zebra.pl should not have --munge-config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org The --munge-config option of rebuild_zebra.pl attempts to create a valid Zebra configuration. While there was a period in the 3.0 days where this might have been useful, nowadays this option would either not work, or if it does work, be actively dangerous. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #6 from Owen Leonard --- My items do have accession date information, and search results can be correctly sorted by accession date, if that is any indication of the index working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Galen Charlton changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #49 from Galen Charlton --- (In reply to Martin Renvoize from comment #48) > Follow-up note 1: I also tested the -sleep option and it worked well. > Follow-up note 2: As an afterthought, should the -z be implied by daemon > mode? In response to this and the previous comment, my view is that --daemon should imply (and be) "here's how you keep your Zebra index up to date." IOW, I think --daemon should imply the following options: -z -a -b It should exclude (by refusing to start or by simply ignoring) the following options: -r -s -k -h -y -where -length -offset -I | -skip-index I wouldn't consider this a blocker for putting the patch in master, but lean towards considering a it blocker for putting in a stable branch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10684] Koha search dies on undecodable records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10684 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #9 from Galen Charlton --- Pushed to master and 3.14.x, along with a regression test. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #5 from Zeno Tajoli --- So in you install the two optinons not work ? Do you have date inside 'Acquisition date field' in the iterm section. ? In MARC21 is the field 952$d The search is based on Zebra index acqdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Maxime Pelletier changed: What|Removed |Added CC||pelletiermax...@gmail.com --- Comment #4 from Maxime Pelletier --- A note that since ug 8368 the link is also broken in the OPAC for send cart and send list. "http://"; was removed before the OPACBaseURL variable, so the link is now "localhost/cgi-bin/koha/opac-detail.pl?biblionumber=11" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #4 from Owen Leonard --- > c)Try to select items with option "Added on or before date" > d)You will receive an error I cannot reproduce this error. Nor can I get any results for any date-based search, whether it be the "before" option, the "after," or both. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8409] purchase order saying 'Books'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8409 --- Comment #1 from Owen Leonard --- I can't reproduce this problem, so I assume it's something in your data. If you could identify where in your order information that text can be found it would help diagnose the formatting issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Owen Leonard changed: What|Removed |Added Attachment #22886|0 |1 is obsolete|| --- Comment #15 from Owen Leonard --- Created attachment 22943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22943&action=edit [SIGNED-OFF] Bug 11059 - Restore time in staged dates in addorderiso2709.tt Follow-up patch to restore the display of time in acqui/addorderiso2709.tt in staged date. Simply uses an option of KohaDates TT plugin. This time may be usefull if there where several imports in the same day. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #9 from Jonathan Druart --- I completely agree with the first patch. The second one looks good too but I cannot reproduce the load difference. In fact, in C4::Biblio, the memoize_memcached routine die with "Invalid memcached argument" (though C4::Context::memcached returns a Cache::Memcached object). Anyway, I hope another QAer will reproduce and pass QA on these 2 patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11251] Easier to customize OPACs for Multi-Library set ups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 George Williams changed: What|Removed |Added CC||geor...@latahlibrary.org --- Comment #1 from George Williams --- I concur with Nicole. For large consortia, a method to customize the OPAC differently for different branches would be a great addition. George Williams georgew at latahlibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11185] check-url-quick.pl fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11185] check-url-quick.pl fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Owen Leonard changed: What|Removed |Added Attachment #22666|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 22942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22942&action=edit [SIGNED-OFF] Bug 11185 check-url-quick.pl fails Revert commit f88f11b4f805a70c9748bc3676cb1ce086db2ce8 Signed-off-by: Owen Leonard Before this patch, check-url-quick.pl fails with an error. After the patch it runs correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11185] check-url-quick.pl fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #3 from Frédéric Demians --- > Does this mean that the follow-up on 7963 was wrong, and no follow-up > was needed? The follow-up was wrong. If the optional dependency AnyEvent::HTTP isn't installed, a Perl error is displayed in any case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11185] check-url-quick.pl fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 --- Comment #2 from Owen Leonard --- The commit in question: Bug 7963 follow-up: die nicely if AnyEvent libraries not installed Does this mean that the follow-up on 7963 was wrong, and no follow-up was needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #5 from Owen Leonard --- (In reply to Fridolyn SOMERS from comment #4) > Is your authorised values catégory for collection codes : ccode or CCODE ? CCODE. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11163] Wrong itemtype usage count when deleting an itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11163] Wrong itemtype usage count when deleting an itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163 Owen Leonard changed: What|Removed |Added Attachment #22530|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 22941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22941&action=edit [SIGNED-OFF] Bug 11163: Wrong itemtype usage count when deleting an itemtype Wrong usage of UNION instead of UNION ALL prevented the count to match the expected value. Steps to reproduce: - Create an itemtype. - Create some biblios setting the created itemtype at biblio level. - Create some items setting the created itemtype on them. - Try to delete the itemtype in Home > Administration > Item types, the count is 1 and doesn't match the expected result. Regards To+ Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #22889|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 22940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22940&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245
Owen Leonard changed:
What|Removed |Added
Attachment #22938|0 |1
is obsolete||
--- Comment #4 from Owen Leonard ---
Created attachment 22939
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22939&action=edit
[SIGNED-OFF] Bug 11245 - typo in modborrowers.tt javascript string
In modborrowers.tt, Bug 8986 made the javascript strings translatable :
_("This attribute will be only applied to the patron\'s category")
In this case, the backslash is useless.
Test plan :
- Create a borrower attribute with a "Category" defined
- Go to Tools / Batch patrons modification
- Enter a cardnumber and submit
- Next to "Attribute", select the borrower attribute you created
=> You see a grey text at the right : This attribute will be only applied to
the patron's category "XXX"
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10952] Store anonymous search history in session
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952 Galen Charlton changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #6 from Galen Charlton --- This patch needs more work. Most obviously, it breaks the tests in t/db_dependent/Auth_ParseSearchHistoryCookie.t. Of course, ParseSearchHistoryCookie is removed by the patch, but the tests should be rewritten so that they exercise session-based search history. Also, there are a number of comments referring to the search history cookie that should be removed or revised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11251] Easier to customize OPACs for Multi-Library set ups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Joel Sasse changed: What|Removed |Added CC||jsa...@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #4 from Fridolyn SOMERS --- (In reply to Owen Leonard from comment #3) > I can't reproduce this problem in master. I get results when either item > type or collection code. Is your authorised values catégory for collection codes : ccode or CCODE ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Fridolyn SOMERS changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 --- Comment #24 from M. Tompsett --- (In reply to Jonathan Druart from comment #22) > I would have been nice to make the most of the opportunity to replace the > parameter list with a hashref. I think the fixing the parameters to hashrefs would be better done in bug 7176. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Fridolyn SOMERS changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Fridolyn SOMERS changed: What|Removed |Added Attachment #22909|0 |1 is obsolete|| --- Comment #3 from Fridolyn SOMERS --- Created attachment 22938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22938&action=edit Bug 11245 - typo in modborrowers.tt javascript string Test plan added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #22 from Jonathan Druart --- QA comment: All looks good, no regression found (I did not launch all UT). The persona login works. As Srdjan already said, I am not sure the set_userenv routine should be used as a method. But no importance when looking at the C4::Context module... I would have been nice to make the most of the opportunity to replace the parameter list with a hashref. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 Jonathan Druart changed: What|Removed |Added Attachment #22585|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 22937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22937&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #3 from Owen Leonard --- I can't reproduce this problem in master. I get results when either item type or collection code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton --- Pushed to master and 3.14.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11251] New: Easier to customize OPACs for Multi-Library set ups
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11251 Bug ID: 11251 Summary: Easier to customize OPACs for Multi-Library set ups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be great to have branch specific opac content. So opacmainuserblock, opacnav, opacnavright, opacnavbottom, opacheader, opaccredits could all be branch specific maybe using a different OPAC customization section in Administration instead of system preferences for these things. Of course one could argue that the entire OPAC preferences section could be broken out in to it's own Admin area - but I'll start small in my suggestion. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 --- Comment #12 from Galen Charlton --- (In reply to Jonathan Druart from comment #11) > Galen: I know there is no sense to sort by relevance asc but don't you know > it is worth to add an entry in the qp config file? I think so, as there's nothing preventing somebody from setting relevance ascending as the default sort order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Owen Leonard changed: What|Removed |Added Attachment #22598|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 22936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22936&action=edit [SIGNED-OFF] Bug 11171: Display basket group name on the supplier list page Test plan: search supplier and verify the basket group column is filled. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Dobrica! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11207] Impossibility to remove a sms number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Owen Leonard changed: What|Removed |Added Attachment #22748|0 |1 is obsolete|| --- Comment #3 from Owen Leonard --- Created attachment 22935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22935&action=edit [SIGNED-OFF] Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11207] Impossibility to remove a sms number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Please provide a test plan. How do you trigger that error message? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Koha Team Lyon 3 changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11250 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10247 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11250] New: "too many holds" message appears inappropriately
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250
Bug ID: 11250
Summary: "too many holds" message appears inappropriately
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Hold requests
Assignee: koha-bugs@lists.koha-community.org
Reporter: k...@univ-lyon3.fr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In the staff interface, when placing a hold from the holds tab of a detailed
record, the message "Cannot place hold
Too Many Holds: Johnny SuchOne has too many holds" appears even if the unique
reason is that there 's no holds allowed for the borrower.
seems because of this line (request.pl line 193) :
unless ( $canbookbereserved ) {
$maxreserves = 1;
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- The behavior introduced by this patch goes against the IndependentBranches pref value. I'm not sure it is relevant. Or maybe should we add the 2 values on the mainpage (total changes/lib changes) and introduce a filter by branch on the members update page. Don't hesitate to argue if you think I am wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11225] \n in translation strings should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What|Removed |Added Attachment #22880|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 22934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22934&action=edit Bug 11225: \n in translation strings should be removed Some strings in the serials module contain linebreaks \n that cause problems in translation. Test plan: - Update your po file - Verify that strings in serials/subscription-add.tt and serials/subscription-numberpatterns.tt are present and don't contain "\n" character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11225] \n in translation strings should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 --- Comment #11 from Jonathan Druart --- Galen: I know there is no sense to sort by relevance asc but don't you know it is worth to add an entry in the qp config file? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Jonathan Druart changed: What|Removed |Added Attachment #22438|0 |1 is obsolete|| Attachment #22439|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 22932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22932&action=edit Bug 11137: regression tests for QP search field alias bug This patch adds regression tests to verify that Boolean searches using QueryParser function correctly. This patch also ensures that QP is correctly initalized when Search.t is run. To test: [1] Apply this patch and the following patch. [2] Verify that prove -v t/QueryParser.t works [3] Verify that prove -v t/db_dependent/Search.t works [4] (optional) instead of applying both patches at the same time, apply only the regression test patch and run the tests listed in steps 2 and 3. The following tests should fail: t/db_dependent/Search.t (Wstat: 512 Tests: 198 Failed: 2) Failed tests: 42, 71 Non-zero exit status: 2 t/QueryParser.t (Wstat: 256 Tests: 28 Failed: 1) Failed test: 12 Non-zero exit status: 1 Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 --- Comment #10 from Jonathan Druart --- Created attachment 22933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22933&action=edit Bug 11137: fix certain types of searches run using QueryParser QueryParser was loading redundant search aliases, which in turn resulted in certain queries involving two or more clauses joined by a Boolean operator getting parsed in correctly. To test: [1] Enable QueryParser. [2] Arrange your database so that some some bib records contain the keyword 'history' while a smaller subset contain both 'history' and 'earth'. (The exact words used don't matter.) [3] Run the following search from the OPAC global search bar: kw:history && kw:earth [4] Observe that the records that are returned include *all* bibs in the database with the keyword 'history'. In other words, the restriction that the records must also contain 'earth' is not observed. [5] Apply the patch and rerun the search. [6] This time, the results that are returned should include only those that contain both 'history' and 'earth'. [7] Verify that prove -v t/QueryParser.t passes. Signed-off-by: Galen Charlton Signed-off-by: Katrin Fischer Passes test plans, all tests and QA script. Also checked the db_dependent/Search.t tests. Tried some other searches, all seems to be working correctly. Signed-off-by: Jonathan Druart I reproduce the bug and I confirm this patch fixes it. Without the patch, kw:history && kw:earth, I got: Search biblios OK 4 1 1+0 RPN @attrset Bib-1 @attr 4=6 @attr 1=1016 history With the path, I get: Search biblios OK 2 1 1+0 RPN @attrset Bib-1 @and @attr 4=6 @attr 1=1016 history @attr 4=6 @attr 1=1016 earth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active when no suggestion selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127 --- Comment #7 from Owen Leonard --- (In reply to Jonathan Druart from comment #6) > ping Owen Sorry, here I am! (In reply to Jonathan Druart from comment #5) > Why are there 2 ways to delete selected suggestions? Should not we keep only > the button on the bottom? I don't see any reason not to offer both options. We do the same on the lists page and the on the user account page with renewal options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 --- Comment #8 from Jonathan Druart --- So stupid... My Unimarc DB got a default sort field relevance dsc and there is no modifier relevance dsc in the qp.yml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean search after the first
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #7 from Jonathan Druart --- I cannot test this patch. My MARC21 DB is broken and with my UNIMARC DB, I got no result. I tried to debug: In QueryParser::Driver::PQF::target_syntax, debug is enable. - with marcflavour=MARC21 QP query for biblioserver: history #relevance_dsc PQF query: @attr 2=102 @or @or @attr 1=1016 @attr 5=1 @attr 4=6 "history" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 "history" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "history" - with marcflavour=UNIMARC QP query for biblioserver: history #relevance_asc PQF query: @and @or @or @attr 1=1016 @attr 4=6 "history" @attr 9=20 @attr 2=102 @attr 4=6 "history" @attr 9=34 @attr 2=102 @attr 4=6 "history" @or @or @attr 1=1016 @attr 4=6 "#relevance_asc" @attr 9=20 @attr 2=102 @attr 4=6 "#relevance_asc" @attr 9=34 @attr 2=102 @attr 4=6 "#relevance_asc" The call to $self->parse_tree->target_syntax does not remove the modifiers for UNIMARC. I don't know how continue to investigate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11225] \n in translation strings should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #5 from Owen Leonard ---
This patch includes several extra parentheses:
error_msg += _("- Frequency is not defined") + "\n"); <-- like that last one
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11009] Do not allow reading records of anonymous patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009 Owen Leonard changed: What|Removed |Added Attachment #21896|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 22931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22931&action=edit [SIGNED-OFF] Bug 11009 - Do not allow reading records of anonymous patron When using an anonymous patron to anonymise issues history, this patron may have a huge number of old issues. In this case, trying to display the reading history of this patron will perform a huge SQL query. It is not usefull to have the reading history of this anonymous patron. This patch adds an alert instead of old issues when displaying reading records of anonymous patron. Test plan : - Set syspref AnonymousPatron to 0. - Select a borrower with old issues. For example 123. - Look at its reading records page : members/readingrec.pl => Old issues are displayed in a datatable - Set syspref AnonymousPatron with this borrower number. For example 123. - Look at its reading records page => Old issues are not displayed and an alert is displayed - Using SQL query, remove old issues of this borrower : DELETE FROM old_issues WHERE borrowernumber=123. - Look at its reading records page => A message is displayed Signed-off-by: Owen Leonard This works as advertised and seems like a reasonable thing to do. I suspect that someone will object... Perhaps that person will implement a solution which uses an AJAX DataTable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11009] Do not allow reading records of anonymous patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Remove unused params from TransformHtmlToXml()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247
M. Tompsett changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||mtomp...@hotmail.com
--- Comment #3 from M. Tompsett ---
use Data::Dumper; die Dumper($itemhash{$item});
I don't think so. Sorry.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11200] Adding subfield without field in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11200 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- Please provide a more thorough description of the problem this fixes and a test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
