[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304
Katrin Fischer changed:
What|Removed |Added
Attachment #23159|0 |1
is obsolete||
--- Comment #3 from Katrin Fischer ---
Created attachment 23183
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23183&action=edit
[PASSED QA] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs
properly
Detail page tabs are not displayed properly because JavaScript is broken
in French. This is due to _(' JS string construction used in place of
_(".
This patch fixes:
- opac-detail.tt page
- xt/single_quotes to test bootstrap theme
Signed-off-by: Owen Leonard
Tested by applying the patch, running translate update, then translate
install. Saw no JavaScript error on the French detail page.
Signed-off-by: Katrin Fischer
Switches from single to double quotes for translatatable strings.
Unit tests for xt/single_quotes passes now.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] New: Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Bug ID: 11310 Summary: Update XSLT stylesheets in bootstrap theme Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org I noticed today that the "Continues:" label is missing a space after the label on the bootstrap theme. This has been fixed a while ago on the prog theme - I think easiest would be to copy the XSLT files, so both filesets are current. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Katrin Fischer changed: What|Removed |Added Attachment #23178|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 23182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23182&action=edit [PASSED QA] Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Small change, big difference. With the patch the content of the RSS feed renders like it does for the prog theme. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188
--- Comment #1 from Magnus Enger ---
Created attachment 23181
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23181&action=edit
Bug 11188 - Make gather_print_notices.pl die on failed open()
Problem:
If you tell gather_print_notices.pl to write output to a location
you do not have write access to, it will silently fail to write the
data, but still mark unsent messages as sent.
Solution:
This patch adds two lines of defense:
1. Check that the location given for the output is writable
2. use "open() or die" instead of just "open()" when writing the
output
The first measure should catch most of the potential errors, but
I guess a directory can be writable, but the open() still can fail
because the disk is full or something similar.
To test:
- Make sure you have some unsent messages in the message_queue table,
that do not have an email adress
- Apply the patch
- Run the script, pointing at a location you do not have access to
write to. Check that the script exits with an appropriate error
message, and that the unsent messages are still unsent. Do this
both with and without the -s option.
- To fake passing the first line of defence, comment out line 62
and put this in instead:
if ( !$output_directory || !-d $output_directory ) {
- Run the script again as above, check you get an appropriate
error and that the message queue is not touched
- Reset line 62 to how it was
- Run the script against a directory you do have access to write to
and check that output is produced as expected and that messages
are marked as sent
- Sign off
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett changed: What|Removed |Added Attachment #23179|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 23180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23180&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. Added special case for dd-mm- calls, so dt_from_string works correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 --- Comment #4 from M. Tompsett --- Created attachment 23179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23179&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- I switched my theme to bootstrap (opacthemes system preference), and followed test plan in comment #1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 M. Tompsett changed: What|Removed |Added Attachment #23174|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 --- Comment #2 from M. Tompsett --- Created attachment 23178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23178&action=edit [SIGNED OFF] Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11290] members-home.pl displays badly if using non english templates and have a utf8 char in categorycode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11290 --- Comment #12 from Chris Cormack --- (In reply to Tomás Cohen Arazi from comment #11) > (In reply to Jacek Ablewicz from comment #7) > > I think the underlying cause for this particular problem in members.pl and > > members-home.pl is that output()/utf8_arrayref()/utf8_hashref() subs in > > Templates.pm do not know what to do with objects / blessed hashrefs (they > > treat them as strings/scalars, actually calling utf8::is_utf8() on them > > etc.). > > Preparing for Reno i had tried even removing any call to those sub. I'd be > in favour of removing them and using template filters instead (I.e. less > loops traversing data structures and less probable double encoding > situations).. > I would prefer this situation also -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Nuño López Ansótegui changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |nu...@masmedios.com |ity.org | --- Comment #1 from Nuño López Ansótegui --- Created attachment 23177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23177&action=edit Bug 11309 - Duplicated patterns when subscription table is updated This patch solves the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11309] New: Duplicated patterns when subscription table is updated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Bug ID: 11309 Summary: Duplicated patterns when subscription table is updated Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: nu...@masmedios.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com When you update the subscription table, checking patterns has a bad behaviour because this process compares patterns (new versus just created) without considering NULL values. The result is a lot of patterns duplicated in 'subscription_numberpatterns' table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #9 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #8 from Martin Renvoize --- All works as expected, passes QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 --- Comment #7 from Martin Renvoize --- Created attachment 23176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23176&action=edit [PASSED QA] Bug 11307 : Follow up for bootstrap theme (master and 3.14.x only) To test: Same as first patch, but using bootstrap theme Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What|Removed |Added Attachment #23169|0 |1 is obsolete|| Attachment #23170|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 23175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23175&action=edit [PASSED QA] Bug 11307 : Potential XSS attack in rss feed To test: 1/ Craft a url like /cgi-bin/koha/opac-search.pl?q=a&count=50"'test&sort_by=acqdate_dsc&format=rss2 2/ look at the source, notice 50"'test 3/ apply the patch, and reload url 4/ source now contains 50"'test
Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 --- Comment #1 from Chris Cormack --- Created attachment 23174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23174&action=edit Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11308] New: RSS feed is slightly broken in bootstrap theme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Bug ID: 11308 Summary: RSS feed is slightly broken in bootstrap theme Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ch...@bigballofwax.co.nz QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22570|0 |1 is obsolete|| --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 23173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23173&action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the "OPACmaxItemsOnDetail". Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11129] Filtering Items based on type in opac-detail.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22569|0 |1 is obsolete|| --- Comment #7 from Olli-Antti Kivilahti --- Created attachment 23172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23172&action=edit Bug 11129 - Filtering Items based on type in opac-detail.pl Currently all Items are always shown on the opac-detail.pl. This is difficult when the amount of Items grows substantially large. Implemented a filter to limit the Items shown (and SELECTed from the DB) based on some typical filters, locationbranch, volume, number, issue, fromDate, toDate. Also streamlined how Serials-data is pulled from the DB to prevent substantial extra work in C4::Items::GetItemsInfo(). C4::Items::GetItemsInfo() extended to support various filters. All modifications: Item filter shown when there are over 50 items (lotsofitems-flag). Filter fields can be changed based on the Biblio type (isSerial-flag). -Volume + Issue + Number available only for serials. Can syspref if Issue-field is used in serial records. Can syspref a regexp to parse the Volume + Number + Issue from the enumeration or chronology field. FromDate and ToDate filter the serial.publisheddate when dealing with serials otherwise target the items.timestamp -column. C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL. This makes filtering by publisheddate much more faster. User input validated using HTML5 Business layer validations as well. Unit tests: Serials enumeration and chronology filtering Items date and branch filtering Formatted using perltidy and Perl::Critic Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #23161|0 |1 is obsolete|| --- Comment #29 from Kyle M Hall --- Created attachment 23171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23171&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com --- Comment #5 from M. Tompsett --- Tested according to test plan given in comment #1 for prog and bootstrap themes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 M. Tompsett changed: What|Removed |Added Attachment #23164|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 23169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23169&action=edit Bug 11307 : Potential XSS attack in rss feed To test: 1/ Craft a url like /cgi-bin/koha/opac-search.pl?q=a&count=50"'test&sort_by=acqdate_dsc&format=rss2 2/ look at the source, notice 50"'test 3/ apply the patch, and reload url 4/ source now contains 50"'test
Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 M. Tompsett changed: What|Removed |Added Attachment #23167|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 23170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23170&action=edit Bug 11307 : Follow up for bootstrap theme (master and 3.14.x only) To test: Same as first patch, but using bootstrap theme Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22696|0 |1 is obsolete|| --- Comment #34 from Olli-Antti Kivilahti --- Created attachment 23168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23168&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 --- Comment #2 from Chris Cormack --- Created attachment 23167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23167&action=edit Bug 11307 : Follow up for bootstrap theme (master and 3.14.x only) To test: Same as first patch, but using bootstrap theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22694|0 |1 is obsolete|| --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 23166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23166&action=edit Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. Formatted using perltidy and Perl::Critic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11020] Transfer limits should be checked when placing a hold/reservation in Staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22321|0 |1 is obsolete|| --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 23165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23165&action=edit Bug 11020 - Transfer limits should be checked when placing a hold/reservation in Staff client Extended bug 11005. Extended C4/Reserves.pm to support checking BranchTransferLimits when requested. Extension does in no way disturb existing functionality. Modified the templates to show branch transfer blocks to the user. Modified the business layer to re-check branch transfer limits in case user fools the POST-request. Created manual test plans. Formatted using perltidy and Perl::Critic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 --- Comment #1 from Chris Cormack --- Created attachment 23164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23164&action=edit Bug 11307 : Potential XSS attack in rss feed To test: 1/ Craft a url like /cgi-bin/koha/opac-search.pl?q=a&count=50"'test&sort_by=acqdate_dsc&format=rss2 2/ look at the source, notice 50"'test 3/ apply the patch, and reload url 4/ source now contains 50"'test
-- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Chris Cormack changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11307] New: Potential XSS attack vector in opac rss feed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Bug ID: 11307 Summary: Potential XSS attack vector in opac rss feed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ch...@bigballofwax.co.nz QA Contact: testo...@bugs.koha-community.org http://demo.mykoha.co.nz/cgi-bin/koha/opac-search.pl?idx=kw&q=a&count=50%22%27%3Ch1%3Etest%3C/h1%3E&sort_by=acqdate_dsc&format=rss2 If you look at the source you will see 50"'test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11306] Login bar over news in Mobile CCSR OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11306 Joel Sasse changed: What|Removed |Added CC||jsa...@plumcreeklibrary.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #22322|0 |1 is obsolete|| --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 23163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23163&action=edit Bug 10993 - Transfer limits should be checked when placing a hold/reservation in OPAC. Depends on bug 11005, 11020 Prevents a user from placing holds on material whose branch transfer is denied. Displays clear messages that items are unavailable and re-checks in the business layer in case of UI blocks failing. Enables choosing another pickup location. Manual test plan included. Formatted with perltidy and Perl::Critic level 5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Barry Cannon changed: What|Removed |Added Attachment #23003|0 |1 is obsolete|| --- Comment #14 from Barry Cannon --- Created attachment 23162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23162&action=edit Patch to fix Bug 6837 The original "AllowOnShelfHolds" SysPref had two options: "Allow" and "Don't Allow". When the preference was set to "Don't Allow" the system would still allow a hold to be placed on a bib if at least one of it's items was not on the shelf. This violated the SystemPreference. When this patch is implemented, and the "AllowShelfHolds" SysPref is set to "Don't Allow" the system will not provide a "Place Hold" option to the OPAC user if ANY item is on the shelf (in ANY location). Setting the SysPref to "Allow" will allow holds to be placed on the bib if there is an attached item on the shelf. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #23158|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall --- Created attachment 23161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23161&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11306] New: Login bar over news in Mobile CCSR OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11306 Bug ID: 11306 Summary: Login bar over news in Mobile CCSR OPAC Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 23160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23160&action=edit mobile See attached. If the library has News on the OPAC the black log in bar is across the middle of the page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11282] Not possible to create multiple restrictions from patron details/new restriction overwrites existing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11282 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA Version|3.14|master --- Comment #6 from Owen Leonard --- I can add an additional restriction from the patron edit page, but it doesn't save the date that I specify. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11303] Add to Cart doesn't work in pro > MARC biblio view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11303 --- Comment #1 from Frédéric Demians --- Same issue on ISBD tab: ISBDdetail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 --- Comment #4 from Frédéric Demians --- (In reply to Owen Leonard from comment #3) > After applying this patch I find that the "show more" links work, but > the "limit to available" link returns no results, and clicking any > facet returns no results. I'm continuing to test. Thanks for testing. I confirm that for me on an UNIMAC-DB, this patch solves the two bugs: (1) 'show more' facets, and (2) library limitation facet--without breaking neither other facets selection, nor availability restriction. Do you confirm the two bugs before applying the patch? Is it solved with the patch? And other facet selection were working? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304
Owen Leonard changed:
What|Removed |Added
Attachment #23156|0 |1
is obsolete||
--- Comment #2 from Owen Leonard ---
Created attachment 23159
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23159&action=edit
Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly
Detail page tabs are not displayed properly because JavaScript is broken
in French. This is due to _(' JS string construction used in place of
_(".
This patch fixes:
- opac-detail.tt page
- xt/single_quotes to test bootstrap theme
Signed-off-by: Owen Leonard
Tested by applying the patch, running translate update, then translate
install. Saw no JavaScript error on the French detail page.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- After applying this patch I find that the "show more" links work, but the "limit to available" link returns no results, and clicking any facet returns no results. I'm continuing to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #183 from Jonathan Druart --- This one became too long. It could be reopened if 11302 is wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #182 from M. de Rooy --- (In reply to Jonathan Druart from comment #181) > > *** This bug has been marked as a duplicate of bug 11302 *** Are you sure that you could close this report? The new report does not seem to be so generic as this one was. But your patch will certainly have my attention. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5725] Batch modifications for Biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Denise changed: What|Removed |Added CC||d.ga...@aarome.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What|Removed |Added Attachment #23137|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 23158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23158&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11305] Patrons with hundreds of checkouts cause extreme slowdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11305 --- Comment #1 from Kyle M Hall --- Created attachment 23157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23157&action=edit Bug 11305 - Patrons with hundreds of checkouts cause extreme slowdown - Quick fix [v3.12.x] For pages such as circulation.pl and moremember.pl, any patron with over a hundred checkouts or more can take an extremely long time to load ( 10's of seconds or more ). This is due to the large amount of data pulled and processed to display the patron's previous checkouts, relative's checkouts, and holds. To use: 1) Apply this patch 2) Create a "Local use" system preference "CirculationRowsLimit" 3) Set CirculationRowsLimit to an integer value. This value will be the maximum number of rows pulled for issues, relatives' issues and holds for circulation.pl. To view a patron's entire list of issues, use moremember.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11305] Patrons with hundreds of checkouts cause extreme slowdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11305 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11305] New: Patrons with hundreds of checkouts cause extreme slowdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11305 Bug ID: 11305 Summary: Patrons with hundreds of checkouts cause extreme slowdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org For pages such as circulation.pl and moremember.pl, any patron with over a hundred checkouts or more can take an extremely long time to load ( 10's of seconds or more ). This is due to the large amount of data pulled and processed to display the patron's previous checkouts, relative's checkouts, and holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11290] members-home.pl displays badly if using non english templates and have a utf8 char in categorycode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11290 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Jacek Ablewicz from comment #7) > I think the underlying cause for this particular problem in members.pl and > members-home.pl is that output()/utf8_arrayref()/utf8_hashref() subs in > Templates.pm do not know what to do with objects / blessed hashrefs (they > treat them as strings/scalars, actually calling utf8::is_utf8() on them > etc.). Preparing for Reno i had tried even removing any call to those sub. I'd be in favour of removing them and using template filters instead (I.e. less loops traversing data structures and less probable double encoding situations).. regards to+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Frédéric Demians changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304
Frédéric Demians changed:
What|Removed |Added
Status|NEW |Needs Signoff
Assignee|oleon...@myacpl.org |frede...@tamil.fr
--- Comment #1 from Frédéric Demians ---
Created attachment 23156
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23156&action=edit
Proposed patch
Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly
Detail page tabs are not displayed properly because JavaScript is broken
in French. This is due to _(' JS string construction used in place of
_(".
This patch fixes:
- opac-detail.tt page
- xt/single_quotes to test bootstrap theme
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11304] New: Bootstrap OPAC detail page doesn't display holding tabs properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304
Bug ID: 11304
Summary: Bootstrap OPAC detail page doesn't display holding
tabs properly
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleon...@myacpl.org
Reporter: frede...@tamil.fr
QA Contact: testo...@bugs.koha-community.org
Detail page tabs are not displayed properly because JavaScript is broken in
French. This is due to _(' JS string construction used in place of _(".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11303] Add to Cart doesn't work in pro > MARC biblio view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11303 Frédéric Demians changed: What|Removed |Added Depends on||9780 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9780] Restrict the right to suppress a record used in some order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Frédéric Demians changed: What|Removed |Added Blocks||11303 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11303] New: Add to Cart doesn't work in pro > MARC biblio view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11303 Bug ID: 11303 Summary: Add to Cart doesn't work in pro > MARC biblio view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: frede...@tamil.fr QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl To reproduce this bug: - Do a search in pro interface - On the result page, click on a biblio record title - On detail page, click on MARC tab if not already selected - Click on Add to > Cart Nothing happens. This is due to the fact that cat-toolbar.inc JavaScript is broken when called from MARCdetail.tt rather than detail.tt. Bug 9780 introduced two new variables countorder, and countdeletedorders, which are populated by detail.pl but not by MARCdetail.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #54 from Martin Renvoize --- Nice work Doug, excellent follow through. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #32 from Martin Renvoize --- It's great to see this bug making such progress.. just wanted to add my thanks to Doug, your doing a Stirling job keeping on top of it. Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Frédéric Demians changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|oleon...@myacpl.org |frede...@tamil.fr --- Comment #2 from Frédéric Demians --- Created attachment 23155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23155&action=edit Proposed patch Bug 11277 Bootstrap theme facets doesn't work properly Two errors: 1. When selecting 'show more' above a facet, the advanced search page is displayed. 2. When restricting search on a library facet, all the biblio records of this library are returned. The patch fixes the way URL are encoded with TT filter. See that: http://search.cpan.org/~abw/Template-Toolkit-2.25/lib/Template/Manual/Filters.pod#url -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 --- Comment #1 from Frédéric Demians --- In the same area, search result limitation on Library facet, doesn't work. It returns all biblio records of the selected library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11277] Bootstrap theme: error in link for showing all facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11277 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11290 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11290] members-home.pl displays badly if using non english templates and have a utf8 char in categorycode description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11290 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11302 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 --- Comment #2 from Jonathan Druart --- Created attachment 23154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23154&action=edit Bug 11302: Template::output should deal with objects if a ref is not HASH or ARRAY, C4::Template::output assumes it is a scalar. Which is wrong, it could be an object. At least the member 'description' of the C4::Category object should be encoded. Test plan: Before applying the patch - translate a template for a language - create a patron category with a no-ASCII character - got the patron home page and select the translated language - you should see a broken encoding Apply the patch - refresh the page - all looks good now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019 Bug 10019 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #181 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 11302 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951 Bug 9951 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10074] Encoding problems for login and installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074 Bug 10074 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10070] History of anonymous searches is not kept
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Bug 10070 depends on bug 6554, which changed state. Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in templates http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] New: Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Bug ID: 11302 Summary: Template::output should deal with object Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org This report replaces bug 6554. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11302] Template::output should deal with object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Jonathan Druart changed: What|Removed |Added CC||du...@library.lviv.ua --- Comment #1 from Jonathan Druart --- *** Bug 6554 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Jacek Ablewicz changed: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
