[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

M. Tompsett  changed:

   What|Removed |Added

  Attachment #23252|0   |1
is obsolete||

--- Comment #24 from M. Tompsett  ---
Comment on attachment 23252
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod

I think my description is a little cleaner, but I've left the patch which I
think is the one to rebase, and debug. Sadly, it failed to give me results:

opac
search
happy - all libraries
result count: (note the number)
advanced search
keyword = happy
go to the library dropdown and select all then click search.
BUSTED!

All and Securehome settings busted. Preferhome works with my current system
preference settings. Have fun debugging.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

M. Tompsett  changed:

   What|Removed |Added

  Attachment #23251|0   |1
is obsolete||

--- Comment #23 from M. Tompsett  ---
Created attachment 23252
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23252&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod

This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.

This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All= no change from standard koha setup.
Preferhome = Prefers patron's home library
 (others may be searched), koha's current
 functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
 libraries (if any) can be searched.

With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"

This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.

This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.

Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.

To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.

So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.

You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

M. Tompsett  changed:

   What|Removed |Added

  Attachment #23250|0   |1
is obsolete||

--- Comment #22 from M. Tompsett  ---
Created attachment 23251
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23251&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod

This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.

This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All= no change from standard koha setup.
Preferhome = Prefers patron's home library
 (others may be searched), koha's current
 functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
 libraries (if any) can be searched.

With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"

This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.

This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.

Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.

To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.

So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.

You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

M. Tompsett  changed:

   What|Removed |Added

  Attachment #23038|0   |1
is obsolete||

--- Comment #21 from M. Tompsett  ---
Created attachment 23250
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23250&action=edit
Bug 9055: Mandumah.com's multiple branch search, multiple branch security mod

This mod creates the ability to search multiple branches using
a jquery dropdown, instead of just one or all branches.

This mod also replaces SearchMyLibraryFirst preference, giving
three options:
All= no change from standard koha setup.
Preferhome = Prefers patron's home library
 (others may be searched), koha's current
 functionality of SearchMyLibraryFirst.
Securehome = Only patrons' home library and other assigned
 libraries (if any) can be searched.

With multiple instances of branchcode inside Borrower extended
attributes, a patron can be given multiple branches to search
within. The Securehome concept also includes the branch given
in the apache enviroment of the host/virtualhost contacted,
from OPAC_SEARCH_LIMIT = "branch: blah"

This patch not only filters the GetBranches results, filtering
the patrons ability to see other branches other than the ones
given, it also filters the branches given in the limit branch:
search options, so that even if a user manually inputted a
branch, they are still only getting what they are ment to get.

This enhancement would be useful for big libraries, in which
its members would be restricted to searching and borrowing
from a subset of its books.

Overall, the multiple branch search dropdown should prove
useful, even with unsecure installations. What is not included
yet, is a method to decide what branches to show to a guest,
not-logged-in, user.

To use this patch, you need to create a branchcode Patron
Extended Attribute, and have the patron your working with,
have one or more branchcode extended attributes.

So, total branches that patron will get:
OPAC_SEARCH_LIMIT branch + Patron record home branch
+ whatever branchcodes you put into Borrower_attributes.

You also need to set the preferences. The three new preferences
to set are:
- OPAC: SearchableBranches
- Patrons: multibranch
- Searching: MultiBranchSelect

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11330] New: Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330

Bug ID: 11330
   Summary: Inconsistent field/subfield descriptions on MARC21
bibliographic frameworks
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org

There are many inconsistencies on field/subfield descriptions on MARC21
bibliographic frameworks.

That fact makes very hard to translate frameworks accurately using an automated
procedure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Galen Charlton  ---
Pushed to master.  Thanks, Chris!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10891] Make facets customisable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #25 from M. Tompsett  ---
(In reply to mathieu saby from comment #2)
> Hi Frederic
> I was thinking of a syspref first. It would be easier for me to do (2
> sysprefs in fact, one for unimarc, the other for marc21/normarc)

A Koha system can't be both unimarc and marc21/normarc at the same time. Why
would you need two?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #9 from M. Tompsett  ---
Could not this bug just get the zebra facets working, and then whatever needs
to be done to filter be worked on in bug 10891?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #8 from Jared Camins-Esakov  ---
(In reply to David Cook from comment #7)
> Also note that you will have to individually set up each index that you want
> to use for facet queries.
> 
> As per this email from an IndexData person:
> http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html
> 
> In general, this shouldn't case a problem, since we only use a short list of
> facets. However, it would create a barrier to allowing users to customize
> their results.

This has to be changed in two places. In the server elements configuration, as
described at that link, *and* an additional index has to be configured for each
facet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #7 from David Cook  ---
Also note that you will have to individually set up each index that you want to
use for facet queries.

As per this email from an IndexData person:
http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html

In general, this shouldn't case a problem, since we only use a short list of
facets. However, it would create a barrier to allowing users to customize their
results.

In theory, we could list all or most of the available indexes in the Zebra
config files. Then, we could use a system preference or a DB table to choose
which indexes we want to use for facets. This would generate the "elements"
string that we pass to Zebra everytime we want our facets.

Actually, now that I think about it...that might not be a bad idea. We already
have that Search.pm sub where we're manually keeping track of indexes, so we
could keep that or use something similar to fill an HTML list and have that
create our Zebra facet string. 

So long as we generate the string once and then use it multiple times...that
should be all right. We could also have a hardcoded fallback string in case
someone deletes the facet config in Koha or if their facet config is bad. 

Hmm. Ideas. Ideas. Ideas...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #23243|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #23245|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #23246|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #11 from Katrin Fischer  ---
Created attachment 23249
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23249&action=edit
[PASSED QA] Bug 11322 : XSS - Scrub bad data before storing suggestions in the
db

1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped

Signed-off-by: David Cook 

Works as described.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #10 from Katrin Fischer  ---
Created attachment 23248
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23248&action=edit
[PASSED QA] Bug 11322 : XSS in suggestions - OPAC

1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html

Signed-off-by: David Cook 

Works as described.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #9 from Katrin Fischer  ---
Created attachment 23247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23247&action=edit
[PASSED QA] Bug 11322 : XSS in suggestions

To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped

Signed-off-by: David Cook 

Works as described.

Signed-off-by: Katrin Fischer 
Passes all tests, thx Chris!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #6 from David Cook  ---
I'm outlining below a rough guide to how to enable Zebra facetting. Note that
this has nothing to do with Koha per se. This is just about setting up Zebra.
The actual Koha code to make use of Zebra's facets will have to come after
initial setup, and at the moment it's just not at the top of my list of
priorities.

First, take stock of which version of Koha you're running and note which type
of indexing you're using (DOM or GRS1).

Look for these two files in your /etc/zebradb/ folder:
"retrieval-info-bib-dom.xml"
"retrieval-info-bib-grs1.xml"

If you can't find them, you're probably running an older version of Koha and
you'll want to modify your "koha-conf.xml". If you do find them, the config in
"koha-conf.xml" is only a fallback, so not necessary for testing.


Step One:
a) Edit the file that suits your version of Koha and method of indexing.
(i.e. if you're running the latest Koha with dom, edit
"retrieval-info-bib-dom.xml". If you're running the latest Koha with grs1, edit
"retrieval-info-bib-grs1.xml". If you're running an older version of Koha,
you're only using grs1 and you'll need to edit "koha-conf.xml"

Step Two:
a) Add lines like the following as children to the "" node (N.B.
do not add them to the top as they will displace the default retrieval syntax
setting. Add them at the bottom.):





(N.B. Paul Poulain mentioned that the "0" register is a "raw"(?) register and
that this should be used if you have issues with diacritics or non-Latin
characters. I imagine that this needs to be set up in your records.abs or DOM
XSLT.)

(N.B. You can substitute any index in for "any" or "title". You can also use
any register instead of "w" or "0", such as "p".)

Step Three: 
a) Restart your Zebra server

Step Four:
a) Connect to Zebra using yaz-client (e.g. yaz-client open
"unix:/zebra/test/var/run/zebradb/bibliosocket")(You can find your specific
path by looking at the top of koha-conf.xml for a "listen" node with an ID of
"biblioserver")

b) Tell Zebra to use facets (e.g. elements zebra::facet::any:w,title:w,title:0)
c) Do a search (e.g. find test)
d) Show your results (e.g. show 1+1)
e) You should now see a list of facets for your search results

--

If you have any issues with these instructions, comment here, find me in the
IRC channel or visit the sites that I'm linking below.

--

For more information, visit the following links:

http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for
"facet")

http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is a
discussion of setting up Zebra facets)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #5 from mathieu saby  ---
(In reply to David Cook from comment #4)
> (In reply to mathieu saby from comment #3)
> > Note that there is currently a big issue for UNIMARC facets:
> > the facet build on type of document (equivalent of 942 in MARC21) is not
> > visible.
> > 
> > That's because some libraries use 099$t for that, and others use other
> > fields like 210$b that are not made for that.
> > That was the main goal of my not-yet-written-patch for make facets
> > customisable...
> > 
> > But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version
> > onwards the type of document is stored in 099t, and provide a script for
> > copying types of documents from other fields to this one for non standard
> > configuration.
> > 
> > Mathieu
> 
> With zebra facets, it uses the index. So if both those marc tags are filling
> the same index, it should be fine.

I did not think of it... Of course ;-)
So, it will really be a nice improvement for 3.16 if Zebra facets could be
used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

--- Comment #9 from Katrin Fischer  ---
I have followed the instructions and set up https, but I am confused by the
results:

OPAC
Still running on localhost:8080, but the Amazon cover URL appears as https://
on the results page and on the details page.

Intranet
Now working with localhost and 442, but the Amazon cover URL is still http://
on the results and the details page.

Liz, can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #4 from David Cook  ---
(In reply to mathieu saby from comment #3)
> Note that there is currently a big issue for UNIMARC facets:
> the facet build on type of document (equivalent of 942 in MARC21) is not
> visible.
> 
> That's because some libraries use 099$t for that, and others use other
> fields like 210$b that are not made for that.
> That was the main goal of my not-yet-written-patch for make facets
> customisable...
> 
> But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version
> onwards the type of document is stored in 099t, and provide a script for
> copying types of documents from other fields to this one for non standard
> configuration.
> 
> Mathieu

With zebra facets, it uses the index. So if both those marc tags are filling
the same index, it should be fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

David Cook  changed:

   What|Removed |Added

  Attachment #23244|0   |1
is obsolete||

--- Comment #8 from David Cook  ---
Created attachment 23246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23246&action=edit
Bug 11322 : XSS - Scrub bad data before storing suggestions in the db

1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped

Signed-off-by: David Cook 

Works as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

David Cook  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

David Cook  changed:

   What|Removed |Added

  Attachment #23242|0   |1
is obsolete||

--- Comment #7 from David Cook  ---
Created attachment 23245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23245&action=edit
Bug 11322 : XSS in suggestions - OPAC

1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html

Signed-off-by: David Cook 

Works as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Chris Cormack  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #6 from Chris Cormack  ---
Created attachment 23244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23244&action=edit
Bug 11322 : XSS - Scrub bad data before storing suggestions in the db

1/ In the public interface, add a suggestion containing html
2/ Save, notice the html is rendered (or if you have the other patches
is displayed)
3/ Apply this paget
4/ Add another suggestion
5/ Notice the html is stripped

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

David Cook  changed:

   What|Removed |Added

  Attachment #23241|0   |1
is obsolete||

--- Comment #5 from David Cook  ---
Created attachment 23243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23243&action=edit
Bug 11322 : XSS in suggestions

To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped

Signed-off-by: David Cook 

Works as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #4 from Chris Cormack  ---
Created attachment 23242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23242&action=edit
Bug 11322 : XSS in suggestions - OPAC

1/ Add a suggestion in the opac, with lots of html
2/ View that suggestion in the OPAC, note the html is rendering
3/ Apply the patch
4/ Test again, in prog and bootstrap, no more rendered html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

--- Comment #3 from Chris Cormack  ---
Created attachment 23241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23241&action=edit
Bug 11322 : XSS in suggestions

To test
1/ Switch on purchase suggestions
2/ On the public interface (OPAC) add a suggestion, put html in every
field
3/ In the staff interface go to the suggestions page
/cgi-bin/koha/suggestion/suggestion.pl
4/ Notice the html is rendered
5/ Click on a suggestion, notice the html is rendered on the show page
also
6/ Apply the patch, check these two pages again, html should now be
escaped

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ch...@bigballofwax.co.nz
   Severity|major   |critical

--- Comment #2 from Chris Cormack  ---
Working on some patches for this now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #1 from Galen Charlton  ---
Not just notes -- most of the fields in the suggestion form (except for title)
aren't using the Template Toolkit HTML filter.  A combination of using
C4::Scrubber and the HTML TT filter should provide belts and suspenders.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #23219|0   |1
is obsolete||

--- Comment #46 from Srdjan Jankovic  ---
Created attachment 23240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23240&action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm

This gets rid of some more warnings.

It also corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );

It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.

This includes:
my $q_userid = $query->param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session->param('id') // '';
Indentation does not reflect actual scoping.

A missing system preference would have triggered a ubiquitous
undef compare check failure message. This makes the flooding
message more useful, so as to help correct it.
The change to accomplish this was:
my $pki_field = C4::Context->preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR "Error: Missing AllowPKIAuth System Preference!\n";
$pki_field = 'None';
}

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4533] Add "duplicate item" link when editing items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4533

Peggy Thrasher  changed:

   What|Removed |Added

 CC||p.thras...@dover.nh.gov

--- Comment #3 from Peggy Thrasher  ---
We would like this too!
Peggy

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Ketan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main entry

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #16 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Philippe and congratulations!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

--- Comment #9 from Galen Charlton  ---
(In reply to Jonathan Druart from comment #8)
> Something like that?

Not as a default behavior -- I'd prefer that the caller explicitly ask for
(say) date_only or as_due_date, not have the behavior of stripping off "23:59"
be hardcoded. (Also, stripping off "23:59" doesn't work if the timeformat is
12hr).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

--- Comment #7 from Jonathan Druart  ---
Created attachment 23239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23239&action=edit
Bug 11148: Followup only display the hours unless "23:59"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

--- Comment #8 from Jonathan Druart  ---
Something like that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #40 from Galen Charlton  ---
Pushed to master.  Thanks, Mathieu!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

Jonathan Druart  changed:

   What|Removed |Added

 Status|Pushed to Master|In Discussion

--- Comment #6 from Jonathan Druart  ---
Galen, I suspect you had a mistake on updating the status :) It is not pushed
to master but in discussion.

Maybe should we never display the hour/minutes if it's 23:59?
So we remove the dateonly flag and we don't need a new routine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2693] Tagging: Add filter by name

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #9 from Galen Charlton  ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #18 from Galen Charlton  ---
Pushed to master.  Thanks, Oliver!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

mathieu saby  changed:

   What|Removed |Added

  Attachment #23108|0   |1
is obsolete||

--- Comment #39 from mathieu saby  ---
Created attachment 23238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23238&action=edit
Bug 11202 - Improve UNIMARC biblio indexing

Sorry :(
It's fixed.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

mathieu saby  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #38 from Paola Rossi  ---
Hello, Mathieu.

I apply the patch against master 3.15.00.002.

Rebuilding zebra indexes, an error appears:


Rebuilding zebra indexes against master without patching, the error doesn't
appear.

The two notices, coming from opac.sbn.it:2100, DB nopac, are:
Nilo, antico Nilo / Folco Quilici
Il Nilo / Pier Domenico Boccardi

So I pass the patch to "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #23234|0   |1
is obsolete||
  Attachment #23235|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 23236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23236&action=edit
[SIGNED OFF] Bug 11096: force XML syntax for Zconn and remove
MARC::File::USMARC everywhere.

This patch makes Koha <-> Zebra exchange speak XML instead of the
current 'USMARC'. For that, it changes some bits in
- C4::Context->Zconn
- C4::Context-_new_Zconn
Zebra's 'element' variable is set to "marcxml" to match our zebra config files.

References to MARC::File::USMARC::decode are substituted for calls to
the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit
'UTF-8' encoding for the task.

This patch also removes calls to the unsafe ZOOM::Record->render()[2] method.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).

- The FindDuplicates function was MARCXML-ized too.
- Unit tests have been moved to expect MARCXML from Zebra as well.

TODO: relevance still uses USMARC. Need advise on that.

References to MARC::File::USMARC where replaced for the corresponding
MARC::File::XML
counterpart from AuthoritiesMarc.pm.
 - Authorities search should work as usual.
 - Set dontmerge to see AuthoritiesMarc::merge still works.

Regards
To+

[1] As a side effect some encoding problems got fixed in facets and record
details.
   
http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode()
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Katrin Fischer 
Testing notes on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #18 from Katrin Fischer  ---
Created attachment 23237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23237&action=edit
[SIGNED OFF] Bug 11096: wrap MARC::Record->new_from_xml call with eval

Catch situations where MARC::Record would croak for bad-formed records.

To test:
- Run prove t/db_dependent/Search.t
- It will fail at test 65 [1]
- Apply the patch, it will warn for some failing records,
 but the tests will run smoothly.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

[1] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Signed-off-by: Katrin Fischer 

- All tests and QA script pass after applying the patch.
- Verfied that sample record is not searchable before applying
  patch, but can be searched without problems after applying it.
- Tested authority searching still workds as expected.
- Tested bilbiographic searching still works as expected.
  - Simple search, also truncated search terms
  - Facetting
  - Advanced search, also itemtype and pubyear limits
- Tested dontmerge preference, editing a linked authority and
  confirming the change is made to the linked records as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #16 from Katrin Fischer  ---
Created attachment 23235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23235&action=edit
[PASSED QA] Bug 11096: wrap MARC::Record->new_from_xml call with eval

Catch situations where MARC::Record would croak for bad-formed records.

To test:
- Run prove t/db_dependent/Search.t
- It will fail at test 65 [1]
- Apply the patch, it will warn for some failing records,
 but the tests will run smoothly.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

[1] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Signed-off-by: Katrin Fischer 

- All tests and QA script pass after applying the patch.
- Verfied that sample record is not searchable before applying
  patch, but can be searched without problems after applying it.
- Tested authority searching still workds as expected.
- Tested bilbiographic searching still works as expected.
  - Simple search, also truncated search terms
  - Facetting
  - Advanced search, also itemtype and pubyear limits
- Tested dontmerge preference, editing a linked authority and
  confirming the change is made to the linked records as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #23030|0   |1
is obsolete||
  Attachment #23033|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 23234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23234&action=edit
[PASSED QA] Bug 11096: force XML syntax for Zconn and remove MARC::File::USMARC
everywhere.

This patch makes Koha <-> Zebra exchange speak XML instead of the
current 'USMARC'. For that, it changes some bits in
- C4::Context->Zconn
- C4::Context-_new_Zconn
Zebra's 'element' variable is set to "marcxml" to match our zebra config files.

References to MARC::File::USMARC::decode are substituted for calls to
the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit
'UTF-8' encoding for the task.

This patch also removes calls to the unsafe ZOOM::Record->render()[2] method.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field->as_string).

- The FindDuplicates function was MARCXML-ized too.
- Unit tests have been moved to expect MARCXML from Zebra as well.

TODO: relevance still uses USMARC. Need advise on that.

References to MARC::File::USMARC where replaced for the corresponding
MARC::File::XML
counterpart from AuthoritiesMarc.pm.
 - Authorities search should work as usual.
 - Set dontmerge to see AuthoritiesMarc::merge still works.

Regards
To+

[1] As a side effect some encoding problems got fixed in facets and record
details.
   
http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode()
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Katrin Fischer 
Testing notes on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #28 from mathieu saby  ---
(In reply to Martin Renvoize from comment #27)
> Hi Mathieu, 
> 
> There were a few IRC converstaions and a thread on the mailing list about
> tidying the whole koha codebase at some point.. I think the final decision
> was to just do it as we go along instead of a massive change.. which is
> exactly what you've done here so is good..
> 
> I'de leave the patch in, now it's marked passed QA it'll pass by Galen
> attention and I'm sure he'll make a sensible decision either way.
> 
> Martin

OK
I remember having read 
- not to mix reindenting and new code in the same commit
- not to do a patch only for reindenting

So, as this bug changes some behavior in a template file, I think it is
legitimate to add a followup for reindenting the file.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #27 from Martin Renvoize  ---
Hi Mathieu, 

There were a few IRC converstaions and a thread on the mailing list about
tidying the whole koha codebase at some point.. I think the final decision was
to just do it as we go along instead of a massive change.. which is exactly
what you've done here so is good..

I'de leave the patch in, now it's marked passed QA it'll pass by Galen
attention and I'm sure he'll make a sensible decision either way.

Martin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #26 from mathieu saby  ---
(In reply to Martin Renvoize from comment #25)
> Passing QA for that final followup. It's a template tidy up which doesn't
> affect operation.
> 
> It'll affect blame as it change whitespace (which can be ignored by -w) but
> also breaks lines.
> 
> I'm not sure that discussion ever came to an end, but I don't see why the
> initial two patches can't get pushed?

Hello
Discussion with whom?
In fact, if someone really does not want this followup, of course I can
suppress the patch. But I think the reindenting on this file was really needed
and will make further changes easier ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #25 from Martin Renvoize  ---
Passing QA for that final followup. It's a template tidy up which doesn't
affect operation.

It'll affect blame as it change whitespace (which can be ignored by -w) but
also breaks lines.

I'm not sure that discussion ever came to an end, but I don't see why the
initial two patches can't get pushed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10860] In-House Use

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

--- Comment #17 from mathieu saby  ---
(In reply to Jonathan Druart from comment #16)
> (In reply to mathieu saby from comment #15)
> > error: The following untracked working tree files would be overwritten by
> > merge:
> > misc/cronjobs/bulk_transferts.pl
> 
> This file does not exist in master. Remove it before applying the patch.

Oups. OK, sorry for that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9016] Multi transport types for notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #29 from mathieu saby  ---
I'll give a look later, but if the behavior of overdue_notices.pl is changed by
an other patch, I suppose I will be able to sign off this one.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9016] Multi transport types for notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #28 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #27)
Test plan is right. Please see the test plan from the active patches, not
obsolete ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #5 from mathieu saby  ---
(In reply to Jonathan Druart from comment #4)
> Did you check the dependency?

Oh no, I did not see it!
Sorry

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9016] Multi transport types for notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #27 from Jonathan Druart  ---
In fact the test plan is wrong. The 4th step is not for this patch.
The changes for overdue_notices is made by bug 10832.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

--- Comment #7 from mathieu saby  ---
By the way, does your patch works with QueryParser? Or does QP calculate
relevance differently?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

--- Comment #6 from mathieu saby  ---
(In reply to Fridolin SOMERS from comment #5)
> (In reply to mathieu saby from comment #4)
> You are looking at 225 and 410 fields. In default config those fields are
> indexed has "Title-series".
> This patch manages only "Title" index.

Yes, that's what I understood, but in your 1st message you wrote
"so that records with all searched terms in title, even not well ordered, are
more relevant."
So I imagined that if there are 3 records, with the 200 field of one them
matching the searched terms, and only 225/410 fields matching in the 2 others,
the record with the 200 matching the search terms would be the 1st in the
results.

But I suppose the algorithm is more complex than that (and the core of it is
hardcoded in Zebra, isn't it?)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #24 from Martin Renvoize  ---
Works as expected.. the final patch really is just a indenting clean up.

Patch still works, patches all still pass qa script and code looks much nicer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #22827|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 23233
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23233&action=edit
Bug 9807, followup: Reindent basketgroup.tt

Basketgroup.tt is very hard to read. This patch simply reindents it.
No visiable changes expected

Regression test :
- check the list of opened and closed basketgroups for a vendor is displayed
properly
- check an individual basketgroup (closed and opened) is displayed properly
- check you can edit a basketgroup and save changes
- check you can print and export a basketgroup
- check you can close and reopen a basketgroup

http://bugs.koha-community.org/show_bug.cgi?id=9807
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Jonathan Druart  ---
Did you check the dependency?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10860] In-House Use

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #16 from Jonathan Druart  ---
(In reply to mathieu saby from comment #15)
> error: The following untracked working tree files would be overwritten by
> merge:
>   misc/cronjobs/bulk_transferts.pl

This file does not exist in master. Remove it before applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951

Bug 9951 depends on bug 6554, which changed state.

Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in 
templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019

Bug 10019 depends on bug 6554, which changed state.

Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in 
templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #23140|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Jonathan Druart  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10074] Encoding problems for login and installer

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074

Bug 10074 depends on bug 6554, which changed state.

Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in 
templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10070] History of anonymous searches is not kept

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070

Bug 10070 depends on bug 6554, which changed state.

Bug 6554 Summary: Resolve encoding problems with corrected UTF8 handling in 
templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11302] Template::output should deal with object

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |INVALID

--- Comment #6 from Jonathan Druart  ---
I was just a try. If it does not work, I reopen the initial report and close
this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

--- Comment #5 from Fridolin SOMERS  ---
(In reply to mathieu saby from comment #4)
You are looking at 225 and 410 fields. In default config those fields are
indexed has "Title-series".
This patch manages only "Title" index.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

--- Comment #2 from M. de Rooy  ---
Created attachment 23232
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23232&action=edit
Bug 11329: Check for marc record in catalogue/showmarc

Intranet counterpart patch. Same check as in opac/opac-showmarc.

Test plan:
[1] Run showmarc.pl with valid biblionumber in id parameter.
[2] Remove id parameter from URL. You should get a 404 now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

M. de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

--- Comment #1 from M. de Rooy  ---
Created attachment 23231
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23231&action=edit
Bug 11329: Check for marc record in opac-showmarc

Instead of just running as_formatted, check if GetMarcBiblio returned
a reference. If you e.g. did not pass an id, return 404 instead of 500.
Consistent with opac-export.pl

Test plan:
[1] Run opac-showmarc.pl with valid biblionumber in id parameter.
[2] Remove id parameter from URL. You should get a 404 now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11329] New: Check for marc record in opac-showmarc

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

Bug ID: 11329
   Summary: Check for marc record in opac-showmarc
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: m.de.r...@rijksmuseum.nl
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Instead of just running as_formatted, check if GetMarcBiblio returned
a reference. If you e.g. did not pass an id, return 404 instead of 500.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11329] Check for marc record in opac-showmarc

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11329

M. de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/