[Koha-bugs] [Bug 11232] Retrieve facets from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #10 from mathieu saby mathieu.s...@univ-rennes2.fr --- Actually, now that I think about it...that might not be a bad idea. We already have that Search.pm sub where we're manually keeping track of indexes, so we could keep that or use something similar to fill an HTML list and have that create our Zebra facet string. I thought this list of index in search.pm was going to be deprecated with the adoption of QueryParser ? Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11232] Retrieve facets from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #11 from mathieu saby mathieu.s...@univ-rennes2.fr --- (In reply to David Cook from comment #6) I'm outlining below a rough guide to how to enable Zebra facetting. Note that this has nothing to do with Koha per se. This is just about setting up Zebra. The actual Koha code to make use of Zebra's facets will have to come after initial setup, and at the moment it's just not at the top of my list of priorities. First, take stock of which version of Koha you're running and note which type of indexing you're using (DOM or GRS1). Look for these two files in your /etc/zebradb/ folder: retrieval-info-bib-dom.xml retrieval-info-bib-grs1.xml If you can't find them, you're probably running an older version of Koha and you'll want to modify your koha-conf.xml. If you do find them, the config in koha-conf.xml is only a fallback, so not necessary for testing. Step One: a) Edit the file that suits your version of Koha and method of indexing. (i.e. if you're running the latest Koha with dom, edit retrieval-info-bib-dom.xml. If you're running the latest Koha with grs1, edit retrieval-info-bib-grs1.xml. If you're running an older version of Koha, you're only using grs1 and you'll need to edit koha-conf.xml Step Two: a) Add lines like the following as children to the retrievalinfo node (N.B. do not add them to the top as they will displace the default retrieval syntax setting. Add them at the bottom.): retrieval syntax=xml name=zebra::facet::any:w/ retrieval syntax=xml name=zebra::facet::title:w/ retrieval syntax=xml name=zebra::facet::title:0/ (N.B. Paul Poulain mentioned that the 0 register is a raw(?) register and that this should be used if you have issues with diacritics or non-Latin characters. I imagine that this needs to be set up in your records.abs or DOM XSLT.) (N.B. You can substitute any index in for any or title. You can also use any register instead of w or 0, such as p.) Step Three: a) Restart your Zebra server Step Four: a) Connect to Zebra using yaz-client (e.g. yaz-client open unix:/zebra/test/var/run/zebradb/bibliosocket)(You can find your specific path by looking at the top of koha-conf.xml for a listen node with an ID of biblioserver) b) Tell Zebra to use facets (e.g. elements zebra::facet::any:w,title:w,title:0) c) Do a search (e.g. find test) d) Show your results (e.g. show 1+1) e) You should now see a list of facets for your search results -- If you have any issues with these instructions, comment here, find me in the IRC channel or visit the sites that I'm linking below. -- For more information, visit the following links: http://www.indexdata.com/zebra/doc/zebra.pdf (Search in the document for facet) http://lists.indexdata.dk/pipermail/zebralist/2007-July/001682.html (This is a discussion of setting up Zebra facets) As DOM is now the new standard way of indexing, and GRS1 is going to be deprecated, maybe the work could be made only for DOM files? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23239|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23253action=edit Bug 11148: Add a as_due_date parameter to the output_pref routine This parameter is a boolean, if true, the hours won't be displayed if the time is 23:59 (24hr format) or 11:59 PM (12hr format). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to mathieu saby from comment #33) All these operations were possible with the permission (and with some choices in sysprefs), and not possible without, except one operation : checking out a document marked PEGI 12 to a 4 year child (I mapped biblioitems.agerestricted with 301a field, set the preference AgeRestrictionMarker with PEGI, and AgeRestrictionOverride to Don't allow) Thanks for testing Mathieu! The AgeRestrictionOverride pref has to be set to Allow if you want to override the age restriction, even if the new permission is set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added Attachment #22717|0 |1 is obsolete|| --- Comment #35 from mathieu saby mathieu.s...@univ-rennes2.fr --- Created attachment 23254 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23254action=edit [PATCH][SIGNED OFF] Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction Ok, so I sign off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think for consistency it also makes sense to have the descriptions the same on each framework. But also it will be really nice to have the marc frameworks nicely translatable with po files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23255 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23255action=edit Bug 11209: Check if a notice has been already sent today The previous patch checks if a notice has already been sent when the current notices has been sent in queue. Which is wrong! We have to check if a similar notice has been sent today. This patch has been created after an observation on a production server: If a user place on holds several items, he will receive 1 SMS per hold. Here we only want 1 SMS for all holds. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11232] Retrieve facets from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think it would be possible to agree that this is only done for DOM, as we are trying to phase out/deprecate GRS-1. There are some bugs in QueryParser that I would like to see addressed before we make it the standard (for example bug 10542). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #7 from mathieu saby mathieu.s...@univ-rennes2.fr --- And it still depends on 11208? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Doug, is this ready for sign off/QA with your follow ups? You can switch the status :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am moving this to failed QA - see questions and notes in comment 10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added CC||colin.campbell@ptfs-europe. ||com --- Comment #5 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 23256 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23256action=edit Supplementary patch The main patch removes the field but DelItem still attempts to populate it supplementary patch to remove that -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #21303|0 |1 is obsolete|| Attachment #21304|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23257 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23257action=edit [PASSED QA] Bug 5031: CSV profiles: content fields are required Some fields are required on editing/adding csv profiles. Test plan: - add a new csv profile (tools/csv-profiles.pl) without any value. - save = error on empty fields. - fill the marc content, select type=sql, fill the csv name input. - save = error on sql content field. - fill the sql content - save = the csv profile is saved. - retry for the edit form. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Comment: On top of both patches for Bug 10853 Works very well, now we get an alert with empty field Saves correctly MARC and SQL profiles Solved minor conflict introduced by tab followup on Bug 10853 Again small tab errors corrected in followup Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, looks a bit 'non standard' for Koha, but improves usability of the form. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 --- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23258 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23258action=edit [PASSED QA] Bug 5031 - followup to correct tabs Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tiny QA follow-up corrcting whitespace to match coding guidelines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow search in 'all libraries'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542 mathieu saby mathieu.s...@univ-rennes2.fr changed: What|Removed |Added CC||mathieu.saby@univ-rennes2.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- yes, it is just a followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #6 from Martin Renvoize martin.renvo...@ptfs-europe.com --- This patch needs a followup to remove any references in code to the marc column in deleteditems. I spotted one in C4/Items.pm at least. I'm also wondering if this affects the output of tools/export.pl (or rather assume it affects) so that will need correcting to. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- In fact, it is not a code dependency, more a functionality dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 --- Comment #7 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Looks like Colin did the first followup I wanted whilst I was failing.. can someone take care of the second one? I'll then nudge Katrin to do QA as with Colin's input I no longer can.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23259|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23260 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23260action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced it but I couldn't find ANY usage of it to fix. Rebased and fixed. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #22415|0 |1 is obsolete|| Attachment #22416|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23259 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259action=edit [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js To old plugin prevents the upgrade to the latest jquery. By replacing with openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest. Changes: - removed jquery.hotkeys.min.js - added shortcut.js - modified the related includes (doc-head-close.inc and help-top.inc) - modified the calls in staff-global.js Regression test: 1) apply the patch 2) in the intranet, test the shortcuts alt-q, alt-r, alt-u. These are the only affected functionalities. There is no new functionnality. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Passes all tests and QA script. Tested existing shortcuts for the search bar tabs on various circulation related pages. This uses a Javascript under BSD license, I wonder if it should be listed in the Aboutlicenses section that we are using it. As Yui is also BSD I assume the license is compatible. +/** + * http://www.openjs.com/scripts/events/keyboard_shortcuts/ + * Version : 2.01.B + * By Binny V A + * License : BSD + */ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23259|1 |0 is obsolete|| CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Comment on attachment 23259 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23259 [PASSED QA] Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js Please have different subjects on various patches - or git bz automatically obsoletes the first when attaching the second :) Also, Galen - please can you take a look at my note on the first patch before pushing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #8 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Setting back to Needs Signoff, I've gone through the code and don't think the third followup is required.. I believe the marc column is grabbed from biblioitems in the join so this isn't a regression. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #72 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to mathieu saby from comment #70) Hi Jonathan 3 remarks: - there is a little conflict (I solved it on my VM) I will submit a rebased patch. - when I click on A to see all the patrons with name begining with A, I am automatically redirected to the card of the only patron whose name begins with A. Is it a wanted behavior? When the table has only 1 result, the patron detail page is displayed. - when I try to sort the table according to names or cardnumber, the sorting is quite slow. It's surprizing, because I only have 10 patrons in my test base. So I fear the results will be worse with a real base. Maybe it's an issue of my computer, but do you think there is some part of code to optimize? With 3.7k patrons, I get a response in 600ms. - Is there a way to cancel a filter when it is too restrictive? or to cancel all filters? I don't understand. The filters on the left can be canceled on choosing the first entry 'all/any'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22265|0 |1 is obsolete|| --- Comment #73 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23261 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23261action=edit Bug 9811: Patron search improvement Rebased patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11249] Add db indexes on borrowers names
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23223|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 23262 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23262action=edit [PASSED QA] Bug 11249 - Add db indexes on borrowers names The borrowers search is by default on columns surname, firstname, othernames and cardnumber. (See C4::Members::_express_member_find). Addind db indexes will really increase the query speed. This patch adds bd indexes on surname, firstname, othernames (cardnumber has already an index). Those indexes must be defined with a size because columns are mediumtext. Test plan : Test with mysql client : mysql explain select * from borrowers where surname like 'A%'; ++-+---+---+---+-+-+--+--+-+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | ++-+---+---+---+-+-+--+--+-+ | 1 | SIMPLE | borrowers | range | surname_idx | surname_idx | 767 | NULL | 395 | Using where | ++-+---+---+---+-+-+--+--+-+ = key show the index is used Signed-off-by: Mathieu Saby mathieu.s...@univ-rennes2.fr Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, changes from updatedatabase and in kohastructure match. I think deletedborrowers can be left out, as it's not queried when doing patron searches. Patron deletes still work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11249] Add db indexes on borrowers names
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #47 from M. de Rooy m.de.r...@rijksmuseum.nl --- Thanks, Srdjan. Mark, could you please add your signoff too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize martin.renvo...@ptfs-europe.com --- I think I've got to the bottom of why I couldn't get this to work.. It's not implemented in the bootstrap theme. Could someone do a follow-up with bootstrap support please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8125] SIP should send Zipcode with address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23263 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23263action=edit Bug 8215 - Course Reserves - Omnibus - v3.12.07 Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com http://bugs.koha-community.org/show_bug.cgi?id=8125 Bug 8215 follow-up encoding for branches itemtypes Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: FIX ergonomic issue : 'Unchanged()' bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8125] SIP should send Zipcode with address
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23263|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8215] Add Course Reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #149 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23264 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23264action=edit Bug 8215 - Course Reserves - Omnibus - v3.12.07 Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com http://bugs.koha-community.org/show_bug.cgi?id=8125 Bug 8215 follow-up encoding for branches itemtypes Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Corinne Bulac corinne.ha...@bulac.fr Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Bug 8215: FIX ergonomic issue : 'Unchanged()' bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11331] New: CSV export for viewlog.pl is missing newlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Bug ID: 11331 Summary: CSV export for viewlog.pl is missing newlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: sophie.meyni...@biblibre.com QA Contact: testo...@bugs.koha-community.org When you try to export the result of tools/viewlog.pl in csv, file cannot be correctly loaded : - Newline is missing after each record, - strings should be enclosed in - columns are not the same as for screen output This patch corrects this 3 points -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Priority|P5 - low|P4 Patch complexity|--- |Small patch Assignee|gmcha...@gmail.com |sophie.meyni...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 --- Comment #1 from Sophie MEYNIEUX sophie.meyni...@biblibre.com --- Created attachment 23265 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23265action=edit Bug 11331 : corrects csv export for viewlog.pl (add newlines, string separator and same column as screen output) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11331] CSV export for viewlog.pl is missing newlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11331 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #16368|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23266 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23266action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23267 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23267action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077
--- Comment #48 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 23268
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23268action=edit
[SIGNED OFF] Bug 11077 - Correct silent warnings in C4/Auth.pm
This gets rid of some more warnings.
It also corrects a noisy ne condition.
$userid = $retuserid if ( $retuserid ne '');
became
$userid = $retuserid if ( $retuserid );
It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.
This includes:
my $q_userid = $query-param('userid') // '';
along with:
my $s_userid = '';
and:
my $s_userid = $session-param('id') // '';
Indentation does not reflect actual scoping.
A missing system preference would have triggered a ubiquitous
undef compare check failure message. This makes the flooding
message more useful, so as to help correct it.
The change to accomplish this was:
my $pki_field = C4::Context-preference('AllowPKIAuth');
if (!defined($pki_field)) {
print STDERR Error: Missing AllowPKIAuth System Preference!\n;
$pki_field = 'None';
}
Signed-off-by: Srdjan srd...@catalyst.net.nz
Signed-off-by: Mark Tompsett mtomp...@hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23240|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #49 from M. Tompsett mtomp...@hotmail.com --- Re-tested. - staff client: click login with nothing entered - click login with just a valid username entered - click login with proper credentials entered - log out - deleted system preference - click login with proper credentials - ran qa tool Looks good to me. Signed off, as you requested Marcel. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #31 from Kyle M Hall k...@bywatersolutions.com --- Sorry I missed this comment until now! 1/ Don't you think we should avoid calls to Koha::Database in pl files ? Using DBIx::Class is, afaik, allowed in pl files. Requiring it to be called from modules only just requires yet another layer of abstraction. The only time this is necessary is when business logic needs to be applied. That is, we should definitely keep code DRY by moving repeated chunks of code into a module subroutine, but for a single line call that is not affected by system preferences, this is both unnecessary and unwanted. It would merely slow the system down. For repeated pieces of code that utilize system preferences, I think they *should* be in modules. Better yet, they should be part of the DBIx::Class files, but we haven't gotten to that stage yet. If I am violating my own person views written above, it's simply because I am attempting to implement this new accounting system while making as few modifications to existing code as possible. I think any violations will need to be taken care of eventually. This is of course, assuming everyone else agrees with my views. In any case, those violations can and should be taken care of post-push once we have formalized our policies regarding usage of DBIC. 2/ Don't you think new module in the Koha namespace should be OOP (for ex. using Class::Accessor)? Modules in the Koha namespace are not required to be OOP, and I can see no advantage to making Koha::Accounts OOP. The data objects themselves are OO, and Koha::Accounts is just a layer around these objects to manage them. Outside the DBIx scope, I am wondering why do you have 2 scripts account_payment.pl and members/account_payment_do.pl. I suppose it is in order to remove the $op variable. I think it would be better to head towards a REST architecture. For example, here, we could imagine executing the AddCredit routine on a POST method and using the show/list view on a GET That is certainly an interesting proposition. What advantages do you see to this? I'd take it much further and say we should make *all* fetching, creating, and updating of data be via REST methods, and make our scripts use those methods via ajax. I think this will make Koha much more responsive, and allow far more flexible integration with other software. What do you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #32 from Kyle M Hall k...@bywatersolutions.com --- One example of moving business logic into DBIC. Items should be smart enough to know that when item-level_itypes is set to biblio record, the call to $item-itype() should return $item-biblio-itemtype() instead. I imagine there is a way to override the existing itype() method, or we could just add a new method itemtype_by_preference() or similar. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23186|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23269 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23269action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11322] Suggestion notes field should be sanitized or escaped
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #13 from Jacek Ablewicz a...@biblos.pk.edu.pl --- Works as described for me too, thanks! On related subject, I think we may have some similiar problems with patron-submitted data in other places as well, e.g.: as a test I just submitted personal data update request from OPAC via opac/opac-memberentry.pl, with JS code in 'Address 2' field, and injected script seems to work in members/members-update.pl. But I guess it would be better to assign separate bug numbers for such further issues (if any)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11332] New: add overdues to the notices tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11332 Bug ID: 11332 Summary: add overdues to the notices tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be great if the notices tab on the patron record also showed the overdue notices that were sent to the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #12 from Galen Charlton gmcha...@gmail.com --- Pushed to master, along with followups to move it out of jquery/plugins (as shortcuts.js is not actually a jQuery plugin) and to update the About | Licenses page. Thanks, Philippe! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #29 from Koha Team AMU koha.aixmarsei...@gmail.com --- Impossible to test because the permissions are missing. We need : # limited_item_edition Limit item modification to barcode, status and note (please note that edit_item is still required) # manage_shelves Allows to manage shelves # delete_all_items Delete all items # merge_from_shelves Allows to merge records from shelves # items_limited_batchmod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Koha Team AMU from comment #29) Impossible to test because the permissions are missing. Sorry, it was caused by the updatedb version. It should be fixed now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23271 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23271action=edit Bug 7673: QA Followup: trailing whitespace and perlcritic issues This patch fixes the following qa issues: FAIL cataloguing/additem.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 833) FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). FAIL tools/batchMod.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 2 violation(s). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7673] New patron permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #23266|0 |1 is obsolete|| Attachment #23267|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23270 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23270action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status The SubfieldsToAllowForLimitedEdition syspref is used to define which subfields can be edited when the editcatalogue.limited_item_edition permission is enabled. In the same way, the SubfieldsToAllowForLimitedBatchmod is used to define which subfields can be edited when the tools.items_limited_batchmod permission is enabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #15 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11332] add overdues to the notices tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11332 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Nicole C. Engard neng...@gmail.com --- Okay, I found an example after talking to Katrin ... apparently it's there. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #21636|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23272 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23272action=edit Bug 9016: DB changes: new table overduerules_transport_types This patch adds: - a new table overduerules_transport_types. - a new column letter.message_transport_type. - a new primary key for letter. - fill the new table with existing values. Test plan: After applying this patch and executing the updatedatabase entry, verify that the overduerules_transport_types table contains a row for each entry in the overduerules table. The message_transport_type column should contain 'email'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11333] New: use jQuery validator plugin for CSV profile forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Bug ID: 11333 Summary: use jQuery validator plugin for CSV profile forms Change sponsored?: --- Product: Koha Version: master Hardware: All URL: tools/csv-profiles.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Depends on: 5031 The patch for bug 5031 added use of the HTML5 required attributes. The jQuery validator plugin introduced in bug 6209 should also be used, as that will add validation support for non-HTML5 browsers and will standardize the look of messages for validation errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Blocks||11333 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22814|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 23273 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23273action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016
--- Comment #33 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Olli-Antti Kivilahti from comment #30)
-
+ updatedatabase.pl +
-
Yes, since 3.14 is out, new update db should be marked 3.15.00.XXX
---
+ perl Overdues.t +
---
ok 1 - use C4::Overdues;
ok 2 - C4::Overdues-can('GetOverdueMessageTransportTypes')
DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at
Overdues.t line 23.
DBD::mysql::db do failed: Duplicate entry 'CPL-PT' for key 'PRIMARY' at
Overdues.t line 23.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 2.
Last patch removes data in the overduerules table too.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11333] use jQuery validator plugin for CSV profile forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11333 --- Comment #1 from Galen Charlton gmcha...@gmail.com --- Created attachment 23274 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23274action=edit Bug 11333: use jQuery validator plugin for CSV profiles forms This patch adds the use of the jQuery validator plugin for the two forms (new and edit) on the CSV profiles page. Doing this standardizes messages that gets displayed on validation errors. This patch, in the process, fixes a bug where if a page has more than one validated form, only the first such form would get the validator plugin applied to it -- it looks like $.validate() does not do implicit iteration. To test: [1] Apply the patch, then go to Tools | CSV profiles. [2] Create a new profile, but leave the name and the MARC/SQL fields blank. When you click the submit button, the form should not be submitted; instead, text will be displayed to the right of each input that lacks required input. [3] As above, but change the profile type and verify that the form is not submitted unless all of the required fields are filled in. [4] Edit an existing form, then empty the MARC/SQL field. Try submitting the form; it should refuse to submit the form and display text saying that the field is required. Signed-off-by: Galen Charlton g...@esilibrary.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate that profile marcfields are required
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031 --- Comment #16 from Galen Charlton gmcha...@gmail.com --- (In reply to Jonathan Druart from comment #11) (In reply to Katrin Fischer from comment #10) It looks really nice, but not like in other places of Koha :) But maybe Owen could take a look later? I used the required attribute and the required class. The attribute is a new one (html5) and the required class is the way to do, I think. I switch back to Signoff: since bug 10853 is pushed to master, I think this one should be in 3.14 I will quickly submit another patch if Owen considers something is wrong. I've opened bug 11333 and attached a patch that makes the two forms on this page use the jQuery validation plugin, which should address some of Katrin's concerns. The way that this form handles editing existing profiles is decidedly not consistent with the rest of Koha, but that would be the topic of another bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23269|0 |1 is obsolete|| --- Comment #34 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23275 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23275action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #23275|0 |1 is obsolete|| --- Comment #35 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276action=edit Bug 6427 - Rewrite of the accounts system This patch re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9294] Move JavaScript out of circulation template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9294 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #24 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. It is needed for 10884. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10884] Circulation table: odd behavior on checkboxes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10884 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10935] CSV for basket and basketgroup are broken when translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10535] by default sort funds by name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #15 from Tomás Cohen Arazi tomasco...@gmail.com --- Follow-up pushed to 3.12.x, will be in 3.12.8. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10843] print a slip can cause an error
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Depends on||10298 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Blocks||10843 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 --- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 23277 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23277action=edit check-diff.sh script to check frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 23278 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23278action=edit Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: On fastadd file there are many space changes. The reason to that is to format that file to ease the translation process. Not related with this bug, but it reformat the file to match the other ones (default and simple_bib) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10850] Give Quick spine label template page its own id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.8. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11334] New: Add facet for home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Bug ID: 11334 Summary: Add facet for home library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The current Library facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11334] Add facet for home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11334] Add facet for home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11334] Add facet for home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 23279 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23279action=edit Bug 11334 - Add facet for home library The current Library facet is somewhat ambiguous for Koha installations with multiple libraries. It refers to the holdingbranch, but does not explicitly state this. It would be beneficial to allow the administrator to choose to show facets for the holding library, home library, or both. In addition, the facets should be more explicitly labeled. Test plan: 1) Apply this patch 2) Check that the facets label Libraries now reads Holding libraries 3) Update the system preference DisplayLibraryFacets to home library 4) Check that the facet now reads Home libraries 5) Update the preference again to both home and holding library 6) Check that both the facets for home and holding library are now displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11334] Add facet for home library
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11334 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5342] Serial claiming improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11322] Suggestion notes field should be sanitized or escaped
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- (In reply to Jacek Ablewicz from comment #13) Works as described for me too, thanks! On related subject, I think we may have some similiar problems with patron-submitted data in other places as well, e.g.: as a test I just submitted personal data update request from OPAC via opac/opac-memberentry.pl, with JS code in 'Address 2' field, and injected script seems to work in members/members-update.pl. But I guess it would be better to assign separate bug numbers for such further issues (if any)? Yep new bug on any others you find, i checked reviews/comments and tags, they are ok. But im prepared to believe member update isn't. At least with that you have to be logged in, so not quite as bad as the suggestions (which could be done without login if the syspref was set that way) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427
--- Comment #36 from Chris Cormack ch...@bigballofwax.co.nz ---
Comment on attachment 23276
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23276
Bug 6427 - Rewrite of the accounts system
Review of attachment 23276:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6427attachment=23276)
-
::: C4/Koha.pm
@@ +1029,4 @@
sub GetAuthorisedValues {
my ( $category, $selected, $opac ) = @_;
+warn GetAuthorisedValues( $category, $selected, $opac );
This needs a debug switch, or to be removed
@@ +1076,4 @@
push @results, $data;
}
$sth-finish;
+warn RET: . Data::Dumper::Dumper( \@results );
And this too, or the logs get loud very very fast
::: misc/release_notes/release_notes_3_10_0.txt
@@ +1762,4 @@
8996normal In result page items with negative notforloan are
available
9017normal Quote of the day: Table footer not translated
5312minor XHTML correction in authority summary
+ 8009 minor Item descriptive data not populated on
account_payment.pl
Shouldnt be in the patch, this looks like a search and replace gone wrong
::: misc/release_notes/release_notes_3_12_0.txt
@@ +579,4 @@
8429minor Unnecessary use of Exporter in SIP/ILS objects
9292minor Remove dead code related to 'publictype'
9401minor Javascript used for tags handling wants access to
CGISESSID cookie
+ 9582minor Unused code in members/account_payment.pl
Hmm not sure why this is in the patch?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #11 from Liz Rea l...@catalyst.net.nz --- Created attachment 23280 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23280action=edit Bug 10944 - Followup for Bootstrap Amazon images on https OPAC see test plan for previous patch, only bootstrap theme instead of prog. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 --- Comment #12 from Liz Rea l...@catalyst.net.nz --- Hi Cait, I wasn't able to replicate your issue - the image url changed correctly for me based on whether or not the site was running in SSL in the OPAC. You would need both patches to cover both OPAC and intranet. The intranet patch doesn't even have a non-ssl mode for fetching the images - you will always get the ssl version of the image no matter the mode. The thinking is - we should not ever be running (yes, of course we *do* but we *shouldn't*!) the intranet in non-SSL. It doesn't hurt anything to fetch the https image over the http version, so Robin simply made that choice to do it without the ability to switch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 --- Comment #25 from M. Tompsett mtomp...@hotmail.com --- Bug 11334 may also affect this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #4 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Found some changes that need to be done. Switch to In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present shows wrong (XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957 --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- (In reply to Katrin Fischer from comment #4) Hi Tomas, what i did was using an authority with $a $b $b (as $b is noted as repeatable). The generated string looked like this: Staff detail: a. b, -- c. Staff result: a. b I wonder about the different generation of the display in result and detail. I think that the punctuation should be cataloged with the record, so maybe -- would not be needed. But, I am not really sure how this should look like. Note: a separeate patch will be needed for the bootstrap OPAC. Leaving as 'signed off', but please comment. Jared told me on IRC it was customary to use -- for $c. In any case, I just left it as it was before (if i recall). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #23278|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 23281 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23281action=edit Bug 11330 - Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks This patch tries to make MARC21 bibliographic frameworks internally consistent. It modifies field/subfield descriptions of simple_bib and fastadd frameworks to match corresponding ones of default framework. To test: 1) Download and edit the attached script, check-diff.sh Put on it user, pass and database name of your dev install Copy the script on your git home 2) Run the script (bash check-diff.sh). WARNING: the script removes bibliographic frameworks, and load default, simple_bib and fastadd ones. It will show on screen, and write on file differences.txt, any difference on field/subfield description (liblibrarian) between any framework and default On master it will show a lot of lines 3) Apply the patch 4) Run the script again. Frameworks files must load without problem. There will be no differences NOTE: There are many space changes. The reason to that is to format files to ease the translation process. Not related with this bug, but necessary. Also a few changes on default framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11335] New: show thumbnails of patrons on patron search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11335 Bug ID: 11335 Summary: show thumbnails of patrons on patron search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org It would be cool if the patron search results could show thumnails of the patron images if the library wanted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Now it's ready -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11232] Retrieve facets from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #13 from David Cook dc...@prosentient.com.au --- (In reply to Jared Camins-Esakov from comment #8) (In reply to David Cook from comment #7) Also note that you will have to individually set up each index that you want to use for facet queries. As per this email from an IndexData person: http://lists.indexdata.dk/pipermail/zebralist/2007-July/001694.html In general, this shouldn't case a problem, since we only use a short list of facets. However, it would create a barrier to allowing users to customize their results. This has to be changed in two places. In the server elements configuration, as described at that link, *and* an additional index has to be configured for each facet. Jared, I'm not sure I understand what you mean by an additional index has to be configured for each facet. Could you elaborate? Once the server element is set up for a facet, it should be all good to go. -- That said, I was thinking about this a bit last night, and I can't recall exactly what is retrieved with a facet query. I have yet to set up a VM for Koha on my new desktop so I'll have to wait a bit before testing it out again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
