[Koha-bugs] [Bug 7934] Separate po file for help pages

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|frede...@tamil.fr   |bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7934] Separate po file for help pages

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7934

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton  ---
Pushed to master.  Thanks, Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10376] Printing cart does not work under IE9

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376

--- Comment #11 from David Cook  ---
The thing to do is probably to open yet another window for the print.

Would people be opposed to that idea?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #167 from M. Tompsett  ---
I've almost got something nice working. I fixed DelUploadedFile and added
DanglingEntry. Hopefully something will be finished in 24 hours. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett  changed:

   What|Removed |Added

  Attachment #21434|0   |1
is obsolete||

--- Comment #166 from M. Tompsett  ---
Comment on attachment 21434
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21434
[SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles

I rebased this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #165 from M. Tompsett  ---
Created attachment 23591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23591&action=edit
[SIGNED OFF] Bug 6874: Add unit tests for C4::UploadedFiles

and move a variable declaration at subroutine level instead of file
level.
Add dependency to Test::CGI::Multipart

Signed-off-by: Jared Camins-Esakov 

Still works, and the newly-provided unit tests have good test
coverage:
C4/UploadedFiles.pm 90.765.066.7100.0   100.00.286.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett  changed:

   What|Removed |Added

  Attachment #21433|0   |1
is obsolete||

--- Comment #164 from M. Tompsett  ---
Comment on attachment 21433
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21433
[SIGNED-OFF] Bug 6874: QA follow-up

I rebased this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #163 from M. Tompsett  ---
Created attachment 23590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23590&action=edit
[SIGNED OFF] Bug 6874: QA follow-up

Squash of the following commits:
  return with explicit undef removed
  Follow-up for PBP fixes
  follow-up fix POD syntax
  follow-up jquery has moved

Signed-off-by: Paul Poulain 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett  changed:

   What|Removed |Added

  Attachment #21432|0   |1
is obsolete||

--- Comment #162 from M. Tompsett  ---
Comment on attachment 21432
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432
[SIGNED-OFF] Bug 6874: File upload in MARC

I rebased it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #161 from M. Tompsett  ---
Created attachment 23589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23589&action=edit
[SIGNED OFF] Bug 6874: File upload in MARC

New cataloging plugin upload.pl and new system preference 'uploadPath'.

upload.pl provide a way to upload files on the server and store a link
(url) to it in MARC
uploadPath is the absolute path on the server where the files will be
stored. It's possible to have a hierarchy of directories under this path
and the plugin will allow to choose in which directory to store the
file.
Stored value in MARC subfield looks like this:
/cgi-bin/koha/opac-retrieve-file.pl?id=
So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this
plugin to work correctly

Signed-off-by: Kyle M Hall 
Signed-off-by: Paul Poulain 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett  changed:

   What|Removed |Added

  Attachment #23588|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #160 from M. Tompsett  ---
Created attachment 23588
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23588&action=edit
Bug 6874: File upload in MARC

New cataloging plugin upload.pl and new system preference 'uploadPath'.

upload.pl provide a way to upload files on the server and store a link
(url) to it in MARC
uploadPath is the absolute path on the server where the files will be
stored. It's possible to have a hierarchy of directories under this path
and the plugin will allow to choose in which directory to store the
file.
Stored value in MARC subfield looks like this:
/cgi-bin/koha/opac-retrieve-file.pl?id=
So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this
plugin to work correctly

Signed-off-by: Kyle M Hall 
Signed-off-by: Paul Poulain 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

--- Comment #45 from mathieu saby  ---
Thank you Paola!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11406] New: Keep history of a borrower's restrictions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11406

Bug ID: 11406
   Summary: Keep history of a borrower's restrictions
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

A library suggested that it might be nice to keep a history of a borrower's
restrictions. What I mean is when a restriction is lifted or expired, a record
of the restriction is kept in the interface. With the new restrictions
interface, there is a nice place to keep them, too. 

This is kind of like bug 3471.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11404] Apache 2.4 expects the sites definition files use the sufix .conf

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

--- Comment #3 from Robin Sheat  ---
I can't see Apache 2.4 in wheezy, however that's not an excuse to not get this
patch in sooner rather than later.

I don't think checking the apache version is necessary, I think, as Galen
suggests, we should transition to this by renaming all the existing apache
files (as shown by koha-list) to have a .conf suffix. This can be done in a
postinst type thing. Note that it should ask the admin if they want to do this
on the upgrade, so they a) can opt out, and b) know what's going on.

koha-create should use .conf for all new ones though

All the scripts should check for a .conf version, and if that doesn't exist, a
version without the .conf. It might be a good excuse to start building a shared
library for the scripts so you can go 'get_apache_config_for($site)' and it
does the right thing.

Anyway, opinions on this welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #4 from Kyle M Hall  ---
Created attachment 23585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23585&action=edit
Bug 11405 [4] - Allow long labels to be less word-wrapped

The labels in the last fieldset of the inventory tool are a bit
"squashed" and are word wrapped to many lines unnecessarily. This patch
adds an additional css style for fieldsets of the class "row". If an
additional class "wide" as added to the fieldset, it will give the
labels more room for display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #6 from Kyle M Hall  ---
Created attachment 23587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23587&action=edit
Bug 11405 [6] - Allow items with selected locations to be not be flagged as
"Item should have been scanned" if not scanned

This patch allows items to be skipped over if
the item has one of the locations selected in
the new field set listing shelving locations.

Test Plan:
1) Apply this patch
2) Generate a list of barcodes ordered by callnumber
3) Set one of those items to a shelving location
4) Remove that item from the list
5) Run the inventory tool with this list of barcodes
6) Note the item is listed as "should have been scanned"
7) Click back to return to the previous page
8) Select the shelving location from "If comparing barcodes list to
results, assume items with the following locations should note have been
scanned".
8) Re-run the inventory tool
9) Note the item is no longer listed as "should have been scanned"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #2 from Kyle M Hall  ---
Created attachment 23583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23583&action=edit
Bug 11405 [2] - Skip items with waiting holds

This patch enables items to be skipped for inventory stocktaking
if the item is currently a waiting hold. The intention is to skip
items that should be on the holds waiting shelf in the library.

Test Plan:
1) Apply this patch
2) Generate a list of barcodes ordered by callnumber
3) Select one of those items and place it on hold, then confirm the hold
4) Remove that barcode from the list of barcodes
5) Browse to the inventory tool, choose your barcodes file
6) Run the inventory tool with that barcode file.
7) Note the tool says that item should have been scanned
8) Click the browsers back button to return to the previous page
9) Check the checkbox for "Skip copies marked as waiting holds"
10) Run the tool again, not it does not flag that item as previously

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #5 from Kyle M Hall  ---
Created attachment 23586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23586&action=edit
Bug 11405 [5] - Fix html fieldset weirdness

For unknown and unnecessary reasons, the inventory tool display will
attempt to merge the "select items you want to check" fieldset with the
bottom fieldset if no statuses are present. This situation is highly
unlikely and complicates the template logic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #1 from Kyle M Hall  ---
Created attachment 23582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23582&action=edit
Bug 11405 [1] - Warn of items possibly scanned out of order

This patch addes the ability to choose to be warned if it's possible
an item was scanned out of order ( i.e. mis-shelved ).

Test Plan:
1) Apply this patch
2) Generate a list of barcodes ordered by callnumber
3) "Misplace" one callnumber by moving it to another area of the list
4) Browse to the inventory tool, choose your barcodes file
5) Check the checkbox for "Check barcodes list for items shelved out of order"
6) Click "submit", note the item has been flagged as possibly out of order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

--- Comment #3 from Kyle M Hall  ---
Created attachment 23584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23584&action=edit
Bug 11405 [3] - Update item status fieldset string to be more descriptive

The inventory tool has a fieldset title "Item status" but does not
explain what selecting item statuses does. This fieldset legend should
be updated to explain what these checkboxes do.

This patch changes the legend from "Item statuses" to "Limit to items
matching all the following statuses".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11405] New: Inventory tool enhancements

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Bug ID: 11405
   Summary: Inventory tool enhancements
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some libraries would like the following enhancements to the inventory tool:
1) Have the tool warn of items possibly shelved out of order for scanned lists
of barcodes ( by comparing to previous and next items ).
2) Ability to skip items with waiting holds ( in the same manners as items on
issue are skipped ).
3) The ability to choose locations to not flag as "Item should have been
scanned" if not scanned ( e.g. On Shelving Cart, On Display, etc )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11404] Apache 2.4 expects the sites definition files use the sufix .conf

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

Galen Charlton  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #2 from Galen Charlton  ---
Is it within the scope of this bug to consider renaming the Apache site config
files upon package upgrade?  It would have to happen anyway, and since Apache
2.2 is perfectly happy if the files have a .conf extension, it would be
possible for koha-create to not have to check the Apache version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #13 from Galen Charlton  ---
(In reply to Christopher Brannon from comment #12)
> I don't know if it is worth going to a modal dialog window in this one
> function.  It isn't a consistent workflow throughout Koha.  When you start
> to do things differently in different parts of the software, it really
> breaks down workflow.  I think modal dialog windows would be great for many
> alert messages throughout Koha, but it needs to be consistent throughout,
> otherwise workflow is disrupted, and you might look for these alerts one way
> and not the other.

I agree about consistency, but from the other direction: namely, Bootstrap
modals are only used in a couple places currently, but if folks generally think
that they're a good direction to go in, then circulation is a good place to get
started with adding more use of them: it's faster for a circ operator to
dismiss a modal than to wait for a round-trip to the server with the current
approach for dealing with blocking alerts during circ operations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11404] Apache 2.4 expects the sites definition files use the sufix .conf

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 23581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23581&action=edit
Bug 11404: Apache 2.4 expects the sites definition files use the sufix '.conf'

To reproduce:
- Install the 'koha-common' package on Debian 7 or Ubuntu 13.10
  (both known to include Apache 2.4).
- Create an instance (for example testlibrary) using the supplied commands:
 $ koha-create --create-db testlibrary
> FAIL: apache reports an error like this:
"ERROR: Site testlibrary does not exist!"

This patch adds a test on the Apache version and appends the needed ".conf"
sufix
if needed.

To test:

1st step: koha-create gets fixed:

-- The hard way --
- Apply the patch, and build the koha-common package on top of this commit.
- Install the built package on an Apache 2.4 Debian-based distro (Debian 7 or
Ubuntu 13.10 will work)
- Create a test instance:
 $ koha-create --create-db testlibrary
> SUCCESS: no more apache sites related error.

-- The easy way --
- Apply the patch, and copy the koha-create into an Apache 2.4 Debian-based
distro
- Create a test instance using the koha-create script you just copied:
 $ ./koha-create --create-db testlibrary
> SUCCESS: no more apache sites related error.

2nd step: the rest of the touched scripts keep working as usual

koha-disable
koha-dump
koha-enable
koha-list
koha-remove
koha-restart-zebra
koha-stop-zebra
oha-start-zebra

They should all keep working. Can be tested "the easy way" too.

Then sign on the patch.

Note: there might be another issues regarding Apache 2.4 deployments like the
need for

 $ a2enmod access_compat

and perhaps some directory permissions tweak, which I think should be properly
documented on the install instructions.

Regards
To+

Edit: some old indentation error fixed.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11404] Apache 2.4 expects the sites definition files use the sufix .conf

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

--- Comment #54 from Koha Team Lyon 3  ---
oups ! I meant "in order that any currency sign COULD BE captured"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3  changed:

   What|Removed |Added

  Attachment #22820|0   |1
is obsolete||

--- Comment #53 from Koha Team Lyon 3  ---
Created attachment 23580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23580&action=edit
Bug 9593 Prices not imported correctly from a staged file

I added a unit test file (MungeMarcFile.t) and made slight modifications in
MungeMarcPrice function in order that any currency signs could'nt be captured
(even ones with slash and dots).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11404] New: Apache 2.4 expects the sites definition files use the sufix .conf

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

Bug ID: 11404
   Summary: Apache 2.4 expects the sites definition files use the
sufix .conf
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks fields and translation

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

--- Comment #6 from Frédéric Demians  ---
Take a look at bug 11396. There is a test which would be able to compare your
es-ES files with the English version. I can help to make it testable with this
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202

Paola Rossi  changed:

   What|Removed |Added

  Attachment #23348|0   |1
is obsolete||

--- Comment #44 from Paola Rossi  ---
Created attachment 23579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23579&action=edit
Improve UNIMARC biblio indexing

I test the patch against master 3.15.00.004.
Simple sort is ok when default sort is not set to relevance-asc (see bug
11255).
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #12 from Christopher Brannon  ---
There are a couple approaches you could go from here.

Currently we have a jquery setup that simply takes the focus off the input box.
 It doesn't disable anything.  This has been a successful adjustment for us. 
You might think that this is a loose fix, as you can click on the text box and
continue on, but it is really no different than clicking the ignore button.

The other approach is to fix the patch to re-enable the input box and button
for transfers.

I don't know if it is worth going to a modal dialog window in this one
function.  It isn't a consistent workflow throughout Koha.  When you start to
do things differently in different parts of the software, it really breaks down
workflow.  I think modal dialog windows would be great for many alert messages
throughout Koha, but it needs to be consistent throughout, otherwise workflow
is disrupted, and you might look for these alerts one way and not the other.

Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #159 from M. Tompsett  ---
(In reply to Paul Poulain from comment #158)
> (In reply to M. Tompsett from comment #156)
> > I have some other related questions:
> > - should validate URLs, since not all 856$u urls will be uploaded file urls.
> Not sure I understand well the question, but isn't
> misc/cronjobs/check-url-quick.pl what you're asking ?

No.

if ( is this one of our uploaded files ) { continue processing as expected }
else { give big warning, and then go immediately to the upload, not the delete
page }


> > - is telling a user to check errors logs reasonable? They may not have shell
> > access to the system.
> No, it isn't

Then we need to fix that. However, I think that is in part of the signed off
patches.


> > - If a valid external url is detected, then a different response is needed
> > than if we discover a url to a deleted file.
> I think check-url-quick.pl achieve the goal, and it's better because it
> detects when an URL becomes invalid at any time.

This isn't about an invalid URL. Frankly, I don't care about the validity as
much as I care about the process flow. If I have a url in the 856$u field and
click the plugin icon, I do not expect to attempt to delete an external url
(not our hosted files that were uploaded).


> > - How will the user know to delete the text field before clicking the plugin
> > icon in order to continue onto the upload screen to put a different file in
> > place?
> I don't understand this one.

Test this.
Upload a file.
Clone the field.
Now there are two fields pointing to the same uploaded file.
Click the plug in icon, and delete the file, but then cancel.
Now there are two fields: one blanked (because you just deleted), and the other
with a dangling reference.

Now, click the plugin icon for the non-empty 856$u field.
It's going to prompt to delete. The user will click "Delete", because there is
no way to go to upload otherwise, and an error will be generated (because the
file was already deleted). And there is no meaningful feedback suggesting to
clear the field before clicking the plugin icon, so the user will be frustrated
because they can't seem to upload a file anymore, because they overlook the
obvious idea of clearing the field.


> Are my answer OK and is it back to go to signed-off ?
> (I have not tested the patches still applies cleanly)

If I have clarified what I mean, and you do test and see the process flow, then
you'll understand that with a couple more validations the process can be made
smoother.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 QA Contact||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11403] renew page missing help file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403

Nicole C. Engard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11403] renew page missing help file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403

--- Comment #1 from Nicole C. Engard  ---
Created attachment 23578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23578&action=edit
Bug 11403: Add missing help file to new Renew page

This patch adds a help file to the Renew page found under
Circulation.

To test:

* Go to Circulation > Renew
* Click the help link
* Confirm text and manual link are correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11403] New: renew page missing help file

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403

Bug ID: 11403
   Summary: renew page missing help file
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: minor
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

File to come

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 23577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23577&action=edit
Bug 11402: Labels::_guide_box should return undef if undefned data is passed

That's it. A guide box cannot be created if invalid data is passed.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11402] New: Labels::_guide_box should return undef if undefned data is passed

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402

Bug ID: 11402
   Summary: Labels::_guide_box should return undef if undefned
data is passed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11401] New: Add support for Norwegian national library card

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401

Bug ID: 11401
   Summary: Add support for Norwegian national library card
 Change sponsored?: Sponsored
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: mag...@enger.priv.no
  Reporter: mag...@enger.priv.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In Norway, we have a national database of library patrons, called "Nasjonalt
lånekort" (NL). The fact that communnication with this database is missing from
Koha is one of the two main stumbling blocks that keep Norwegian libraries from
adopting Koha (the other one is the lack of support for the Norwegian ILL
protocol). 

This bug will add support for NL to Koha. 

Communication with NL happens through SOAP. 

Documentation on NL is available here: http://www.lanekortet.no/ but it is in
Norwegian only, alas.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 23576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23576&action=edit
Bug 11400: Show "Login as a different user" instead of "Logout" if not enough
premissions

Bug 11146 introduced a way to go back, and have a logout link for the
"Not enough permissions" message page. I belive this string change is worth.

Simple and disputable string change.
Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||11146

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11146] Show a go back link on no permission page

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||11400

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11400] New: Show "Login as a different user" instead of "Logout" if not enough premissions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400

Bug ID: 11400
   Summary: Show "Login as a different user" instead of "Logout"
if not enough premissions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Bug 11146 introduced a way to go back, and have a logout link for the "Not
enough permissions" message page. I belive this string change is worth.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11146] Show a go back link on no permission page

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383

--- Comment #8 from Nicole C. Engard  ---
I will watch the other bug and update the manual and the help accordingly once
it's pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #19 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11245] typo in modborrowers.tt javascript string

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11245

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10809] use template branches plugin in serials search

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #11 from Tomás Cohen Arazi  ---
This patch has been pushed to 3.12.x, will be in 3.12.8.

Thanks Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |stephane.delaune@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #1 from stephane.dela...@biblibre.com ---
Created attachment 23575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23575&action=edit
proposed patch

./batchRebuildItemsTables.pl -h (or without arguments => shows this screen)
./batchRebuildBiblioTables.pl -c (c like confirm => rebuild non marc DB (may be
long)
-t => test only, change nothing in DB
-where => optionnal where condition on default query (eg. -where
'biblio.biblionumber < 100')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11399] New: batch Rebuild Items Tables

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Bug ID: 11399
   Summary: batch Rebuild Items Tables
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: stephane.dela...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

This script rebuilds the non-MARC DB items table from the MARC values (eg. in
995 for unimarc, 952 in marc21). You can/must use it when you change your
mapping.

This script is similar to batchRebuildBiblioTables(which works on biblio an
biblioitems table), but works on items only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #40 from Martin Renvoize  ---
Above comment was by me.. I seem to have been logged in as the wrong user after
doing some work on our sandboxes.. Oops.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 CC||sandbo...@ptfs-europe.com

--- Comment #39 from PTFS Europe Sandboxes  ---
Setting Singed Off:

* Reviewed code and it looks good, also ran QA scripts and it passed all tests.
* Ran through full install procedure for dev install - files files placed as
epxected.
* Ran through full install procedure for standard install - again files were
placed as expected.

Tested locking with deamon mode + manual rebuild - Worked as expected.
Tested locking with two manual rebuilds - Wored as expected.
Tested locking with croned rebuild + manual rebuild - Worked as expected.

I've not build a package using these files as yet, but the code looks as though
it should work as expected too.

Signing off.. good luck Mr/Mrs QA ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #23221|0   |1
is obsolete||

--- Comment #38 from Martin Renvoize  ---
Created attachment 23574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23574&action=edit
Bug 11078 Add locking to rebuild_zebra.pl (path fix)

Add missing reference to subdirectory for rebuild_zebra locks
under zebra lock diretory.  This is already handled correctly
in the docs, template and makefiles.  The code in fact works
either way, but docs and reality should match.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #23220|0   |1
is obsolete||

--- Comment #37 from Martin Renvoize  ---
Created attachment 23573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23573&action=edit
Bug 11078 Add locking to rebuild_zebra.pl

This patch adds locking to rebuild_zebra.pl to ensure that simultaneous
changes are prevented (as one is likely to overwrite the other).
Incremental updates in daemon mode will skipped if the lock is busy
and they will be picked up on the next pass.  Non-daemon mode
invocations will wait for the lock to clear and then proceed.
Supporting changes made to Makefile.PL and templates for the new
locking directory (paralleling the other zebra lock directories).
We stash the zebra_lockdir in koha-conf.xml so rebuild_zebra.pl
can find it.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11398

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11398] A typo occurred with occured

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398

M. de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11170

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

M. de Rooy  changed:

   What|Removed |Added

  Attachment #22597|0   |1
is obsolete||

--- Comment #2 from M. de Rooy  ---
Created attachment 23571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23571&action=edit
Bug 11170: The pending order list should only display orders to receive

The order status ordered is set when the basket is closed.
The parcel page should only display status "ordered" and "partial".

Test plan:
- create a basket.
- create an order.
- verify the order is not listed on the parcel page (i.e. you cannot
  receive it).
- close the basket.
- verify the order is listed on the parcel page.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

M. de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

--- Comment #3 from M. de Rooy  ---
Created attachment 23572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23572&action=edit
Bug 11170: Follow-up for typo occured in parcels.tt

Found this typo while testing bug 11170.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11398] A typo occurred with occured

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398

--- Comment #1 from M. de Rooy  ---
Created attachment 23570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23570&action=edit
Bug 11398: A typo occurred with occured

This patch cures occured and makes occurred occur.
Note that I found them while testing bug 11170.
In a follow-up of 11170, I corrected this typo in parcels.tt.
This patch touches update22to30.pl and modborrowers.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11398] A typo occurred with occured

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398

M. de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11398] New: A typo occurred with occured

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11398

Bug ID: 11398
   Summary: A typo occurred with occured
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: m.de.r...@rijksmuseum.nl
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

This patch cures occured and makes occurred occur.
Note that I found them while testing bug 11170.
In a follow-up of 11170, I corrected this typo in parcels.tt.
This patch touches update22to30.pl and modborrowers.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397

--- Comment #1 from Jonathan Druart  ---
Created attachment 23569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23569&action=edit
Bug 11397: Remove the itemnumber list on the Acquisition detail tab

Test plan:
- verify this patch does not introduce regression on the enhancement
  introduced by bug 8230.
- verify the itemnumber list does not appears anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||11397

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11397] New: Displaying itemnumber list on the Acquisition detail tab is useless

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397

Bug ID: 11397
   Summary: Displaying itemnumber list on the Acquisition detail
tab is useless
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Since we have the pref AcqItemSetSubfieldsWhenReceived and filters on the
holdings tab, the list of ordered items per order is unimportant and gadget.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11397] Displaying itemnumber list on the Acquisition detail tab is useless

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11397

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||8230
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8230] Show the ordered status in catalogue page

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #32 from Jonathan Druart  ---
(In reply to Galen Charlton from comment #30)

> Is it actually necessary to be able to link to the items associated with a
> basket from the bib details page?

Galen,
I just talk about this with Stéphane and the conclusion is you are right, this
information is useless :) Since we have the pref
AcqItemSetSubfieldsWhenReceived and filters on the holdings tab, the list of
ordered items per order is unimportant and gadget.
I will open a new bug for that.
Thank you very much for your follow-ups!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10626] Remove doubled up TT plugins

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #31 from Jonathan Druart  ---
I added a commit in the QA tests for that:

commit 32dcd4db9639bb976763ad92759850bf96c2a59d
Author: Jonathan Druart 
Date:   Mon Dec 16 11:02:46 2013 +0100

TT plugins have been merged (see bug 10626)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #158 from Paul Poulain  ---
(In reply to M. Tompsett from comment #156)
> I have some other related questions:
> - should validate URLs, since not all 856$u urls will be uploaded file urls.
Not sure I understand well the question, but isn't
misc/cronjobs/check-url-quick.pl what you're asking ?

> - external urls will generate the same apparent error deleting as the
> cloning scenario I mentioned in comment #154.
see my previous answer.

> - is telling a user to check errors logs reasonable? They may not have shell
> access to the system.
No, it isn't

> - If a valid external url is detected, then a different response is needed
> than if we discover a url to a deleted file.
I think check-url-quick.pl achieve the goal, and it's better because it detects
when an URL becomes invalid at any time.

> - How will the user know to delete the text field before clicking the plugin
> icon in order to continue onto the upload screen to put a different file in
> place?
I don't understand this one.

> The signed off patches need a rebase. Feedback on these questions would be
> useful. I'm leaving the status at In Discussion, because even if my patch
> was signed off, the problem with respect to external urls and deleted files,
> due to a clone, would still exist. And that seems like enough to merit not
> just running for QA's approval.
Are my answer OK and is it back to go to signed-off ?
(I have not tested the patches still applies cleanly)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6874] File upload in MARC

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #157 from Paul Poulain  ---
(In reply to M. Tompsett from comment #154)
> Shoot... My librarian colleague came up with a scenario that breaks this.
> 
> 1) Upload and set everything for a 856$u.
> 2) Clone the subfield.
> 3) Click the plugin icon.
> This is where the problem comes in, because now the two subfields you can
> end up deleting the file for the current 856$u, but the other 856$u still
> has a reference to the deleted file in it.
I think it's not a big deal: the user just get an invalid URL. That's exactly
the same thing as when the librarian fills an invalid URL.
Also note that the script misc/cronjobs/check-url-quick.pl will detect the
problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #23557|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  ---
Created attachment 23568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23568&action=edit
Bug 11383: Add help file for Marc modification templates

This patch adds the missing help files to the Marc modification
templates tool. To test:

* Visit Tools > Marc modification templates
* Click 'Help' in the top right
* Confirm that help is there and right

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383

--- Comment #6 from Jonathan Druart  ---
Nicole,
Thank you very much to write this help page!
Note that currently the Marc modification templates is only used while staging
MARC records for import but bug 11395 will (if pushed) allow librarians to
apply templates to existing records (biblios and authorities already in the
catalog).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #23532|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  ---
Created attachment 23567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23567&action=edit
Bug 11336: (follow-up) Priority is not updated on deleting holds - moremember

Patch does not fix issue when canceling hold from moremember.pl.
This followup fixes that issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

--- Comment #13 from Jonathan Druart  ---
Kyle,
I disagree with your patch. The call stack could be weird:
If ModReserve is called for deleting an hold, _FixPriority will be called with
$rank=del which will call CancelReserve which will call again _FixPriority.
Since the code in ModReserve (when call with rank=del) cancels a reserve, maybe
the best is to call CancelReserve :)
I am submitting a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

M. de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

M. de Rooy  changed:

   What|Removed |Added

  Attachment #22573|0   |1
is obsolete||

--- Comment #2 from M. de Rooy  ---
Created attachment 23566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23566&action=edit
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals

In budgets administration, admin/aqbudgets.pl, there is a combobox for
filtering by branch code.
The bug is that the filter uses a pattern match  instead of equals :
  next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/;
In this case, if there is a branch with code '1' and one with code '12',
filtering by branch '1' will also show budgets of branch '12'.

Test plan :
- Create a branch with code '1' and one with code '12'
- Create budgets in both branches
- Go to admin/aqbudgets.pl
- Filter by branch '12'
=> You see only budgets of this branch
- Filter by branch '1'
=> You see only budgets of this branch

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10861] Add a check on cardnumber length

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861

--- Comment #21 from M. de Rooy  ---
Created attachment 23564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23564&action=edit
Bug 10861: Follow-up for typo in patrons.pref

I'd rather have a comma than a coma :)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10861] Add a check on cardnumber length

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861

--- Comment #22 from M. de Rooy  ---
Created attachment 23565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23565&action=edit
Bug 10861: Followup Add a check on cardnumber length

This patch refactors the previous code and moves the logic from the pl
to a new routine.

Same test plan as previous patch.

/!\ new unit test filename.

Signed-off-by: Marcel de Rooy 

Bug 10861: Reintroduced the cardnumber length check (client side)

Previous patches has removed the pattern attribute of the input, it was
not needed. This patch reintroduces it. It will only work for new
browser version.

Moreover, it manages with the ',XX' format (see UT).

Signed-off-by: Marcel de Rooy 
Squashed the last two follow-ups. The pattern test did not work fully for me
in Firefox 26 (very recent). But I see the message when I clear the field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10861] Add a check on cardnumber length

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861

M. de Rooy  changed:

   What|Removed |Added

  Attachment #23387|0   |1
is obsolete||
  Attachment #23388|0   |1
is obsolete||
  Attachment #23476|0   |1
is obsolete||
  Attachment #23477|0   |1
is obsolete||

--- Comment #20 from M. de Rooy  ---
Created attachment 23563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23563&action=edit
Bug 10861: Add a check on cardnumber length

Some libraries would like to add a check on the cardnumber length.
This patch adds the ability to restrict the cardnumber to a specific
length (strictly equal to XX, or length > XX or min < length < max).
This restriction is checked on inserting/updating a patron or on importing
patrons.

This patch adds:
- 1 new syspref CardnumberLength. 2 formats: a number or a range
  (xx,yy).

- 1 new unit test file t/Members/checkcardnumber.t for the
C4::Members::checkcardnumber routine.

Test plan:
1/ Fill the pref CardnumberLength with '5,8'
2/ Create a new patron with an invalid cardnumber (123456789)
3/ Check that you cannot save
4/ With Firebug, replace the pattern attribute value (for the cardnumber
input) with ".{5,10}"
5/ You are allowed to save but an error occurred.
6/ Try the same steps for update.
7/ Go to the import borrowers tool.
8/ Play with the import borrowers tool. We must test add/update patrons
and the "record matching" field (cardnumber or a uniq patron attribute)

Signed-off-by: Marcel de Rooy 
Tested adding, updating; importing and ran unit test.
Preliminary QA comments on Bugzilla

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10861] Add a check on cardnumber length

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861

M. de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #42 from Jonathan Druart  ---
Kyle,

Patches apply cleanly (only a conflict in updatedb.pl).
You got a conflict because of the previous patches was not obsoleted.
I provided a QA followup for QA issues.

Switch back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #21637|0   |1
is obsolete||
  Attachment #21638|0   |1
is obsolete||
  Attachment #21639|0   |1
is obsolete||
  Attachment #23272|0   |1
is obsolete||
  Attachment #23273|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart  ---
Created attachment 23562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23562&action=edit
Bug 9016: QA Followup

Fix tab characters and POD.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10637] Unexpected item creation in Acquisitions

2013-12-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10637

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >