[Koha-bugs] [Bug 11411] New: Bootstrap theme (enhancement) for (right to left).

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

Bug ID: 11411
   Summary: Bootstrap theme (enhancement) for (right to left).
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: karamqu...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Created attachment 23615
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23615action=edit
Before the patch

Hi,
As you can see in the first attached image the welcome statement and the logout
link is located  to the right of the screen, but in the right to left languages
it must be to the left.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left).

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

--- Comment #1 from Karam Qubsi karamqu...@gmail.com ---
Created attachment 23616
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23616action=edit
Bug-11411-ENH-Bootstrap-theme-enhancement-for right to left

 This patch will make a small change on the
 bootstrap-rtl.min.css file to make the welcome statement
 and the logout link located to the left of the screen. 
 Test plan : 
 1-apply the patch 
 2-translate install ar-Arab .
 and that's it  .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left).

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

Karam Qubsi karamqu...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11411] Bootstrap theme (enhancement) for (right to left).

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11411

--- Comment #2 from Karam Qubsi karamqu...@gmail.com ---
Created attachment 23617
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23617action=edit
After the patch

The results must be as the attached image .

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9948] acq data going on first item even if not received

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Depends on||9224

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||9948

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

--- Comment #8 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23619
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23619action=edit
Bug 10952: comments fixes and unit tests

- Remove unit tests for ParseSearchHistoryCookie, which doesn't exist
  anymore
- Add unit tests for ParseSearchHistorySession and
  SetSearchHistorySession
- Remove/Modify comments about search history cookie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

--- Comment #7 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23618
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23618action=edit
Bug 10952: Store anonymous search history in session

Storing search history into cookie can cause problems, due to the size
limitation of 4KB.
The solution here is to store search history into the CGI::Session
object, so there is no size limitation (but anonymous search history
still remember up to 15 requests max.)

Test plan:
- Go to OPAC in anonymous mode.
- Check that the Search history link is *not* shown in the top right
  corner of the page
- Make some searches on /cgi-bin/koha/opac-search.pl
- The Search history link must appear. Click.
- Your search history must be displayed.
- Try to log in with invalid username/password
- Go back to search history, it's still there
- Now log in with valid username/password
- Your anonymous search history must be saved into your own search
  history.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #23618|Bug 10952: Store anonymous  |[PASSED QA] Bug 10952:
description|search history in session   |Store anonymous search
   ||history in session

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22133|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10952] Store anonymous search history in session

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Julian Maurice julian.maur...@biblibre.com ---
1st patch rebased on master.
2nd patch needs signoff (or maybe only QA since it modifies only comments and
unit tests)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11412] New: Bulkmarcimport can crash when searching for duplicates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412

Bug ID: 11412
   Summary: Bulkmarcimport can crash when searching for duplicates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

bulkmarcimport.pl can crash when searching for duplicates if the 005 field from
the incoming or local record is not defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412

--- Comment #1 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 23620
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23620action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] New: Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Bug ID: 11413
   Summary: Marc modification template has not the expected
behavior if the condition and source fields are on the
same field
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

If you want to do an action (delete/update/move/...) on a multivalued field and
if a condition is defined on the same field, it is highly probable the resulted
record will not be what you expected.

For example:
Deleting All (or the first) fields 650 if 245$a=Bad title works with the
current code.

BUT if you want to delete All (or the first) fields 650 with a condition on
650$9=42, and if at least one field matches the condition :
- if you have selected all, all fields 650 will be deleted, even the ones who
do not match the condition.
- if you have selected first, the first 650 field will be deleted, even if it
does not match the condition.
The expected behavior is to delete the fields matching the condition (and not
all the 650 fields).

Maybe this bug is a major one, lose or corrupt data is probable!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #23620|0   |1
is obsolete||

--- Comment #2 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 23621
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23621action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8015] Add MARC Modifications Templates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||11413

--- Comment #192 from Jonathan Druart jonathan.dru...@biblibre.com ---
/!\ This feature is buggy if the condition and source fields are defined on the
same field.

See bug 11413.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||8015

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23623
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23623action=edit
Bug 11413: UT to show up the issue

These UT reflect this change:
- deletion of the field 245 if 245$a='Bad title'
- move of the 650 field to 651 if 650$9=499

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23622
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23622action=edit
Bug 11413: Change the field number logic

This patch series is a bugfix for the Marc modification templates tool.

Bug description:
If you want to do an action (delete/update/move/...) on a multivalued
field and if a condition is defined on the same field, it is highly
probable the resulted record will not be what you expect.

For example:
Deleting All (or the first) fields 650 if 245$a=Bad title works with
the current code.
BUT if you want to delete All (or the first) fields 650 with a condition
on 650$9=42, and if at least one field matches the condition :
- if you have selected all, all fields 650 will be deleted, even the
  ones who do not match the condition.
- if you have selected first, the first 650 field will be deleted, even
  if it does not match the condition.
The expected behavior is to delete the fields matching the
condition (and not all the 650 fields).

What this patch does:
This patch introduces 2 changes in the logic of Koha::SimpleMARC.
The first change is a change of the prototypes for the 2 routines
field_exists and field_equals. Now they return the field number of the
matching fields.
The second change is the type of the n parameter for all routines
using it in Koha::SimpleMARC. Before this patch, the n parameter was a
boolean in most cases. If 0, the action was done on all fields, if 1
on the first one only. Now it is possible to specify the field numbers
(so the array of field numbers which is returned by field_exists or
field_equals) for all routines which had the n parameter.

Test plan for the patch series:
Note: This test plan describes a specific example, feel free to create
your own one.
0/ Define a marc modification template with the following action:
  Delete field 245 if 245$9 = 42
1/ choose and export a record with several 245 fields.
For ex:
  245
$a The art of computer programming
$c Donald E. Knuth.
$9 41
  245
$a Bad title
$c Bad author
$9 42
2/ import it using the Stage MARC for import tool.
3/ verify the imported record does not contain any 245 field.
4/ apply all the patches from this bug report
5/ do again steps 2 and 3
6/ verify the imported record contains only one 245 field, the one with
245$9=41
7/ verify the unit tests passed:
  prove t/SimpleMARC.t
  prove t/db_dependent/MarcModificationTemplates.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23624
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23624action=edit
Bug 11413: Reflect the changes to the interface

Test plan:
- add/edit an action on the marc modification templates tools
- choose an action and define a condition
- define the source field as same as the condition field
- verify the All/1st dropdown list is changed to Every/1st

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22753|0   |1
is obsolete||

--- Comment #6 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23625
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23625action=edit
Bug 8995: Show OpenURL links in OPAC search results

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 Depends on||11319

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Since I already submitted a big refactoring for this tool (bug 11319), I
developed this fix on top of it. So I mark them as dependent. But the bug will
exist in the 3.14 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #7 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23626
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23626action=edit
Bug 8995: Use uri_escape_utf8 instead of uri_escape

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #8 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 23627
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23627action=edit
Bug 8995: Show OpenURL links in bootstrap theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11319] Marc modification templates improvements

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||11413

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Julian Maurice julian.maur...@biblibre.com ---
1st patch rebased on master
2nd patch fix the Can't escape \x{0152} error
3rd patch update bootstrap theme to display OpenURL links

All patches needs a signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11414] New: Marc modification template limitations should alert the user

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414

Bug ID: 11414
   Summary: Marc modification template limitations should alert
the user
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bug 11413 fixes a bug for the Marc modification template tool but will not be
available for 3.14.x branches (maybe never).
The limitation could cause lost of data.

The user should be alerted on the interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23628
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23628action=edit
Bug 11414: Marc modification template limitations should alert the user

Test plan:
On the Marc modification tool:
add/edit a new action on a field and define a condition on the same
field.
Verify that you get a warning message in red.

see bug 11413 for more information

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11414

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11413

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Hi Katrin,

What is the standard formatting exactly? Text in red, followed by Required
?
What do you mean by [they] are not highlighting when you miss to enter data ?
Is there a form in Koha that do that already ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11386] Mandatory fields in subscription add form should use standard formatting

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11386

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Julian,

take a look at the administration  branches form. There is a newer Javascript
library that can be used to achieve these things in Koha.
The bug is here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6209

CCing Owen as the expert :)

There is another thing about the form that troubles me - the date fields are
now readonly. This is an accessibility problem as not everyone is able to use
the date plugin. Could you reconsider those? I think we have other examples
that allow direct entry of dates. (I can file a separate bug later).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23567|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23629
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23629action=edit
Bug 11336: (follow-up) Priority is not updated on deleting holds - moremember

Patch does not fix issue when canceling hold from moremember.pl.
This followup fixes that issue.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11415] New: SCO has no option to disable automatic receipt printing

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415

Bug ID: 11415
   Summary: SCO has no option to disable automatic receipt
printing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

There are libraries use Koha's self checkout system without having receipt
printers connected to them. The prompt for print a receipt from sco should be
optional and controlled by a system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #17)
 General question about this proposed feature: what's wrong with using the
 cart for this?

The idea is to navigate between selected results, I don't see how to do that
with the cart.
When I open the basket, I can see a biblio list but the detail page is opened
in a new window.
Even if I improve the behavior, on a ux point of view I think it is not
friendly to have to put biblios in the cart for browsing them.
Moreover the same enhancement is developed for authorities (bug 11311), which
can not be put in the cart.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] New: Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

Bug ID: 11416
   Summary: Serials editor improperly hides fields
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

In serials/serials-edit.pl, if a field is hidden from the OPAC, it will not
display in the editor, even if the field is marked as visible in the staff
intranet and editor. However, the field is still displayed correctly in the
items editor ( additem.pl ).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23630
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23630action=edit
Bug 11416 - Serials editor improperly hides fields

In serials/serials-edit.pl, if a field is hidden from the OPAC, it will
not display in the editor, even if the field is marked as visible in the
staff intranet and editor. However, the field is still displayed
correctly in the items editor ( additem.pl ).:

Test Plan:
1) Select an item-level field ( e.g. non-public note )
2) Create a serial using the default framework ( or one of your choice )
3) For that framework, mark the chosen field as visible from the
intranet and editor, but not the opac.
4) Recieve an item for this serial, note your field does not display
5) Use the biblio item editor to add an item ( additem.pl ), not the
field displayes
6) Apply this patch
7) Repeat step 4, not the field displayes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11415] SCO has no option to disable automatic receipt printing

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11415

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11417] New: remove_unused_authorities.pl doesn't accept --test

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Bug ID: 11417
   Summary: remove_unused_authorities.pl doesn't accept --test
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: gaetan.bois...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

remove_unused_authorities.pl says in the help that it will accept both --test
and --t as arguments in order to only test and count eligible authorities
without removing them :

This script will parse all authoritiestypes given as parameter, and remove
authorities without any biblio attached.
warning : there is no individual confirmation !
parameters
--aut|authtypecode TYPE   the list of authtypes to check
--t|test  test mode, don't delete really, just count
--help or -h  show this message.


 but in practice it only accepts --t :

GetOptions(
'aut|authtypecode:s'= \@authtypes,
't'= \$test,
'h|help'= \$want_help
);

A user launching the script with --test will see a warning that there was an
unrecognised option, and the authorities will be deleted

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #86 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23631
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23631action=edit
Bug 7825: Changed OPACItemHolds syspref to be no|yes|force choice - bootstrap

Same test plan as previous patch but with the bootstrap theme set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11417] remove_unused_authorities.pl doesn't accept --test

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being no, yes, force

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #87 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #84)
 One other comment: when forcing item holds, it would probably be best to
 display the list of items be default so the patron knows which specific copy
 has been selected for the hold.

I would prefer not to modify the tt file since it is signed off.
I don't think it could be considered as blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11416] Serials editor improperly hides fields

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11417] remove_unused_authorities.pl doesn't accept --test

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |gaetan.bois...@biblibre.com

--- Comment #1 from Gaetan Boisson gaetan.bois...@biblibre.com ---
Created attachment 23632
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23632action=edit
Bug 11417 - remove_unused_authorities.pl doesn't accept --test

See commit message for the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11417] remove_unused_authorities.pl doesn't accept --test

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11417] remove_unused_authorities.pl doesn't accept --test

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11417

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23633
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23633action=edit
Bug 10858: FIX error if no biblio is selected

If the user launch a search a directly go to the opac detail page, an
error occurs:

  malformed JSON string, neither array, object, number, string or atom, at
  character offset 0 (before (end of string)) at
  /usr/share/perl5/JSON.pm line 171.

Test plan:
- remove the bibs_selected cookie
- launch a search
- click on a result
- the page should be displayed correctly
(cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252)

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4418] Enable required option for patron attributes

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4418

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
So, the hack that we had to make attributes required doesn't work if you are
making attributes branch specific ... so I thought I'd bump this to see if
anyone has any other ideas on how to tackle this enhancement.

Nicole

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #16)
 Maybe it is just a rebase...

Yep, I had to rebase this patch due to additions to bug 10277, which this one
depends on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

--- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 23634
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23634action=edit
Bug 10277: Add UT for C4::Context::IsSuperLibrarian

Note that I modify the return value. Before this patch, it returned an
empty string or 1. Now it returns 0 or 1.

Test plan:
- same as the original patch
- verify that unit tests pass:
prove t/Context.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #26)
 I have been unable to find a good way to UT this sub. MockModule doesn't
 seem to work in this context, since we are trying to mock a subroutine
 outside the module and then use the mocked sub inside the module.

It seems to work using MockModule. Have a look at my patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10502] Add independent branches option for sql reports

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23634|0   |1
is obsolete||

--- Comment #31 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23635
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23635action=edit
Bug 10277: Add UT for C4::Context::IsSuperLibrarian

Note that I modify the return value. Before this patch, it returned an
empty string or 1. Now it returns 0 or 1.

Test plan:
- same as the original patch
- verify that unit tests pass:
prove t/Context.t

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10277] Add C4::Context-IsSuperLibrarian()

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

--- Comment #32 from Kyle M Hall k...@bywatersolutions.com ---
Great work! Thanks! I had attempted a UT using MockModule, but I must have been
setting it up incorrectly.


(In reply to Jonathan Druart from comment #30)
 (In reply to Kyle M Hall from comment #26)
  I have been unable to find a good way to UT this sub. MockModule doesn't
  seem to work in this context, since we are trying to mock a subroutine
  outside the module and then use the mocked sub inside the module.
 
 It seems to work using MockModule. Have a look at my patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23491|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23636
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23636action=edit
Bug 10263 - Add ability to limit which branch can edit a bibliographic record (
IndependentBranchesMarcEditing )

Right now, it's possible to limit who can edit items by using
IndependantBranches. However, Koha has no method of limiting who can
edit bibliographic records, as they have no defined owner.

This patch adds a new system preference IndependentBranchesMarcEditing. If this
new
syspref is enabled, a librarian can only edit or delete a bib record if
his or her logged in branch code matches the branchcode in
biblio.branchcode. This feature does not affect the ability to edit or
delete items, as that functionality is determined by
IndependantBranches.

This patch adds the 'branches_optional' field to the authorised values
pulldown for MARC fields and subfields in the MARC frameworks editor.
'branches_optional' behaves exactly like 'branches' except it includes
an empty choice so the branch does not have to be set.

Test Plan:
 1) Apply patch
 2) Run updatedatabase.pl
 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o )
Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of
libraries instead of entering the branchcode manually.
 4) Edit a record, and add a branchcode.
 5) Log in as a non-superlibrarian with cataloging priveleges
 6) Change the logged in branch to a branch other than the one you
entered in the record.
 7) You should note the 'edit' pulldown for the record is missing the
Edit record and Delete record options.
 8) Switch the logged in branch to match the branchcode of the record.
 9) You should now see the edit and delete options for that record.
10) Attempt to edit a record with no branchcode defined, you should be
able to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11412] Bulkmarcimport can crash when searching for duplicates

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11412

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #18 from Joel Sasse jsa...@plumcreeklibrary.net ---
I tested this and want to sign off on this patch.

Joel Sasse

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #9 from Joel Sasse jsa...@plumcreeklibrary.net ---
I tested this and want to sign off on it.

Joel Sasse

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Melissa Lefebvre meli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23489|0   |1
is obsolete||

--- Comment #19 from Melissa Lefebvre meli...@bywatersolutions.com ---
Created attachment 23637
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23637action=edit
Extend IndependetBranches to support groups of libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278

Melissa Lefebvre meli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23490|0   |1
is obsolete||
 CC||meli...@bywatersolutions.co
   ||m

--- Comment #10 from Melissa Lefebvre meli...@bywatersolutions.com ---
Created attachment 23638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23638action=edit
Bug 10278 - Add ability to hide items and records from search results for
Independent Branches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263

Melissa Lefebvre meli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23636|0   |1
is obsolete||
 CC||meli...@bywatersolutions.co
   ||m

--- Comment #13 from Melissa Lefebvre meli...@bywatersolutions.com ---
Created attachment 23639
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23639action=edit
Bug 10263 - Add ability to limit which branch can edit a bibliographic record
(IndependentBranchesMarcEditing)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #12 from Joel Sasse jsa...@plumcreeklibrary.net ---
I tested this and want to sign off on it.

Joel Sasse

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10502] Add independent branches option for sql reports

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #15 from Joel Sasse jsa...@plumcreeklibrary.net ---
I tested this and want to sign off on it.

Joel Sasse

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10502] Add independent branches option for sql reports

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10502

Melissa Lefebvre meli...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23492|0   |1
is obsolete||

--- Comment #16 from Melissa Lefebvre meli...@bywatersolutions.com ---
Created attachment 23640
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23640action=edit
Bug 10502 - Add independent branches option for sql reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23637|0   |1
is obsolete||

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23641
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23641action=edit
Bug 10276 - Extend IndependentBranches to support groups of libraries

This patch adds the ability to have independent library groups. To
enable this feature, enable the IndependentBranches system preference.
If no libraries are in any independent library groups,
IndependentBranches will behave as it always have. If a library is
part of an independent library group with one or more libraries, that
library will be able to access and modify patrons and items from any
library in that group.

Let's say we have 3 groups:
Group1:
  LibA
  LibB
  LibC
Group1:
  LibD
  LibE
  LibF
Group3:
  LibG
  LibH
  LibA

Note how LibA is in two groups ( Group1 and Group2 ). With this
configuration, if IndependentBranches is enabled, libraries will be able
to access and edit patrons and items in the following configuration:
LibA = LibB, LibC, LibG, LibH
LibB = LibA, LibC
LibC = LibA, LibB
LibD = LibE, LibF
LibF = LibD, LibE
LibG = LibH, LibA
LibH = LibG, LibA

Furthermore, let us assume there is a library LibI, which does not
belong to any group. That library will only be able to view and edit
patrons and items from it's own library.

Imagine a library consortium consisting of multiple library systems.
This feature would allow a consortium to group libraries by system such
that those systems could work independently from one another on a single
installation.

Test Plan:
1) Apply patches for bugs 10080 and 10206
2) Apply this patch
3) Run updatedatabase.pl
4) Enable IndependentBranches
5) Test independent branches, no changes should be noted
6) Navigate to admin/branches.pl
7) Create a new Independent library group
8) Add your library and some other libraries to that group
9) Re-test IndependentBranches, everything should work as previously,
   but instead of being limited to just your library, you should have
   access to everything within your library group.
   Example: Try to edit an item. If the item is owned by a library in
your group, you should be able to edit it.

Signed-off-by:  Joel Sasse jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f
   |ity.org |r

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

--- Comment #2 from mathieu saby mathieu.s...@univ-rennes2.fr ---
In basketgroup.pl, some code is supposed to be executed if $op = validate.
But this value is no more assigned to $op variable since 2009.

This patch suppressed dead code.
No functional changes expected

Regression test : check basketgroup are shown as before the patch, and can be
closed and reopen.
Check you can create a basketgroup when you close a basket.


M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

--- Comment #1 from mathieu saby mathieu.s...@univ-rennes2.fr ---
Created attachment 23642
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23642action=edit
[PATCH] Bug 11056 : Delete dead code in basketgroup.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on validate param

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

mathieu saby mathieu.s...@univ-rennes2.fr changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11418] New: cannot delete a course

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11418

Bug ID: 11418
   Summary: cannot delete a course
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Course reserves
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We see the delete course button, click on this button, then when the message
appears:  Are y ou sure you want to delete this course?, click on the OK
button --- but nothing happens.  The course is still there, it does not
disappear.  It appears that the button does not work.

Tested in 3.12.7.  I can delete a course in master though.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23458|0   |1
is obsolete||
  Attachment #23459|0   |1
is obsolete||
  Attachment #23460|0   |1
is obsolete||
  Attachment #23461|0   |1
is obsolete||
  Attachment #23462|0   |1
is obsolete||
  Attachment #23463|0   |1
is obsolete||
  Attachment #23464|0   |1
is obsolete||
  Attachment #23465|0   |1
is obsolete||
  Attachment #23466|0   |1
is obsolete||
  Attachment #23467|0   |1
is obsolete||
  Attachment #23468|0   |1
is obsolete||
  Attachment #23469|0   |1
is obsolete||
  Attachment #23470|0   |1
is obsolete||
  Attachment #23471|0   |1
is obsolete||
  Attachment #23603|0   |1
is obsolete||

--- Comment #100 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23643
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23643action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #102 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23645
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23645action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #103 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23646
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23646action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #105 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23648
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23648action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #104 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23647
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23647action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #106 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23649
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23649action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #107 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23650
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23650action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #109 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23652
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23652action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #112 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23655
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23655action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #108 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23651
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23651action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #110 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23653
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23653action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #111 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23654
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23654action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2013-12-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #114 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 23657
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23657action=edit
Bug 6427 [Part 15] - Auto-print payment and manual fee receipts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >