[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #46 from M. Tompsett --- I believe this test plan properly tests everything. However, each smaller one should have it's own test plan in the appropriate comment, for those who don't have time to test everything at once. And really only the last two patches are enhancements, so I would hope that the other 8 patches could make it into 3.14.x and/or earlier too. REVISED TEST PLAN - 0) Test the existing functionality and notice some of the bugs. Backup the database if you care about your opac_news. :) Apply all the patches. 1) Do a fresh install, to ensure that branchcode is created as a field in the opac_news table. - Did you try for something non-English? - This would require rolling your own distribution, or being lazy and just source'ing kohastructure.sql after dropping and recreating the database. 2) Do an upgrade to confirm that the branchcode field is added to the opac_news table. - useful MySQL commands: show create table opac_news; describe opac_news; 3) prove -v t/db_dependent/NewsChannels.t This should test all the changes in C4::NewsChannels functions. 4) Log into the staff client - Does the News display on the main page bust? 5) Add a new dummy branch (so it has no items or borrowers) 6) Go to Tools->News - Are the locations properly display? 7) Add a News item, for 'All' interfaces for 'All Branches'. 8) Add a News item, for 'Librarian interface' interfaces for the dummy branch. 9) Add a News item, for 'Slip' interfaces at your user branch. 10) Add a News item, for 'OPAC' interface at your user branch. 11) Change the Location and Branch filters. - Do they show what you select after you click the Filter button? (Unpatched the Location does not!) - Are the items displayed matching what is selected? - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) 12) Click 'Edit' for one of the news items added. - Does what comes up match what was displayed? ( Unpatched the Location may be 'All' ) - Are the drop downs containing the expected values? (All, Librarian Interface, Slip, and OPAC ( -- for each installed) (All Branches, and every branch listed) - Does the submitted values match the changes made? 13) Find a patron to print a slip for. Print Slip. - Does both the 'All' and 'Slip' news show up on the print slip? 14) In a new tab, go to OPAC - Does the News display on the main page bust? - Does it display the news item for a specific branch? (It shouldn't when patched, but unpatched it would) (Only one of the new things added should be displayed) 15) Log in as yourself on OPAC. - Does that piece of News display now too? (Both things added should be displayed) 16) In the staff client, delete the dummy branch. - Does the 'Librarian interface' news item exist any more? It shouldn't. 17) Check the news items added and click the delete button in the staff client. - Did it delete them appropriately? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What|Removed |Added Attachment #23475|0 |1 is obsolete|| --- Comment #45 from M. Tompsett --- Comment on attachment 23475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23475 Bug 7567 - News by Branch This mega patch has been replaced by all the smaller patches. I think I even fixed up a couple things from it too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #20 from Katrin Fischer --- Hm, I just took a look at the feature and I think I found a problem: 1) The feature should not be active, when OpacBrowseResults is turned off. Maybe there should even be a separate pref to control this independently from OpacBrowseResults. People are worried about the use of cookies in some contexts and it might be nice to limit the use of them to a mininum. 2) I wonder if the plugin used needs to be added to the about.pl page - not sure there. It also states alpha, but it does look like there is a stable version available now: https://code.google.com/p/jquery-json/ 3) While this feature is a bit fun to use, I wonder a bit about the use cases. Maybe the sponsoring library/libraires could share the idea behind the feature? 4) Currently the feature seems to do less than the cart or the list functionality offer, as there are no 'bulk' actions available, so I can understand what Galen means with his comment. 5) Also it changes the behaviour of an existing feature, which might be a bit unexpected to users. Not sure what we could do here. 6) When switching between different records you always have to reopen the "Browse results" area and this hides part of the possible actions on the page. This way you can't switch really fast between records and have to find your place in the list again. I think the first point is a 'Failed QA'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 --- Comment #5 from Katrin Fischer --- Created attachment 23742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23742&action=edit [PASSED QA] Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum Signed-off-by: Suzanne Fayle Signed-off-by: Katrin Fischer This works as described, passes all tests and QA script. Note: Because $query = $builtquery when the QueryParser is used, this problem is only visible when UseQueryParser is set to "Don't try". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 mathieu saby changed: What|Removed |Added Attachment #23642|0 |1 is obsolete|| --- Comment #4 from mathieu saby --- Created attachment 23741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23741&action=edit [PATCH] Bug 11056 : Delete dead code in basketgroup.pl In basketgroup.pl, some code is supposed to be executed if $op = "validate". But this value is no more assigned to $op variable since 2009. This patch suppressed dead code, along with parseinputbaskets and parseinputbasketgroups subs, which are obsolete. No functional changes expected Regression test : Check basketgroup are shown as before the patch, and can be closed and reopen. Check you can add or remove a basket from a basketgroup, and change informations about it (like delivery place) Check you can create a basketgroup when you close a basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 --- Comment #2 from mathieu saby --- See also bug 11056 for code cleaning on basketgroup.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 mathieu saby changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 --- Comment #1 from mathieu saby --- Created attachment 23740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23740&action=edit [PATCH] Bug 11433 - Remove attachbasket op value in basket.pl and rename it in basketgroup.pl This patch cleans code in basket.pl, basketgroup.pl and basketgroup.tt Not absolutely needed, but makes further improvements easier 'attachbasket' is used in basket.pl and basketgroup.pl as a value of $op In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'. But it is never the case (grep attachbasket * -r), so this condition must be removed. In basketgroup.pl, the description of 'attachbasket' value in comments is wrong, and the name is misleading (this value of $op is ONLY used when someone clic on 'Save' button on a basketgroup page). So 'attachbasket' should be renamed. This patch - removes code related to 'attachbasket' in basket.pl - rename 'attachbasket' to 'save' in basketgroup.pl and basketgroup.tt - fixes some comments related to 'attachbasket' and 'mod_basket' in basketgroup.pl No functional change expected. Regression test only : Make a complete acquisition process, from the creation of a basket to the closure of a basketgroup, and check everything is OK On a basket page, try to change the basketgroup it belongs to, and check everything is OK On a basketgroup page, try to edit the content of a basketgroup (put a new basket in it, change the deliverybranch...), and check everything is OK On a basketgroup page, try to reopen a closed basketgroup, and close an open basketgroup, and check everything is OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11433] New: Remove attachbasket op value in basket.pl and rename it in basketgroup.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11433 Bug ID: 11433 Summary: Remove attachbasket op value in basket.pl and rename it in basketgroup.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.s...@univ-rennes2.fr QA Contact: testo...@bugs.koha-community.org Code cleaning: 'attachbasket' is used in basket.pl and basketgroup.pl as a value of $op In basket.pl, some code is supposed to be executed if $op eq 'attachbasket'. But it is never the case (grep attachbasket * -r), so this condition must be removed. In basketgroup.pl, the description of 'attachbasket' value in comments is wrong, and the name is misleading (this value of $op is ONLY used when someone clic on 'Save' button on a basketgroup page). So 'attachbasket' should be renamed. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056 --- Comment #3 from mathieu saby --- Functions parseinputbaskets and parseinputbasketgroups are only called by this dead code. So they could be removed too. M. Saby -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Katrin Fischer changed: What|Removed |Added Attachment #23723|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 23739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23739&action=edit [PASSED QA] Bug 9948: Fix acqui/finishreceive.pl so it will update item data properly on partial receives Problem summary: when doing partial receives for the given order - 1) if AcqCreateItem is set to 'ordering', various item data (price, dateaccessioned, replacementprice, replacementpricedate) are getting erroneously updated on the wrong (yet to be received == not the ones being currently received) item records 2) if AcqCreateItem is set to 'receiving', newly received item records are being created without the aforementioned fields set to the proper values This (trivial) patch should deal with both cases, hopefully without breaking enything else. To test: - apply the patch, - create some orders with 2+ quantity - test partial & non-partial receives for those orders - ensure the received item records are getting modified (for AcqCreateItem set to 'ordering') and/or created (for AcqCreateItem set to 'receiving') correctly for both partial and non-partial receives - receiving orders with quantity = 1 / receiving orders in non-partial mode should be still working fine for 1) & 2) scenarios (i.e., AcqCreateItem set to 'ordering' / AcqCreateItem set to 'receiving') Signed-off-by: Nicole C. Engard Works as I'd expect now! Awesome patch. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Passes all tests and QA script. Also: t/db_dependent/Acquisition/ t/db_dependent/Acquisition.t Created 2 orders with 3 items each for both settings of AcqCreateItem (on receive, on order) with the patches applied. No regressions found. Closed baskets and received shipments for each, with AcqCreateItem set according to how the order was created. First recreated the problem without the patches, reloaded database and confirmed that the patch fixes it. No problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Katrin Fischer changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11432 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10584 Assignee|oleon...@myacpl.org |mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11432] 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 --- Comment #1 from M. Tompsett --- Created attachment 23738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23738&action=edit Bug 11432 - 404.pl redirect for single, hidden result makes no sense. In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN - 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11432] New: 404.pl redirect for single, hidden result makes no sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11432 Bug ID: 11432 Summary: 404.pl redirect for single, hidden result makes no sense. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org In bug 10584, when searching for something in OPAC and a single, hidden result is returned, the default automatic redirect to the details/MARCdetails/ISBDdetails page triggers a 404.pl error page. This makes no sense. The correct behaviour would be to give no results. TEST PLAN - 1) OPAC Search for something (I started with stupid) 2) Narrow it to one item (I tweaked it to stupid things) 3) Detail page comes up 4) Staff client -> home -> administration -> global system preferences -> OPAC 5) OpacHiddenItems add "homebranch: [MAL,DAV,PAP]", changing MAL, DAV, PAP to the branches for items for this single biblio. 6) Search for the one item again in OPAC -- 404.pl is triggered. 4) Apply patch 5) Search again for the one item search -- No results is triggered (as expected) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #3 from Paul Poulain --- In your idea, will sounds be activable independently ? For example, I would like to have a sound at check-out, but NOT at check-in. Or I would like to have a sound at check-in only if there's a hold. If everything is OK, I don't want any sound. Will it be possible ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #8 from Kyle M Hall --- Applying: Bug 11413: Change the field number logic fatal: sha1 information is lacking or useless (C4/MarcModificationTemplates.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11413: Change the field number logic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11414] Marc modification template limitations should alert the user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11414 Kyle M Hall changed: What|Removed |Added Attachment #23628|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 23737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23737&action=edit Bug 11414: Marc modification template limitations should alert the user Test plan: On the Marc modification tool: add/edit a new action on a field and define a condition on the same field. Verify that you get a warning message in red. see bug 11413 for more information Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9016] Multi transport types for notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #43 from Kyle M Hall --- Not sure if this is a problem with the patch or just me: Applying: Bug 9016: QA Followup fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9016: QA Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Kyle M Hall changed: What|Removed |Added Attachment #23735|0 |1 is obsolete|| --- Comment #27 from Kyle M Hall --- Created attachment 23736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23736&action=edit Bug 10861 - QA Followup - Clarify preference description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 --- Comment #26 from Kyle M Hall --- Created attachment 23735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23735&action=edit Bug 10861 - QA Followup - Clarify preference description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Kyle M Hall changed: What|Removed |Added Attachment #23565|0 |1 is obsolete|| --- Comment #25 from Kyle M Hall --- Created attachment 23734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23734&action=edit Bug 10861: Followup Add a check on cardnumber length This patch refactors the previous code and moves the logic from the pl to a new routine. Same test plan as previous patch. /!\ new unit test filename. Signed-off-by: Marcel de Rooy Bug 10861: Reintroduced the cardnumber length check (client side) Previous patches has removed the pattern attribute of the input, it was not needed. This patch reintroduces it. It will only work for new browser version. Moreover, it manages with the ',XX' format (see UT). Signed-off-by: Marcel de Rooy Squashed the last two follow-ups. The pattern test did not work fully for me in Firefox 26 (very recent). But I see the message when I clear the field. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861
Kyle M Hall changed:
What|Removed |Added
Attachment #23563|0 |1
is obsolete||
--- Comment #23 from Kyle M Hall ---
Created attachment 23732
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23732&action=edit
Bug 10861: Add a check on cardnumber length
Some libraries would like to add a check on the cardnumber length.
This patch adds the ability to restrict the cardnumber to a specific
length (strictly equal to XX, or length > XX or min < length < max).
This restriction is checked on inserting/updating a patron or on importing
patrons.
This patch adds:
- 1 new syspref CardnumberLength. 2 formats: a number or a range
(xx,yy).
- 1 new unit test file t/Members/checkcardnumber.t for the
C4::Members::checkcardnumber routine.
Test plan:
1/ Fill the pref CardnumberLength with '5,8'
2/ Create a new patron with an invalid cardnumber (123456789)
3/ Check that you cannot save
4/ With Firebug, replace the pattern attribute value (for the cardnumber
input) with ".{5,10}"
5/ You are allowed to save but an error occurred.
6/ Try the same steps for update.
7/ Go to the import borrowers tool.
8/ Play with the import borrowers tool. We must test add/update patrons
and the "record matching" field (cardnumber or a uniq patron attribute)
Signed-off-by: Marcel de Rooy
Tested adding, updating; importing and ran unit test.
Preliminary QA comments on Bugzilla
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10861] Add a check on cardnumber length
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861 Kyle M Hall changed: What|Removed |Added Attachment #23564|0 |1 is obsolete|| --- Comment #24 from Kyle M Hall --- Created attachment 23733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23733&action=edit Bug 10861: Follow-up for typo in patrons.pref I'd rather have a comma than a coma :) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #2 from Kyle M Hall --- 8) Add three new system preferences to define urls to override these sounds with. If left empty, the default sounds will be used -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 --- Comment #28 from M. Tompsett --- Oooo... sounds like a test case missed. Because the hidden item wouldn't be listed in a search, so there would be no way to go to the details page. And looking for the page of a hidden item is like looking for a biblio that is non-existant (404.pl). However, Koha when there is only one result automatically goes to the detail page. I'll look into this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall --- I think we can do this in a fairly elegant way: 1) Identify all triggers of existing sounds 2) Strip out existing html for playing sounds 3) Make those existing sound-triggering dialogs with a class "audio-success", "audio-error" 4) Add a new "warning" sound 5) Add the class "audio-alert" to those dialogs that should trigger the new audio sound 6) Modify the header include to trigger the respective sound if an element with one of these classes is present on the page via jquery ( if soundon is enabled of course ) 7) Rename soundon to something more sensible ( eg UseSounds, UseAudioAlerts, etc ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] New: Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Bug ID: 11431 Summary: Add additional sound options for warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: meli...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com It would be nice if Koha had a library of sounds to choose from and then apply to various yellow box warnings. This should also include a page in the administration area where staff could choose which sound to be played for each action. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Component|OPAC|MARC Authority data support -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Kyle M Hall changed: What|Removed |Added Attachment #23568|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 23731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23731&action=edit Bug 11383: Add help file for Marc modification templates This patch adds the missing help files to the Marc modification templates tool. To test: * Visit Tools > Marc modification templates * Click 'Help' in the top right * Confirm that help is there and right Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11383] There is no help page for the marc modification templates tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11383 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 Kyle M Hall changed: What|Removed |Added Attachment #22183|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 23730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23730&action=edit Bug 10905: Author tracings incorrect when UseAuthoritiesForTracings is turned on Quotation marks in MARC21slim2OPACDetail.xsl break author tracings in OPAC. This patch fixes that. To reproduce: - Enable UseAuthoritiesForTracings - Search in the OPAC and go to the detail page of a record that has links to authorities. - Click on the magnifier icon - You get a 404 error page. To test the fix: - Apply the patch - Search in the OPAC and go to the detail page of a record that has links to authorities. - Click on the magnifier icon - You are sent to the corresponding authority record. Regards To+ Sponsored-by: Universidad Nacional de Cordoba http://bugs.koha-community.org/show_bug.cgi?id=10838 Signed-off-by: David Noe Signed-off-by: Kyle M Hall Passes koha-qa.pl, trivial change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10905] Author tracings incorrect when UseAuthoritiesForTracings is turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Attachment #23572|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 23729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23729&action=edit Bug 11170: Follow-up for typo occured in parcels.tt Found this typo while testing bug 11170. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11170] The pending order list should only display orders to receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170 Kyle M Hall changed: What|Removed |Added Attachment #23571|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 23728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23728&action=edit Bug 11170: The pending order list should only display orders to receive The order status ordered is set when the basket is closed. The parcel page should only display status "ordered" and "partial". Test plan: - create a basket. - create an order. - verify the order is not listed on the parcel page (i.e. you cannot receive it). - close the basket. - verify the order is listed on the parcel page. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall changed: What|Removed |Added Attachment #23316|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 23726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23726&action=edit Bug 6331 Do not populate marc in deleted items This is supplementary to the main patch for bug 6331. Having removed the attribute marc from items DelItem should not populate it Signed-off-by: Fridolin Somers Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall changed: What|Removed |Added Attachment #23356|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 23727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23727&action=edit Bug 6331 - Update timestamp when deleting items When item is transfered from items table to deleted items, all fields must be copies but "timestamp". This value must be updated to know when item has been deleted. Test plan: - Look a an item timestamp : mysql> select timestamp from items where itemnumber = 2690; +-+ | timestamp | +-+ | 2011-09-09 15:30:21 | +-+ 1 row in set (0.00 sec) - Delete this item in cataloguing module - Check it is not in items table anymore : mysql> select timestamp from items where itemnumber = 2690; Empty set (0.00 sec) - Look in deleteditems table : mysql> select timestamp from deleteditems where itemnumber = 2690; +-+ | timestamp | +-+ | 2013-12-05 15:33:20 | +-+ 1 row in set (0.00 sec) => timestamp as been set to actual date/time Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Patch set passes koha-qa.pl, works as advertised! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 Kyle M Hall changed: What|Removed |Added Attachment #23230|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 23725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23725&action=edit Bug 6331 - Obsolete marc column in deleteditems There is a difference between "items" and "deleteditems" tables in "kohastructure.sql" : "deleteditems" has a field "marc" not existing in "items". This patch removes this obsolete column. === Test : - suppressing an item, checking the deleted item is properly stored in deleteditems table - checking the column marc has been deleted from deleteditems table Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166
Kyle M Hall changed:
What|Removed |Added
Attachment #23566|0 |1
is obsolete||
--- Comment #3 from Kyle M Hall ---
Created attachment 23724
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23724&action=edit
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals
In budgets administration, admin/aqbudgets.pl, there is a combobox for
filtering by branch code.
The bug is that the filter uses a pattern match instead of equals :
next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/;
In this case, if there is a branch with code '1' and one with code '12',
filtering by branch '1' will also show budgets of branch '12'.
Test plan :
- Create a branch with code '1' and one with code '12'
- Create budgets in both branches
- Go to admin/aqbudgets.pl
- Filter by branch '12'
=> You see only budgets of this branch
- Filter by branch '1'
=> You see only budgets of this branch
Signed-off-by: Marcel de Rooy
Signed-off-by: Kyle M Hall
Passes koha-qa.pl, works as advertised
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern match instead of equals
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Kyle M Hall changed: What|Removed |Added Attachment #23606|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 23723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23723&action=edit Bug 9948: Fix acqui/finishreceive.pl so it will update item data properly on partial receives Problem summary: when doing partial receives for the given order - 1) if AcqCreateItem is set to 'ordering', various item data (price, dateaccessioned, replacementprice, replacementpricedate) are getting erroneously updated on the wrong (yet to be received == not the ones being currently received) item records 2) if AcqCreateItem is set to 'receiving', newly received item records are being created without the aforementioned fields set to the proper values This (trivial) patch should deal with both cases, hopefully without breaking enything else. To test: - apply the patch, - create some orders with 2+ quantity - test partial & non-partial receives for those orders - ensure the received item records are getting modified (for AcqCreateItem set to 'ordering') and/or created (for AcqCreateItem set to 'receiving') correctly for both partial and non-partial receives - receiving orders with quantity = 1 / receiving orders in non-partial mode should be still working fine for 1) & 2) scenarios (i.e., AcqCreateItem set to 'ordering' / AcqCreateItem set to 'receiving') Signed-off-by: Nicole C. Engard Works as I'd expect now! Awesome patch. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9948] acq data going on first item even if not received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9948 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #40 from Martin Renvoize --- Just a little update on this.. I've built some packages from this patch, and installed onto a clean VM. * All seems to work as expected using Tamil indexer * Patches all pass QA script The last thing I wanted to check was that this patch will also work with the new daemon mode on rebuild_zebra.pl. I believe it should, but I haven't yet had a moment to get my teeth stuck into that piece. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #39 from Martin Renvoize --- Just a little update on this.. I've built some packaages from this patch, and installed onto a clean VM. * All seems to work as expected using Tamil indexer * Patches all pass QA script The last thing I wanted to check was that this patch will also work with the new daemon mode on rebuild_zebra.pl. I believe it should, but I haven't yet had a moment to get my teeth stuck into that piece. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #93 from Paola Rossi --- I test the patch against master 3.15.00.006. The 8-th patch "Update database entry" needs to be rebased. The following errors occur. So I pass the patch to "Failed QA" status. I add some searchable additional fields, in particular these ones: 022$a category NOT_LOAN category CCODE Using advanced "Search subscription", I see the following 2 errors: S1) My subscription' NOT_LOAN-category-additional-field value is "Ordered" (code "-1" in Administration Authorized values' table); choosing "NOT_FOR_LOAN" (code "1") in the search field in the left column, the list shows the subscription. S2) My subscription' CCODE-category-additional-field value is "Non Fiction" (code "NFIC"); choosing "Fiction" (code "FIC") in the search field in the left column, the list shows the subscription. The string "FIC" is a substring of string "NFIC", as well as the string "1" is a substring of "-1". So the error could be that search matches codes of values of the categories in a "contains" way, instead of an "exactly =" way. The error could occur matching the codes, not the descriptions. A counterexample is this of category "LOST": description "Lost" is a substring of description "Lost and Paid For". The corresponding codes are "1" and "3", mutually distinct strings. S3 OK) searching "Lost", the subscription whose additional value is set to "Lost and Paid for" is not found. Errors filtering at the bottom of the columns of the result table (columns of additional searchable fields): F1) My subscription' ISSN-marc-additional-field value is 12345678; writing 12345678 in the filter at the bottom of the column, the list of subscriptions becomes null. F2) My subscription' NOT_LOAN-category-additional-field value is "Ordered"; writing "Ordered" in the filter at the bottom of the column, the list of subscriptions becomes null. F3) Using every filter at the bottom of the columns of the additional searchable fields, the list becomes null. F4 OK) On the contrary, using the filters at the bottom of the fields that are not additional the list is filtered OK. [I use FireFox 25.0.1] NB1. A form in the left column of the page is often named "Filter" in koha. The subscription searching is named "Search" there. NB2. Before patching the zero case, all the subscriptions were found by advanced search: either the ones modified with additional fields filled, or the ones not yet modified whose additional fields are therefore still unset. After patching the zero case, advanced search found only the modified subscriptions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11410] Cataloging search finds no results for searches with ampersands
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11410 Kyle M Hall changed: What|Removed |Added Attachment #23614|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 23722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23722&action=edit Bug 11410 - Cataloging search finds no results for searches with ampersands The cataloging search is passing the incorrect variable to SimpleSearch. I'm sure this is causing other issues, but the one I have identified is that any searches with an "&" in them return no results. Test Plan: 1) Catalog a new record titled "Cats & Dogs" 2) Rebuild your zebra index so this record is indexed 3) Browse to cataloguing/addbooks.pl 4) Search for "Cats & Dogs" 5) Notice you get no results 6) Apply this patch 7) Repeat the search 8) Notice your result now shows up! Signed-off-by: Heather Braum Signed-off-by: Suzanne Fayle -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #21 from Jonathan Druart --- No, I read too quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #20 from Jonathan Druart --- Is this patch serves your purpose? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336 --- Comment #19 from Jonathan Druart --- Created attachment 23721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23721&action=edit Bug 11336: WIP add GetOldReserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11416] Serials editor improperly hides fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416 Kyle M Hall changed: What|Removed |Added Attachment #23630|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 23720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23720&action=edit Bug 11416 - Serials editor improperly hides fields In serials/serials-edit.pl, if a field is hidden from the OPAC, it will not display in the editor, even if the field is marked as visible in the staff intranet and editor. However, the field is still displayed correctly in the items editor ( additem.pl ).: Test Plan: 1) Select an item-level field ( e.g. non-public note ) 2) Create a serial using the default framework ( or one of your choice ) 3) For that framework, mark the chosen field as visible from the intranet and editor, but not the opac. 4) Recieve an item for this serial, note your field does not display 5) Use the biblio item editor to add an item ( additem.pl ), not the field displayes 6) Apply this patch 7) Repeat step 4, not the field displayes Signed-off-by: Kim Schwant -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11416] Serials editor improperly hides fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11416 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11419] z39.50 searches not displaying errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11419] z39.50 searches not displaying errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11419 Kyle M Hall changed: What|Removed |Added Attachment #23658|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 23719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23719&action=edit Bug 11419 - z39.50 searches not displaying errors When a z39.50 server isn't able to be searched successfully, the yellow error box comes up empty. Test Plan: 1) Go to Administration/z39.50 servers 2) Create a fake z39.50 server with a made up address 3) Go to cataloging, search only that server 4) Note the empty yellow alert box 5) Apply this patch 6) Re-run the search, not the alert box has a message in it now Signed-off-by: Nora Blake -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #6 from Jonathan Druart --- Created attachment 23718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23718&action=edit Bug 11430: Intranet changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11336] Priority is not updated on deleting holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11336
Galen Charlton changed:
What|Removed |Added
Status|Passed QA |In Discussion
--- Comment #18 from Galen Charlton ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Kyle M Hall from comment #6)
> > I agree this is a bit of a dirty fix. Wouldn't it be better to modify
> > GetReserve to look for the reserve in reserves first, and then old_reserves
> > if it doesn't find it there?
>
> Hum... It could work. But how to be sure this won't introduce a regression?
> For ex. a logic like: if GetReserve returns undef, the reserve is deleted.
Upon review, I prefer Jonathan's original approach. Yes, it's a bit "dirty",
but that's mostly because _FixPriority() does not have all that great an
interface: if it's passed a single $reserve_id, it's really meant to fix the
priority for all holds on that hold's bib; if it's passed a rank and a
$reserve_id, it touches that specific hold first.
No other accessor routine currently falls back to looking in the old_* or
deleted* table if it can't find a row in the main table, and I don't see a good
reason to make GetReserve() different when all that is needed is to pass the
biblionumber to _FixPriority.
Also, making hold priority updates after cancellation contingent on there being
a row in old_reserves opens up the possibility (admittedly, a remote one) of a
race condition if anybody ever writes a cronjob that purges old_reserves.
I suggest going back to Jonathan's original approach -- most of the test cases
and the follow-up can be used as is, I suspect. For extra credit, it might be
a good time to make _FixPriority accept a hashref, so that you can say:
_FixPriority({ biblionumber => $foo});
vs.
_FixPriority({ reserve_id => $foo, rank => 'del' })
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #5 from Jonathan Druart --- Created attachment 23717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23717&action=edit Bug 11430: OPAC changes -- prog theme -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #2 from Jonathan Druart --- Created attachment 23714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23714&action=edit Bug 11430: delete search history by id - API changes Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. This change is done for the OPAC and intranet interface. The user is now allow to delete one or more lines of his/her search history. Test plan (for intranet, opac: bootstrap and prog themes): 1/ launch some search (catalogue and authority) 2/ verify the lines is added to your search history 3/ delete one or more lines of the history and verify they have been deleted 4/ at the OPAC: logout and do again steps 1-3. 5/ prove t/db_dependent/Search/History.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #1 from Jonathan Druart --- Created attachment 23713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23713&action=edit Bug 11430: DB changes: Add the primary key for search_history Adds a primary key search_history.id. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #3 from Jonathan Druart --- Created attachment 23715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23715&action=edit Bug 11430: UT: add unit tests to delete only selected lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 --- Comment #4 from Jonathan Druart --- Created attachment 23716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23716&action=edit Bug 11430: OPAC changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807
--- Comment #40 from Jonathan Druart ---
Created attachment 23712
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23712&action=edit
Bug 10807: FIX conflicts with bug 10380
Bug 10380 changes the prototype of the output_pref routine.
Now it should take a hashref in parameters.
Without this patch, an error occurred if the user was not looged in and
try to access to his search history (Template process failed: undef
error - The 'day' parameter ("2013") to DateTime::new did not pass the
'an integer which is a possible valid day of month' callback")
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10718] items with no checkouts report does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #17 from Kyle M Hall --- This patch has been pushed to 3.8.x, and will be in 3.08.20. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #9 from Kyle M Hall --- This patch has been pushed to 3.8.x, and will be in 3.08.20. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #14 from Kyle M Hall --- This patch has been pushed to 3.8.x, and will be in 3.08.20. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 --- Comment #15 from Kyle M Hall --- This patch has been pushed to 3.8.x, and will be in 3.08.20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What|Removed |Added Depends on||10807, 10862 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] New: Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Bug ID: 11430 Summary: Search history: Delete selected lines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org Bug 10807 adds a search history for authorities and bug 10862 adds the search history on the staff interface. This one allows the user to select the search history lines he wants to delete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11430] Search history: Delete selected lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10862] Add an search history for the staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862 Jonathan Druart changed: What|Removed |Added Blocks||11430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart changed: What|Removed |Added Blocks||11430 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall changed: What|Removed |Added Attachment #23213|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #8 from Kyle M Hall --- Created attachment 23711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23711&action=edit Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. http://bugs.koha-community.org/show_bug.cgi?id=10774 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 Sophie MEYNIEUX changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m --- Comment #27 from Sophie MEYNIEUX --- What is a bit strange is that when you make a search without results you've got a "No results found!" answer. But if the search finds only one biblio matching, but all items are hidden, then a 404 error page is displaid. OPAC users don't understand the difference and for them 404 error page means the system fails, not that there are no results to their search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Kyle M Hall changed: What|Removed |Added Attachment #22963|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > Kyle, what is your opinion on my patch? Maybe it is stupid, what do you > think about it? I think it's a far better solution than mine! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #32 from Julian Maurice --- Created attachment 23710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23710&action=edit Bug 8064: Fix issues with control fields and non-repeatable check Fields < 010 were systematically unchecked during target rebuild because they have no subfields (unchecking manually all subfields of a field automatically uncheck the field) When user check a field or a subfield, we have to uncheck it before calling (sub)field_can_be_added. Otherwise, field is treated as if it was already in target record, and this is a problem for non-repeatable fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What|Removed |Added Attachment #21351|0 |1 is obsolete|| --- Comment #30 from Julian Maurice --- Created attachment 23708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23708&action=edit Bug 8064: Merge several biblios Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8064] Merge several biblio records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What|Removed |Added Attachment #22749|0 |1 is obsolete|| --- Comment #31 from Julian Maurice --- Created attachment 23709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23709&action=edit Bug 8064: Change the way target record is built. Rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
