[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Katrin Fischer changed: What|Removed |Added Attachment #23842|0 |1 is obsolete|| Attachment #23843|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 23852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23852&action=edit [PASSED QA] Bug 11445: regression test for duplicate hold notifications This patch implements a regression test for verifying that duplicate hold notifications aren't sent if ModReserveAffect() is called repeatedly (as might happen if a circ operator accidentally checks in an item and confirms its hold more than once). Note that the test depends on the fact that _koha_notify_reserve() defaults to sending a HOLD_PRINT letter if the borrower has not specified an email or SMS hold notification. To test: [1] Run prove -v t/db_dependent/Reserves.t [2] The 'patron not notified a second time (bug 11445)' test should fail. [3] Apply the main patch and run prove -v t/db_dependent/Reserves.t again. This time all tests should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 --- Comment #6 from Katrin Fischer --- Created attachment 23853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23853&action=edit [PASSED QA] Bug 11445: avoid sending duplicate hold waiting notifications This patch fixes a problem where a patron could receive duplicate hold waiting notifications. For example, this could happen if a circ operator checked in an item more than once and confirmed the same hold each time. To test: [1] Set up a test patron that received hold waiting notifications. [2] Put an item on hold for the patron, then check the item in and confirm the hold. Verify that a hold notification is sent (or inspect the message_queue table). [3] Check the item in again and confirm the hold again. A duplicate hold notification will be generated. [4] Apply the patch. [5] Repeat steps 2 and 3. This time, only one notification should be generated. [6] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Chris Cormack changed: What|Removed |Added Attachment #23315|0 |1 is obsolete|| --- Comment #10 from Chris Cormack --- Created attachment 23851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23851&action=edit Bug 8921: koha-common*.deb should depend on cron Trivial patch to add 'cron-daemon' as dependency for the koha-common package. 'cron' is usually pulled in any minimal Ubuntu/Debian install, but in some circumstances (using debootstrap) it might be absent. As Robin said, this doesn't seem to have any side effects. Regards To+ Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Chris Cormack changed: What|Removed |Added Attachment #23070|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 23850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23850&action=edit Bug 11075 - 'select all' export clears renew checkboxes If circulation exports are enabled (by turning on ExportWithCsvProfile), the table on the checkout page includes three columns of checkboxes -- 'renew', 'checkin', and 'export'. For each loan, the renew and checkout links should behave like radio buttons, but the state of the export checkbox is meant to be independent of the renew and checkin checkboxes. However, if the 'select all' link in the export column is clicked, active renew checkboxes are toggled off. The desired behavior is that clicking the select all link in the export column should only affect checkboxes in that column. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11075] Clicking 'select all' link in export tab in checkout page clears renew checkboxes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188
Chris Cormack changed:
What|Removed |Added
Attachment #23181|0 |1
is obsolete||
--- Comment #2 from Chris Cormack ---
Created attachment 23849
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23849&action=edit
Bug 11188 - Make gather_print_notices.pl die on failed open()
Problem:
If you tell gather_print_notices.pl to write output to a location
you do not have write access to, it will silently fail to write the
data, but still mark unsent messages as sent.
Solution:
This patch adds two lines of defense:
1. Check that the location given for the output is writable
2. use "open() or die" instead of just "open()" when writing the
output
The first measure should catch most of the potential errors, but
I guess a directory can be writable, but the open() still can fail
because the disk is full or something similar.
To test:
- Make sure you have some unsent messages in the message_queue table,
that do not have an email adress
- Apply the patch
- Run the script, pointing at a location you do not have access to
write to. Check that the script exits with an appropriate error
message, and that the unsent messages are still unsent. Do this
both with and without the -s option.
- To fake passing the first line of defence, comment out line 62
and put this in instead:
if ( !$output_directory || !-d $output_directory ) {
- Run the script again as above, check you get an appropriate
error and that the message queue is not touched
- Reset line 62 to how it was
- Run the script against a directory you do have access to write to
and check that output is produced as expected and that messages
are marked as sent
- Sign off
Signed-off-by: Chris Cormack
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Chris Cormack changed: What|Removed |Added Attachment #23577|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 23848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23848&action=edit Bug 11402: Labels::_guide_box should return undef if undefned data is passed That's it. A guide box cannot be created if invalid data is passed. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11402] Labels::_guide_box should return undef if undefned data is passed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11402 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11403] renew page missing help file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11403] renew page missing help file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11403 Chris Cormack changed: What|Removed |Added Attachment #23578|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 23847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23847&action=edit Bug 11403: Add missing help file to new Renew page This patch adds a help file to the Renew page found under Circulation. To test: * Go to Circulation > Renew * Click the help link * Confirm text and manual link are correct. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What|Removed |Added Attachment #23051|0 |1 is obsolete|| --- Comment #10 from Chris Cormack --- Created attachment 23846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23846&action=edit Bug 11243: UT: unit tests for GetBasketsInfosByBookseller Verify prove t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t returns green. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What|Removed |Added Attachment #23050|0 |1 is obsolete|| --- Comment #9 from Chris Cormack --- Created attachment 23845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23845&action=edit Bug 11243: Display count of items and biblios cancelled Same as previous patch but for the biblios count. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11243] Supplier list counts all items, even canceled ones
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11243 Chris Cormack changed: What|Removed |Added Attachment #22946|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 23844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23844&action=edit Bug 11243: Supplier list should distinct canceled items On the supplier result list, the "Item count" columns contain the sum of all items ordered for a basket. But if an order is canceled, the item count is not really meaningful. This patch just adds, in parenthesis, the number of items canceled. Test plan: - create a basket and 3 orders with different number of items - cancel 1 order - verify on the supplier list that the number of items is correct and the number of canceled items is correct too. Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What|Removed |Added Attachment #23812|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 23843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23843&action=edit Bug 11445: avoid sending duplicate hold waiting notifications This patch fixes a problem where a patron could receive duplicate hold waiting notifications. For example, this could happen if a circ operator checked in an item more than once and confirmed the same hold each time. To test: [1] Set up a test patron that received hold waiting notifications. [2] Put an item on hold for the patron, then check the item in and confirm the hold. Verify that a hold notification is sent (or inspect the message_queue table). [3] Check the item in again and confirm the hold again. A duplicate hold notification will be generated. [4] Apply the patch. [5] Repeat steps 2 and 3. This time, only one notification should be generated. [6] Verify that prove -v t/db_dependent/Reserves.t passes. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What|Removed |Added Attachment #23811|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 23842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23842&action=edit Bug 11445: regression test for duplicate hold notifications This patch implements a regression test for verifying that duplicate hold notifications aren't sent if ModReserveAffect() is called repeatedly (as might happen if a circ operator accidentally checks in an item and confirms its hold more than once). Note that the test depends on the fact that _koha_notify_reserve() defaults to sending a HOLD_PRINT letter if the borrower has not specified an email or SMS hold notification. To test: [1] Run prove -v t/db_dependent/Reserves.t [2] The 'patron not notified a second time (bug 11445)' test should fail. [3] Apply the main patch and run prove -v t/db_dependent/Reserves.t again. This time all tests should pass. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11445] it is possible for duplicate hold notifications to be sent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11445 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Katrin Fischer changed: What|Removed |Added Attachment #23836|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 23841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23841&action=edit [PASSED QA] Bug 11208: If no smsalertnumber is defined, the message is marked as failed For DUE message (and PREDUE, etc.) there are no check before sending the message to the message_queue table. This check avoids to try to send again and again the same message. Now it is marked as "failed". Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Without the patch a sms notice will remain as 'pending' forever. With the patch applied, the status is set to 'failed'. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #22 from Katrin Fischer --- I am stumbling over this bug report again and again, wondering what it is about as the subject is not really telling much. After reading the comments I think this would have been a bit better as 2 separate bug reports, one for the CSV and one for the HTML output change. I agree with Jonathan about the change to the itemscontent default as this would be an unexpected change for a lot of libraries. Also itemnumber and branchname are not useful for a lot of libraries. -my $itemscontent = join( ',', qw( date_due title barcode author itemnumber ) ); +my $itemscontent = join( ',', qw( itemnumber issuedate date_due title barcode author itemcallnumber branchname ) ); It looks like this is hiding a 3rd feature even: +SELECT biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue, branchname + FROM issues,items,biblio, biblioitems, branches b Making ist possible to put the branchname instead of the branchcode into the output of items? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
