[Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- When items are created on order (AcqCreateItem = on order) the subfields of those items will be updated as set in this preference automatically during the receive process. For example this will allow to remove the 'on order' status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486
--- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 24206
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24206
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC
Review of attachment 24206:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=10486attachment=24206)
-
Hi Jesse, I got curious and took a look at the code. Looks mostly good (as far
as I can tell), but I spotted some translation issues in the templates. Could
you take a look please?
::: C4/Search.pm
@@ +72,4 @@
GetDistinctValues
enabled_staff_search_views
PurgeSearchHistory
+ GetExternalSearchTargets
New routine - being super strict I would expect some unit tests :)
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/external-targets.tt
@@ +27,5 @@
+$( '#targets tr[data-targetid=[% saved_id %]]' ).addClass( 'updated' );
+[% END %]
+
+$( '#targets .delete' ).click( function() {
+return confirm( _( 'Are you sure you wish to delete this target?' )
);
Please use else a translation using ' can break the Javascript code.
::: koha-tmpl/opac-tmpl/prog/en/modules/opac-external-search.tt
@@ +67,5 @@
+} );
+}
+
+function search( offset, reset_search ) {
+$( '#pazpar2-status' ).html( 'Searching external targets... img
class=throbber
src=/opac-tmpl/lib/jquery/plugins/themes/classic/throbber.gif //span' );
'Searching external targets' is untranslatable. Marking all spotted translation
problems with 'T'.
@@ +77,5 @@
+}
+
+function callback( data ) {
+if ( data.error ) {
+$( '#pazpar2-status' ).html( 'strong class=unavailableError
searching external targets./strong' );
T
@@ +82,5 @@
+return;
+}
+
+if ( !data.total ) {
+$( '#pazpar2-status' ).html( 'strongNo results found in the
external targets./strong' );
T
@@ +88,5 @@
+}
+
+$( '#results tbody' ).empty();
+
+$( '#pazpar2-status' ).html( 'strong' + _( 'Found ' ) + data.total
+ _( ' results in ' ) + $( '#targets-facet input:checked' ).length + _( '
external targets.' ) + '/strong' );
T (single quotes). Also a bit hard to translate, as this will be split up in
the translation file.
@@ +104,5 @@
+
+if ( resultRenderCache[ hit.recid[0] ] ) {
+results.push( resultRenderCache[ hit.recid[0] ] );
+} else {
+results.push( hit['md-work-title'] ? hit['md-work-title'][0]
: 'Loading...' );
T
@@ +131,5 @@
+var cur_page = data.start / results_per_page;
+var max_page = Math.floor( data.total / results_per_page );
+
+if ( cur_page != 0 ) {
+pages.push( 'a class=nav href=# data-offset=' + (offset -
results_per_page) + 'lt;lt; Previous/a' );
T
@@ +143,5 @@
+}
+}
+
+if ( cur_page max_page ) {
+pages.push( ' a class=nav href=# data-offset=' + (offset +
results_per_page) + 'Next /a' );
T
::: koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ +319,4 @@
}
+
+first_succeeded = true;
+FinishExternalSearch( 'pazpar2', _(Found __LINK__ in ) +
num_targets + _( external targets), data.total,
'/cgi-bin/koha/opac-external-search.pl?q=' + escape( querystring ) );
This looks interesting. Maybe a replacement like __LINK__ could make
translating the sentences easier.
::: opac/opac-external-search.pl
@@ +17,5 @@
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+use strict;
+use warnings;
Could be using Modern Perl instead.
::: opac/opac-search.pl
@@ +884,5 @@
+$template-{VARS}-{OPACSearchExternalTargets} =
C4::Context-preference('OPACSearchExternalTargets');
+$template-{VARS}-{external_search_targets} = GetExternalSearchTargets(
C4::Context-userenv ? C4::Context-userenv-{branch} : '' );
+
+$template-{VARS}-{OverDriveLibraryID} =
C4::Context-preference('OverDriveLibraryID');
I think some of those lines could now be replaced using the TT plugin for
looking up the system preferences from the template. Just noting, it's ok to
leave it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am sorry, but I can't seem to reproduce the bug on current master. I followed the test plan, but my holds queue entry is the same before and after applying the patch. 1) Create a test record with 2 items with different itemtypes Branches, itemtype, barcode Midway, Books, t1 Midway, Computer files, t2 2) Set the Default holds policy by item type for the first item to From any library Midway: Books, from any library 3) Set the Default holds policy by item type for the second item to From home library Midway: Computer files, from home library 4) Place a record level hold for a patron from another library, but for pickup at the same library as the item is from Switched to Riverside, placed a title level hold for a Riverside patron, pickup location is Midway. 5) Rebuild the holds queue Entry reads: Books, t1 or any available 6) View the holds queue, note the item is listed, though this patron cannot place a hold on this item I couldn't reproduce this. 7) Apply this patch 8) Repeat step 5, note the hold is no longer in the queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Working on this now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some notes: 1) The feature is activated by default on updated installations. I think it would be better to only activate it on new installations. 2) The return date defaults to today 23:59. Wouldn't it make more sense to default to yesterday 23:95? And consequently, should we allow setting return dates in the future? 3) If you use the date the plugin suggests, check the checkbox for keeping the date and then submit the form with empty barcode or return a book, following error occurs: Template process failed: undef error - Can't use string () as a HASH ref while strict refs in use at /home/katrin/kohaclone/Koha/Template/Plugin/Borrowers.pm line 47. It also happens with a return date in the past, book was not checked out. X) We have the same problem here as we have on bug 10995. For accessibility reasons we should allow manual entry of the date and time, but we need to catch the errors. If you enter an invalid date now, you get a nasty perl error. I got: Can't call method ymd on an undefined value at /usr/share/perl5/DateTime/Format/MySQL.pm line 84. Failed for 2) and 3). X) is kind of a difficult one. I really think we need a general solution here, but not sure how to achieve it. Not going to fail for that right now, but welcoming ideas. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10807] OPAC: There is no authority search history
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, I am sorry, but there are too many conflicts outside of updatedatabase. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Team Lyon, there is an open question from Jonathan in comment 25 - could you please take a look? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11389] re-enable PostgreSQL as a database scheme that Koha can connect to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11389 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23885|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 24212 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24212action=edit [PASSED QA] Bug 11389: reenable Pg as a DB scheme that Koha can connect to This patch restores the ability to request a DBI database handle or a DBIx::Class schema object connected to a PostgreSQL database. To address the concerns raised in bug 7188, only mysql and Pg are recognized as valid DB schemes. If anything else is passed to C4::Context::db_scheme2dbi or set as the db_scheme in the Koha configuration file, the DBD driver to load is assumed to be mysql. Note that this patch drops any pretense of Oracle support. To test: [1] Apply patch, and verify that the database-dependent tests pass when run against a MySQL Koha database. [2] To test against PostgreSQL, create a Pg database and edit koha-conf.xml to set db_scheme to Pg (and adjust the other DB connection parameters appropriately). The following tests should pass, at minimum: t/Context.t t/db_dependent/Koha_Database.t Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, some additional notes: - Installed Postgres following http://wiki.ubuntuusers.de/PostgreSQL - Created a database user koha - Created a database koha - Changed the koha-conf.xml file db_schemePg/db_scheme databasekoha/database hostnamelocalhost/hostname port5432/port userkoha/user pass/pass - Installed libdbd-pg-perl - Ran the web installer until step 3 everything looked ok Step 3 complains: Password for user koha: psql: fe_sendauth: no password supplied - Both t/Context.t and t/db_dependent/Koha_Database.t pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6254] can't set patron privacy by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6254] can't set patron privacy by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254
--- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 23987
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23987
Bug 6254 [QA Followup 1] - can't set patron privacy by default
Review of attachment 23987:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6254attachment=23987)
-
Kyle, we are really almost there, but there is a translation problem:
::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
@@ +276,5 @@
+trth scope=rowEnrollment fee: /thtd[%
category.enrolmentfee | format('%.02f') %]/td/tr
+trth scope=rowReceives overdue notices: /thtd[% IF
( category.overduenoticerequired ) %]Yes[% ELSE %]No[% END %]/td/tr
+trth scope=rowLost items in staff client/thtd[% IF
( category.hidelostitems ) %]Hidden by default[% ELSE %]Shown[% END
%]/td/tr
+trth scope=rowHold fee: /thtd[%
category.reservefee | format('%.02f') %]/td/tr
+trth scope=rowDefault privacy: /thtd[%
category.default_privacy %]/td/tr
I think this should be a SWITCH making the never, forever and default
translatable. The configuration page already does it correctly.
@@ +404,5 @@
No limitation
[% END %]
/td
+td
+[% loo.default_privacy %]
And here.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #24035|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 24213 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24213action=edit [PASSED QA] Add the borrower's cardnumber and phonenumber to the branch overdues. http://bugs.koha-community.org/show_bug.cgi?id=11359 Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com All tests pass, this adds data to the Patron column on the overdues with fines report to show the patron's cardnumber and phone number. Signed-off-by: Katrin Fischer katrin.fischer...@web.de This works as described and passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11359] Add cardnumber and phonenumber columns to the branch overdues circulation report.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11359 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- An idea: If we made the line breaks (br) dependent on the existance of the phone number/email address we could save some space. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11477] Add names for librarian and borrowers in the logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11477 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23926|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 24214 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24214action=edit [PASSED QA] Bug 11477 - Add names for librarian and borrowers in the logs This patch adds the first name and surname of the librarian and the user involved in a transaction log, if available. If neither the firstname or the surname is available, then the 'object' number will be prefaced with the 'Member' qualifier. _TEST PLAN_ 0) This patch depends on Bug 11473, so you must apply it first Before applying this patch (11477): 1) View the logs. 2) Note that the Librarian column just has a number 3) Note that the Object column will just say Member X (where X is a number), in the circulation, fines, and patron/member modules. Apply the patch. 4) Reload the logs (you don't need to make new ones) 5) Note that the Librarian and Object columns mentioned above now have firstname and surname appearing (where available) Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10318] show email on patron search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10318] show email on patron search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23991|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 24215 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24215action=edit [PASSED QA] Show primary email in patron search results Now showing primary email address of a patron in the patron search results page added mailto link to the email address http://bugs.koha-community.org/show_bug.cgi?id=10318 Signed-off-by: Melissa Lefebvre meli...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, template only change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|oleon...@myacpl.org |olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #23892|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #24034|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 24216 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24216action=edit [PASSED QA] Bug 11466 - Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes' -- -- Synopsis -- -- When system preference AdvancedSearchTypes has other values than 'itemtypes', for ex 'itemtypes|loc', itemtypes selection in opac-suggestions.pl is not populated with available itemtypes. This patch fixes the issue by broadening the strict comparison of ($advanced_search_types eg 'itemtypes') #fails 'itemtypes|loc' to ($advanced_search_types =~ 'itemtypes') #succeeds 'itemtypes|loc' Unit tests included --- -- Test plan -- --- REPLICATING THE ISSUE 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type select dropdown list 2.1. List should have only the default value AFTER APPLYING THIS PATCH 1. Set system preference AdvancedSearchTypes to itemtypes|loc 2. Go to opac-suggestions.pl and observe Item type select dropdown list 2.1. List should have itemtypes available for selection Thanks for testing! You are awesome! gg Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com Tests worked as expected. Placed a suggestion and saw the whole list of item types, chose one, saved, checked staff and it loaded as expected. Changed item type in staff and it applied in both views. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described, passes all tests including new regression tests. Restores old functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11466] Purchase suggestion itemtypes, only default available if AdvancedSearchTypes not equal 'itemtypes'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11466 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
Katrin Fischer katrin.fisc...@bsz-bw.de changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #25 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Kyle,
there is a conflict in Branches.pm. I tried to resolve it, but started
wondering about @bind_parameters. You remove the push line, so it never gets
assigned, but is used later on. Also I think we should use ? instead of
$branches.
my $query=SELECT * FROM branches;
my @bind_parameters;
if ($onlymine C4::Context-userenv C4::Context-userenv-{branch}){
- $query .= ' WHERE branchcode = ? ';
- push @bind_parameters, C4::Context-userenv-{branch};
+ my $branches = GetIndependentGroupModificationRights({ stringify = 1
});
+ $query .= qq{ WHERE branchcode IN ( $branches ) };
}
$query .= ORDER BY branchname;
$sth = $dbh-prepare($query);
$sth-execute(@bind_parameters);
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9858] Add button in Search Engine Configuration is not working.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 --- Comment #2 from Samuel Crosby scrosby...@gmail.com --- Nevermind, was a problem on my end. I created the directories through root, and mykoha-koha couldn't write to the indexes file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11503] Several typos
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Assuming cataloguer should become cataloger and canceled should become cancelled, I have no problem. I confirmed the variable is finesCalendar. Those changes being more of an American spelling, which I suspect en is supposed to be. I'm going to sign this off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Neither Jonathan nor I are native speakers - maybe just make a suggestion what would sound better to you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11503] Several typos
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #24161|0 |1 is obsolete|| --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Created attachment 24217 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24217action=edit [SIGNED OFF] Bug 11503 - Several typos This patch corrects several typos: Some reported in Bug 11503, others found during a systematic spell check of the help files. To test, examine the changes and confirm that the spelling changes are correct. Signed-off-by: Mark Tompsett mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11525] New: No way to turn off search word hilighting in staff UI by default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11525 Bug ID: 11525 Summary: No way to turn off search word hilighting in staff UI by default Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com There is no way to turn off the search word hilighting in the staff UI by default. The syspref OpacHighlightedWords doesn't seem to apply to the staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11503] Several typos
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11503 --- Comment #6 from Bob Birchall b...@calyx.net.au --- (In reply to M. Tompsett from comment #3) Take note of the one's I didn't put Check or Okay on. I did suggest another edit as well. There were American vs. non-American English questions in my mind. What is it supposed to be? US usage is 'catalogers'; usage in other english speaking countries is 'cataloguers' - should prolly be left with US spelling and changed in translations. 'Cancelled' seems to be used everywhere except in US, but even there it may not be consistent. I saw 'canceled' used by the NY Times and Seattle Post however Avis website has 'cancelled'. I saw other .com websites with 'cancelled' but maybe not all are US sites? 'finesCalendar' is a reference to the sys pref, not to the object of the sys pref, and so is correct, imo. I think a comma after 'For example' is not necessary, but would not be incorrect either. I hope this helps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11526] New: search word hilighting does not handle multi-word phrases well
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11526 Bug ID: 11526 Summary: search word hilighting does not handle multi-word phrases well Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org Do a multi-word phrase search. The results page will highlight all instances of the searched words, even when the word is simply a fragment of other word. for example 'kw,phr: a world' will highlight every 'a' in the search results, even in the middle of words. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11254] breeding search must normalize ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11254 --- Comment #3 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to M. Tompsett from comment #2) This eyeballs well, but step-by-step instructions would really help. There is a test plan into patch comment : Subject: [PATCH] Bug 11254 - breeding search must normalize ISBN When importing records, the ISBN is normalized and stored into database (see C4::Breeding::ImportBreeding). But when searching with ISBN into reservoir, it is not normalized (see C4::Breeding::BreedingSearch). So search does not match. This patch adds the normalisation to breeding search. Also replaces call private method _isbn_cleanup by GetNormalizedISBN, the correct public method. Also allows the breeding search on ISBN with hyphens. Test plan : - Import a record with ISBN 13 with hyphens. ie 978-2-8153-0357-6 - Go to cataloguing : cataloguing/addbooks.pl - Enter ISBN 13 with hyphens. ie 978-2-8153-0357-6 = the imported record is found - Enter ISBN 13 without hyphens. ie 9782815303576 = the imported record is found - Enter normalized ISBN. ie 2815303574 = the imported record is found -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11516] OPAC highlight lost in results browser
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11516 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com --- (In reply to Kyle M Hall from comment #6) The choice to unhighlight search terms is not remembered when moving between pages. If this is not an issue, please reset status to Signed off. The Unhighlight link is a JavaScript function. I think it is used only some times to maybe have a clearer look at record datas. So in my opinion, this choice should not be remembered when moving to another result. Note that in results page, unhighlight choice is not remembered when moving to another results page. (but not in the Browse results but perhaps it's normal...).(In reply to Aurélie Fichot from comment #5) but not in the Browse results but perhaps it's normal... It is normal. It would be to much highlight in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
