[Koha-bugs] [Bug 11638] New: Untranslatable "Tag editor" in addbiblio.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11638 Bug ID: 11638 Summary: Untranslatable "Tag editor" in addbiblio.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr addbiblio.pl has a hard-coded (and therefore untranslatable) "Tag editor" text. It appears in two places in the code. Also: print "Content-Type: text/html\n\nERROR when DELETING BIBLIO $biblionumber : $error"; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Chris Cormack changed: What|Removed |Added Attachment #24871|0 |1 is obsolete|| --- Comment #12 from Chris Cormack --- Created attachment 24878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24878&action=edit Bug 11534 - impossible to remove instructors on course reserve In some cases clicking the "remove" link to remove a course instructor when editing a course reserves course doesn't work. I suspect this is caused by leading zeroes in the card number. This patch refactors the relevant function to fix the problem and to remove inline JavaScript from generated markup. Other changes: - Make the "Remove" text translatable - Re-order the first name and last name when added by JavaScript to match the template's "surname, firstname" order. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Course reserves and add or edit a course. 3. If you are editing a course and there are existing instructors, click the "remove" link. Nothing will happen. 4. Perform a patron search and choose one of the results. The name should be added to the list of instructors in the format "surname, firstname." 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and repeat step 4. The "remove" link should work. 7. Add an instructor and save the course reserve. Repeat steps 2 and 3. The "remove" link should now work. To test the translation fix, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for course_reserves/course.tt. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 M. Tompsett changed: What|Removed |Added Attachment #24868|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 24877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24877&action=edit [SIGNED OFF] Bug 11635 - 995$r defined twice in record.abs For UNIMARC flavor, in record.abs, 995$r defined twice. Test plan : - Create a fresh install UNIMARC flavor and GRS1 indexing for biblios - Re-indexe database - Perform a search with index "itemtype" (and then "itype") on an existing value of 995$r. For example : itemtype:BOOK => Check you get results Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- Eyeballing it, I can see it is duplicated. Branched based on origin/master Fully reindexed OPAC searched for itemtype:dpn and itype:dpn -- 631 results Applied patch Fully reindexed OPAC searched for itemtype:dpn and itype:dpn -- 631 results cp ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs.bak cp ./etc/zebradb/marc_defs/unimarc/biblios/record.abs ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs Fully reindexed OPAC searched for itemtype:dpn and itype:dpn -- 631 results git reset --hard origin/master Fully reindexed OPAC searched for itemtype:dpn and itype:dpn -- 631 results my reindexing gave my lots of warnings, but it was about indexing tags not found in attset(s). I figure I can ignore those. I think my test covers it. I'm signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #22 from Robin Sheat --- (sorry, attached them the wrong way around due to expecting git bz to work like most git commands.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #21 from Robin Sheat --- Created attachment 24876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24876&action=edit Bug 11592 - opac scripts do not respect marc tag visibility Added two functions to C4/Biblio: GetFilteredOpacBiblio and GetOpacHideMARC. GetFilteredOpacBiblio returns a MARC::Record stripped of all the fields and subfields which are supposed to be hidden in OPAC. GetOpacHideMARC returns a hash of whether a particular key (eg. title, subtitle, etc.) is hidden. A value of 0 means no, a value of 1 means hidden. Made GetCOinSBiblio function handle hiding of 245$a more gracefully. Also, modified GetMarcSubjects to not generate an array entry of empty values. Tweaked C4/XSLT.pm to delete a field, if there weren't any subfields to actually update with. Properly hid 245$a, in the case that there is no visibility for OPAC, for opac-MARCdetail. opac-detail now filters the MARC::Record according to the hidden value in marc_subfield_structure properly. It also corrects a couple minor issues with a parameter not passed being used in a concatenation. How the subtitle values calculation works changed. It is now based on marc_subfield_structure and not fieldmapping. And, the GetBiblioData hash that generates template variables is now filtered by the results of a GetOpacHideMARC call. The opac-showmarc page now converts the MARCXML record to a MARC::Record to easily filter using GetFilteredOpacBiblio, which is then turned back into MARCXML for processing. The opac-export script now filters the biblio record to match what is currently displayed. Added tests to t/db_dependent/Biblio.t to test the functionality of the two functions added into C4::Biblio. Added a GetFilteredOpacBiblio call into opac-ISBDdetail page, so that it should be filtered. TEST PLAN - 1) Backup DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8) Refresh the opac-MARCdetail page in OPAC -- what you hid should be mostly hidden TITLE will still display, even if you hide 245$a! 9) Click Normal view, and all the hidden things are still mostly showing! 10) The steps should be done with OPACXSLTDetailsDisplay set to default (or some custom one?). 11) Refresh the opac-detail page. Still mostly showing all the hidden things. 12) Click MARC view, and everything should be hidden... 13) Until you click the 'view plain' link. 14) Apply the patch. 15) Run the Koha QA test tool. 16) Refresh the opac-MARCdetail page. Title should hide now. 17) Click the 'view plain' link. -- LDR and 999$c and 999$d were displaying for me. I realized that I hadn't hidden 999, because the opac-MARCdetail page doesn't display it. LDR is the only known leak. 18) Click Normal view 19) Now all the opac-detail page should hide things just like the opac-MARCdetail page. 20) In the staff client, change the OPACXSLTDetailsDisplay to a blank value. 21) Recheck opac-detail and opac-MARC detail pages again, including the view plain link, and everything should hidden similarly. -- NOTE: LDR is the only known leak. NOTE: 952 fields are treated separately, so I don't believe they could be hidden in the table using the MARC visibility. The goal was hiding properly things above the items. 22) And lastly, attempt to Save record in the various formats using the dropdown and clicking Go. -- The results should be filtered. 23) Click on ISBD view to ensure nothing broke. 24) Restore DB, because hiding 000,003,005,008,020,040,245,etc. are not useful across an entire framework. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Robin Sheat changed: What|Removed |Added Attachment #24663|0 |1 is obsolete|| Attachment #24664|0 |1 is obsolete|| --- Comment #20 from Robin Sheat --- Created attachment 24875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24875&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11579] The ordernumber is not displayed on the basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11579 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Julian! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #38 from M. Tompsett --- Please test with /cgi-bin/koha/opac-password-recovery.pl?uniqueKey=OneThatDoesNotExist 404.pl is not the correct behaviour, in my opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tomás Cohen Arazi changed: What|Removed |Added Attachment #24490|0 |1 is obsolete|| --- Comment #65 from Tomás Cohen Arazi --- Created attachment 24874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24874&action=edit Bug 11096: (follow-up) add direct regression tests This adds direct tests of indexing and retrieving bib records that are larger than the ISO2709 limit of 99,999 octets. To test: verify that prove -v t/db_dependent/Search.t passes. Signed-off-by: Galen Charlton Signed-off-by: Tomas Cohen Arazi Signed-off-by: Chris Cormack Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11637] No way to prevent a prediction date for the next issue in serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 Francois Charbonnier changed: What|Removed |Added CC||franch...@gmail.com --- Comment #2 from Francois Charbonnier --- Created attachment 24873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24873&action=edit Irregular pattern example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11637] No way to prevent a prediction date for the next issue in serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 --- Comment #1 from Francois Charbonnier --- I confirm. Now, irregular patterns show the first issue publication date for each issue in the prediction pattern. Before, Koha used to display XXX instead, which was maybe more handy since one cant predict the issue dates with irregular patterns... See attachment "irregular_pattern.png" for an example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tomás Cohen Arazi changed: What|Removed |Added Attachment #24490|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tomás Cohen Arazi changed: What|Removed |Added Attachment #24731|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #37 from M. Tompsett --- You forget to delete the password reset entry after resetting the password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Katrin Fischer changed: What|Removed |Added Depends on||11637 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11637] No way to prevent a prediction date for the next issue in serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 Katrin Fischer changed: What|Removed |Added Blocks||11576 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11637] New: No way to prevent a prediction date for the next issue in serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11637 Bug ID: 11637 Summary: No way to prevent a prediction date for the next issue in serials Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com This needs more testing, but I think we have lost a feature in serials: It used to be possible to create a frequency/prediction pattern where no date was created for the next issue. Instead it would show XXX in some places. That was for serials where you had no idea about when the next isssue would arrive. It doesn't seem to be possible now in serials to do that. When testing an irregular pattern, for all issues today's date is shown and there is also always a date set for the next predicted issue. Maybe I am missing something - please comment :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Owen Leonard changed: What|Removed |Added Attachment #24194|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 24872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24872&action=edit [SIGNED-OFF] Bug 11495: Make "Select titles to: " translatable Fixes translation of "Select titles to: " on the Bootstrap OPAC result page. Test plan: - Update one of the po files running: perl translate update - Verify that "Select titles to: " is only listed once for search-results.tt Apply patch - Verify addings titles to lists and cart from the result list still works as expected - Rerun the po file update - Verify the string is now listed twice for search-results.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text "Select titles to: " in bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #38 from Benjamin Rokseth --- No worries Marcel! Rookie in patch signoffs, and strugglig behind company firewalls, so wasn't able to signoff via git-bz. Also noting that you're still working on this, so will keep hands off this one for now. Enough of others waiting signoff... Glad you're working on the public APIs, by the way, would love to see some work on a JSON API for Holds, Reservations, etc. in the line of : https://github.com/biblibre/koha-restful & https://github.com/clrh/koha-restful All the best! Benjamin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944 Liz Rea changed: What|Removed |Added Attachment #24633|0 |1 is obsolete|| --- Comment #21 from Liz Rea --- Comment on attachment 24633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24633 Bug 10944 - opac-user and opac-readingrecord had instances of non-https amazon images I think the amazonTLD preference isn't working properly, so I'll submit a new patch without that additional change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #11 from Owen Leonard --- (In reply to Marjorie Barry-Vila from comment #10) > There is no number in the cardnumber I used, there is only letters... That's good to know. My patch should fix the problem for both of us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #10 from Marjorie Barry-Vila --- Owen, I understood why i did not be able to remove my instructors. There is no number in the cardnumber I used, there is only letters... I tested it with a cardnumber with numbers (without leading zero) and it works! So, a cardnumber can contain letters? Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable "manage" in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Owen Leonard changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11595] Untranslatable error messages in rotating collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11595 Owen Leonard changed: What|Removed |Added Depends on||8836 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Owen Leonard changed: What|Removed |Added Blocks||11595 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 Owen Leonard changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #9 from Owen Leonard --- Created attachment 24871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24871&action=edit Bug 11534 - impossible to remove instructors on course reserve In some cases clicking the "remove" link to remove a course instructor when editing a course reserves course doesn't work. I suspect this is caused by leading zeroes in the card number. This patch refactors the relevant function to fix the problem and to remove inline JavaScript from generated markup. Other changes: - Make the "Remove" text translatable - Re-order the first name and last name when added by JavaScript to match the template's "surname, firstname" order. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Course reserves and add or edit a course. 3. If you are editing a course and there are existing instructors, click the "remove" link. Nothing will happen. 4. Perform a patron search and choose one of the results. The name should be added to the list of instructors in the format "surname, firstname." 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and repeat step 4. The "remove" link should work. 7. Add an instructor and save the course reserve. Repeat steps 2 and 3. The "remove" link should now work. To test the translation fix, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for course_reserves/course.tt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11145] creating a guided report in non-english language fails
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145 michel changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |WISHLIST --- Comment #9 from michel --- Hi, i solved the problem by upgrading to koha 3.14 and rerunning the translation process with the command perl translate install fr-FR i already used this fix to solve problems when upgrading -- but i'm not sure which problems, maybe the "search by keyword" not working anymore. Maybe reruning the translation(s) automatically when updating could be put in the wish list ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Owen Leonard changed: What|Removed |Added Blocks||11632 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 --- Comment #1 from Owen Leonard --- Created attachment 24870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24870&action=edit Bug 11636 - Impossible to remove patrons from patron list during add process If you patrons have card numbers with leading zeroes this causes problems removing patron entries during the process of adding patrons to an existing list. This patch refactors the relevant JavaScript to correct the problem and to remove inline "onclick" from generated HTML. This patch also includes a fix for Bug 11632 - Untranslatable string "Remove" in patron lists. To test: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Tools -> Patron lists. 3. Click "Add patrons" on an existing list. 4. Perform a patron search and choose one of the results. 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. 6. Apply the patch and test again. The "remove" link should now work. To test the fix for Bug 11632, after applying the patch run "translate update [language code]" and confirm that the "Remove" string is listed in the updated po file for patron_lists/list.tt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11632] Untranslatable string "Remove" in patron lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||11636 Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11636] Impossible to remove patrons from patron list during add process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Owen Leonard changed: What|Removed |Added Component|Course reserves |Tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11636] New: Impossible to remove patrons from patron list during add process
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11636 Bug ID: 11636 Summary: Impossible to remove patrons from patron list during add process Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P3 Component: Course reserves Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org This problem affects libraries where patron card numbers include leading zeroes, for example "0001234." To reproduce: 1. If necessary, create or modify a patron to have a card number with leading zeroes. 2. Go to Tools -> Patron lists. 3. Click "Add patrons" on an existing list. 4. Perform a patron search and choose one of the results. 5. Click the "remove" link next to the patron name which was just added. Nothing will happen. See also Bug 11534. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #8 from Marjorie Barry-Vila --- Hi Owen, No there is no zeroes in patron card number. See the capture for the link when i do a hover on "remove". Liz, do you see the same? Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #7 from Marjorie Barry-Vila --- Created attachment 24869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24869&action=edit link remove instructor course reserve -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 Fridolin SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 --- Comment #1 from Fridolin SOMERS --- Created attachment 24868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24868&action=edit Bug 11635 - 995$r defined twice in record.abs For UNIMARC flavor, in record.abs, 995$r defined twice. Test plan : - Create a fresh install UNIMARC flavor and GRS1 indexing for biblios - Re-indexe database - Perform a search with index "itemtype" (and then "itype") on an existing value of 995$r. For example : itemtype:BOOK => Check you get results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11635] New: 995$r defined twice in record.abs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11635 Bug ID: 11635 Summary: 995$r defined twice in record.abs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: fridolyn.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org For UNIMARC flavor, in record.abs, 995$r defined twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11534] impossible to remove instructors on course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11534 --- Comment #6 from Owen Leonard --- Marjorie do your patron card numbers have leading zeroes? I suspect that's why Liz can't reproduce the error but I can. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11394] "Routing lists" -tab vanishes from patron info bar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11394 Owen Leonard changed: What|Removed |Added Version|unspecified |master Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..."
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Owen Leonard changed: What|Removed |Added Attachment #24460|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 24867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24867&action=edit [SIGNED-OFF] Bug 11488 Untranslatable warning "Are you sure you want to write off ..." Test plan: - ./translate update LANG - translate the string into your po file - ./translate install LANG - Verify the string is translated. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11488] Untranslatable warning "Are you sure you want to write off ..."
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11488 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What|Removed |Added Summary|Allow renewal of item with |Allow renewal of item with |unfilled holds if other |unfilled holds if other |available items can fill|available items can fill |that hold |those holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #37 from M. de Rooy --- (In reply to M. de Rooy from comment #36) > benjamin.roks...@kul.oslo.kommune.no changed status to Signed off? > > Could you please clarify? I appreciate your interest in this report, Benjamin. But I take the liberty to reset the status to Needs Signoff in lack of evidence that these two patches have been tested and are ready for QA. Note that I was looking at them too and I will still continue with them. But the changes proposed are certainly not trivial and concern an area (Circulation/Holds) which is rather complex and not bug free. At this moment I actually feel that this report is not yet ready for signoff, but this needs some documentation too. To be continued.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] Allow renewal of item with unfilled holds if other available items can fill those holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 --- Comment #1 from Kyle M Hall --- Created attachment 24866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24866&action=edit Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds The current holds behavior in Koha allows a situation like this: - Patron A has an item currently checked out. - Patron B places a hold on the next available copy of that title. - Then Patron A will not be able to renew his item, even if there are other available copies of that title that could potentially fill Patron B's hold. Since this seems unfair to Patron A, we should allow renewal of items even if there are unfilled holds, but those holds could all be filled with currently available items. Test Plan: 1) Apply this patch 2) Create a record with two items 3) Check out the item to a patron 4) Place a hold on the record 5) Note you cannot renew the item for the patron 6) Enable the new system preference AllowRenewalIfOtherItemsAvailable 7) Note you can now renew the item, as all the holds can be satisfied by available items. 8) Place a second hold on the record 9) Note you can no longer renew the item, as all the holds *cannot* be filled by currently available items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11634] New: Allow renewal of item with unfilled holds if other available items can fill that hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11634 Bug ID: 11634 Summary: Allow renewal of item with unfilled holds if other available items can fill that hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The current holds behavior in Koha allows a situation like this: - Patron A has an item currently checked out. - Patron B places a hold on the next available copy of that title. - Then Patron A will not be able to renew his item, even if there are other available copies of that title that could potentially fill Patron B's hold. Since this seems unfair to Patron A, we should allow renewal of items even if there are unfilled holds, but those holds could all be filled with currently available items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11513] Warnings in Patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11513] Warnings in Patron categories
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11513 Owen Leonard changed: What|Removed |Added Attachment #24481|0 |1 is obsolete|| --- Comment #16 from Owen Leonard --- Created attachment 24865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24865&action=edit [SIGNED-OFF] Bug 11513 - Warnings in Patron categories Just going to the patron categories page triggered errors. Running through all the plain options also triggered other warnings. This fix silences them. Discovered tabs I had not corrected by running qa test tool. Some errors which I could not trigger were also fixed, such as line 248 shown by Merllissia Manueli. TEST PLAN - 1) Log in to staff client 2) Click 'Administration' 3) Click 'Patron categories' 4) Click '+ New category' 5) Enter a dummy category and click 'Save' 6) Click 'Edit' for the dummy category. 7) Change a value and click 'Save' 8) Click 'Delete' for the dummy category. 9) Confirm to delete. 10) Review error log, several new warnings 11) Apply patch 12) Run the koha qa test tool. 13) Click 'Home' 14) Click 'Administration' 15) Click 'Patron categories' 16) Click '+ New category' 17) Enter a dummy category and click 'Save' 18) Click 'Edit' for the dummy category. 19) Change a value and click 'Save' 20) Click 'Delete' for the dummy category. 21) Confirm to delete. 22) Review error log, no new warnings Signed-off-by: Owen Leonard Followed test plan, saw no errors in the log after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which require it
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108 Owen Leonard changed: What|Removed |Added Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #36 from M. de Rooy --- benjamin.roks...@kul.oslo.kommune.no changed status to Signed off? Could you please clarify? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Benjamin Rokseth changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||benjamin.roks...@kul.oslo.k ||ommune.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What|Removed |Added Priority|P3 |P5 - low Version|3.14|master --- Comment #35 from M. de Rooy --- Rebasing first.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What|Removed |Added Attachment #22731|0 |1 is obsolete|| --- Comment #33 from M. de Rooy --- Created attachment 24863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24863&action=edit Bug 8918: Calculate hold priority in AddReserve Priority was calculated outside of this sub, in separate places. Priority was not calculated when using ILS-DI. This patch factorize code by putting the priority calculation code into AddReserve. Test plan: 1/ Place multiple holds in staff interface and check the priority is incremented for each hold. 2/ Do the same in OPAC. 3/ Place multiple holds using ILS-DI HoldTitle service: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER and check the priority is incremented for each hold. 4/ Do the same using HoldItem service: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What|Removed |Added Attachment #22732|0 |1 is obsolete|| --- Comment #34 from M. de Rooy --- Created attachment 24864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24864&action=edit Bug 8918: Add a unit test for GetReserveNextRank Rebased on January 29, 2014 (marcelr) Added text on the two 'is'-statements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Blou changed: What|Removed |Added Attachment #24855|0 |1 is obsolete|| --- Comment #36 from Blou --- Created attachment 24862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24862&action=edit Bug 8753 - Add forgot password link to OPAC This includes fix following the most recent comments and a rebasing to 3.15.15 Fixes all comments specified by mtompsett. TEST PLAN: 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. That will cause the link 'Forgot your password' to show up on the welcome page, below connection box. 3) refresh front page, click on 'Forgot your password' and enter a VALID address (one that is associated to an entry in borrowers.email or borrowers.email_pro. 3b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 4) An email should be received at that address with a link. 5) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 6) Go to main page try the new password. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Owen Leonard changed: What|Removed |Added Attachment #24845|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 24861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24861&action=edit [SIGNED-OFF] Bug 11625 - Default to logged in library for circ rules and notices & slips This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11087] Have the fines tab default to pay fines rather than account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087 Holger Meißner changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||h.meissner...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11087] Have the fines tab default to pay fines rather than account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087 --- Comment #2 from Holger Meißner --- Created attachment 24860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24860&action=edit template updates to make the Pay Fines tab the default tab http://bugs.koha-community.org/show_bug.cgi?id=11087 Signed-off-by: Holger Meißner -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11351] Add support for SIP2 media types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11351 Petter Goksøyr Åsen changed: What|Removed |Added CC||boutrosboutrosboutros@gmail ||.com --- Comment #6 from Petter Goksøyr Åsen --- I'd like to test this, can you rebase? Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8769] Allow SIP2 return backdating
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Petter Goksøyr Åsen changed: What|Removed |Added CC||boutrosboutrosboutros@gmail ||.com --- Comment #13 from Petter Goksøyr Åsen --- I'd like to test this, can you rebase? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9218] intranet cart email broken for non english templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Eric Bégin changed: What|Removed |Added CC||eric.be...@inlibro.com --- Comment #12 from Eric Bégin --- The 'à' character I write in my message (in .po file) or in the comment are not encoded correctly and shows as � even with that patch. It's weird because this seems to be only with that character Other characters (î ç ï û) are ok. Anyone noticed that ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Jonathan Field changed: What|Removed |Added CC||jonathan.field@ptfs-europe. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] New: Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Bug ID: 11633 Summary: Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.fi...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com You cannot use the override function (AllowFineOverride) on “Fines outstanding” on the Staff client because this stops the pay function working on the SelfCheck (SC) machines. The SIP2 devices share this system preference. Test Plan = 1) Set System Preference AllowFineOverride to "Allow". 2) On SIP2 device (e.g. 3M SelfCheck) try paying a fine. We see:- Borrower X had existing fines of 50p (2 x 25p). Attempted to borrow book Y. Chose 'Pay Fines Later' and issue was allowed even with an outstanding (payable) fine. Tried to pay fines SelfCheck Machine asked for correct amount took money but then returned money stating it could not charge account and to enquire at desk. In the SIP2 response, character position 1 & 2 on the 64 response need to be set to Y for the SIP2 device to properly handle the block. 64YYY 00020110614 . In Koha these are only set in two scenarios 1) If the user has expired and 2) if the user is debarred Needs a change in the Members logic the status in the ILS::Patron is setup on the basis of the return from GetMemberDetails it does not set the noissues flag if staff can override (AllowFineOverride option). In the staff client the noissuescharge is applied as part of the checkout transaction in 'CanBookBeIssued'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 Eric Bégin changed: What|Removed |Added CC||eric.be...@inlibro.com --- Comment #1 from Eric Bégin --- I think that we could use the notifications in order to edit the content of the email sent by the cart / lists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11632] New: Untranslatable string "Remove" in patron lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11632 Bug ID: 11632 Summary: Untranslatable string "Remove" in patron lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr In modules/patron_lists/list.tt there's text "Remove" which is not translatable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11631] New: Make translation toolchain ignore useless translatable strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bug ID: 11631 Summary: Make translation toolchain ignore useless translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr Created attachment 24859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24859&action=edit Make i18n toolchain ignore useless strings There are several translatable strings which contain nothing but spaces and placeholders - these are useless for translators. Attached patch makes the translation toolchain ignore such strings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Holger Meißner changed: What|Removed |Added CC||h.meissner...@web.de --- Comment #14 from Holger Meißner --- Created attachment 24858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24858&action=edit Screenshot of downloaded report The download button appears and a text file can be downloaded. But it only contains some kind of reference? See screenshot. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
