[Koha-bugs] [Bug 11844] New: Additional fields for order lines

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Bug ID: 11844
   Summary: Additional fields for order lines
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: new feature
  Priority: P5 - low
 Component: Acquisitions
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Make use of new module Koha::AdditionalField to provide additional fields to
order lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Depends on||10855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25632
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25632action=edit
Bug 11844: Use additional fields for order lines

This patch makes use of new module Koha::AdditionalField to provide
additional fields to order lines.
Once created, these fields can be filled during order line creation or
modification.

If additional field is linked to a MARC field, then
value from biblio record is retrieved at order line creation. When
saving order line (at creation or modification), values in additional
fields are saved into biblio record.
If additional field is linked to an authorised value category, then
authorised values are used. If not directly linked to an authorised
value category, but linked to a MARC field, a search for a AV category
is made on MARC default framework.

This patch doesn't display additional fields value anywhere (except in
order line creation/modification). Future patches will do that.

Test plan:
1/ Go to Acquisitions home
2/ In the left menu, click on Add order line fields
3/ Click on New field button
4/ Give the field a name (unique), no AV category and no MARC field.
5/ Save.
6/ Create 5 other fields:
   a/ no AV category, a MARC field not linked to AV category
   b/ no AV category, a MARC field linked to AV category
   c/ a AV category, no MARC field
   d/ a AV category, a MARC field not linked to AV category
   e/ a AV category, a MARC field linked to another AV category
   In case of (e), the additional AV category should be used, not the AV
   category linked to MARC field
7/ Create everything you need to be able to create order lines
   (supplier, basket, ...)
8/ Create an order line. At bottom of the page, you should see your
   additional fields, with authorised values dropdrown list for fields
   (c), (d) and (e) (check this is the right AV category for (e))
9/ Fill these fields with some data and save order line
10/ check that data was correctly saved into biblio for fields (a), (b),
(d) and (e)
11/ modify the same order line, check that values you've filled is
correctly retrieved.
12/ modify all values, save, and check biblio once again
13/ create a new order line on the same biblio used for previous order
line. check that values are correctly retrieved from biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Blocks||11844

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11845] New: set overlay and import status translatable in addorderiso2709.tt

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845

Bug ID: 11845
   Summary: set overlay and import status translatable in
addorderiso2709.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

In addorderiso2709.tt, the text for overlay and import status come from
database and is not translatable.
Same has Bug 10170.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10170

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values)

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11845

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25633
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25633action=edit
Bug 11845 - set overlay and import status translatable in addorderiso2709.tt

In addorderiso2709.tt, the text for overlay and import status come from
database and is not translatable.
Same as Bug 10170.

Test plan :
- Go to acquisition module
- Display an open basket
- Click on From a staged file
- Look at table
= Without patch, you see codes in Status column : staged, imported, ...
= With patch, you see descriptions in Status column : Staged, Imported, ...
- Click on a Add orders
- Look at table
= Without patch, you see codes in Match? column : no_match, auto_match, ...
= With patch, you see descriptions in Match? column : No match, Match found,
...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11846] New: Correct database update for debarments with 9999-12-31

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

Bug ID: 11846
   Summary: Correct database update for debarments with -12-31
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Database
  Assignee: gmcha...@gmail.com
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

The borrowers with infinite debarments have borrowers.debarred with
'-12-31'.
Database update of Bug 2720 3.13.00.035 contains :
  INSERT INTO borrower_debarments ( borrowernumber, expiration, comment )
SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred
IS NOT NULL
For borrowers where borrowers.debarred is '-12-31', this value is copied
into borrower_debarments.expiration.
This is not correct because borrower_debarments.expiration must be NULL for
infinite debarments.

Set as major because it creates an heavy load on pages displaying this infinite
date (using the TT plugin KohaDates).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11845] set overlay and import status translatable in addorderiso2709.tt

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11845

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #25578|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #51 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I move the follow-up Correct database update for debarments with -12-31
to Bug 11846 in order to ease its management.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #71 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 25634
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25634action=edit
[PASSED QA] Bug 11096: add direct regression tests

This adds direct tests of indexing and retrieving
bib records that are larger than the ISO2709 limit
of 99,999 octets.

To test: verify that prove -v t/db_dependent/Search.t passes.

Signed-off-by: Galen Charlton g...@esilibrary.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #73 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 25636
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25636action=edit
[PASSED QA] Bug 11096: Koha-Zebra should use the XML syntax with DOM

This patch makes Koha - Zebra use MARCXML for the serialization when
using DOM, and USMARC for GRS-1.

* The following functions are modified to set the Zebra record syntax according
to the current sysprefs and configuration:

- C4::Context-Zconn
- C4::Context-_new_Zconn

* A new function 'new_record_from_zebra' is introduced, which checks the
context
we are in, and creates the MARC::Record object using the right constructor.

The following packages get touched to make use of the new function:
- C4::Search
- C4::AuthoritiesMarc

and the same happens to the UI scripts that make use of them (both in the OPAC
and
STAFF interfaces).

* Calls to the unsafe ZOOM::Record-render()[1] method are removed.
Due to this last change the code for building facets was rewritten. And for
performance on the facets creation I pushed higher version dependencies for
MARC::File::XML and MARC::Record (we rely on MARC::Field-as_string).

* Calls to MARC::Record-new_from_xml and MARC::Record-new_from_usmarc are
wrapped with
eval for catching problems [2].

* As of bug 3087, UNIMARC uses the 'unimarc' record syntax. this case is
correctly handled.

* As of bug 7818 misc/migration_tools/rebuild_zebra.pl behaves like:

- bib_index_mode (defaults to 'grs1' if not specified)
- auth_index_mode (defaults to 'dom')

here we do exactly the same.

To test:
 - prove t/db_dependent/Search.t should pass.
 - Searching should remain functional.
 - Indexing and searching for a big record should work (that's what the unit
tests do).
 - Test an index scan search (on the staff interface):
Search  More options  Check Scan indexes.
 - Enable 'itemBarcodeFallbackSearch' and try to circulate any word, it
shouldn't break.
 - Searching for a biblio in a new subscription shouldn't break.
 - Running bulkmarcimport.pl shouldn't break.
 - And so on... for the rest of the .pl files.

Regards
To+

[1] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()
[2] a record that cannot be parsed by MARC::Record is simply skipped (bug
10684)

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #72 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 25635
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25635action=edit
[PASSED QA] Bug 11096: Wrap each test set configuration into a subtest

This makes it easier to read. Also fixes the test count, and is rebased
against 11499 which is needed to correctly test the patches for this bug
(i.e. indexing mode needs to be correctly set in koha-conf.xml)

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #24894|0   |1
is obsolete||
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #24895|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #25282|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11096] Koha cannot retrieve big records from Zebra

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #74 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Setting Passed QA:

1. Ran through the test plan without any failures using marc21 setup.
 - Tested authority searching still works as expected.
 - Tested bilbiographic searching still works as expected.
  - Simple search, also truncated search terms
  - Advanced search, also itemtype and pubyear limits
 - Tested dontmerge preference, editing a linked authority and
   confirming the change is made to the linked records as well
2. Ran db_dependant tests. Success all round
3. Ran through QA script. Success all round

I don't have a working UNIMARC setup, so I've not tested this again unimarc,
however, with Katrin's earlier sign-off climing unimarc was ok, I thought this
OK to pass anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25637
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25637action=edit
Bug 11846 - Correct database update for debarments with -12-31

The borrowers with infinite debarments have borrowers.debarred with
'-12-31'.
Database update for this bug contained :
  INSERT INTO borrower_debarments ( borrowernumber, expiration, comment )
SELECT borrowernumber, debarred, debarredcomment FROM borrowers WHERE debarred
IS NOT NULL
For borrowers where borrowers.debarred is '-12-31', this value is copied
into borrower_debarments.expiration.
This is not correct because borrower_debarments.expiration must be NULL for
infinite debarments.

This patch corrects update 3.13.00.035 and also adds an update for databases
already updated.

Test plan :
- Use a database with verison 3.13.00.000
- Set a borrower as restricted for ever (leave until empty)
- Use sources to master + patch
- Perform updatedatabase
- Look at borrower details, tab Restrictions
= Without patch, you see Expiration 31/12/
= With patch, you see Expiration Infinite

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||11846

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11846] Correct database update for debarments with 9999-12-31

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11846

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Depends on||2720

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11844] Additional fields for order lines

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #25632|0   |1
is obsolete||

--- Comment #2 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25638action=edit
Bug 11844: Use additional fields for order lines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Blocks||11847

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11847] New: Display basketgroup closed date at OPAC

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

Bug ID: 11847
   Summary: Display basketgroup closed date at OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 11169, 11708

Display basketgroup closed date at OPAC under Acquisition Details tab, on
detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25639
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25639action=edit
Bug 11847: Display basketgroup closed date at OPAC

under Acquisition Details tab, on detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Blocks||11847

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #2 from Julian Maurice julian.maur...@biblibre.com ---
Depends on bug 11169 and bug 11708

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25640
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25640action=edit
Bug 11603: Fix delimiter on launching csv2ods

For instance, if the delimiter is ';', quote should be put around.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11840] Editing an item should take you to the editing form

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11840

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Christopher Brannon from comment #0)
 When clicking on an item record to edit, if you have many items in the
 record, it is a huge hassle to have to go to the end of the page to edit the
 record.  It would be nice if, when you clicked on edit, it would take you to
 the form at the bottom of the page.

Hi Christopher,
What about bug 11746?
If you agree on looking in that direction, could you close this bug? Feel free
however to state another opinion..

Marcel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #91 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #88)

Thanks for your quick response and changes.

  At this moment in the process, it is not clear what is used (probably
  only email) and what is not. That makes a push not very obvious?
 I tried to explain the complete feature in a previous email to koha-devel:
 all patches should be reviewed together and pushed together, in order to
 keep thing consistent (for the review, not the same day :))
Sorry, I have seen your email passing by, but it got lost :) Imo it would be
easier to have all information on the report. (Perhaps a document attachment
explaining some thing or so..)

* Functionality: I can imagine that I have filled in multiple transport
  types but want to activate or deactivate some of them. Would you need some
  status on each of them? 
 I am sorry but I don't understand what you mean here.
Now you see the 4 or 5 types (and that could grow..?) But I miss a field like
Status that activates or deactivates the transport type for that notice.
We could also use that status somehow to warn people that activating a certain
type is not useful or even possible when there is no code to support it yet.

* Functionality clash? For Overdue notice (phone notice): I can select all
  transport types. Confusing..
 I don't find this notice in sql files. Normally, with this feature, all
 notices created for a specific transport type, should be moved into the
 main notice. For instance, Overdue notice (phone notice) should be moved
 into the phone template for the Overdue notice.
Yes, that sounds more logical to me. This notice must have come from some
earlier test perhaps..

* From commit: [Currently, only email, sms and print are relevant.] Note
  that you could hide what is not relevant now?
 Maybe someone else would like to implement phone, etc.
 So I did not restrict the mtts to display on the interface.
OK Same comment as above actually: What about not allowing to enable the types
that are not yet supported? 

I do not change the status for now. Appreciate feedback on the questions
raised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9093] 008 forgetting what material type was chosen

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9093

Stefano Bargioni bargi...@pusc.it changed:

   What|Removed |Added

 CC||bargi...@pusc.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11679] Add an ods export choice for reports

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25641
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25641action=edit
Bug 11679: FIX encoding in CSV file

Previously, the CSV file was not in encoded in utf8 and the csv2ods
command failed with the following error if diacritics existed:
  UnicodeDecodeError: 'utf8' codec can't decode byte 0xe9

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11603] Gather print notices: add csv and ods export

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11603

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25642
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25642action=edit
Bug 11603: If a letter code is given, filenames should contain it

If you choose to generate print notices for a specific letter code, the
generated files should be distinct.

The use case is: you want to process print notice for letter codes:
overdue1, overdue2 and overdue3.

The cronjobs will be:

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue1 --csv --ods --html --delimiter=;

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue2 --csv --ods --html --delimiter=;

perl misc/cronjobs/gather_print_notices.pl
/tmp --letter_code=overdue3 --csv --ods --html --delimiter=;

without this patch, the 2 first files will be erased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9016] Multi transport types for notices

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

--- Comment #92 from Jonathan Druart jonathan.dru...@biblibre.com ---
If some transport type are not relevant for someone, he cans completely remove
the mtt in the message_transport_types table.

I don't see a proper way to implement what you propose. For instance, on
tools/overduerules.pl, all notices and mtt are listed. We could imagine a
tricky js stuff for disabling/enabling mtt function of the notice selected. But
is it really useful?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|SRU Responce is different   |SRU Response is different
   |when DOM indexing is|when DOM indexing is
   |enabled |enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I suggest to remove the browser feature from cataloging module.
It works perfectly for catalogue module, but for cataloging module, I think it
can cause too much bugs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817

--- Comment #2 from Owen Leonard oleon...@myacpl.org ---
(In reply to Fridolin SOMERS from comment #1)
 I suggest to remove the browser feature from cataloging module.

What do you mean by the cataloging module? Do you mean the staff client? Can
you please point out the bugs you know of?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25450|0   |1
is obsolete||

--- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25643
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25643action=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link Browse selected biblios  when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the Browse results block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the Browse selected biblios  link
- Check that you are able to browse results you had checked.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25452|0   |1
is obsolete||

--- Comment #57 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25645
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25645action=edit
Bug 10858: FIX error if no biblio is selected

If the user launch a search a directly go to the opac detail page, an
error occurs:

  malformed JSON string, neither array, object, number, string or atom, at
  character offset 0 (before (end of string)) at
  /usr/share/perl5/JSON.pm line 171.

Test plan:
- remove the bibs_selected cookie
- launch a search
- click on a result
- the page should be displayed correctly
(cherry picked from commit 660e8d0437338a5d533d333123b56f0219aec252)

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25451|0   |1
is obsolete||

--- Comment #56 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25644
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25644action=edit
Bug 10858 [Follow-up] Browse selected biblios

This follow-up adds the browse functionality to the CCSR theme and
adds some CSS for the browse link, including a new image in the image
sprite.

To test, apply the patch, clear your cache, and test the browsing
functionality again. Confirm that the browse link looks good and works
correctly in both the prog and CCSR themes.

Signed-off-by: Koha Team Amu koha.aixmarsei...@gmail.com
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Passes koha-qa.pl, works as advertised for prog and ccsr.
Not implemented for bootstrap, but doesn't affect it detrimentally
either. Jonathan plans to open a new bug to implement for bootstrap.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25454|0   |1
is obsolete||

--- Comment #59 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25647
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25647action=edit
Bug 10858: Browse selected biblios - bootstrap

Add the changes from bug 10858 to the bootstrap theme.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the Browse selected biblios  link
- Check that you are able to browse results you had checked.

In addition to prog and ccsr templates, this patch allows to add
selected biblios (from multiple pages) to the cart or a list.
To test:
- check some biblios from several pages
- add them to the cart
- add them to a list

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25455|0   |1
is obsolete||

--- Comment #60 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25648
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25648action=edit
Bug 10858: FIX the Browse selected link

It should be updated on checkbox changes.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25453|0   |1
is obsolete||

--- Comment #58 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25646
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25646action=edit
Bug 10858: Don't use the cookie if the ft is disabled

Is the pref 'OpacBrowseResults' is off, the feature should be completly
off.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25456|0   |1
is obsolete||

--- Comment #61 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25649
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25649action=edit
Bug 10858: FIX Only one occurrence of the biblionumbers should be stored

We have to remove duplicate biblionumber in the array of biblionumbers
stored in the cookie.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25512|0   |1
is obsolete||

--- Comment #63 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25651
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25651action=edit
Bug 10858: fix bad merge conflict

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25514|0   |1
is obsolete||

--- Comment #65 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25653
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25653action=edit
Bug 10858: Handle JS deactivated and cookies disabled

If JS is deactivated, the browse link should not be displayed.
Same if cookies are disabled, the feature does not work.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25513|0   |1
is obsolete||

--- Comment #64 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25652
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25652action=edit
Bug 10858: follow-up Don't use the cookie if the ft is disabled

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #66 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Nice work including QA changes. No complaints from koha-qa. 

Tested prog and bootstrap. Disabled cookies too for a short while :) 

Still found small debatable issue: 
First I selected one record on page 1, page 2 and page 3. After that I selected
all records on page 1. 
It confused me at first to discover that the Browse results on detail are not
in the order of the search results, but apparently in the order of being added
to the list. 
No blocker for me, but we could argue about the order of the list. 

One of the commit messages promised this: 
  In addition to prog and ccsr templates, this patch allows to add 
  selected biblios (from multiple pages) to the cart or a list. 
  To test: 
  - check some biblios from several pages 
  - add them to the cart 
  - add them to a list 
Unfortunately, when I added items from two pages, only the item of the current
page was added. 
Again (with this being my last QA before temporary cutoff date) no blocker for
me :) 
A followup would be pretty on another report though.  

Saw some warnings in the log: 
opac-detail.pl: Use of uninitialized value in concatenation (.) or string at
/usr/share/koha/testclone/opac/opac-detail.pl line 394 
opac-detail.pl: Use of uninitialized value in concatenation (.) or string at
/usr/share/koha/testclone/opac/opac-detail.pl line 400. 
But I have the impression that your patches did not touch these lines.. 

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25457|0   |1
is obsolete||

--- Comment #62 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25650
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25650action=edit
Bug 10858: Replace Browse results with Browse selected results

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

--- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Owen Leonard from comment #18)
 This patch adds a new hint class for displaying information relating
 to a form field. On the list edit screen the hint also has an alert
 class to highlight it.

Owen: What is the exact 'procedure' when making changes now to css file or less
file? Who compiles less to css? You did probably now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25654
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25654action=edit
MT12445: Hide the date_due column

The date due information is useless for in order items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

--- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl ---
The text on the page now on bootstrap is so long actually that it wraps to the
second line showing up not very nice. This pertains to the existing permissions
line too..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25623|0   |1
is obsolete||

--- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25656
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25656action=edit
Bug 10865 [Follow-up] Add style to warning

This patch adds a new hint class for displaying information relating
to a form field. On the list edit screen the hint also has an alert
class to highlight it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11746] Add edit item links to record details page

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

  Attachment #25579|0   |1
is obsolete||
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #25621|0   |1
is obsolete||

--- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 25655
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25655action=edit
bug 10865: (follow-up) allow patrons to make their public lists private when
OpacAllowPublicListCreation is off

This patch ensures that patrons continue to have the ability to make
their public lists private for any public lists they control that were
created before the library turned the OpacAllowPublicListCreation
system preference off.

To test:

[1] Ensure OpacAllowPublicListCreation is on.
[2] As a patron, create a public list in the OPAC.  Also, create
a private list.
[3] Turn OpacAllowPublicListCreation off.
[4] Back in the OPAC, verify that the public list can be edited
and that there are drop-downs for category and permissions.
Also verify that there is a warning that the patron cannot
change it back if they convert a public list to private.
[5] Edit the private list created in step 2.  Verify that the
category and permissions drop-downs are not displayed.

Signed-off-by: Galen Charlton g...@esilibrary.com
Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com
Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865

--- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Galen: I agree with your patch. But note that imo the design still needs some
attention. But since we cannot argue about tastes too much :), anyone is free
to get this to Signed off stage..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #25654|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 25657
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25657action=edit
Bug 11169: Hide the date_due column

The date due information is useless for in order items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #23672|0   |1
is obsolete||
  Attachment #23673|0   |1
is obsolete||
  Attachment #23697|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25658
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25658action=edit
Bug 10694 - Allow arbitrary backdating of returns

Sometimes libraries need to backdate returns further back in time than
Koha's dropbox mode will allow. The returns backdating will check in an
item as if it had been returned on the specified date, and will reduce
any fine accordingly.

Test Plan:
1) Apply this patch
2) Check out an item, and backdate the due date by 1 month or so
   * This issue needs to generate a fine
3) Run fines.pl to generate the fine
4) Browse to returns.pl
5) Specify a return date of the day after the specified due date
6) Check the borrowers issue history, you should see the backdated
   return date, rather than today's date
7) Check the fine, it should be reduced to a fine for a single day
   overdue, rather than the previous larger fine.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com
Signed-off-by: Barbara Knibbs bkni...@farmingtonlibraries.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25660
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25660action=edit
Bug 10694 - Allow arbitrary backdating of returns - QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25659
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25659action=edit
Bug 10694 - Allow arbitrary backdating of returns - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 25661
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25661action=edit
Bug 10694 - Allow arbitrary backdating of returns - QA Followup 3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. de Rooy from comment #66)
 One of the commit messages promised this: 
   In addition to prog and ccsr templates, this patch allows to add 
   selected biblios (from multiple pages) to the cart or a list. 
   To test: 
   - check some biblios from several pages 
   - add them to the cart 
   - add them to a list 
 Unfortunately, when I added items from two pages, only the item of the
 current page was added. 

I just retested right now and it works using the bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #23390|0   |1
is obsolete||

--- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25663
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25663action=edit
Bug 11369 - Too many search cursor cookies overflow HTTP-header size, when
making multiple searches in the staff client.

To replicate this issue, make multiple searches in catalogue/search.pl.
50+ Should be enough to cause the HTTP-request header to overgrow.
One can verify this issue by observing the searchCookie growth in
browser's stored cookies.

-
- TEST PLAN -
-

Keep making searches.
One should never have more than 10 searchCookies. Browser might display only 9,
because for some reason the newest js-generated cookie is not included in
Firefox's cookies listing.


- DRAWBACK -


Removing these cookies disables the search cursor for traversing search
results (next/previous) for the removed cookie. This maybe be problematic
in some cases,
(for ex when multiple search tabs need to be open and they need to be
traversed)
One easy solution is to grow the amount of stored searchCookies from 10 to 20,
but 10 is chosen so there will be plenty of room for other cookies as well.

Signed-off-by: Fridolin Somers fridolin.som...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8044] Localization for Perl scripts and modules

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Blocks||11848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] New: Make Koha::I18N easier to user

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

Bug ID: 11848
   Summary: Make Koha::I18N easier to user
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr
Depends on: 8044

Actually (with bug 8044), to translate a string in a Perl script or module you
have to write:

use CGI;
use Koha::I18N;
my $cgi = new CGI;
my $lh = Koha::I18N-get_handle_from_context($cgi, 'intranet');
print $lh-maketext('my translatable text');

With the patches I'll submit, this will become:

use Koha::I18N;
print gettext('my translatable text');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #23389|0   |1
is obsolete||

--- Comment #6 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25662
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25662action=edit
Bug 11369 - Updating the jquery.cookie.js-plugin

The current jquery.cookie-plugin crashes when trying to fetch all cookies using
$.cookie();
Downloaded the newest plugin version and minified it.
Now works as intended.

Encountered an issue with the plugin now returning null when no cookies are
found,
and applied a fix in browser.js.

-
- Test plan -
-
Plugin is used in browser.js and batchMod.js so testing both

Signed-off-by: Fridolin Somers fridolin.som...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] Make Koha::I18N easier to user

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25664
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25664action=edit
Bug 11848: Move language detection function in C4::Languages

and store interface (intranet, opac) in context to not have to pass it
as parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11849] New: consolidate display of analytic/bound-width analytic item links

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11849

Bug ID: 11849
   Summary: consolidate display of analytic/bound-width analytic
item links
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

At present, if you want to see if an item attached to a host bib is also linked
to another bib, you have to either click the Analytics tab or choose Analyze
items from the cataloging toolbar.  This will cause the Used in column to
display in the holdings table as well as the Create analytics link.

However, we could just display all of the item relationship information all the
time. This would mean that we would remove clicks to see the analytic
relationships and simplify the construction of the holdings table.

Specifically, what I suggest is:

- Remove the analytics tab
- Remove the analyze items toolbar action

When analytics support is turned on:

- Always display the used in column.  Perhaps it could be combined with the
host item column to make a single Analytics or Item relationships column
- move the create analytics link to the actions column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] Make Koha::I18N easier to user

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

--- Comment #2 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25665
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25665action=edit
Bug 11848: Make Koha::I18N easier to use

Instead of writing

  use CGI;
  use Koha::I18N;
  my $cgi = new CGI;
  my $lh = Koha::I18N-get_handle_from_context($cgi, 'intranet');
  print $lh-maketext('my translatable text');

you can now write

  use Koha::I18N;
  print gettext('my translatable text');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11850] New: Bulkmarcimport does not append in logfile

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850

Bug ID: 11850
   Summary: Bulkmarcimport does not append in logfile
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: matthias.meusbur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bulkmarcimport has the -l option, which allows to write to a logfile.

It does work, however, its behavior is not what we expect from a logfile.

Indeed, bulkmarcimport erases the logfile each time it is executed.

The expected behavior imho is to append the logs to the given file.


Test plan:

1) use bulkmarcimport several times with the same logfile given with -l.
2) the logfile is erased every time. - KO

Apply the patch, then:

1) use bulkmarcimport several times with the same logfile given with -l. 
2) the logs are correctly appended to the logfile. - OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I've signed with a few trivial changes : 
  - I've set : scsCookieKeys.length = 10 instead of  to maintain 10 cookies
max.
  - I've removed '' from '//EO Bug_11369' because it is better not using
several '' like in patch conflicts ().

@Jonathan indeed, the could use session but it seems that it tries to use
maximum javascript only.
For me best of all would be using the HTML5 SessionStorage feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11850] Bulkmarcimport does not append in logfile

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11850

--- Comment #1 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 25666
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25666action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10404] Add previous/next browsing to staff client search results

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Blocks||11369

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Depends on||10404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] Make Koha::I18N easier to user

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #3 from Julian Maurice julian.maur...@biblibre.com ---
Test plan (for developpers):

1/ Edit a Perl script, for example mainpage.pl
2/ add use Koha::I18N; to the top of file
3/ add a translatable message somewhere in the script (this have to be after
the call to get_template_and_user). For example:
   warn gettext(This is a translated warning);
4/ Create or update the PO files with
   misc/translator/translate create LANGCODE
or
   misc/translator/translate update LANGCODE
(LANGCODE should be enable in syspref 'languages')
5/ In misc/translator/po/LANGCODE-messages.po you should have your string,
translate it (using a text editor or a PO file editor, make sure you don't have
the fuzzy flag for this string).
6/ Go to mainpage.pl with active language being English with your browser and
check your logs. You should see your string This is a translated warning.
7/ Now change language to LANGCODE. Check your logs, you should have the string
translated.

Note: I chose to name the sub 'gettext' because it's the default keyword for
xgettext for Perl. We can change it to whatever we want.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11848] Make Koha::I18N easier to user

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11848

--- Comment #4 from Julian Maurice julian.maur...@biblibre.com ---
Note 2: The purpose of Koha::I18N is *not* to translate warning messages
(warnings should not be in the language of the person actually using Koha), but
it's the quickest way to test this (I think)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

--- Comment #9 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25667action=edit
Bug 11369 - Correct usage of me.searchid in browser.js

In browser.js, at creation of browser, the searchid is transmited to JS object
into me.searchid.
To be consistant, me.searchid should always be use, never searchid alone.
In browseRecords function, setting searchid as parameter is useless because it
is defined in me.searchid.

Test with test plan of Bug 10404

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11746] Add edit item links to record details page

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Kyle!

However, I am declining to push the second and third follow-ups, as they are
not comprehensive enough -- if a staff user lacks permission to edit items, and
spine label printing is off, and there are no analytics, the last column that
would be made non-sortable would be an item information column.  Leaving the
edit column sortable for now is the lesser evil.

I will open a new bug for setting up an actions column in the holdings table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

  Attachment #24609|0   |1
is obsolete||
 CC||matted-34...@mypacks.net

--- Comment #2 from wajasu matted-34...@mypacks.net ---
Created attachment 25668
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25668action=edit
[SIGNED-OFF] Bug 11598 - Add --text option to overdue_notices similar to --html
option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #3 from wajasu matted-34...@mypacks.net ---
Performed test plan.

Also, compared text output with and without --text
Also, tested --text /tmp  to see if notices file with .txt was written.
Also, tested --html /tmp  to see if notices file with .html was written.
And that the contents looked fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11851] New: holdings table should have action links consolidated into one column

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11851

Bug ID: 11851
   Summary: holdings table should have action links consolidated
into one column
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: gmcha...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

With the push of the patches for bug 11746, depending on the user's permissions
and syspref settings, there can be the following separate columns for
initiating actions on a given item:

- spine label
- edit

These should be consolidated into a single action column, that if present is
non-sortable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11746] Add edit item links to record details page

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746

--- Comment #19 from Galen Charlton gmcha...@gmail.com ---
(In reply to Galen Charlton from comment #18)
 I will open a new bug for setting up an actions column in the holdings table.

Bug 11851.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11689] New missing statuses is not well managed

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11689

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||gmcha...@gmail.com

--- Comment #15 from Galen Charlton gmcha...@gmail.com ---
Particularly in light of the planned use of a constant (+1 to that, BTW), for
this one I'm going to insist on that a regression test be written before I will
push this to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

--- Comment #10 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 25669
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25669action=edit
Bug 11369 - General searchid in browser.js

The search browser fearture uses nearly only the browser.js file.
That is why I propose to move the searchid generation from search.pl to
browser.js.
We then use Date.getTime() to use current timestamp as searchid, prefixed by
'scs_' like before.

Test by using test plan of main patch :
Too many search cursor cookies overflow HTTP-header size, when making multiple
searches in the staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11550] GetOrder returns something even if the order does not exist

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11550

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

 CC||matted-34...@mypacks.net

--- Comment #2 from wajasu matted-34...@mypacks.net ---
Can you rebase. Got merge conflicts, and I'll try again. - wajasu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11369] Too many search cursor cookies overflow HTTP-header size, when making multiple searches in the staff client.

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11369

--- Comment #11 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Two new patches need signoff :
Bug 11369 - Correct usage of me.searchid in browser.js
Bug 11369 - General searchid in browser.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10751] Title should be mandatory for creating suggestions in staff

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10751

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #8 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11707] Additional attributes broken for category code with space

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11707

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11459] [Signed-Off] OrderPdfFormat pref description could be more verbose

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Created attachment 25670
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25670action=edit
[COUNTER PATCH] Bug 11459: use drop-down to set OrderPdfFormat syspref

This patch converts the OrderPdfFormat to a choice.

To test:

[1] Look at OrderPdfFormat in the system preferences editor. Verify
that there is a drop-down giving a choice among the three PDF
basketgroup printing formats.
[2] Change the OrderPdfFormat setting and print a basketgroup.  Verify
that the chosen template is used.

Signed-off-by: Galen Charlton g...@esilibrary.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11459] [Signed-Off] OrderPdfFormat pref description could be more verbose

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton gmcha...@gmail.com ---
The system preferences editor lets one specify a set of choice for a syspref. 
A drop-down makes more sense than asking the user to copy and paste their
chosen value from the system preference, and also makes it less error-prone.

Consequently, I've attached a counter-patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11852] New: Scripted processes

2014-02-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11852

Bug ID: 11852
   Summary: Scripted processes
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Here is a lofty wish...

I wish Koha could have the ability to have scripted processes.

For example.  We don't have holds waiting automatically expire (meaning it
wasn't picked up, not to be confused with a patron set expiration on the
request), simply for the sake that we don't want available items on the hold
shelf unless it has been processed.

For us, this means, after 7 days waiting without being picked up, we pull the
item, we go into the patron account the item was waiting for and put a message
on the account that the item was not picked up.  We then cancel the hold and
check the item in to trigger the next hold or transfer back to the home
library.

It would be a dream to be able to create link to a script that would do all of
this.  For example, we would have a link in the Circulation menu to a script
called Process expired holds.  We then scan the item, and the script puts the
Not picked up message in the patron account, cancels the existing hold for
that patron, and checks the item in to trigger the next hold or transfer on
that item.

I could see this working if there were a way to pass on these tasks to Koha
like events.  Maybe through URLs.  I don't know.  But, it would be wonderful in
streamlining processes.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >