[Koha-bugs] [Bug 11985] New: Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11985 Bug ID: 11985 Summary: Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: imingc...@yahoo.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Automatically insert detail for MARC 005 (Date and Time of Latest Transaction) when saving a new catalog record. Currently, a pop-up message may appears when MARC 005 is left blank as you save a new catalog record. Clear this message, and it automatic insert necessary detail into this field. This should be improved, so user don't have to click into MARC 005 (to insert detail) field as part of cataloguing activity. It should automatically get inserted when the record is saved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11984] New: Show number of item(s) on order in the catalogue holdings without having to create item records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11984 Bug ID: 11984 Summary: Show number of item(s) on order in the catalogue holdings without having to create item records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: imingc...@yahoo.com.au QA Contact: testo...@bugs.koha-community.org In OPAC/staff catalogue, show number of item(s) on order without having to create item record(s). We have opted to create item record only when receive ordered goods, because this allowed us to cancel an order, without also having to delete linked item record(s). Currently item record(s) must be created in order for such information to be presented in OPAC or staff catalogue. Ideally, "On Order" information should be presented similarly to number of reservation(s) attached to each catalogue record, such as: [Qty] on order; or [Qty] on order for [Holding Library 1]; [Qty] on order for [Holding Library 2], etc. Perhaps we then specify whether to show a grand quantity total on order, or quantity breakdown for each holding library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11631] Make translation toolchain ignore useless translatable strings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11631 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #26512|0 |1 is obsolete|| --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 26522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26522&action=edit Bug 11631 - Followup to extend and compile pattern This followup extendes and compile the pattern to test for useless strings To test: Same procedure as signed patch Ammended patch, there is already a place for this check -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 26521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26521&action=edit Bug 11646 - Untranslatable confirm popup in field 006 and 008 builders This patch MARC21 modifies value builders 006 and 008 to make confirm popup translatable To test: 1) Update po files for your preferred language, xx-YY cd misc/translator; perl translate update xx-YY 2) Check that confirm string is NOT present egrep -B3 "Show values for|material type\?" po/xx-YY*po 3) Apply the patch 4) Repeat 1) 5) Repeat 2), now the strings are present Also check that english or translated popup is right -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11646] Untranslatable confirm popup in field 006 and 008 builders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11646 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|NEW |Needs Signoff Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 26520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26520&action=edit Bug 11639 - Untranslatable strings in 007 builder This patch modifies marc21_field_007.tt to make some missing strings translatable To test: 1) Using your preferred language, xx-YY, updatepo files cd misc/translator perl translate update xx-YY 2) Check that missing strings are NOT present egrep -i "exact bit depth|pad with zero|use up to 6" po/xx-YY-i-staff-t-prog-v-3006000.po 3) Apply the patch 4) repeat 1) 5) Repeat 2), check that missing strings are present -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11639] Untranslatable strings in 007 builder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11639 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 26519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26519&action=edit Bug 10818 - System preference OAI-PMH:ConfFile isn't translatable This patch correct english display for OAI-PMH:ConfFile syspref, and makes it's strings translatable To test: 1) On Administration > System preferences > Web Services OAI-PMH:ConfFile syspref doesn't have description before file box. Text after that box is not translated. 2) Choose your prefered language, xx-YY, update po files cd misc/translator perl translate update xx-YY 3) Look into xx-YY-pref.po for any occurence of "YAML", there is none 4) Apply the patch 5) Update po files again 6) Look into xx-YY-pref.po, now there are 2 entries 7) Also reload page from 1) and check for text before file box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10818] System preference OAI-PMH:ConfFile isn't translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10818 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | --- Comment #2 from Bernardo Gonzalez Kriegel --- Not only that text is not translated. Also file description is missing in english. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton --- Pushed to master. Thanks, Jacek! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 --- Comment #11 from Galen Charlton --- I've opened another follow-up bug (bug 11983) regarding the fact that this patron introduces a /second/ implementation of logic to exclude patrons that have non-zero fine-balances (the other is in the patron deletion cronjob) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Galen Charlton changed: What|Removed |Added Depends on||11352 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Galen Charlton changed: What|Removed |Added Blocks||11983 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] New: code to select patrons to purge needs to be centralized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Bug ID: 11983 Summary: code to select patrons to purge needs to be centralized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: gmcha...@gmail.com QA Contact: testo...@bugs.koha-community.org The patch for bug 11352 introduces a routine in tools/cleanborrowers.pl called skip_borrowers_with_nonzero_balance. This filters out patrons who have active fine balances so that the patron purge does not inadvertently delete/trash them. This logic should be put in a central routine, e.g., perhaps in GetBorrowersToExpunge(). At present, misc/cronjobs/delete_patrons.pl also has logic to not purge patrons with fine balances, but it implements it differently. Having two different implementations of the same functionality is not great, but I (in my role as 3.16 RM) allowed it because of the potential for data loss that the patch for bug 11352 fixed. However, this situation should not be allowed to persist. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #26 from Katrin Fischer --- Hi Jacek, thx for checking :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11371] Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11371] Add a new report : Orders by budget
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371
--- Comment #6 from Katrin Fischer ---
Comment on attachment 25915
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25915
[Signed-off]Add the "Orders by budget" report.
Review of attachment 25915:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11371&attachment=25915)
-
Hi Frederick,
I know this has been in the loop for a while already, but I found some things
that I feel should be addressed. I hope my comments are understandable.
I. The QA script points out some things:
QA SCRIPT
testing 1 commit(s) (applied to 7408fa5 'Bug 8168: (follow-up) Use semicolon
a')
OKC4/Budgets.pm
OK pod
OK forbidden patterns
OK valid
OK critic
FAILreports/orders_by_budget.pl
OK pod
FAIL forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 10)
FAIL valid
Scalar value @filtered_budgets[0] better written as
$filtered_budgets[0]
FAIL critic
I/O layer ":utf8" used at line 154, column 9. Use ":encoding(UTF-8)" to
get strict validation.
FAILt/db_dependent/Acquisition.t
OK pod
FAIL forbidden patterns
forbidden pattern: tab char (line 135)
forbidden pattern: tab char (line 136)
forbidden pattern: tab char (line 134)
forbidden pattern: tab char (line 137)
OK valid
OK critic
FAILt/db_dependent/Budgets.t
OK pod
FAIL forbidden patterns
forbidden pattern: tab char (line 68)
forbidden pattern: tab char (line 67)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 49)
forbidden pattern: tab char (line 50)
forbidden pattern: tab char (line 57)
OK valid
OK critic
FAILkoha-tmpl/intranet-tmpl/prog/en/modules/reports/orders_by_budget.tt
FAIL forbidden patterns
forbidden pattern: tab char (line 36)
forbidden pattern: tab char (line 99)
forbidden pattern: tab char (line 88)
forbidden pattern: tab char (line 90)
forbidden pattern: tab char (line 95)
forbidden pattern: tab char (line 98)
forbidden pattern: tab char (line 100)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 101)
forbidden pattern: tab char (line 15)
forbidden pattern: tab char (line 62)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 77)
forbidden pattern: tab char (line 83)
forbidden pattern: tab char (line 78)
forbidden pattern: tab char (line 57)
forbidden pattern: tab char (line 96)
forbidden pattern: tab char (line 14)
forbidden pattern: tab char (line 82)
forbidden pattern: tab char (line 107)
forbidden pattern: tab char (line 80)
forbidden pattern: tab char (line 89)
forbidden pattern: tab char (line 59)
OK tt_valid
OK valid_template
FAILkoha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
FAIL forbidden patterns
forbidden pattern: tab char (line 65)
OK tt_valid
OK valid_template
Please fix those.
II. Testing the interface
1) I think the budgets should be funds in the interface, or fund (budget) for
the pull down list.
2) There is a small display issue with the legend 'Filters' on the first
fieldset. The legend shows inside the elemend, instead of above.
3) The list could be improved, showing only funds with orders. But that would
be an enhancement.
4) Lots of the date and currency formatting could be handled in the template.
But it works and dateformat is honored.
III Code review
Generally I think there is a bit of confusion about the terminology, visible in
the interface and in the naming and documentation of the new routines.
The hierarchies in Koha speak are something like:
basket group - basket - order/order line
budget - fund - child funds
I have tried to point those out and also found a few other things:
::: C4/Budgets.pm
@@ +476,4 @@
> }
>
> # ---
> +sub GetBudgetPeriodDescription {
1) Please add complete documentation to the new routine - I know Budget.pm is a
bit sparse on that, but it's still worth not making it worse :) (minor)
2) Please also document the return values (see also below) (minor)
@@ +725,5 @@
> +=head2 GetBudgetReport
> +
> + &GetBudgetReport();
> +
> +Get one specific budget for reports without cancelled baskets.
3) Documentation could be a bit more clear: Get all orders for a specific fund,
without cancelled orders.
@@ +739,5 @@
> +FROM aqbudgets b
> +INNER JOIN aqorders o
> +ON b.budget_id = o.budget_id
> +WHERE b.budget_id=?
> +AND (o.dat
[Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613
--- Comment #25 from Jacek Ablewicz ---
(In reply to Katrin Fischer from comment #23)
> 151 suppliername => $details->{'suppliername'},
IMO this part is fine (GetInvoiceDetails() does return 'suppliername' and it
seems to work like intended, at least for me), but this one:
152 supplierid => $details->{'supplierid'},
is indeed not; as a result, link via "Vendor: " name is leading to nowhere.
Which I should've spotted before signing-off :(.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #108 from Katrin Fischer --- I am sorry, there is a conflict I can't resolve in this patch series: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 6739 - expired patrons not blocked from opac actions - Followup 2 fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6739 - expired patrons not blocked from opac actions - Followup 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #24 from Katrin Fischer --- Hm also: FAILacqui/invoice.pl OK pod OK forbidden patterns FAIL valid Useless use of private variable in void context OK critic -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #23 from Katrin Fischer ---
Looking at this a bit more, I think I might have found a small mistake. With
both patches applied:
In acqui/invoice.pl:
103 my $bookseller = GetBookSellerFromId($details->{booksellerid});
151 suppliername => $details->{'suppliername'},
Jonathan, could you check please? There is no "Need Feedback" status, so
setting "Failed QA".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #22 from Katrin Fischer --- My feeling is, that we need to centralize the code doing all the calculations in acq, as the tax calculation has proven to be an endless source of pain and confusion. That said... going to QA this and hoping for an improvement :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|paul.poul...@biblibre.com | --- Comment #67 from Katrin Fischer --- ... now it looks a lot less scary already. The QA script complains about a few small things: FAILreports/issues_stats.pl FAIL pod *** ERROR: =over on line 45 without closing =back at line EOF in file reports/issues_stats.pl FAIL forbidden patterns forbidden pattern: tab char (line 628) OK valid OK critic FAILkoha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt FAIL forbidden patterns forbidden pattern: tab char (line 75) OK tt_valid OK valid_template Please provide a follow up for the POD and include the tab fixes. Also - are there patches missing? I can't find the new tests in t/db_dependent/Biblio.t the comments talk about. and some of the other changes mentioned. Julian, could you please check the patches are all there and complete for testing? Please also point me the correct test plan I should be using, thx. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Attachment #25093|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Attachment #25095|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Attachment #25092|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Attachment #25091|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What|Removed |Added Attachment #25094|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #66 from Katrin Fischer --- I think by accident some patches got on this bug report, that don't belong here - tidying up a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865 --- Comment #4 from Katrin Fischer --- ... by 'the table won't be sortable' I meant: the column will not be sortable by the staff member who created the order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- This works as described, but I worry about adding more and more information to all the acquisition tables, because I think it can be counter productive to ergonomy and make them harder to use. In this case the patch doesn't add a link to another patch with more information, like the recent patches for adding the basket group numbers to more places, but it adds a very specific information. The table won't be sortable, the information will repeat for every order line from that basket. For a small library, it might even be always the same information repeated all over. If you need to find out, who ordered a book, you can do a right click on the basket number link and open it in a new tab. There all the information about the basket will be displayed clearly - the name of the staff person who ordered it, when it was ordered, for which branch, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Katrin Fischer changed: What|Removed |Added Attachment #26449|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 26518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26518&action=edit [PASSED QA] Bug 11957: sample_only_param_tables.sql is not usable This sql file tries to insert data into nonexistent tables. It is useless and can be removed. Test plan: git grep sample_only_param_tables should not return any result. NOTE: This is basically a git rm. Simple patch. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer File is not used by the installers and it wouldn't work with today's Koha for trying to insert data into non-existant tables and tables with different structure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11957] sample_only_param_tables.sql is not usable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11957 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #7 from Katrin Fischer --- I have added some other related bugs. My suggestion would be, that we first fix the English file as reference and then either - copy the corrected English file for all translated installers - or better: move it out of the language specific installer directories (like syspref.sql) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 --- Comment #6 from Katrin Fischer --- Created attachment 26517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26517&action=edit [PASSED QA] Bug 11973 - Fix Armenian language description This patch fix Armenian language description To test: 1) Do a fake translation to Armenian, mkdir koha-tmpl/intranet-tmpl/prog/hy-Armn 2) Go to Administration > System preferences > I18N/L10N 3) Armenian description looks like the second string in Bug description 4) Apply the patch 5) Run updatedatabase.pl 6) Reload page, now description look as first string in Bug description (it's the sixth letter, similar to 't') Ammended patch, wrong column. Signed-off-by: Holger Meißner Signed-off-by: Katrin Fischer Patch fixes the English sample file for translations and includes a database update to correct the string in existing installations. Passes all tests and QA script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added Attachment #26508|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11393] Language menu not show up as name for Thai (th-THA was shown)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11393 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11973 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11393 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9056] Add more translations to table language_descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9056 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11973 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11568 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9056 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11568] Wrong language code in de-DE/mandatory/subtag_registry.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11568 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11973 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11973] Fix Armenian language description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11973 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- This patch fixes the English sql file, but the wrong string still appears in the translated SQL files: installer/data/mysql/de-DE/mandatory/subtag_registry.sql 86 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/es-ES/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/it-IT/necessari/subtag_registry.sql 76 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/nb-NO/1-Obligatorisk/subtag_registry.sql 95 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/pl-PL/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/ru-RU/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); installer/data/mysql/uk-UA/mandatory/subtag_registry.sql 74 VALUES ( 'hy', 'language', 'hy', 'Հայերէն'); We really should only maintain the language files once, as they contain all the translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11352] Batch Patron Deletion/Anonmyzation deletes more than warning states it will delete
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11352 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.12|master Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
