[Koha-bugs] [Bug 12041] Improve Koha::Cache

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Robin Sheat from comment #1)
 Created attachment 26891 [details] [review]
 Bug 12041 - improve Koha::Cache
 
 This makes Koha::Cache behave better by default. It will use memcached
 if available to do shared caching, if that's not available it will fall
 back to in-memory caching. It also allows for a singleton accessor to
 allow a single cache to be shared within a process.
 
 Test plan:
 * The t/Cache.t file runs successfully with and without the
   MEMCACHED_SERVERS envvar set (and memcached running in the
   environment.)

You will want to test that storing utf8 and retrieving it still works. If this
change munches utf8 then it makes the caching unusable in a lot of situations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to M. Tompsett from comment #2)
 Comment on attachment 26559 [details] [review]
   my $subscription = GetSubscription( $issue-{subscriptionid} );
  +my $publisheddate  = $issue-{publisheddate};
 
 What is the difference between publisheddate and planneddate? This is the
 only thing holding me back from signing off.

publisheddate is the date of the publication and planneddate is the planned
date of the reception (and becomes the date of the reception, when it has been
done).
Before bug 7688, the GetNextDate was called with planneddate sometimes and
publisheddate other times. To get the next published date, it is logical to be
based on the current published date (and not planneddate, which could be
different for each library).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Marjorie Barry-Vila from comment #13)
 Hi Jonathan,
 I tested it on a sandbox but it is not working for me. I think it's me I do
 something wrong. I added an owner, a library and a restriction to only owner
 and i can still see fund of the other library.
 I changed flags too but without results.

The test patron has the manage_all_buggets permission. So he can edit all
budgets, even if a restriction is set.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] New: Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Bug ID: 12042
   Summary: Change text ‘Add to basket’ into ‘Add order to basket’
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: s.simone...@cineca.it
QA Contact: testo...@bugs.koha-community.org

I think it would be a good idea to clarify better the function of the 
add to basket button on the vendor search results page
/cgi-bin/koha/acqui/booksellers.pl
and on the single basket page  
cgi-bin/koha/acqui/basket.pl?basketno=1.
To make that, I suggest to add the word order. So  add to basket could become
‘add order to basket’

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

--- Comment #1 from Silvia Simonetti s.simone...@cineca.it ---
Created attachment 26892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26892action=edit
Change text ‘Add to basket’ into ‘Add order to basket’

This patch changes the text ‘Add to basket’ into ‘Add order to basket’ in
vendor search results page and the single basket page

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

  Attachment #26892|0   |1
is obsolete||
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |s.simone...@cineca.it
   |ity.org |

--- Comment #2 from Silvia Simonetti s.simone...@cineca.it ---
Created attachment 26893
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26893action=edit
patch for this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
   Assignee|s.simone...@cineca.it   |koha-b...@lists.koha-commun
   ||ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
 CC||z.taj...@cineca.it
   Severity|trivial |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |s.simone...@cineca.it
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Silvia Simonetti s.simone...@cineca.it changed:

   What|Removed |Added

 CC||s.simone...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674

paxed pasi.kalli...@pttk.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@pttk.fi
   |ity.org |

--- Comment #1 from paxed pasi.kalli...@pttk.fi ---
Created attachment 26894
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26894action=edit
Add syspref MarcFieldDocURL to config the MARC format documentation URL for
marc edit

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #59 from Paola Rossi paola.ro...@cineca.it ---
Today I've installed master 3.15.00.027
I try to apply the patches.
At the 6-th patch there a conflict, perhaps due to the rebasing:

Applying: Bug 11944: use CGI( -utf8 ) everywhere
Using index info to reconstruct a base tree...
stdin:2009: trailing whitespace.
use CGI qw ( -utf8 ); 
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging tools/koha-news.pl
CONFLICT (content): Merge conflict in tools/koha-news.pl
Auto-merging opac/opac-main.pl
CONFLICT (content): Merge conflict in opac/opac-main.pl
Auto-merging mainpage.pl
CONFLICT (content): Merge conflict in mainpage.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 11944: use CGI( -utf8 ) everywhere
--
So I pass the patch to Patch doesn't apply status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674

--- Comment #2 from paxed pasi.kalli...@pttk.fi ---
Add a new system preference MarcFieldDocURL. Setting it to some URL
will make all the MARC documentation links point to that in
the MARC edit UI. Leaving the value empty will use the old defaults
(http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC).

There are some possible substitutions usable in the URL:
 - {MARC} is replaced with either MARC21 or UNIMARC
 - {FIELD} is replaced by the MARC field number, eg. 000, 048, ...
 - {LANG} is replaced by the UI language, eg. en, or fi-FI

To test:

1) Install Koha
2) Go to Cataloguing  New record
3) Clicking on the question mark links in the MARC edit will
   open a window to either loc.gov or archive.ifla.org
4) Install patch
5) Redo parts 1, 2, and 3.
6) Set the value of MarcFieldDocURL to
   http://example.com/?field={FIELD}marc={MARC}lang={LANG}
7) Redo parts 1 and 2
8) Clicking on the question mark links in the MARC edit will
   open a window to example.com, with the proper substitutions
   in the URL for the field, marc flavour and language.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26748|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26861|0   |1
is obsolete||

--- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26895
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26895action=edit
Bug 11944: use CGI( -utf8 ) everywhere

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

--- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com ---
Last patch resolves conflicts with bug 7567.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10944] Mixed content warnings in results and detail with Amazon images on https

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11684

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11684

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10944,
   ||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8952

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
It seems the same stuff is done on bug 8952.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12042] Change text ‘Add to basket’ into ‘Add order to basket’

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12042

Alessandra Carassiti a.carass...@cineca.it changed:

   What|Removed |Added

 CC||a.carass...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12043] New: Popup when reserved item checked in at wrong branch should generate transfer slip

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043

Bug ID: 12043
   Summary: Popup when reserved item checked in at wrong branch
should generate transfer slip
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: benjamin.roks...@kul.oslo.kommune.no
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There are a number of bugs addressing print slip and holds issues, so this bug
addresses solely the following three scenari:

Item with homebranch A is reserved for pickup at branch B.

1) Item is checked in at A (parameters $reserved and $transfertodo are set)
2) Item is checked in at C (parameters $diffbranch and $transfertodo are set)
3) Item is checked in at A, then at C (parameter $WrongTransfer is set)
4) Item is checked in at A, then at B (parameter $reserved is set)

In all of these, messages are created correctly, but hold-transfer-slip.pl
popup is generated with transfer=1.

hold-transfer-slip.pl ignores $transfer so all cases opens a dialog generated
from template RESERVESLIP, where the three first actually should generate
TRANSFERSLIP.

Either hold-transfer-slip.pl must respect $transfer variable or
transfer-slip.pl must be used in cases of transfer.

Popups are generated in returns.tt, e.g.:

hold-transfer-slip.pl?transfer=1amp;borrowernumber=[% borrowernumber
%]amp;biblionumber=[% itembiblionumber %]amp;op=slip

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043

--- Comment #1 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no ---
Created attachment 26896
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26896action=edit
Bug 12043 - Popup when reserved item checked in at wrong branch should generate
transfer slip

This patch corrects some wrong popups in Returns.tt handling transfers
of reserved items.

Instead of using hold-transfer-slip.pl with param transfer=1 (which
seems to be silently ignored) it uses transfer-slip.pl with
itemnumber and destination branch, which allows for printing correct
slips.

It also removes the non-used param $tranfer in hold-transfer-slip.pl.

Test plan:
( see cases in bug description )
1) Make a reservation on item with homebranch A to branch B
2) checkin item at its homebranch A
3) press 'Print slip and confirm transfer'
4) verify that slip uses template RESERVESLIP
5) apply patch
6) repeat steps 1-3
7) verify that slip now uses template TRANSFERSLIP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043

Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12044] New: Checkout should not be possible if a patron's fines will block the transaction

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044

Bug ID: 12044
   Summary: Checkout should not be possible if a patron's fines
will block the transaction
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a patron cannot check out because they are over the limit specified by the
noissuescharge system preference and the logged in user doesn't have permission
to override the limit the barcode input field should not appear. The user
should see a message explaining that checking out is blocked by the outstanding
charge.

Currently the user is able to submit the barcode without any warnings about the
block, and only after the page refreshes do they get a warning.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

--- Comment #16 from Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca ---
(In reply to Jonathan Druart from comment #15)
 (In reply to Marjorie Barry-Vila from comment #13)
  Hi Jonathan,
  I tested it on a sandbox but it is not working for me. I think it's me I do
  something wrong. I added an owner, a library and a restriction to only owner
  and i can still see fund of the other library.
  I changed flags too but without results.
 
 The test patron has the manage_all_buggets permission. So he can edit all
 budgets, even if a restriction is set.

ok! it's works! Sorry for all my comments!
I signed off.

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #17 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Patch tested with a sandbox, by marjorie barry-vila
marjorie.barry-v...@ccsr.qc.ca

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

--- Comment #19 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 26898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26898action=edit
Bug 12019: If a fund has a restriction, a owner is mandatory

The C4::Budgets::CanUserUseBudget assumes that budget_owner_id is
set if a restriction (budget_permission) exists.
see
 $budget-{budget_owner_id}
 $budget-{budget_owner_id} != $borrower-{borrowernumber}

Test plan:
Edit a fund and try to save it with a limitation and no owner. It should
not be possible.

Signed-off-by: marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

--- Comment #18 from sandbo...@biblibre.com sandbo...@biblibre.com ---
Created attachment 26897
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26897action=edit
Bug 12019: FIX budget_owner_id node is duplicated

The input witht the budget_owner_id id is duplicated.
It breaks the jQuery selector
  $('#budget_owner_id').val('');

Signed-off-by: marjorie barry-vila marjorie.barry-v...@ccsr.qc.ca

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #26758|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12019] funds displayed on acquisition home show funds of all branches

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12019

sandbo...@biblibre.com sandbo...@biblibre.com changed:

   What|Removed |Added

  Attachment #26757|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #24087|0   |1
is obsolete||
  Attachment #24088|0   |1
is obsolete||
  Attachment #24089|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26899
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26899action=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= amp;$value
in the function body.

Also use URI::Escape instead of custom regexps.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are not in OPACHideOpenURLForItemTypes)
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
default
9/ Repeat steps 5 to 7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26900
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26900action=edit
Bug 8995: Use uri_escape_utf8 instead of uri_escape

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070

BiAA heull...@mmsh.univ-aix.fr changed:

   What|Removed |Added

 CC||heull...@mmsh.univ-aix.fr
Version|master  |3.14

--- Comment #32 from BiAA heull...@mmsh.univ-aix.fr ---
Hello,

We've just changed for Koha 3.14 and I see that the bug, reported by Paul
Poulain, about the biblioitems.collectiontitle fields (UNIMARC 225Sa)in the
orders, has not been resolved yet. The field is not saved between suggestions
and orders. It's a real problem because we can't use fully koha to manage our
acquisitions. I must use another software (ACCESS) to make the link between
purchasers and suggestions, its a waste of time... pity.

Regards,

Fabienne Heullant, Head Librarian
Frantiq, French archaeology libraries network (more than 40 libraries)
http://frantiq.mom.fr/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26901
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26901action=edit
Bug 8995: Show OpenURL links in bootstrap theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070

BiAA heull...@mmsh.univ-aix.fr changed:

   What|Removed |Added

   Severity|major   |blocker

--- Comment #33 from BiAA heull...@mmsh.univ-aix.fr ---
Hello,

We've just changed for Koha 3.14 and I see that the bug, reported by Paul
Poulain, about the biblioitems.collectiontitle fields (UNIMARC 225Sa)in the
orders, has not been resolved yet. The field is not saved between suggestions
and orders. It's a real problem because we can't use fully koha to manage our
acquisitions. I must use another software (ACCESS) to make the link between
purchasers and suggestions, its a waste of time... pity.

Regards,

Fabienne Heullant, Head Librarian
Frantiq, French archaeology libraries network (more than 40 libraries)
http://frantiq.mom.fr/

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12046] New: Authentication using CAS - bootstrap

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

Bug ID: 12046
   Summary: Authentication using CAS - bootstrap
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to
use the CAS authentication.
A link should be displayed, as on the opac-user.pl page (and on the prog
theme).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12045] New: Transfer impossible if barcode includes spaces

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12045

Bug ID: 12045
   Summary: Transfer impossible if barcode includes spaces
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: verolenci...@yahoo.com.ar
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Barcodes in Koha can include spaces but if such an item is transferred you get
the message No Item with barcode:  where  is the barcode with spaces
stripped.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 26902
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26902action=edit
Bug 12046: Authentication using CAS - bootstrap

At the OPAC, if the bootstrap theme is used, the modal dialog does not
allow to use the CAS authentication.
A link should be displayed, as on the opac-user.pl page (and on the prog
theme).

Test plan:
- set opacthemes to bootstrap
- enable the casAuthentication pref
- fill the casServerUrl pref with something
- go on the opac home page
- click on the log in link (top right)
- you should see 2 login blocks 'CAS' and 'Local'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12047] New: Add new suggestion page should hide inactive funds

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12047

Bug ID: 12047
   Summary: Add new suggestion page should hide inactive funds
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

When adding a suggestion, all funds are showing. It would be great to have the
same option like in new order page to select active/inactive funds.

Thanks,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12048] New: Doesn't display other libraries subscriptions when superlibrarian user

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048

Bug ID: 12048
   Summary: Doesn't display other libraries subscriptions when
superlibrarian user
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: frede...@tamil.fr
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

This is a regression in master and 3.14. When a user has superlibrian
permissions, a search on serials subscriptions must display other libraries
subscriptions even when IndependantBranch syspref is enabled.

To reproduce/test the bug/patch:

1. Enable IndependanBranch
2. Login as a user not having superlibrarian permission
3. Search for a serial subscription on:
   /cgi-bin/koha/serials/serials-search.pl
4. Search a title which has at least 2 subscriptions: one in the user branch,
and
   one in another branch
5. On the result page, just 1 subscription is displayed: the one attached to
   the userbranch
   = this is normal
6. Login as a user having superlibrarian permission
7. Repeat step 3-5.
8. You get the same result as 5. You should have seen all subscriptions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12048] Doesn't display other libraries subscriptions when superlibrarian user

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr
   |ity.org |

--- Comment #1 from Frédéric Demians frede...@tamil.fr ---
Created attachment 26903
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26903action=edit
Proposed patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12049] New: DatePicker not translated

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12049

Bug ID: 12049
   Summary: DatePicker not translated
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Tested on 3.14.05, the JavaScript calendar aka DatePicker is not translated in
circulation page for date due and renew date (you see Now, Done ...).
Strange because the page calls calendar.inc which contains translated texts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070

--- Comment #34 from mathieu saby mathsaby...@gmail.com ---
Hello
If it is still in master, it must be fixed!
And bug status should not be in discussion.

But it is definitely not a P1 blocker bug.
You can see the definition of bug priority in the wiki
http://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines

More likely something like Normal P3

Mathieu Saby

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070

mathieu saby mathsaby...@gmail.com changed:

   What|Removed |Added

   Priority|P1 - high   |P3
   Severity|blocker |normal

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11618] jQuery timepicker is not picked up by the i18n toolchain

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11618

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
*** Bug 12049 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12049] DatePicker not translated

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12049

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
This bug was fixed by 11618 which has been pushed to master but not stable. It
applies cleanly to 3.14.x.

*** This bug has been marked as a duplicate of bug 11618 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11684] More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11684

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
Similar, but not the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12050] New: batch bib deletion tool

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12050

Bug ID: 12050
   Summary: batch bib deletion tool
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

it would be nice to have a batch bib deletion tool that took a batch of bib
numbers or ran a report with the criteria of the user's choosing (like all bibs
without items).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #26902|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 26904
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26904action=edit
[SIGNED OFF] Bug 12046: Authentication using CAS - bootstrap

At the OPAC, if the bootstrap theme is used, the modal dialog
does not allow to use the CAS authentication.  A link should be
displayed, as on the opac-user.pl page (and on the prog theme).

Test plan:
- set opacthemes to bootstrap
- enable the casAuthentication pref
- fill the casServerUrl pref with something
- go on the opac home page
- click on the log in link (top right)
- you should see 2 login blocks 'CAS' and 'Local'

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

NOTE: Without CAS properly set up, the URL will actually be
  empty for the CAS' click here to login link.
COMMENT: Though this does do what it says it does, would it
 not be better to redirect to the opac-user page and
 get the old page loaded up as before, so not just
 CAS but all potential authentication mechanisms will
 work? Increasing the size of the modal seems to
 defeat the purpose of the modal, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12046] Authentication using CAS - bootstrap

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12046

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12051] New: add renew tab to top on staff client

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051

Bug ID: 12051
   Summary: add renew tab to top on staff client
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

On pages that have the check out and check in tabs on the quick search box at
the top, it would be nice to also have a renew tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7413] Allow OPAC renewal x days before due date

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #48 from Galen Charlton gmcha...@gmail.com ---
Pushed to master, along with several follow-ups.  Thanks, Holger!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9075] Rename type to material type

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9075

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #24 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  I note that material type is library jargon, not patron
jargon, but the distinction expressed is valid.  Thanks, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12051] add renew tab to top on staff client

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051

Suzanne Fayle sfa...@roseman.edu changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11978] OverDrive API now prepends http:// to URLs

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11978

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11855] Tiny code cleanup in members

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11855

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Marcel and Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11711] Use new DataTables include in circ templates

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #9 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11734] Use new DataTables include in batch modification templates

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #6 from Galen Charlton gmcha...@gmail.com ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #47 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Today I re-invented this fix trying to answer a mail :(

Comments:

1. Of DejaVu fonts, only Sans version has a good collection of chars,
so we can advice to use only Helvetica if you want Arabic for example.
It's not a problem of the proposed solution, but a shortcoming of the
available font. I think it's the best we can do for now.

2. Helvetica (DejaVuSans) PDF fails because the wrong code is passed to the
file selection on Creators/PDF.pm, I will add a followup

3. Have you tried changing justification on layout? The result is wrong.
I will add another followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #48 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 26905
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26905action=edit
Bug 8375 - Followup - Fix font code

This follow up fixes font code taking it from layout.

To test:
1. Try making a batch using Helvética, downloaded
PDF do not open.
2. Apply the patch
3. Try again, now it's correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #49 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 26906
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26906action=edit
Bug 8375 - Followup 2 - Fix label justification/aligning

This patch use prText alignment to produce center or right
align in text

To test (with former patches applied):
1. Try a batch of mixed scripts with layout alignment center or right, only
latin scripts align almost correctly.
I would suggest to use Helvetica

2. Apply the patch

3. Verify again, now strings must be correctly aligned

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #50 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 26907
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26907action=edit
pic2

another pic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12041] Improve Koha::Cache

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041

--- Comment #3 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 26908
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26908action=edit
Bug 12041 - utf8 compatibility changes

Switched to Cache::Memcached::Fast due to its better support for
unicode, added to the test case so that we notice if something causes
it to break.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12041] Improve Koha::Cache

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #26891|0   |1
is obsolete||
  Attachment #26908|0   |1
is obsolete||

--- Comment #4 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 26909
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26909action=edit
Bug 12041 - improve Koha::Cache

This makes Koha::Cache behave better by default. It will use memcached
if available to do shared caching, if that's not available it will fall
back to in-memory caching. It also allows for a singleton accessor to
allow a single cache to be shared within a process.

Added tests to confirm UTF8-cleanness.

Test plan:
* The t/Cache.t file runs successfully with and without the
  MEMCACHED_SERVERS envvar set (and memcached running in the
  environment.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967

--- Comment #14 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 26910
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26910action=edit
Bug 9967 - Cache authorised value requests properly

Authorised values are now cached using the proper Koha::Cache mechanism,
rather than a simple internal cache. Memoize has been removed because it
didn't really work like we needed it to.

Test plan:
 * running a persistent environment:
 * load the edit item screen
 * refresh several times to ensure any process-based caches are filled
 * add a new LOC authorised value as fast as possible (prepare it on
   another tab.)
 * refresh the edit item page
 * note that the new LOC value may or may not be showing in the
   shelving location
 * if more than 5 seconds have passed since saving it, it must now show
   up.
 * refresh a few times to ensure that it's showing on all processes.

Note:
 * This patch depends on the caching changes of 9967.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9967] Authorized values are not Plack-compatible

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9967

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #26786|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

--- Comment #36 from wajasu matted-34...@mypacks.net ---
Created attachment 26911
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26911action=edit
0001-Bug-11232-support-zebra-facet-queries-in-search.patch

Minimal support for zebra facet queries with indexes being made
available in the zidx fields added to the Koha::getFacets routine.

Search falls back to current implementation when facet query has
and error or no results.  This enables folks to roll out index
changes.  Currently supports the existing facets.

Test Plan:
1) Setup a working git clone dev install with a database with biblios
   (be sure to have your KOHA_CONF and PERL5LIB set.
   dom, icu
2) Run searches with current facet behavior
   (keeping browser tab for later reference)
   (use staff client to find some biblios and on the marc tab
write down the biblionumber for later use.  get about 5 or more)
   (enable syspref for showing facet counters in staff client admin)
3) (Optional) Setup yaz-client for manual validation (on a console tab)
yaz-client unix:/home/koha/koha-dev/var/run/zebradb/bibliosocket
base biblios
form xml
elem zebra::facet::Author:0
f @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 Ferguson, Sinclair B.
... some hits
s
(should show  results when thedesignated index Author:0 is specified)
elem
Subject-to:0,Subject-geo:0,Subject-ut:0,Author:0,Title-series:0,itype:0,location:0,holdingbranch:0
s
(should show  all facets results if all are configured )
4) Apply patch
5) cd to your chosen .../koha-dev/etc/zebradb/marc_defs/marc21/biblios (on
another console tab)
6) xsltproc ../../../xsl/koha-indexdefs-to-zebra.xsl biblio-koha-indexdefs.xml
 biblio-zebra-indexdefs.xsl
  (rerun this after changing biblio-koha-indexdefs.xml)
7) from kohaclone dir (setup this up in another console tab for steps 7  8)
   run  misc/migration_tools/rebuild_zebra.pl --where biblionumber
in (n1, n1, ...) -b -r --run-as-root -v
 where n1 ... are the biblios you write down above.  (For a quick index
turnaround)
   Later for a full database rebuild, that will use the new
biblio-zebra-indexdefs.xsl
   from kohaclone dir run misc/migration_tools/rebuild_zebra.pl -a -b -r
--run-as-root -v
   (--run-as-root if needed)
8) zebrasrv -f /home/koha/koha-dev/etc/koha-conf.xml
   (can watch this on output and cut RPN queries for yaz if you desire)
9) use browser to search as you did in step 2 to see if you have
   larger counters (when you have a bigger database/result)
10) if facets are satisfactory, we pass.  please report anomalies.

You can edit the C4/Search.pm  line that defines  $element_set_all_indexes
and make adjustments removing selectively,save and then do a search to see
things fallback to the current code behavior.

Write now this patch demonstrates this strategy as a baby step for a release.

Things that need to be done:
- clean code (warnings, comments, long/bad var names, etc)
- add facet usage syspref detection (if needed)
- pubdate, and other desired additions (can be a future/followup enhancment)
- think about UTF-8 and check if diacritics etc show in facet term
- discuss naming of some added indexes  Subject-to vs su-to, Subject-geo vs
su-geo
- handle HideLostItems, and check if Suppress is handled.
- grs1 and other adjustments (if needed)
- future enhancment can: support syspref/editing of element_indexes_all
  and the order to display
- communicate the adjustment to biblio-koha-indexdefs.xml for upgrades
  to take advantage.
- if this patch strategy is acceptable, the UNIMARC and NORMARC facets
  can be worked on. fallback allows us to rollout.
- no restrictions on the total amount of facets are configured
  (Author:0:100 might be worth trying)
- facet consolidation for the presentation UI is the same but could
  return all results to the UI and let CSS hide/unhide.
  (another bug exists for this)

I did NYTProf, but others can and suggest performance enhancements.
When zebra facet indexes are available no marc records are being read etc,
as of now, unless things fallback.

Note: Title-series:0  seemed to not show a 490a in a certain case where I
had 10 results with a certain resultset.  Weird, but me might just
decide to fallback for that index if its an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11232] Retrieve facets from Zebra

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232

wajasu matted-34...@mypacks.net changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

--- Comment #60 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 13018
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13018
Bug 6030 [3.8.x] Allow html content in letters

Review of attachment 13018:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=6030attachment=13018)
-

::: misc/cronjobs/overdue_notices.pl
@@ +344,4 @@
  
  our $csv;   # the Text::CSV_XS object
  our $csv_fh;# the filehandle to the CSV file.
 +if ( $csvfilename ) {

No, because the file name could be 0. Old code is better.

@@ +563,4 @@
  email  = $email,
  itemcount  = $itemcount,
  titles = $titles,
 +outputformat   = $csvfilename ? 'csv' : defined 
 $htmlfilename ? 'html' : '',

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

@@ +591,4 @@
  email  = $email,
  itemcount  = $itemcount,
  titles = $titles,
 +outputformat   = $csvfilename ? 'csv' : 
 defined $htmlfilename ? 'html' : '',

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

@@ +602,4 @@
  }
  
  if (@output_chunks) {
 +if ( $csvfilename ) {

This nested mess should be made clearer elsewhere. And no, defined $csvfilename
should be used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10363] There is no package for authorised values.

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

--- Comment #28 from Robin Sheat ro...@catalyst.net.nz ---
See also bug 9967

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12041

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12041] Improve Koha::Cache

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12041

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8089

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10893] Location facet not working in UNIMARC

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10893] Location facet not working in UNIMARC

2014-04-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #21114|0   |1
is obsolete||

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 26912
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26912action=edit
Bug 10893: fix location facet in UNIMARC

Location facet in UNIMARC is void. In the code, it is build
on 995$c, while location is store in 995$e (see record.abs).
This patch replace 995$c with 995$e in Koha.pm

To test :
1. Use a UNIMARC Koha instance with ONE branch, and SEVERAL
locations
2. Make a search in opac and staff interface : no location
facet on the left side of the screen
3. apply the patch
4. Make the same search : location facets will be displayed

NOTE: I, Mark Tompsett, rebased this. I confirmed that 995$c
  should be 995$e (wiki, Holdings_data_fields_(9xx) page)
  Also note that the code relocated based on bug 10078,
  causing the patch to not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/