[Koha-bugs] [Bug 11974] Enable unix socket connections for database connections.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11974 --- Comment #21 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- (In reply to Frédéric Demians from comment #19) Thanks for trying :-) I'm sure this sad attempt will pave the way to successful contributions! Looking forward to it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9216] Make table headings translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #22521|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26989action=edit Bug 9216: columns.def file is not translatable The sql column headers is stored into the columns.def file. This file is not managed by the translation script. This patch makes possible the headers translation. Note: The translation xml tags were added to avoid all lines to be put on a single line. Test plan: 1/ update your po file cd misc/translate; perl translate -f columns update LANG # Replace by another language here 2/ translate header columns (search columns.def in your po file). 3/ install the translated columns.def perl translate -f columns install LANG # Replace by another language here 4/ go on the report module create a new report next next 5/ change the language on the 3rd step, you should see the column header translated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9216] Make table headings translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Bernardo Gonzalez Kriegel from comment #7) Anyway, may I suggest using instead of translationbiblioitems.volumedesc: Volume information/translation something like table name=biblioitems.volumedesc:Volume information/table I think it's equally easier to match and split. Very good idea! I did that in the new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26991action=edit with patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #59 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26990action=edit without patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #58) Jonathan, I can't reproduce this issue. Do you think you could post a screenshot? I added 2 screenshots, with and without the patch. Note that the titles were bold, not with the patch. The table width has been changed too. It seems too narrow to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26917|0 |1 is obsolete|| Attachment #26918|0 |1 is obsolete|| Attachment #26919|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26992action=edit Bug 11885 - Inconsistent HTML in MARC Details In Catalog MARC Details, the HTML in the different tabs is slightly inconsistent and doesn't differentiate different elements, making CSS styling complicated or impossible: * tab 0 has p class=subfield_line whereas all the other tabs have just p * all other tabs wrap the subfield character in b tags, except for tab 0 * the MARC tag title is a single div with the tag, the indicators and the field description. Attached patch folds all the tab outputs into a single TT BLOCK, which is then reused. It also marks the separate parts of the tag title in their own spans. The output should be nearly identical to previous behaviour, minus a dash from the tag title descriptions - it was used to separate the tag from the description. The description can now be styled separately from the tag itself, so the dash can be added with CSS, if necessary. Revised test: 1) Find a biblio 2) Edit the record so that there is something in every tab (0-9). 3) Save and then click 'MARC' in the left pane to view the MARC details. 4) Note the contents of each tab. 5) Apply patch 6) Compare the MARC details output to what was noted. Should be the same, minus a dash in each of the tag title descriptions. http://bugs.koha-community.org/show_bug.cgi?id=11885 Signed-off-by: Pasi Kallinen pasi.kalli...@pttk.fi Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26993action=edit Bug 11885 - Follow-up to address issues raised Jonathan Druart raised the following three issues: 1/ subtags was bold before patch 2/ 1 dash existed between tag and tag name 3/ A space has been added (606 #1 - Sujet nom commun becomes 606 # 1 Sujet nom commun, 101 ## - Langue becomes 101 # # Langue) This patch addresses them in the following way: 1/ You will note that @ was not bold on the 0 tab. Every other tab were bold. By making the similar template into a procedure based on the 0XX tab, bolding was lost. This patch bolds all subtags including the @, so that the visible change is minimized. 2/ The dash was programmatically added in at the code stage previously. This bug fix splits the the single concatenation mess into parts which can be styled. This puts the dash back into the template. However, it should be noted that the spacing for the 0 tab's tag and tag description will have an extra space after the hypen that was lacking before. 3/ span.../spanspan.../span is different than span.../span span.../span The later puts that extra space. This patch fixes that. See comment 1 for the test plan. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described. Small koha-qa errors fixed in followup Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26994action=edit Bug 11885 - followup to remove tabs Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26995action=edit Bug 11885: Add a css class to set subfield code bold Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11885] Inconsistent HTML in MARC Details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11885 --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- All looks good, no regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #24857|0 |1 is obsolete|| CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 --- Comment #1 from Marc Véron ve...@veron.ch --- Created attachment 26996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26996action=edit [SIGNED-OFF]Improve AgeRestrictionMarker to consider the case where the marker is immediately followed by the age, eg. K16 in Finland. How I tested: Configure Age Restricition (see Syspref AgeRestrictionMarker) and have a biblio record with e.g. PEGI 99 in age restriction field Try to check out to a patron with age 99 Check out should be blocked Change entry in age restriction field to PEGI99 Checkout should be possible Apply patch Checkout schould now be blocked Patch behaves as expected http://bugs.koha-community.org/show_bug.cgi?id=11630 Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] New: javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071
Bug ID: 12071
Summary: javascript broken for a search with double quotes
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs@lists.koha-community.org
Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com
In staff interface, when performing a simple search with a double quote (ie
histoire algerie), the javascript is broken in results page because of :
function GetZ3950Terms(){
var strQuery=frameworkcode=;
strQuery += + title + = + histoire%20algerie;
Double quotes are not URI-escaped.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Marc Véron ve...@veron.ch changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071
--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 26997
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26997action=edit
Bug 12071 - javascript broken for a search with double quotes
In staff interface, when performing a simple search with a double quote (ie
histoire algerie), the javascript is broken in results page because of :
function GetZ3950Terms(){
var strQuery=frameworkcode=;
strQuery += + title + = + histoire%20algerie;
This patch moves URI escaping from perl to template with uri TT filter.
Test plan :
- In staff interface, perform a search with double quotes that will return no
result, ie aaa xxx
= Without patch, javascript is broken
= With patch, javascript is not broken
- Click on Z3950 button on results page
= Without patch, the Title input is empty
= With patch, the Title input contains the search terms
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27000 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27000action=edit Bug 8992: Update DOM xsl file for new indexes This file has been manually updated (very fun). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26998 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26998action=edit Bug 8992: qa-followup: replace given/when with if/elsif -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 26999 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26999action=edit Bug 8992: Fix index name Identifier-standard It was Identified-standard... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #19) I saw css changes without less (no bootstrap?), There is no change in css file for the bootstrap theme. and saw a given/when construction. Fixed Also it appears to add indexes to GRS1 and not to DOM. Fixed My impression is that we are not complete yet. Is that correct? More or less, 18 months ago, the workflow for patches integration was more flexible :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Severity|normal |critical --- Comment #9 from Fridolin SOMERS fridolyn.som...@biblibre.com --- I set as critical because it may show a user/password -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Robin, did you see my last comment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- I need tests and feedbacks on my patches to continue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #8) I think this behavior should be controlled by a new system preference IndependentBranchesPatronModifications. I also agree, IndependentBranches behaviors need to be broken up into smaller sets in the future. This would be a good place to start. Any new modules such as this one that need an IndependentBranches behavior should have a separate preference. Katrin, I would like to get your opinion about that. Do you agree with Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #22) (In reply to Robin Sheat from comment #21) (In reply to Katrin Fischer from comment #20) Robin, could you take a look at comment 9 from Jonathan? I can, but I don't know why it'd be doing that. Maybe memcached wasn't running or something? To me it is not working on master. After some debug: C4::Context-memcached returns a Cache::Memcached object (created in the BEGIN block of C4::Context l.86). The call to memoize_memcached (BEGIN block in C4::Biblio) is done with memoize_memcached( 'GetMarcStructure', memcached = C4::Context-memcached); My error (which I got when I remove the eval) is Invalid memcached argument (expected a hash) It is raised because memoize_memcached expects a hashref for the memcached value, not a Cache::Memcached instance. Just curious: The above call seems to be incorrect and is removed. But after removal you got the same error? Where is it raised in that situation? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11051] Performance of opac-search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. de Rooy from comment #24) Just curious: The above call seems to be incorrect and is removed. But after removal you got the same error? Where is it raised in that situation? I get the error without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New: New dateformats are stupidly hard to add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Bug ID: 12072 Summary: New dateformats are stupidly hard to add Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kalli...@pttk.fi QA Contact: testo...@bugs.koha-community.org CC: frede...@tamil.fr We need a dateformat like dd.mm. but just adding that into C4/Dates.pm, Koha/DateUtils.pm and i18n_l10n.pref -files isn't enough, because the allowed date formats are hard-coded in multiple template like this: [% IF ( dateformat == us ) %]mm/dd/yy[% ELSIF ( dateformat == metric ) %]dd/mm/yy[% ELSE %]yy-mm-dd[% END %] The dateformat style should be passed to the templates instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27003 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27003action=edit Bug 7267: Add account number to French PDF template To test: - Switch system preference OrderPdfFormat to pdfformat::layout3pagesfr - Create one or more baskets with some orders each. - Add all baskets to one basket group - Print the basket group - Check the account number from your vendor shows up with the other vendor details Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27001 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27001action=edit Bug 11828: Add German translation of layout2pages PDF template To test: - Switch system preference OrderPdfFormat to pdfformat::layout2pagesde - Create one or more baskets with some orders each. - Add all baskets to one basket group - Print the basket group - Check everything is translated into German and the formatting/layout looks ok Followed test plan and compared English with German printout. German version is OK. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27002 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27002action=edit Bug 11828: Follow up - add new option to OrderPdfFormat This depends on bug 11459. To test: - Apply patch for 11459 - Apply patches for 11828 - Check appearance of the OrderPdfFormat system preference It will offer a pull down with options, including German 2-page Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27004action=edit Bug 7267: Add accountnumber to English PDF templates To test: - Switch system preference OrderPdfFormat to pdfformat::layout2pages - Create one or more baskets with some orders each. - Add all baskets to one basket group - Print the basket group - Check the account number from your vendor shows up with the other vendor details - Repeat with pdfformat::layout3pages Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27005 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27005action=edit Bug 7267: Add account number to German PDF template To test: - Switch system preference OrderPdfFormat to pdfformat::layout2pagesde - Create one or more baskets with some orders each. - Add all baskets to one basket group - Print the basket group - Check the account number from your vendor shows up with the other vendor details Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Attachment #26125|0 |1 is obsolete|| --- Comment #62 from Koha Team Lyon 3 k...@univ-lyon3.fr --- Created attachment 27006 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27006action=edit Bug 9593 Prices not imported correctly from a staged file I just changed :utf8 for :encoding(UTF-8) in test unit as preconized. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25710|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25711|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25709|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25708|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25897|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11828] Add German PDF template for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11828 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |jonathan.dru...@biblibre.co |y.org |m --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- All works great. Tested with bug 7267. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7267] Display accountnumber in PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||jonathan.dru...@biblibre.co ||m --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- All works great. Tested with bug 11828. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11459] [Signed-Off] OrderPdfFormat pref description could be more verbose
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- This change is quite confusing if you have a customized pdf, the selected value is the first one of the dropdown list. Which is different from the value in the DB. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11459] [Signed-Off] OrderPdfFormat pref description could be more verbose
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11459 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- I should have read the discussion before raising something already discussed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #62 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jonathan Druart from comment #61) (In reply to Kyle M Hall from comment #58) Jonathan, I can't reproduce this issue. Do you think you could post a screenshot? I added 2 screenshots, with and without the patch. Note that the titles were bold, not with the patch. The table width has been changed too. It seems too narrow to me. Thanks! Yes, that is the way it should look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- I should note the unit test for this will now fail until we get the database handles for DBI and DBIx::Class tied together somehow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9216] Make table headings translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #26989|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 27007 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27007action=edit [SIGNED-OFF] Bug 9216: columns.def file is not translatable The sql column headers is stored into the columns.def file. This file is not managed by the translation script. This patch makes possible the headers translation. Note: The translation xml tags were added to avoid all lines to be put on a single line. Test plan: 1/ update your po file cd misc/translate; perl translate -f columns update LANG # Replace by another language here 2/ translate header columns (search columns.def in your po file). 3/ install the translated columns.def perl translate -f columns install LANG # Replace by another language here 4/ go on the report module create a new report next next 5/ change the language on the 3rd step, you should see the column header translated. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, no koha-qa errors [on es-ES about a third of the strings translated!! :-) ] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #63 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #62) Thanks! Yes, that is the way it should look. The width, the bold ou the Previous checkouts line? 1/ The previous checkouts appears but todays checkouts are put in it. Not logical. 2/ The bold: it is a regression, in my opinion. 3/ The width: the table is, now, really narrow on wide screen. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #23 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Jonathan Druart from comment #22) I need tests and feedbacks on my patches to continue. 4th patch has small conflict, seems that present version on master is shorter koha-qa complains FAIL koha-tmpl/intranet-tmpl/prog/en/includes/av-build-dropbox.inc OK forbidden patterns OK tt_valid FAIL valid_template Undefined subroutine C4::Koha::GetAuthvalueDropbox called at /home/bgkriegel/kohaclone/Koha/Template/Plugin/AuthorisedValues.pm line 49. But works -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformats are stupidly hard to add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The proposed new date format would be useful for us as well. Date handling has been improved a lot using TT plugins and includes in the past, but I guess more clean up would be good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26940|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27008action=edit Bug 11995: Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl Bug 7688 changes the prototype for GetNextDate. The serialsUpdate.pl cronjob script has not been updated. Test plan: Before applying the patch: 1/ Check that the following SQL query returns something: SELECT serial.* FROM serial LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid) WHERE serial.status = 1 AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) NOW() AND subscription.closed = 0; 2/ Run misc/cronjobs/serialsUpdate.pl -v It should die with an error message like this: Can't use string (2011-03-05) as a HASH ref while strict refs in use 3/ Apply the patch 4/ Run misc/cronjobs/serialsUpdate.pl -v It should exit normally and print messages like this: Serial issue with id=XX updated 5/ Run the Koha QA test tools. Signed-off-by: Mark Tompsett mtomp...@hotmail.com NOTE: The only file modified is misc/cronjobs/serialsUpdate.pl The error is caused by switching the order of a hash and parameter. This also corrects the date used to be publisheddate instead of planneddate, because the latter does not logically predict the next one. See comment #3. The id=XX's listed in step 4 match the ids displayed by the SQL query in step 1. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11995] Followup for Bug 7688 - FIX GetNextDate in serialsUpdate.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11995 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9216] Make table headings translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Almost an xml file now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Jacek Ablewicz from comment #1) (In reply to Marjorie Barry-Vila from comment #0) Someone can test it? Yes, I can confirm there is a problem with CancelReceipt(). It will delete (one or more, it doesn't matter) items associated with received order only if the given order is a partial receive (and the parent order is not fully received yet). Plus, in those rare cases when it is actually deleting the items, it's currently not doing a very good job - it is removing item records directly from mysql table, but it does NOT flag biblio record for Zebra reindexing after the deletion. Until recently, it also used to delete the items if given order was a transfer to another basket - but it was deleting the order record itself too, which was not all that good (see bug 11549). This patch set does not appear to update zebra on deletion. Also, I wonder if it would be best to call DelItem from the item deletion to take care of that. Using DelItem would also cause the item to be moved to deleteditems rather than being irrevocably destroyed. If these are not issues or I am missing something, please reset the status. Other than that everything looks good! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, thx for taking a look at this - I won't be able to do much QA before the beginning of next week. Woudl DelItem also help with the hold issues? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651
--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 26262
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26262
Bug 11651: Add possibility to print holds from holds queue
Review of attachment 26262:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11651attachment=26262)
-
Please take a look at the following.
Marked as Failed QA.
::: C4/HoldsQueue.pm
@@ +47,5 @@
TransportCostMatrix
UpdateTransportCostMatrix
+
+MarkHoldPrinted
+GetItemNumberFromTmpHold
New unit tests should be provided for these 2 new subroutines.
@@ +136,5 @@
+if (C4::Context-preference('printSlipFromHoldsQueue')){
+$query .= $branchlimit ? AND : WHERE;
+$query .= tmp_holdsqueue.print_status = ?;
+push @bind_params, $printstatus;
+}
New unit tests should be provided for this subroutine change.
::: C4/Reserves.pm
@@ +2255,5 @@
+'biblio' = $reserve-{biblionumber},
+'items' = $itemnumber,
+},
+);
+}
At least one unit test should be provided for this new subroutine.
::: circ/hold-pull-print.pl
@@ +12,5 @@
+# A PARTICULAR PURPOSE. See the GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
License should be GPLv3.
@@ +15,5 @@
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+use strict;
+#use warnings; #FIXME - Bug 2505
replace use strict/warnings with use Modern::Perl.
::: circ/view_holdsqueue.pl
@@ +76,4 @@
$template-param(
branchloop = GetBranchesLoop(C4::Context-userenv-{'branch'}),
itemtypeloop = \@itemtypesloop,
+ printenable = C4::Context-preference('printSlipFromHoldsQueue'),
Same as previously.
::: installer/data/mysql/updatedatabase.pl
@@ +8071,5 @@
+$dbh-do(ALTER TABLE old_reserves ADD print_status BOOLEAN NOT NULL
DEFAULT '0');
+$dbh-do(ALTER TABLE tmp_holdsqueue ADD print_status BOOLEAN NOT NULL
DEFAULT '0');
+$dbh-do(ALTER TABLE tmp_holdsqueue ADD reserve_id INT ( 11 ) FIRST);
+$dbh-do(INSERT INTO systempreferences
(variable,value,options,explanation,type) VALUES('printSlipFromHoldsQueue',
'0', 'NULL', 'If enabled reserve slips can be printed from Holds Queue
screen,', 'YesNo'););
+print Upgrade to $DBversion done \n;
you forgot the SetVersion call here.
::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ +44,5 @@
+for (var i=0; i document.hold_print.reserve_id.length; i++) {
+document.hold_print.reserve_id[i].checked=false;
+}
+}
+}
you can use [un]checkCheckboxes functions provided by jquery.checkboxes.min.js
to do that.
@@ +93,2 @@
[% IF ( itemsloop ) %]
+form id=hold_print name=hold_print method=get
action=/cgi-bin/koha/circ/hold-pull-print.pl target=_blank
why do you use target=_blank here?
@@ +142,5 @@
/tr
[% END %]/tbody
/table
+[% IF ( printenable ) %]
+/form
This close tag is in a IF but not the form.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11651] Add possibility to print holds from holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11651 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #63 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27009 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27009action=edit Bug 9593 - Additional Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #64 from Kyle M Hall k...@bywatersolutions.com --- I'm afraid it appears that this patch introduces some regressions. If you try the examples from the original bug report that added MungeMarcPrice, you'll see that some variations fail that previously would not. I've attached a followup that with tests that pass with the original version of the subroutine but fail with the new version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25906|0 |1 is obsolete|| --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27012 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27012action=edit Bug 766: Use the method plugin to generate sort dropdown list - memberentry Now we can use the method plugin from the memberentry form. Test plan: 1/ Create a patron and verify sort1 and sort2 dropdown list are correctly generated. 2/ Select values. 3/ Save. 4/ Edit the patron and verify the selected values are displayed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25905|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27011 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27011action=edit Bug 766: Create a plugin routine to build dropdown list On this way, dropdown list could be generated from the templates. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25904|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27010 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27010action=edit Bug 766: Move GetAuthvalueDropbox to C4::Koha GetAuthvalueDropbox is in C4::Budgets, this does not make sense. Only acqui/fetch_sort_dropbox.pl call GetAuthvalueDropbox without using C4::Koha. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25907|0 |1 is obsolete|| --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27013action=edit Bug 766: Cleaning: buildCGISort is not in use anymore buildCGISort can be deleted. Test plan: git grep buildCGISort should return no result. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #26401|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27014action=edit Bug 766: Use a tt include instead of a method in the AV plugin -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Bernardo Gonzalez Kriegel from comment #23) 4th patch has small conflict, seems that present version on master is shorter Hum, I don't get the conflict (just Auto-merging members/memberentry.pl) and no qa errors raised. Could you please retry with these rebased patches? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformats are stupidly hard to add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 paxed pasi.kalli...@pttk.fi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |pasi.kalli...@pttk.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11961] Add a Z39.50 search button to the authority creation and modfication forms.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11961 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|gmcha...@gmail.com |fcapovi...@live.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12031] Task Scheduler not sending mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #19 from Kyle M Hall k...@bywatersolutions.com --- Shouldn't supportdir/path/to/koha/misc/supportdir be added by the installer so it is automatically generated for future installations? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11744] cancel receipt doesn't work for one item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11744 --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Kyle M Hall from comment #18) This patch set does not appear to update zebra on deletion. Also, I wonder if it would be best to call DelItem from the item deletion to take care of that. Using DelItem would also cause the item to be moved to deleteditems rather than being irrevocably destroyed. If these are not issues or I am missing something, please reset the status. I am not sure this should be done on this report. It is a major one and I tried to change the code as few as possible. Note that I totally agree with your remark, we should call DelItem here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11947] Hold priorities not re-calculated when hold is confirmed on checkin.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11947 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||k...@bywatersolutions.com --- Comment #22 from Kyle M Hall k...@bywatersolutions.com --- These patches do not appear to be signed off. Changed status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle: ping! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- I have a few suggestions for this: 1) Use the Preference method of the Koha TT plugin instead of passing them in from the perl script. No real processing is done. 2) Change the new sys pref PublicCatalogUsesSSL to OpacProtocol and give it the two options with the values http://; and https://; instead of it being a yes/no. That way in the template we can use do [% Koha.Preference( 'OPACProtocol' ) %][% OPACBaseURL %] which will mean far fewer changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #17493|0 |1 is obsolete|| --- Comment #37 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 27015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27015action=edit Patch rebased master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6070] On a new order defined from suggestion some fields were missing.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6070 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Attachment #27015|Patch rebased master. |[PATCH] Bug 6070: description||publication place and ||[collection|series]title ||not properly saved -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11630] AgeRestrictionMarker doesn't handle marker immediately followed by age
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11630 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Would it be too onerous a request to move the code for parsing the age restriction marker to a separate subroutine and add unit tests? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #22 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, good suggestions, thank you for your review :) - I hope I will find some time to improve the patches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11395] Batch modifications for records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||k...@bywatersolutions.com --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- None of these patches appear to be signed off, change status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #23 from M. Tompsett mtomp...@hotmail.com --- I'll make the patches for you in a few hours, Katrin, if you would like. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26877|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27016action=edit Bug 12040 - Add 3 parameters for SMTP authentication -username - Username to pass to the SMTP server for authentication -password - Password to pass to the SMTP server for authentication -method - Method is the type of authentication. Ie. LOGIN, DIGEST-MD5, etc. Test Plan - As for testing manually using a Gmail account: 1. Set up your sendmail as shown in misc/cronjobs/CONFIGURE.gmail 2. Before applying this patch, run misc/cronjobs/runreports.pl on your favorite report including the proper email parameters against your gmail account. 3. Note the failure message stating the authentication requirement. 4. Apply this patch, and return the script including the additional parameters and specifying LOGIN for the method. 5. Note the successful send. 6. perldoc misc/cronjobs/runreport.pl 7. Run the koha qa test tool. Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu Signed-off-by: Mark Tompsett mtomp...@hotmail.com Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm I tested the case with the patch applied, with and without expected parameters. The parameters don't exist before, so I don't see how to pass values for them. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12040] Add STMP authentication parameters to runreports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12040 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11598] Add --text option to overdue_notices similar to --html option
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11598 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #25668|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27017action=edit Bug 11598 - Add --text option to overdue_notices similar to --html option We have a number of reports of libraries that were upset by Bug 10720 being fixed! These libraries preferred this single file output, but as text only. We should bring back this behavior, but as a feature, not a bug. Test Plan: 1) Apply this patch 2) Run overdue_notices.pl --html 3) Note the output is wrapped in html tags 4) Run overdue_notices.pl --text 5) Note the same output, but not wrapped in html tags Signed-off-by: wajasu matted-34...@mypacks.net Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com To test, add the -n parameter. The filename generation could be refactored but not blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- (In reply to M. Tompsett from comment #1) Are you doing a patch for this, Owen? The fact that the bug is assigned to me and the status is ASSIGNED signals my intention to do a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #66 from Paola Rossi paola.ro...@cineca.it --- In Serials, I create a new numbering pattern whose name is: new実 numbering pattern In this pattern I set this Label: 実label When I select this new pattern for a subscription, the label shown has bad chars: å®label I go on and select Show advanced pattern. The red Pattern name shown has bad chars: newå® numbering pattern --- So I pass the status to Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26343|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27018 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27018action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the acquitision details tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the acquitision details tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. Signed-off-by: Broust jean-manuel.bro...@univ-lyon2.fr Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26345|0 |1 is obsolete|| --- Comment #22 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27020action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. Signed-off-by: Broust jean-manuel.bro...@univ-lyon2.fr Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26344|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27019 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27019action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. Signed-off-by: Broust jean-manuel.bro...@univ-lyon2.fr Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformats are stupidly hard to add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #2 from Owen Leonard oleon...@myacpl.org --- Template output of date formats is handled by three include files: one for the staff client and one each for the prog and bootstrap themes. This doesn't seem like an unreasonable number of templates to modify. The only exception that I can find is circ/offline.tt. That template should be updated to use the include. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 27021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27021action=edit Bug 11944: Fix encoding issue on adding a subscription If frequencies or numbering patterns contain non-latin characters, so output was broken. To reproduce: - Create a frequency and a numbering pattern with non-latin characters - Add a new subscription using these values - The screen should not contain bad encoded characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 27022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27022action=edit Bug 12069 - If you access members/mod_debarment.pl when logged out you are redirected to OPAC login members/mod_debarment.pl's call to checkauth should pass 'intranet' so that if the user happens to be logged out they will be redirected to the staff client login form. To test, apply the patch and log in to the staff client: - Add a restriction to a patron's account. - View the restrictions tab on the patron's account. You should see the restriction and a Remove link for that restriction. - In another tab, log out of the staff client. - In the first tab, click the Remove link. You should be redirected to the staff client login page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12069] If you access members/mod_debarment.pl when logged out you are redirected to OPAC login
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12069 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformats are stupidly hard to add
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- (In reply to Owen Leonard from comment #2) The only exception that I can find is circ/offline.tt. That template should be updated to use the include. Correction: This template needs different date format handling because it's setting a JavaScript variable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #26645|0 |1 is obsolete|| --- Comment #28 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27024 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27024action=edit Bug 8868: Remove CancelReserveFromId CancelReserve does the same job. Signed-off-by: Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
