[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Karam Qubsi changed: What|Removed |Added CC||karamqu...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9915] Allow opac/svc/report to be passed sql parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9915 --- Comment #18 from Chris Cormack --- (In reply to Martin Renvoize from comment #17) > I'm afraid I can't get this to work for more than one parameter? > > I have the below report to grab 'New Items added between two dates', running > through the normal report interface I can varify I do get responses for the > query, but running through svc interface I get zero results (i.e [] is the > response) > > URLs and Report detailed below: > > svc URL used: > http://koha-staff.koha-ptfs.co.uk/cgi-bin/koha/svc/ > report?id=69&sql_params=2010-03-19&sql_params=2010-11-18 > > report URL used: > http://koha-staff.koha-ptfs.co.uk/cgi-bin/koha/reports/guided_reports. > pl?reports=69&phase=Run+this+report&sql_params=2010-03-19&sql_params=2010-11- > 18 > > report used: > SELECT > biblio.title,biblio.author,biblio.datecreated,biblioitems.isbn,items.barcode, > items.location FROM items LEFT JOIN biblioitems on > (items.biblioitemnumber=biblioitems.biblioitemnumber) LEFT JOIN biblio on > (biblioitems.biblionumber=biblio.biblionumber) WHERE biblio.datecreated >= > <> AND biblio.datecreated <= <> > ORDER BY biblio.author asc > > If I remove the second parameter from the report and hard code it, I can use > both the reports and svc interface without issue. > > Could you look into this Chris? I cant replicate it failing, I did one with 3 parameters and it worked fine http://rorohiko/cgi-bin/koha/svc/report?id=196&sql_params=2014-01-01&sql_params=AS&sql_params=ABS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 --- Comment #1 from Owen Leonard --- Created attachment 27277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27277&action=edit Bug 12105 - Remove duplicated plugin jquery.dataTables.columnFilter.js This patch removes a redundant copy of the DataTables plugin jquery.dataTables.columnFilter.js and corrects two templates. The path to the plugin has been modified in acqui/parcel.tt: - Go to Acquisitions and search for a vendor. - Open the detail page for that vendor. - Click the "Receive shipments" button. - Select an invoice to view. - In the table of titles, confirm that the column header search forms work to filter column data. In the template for the Staged MARC management page the plugin has been removed as it is unused. A couple of markup corrects have been made. Confirm that table sorting is unaffected by going to Administration -> Staged MARC management, clicking a staged MARC file, and viewing the table of items in that batch. There should be no more remaining instances of this path in the templates: [% themelang %]/lib/jquery/plugins/jquery.dataTables.columnFilter.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12105] Remove duplicated plugin jquery.dataTables.columnFilter.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What|Removed |Added Attachment #26988|0 |1 is obsolete|| --- Comment #48 from Jesse Weaver --- Created attachment 27276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27276&action=edit Bug 10486 followup - add tables to kohastructure.sql (Rebased.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 Jesse Weaver changed: What|Removed |Added Attachment #26804|0 |1 is obsolete|| --- Comment #47 from Jesse Weaver --- Created attachment 27275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27275&action=edit Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC This adds a new page to the OPAC that can search several Z39.50 targets using Pazpar2. Test plan: 1) Apply patches. 2) Update database. 3) Add one or more Z39.50 targets, using the Administration -> External targets screen. Note that not all targets support keyword search, but here are some that do: * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8 * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8 4) Perform a search on the OPAC, check to see if the "external targets" notice pops up at the top. 5) Click on the results link near that message. 6) This should bring back results from all enabled targets, all of which should be clickable to bring up a detailed view of the record. (This version incorporates previous QA followups and some fixes for translation and per-branch-limiting. Rebased.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12105] New: Remove duplicated plugin jquery.dataTables.columnFilter.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12105 Bug ID: 12105 Summary: Remove duplicated plugin jquery.dataTables.columnFilter.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org There are copies of the DataTables plugin jquery.dataTables.columnFilter.js in both intranet-tmpl/lib/jquery/plugins and intranet-tmpl/prog/en/lib/jquery/plugins. The only one we should have is the one outside translated templates. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9416] We should have 2 kinds of notes for each order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 mathieu saby changed: What|Removed |Added Attachment #27231|0 |1 is obsolete|| --- Comment #19 from mathieu saby --- Created attachment 27274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27274&action=edit [PATCH] Bug 9416: In each order, add a new note made for the vendor I fix a conflict in updatedatabase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #37 from mathieu saby --- Please note that bug 10869 is linked to this bug. There is no dependancy strictly speaking, so both can be tested, but bug 10758 is "bigger", so I suppose bug 10869 will be pushed first, and I will have then to make some changes to bug 10758. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What|Removed |Added Attachment #26830|0 |1 is obsolete|| --- Comment #36 from mathieu saby --- Created attachment 27273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27273&action=edit [PATCH 1/2] Bug 10758 - Show bibliographic information of deleted records in acquisitions (I removed the changes to Koha/Schema/Result/Aqorder.pm, as it should not be integrated in the main patch) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Katrin Fischer changed: What|Removed |Added Attachment #27117|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071
--- Comment #6 from Katrin Fischer ---
Created attachment 27272
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27272&action=edit
[PASSED QA] Bug 12071 - Javascript broken for a search with double quotes
In staff interface, when performing a simple search with
a double quote (ie "histoire algerie"), the javascript
is broken in results page because of :
function GetZ3950Terms(){
var strQuery="&frameworkcode=";
strQuery += "&" + "title" + "=" + ""histoire%20algerie"";
This patch moves URI escaping from perl to template with uri TT filter.
Test plan :
- In staff interface, perform a search with double quotes
that will return no result, ie "aaa xxx"
=> Without patch, javascript is broken
=> With patch, javascript is not broken
- Click on Z3950 button on results page
=> Without patch, the Title input is empty
=> With patch, the Title input contains the search terms
Additional test:
Do a search with something like äöü and then click Z3950
button on results page.
Without patch, encoding is broken in Z3950 form
With patch, encoding is correct.
Signed-off-by: Marc Véron
Signed-off-by: Katrin Fischer
Fixed a few tabs. Passes tests and QA script.
I can't reproduce the Javascript problem, but I can reproduce
the Z39.50 encoding problem and can detect no regression.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12071] javascript broken for a search with double quotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12071 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12104] New: add print label to serials receive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104 Bug ID: 12104 Summary: add print label to serials receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com It would be nice to have a print label link on the serial receive page (like you can have on the holdings table in the catalog). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8991] Add a script to delete old orders
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 mathieu saby changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10869| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8991 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #63 from mathieu saby --- Please note that bug 10758 is linked to this bug (it will display the titles of deleted records in orders, instead of "Deleted record, can't find title"). There is no dependancy strictly speaking, so both can be tested, but bug 10758 is "bigger", so I suppose bug 10869 will be pushed first, and I will have then to make some changes to bug 10758. Mathieu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 --- Comment #1 from Owen Leonard --- Created attachment 27271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27271&action=edit Bug 12103 - Move ajaxfileupload jQuery plugin outside of language-specific directory This patch moves the ajaxfileupload jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and test a page which requires the file upload plugin. For instance: Tools -> Upload local cover image. The upload process should finish correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #62 from mathieu saby --- Created attachment 27270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27270&action=edit [PATCH 3/3] Followup : update the receipt page (parcel.tt) Sorry, I forgot to change parcel.tt page. Here is a followup In main patch, I forgot to made some changes in the parcel.tt page This patch fixes that bu giving the librarian the ability to cancel an order in receipt page if the record is deleted. It also displays the message "Deleted bibliographic record, can't find title" in Summary Note that this behavior will be improved by bug 10758 To test : - create a basket and an order - delete the record used by that order - go on receipt page - in the line matching this order, you should see instead of the title "Deleted bibliographic record, can't find title" - click on "Delete order" : you should be able to delete the order - go to the basket, to check the order was properly cancelled - in receipt page, try to delete an other order (always linked to a record), to be sure there is no regression -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11869] Add more informations to the member printing pages.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11869] Add more informations to the member printing pages.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11869 Katrin Fischer changed: What|Removed |Added Attachment #26690|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 27269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27269&action=edit [PASSED QA] Bug 11869 - Add more informations to the account printing page This patch adds additional informations to the "Print summary" and the "Print receipt" templates. Additional information in "Print summary": * Registration date * Expiration date * Library * Category * Fines and payments TEST PLAN - 1) Go to a patron. 2) Make sure they have something checked out. 3) Manually add a fine. 4) Under the 'Print' button click 'Print summary' -- the resulting preview should: a) have the first for things listed above, and b) have a new fines and payments section. Signed-off-by: Mark Tompsett NOTE: The due date of the check out is not part of this patch, and so I signed off. Similarly, anything required for slips is configurable elsewhere now and thus comment 1 does not accurately reflect the intent of this patch. Signed-off-by: Katrin Fischer This works as described and passes all tests and the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10758 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 mathieu saby changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10869 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #34 from Kyle M Hall --- Created attachment 27268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27268&action=edit Bug 8735 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11258] Holds queue is still making transfer requests that contradict the branch holds policy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11258 Katrin Fischer changed: What|Removed |Added Attachment #25224|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 27267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27267&action=edit [PASSED QA] Bug 11258 - Holds queue is still making transfer requests that contradict the branch holds policy The holds queue generator is still making requests that are not allowed. Previously it was making transfer requests that were not allowed. Currently, it is still making requests where the pickup branch is the same as the item's branch but not the patron's branch, even if there is a "Default holds policy by item type" rule that states this item can only fill holds for patron's of the same branch as the item. Test Plan: 1) Create a test record with 2 items with different itemtypes 2) Set the Default holds policy by item type for the first item to "From any library" 3) Set the Default holds policy by item type for the second item to "From home library" 4) Place a record level hold for a patron from another library, but for pickup at the same library as the item is from 5) Rebuild the holds queue 6) View the holds queue, note the item is listed, though this patron cannot place a hold on this item 7) Apply this patch 8) Repeat step 5, note the hold is no longer in the queue Signed-off-by: Liz Rea automated tests pass, functional tests pass. Bug replicated, eradicated by patch. Signed-off-by: Katrin Fischer I finally managed to reproduce this, patch works as described. Passes tests and QA script, provided tests fail without patch, but succeed with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #7 from Katrin Fischer --- /me whispers *regression test*? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12103] New: Move ajaxfileupload jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12103 Bug ID: 12103 Summary: Move ajaxfileupload jQuery plugin outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The ajaxfileupload jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 --- Comment #1 from Owen Leonard --- Created attachment 27266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27266&action=edit Bug 12102 - Move humanmsg jQuery plugin outside of language-specific directory This patch moves the humanmsg jQuery plugin to intranet-tmpl/prog/lib/jquery/plugins so that it will not be duplicated for each set of translated templates. To test, apply the patch and modify a system preference. The modification messages should appear normally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12102] New: Move humanmsg jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12102 Bug ID: 12102 Summary: Move humanmsg jQuery plugin outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The humanmsg jQuery plugin should be moved to intranet-tmpl/lib/jquery/plugins so that it doesn't have to be duplicated for each translation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 --- Comment #1 from Owen Leonard --- Created attachment 27265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27265&action=edit Bug 12101 - Move Greybox library outside of language-specific directory This patch moves the Greybox library to intranet-tmpl/lib so that it is not duplicated for each set of translated templates. The Greybox library files are called directly only by one include file, greybox.inc, which is modified by this patch. To test, apply the patch and view any page which calls the Greybox library and confirm that modal windows are still generated correctly. For instance, Cataloging -> Cataloging search, click the "Preview MARC" link. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12101] Move Greybox library outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12101] New: Move Greybox library outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12101 Bug ID: 12101 Summary: Move Greybox library outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The Greybox javascript library should be moved to intranet-tmpl/lib so that it doesn't have to be duplicated for each translation and so that the translation script won't have to parse it each time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton --- Pushed to master, along with a couple follow-ups to tweak wording and keep circ staff honest. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12058] OverDrive search results page doesn't show cart, lists, or login links
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12058 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11484] Add option to purge z39.50 search records from import table to cleanup_database.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11484 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Galen Charlton changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Galen Charlton changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #23 from Galen Charlton --- (In reply to Kyle M Hall from comment #8) > I think this behavior should be controlled by a new system preference > "IndependentBranchesPatronModifications". I also agree, IndependentBranches > behaviors need to be broken up into smaller sets in the future. This would > be a good place to start. Any new modules such as this one that need an > IndependentBranches behavior should have a separate preference. I disagree that a new system preference is needed. I think it is sufficient to make this behave like similar interface with regards to library selection: * If IndependentBranches is on, you see only your libraries' stuff unless you're a superlibrarian * If IndependentBranches is off, it *defaults* to showing your library, but there's a selector available on the form to switch to another library. In the later case, it can be coupled with notifications on the main page and patron home page that look like "Patrons requesting modifications: X at my library, Y in the entire system" That's not to say that there won't be other occasion for making finer-grained visibility distinctions, but this really needs a broader discussion. For one thing, it's currently being done differently in serials with the "superserials" permission, and I am very concerned about the prospect of letting a pile of slightly different approaches occur. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 --- Comment #5 from Owen Leonard --- Created attachment 27264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27264&action=edit [SIGNED-OFF] Bug 9063: When ordering from staged file '# Bibs' is empty Bug 2060 renames columns num_biblios with num_records in the import_batches table. The addorderiso2709 files had not been fixed. Test plan: Add an order from a staged file to a basket and verify the "# Bibs" columns is correctly filled. Before the patch, the column was empty. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9063] When ordering from staged file '# Bibs' is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9063 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What|Removed |Added Attachment #27262|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 27263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27263&action=edit Bug 12086 - Hold priorities incorrect, when waiting status was reversed 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 7) Apply this patch 8) Repeat steps 1-6 9) Note the priorities are correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #5 from Kyle M Hall --- Created attachment 27262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27262&action=edit Bug 12086 - Hold priorities incorrect, when waiting status was reversed 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 7) Apply this patch 8) Repeat steps 1-6 9) Note the priorities are correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #6 from Owen Leonard --- Created attachment 27261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27261&action=edit Bug 12089 - Remove use of dt_add_type_uk_date() - JavaScript This patch removes the now unused dt_add_type_uk_date function from Koha's custom DataTables javascript file. To test, be sure all other patches on Bug 12089 are applied. Apply this patch and search for instances of dt_add_type_uk_date. There should be none. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12089] Remove use of dt_add_type_uk_date()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12089 --- Comment #5 from Owen Leonard --- Created attachment 27260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27260&action=edit Bug 12089 - Remove use of dt_add_type_uk_date() - Acquisitions This patch removes instances of dt_add_type_uk_date() from acquisitions templates and updates sorting configurations according to current guidelines. In cases where a formatted date was passed from a Perl script, the script has been modified to pass an unformatted date. Several instances of the no longer valid align attribute have been removed from tags in favor of an existing "data" class which is suitable for display of currency values. To test, view the following pages in Acquisitions. Columns containing dates should sort correctly regardless of dateformat system preference setting. Columns containing bibliographic titles should ignore articles when sorting. - Add to an order from a staged file: The table of staged files should sort correctly. After clicking "add orders" for one of the staged files, the table of titles in that staged file should also be sorted correctly. - Add to an order from a subscription. The table of subscription search results should sort correctly. - Orders search results should sort correctly. - Late orders should sort correctly. - Search for a vendor. Click on the vendor name to view the vendor detail page. The table of contracts on this page should sort correctly. - From the Acquisitions home page click a number in the "spent" column of the table of available funds. The table of orders should sort correctly. - From the Acquisitions home page click a number in the "ordered" column of the table of available funds. The table of orders should sort correctly. - From a vendor detail page, click the "Receive shipments" button. On the receive shipments page the table of shipments should be sorted correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #4 from Kyle M Hall --- I was able to reproduce this issue following the new test plan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #3 from Katrin Fischer --- Ok, repeating tests, adding some information to the test plan: 1) Test record has 1 single item, checked out to patron X 2) Place 3 holds for patrons A, B and C, all title level hold this time A, B, C, item branches and staff branch are the same. 3) Return item, confirm hold 4) Confirm item is now waiting for patron A Priorities are: A = Waiting, B = 1, C = 2 5) Open patron account of user B, checkout book Koha asks: Item X has been waiting for patron A... Revert waiting status Confirm. 6) Check priorities: Hold list shows: A = 1, C = 1 Database says: A = 1, C = 3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 --- Comment #3 from Colin Campbell --- Created attachment 27259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27259&action=edit Second patch ensuring Patron Info is returned correctly The previous patch stopped users with 'excessive fines' (to use the SIP terminology) from issuing items to themselves. This supplementary patch includes the fact that the borrower cannot borrow to be returned in the patron information response. Typically client units request this before issuing, it was saying fines were present but not that this restricted the user's privileges. To test: See the returns from patron information requests If loan privileges are suspended the first four flags in the summary should be set to Y thus: 64 YY 001201404171632430001AOCPL|AA. (of course what the client does with this info is up to it) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #2 from Katrin Fischer --- Gah. I am sure it was there - but what is the missing piece? I reproduced the behaviour twice - one of my holds was item level, I remember that much. I will see if I can still reproduce it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 Colin Campbell changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #2 from Colin Campbell --- Created attachment 27258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27258&action=edit Patch fixing incorrect behaviour on issue This patch handles the blocking of loans which previously could be executed via SIP2 To test: on a system where AllowFineOverride is set to 'allow' attempt to issue an item to a borrower with fines which exceed the value to require staff override. The system should reject the issue. The issue should succeed if the borrower has no fines or fines below the value which restricts issue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Kyle M Hall changed: What|Removed |Added Attachment #27129|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 27257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27257&action=edit [PASSED QA] Bug 12079: ensure that CheckReserves() includes reserve_id in its response This patch modifies _Findgroupreserve so that its one caller, CheckReserves(), would include the reserve_id field in the hold request it returns. Failure to include reserve_id in every circumstance resulted in bug 11947. This patch is therefore a complementary fix for that bug, but is not meant to preempt the direct fix for that bug. To test: [1] Verify that t/db_dependent/Reserves.t passes. [2] Verify that the following test plan taken from the patch for bug 11947 works for this patch *without* applying the patch for 11947: * have a few borrowers, say 4. * have a biblio with a single item (you can scale this up, it should work just the same.) * issue the item to borrower A * have borrowers B, C, and D place a hold on the item * return the item, acknowledge that it'll be put aside for B. * view the holds on the item. Without the patch: * the hold priorities in the UI end up being "waiting, 2, 1" when they should be "waiting, 1, 2". * in the database "reserves" table, they're really "0, 2, 3" when they should be "0, 1, 2". With the patch: * the hold priorities in the UI end up being "waiting, 1, 2" * in the database, they're "0, 1, 2" Signed-off-by: Galen Charlton Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No koha-qa errors. Test pass Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #1 from Kyle M Hall --- I can't reproduce this on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #33 from Katrin Fischer --- Ah, I see now that I had missed Jonathan's comment 28: 'Kyle, could you provide unit tests please?' I second that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10869] can't delete order line if title deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Koha Team Lyon 3 changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||k...@univ-lyon3.fr --- Comment #61 from Koha Team Lyon 3 --- It's ok for the page of the basket but I can't delete the command on the receipt page if the title is suppressed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12079] CheckReserves() and _Findgroupreserve do not return reserve_id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12079 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|koha-b...@lists.koha-commun |g...@esilibrary.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #22 from Katrin Fischer --- Created attachment 27256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27256&action=edit [PASSED QA] Bug 10904 [QA Followup] - Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled Signed-off-by: Katrin Fischer Passes all tests and QA script. Behaviour now is: IndependentBranches = Prevent or IndependentBranches = Don't prevent, IndependentBranchesPatronModifications = Prevent: You will always only see the modification requests of your branch's patrons. IndependentBrnaches = Don't prevent, IndependentBranchesPatronModifications = Don't prevent All modification requests are shown. Link to patron record works and cardnumber is shown. IndependentBranches = OFF - use the new preference. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #21 from Katrin Fischer --- Created attachment 27255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27255&action=edit [PASSED QA] Bug 10904 [QA Followup] - would like to limit patron update request management by branch Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Katrin Fischer changed: What|Removed |Added Attachment #25467|0 |1 is obsolete|| Attachment #25468|0 |1 is obsolete|| Attachment #27253|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 27254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27254&action=edit [PASSED QA] Bug 10904 - would like to limit patron update request management by branch By not limiting the patron modification lists by branch, it can quickly become overwhelming for a librarian. This patch makes the following modifications: * Only superlibrians will see the full list of borrowers with pending modifications. * Adds the patron cardnumber after the patrons name on the modification list. * Adds a link to the patron's record from the modification list. Test Plan: 1) Apply this patch 2) Set up some pending modifications for two branches 3) Log in to the staff intranet as one of those branches 4) You should note the number of pending modifications counts only your logged in branch's patrons 5) Click the link, you should only see your logged in branches patrons in the pending modifications list. 6) You should note the cardnumber is displayed next to the patron name 7) You should note the "View record" link below each patron's name Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer Comments on last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 Katrin Fischer changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #18 from Katrin Fischer --- I think one of the effects IndependentBranches is supposed to have, is that it hides the patron data from other branches. For example, it is not possible to search for other branches' patrons. But I agree that IndependentBranches is not for every library and a more granular approach would be better for the future. I'd propose: IndependentBranches = ON - ignore system preference, never show other branches' patrons modification requests. IndependentBranches = OFF - use the new preference. This would fix a 'bug' with IndependentBranches supposed behaviour, but still allow flexibility. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #19 from Katrin Fischer --- Kyle was reading my mind... ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904 --- Comment #17 from Kyle M Hall --- Created attachment 27253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27253&action=edit Bug 10904 [QA Followup] - Use branch limit if either IndependentBranches or IndependentBranchesPatronModifications is enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #25583|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #25582|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #27246|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #25581|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #25580|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Attachment #27233|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #25 from Katrin Fischer --- Created attachment 27252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27252&action=edit [PASSED QA] Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #23 from Katrin Fischer --- Created attachment 27250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27250&action=edit [PASSED QA] Bug 11629 [QA Followup] - Remove tags to ease translation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #24 from Katrin Fischer --- Created attachment 27251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27251&action=edit [PASSED QA] Bug 11629 [QA Followup] Signed-off-by: Katrin Fischer Changed the syspref.sql file to remove one of the doubled up UNIMARCAuthrityField100 that slipped in with an earlier patch on this bug. Passes all tests and QA script, also t/db_dependent/Circulation_issue.t Tested with items that had - no notforloan value set - notforloan value not used in updateNotforLoanStatusOnCheckin - the notforloan value defined in UpdateNotForLoanStatusOnCheckin Also verified it works the same, when the item was checked out or not checked out on return. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #22 from Katrin Fischer --- Created attachment 27249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27249&action=edit [PASSED QA] Bug 11629 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #21 from Katrin Fischer --- Created attachment 27248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27248&action=edit [PASSED QA] Bug 11629 [QA Followup] - Add message for librarian that status was updated Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #20 from Katrin Fischer --- Created attachment 27247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27247&action=edit [PASSED QA] Bug 11629 - Add ability to update not for loan status on checkin Some libraries would like to streamline the cataloging process my automatically updating notforloan values on checkin. For example, an item is set to notforloan of -1 ( ordered ). The item, is received, processed, and checked in for the first time before being shelved. The checkin automatically changes the nfl value from -1 to 0. The same workflow could be used for damaged items as well. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateNotForLoanStatusOnCheckin to the following: -1: 0 0: 1 4) Create an item, set it's notforloan value to -1 5) Check in the item, note its not for loan value is now 0 6) Check in the item again, note its not for loan value is now 1 7) Check in the item again, note its not for loan value reamins 1 Signed-off-by: Havilah Lyon Signed-off-by: Katrin Fischer Testing notes on last patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall changed: What|Removed |Added Attachment #27245|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 27246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27246&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 Kyle M Hall changed: What|Removed |Added Attachment #27244|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 27245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27245&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629 --- Comment #17 from Kyle M Hall --- Created attachment 27244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27244&action=edit Bug 11629 [QA Followup] - Updating notforloan to 0 gives no "to" status in message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #69 from Kyle M Hall --- Screenshot: http://i.imgur.com/S01Sv0V.png -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #5 from Frédéric Demians --- Created attachment 27243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27243&action=edit Fix C4::Serials::can_edit_subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12098] User can edit some subcriptions he should be prevented to
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12098 --- Comment #4 from Frédéric Demians --- Created attachment 27242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27242&action=edit Refactor can_*_subscription in C4::Serials -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 --- Comment #68 from Kyle M Hall --- > It's odd because I don't do something special. I just check an item out to a > patron (tested with marc21/unimarc and dateformat us/metric). What is your > display? You get the 2 "Previous checkouts" and "Today's checkouts" lines? I've attached a screenshot to show what I see. I've tried all the different date formats and they all work for me. > > > 2/ The bold: it is a regression, in my opinion. > > > > Fixed! > > Maybe a span with a class would be better than using the b tag. I've updated the followup to use a span with a class. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What|Removed |Added Attachment #27102|0 |1 is obsolete|| --- Comment #67 from Kyle M Hall --- Created attachment 27241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27241&action=edit Bug 11703 [QA Followup] - Bold record title, fix table width -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11633] Cannot use the override function AllowFineOverride on the Staff client because this stops the pay function working on the SelfCheck (SC) machines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11633 --- Comment #1 from Colin Campbell --- Clarify the behaviour with AllowFineOverride set to 'dont allow' Behaviour is: Request:6300120140417135829 AOCPL|AA23529001223654|ACsipuser|ADSIPK1|AY1AZECE8 Response:64 YY 00120140417 1358290001AOCPL|AA23529001223654|AEMadeleine Smith|BLY|CQN|BV19.00|CC5|BDEdinburgh 111|PCPT|PIN|AFGreetings from Koha. -- Patron owes 19.00|AY1AZC8BA[0d][0a] Request:11YN2014041713582920141211 235500AOCPL|AA23529001223654|AB502326000745|ACsipuserAY2AZEA61 Response:120NUN20140417135829AOCPL|AA23529001223654|AB502326000745|AJThe hydrogen sonata /|AH|AFPatron Blocked|BLY|AY2AZDF60[0d][0a] Status response (64) returns that Patron is blocked from borrowing. An attempt to borrow (Request 11) is rejected With 'AllowFineOverride' behaviour is Request:6300120140417140210 AOCPL|AA23529001223654|ACsipuser|ADSIPK1|AY1AZECFC Response:64 YY 00120140417 140211AOCPL|AA23529001223654|AEMadeleine Smith|BLY|CQN|BV19.00|CC5|BDEdinburgh 111|PCPT|PIY|AFGreetings from Koha. -- Patron owes 19.00|AY1AZC9A7[0d][0a] Request:11YN2014041714021020141211 235500AOCPL|AA23529001223654|AB502326000745|ACsipuserAY2AZEA75 Response:121NNY20140417140210AOCPL|AA23529001223654|AB502326000745|AJThe hydrogen sonata /|AH20140419235900|AY2AZE3D5[0d][0a] Response now indicates borrower is not blocked from borrowing and indeed a request to issue the item succeeds. This subverts the normal behaviour as the borrower is still stopped in the online and requires staff permission to borrow. If that permission is refused the borrower can now still borrow the item if there is a self check unit available -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Katrin Fischer changed: What|Removed |Added Attachment #27239|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 27240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27240&action=edit [PASSED QA] Bug 9448 [QA Followup] - Hide 'Forgive overdue charges' for returns if user does not have writeoff permission Signed-off-by: Katrin Fischer Works as described, template change only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #22 from Kyle M Hall --- Created attachment 27239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27239&action=edit Bug 9448 [QA Followup] - Hide 'Forgive overdue charges' for returns if user does not have writeoff permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #21 from Katrin Fischer --- Created attachment 27238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27238&action=edit [PASSED QA] Bug 9448 [QA Followup] Rephrases permission description a bit to make it clearer and easier to translate. Adds German descriptions as requested by katrin. Signed-off-by: Katrin Fischer Passes QA script and all tests. Tested with various permission combinations: - superlibrarian - updatecharges (full permission) - only 'remaining permissions for updating charges' It works as expected. Note: I think we need a follow up to include the 'Forgive overdue charges' checkbox on the check in page in the new permission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Katrin Fischer changed: What|Removed |Added Attachment #27235|0 |1 is obsolete|| Attachment #27236|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 27237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27237&action=edit [PASSED QA] Bug 9448 - Add separate permission for writing off fees Adds new sub-permissions to updatecharges, 'writeoff' for writing off fees and 'remaining_permissions' for all other fee related activites. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Remove the 'writeoff' permission from your privileges 4) Attempt to write off a fee, you should not be able to 5) Re-add the 'writeoff' permission 6) Attempt to write off a fee, you should now be able to do so Signed-off-by: Joel Sasse Signed-off-by: Katrin Fischer Comments on second patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #59 from Chris Nighswonger --- (In reply to Bernardo Gonzalez Kriegel from comment #53) > Created attachment 26928 [details] [review] > Bug 8375 - Followup - Fix font code and alignment > > This follow up fixes font code taking it from layout, > and alignment. I see no obvious problem with the using prText for alignment (thought I have a nagging feeling there were some issues with it), however, this fix is applied in the wrong location in the code. The text justification mechanism is housed at the module level in C4::Labels::Label[1] and fixes should probably be applied there or else things will turn to spaghetti pretty fast. Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this. [1]http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm;h=cb6a631d9ffbbeca1f96254352575503ec93f861;hb=ffd90a1564328add63ce376a15b097707d5d66be#l443 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 --- Comment #19 from Kyle M Hall --- Created attachment 27236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27236&action=edit Bug 9448 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9448] Add separate permission for writing off fees
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448 Kyle M Hall changed: What|Removed |Added Attachment #23519|0 |1 is obsolete|| --- Comment #18 from Kyle M Hall --- Created attachment 27235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27235&action=edit Bug 9448 - Add separate permission for writing off fees Adds new sub-permissions to updatecharges, 'writeoff' for writing off fees and 'remaining_permissions' for all other fee related activites. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Remove the 'writeoff' permission from your privileges 4) Attempt to write off a fee, you should not be able to 5) Re-add the 'writeoff' permission 6) Attempt to write off a fee, you should now be able to do so Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12100] Messaging preferences did not save Days in Advance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12100 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
