[Koha-bugs] [Bug 12182] Koha installation problem in Ubuntu

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12182

--- Comment #1 from Simanta Shantikari  ---
When I execute this comman folling are showings

 #./koha_perl_deps.pl -m
[Mon May  5 12:39:14 2014] koha_perl_deps.pl: defined(@array) is deprecated at
/usr/share/perl5/PDF/Reuse.pm line 993,  line 751.
[Mon May  5 12:39:14 2014] koha_perl_deps.pl: (Maybe you should just omit
the defined()?)
[Mon May  5 12:39:14 2014] koha_perl_deps.pl: defined(@array) is deprecated at
/usr/share/perl5/PDF/Reuse.pm line 993,  line 751.
[Mon May  5 12:39:14 2014] koha_perl_deps.pl: (Maybe you should just omit
the defined()?)

  Installed Required   
  Module is
Module Name   Version   Version
   Required

Readonly::XS  0 *   1.02   
No


Total modules reported: 1  * Module is missing or requires
an upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

  Attachment #27827|0   |1
is obsolete||
  Attachment #27828|0   |1
is obsolete||
  Attachment #27919|0   |1
is obsolete||

--- Comment #22 from M. de Rooy  ---
Created attachment 27937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27937&action=edit
Bug 11209: Don't sent the same message for the same user the same day

For PREDUE messages, one message is sent to the message_queue table for
each items in advanced.
So the patron will receive the same message.

The sms part for DUE and PREDUE should not contain dynamic parts, only a
standard message.

Signed-off-by: Chris Cormack 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #24 from M. de Rooy  ---
Created attachment 27939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27939&action=edit
Bug 11209: A message is duplicate if its content has been already sent

If the template contains dynamic parts, the message won't be
considerated as duplicated.

Signed-off-by: Marcel de Rooy 
Duplicate messages will be queued, but when sending the queued messages
duplicates are found and are marked as failed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

--- Comment #23 from M. de Rooy  ---
Created attachment 27938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27938&action=edit
Bug 11209: Check if a notice has been already sent today

The previous patch checks if a notice has already been sent when the
current notices has been sent in queue. Which is wrong!
We have to check if a similar notice has been sent today.

This patch has been created after an observation on a production server:
If a user place on holds several items, he will receive 1 SMS per hold.
Here we only want 1 SMS for all holds.

Signed-off-by: Chris Cormack 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

M. de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #25910|0   |1
is obsolete||

--- Comment #9 from Julian Maurice  ---
Created attachment 27940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27940&action=edit
Bug 11904: New module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #25911|0   |1
is obsolete||

--- Comment #10 from Julian Maurice  ---
Created attachment 27941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27941&action=edit
Bug 11904: Unit tests for Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

  Attachment #25912|0   |1
is obsolete||

--- Comment #11 from Julian Maurice  ---
Created attachment 27942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27942&action=edit
Bug 11904: Example usage of new module Koha::Messages

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] New: Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

Bug ID: 12185
   Summary: Remove extra "f" from parcel.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Acquisitions
  Assignee: mag...@enger.priv.no
  Reporter: mag...@enger.priv.no
QA Contact: testo...@bugs.koha-community.org

Pasi Kallinen spotted this rather obvious typo in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:

 [% IF ( loop_order.order_internalnote ) %]
fInternal note: [%
loop_order.order_internalnote|html %] [Change internal note]
[% ELSE %]

The "f" before the "http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

--- Comment #1 from Magnus Enger  ---
Created attachment 27943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27943&action=edit
Bug 12185 - Remove extra "f" from parcel.tt

There is a typoed "f" outside of the HTML on line 279 of
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
This patch removes that extra "f".

To test:
It should be sufficient to look at line 279 before and after the
patch has been applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12186] New: Duplicate TT code for account payments

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186

Bug ID: 12186
   Summary: Duplicate TT code for account payments
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org

[% SWITCH line.accounttype %]
  [% CASE 'Pay' %]Payment,thanks
  [% CASE 'Pay00' %]Payment,thanks (cash via SIP2)
  

This SWITCH statement is duplicated in three different files:

intranet-tmpl/prog/en/modules/members/pay.tt
intranet-tmpl/prog/en/modules/members/boraccount.tt
opac-tmpl/prog/en/modules/opac-account.tt

It should be folded into a single macro or block.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12187] New: Duplicate TT code for serial statuses

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12187

Bug ID: 12187
   Summary: Duplicate TT code for serial statuses
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org

[% IF ( latestserial.status1 ) %]Expected[% END %]
[% IF ( latestserial.status2 ) %]Arrived[% END %]
[% IF ( latestserial.status3 ) %]Late[% END %]
...


These statements are repeated multiple times, in the following files:

intranet-tmpl/prog/en/modules/catalogue/detail.tt
intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt
intranet-tmpl/prog/en/modules/serials/claims.tt
intranet-tmpl/prog/en/modules/serials/serials-recieve.tt
intranet-tmpl/prog/en/modules/serials/serials-collection.tt
intranet-tmpl/prog/en/modules/serials/serials-edit.tt
intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
opac-tmpl/prog/en/modules/opac-detail.tt


To prevent things from getting out of sync, they should be folded into a single
TT block or macro.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046

--- Comment #20 from Kyle M Hall  ---
Pushed to 3.8.x! Will be in v3.08.24

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

--- Comment #22 from Kyle M Hall  ---
Created attachment 27944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27944&action=edit
Bug 8769 - (QA Followup) Rename $today to $return_date_dt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #27944|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 27945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27945&action=edit
Bug 8769 - (QA Followup) Rename $today to $return_date_dt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #27945|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 27946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27946&action=edit
Bug 8769 - (QA Followup) Undo change to value of $today

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

--- Comment #25 from Kyle M Hall  ---
(In reply to Galen Charlton from comment #21)
> Comment on attachment 27466 [details] [review]
> [PASSED QA] Bug 8769 - Allow SIP2 return backdating
> 
> Review of attachment 27466 [details] [review]:
> -
> 
> ::: C4/Circulation.pm
> @@ +1780,4 @@
> >  }
> >  
> >  # case of a return of document (deal with issues and holdingbranch)
> > +my $today = dt_from_string( $return_date, 'iso' );
> 
> This makes me nervous.  Besides the comments that Colin made about this
> change in bug 10694, a variable named $today that doesn't necessarily
> contain today's date is ... confusing.  Also, it is not clear to be why this
> would be part of the SIP2 change.
> 
> Can you explain the purpose of this line?

After some examination, I have concluded that this change serves no useful
purpose and only causes code obfuscation. I have attached a followup to revert
that line of code. I believe the change is vestigial from a time before this
feature was dependent on bug 10694.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Julian Maurice  changed:

   What|Removed |Added

  Attachment #27771|0   |1
is obsolete||

--- Comment #35 from Julian Maurice  ---
Created attachment 27947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27947&action=edit
Bug 8868: ILS-DI: CancelHold needs to take a reserve_id

CancelHold takes two parameters: patron_id and item_id.
If item_id is considered as an itemnumber, holds on title can't be
canceled.
If item_id is considered as a biblionumber, all holds on this
biblionumber (for a borrower) will be canceled.

So CancelHold have to consider item_id as a reserve_id.

- Added subroutine C4::Reserves::GetReserve
- C4::ILSDI::Services::GetRecords now returns the reserve_id
- Fix the text in the ilsdi.pl?service=Describe&verb=CancelHold page
- Unit tests for CancelReserved and GetReserve
- Do not delete row in reserves table if insert in old_reserves fails

Signed-off-by: Leila and Sonia 
Signed-off-by: Benjamin Rokseth 
Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #36 from Julian Maurice  ---
GetReserve is already in master (added by bug 9394)
This patch was creating another GetReserve subroutine.
I only removed the GetReserve added by this patch (but still continue to use
GetReserve in C4::ILSDI::Services)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7088] cannot renew items on hold even with override

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9046] Items are not exported with the tools/export.pl

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12188] New: fines duplicated after changing dateformat

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188

Bug ID: 12188
   Summary: fines duplicated after changing dateformat
 Change sponsored?: ---
   Product: Koha
   Version: 3.12
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 27948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27948&action=edit
fines duplicated

hi,


 I changed sys pref dateformat to put dd/mm/ and after cron of overdues,
fines were duplicated (see attachment).


I think a bug is on date on description of charges or on cron?

Someone noticed it?

Regards,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12188] fines duplicated after changing dateformat

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12188

Marjorie Barry-Vila  changed:

   What|Removed |Added

   Severity|enhancement |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12186] Duplicate TT code for account payments

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #1 from Magnus Enger  ---
And there should probably be a space between "Payment" and "thanks"? 

  Payment, thanks

not 

  Payment,thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8769] Allow SIP2 return backdating

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #26 from Galen Charlton  ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8813] issue slip lists items as overdue that are not overdue

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8813

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org
   Severity|enhancement |normal

--- Comment #1 from Christopher Brannon  ---
I would love to see this issue corrected.  We reported this almost two years
ago.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10195] Records hidden with OpacSuppression can still be accessed

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #6 from Galen Charlton  ---
Pushed to master.  Thanks, Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8190] Add a logging module to Koha

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12186] Duplicate TT code for account payments

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12186

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
There are also bugs 12165 for adding the code to bootstrap and bug 12166. There
are still some things that need to be added to the account descriptions before
they will cover all cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #19 from Galen Charlton  ---
Pushed to master.  Thanks, Tomás.

However, I am not pushing the follow-up: I've never heard of any other package
that prompts you for a sudo password just by hitting the tab key.  It's one
thing to do 'sudo foo', then get prompted for a password -- that's what you
expect.  But not for hitting the tab key.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5770] email librarian when purchase suggestion made

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12189] New: Untranslatable page title in print slip template

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12189

Bug ID: 12189
   Summary: Untranslatable page title in print slip template
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

printslip.pl includes this line:

title => "Print Receipt for $borrowernumber",

...meaning the page title is untranslatable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12189] Untranslatable page title in print slip template

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12189

Owen Leonard  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #17 from Galen Charlton  ---
Pushed to master, along with a regression test.  Thanks, Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11741] < > not displaying correctly in XSLT result list

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #10 from Galen Charlton  ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #21 from Galen Charlton  ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11404] add out-of-the-box support for Apache 2.4

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11404

Galen Charlton  changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate

--- Comment #14 from Galen Charlton  ---
Note that this is a candidate for 3.16 RC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12147] Column width for action links on invoices too small

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12147

--- Comment #3 from Owen Leonard  ---
Created attachment 27949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27949&action=edit
Bug 12147 [Alternate] Column width for action links on invoices too small

This alternative patch groups "action" links into a menu as was done
with Bug 11763.

This patch also converts the date column sorting configuration to use
header class instead of an index.

This patch also corrects a couple of HTML markup errors: An
improperly-closed  and an improperly closed .

To test, view the invoices page and confirm that the "Actions" menu
button works corectly. Test the functionality of each menu options:
Details, Close, Reopen, and Delete. Confirm that sorting by billing date
still works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10500] Improve isbn matching when importing records

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #37 from Galen Charlton  ---
Pushed to master.  Thanks, Kyle!

Please note the follow-up.  The original patch did not work correctly with
QueryParser, and unfortunately, there's a deeper bug in QP that is getting in
the way.  Consequently, the follow-up ensures that AggressiveMatchOnISBN
doesn't make any change in behavior when UseQueryParser is on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11826] Improving code for XSLT handling

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11826

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |

--- Comment #12 from Galen Charlton  ---
This looks promising for 3.18, but upon reflection, this has no urgent reason
to bypass QA and go into 3.16.0, as there's no user-visible behavior change. 
Consequently, I'm removing the rel_3_16_candidate keyword.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612

Galen Charlton  changed:

   What|Removed |Added

 Status|Signed Off  |Pushed for QA

--- Comment #14 from Galen Charlton  ---
Passing QA and pushing to master.  Thanks, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612

Galen Charlton  changed:

   What|Removed |Added

 Status|Pushed for QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9612] SRU Response is different when DOM indexing is enabled

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #103 from Galen Charlton  ---
Upon review:

- this definitely causes a regression on bug 12107
- rather than the approach you've used for putting placeholders in JavaScript
strings to translate, the approach in bug 12138 should be used instead.

I suspect regressions of the following bugs may be possible

- 7413
- 11486
- 11711

The main reason, however, is that this is too large to safely put in this close
to release.  I'm reasonably confident it can make it in early in the 3.18
cycle, however.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #37 from Galen Charlton  ---
(In reply to Jesse Weaver from comment #36)
> (In reply to Galen Charlton from comment #31)
> > I've marked this as a candidate for 3.16.0.
> > 
> > One question: given the integration problems around pazpar2, is it possible
> > to spit off the pazpar2 metasearch functionality, leaving the core of the
> > editor as something that might make it in as an experimental feature for
> > 3.16.0?
> 
> I have a patch ready that does exactly this ready and sitting in a branch.
> Wasn't quite sure where to put it, but I can rebase and post it if we end up
> needing it.

Please attach it to this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12190] New: move creators preference to tools tab

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12190

Bug ID: 12190
   Summary: move creators preference to tools tab
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We have 2 tabs that have only one preference on them - Tools & Creators I think
that since Creators is used by the Patron Cards tool the preference there
should be moved to Tools and the Creator's tab removed.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #38 from Galen Charlton  ---
One the whole, I am pleased with how this is coming along, but on balance, it's
premature to include this for 3.16.0.

Some issues found:

- the fixFloat jQuery plugin has moved (bug 12116)
- there doesn't seem to be any way to enter a value that contains a dollar
sign, followed by a character, followed by a space that isn't interpreted as a
subfield
- as a currently experimental feature, in additional to chopping out the
PazPar2 stuff until it's solid, there needs to be a way to completely hide this
-- and at present, it doesn't let you use addbiblio.pl for anything except
fast-adds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |

--- Comment #152 from Galen Charlton  ---
On reflection -- I'm not going to bypass QA on this one, given its size. 
Remove the 3.16 candidate keyword.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10857] Add facets cancellation

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #50 from Galen Charlton  ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10858] Browse selected biblios

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |In Discussion

--- Comment #68 from Galen Charlton  ---
This set up rather a lot of infrastructure for a feature whose workflow purpose
can be met by the cart, and I remain dubious.  Consequently, I'm punting this
to the next RM.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

Galen Charlton  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #85 from Galen Charlton  ---
In this case, I agree with Chris.  Since we have two independent signoffs, I've
gone ahead and pushed this.  Thanks, Dobrica!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375)

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854

Galen Charlton  changed:

   What|Removed |Added

 Status|BLOCKED |Pushed to Master

--- Comment #6 from Galen Charlton  ---
Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |In Discussion
 CC||gmcha...@gmail.com

--- Comment #5 from Galen Charlton  ---
I'm punting this one to later and revisit bug 6193 -- nowadays, I don't think
it was a good idea to put the memcached config in the Apache configuration:

- passing environment variables to Plack is difficult
- we don't need to cache koha-conf.xml quite like this in memcached, avoiding
the chicken-and-egg problem that may ahve motivated 6193.

Setting to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |

--- Comment #48 from Galen Charlton  ---
I won't be including this in 3.16.0, as I think it needs to bake for a bit
longer:

- do we /really/ need a new system preference when we could enforce making
OPACBaseURL contain the protocol?
- is it clear that somebody email a cart from the staff interface wants the
results to point to the OPAC, rather than the staff interface?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search groups

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||gmcha...@gmail.com

--- Comment #7 from Galen Charlton  ---
Pushed to master.  Thanks, Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6254] can't set patron privacy by default

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6254

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |Patch doesn't apply

--- Comment #36 from Galen Charlton  ---
Patch does not apply.

Reminder: please keep extensive whitespace changes onto separate patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11287] Import borrowers doesn't take into account the new restriction system

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11287

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Galen Charlton  ---
Doesn't solve the whole problem, but since it's better than the status quo,
I've pushed it.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |Patch doesn't apply

--- Comment #26 from Galen Charlton  ---
Patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

--- Comment #6 from Robin Sheat  ---
(In reply to Galen Charlton from comment #5)
> - passing environment variables to Plack is difficult

It's not really, I have the init script set to pull from a defaults file:

$ cat /etc/default/koha-common-starman 
# Defaults file for starman-related environment variables

# The location of the memcache server (currently only one can be provided.)
MEMCACHED_SERVERS=127.0.0.1:11211

# The namespace under which memcache keys will be stored.
# ${name} becomes the name of the instance.
MEMCACHED_NAMESPACE="${name}_koha"

# Koha debug options that you probably don't want to use unless you're trying
# to figure out a problem.
KOHA_BACKTRACE=1
DEBUG=1

> - we don't need to cache koha-conf.xml quite like this in memcached,
> avoiding the chicken-and-egg problem that may ahve motivated 6193.

We don't so much for plack, we can keep it in a local variable, and a read
every 20 requests or whatever is no big deal. But it seems it'd shave a
reasonable bit of time off loading the CGI implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |Patch doesn't apply
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7933] Fields in marc display not the same

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7933

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||gmcha...@gmail.com

--- Comment #30 from Galen Charlton  ---
I prefer the approach that Mark took in bug 11592 (the currently rebase issue
aside) of creating a new GetFilteredOpacBiblio rather than changing
GetMarcBiblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||gmcha...@gmail.com

--- Comment #63 from Galen Charlton  ---
This needs a Bootstrap follow-up, and unfortunately that looks to be
non-trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 CC||gmcha...@gmail.com

--- Comment #20 from Galen Charlton  ---
Punting to next release as it's tied to bug 10589.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 CC||gmcha...@gmail.com

--- Comment #26 from Galen Charlton  ---
Punting this to the next release; my concerns about relying on this in your
particular use case remain.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Category

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

Galen Charlton  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_16_candidate  |
 Status|Passed QA   |In Discussion
 CC||gmcha...@gmail.com

--- Comment #26 from Galen Charlton  ---
Punting to next release as it's tied to bug 10589.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Galen Charlton  changed:

   What|Removed |Added

   Keywords|rel_3_14_candidate, |
   |rel_3_16_candidate  |
 Status|Passed QA   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7981] Transfer message when returning doesn't properly respect HomeOrHoldingBranchReturn syspref

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981

Benjamin Rokseth  changed:

   What|Removed |Added

  Attachment #27487|0   |1
is obsolete||

--- Comment #6 from Benjamin Rokseth  ---
Created attachment 27950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27950&action=edit
Bug 7981 - Transfer message when returning doesn't properly respect
HomeOrHoldingBranchReturn syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #49 from M. Tompsett  ---
(In reply to Galen Charlton from comment #48)
> - do we /really/ need a new system preference when we could enforce making
> OPACBaseURL contain the protocol?

Valid point. Just that if one only wants to fix a tiny piece at a time, this
solution works. Enforcing the protocol is a much larger patch.


> - is it clear that somebody email a cart from the staff interface wants the
> results to point to the OPAC, rather than the staff interface?

One could email it to someone without staff access. I think it is best to email
OPAC links, and not staff links. That is, I think the current behaviour is
best. 

Now, that doesn't mean that they won't want the staff interface link, but since
we do not know if the email address has staff access (we don't check, though I
suppose we could), OPAC is quickest solution.

Perhaps a logged in user should have the staff URL in their OPAC details pages,
if they have access?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5768] serial enumeration appearing twice in staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5768

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
I believe this is solved by the bug 10823 and bug 10825 combination.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825

--- Comment #30 from M. Tompsett  ---
*** Bug 5768 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5768] serial enumeration appearing twice in staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5768

M. Tompsett  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from M. Tompsett  ---


*** This bug has been marked as a duplicate of bug 10825 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #50 from M. Tompsett  ---
Created attachment 27951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27951&action=edit
Bug 5010: Send list emails with complete links back into the catalog

This patch adapts the way the links in the cart email in OPAC
are generated for the list emails.

The OpacBaseURL variable is generated from code in Auth.pm.

To test:
- Create a list
- Email yourself the list
  Note: Email is sent directly and not via messagequeue table
- Verify the links back into the catalog are missing http(s)://
- Apply the patch
- Email yourself the list again
- Verify the links are now ok and working

Note: The way Auth.pm generates the OpacBaseURL is not correct, as
it does not take into account the OpacBaseURL system preference.
This patch makes both emails sent from OPAC rely on the same
code and is an improvement over the current behaviour.

Tested both together using steps similar to larger test plan.

Signed-off-by: Mark Tompsett 
Signed-off-by: Bernardo Gonzalez Kriegel 
Just add a sign.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #53 from M. Tompsett  ---
Created attachment 27954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27954&action=edit
Bug 5010 - Follow up: Case typographical error

The call had 'OPACProtocol', but it should be 'OpacProtocol'.
I am uncertain why it functioned.

TEST PLAN
-
1) Retest the sending cart from staff client.

Sign comment:
It works because mysql is case insensitive :)
(try "select variable from systempreferences where variable like 'opac%'")

Signed-off-by: Bernardo Gonzalez Kriegel 
No koha-qa errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #51 from M. Tompsett  ---
Created attachment 27952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27952&action=edit
Bug 5010: Fix incomplete links in carts and lists sent from the staff client

While the list email hardcoded http:// in front of the URL, the cart email
was missing http(s)://. As there seems to be no reliable way to determine
in staff if the OPAC is using SSL or not, this patch introduces a new
system preference: PublicCatalogUsesSSL.

To test:
- Create a list
- Send yourself the list from the staff interface
- Verify that the links are http://
- Put some records into your cart
- Send yourself the cart from the staff interface
- Verify that the links are missing http(s):// in front of them
- Apply patch
- Run database update
- Verify that the default setting for PublicCatalogUsesSSL is 'doesn't use'
- Resent both emails
- Verfiy the catalog links are now both http:// links
- Change system preference setting to 'uses'
- Resent both emails
- Verify the catalog links are now https:// links

NOTE: My cart didn't have a 'In online catalog:' line on master.
  My list had http:// on master.
  System preference affected both cart and list sending.
  System preference necessary, because there is no way to
   determine http or https in the middle of an email.

Signed-off-by: Mark Tompsett 

NOTE: The rebase removed sendshelf.tt, because bug 11248 removed
  the hardcoded http:// in the template file. That may have
  been a mistake, since nothing was added to the
  corresponding sendshelf.pl file.

Signed-off-by: Bernardo Gonzalez Kriegel 
Add a sign

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

--- Comment #52 from M. Tompsett  ---
Created attachment 27953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27953&action=edit
Bug 5010: (2) Fix incomplete links in carts and lists sent from the staff
client

While the list email hardcoded http:// in front of the URL, the cart email
was missing http(s)://.

As there seems to be no reliable way to determine in staff
if the OPAC is using SSL or not, this patch introduces a new
OPAC system preference, OpacProtocol, in the Policy subsection.
It defaults to "doesn't use" (http://), but can be changed to
"uses" (https://).

Both basket/sendbasket.pl and virtualshelves/sendshelf.pl were
tweaked to always set OPACBaseURL. If OPACBaseURL is undef or
not set, the URL is not given in the corresponding template
files.

opac/opac-sendshelf.pl was returned to previous state, because
it affects doc-head-close.inc if OPACBaseURL is not passed. This
should be fixed to use the OpacProtocol system preference in
another bug fix. However, this is OPAC, not Staff, and outside
of the bugs scope.

Both basket/sendbasket.tt and virtualshelves/sendshelf.tt
template files contain the suggested Koha.Preference logic
recommended by Kyle in comment #21.

TEST PLAN
-
1) Back up your database
2) Drop your koha database and recreate it empty
3) In the mysql client:
   > SOURCE .../installer/data/mysql/sysprefs.sql;
   -- It should run without error.
   > SELECT variable,value from systempreferences WHERE
variable='OpacProtocol';
   -- It should have the value 'http://'
4) Restore your database
5) $ ./installer/data/mysql/updatedatabase.pl
   -- It should run the upgrade to insert OpacProtocol.
6) In the mysql client:
   > SELECT variable,value from systempreferences WHERE
variable='OpacProtocol';
   -- It should have the value 'http://'
7) Log into the staff client
8) Click 'Koha administration'
9) Click 'Global system preferences'
10) Click the 'OPAC' tab on the left side.
11) Scroll down to the Policy section, and find the OpacProtocol
preference.
-- It should have a value of "doesn't use" in the drop down.
12) Fill your cart with something(s).
13) Make sure you have a list filled with something(s).
14) Click 'Cart' in the top menu bar area.
15) Click 'Send', and send it to yourself.
16) Click 'Close window'
17) Click 'Hide window'
18) Click 'More' and click 'Lists'
19) Choose a list and 'Send list' to yourself.
20) Check your email
-- both emails should have OPAC URLs which start with http://
21) Change the OPAC system preference OpacProtocol to
 'uses' (https://), log out and log in (to force refresh of
 cached system preferences), and repeat steps 14 through 19.
22) Check your email
-- the two new emails should have OPAC URLS which start with
   https://

NOTE: Other URLs may be broken as well, this bug only fixes carts
  and lists sent from staff.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described, shelf and cart. No koha-qa errors

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27435|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27436|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27779|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

   What|Removed |Added

  Attachment #27437|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5010] Incomplete links in carts and lists sent from the staff client

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010

M. Tompsett  changed:

   What|Removed |Added

   Assignee|mtomp...@hotmail.com|katrin.fisc...@bsz-bw.de

--- Comment #54 from M. Tompsett  ---
I have rebased, but the discussion on comment 48 and comment 49 should
continue. Also, Katrin, I've bounced this back to you, as my development time
available for Koha has drastically reduced.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11592] opac scripts do not respect MARC tag visibility

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

--- Comment #29 from M. Tompsett  ---
I think I have something working, but I need to get my unimarc VM updated and
do a test on it first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #27943|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12185] Remove extra "f" from parcel.tt

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12185

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

--- Comment #153 from Zeno Tajoli  ---
Do you think it is still possible to insert it ?
In fact it doesn't change template strings so it is not blocked by string
freeze.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #1 from Chris Cormack  ---
unless ( $data ~~ @used_datas ) {

Should be the same as 

unless ( grep ( $_ eq $data) @used_datas ) {

(I think, just noting it down for when I get the chance to try it)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11629] Add ability to update not for loan status on checkin

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11629

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12191] New: Items with not for loan status shouldn't trigger a transfer

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12191

Bug ID: 12191
   Summary: Items with not for loan status shouldn't trigger a
transfer
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: hbr...@nekls.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Items with notforloan setting ≠ 0 [so 1 or -1, for example] CAN be checked in
and CANNOT be checked out -- both expected behaviors. 

However, items with notforloan ≠ 0 CAN trigger a branch transfer and put an
item into transit for a hold. 

I don't think items should be able to trigger a transfer at all on checkin, if
the item still has notforloan ≠ 0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12110] Display the order vendor note in basket and basketgroup CSV and PDF

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12110

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12192] New: Template toolkit code in HTML attributes is picked up into po-files

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192

Bug ID: 12192
   Summary: Template toolkit code in HTML attributes is picked up
into po-files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

If TT code is used in title, alt, value, label, etc. attribute, the code is
picked up into the po-files as-is, instead of replacing it with a placeholder.

For example:

x

shows up in the po-files as:

msgid "Remove facet [% facet.facet_link_value | html %]"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #5 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9723] Hourly loans don't show time due in OPAC

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9723

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #27555|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11672] Untranslatable report areas in step 1 of Guided Reports

2014-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11672

paxed  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |pasi.kalli...@pttk.fi
   |ity.org |

--- Comment #1 from paxed  ---
Created attachment 27955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27955&action=edit
Fix untranslatable report areas

The guided reports UI shows a drop-down box with "Circulation", "Catalogue",
etc.
These are hard-coded in C4/Reports/Guided.pm  (the @REPORT_AREA hash)

To test:
1) cd misc/translator
2) perl translate update xx-YY
3) there should be no translations msgid for the report area names
   in the po/xx-YY-i-staff-t-prog-v-3006000.po
4) apply patch
5) perl translate update xx-YY
6) check po/xx-YY-i-staff-t-prog-v-3006000.po that it contains
   the msgid - search for "translate_report_areas"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >