[Koha-bugs] [Bug 12315] MTT FIX: Advanced notices are duplicated and not sent to the right patron

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi
 Depends on||12396

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12396] MTT FIX: Due notices (DUEDGST) are multiplicated and not sent to everybody.

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12396

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||12315

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12396] MTT FIX: Due notices (DUEDGST) are multiplicated and not sent to everybody.

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12396

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |olli-antti.kivila...@jns.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12396] New: MTT FIX: Due notices (DUEDGST) are multiplicated and not sent to everybody.

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12396

Bug ID: 12396
   Summary: MTT FIX: Due notices (DUEDGST) are multiplicated and
not sent to everybody.
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

So the first patron receives correct letters, but the followings received
all the previous ones AND his letters.
Eventually you end up with !n letters in message_queue where n = amount of
patrons receiving due messages as digest and having something due.

Eventually we got 4 000 000 ODUEDGST-letters of which 1 100 000 were sent to
our patrons :)
This is madness!

Test plan:
0/ Delete the content of the message_queue table.
1/ Pick 3 patrons and set them to receive due messages as digest.
2/ Check 1 item out for 3 separate patrons and specify a due date today.
3/ Launch the advance_notices.pl script.
4/ Before this patch, you got 6 notices (1+2+3 [!n]). Now, you get 3 notices, 1
for each patron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #3 from Julian Maurice  ---
That's why I moved it in a popup. It doesn't take extra space on screen.
I don't see where is the problem now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
I still have concerns about overloading the tables with information - see my
comment on bug 11865. I think only very few libraries are using the granularity
of permissions, owners and creators that acq offers right now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865

--- Comment #6 from Julian Maurice  ---
Bug 12395

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #1 from Julian Maurice  ---
Created attachment 28754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28754&action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] New: Save order line's creator

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Bug ID: 12395
   Summary: Save order line's creator
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11865] Show basket creator's name in pending orders table

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11865

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #5 from Julian Maurice  ---
Our customer finally doesn't want the name of basket's creator but the name of
order line's creator.
I close this bug and will open a new one.

Sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 643] Allow override of 'debarred' status

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643

--- Comment #5 from sandbo...@biblibre.com  ---
Created attachment 28753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28753&action=edit
Bug 643: Allow override of 'debarred' status

Add a button to temporarily override patron debarment.

To test:
1) Go to patron check out page
2) If patron has been debarred (eg. due to having fees),
   there is no way to check out to that patron.
3) Apply patch
4) A debarred patron check out page now has a button for
   "Override debarment temporarily" - clicking on it
   should allow checking out to that patron.

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 643] Allow override of 'debarred' status

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #28453|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 643] Allow override of 'debarred' status

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=643

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #4 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #28686|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377

--- Comment #3 from sandbo...@biblibre.com  ---
Created attachment 28752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28752&action=edit
Bug 12377 - Add date pickers to serials-edit.pl

There are two date fields when receiving serials on serials-edit.pl,
these inputs should have a calendar widget like other date fields
in Koha.

Test Plan:
1) Apply this patch
2) Recieve a serial
3) Note when clicking on the "Published on" or "Expected on" fields
   you will now have a calendar popup. Note you can still manually
   edit the date if you wish to.

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12377] Add date pickers to serials-edit.pl

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12377

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #2 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12393] OverDrive does not depend on SSL modules for LWP, causing searches to fail

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393

Jesse Weaver  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12393] OverDrive does not depend on SSL modules for LWP, causing searches to fail

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393

--- Comment #2 from Jesse Weaver  ---
Created attachment 28751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28751&action=edit
Bug 12393 - Depend on SSL module for LWP, for OverDrive

The OverDrive integration needs to connect to an authentication server
over HTTPS, and many systems do not install the necessary module
(LWP::Protocol::https) by default.

Test plan (for patch):
  1) Run koha_perl_deps.pl -a, verify that LWP::Protocol::https appears in
 listing.

Test plan (to verify that LWP::Protocol::https is necessary, needs OverDrive
access):
  1) Remove LWP::Protocol::https (liblwp-protocol-https-perl under Debian).
  2) Run an OverDrive search on the OPAC, it should fail.
  3) Reinstall LWP::Protocol::https.
  4) Rerun OverDrive search, it should now succeed.

Note: older versions of Debian do not need to install LWP::Protocol::https
separately;
the Debian scripts have been updated to reflect this divide.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12394] Item selection pull down menu on main page

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12394

--- Comment #2 from Amit  ---
OpacAddMastheadItemtypePulldown

In the current OPAC, there is no easy way to search a particular Item type.
By default, a user searches all itemtype or use advance search.

By this feature user can select itemtype on main screen and perform there
search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12394] Item selection pull down menu on main page

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12394

--- Comment #1 from Amit  ---
By this feature user will select itemtype and do there searching for better
result without going advance search page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12394] New: Item selection pull down menu on main page

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12394

Bug ID: 12394
   Summary: Item selection pull down menu on main page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: amitddng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12394] Item selection pull down menu on main page

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12394

Amit  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |amitddng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12257] Suggestions management displays all librarians as "Unknown"

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12257

--- Comment #6 from ejanla  ---
I use a version 3.14 and is still showing UNKNOWN after using the patch placed
here, can anyone please help me out I really need this. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12257] Suggestions management displays all librarians as "Unknown"

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12257

ejanla  changed:

   What|Removed |Added

 CC||efosaima...@yahoo.com

--- Comment #5 from ejanla  ---
I use a version 3.14 and is still showing UNKNOWN after using the patch placed
here, can anyone please help me out I really need this. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12393] OverDrive does not depend on SSL modules for LWP, causing searches to fail

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393

--- Comment #1 from Jesse Weaver  ---
Misspoke, seems only IO::Socket::SSL is required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12393] New: OverDrive does not depend on SSL modules for LWP, causing searches to fail

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393

Bug ID: 12393
   Summary: OverDrive does not depend on SSL modules for LWP,
causing searches to fail
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: jwea...@bywatersolutions.com
  Reporter: jwea...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha needs to list IO::Socket::SSL and Crypt::SSLeay as dependencies; if these
modules are not installed, the OverDrive code cannot get an authentication
token over SSL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12380] can't tab to save buttons on add item

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12380] can't tab to save buttons on add item

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #28734|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 28750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28750&action=edit
[SIGNED-OFF] Bug 12380 - can't tab to save buttons on add item

Many form elements on the add item page are giving a tabindex of "1" by
the script. This seems to make it impossible to tab through the add item
form fields onto the save buttons. I don't see a reason to set an
explicit tabindex of "1," so this patch removes it.

To test, apply the patch and open an item for editing. Try tabbing
through the add item form fields. It should be possible to tab through
the fields and onto the submit buttons at the bottom. Test again when
adding a new item.

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12392] New: trying to vote gets invalid parameter

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12392

Bug ID: 12392
   Summary: trying to vote gets invalid parameter
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: bugs.koha-community.org
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@freefriends.org
QA Contact: testo...@bugs.koha-community.org

I tried to vote on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569
and received the following internal error ... maybe my account isn't allowed to
vote, I'm not sure (I just created it a couple days ago), but presumably this
error shouldn't happen anyway.  Although the error page says to mail it to
chris@..., I somehow suspected reporting it this way would be preferable.

karl

URL:
http://bugs.koha-community.org/bugzilla3/page.cgi?id=voting/user.html&bug_id=569#vote_569
Invalid parameter HASH(0xa9c6a94) passed to Bugzilla::User->visible_bugs: It
must be numeric.

Traceback:

 at Bugzilla/User.pm line 894
Bugzilla::User::visible_bugs(...) called at Bugzilla/User.pm line 873
Bugzilla::User::can_see_bug(...) called at
template/en/default/bug/link.html.tmpl line 38
eval {...} called at template/en/default/bug/link.html.tmpl line 38
eval {...} called at template/en/default/bug/link.html.tmpl line 18
Template::Provider::__ANON__(...) called at
/usr/lib/perl5/Template/Document.pm line 151
eval {...} called at /usr/lib/perl5/Template/Document.pm line 149
Template::Document::process(...) called at
/usr/lib/perl5/Template/Context.pm line 351
eval {...} called at /usr/lib/perl5/Template/Context.pm line 321
Template::Context::process(...) called at Bugzilla/Template/Context.pm line
31
Bugzilla::Template::Context::process(...) called at
extensions/Voting/template/en/default/pages/voting/user.html.tmpl line 136
eval {...} called at
extensions/Voting/template/en/default/pages/voting/user.html.tmpl line 155
eval {...} called at
extensions/Voting/template/en/default/pages/voting/user.html.tmpl line 163
eval {...} called at
extensions/Voting/template/en/default/pages/voting/user.html.tmpl line 18
Template::Provider::__ANON__(...) called at
/usr/lib/perl5/Template/Document.pm line 151
eval {...} called at /usr/lib/perl5/Template/Document.pm line 149
Template::Document::process(...) called at
/usr/lib/perl5/Template/Context.pm line 351
eval {...} called at /usr/lib/perl5/Template/Context.pm line 321
Template::Context::process(...) called at Bugzilla/Template/Context.pm line
31
Bugzilla::Template::Context::process(...) called at
/usr/lib/perl5/Template/Service.pm line 94
eval {...} called at /usr/lib/perl5/Template/Service.pm line 91
Template::Service::process(...) called at /usr/lib/perl5/Template.pm line
66
Template::process(...) called at Bugzilla/Template.pm line 545
Bugzilla::Template::process(...) called at /var/www/bugzilla3/page.cgi line
78

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

--- Comment #5 from Christopher Brannon  ---
I would also suggest considering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 while looking at
this.  There are times you don't want to allow this feature to change the date.
 For example, we have a bookmobile that visits a location once a month.  There
needs to be a way this shortened due date can be overridden on the fly, or
perhaps an issuing library can ignore this rule in the circulation rules.

I know this is an entirely separate functionality, but I think it should be
kept in mind for something to work towards as this is being worked out.

That's my two cents.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Christopher Brannon  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11565

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565

Christopher Brannon  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10067

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Viktor Sarge  changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #4 from Viktor Sarge  ---
I've been giving this some thought and I don't mind the current workflow where
you get a chance to tell a patron that the book will have a shorter loan period
than usual. But the problem is that decreaseLoanHighHolds hooks into
duedatespec and overwrites it. So even if you auto clear after using highholds
you will lose any date you had entered manually. 

My two cents is that this could be solved with this workflow: 
1) When highholds is active pick upp anything stored in "duedatespec" and stick
it into the new parameter "specifiedDueDateToRestore" 
2) Let highholds overwrite duedatespec as it currently do. 
3) When circulation.pl finds a non empty specifiedDueDateToRestore parameter
stick this back into duedatespec. 

This way the due date from highholds will be the one off value it's supposed to
be and manually defined due dates will be restored. 

I've been looking at 10067 from a few different angles and this is what I can
come up with that does'nt change peoples current workflow. I have yet to
discover any fatal flaws with this approach althoguh there might be several for
all I know.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
I tested. 
After applying the patch the menu item appeared as expected, but the slip did
not display properly. Ic checked FINESLIP in Home › Tools › Notices & Slips. It
had missing angle brackets (<) at two places. After fixing it the slip printed
as expected.

The HTML in FINESLIP inserted by the patch was:

<> <>
<>
Fines: <>


<>, 1001>
Bar code: <>
<>


Total: 1001>

If I look at the patch, the strange 1001's appear at the places where, in both
SQL statemens, we have $<> and $<>
Could it be that the $ signes are superfluous?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12391] printable versions of opac showing all kinds of html

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12391

--- Comment #3 from Nicole C. Engard  ---
This is in Bootstrap by the way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12391] printable versions of opac showing all kinds of html

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12391

--- Comment #2 from Nicole C. Engard  ---
Created attachment 28749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28749&action=edit
links showing over text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12391] printable versions of opac showing all kinds of html

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12391

--- Comment #1 from Nicole C. Engard  ---
Created attachment 28748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28748&action=edit
links showing all over

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12391] New: printable versions of opac showing all kinds of html

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12391

Bug ID: 12391
   Summary: printable versions of opac showing all kinds of html
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

See attached or just go ahead and print the any page in the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12296] OPAC search box should be customisable

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #10 from Marc Véron  ---
Does not apply:

Applying: Bug 12296 - make search box customisable with OpacCustomSearch
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12378] addbiblio.pl error when deleting record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378

--- Comment #2 from Owen Leonard  ---
I suspect this might be related to (a duplicate of?) Bug 11817

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12390] Software Error Message Each Time we Delete a Record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12390

--- Comment #2 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 12378 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12378] addbiblio.pl error when deleting record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12378

Owen Leonard  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #1 from Owen Leonard  ---
*** Bug 12390 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12387] "Digests only?" can confuse patrons

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12387

Owen Leonard  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #2 from Owen Leonard  ---
*** Bug 12390 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12390] Software Error Message Each Time we Delete a Record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12390

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 12387 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12390] Software Error Message Each Time we Delete a Record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12390

Jesse Maseto  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12390] New: Software Error Message Each Time we Delete a Record

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12390

Bug ID: 12390
   Summary: Software Error Message Each Time we Delete a Record
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We bring a record up in the staff side, view in "Normal View," Choose "Delete
Record" from the edit menu, and then get the error message. Both people have
"Super User" Permissions.

The error message they both get comes right after they choose "Delete Record."
The next screen is:

Software error:

Can't call method "title" on an undefined value at
/home/koha/kohaclone/cataloguing/addbiblio.pl line 835.

For help, please send mail to the webmaster (x), giving this error
message and the time and date of the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

Galen Charlton  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #23 from Galen Charlton  ---
Given that some libraries have been significantly affected by purchase
suggestion spam and consequently have not been able to use AnonSuggestions, I'm
considering this a bugfix.

Therefore, pushed to 3.16.x for inclusion in 3.16.1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #118 from Jonathan Druart  ---
Created attachment 28747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28747&action=edit
Build patrons

(In reply to Katrin Fischer from comment #105)
> Does someone know a good trick to add a few thousand borrowers easily? :)

Try this script (you have to edit the $number_of_patrons_to_create variable
value).

/!\ Don't use this script if you are in love with you DB!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #117 from Jonathan Druart  ---
10318:(In reply to Katrin Fischer from comment #105)
> Giving this some quick tests for today, hopefully more soon:

Thanks!

> 1) Sending an empty search from the patrons module top search results in a
> perl error: Can't use an undefined value as an ARRAY reference at
> /usr/lib/perl5/DBI.pm line 2059.

Fixed.

> 2) There is a sort option on the first column with the checkboxes for the
> patron list feature, but if you sort with checkboxes checked, all checkboxes
> are unchecked.

Fixed.

> 3) I had it happen that my existing patron lists didn't show up in the pull
> down - after switching to master and back to the branch with the patches
> applied, I can't reproduce that. So for now this is mostly a note to keep an
> eye out for that.

Hum, weird... :)

> 3) It would be nice to be able to sort on the 'fines' column as well.

No more improvement is envisage in this report. But could be done later.

(In reply to Katrin Fischer from comment #106)
> Found another tiny issue: missing space between category and type: Staff(S)

Fixed.

(In reply to Katrin Fischer from comment #107)
> Another small one: Some time ago the email address was added to the
> information displayed, with the patch we have a small regression there as it
> no longer displays.

Yep, good catch, introduced by bug 10318. Reintroduced in one of the last
patches.

Back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #116 from Jonathan Druart  ---
Created attachment 28746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28746&action=edit
Bug 9811: Various fixes

This patch fixes the issues raised in bug 9811 comment 105, 106 and 107:
1/ Add missing space between category and type.
2/ Fix error on searching an empty string (caused by a previous rebase).
3/ Remove sort option on checkbox/borrowernumber column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #3 from Nicole C. Engard  ---
Checking in on this - it's still an issue for some of our libraries

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #114 from Jonathan Druart  ---
Created attachment 28744
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28744&action=edit
Bug 9811: Display email address in patron result list

This patch restores the enhancement introduced by Bug 10318.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #115 from Jonathan Druart  ---
Created attachment 28745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28745&action=edit
Bug 9811: Remove useless orderby management

I don't know what is this stuff. I didn't find a call to member.pl with
an orderby parameter.
I am not sure this is in used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #113 from Jonathan Druart  ---
Created attachment 28743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28743&action=edit
Bug 9811: QA follow-up: Fix license version

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #112 from Jonathan Druart  ---
Created attachment 28742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28742&action=edit
Bug 9811 - datetime does not respect DateFormat-system prefrence

To test:
Try searching by the date of birth using the left filter column. Good luck.

After applying this patch:
You can search using your preferred DateFormat.

Merci bocu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #110 from Jonathan Druart  ---
Created attachment 28740
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28740&action=edit
Bug 9811: Fixing JSON validation error for non-javascript string literal
characters

Issue:
When a patron has backslashes in his circulation notes, the JSON transportation
layer cannot send the message because it will fail JSON validation when trying
to
validate backslashed non-literal characters (\s \d ...).
This causes the whole search to fail when even one Borrower has a non-literal
backslashed character in his notes.

Solution:
The Borrowers' circulation notes are filtered through a regexp which doubles
all
backslashes to prepare them for the JSON validation routine.

Result:
Backslashes pass through unchanged.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #111 from Jonathan Druart  ---
Created attachment 28741
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28741&action=edit
Bug 9811: FIX encoding issue on patron categories

The patron categories should use the html_entity filter (on the current
master).

Signed-off-by: Olli-Antti Kivilahti 
This fix solves the issue of double encoding some utf8-characters by
html_encoding the
patron categories, which are not marked as utf8.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #109 from Jonathan Druart  ---
Created attachment 28739
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28739&action=edit
Bug 9811: FIX branches loop was not correctly set

The branches loop was not set with the values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #27642|0   |1
is obsolete||
  Attachment #27643|0   |1
is obsolete||
  Attachment #27644|0   |1
is obsolete||
  Attachment #27645|0   |1
is obsolete||
  Attachment #27646|0   |1
is obsolete||
  Attachment #27711|0   |1
is obsolete||

--- Comment #108 from Jonathan Druart  ---
Created attachment 28738
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28738&action=edit
Bug 9811: Patron search improvement

This patch add DataTables using server-side processing for the patrons
search.

It adds:
- 1 module C4/Utils/DataTables/Members.pm
- 2 services svc/members/search and svc/members/add_to_list
- 1 template members/tables/members_results.tt
- 1 new practice which is to add template for DataTables in a
  subdirectory named 'tables'.

Impacted scripts: members/members-home.pl and members/members.pl

To go further: We can imagine that all patrons searches use the same
service with no big changes: 1 little template creates a JSON file and
to implement DataTables on the template page, that's all.

Amended patch: Since bug 10565 has been pushed, these patches don't
apply cleanly. I had to rewrite a part of the patron list feature.
I removed the choice to add all resultant patrons from a search. I think
this choice is useless with this patch: we are able to display the
number of patrons we want and to select all of them.

Test plan:
- Check that there is no regression on searching patrons.
- Try filters on the left of the screen.
- Try to sort each column.
- Try the "Browse by last name" links.
- Check that the "Clear" button clears yours filters.
- Try with IndependantBranches ON and OFF.
- Verify this feature does not break the patron list feature (cf bug
  10565).

Signed-off-by: Cedric Vita 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script, couldn't find any regressions
or problems. Some notes left on the bug.

Bug 9811: Add unit tests for C4::Utils::DT::Members

Signed-off-by: Katrin Fischer 

Bug 9811: QA followup

- removes 2 tabs
- removes mysqlisms
- add sort on borrowernotes
- fix wrong capitalization
- cat => Category

Signed-off-by: Katrin Fischer 
Thx for fixing these!

Bug 9811 - multilines notes brakes JSON

In new patron search feature, the search results are fetched using Ajax and
returned in JSON format.
The JSON is created by TT using
koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt.
One of the fields is the borrower notes. When this notes contains several
lines, the JSON is broken.

This patch uses TT fileters to consert in notes linefeeds into HTML line break
(html_line_break) and then remove linefeeds (collapse).

Test plan :
- perform a member search that does not return a borrower with a circ note
- edit one of the borrowers returned by this search
- enter serveral lines of text in "Circulation note" and save
- reperform the member search
=> circ note is well displayed on several lines

Bug 9811: use count(primary_key) instead of count(*)

Bug 9811: A limit clause should be always added.

By default, we want to retrieve 20 first results.

Bug 9811: Load the page without any data.

Displaying the first 20 patrons is not useful. With this patch, the
table is hidden and no record is retrieved by default.
On the same way, the existing side effect on redirect disappears.

Signed-off-by: Olli-Antti Kivilahti 
-
-TEST REPORT-
-
For the filter: Tested all the search fields, branches, search type.
Found a bug with "date of birth", followup provided.
Tested display limits and verified that AJAX-queries are
  efficient (using LIMIT clause) to not stress DB needlessly.
Tested adding Patrons to a list.
A good feature, which seems to work quite well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363

Barton Chittenden  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8506

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8506] return date of lost items recorded wrong

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8506

Barton Chittenden  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12363

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8506] return date of lost items recorded wrong

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8506

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com
   Severity|normal  |major

--- Comment #1 from Barton Chittenden  ---
This should be escalated, because it causes an inconsistency between
issues.date_due and items.onloan... this is one of the avenues for items to
show up as both "Checked out" and "Available" at the same time.

I've marked this as "Major".

This may also be linked to Bug 12363 (Marking an item as lost in koha always
returns it, but longoverdue.pl may no)

To replicate:

1) Check out an item.
2) Change the following dates in the database, so that the item will trigger as
long overdue:
-- items.onloan
-- issues.date_due
The following fields should probably also be back-dated, for the sake of
consistency with koha:
-- items.datelastseen
-- items.datelastborrowed
-- items.timestamp
-- issues.timestamp
-- issues.issuedate
3) Run longoverdue.pl
4) Navigate to the item in moredetail.pl. Change the lost status from
'Longoverdue (Lost)' to blank.
5) Navigate back to detail.pl, and note that the item now shows as both
'Available' and 'Checked out to  : due '

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

--- Comment #31 from Jonathan Druart  ---
(In reply to Bernardo Gonzalez Kriegel from comment #24)
> But, if I understand correctly [1], it's better to use fileparse() for that
> instead of basename(). 

I always used basename! Thank for pointing that out to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28645|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  ---
Created attachment 28737
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28737&action=edit
Bug 12061 - tmpl_process3.pl - Include/exclude file by name

This patch adds an option to tmpl_process3.pl
for exclude some files by matching their
names. Also modifies current code to include
only selected files to check only filenames.
Checking is case insensitive !!

To test after patch:

A) Include only 'normarc'
1. create
cd misc/translator
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s
normarc.po -r -f normarc
- check provenance of strings
egrep "^#:" normarc.po | cut -d":" -f2 | sort | uniq
- only files with normarc in their names must be present

2. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s
normarc.po -r -f normarc
- repeat check

3. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o
./test -s normarc.po -r -f normarc
- check name of created files

rm -rf test normarc.po

B) Exclude
4. create
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s
xnormarc.po -r -n normarc
- check provenance
egrep "^#:" xnormarc.po | cut -d":" -f2 | sort | uniq | grep -i normarc
- there must be no results

5. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s
xnormarc.po -r -n normarc
- check provenance

6. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap/en -o
./test -s xnormarc.po -r -n normarc
- check files
find test | grep -i normarc
- there must be no results

You can also try another combination, use for example "-f patron -f user -f
bottom" (or use -n)
or mixed "-f marc -n normarc", do create/install and look filenames

Changed to adapt current functionality (-f)

http://bugs.koha-community.org/show_bug.cgi?id=12292
Signed-off-by: Fridolin Somers 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28644|0   |1
is obsolete||

--- Comment #29 from Jonathan Druart  ---
Created attachment 28736
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28736&action=edit
Bug 12061 - tmpl_process3.pl - Multiple source dir

This patch adds the option to use multiple source
dirs for tmpl_process3.pl on create/update actions.

To test after patch:
A) Old
1. install
cd misc/translator
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/bootstrap/en -s
bootstrap.po -r

2. update
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/bootstrap -s
bootstrap.po -r

3. install
mkdir test
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/bootstrap -s
bootstrap.po -r -o ./test -q
- check same number of files
ls -lR ../../koha-tmpl/opac-tmpl/bootstrap | wc -l
ls -lR ./test | wc -l

rm -f bootstrap.po

B) New
4. create from multiple sources
perl tmpl_process3.pl create -i ../../koha-tmpl/opac-tmpl/prog/en -i
../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s
opac.po -r

5. update from multiple source
perl tmpl_process3.pl update -i ../../koha-tmpl/opac-tmpl/prog/en -i
../../koha-tmpl/opac-tmpl/bootstrap/en -i ../../koha-tmpl/opac-tmpl/ccsr/en -s
opac.po -r

6. install (must give an error)
perl tmpl_process3.pl install -i ../../koha-tmpl/opac-tmpl/prog/en -i
../../koha-tmpl/opac-tmpl/bootstrap -s opac.po -r -o ./test

7. updated help
perl tmpl_process3.pl --help

Any other functionality must not be affected

Signed-off-by: Fridolin Somers 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28643|0   |1
is obsolete||

--- Comment #28 from Jonathan Druart  ---
Created attachment 28735
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28735&action=edit
Bug 12061 - tmpl_process3.pl - Remove obsoleted strings/backups

This patch modifies the update process for PO files,
removing obsoleted strings. Currently they are removed
manually as part of the standar procedure of strings update.
Also backup files (*~) need to be removed manually.

To test:
1. Update translation files for any language, ej. fi-FI
(cd misc/translation; perl translate update fi-FI)

2. Check existence of obsoleted strings
egrep "#~ msg" misc/translator/po/fi-FI-*

3. Check existence of backup files
ls misc/translator/po/fi-FI-*~

4. Reset to HEAD and clean

5. Apply the patch

6. Update again, check there are no more obsoleted
strings nor backup files

Signed-off-by: Fridolin Somers 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #27 from Jonathan Druart  ---
(In reply to Bernardo Gonzalez Kriegel from comment #25)
> > Could you detail why this change is useful please? Maybe a small comment
> > would be helpful.
> 
> There is a comment in bug description, point a), But no problem :) 

I was thinking a comment in the code. But it could be retrieve from this bug
report :)

(In reply to Bernardo Gonzalez Kriegel from comment #26)
> Thanks for your comments :)

Thanks for your answers, all look good and nothing is blocker in my opinion.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11244] notices ignoring the dateformat preference

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244

--- Comment #21 from Jonathan Druart  ---
(In reply to Olli-Antti Kivilahti from comment #16)
> Hi there!
> 
> Applied the bug.
> I am noticing a huge performance drop with cronjobs/overdue_notices.pl
> 
> getting 12 items to the message_queue takes 31s with this feature applied.
> getting 12 items to the message_queue takes 1s without this feature applied.
> 
> oops...

I don't reproduce. I generated 10 overdues, and I got:

koha@koha-qa:~/src (BZ11244↑⚡)% time perl misc/cronjobs/overdue_notices.pl
perl misc/cronjobs/overdue_notices.pl  1.46s user 0.05s system 76% cpu 1.976
total

koha@koha-qa:~/src (BZ11244↑⚡)% git checkout master
Switched to branch 'master'

koha@koha-qa:~/src (master⚡)% time perl misc/cronjobs/overdue_notices.pl
perl misc/cronjobs/overdue_notices.pl  1.32s user 0.05s system 73% cpu 1.853
total

I have 5 dates in the template:
[skip]
<><><>
[skip]
<><>
[skip]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12389] New: hide collections/locations if not for that branch

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12389

Bug ID: 12389
   Summary: hide collections/locations if not for that branch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

If a library chose a branch limitation for a collection code or shelving
location then it should be hidden in the OPAC if using a custom URL or if
you're logged in at a branch that shouldn't see the types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8064] Merge several biblio records

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #49 from Paola Rossi  ---
I try to apply against master 3.17.00.007

Applying: Bug 8064: Merge several biblios
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 8064: Merge several biblios

I pass the patch to "Patch doesn't apply" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

Owen Leonard  changed:

   What|Removed |Added

Version|3.10|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12387] "Digests only?" can confuse patrons

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12387

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 10174 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10174] Digest is confusing

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174

Owen Leonard  changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #12 from Owen Leonard  ---
*** Bug 12387 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12385] Problem Searching

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12385

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This sounds like a support request rather than a bug report. Please consult
your options for getting Koha support:

http://koha-community.org/support/

...particularly the Koha mailing list. Keep in mind that any requests for help
should include the version of Koha you are using.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 569] Searches need 'browse' option

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569

Owen Leonard  changed:

   What|Removed |Added

 CC||k...@freefriends.org

--- Comment #1 from Owen Leonard  ---
*** Bug 12383 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12383] search results including nearby non-matches

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12383

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---
I believe what you are describing is covered by Bug 569, one of Koha's oldest
open enhancement requests.

*** This bug has been marked as a duplicate of bug 569 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12380] can't tab to save buttons on add item

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12380] can't tab to save buttons on add item

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12380

--- Comment #1 from Owen Leonard  ---
Created attachment 28734
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28734&action=edit
Bug 12380 - can't tab to save buttons on add item

Many form elements on the add item page are giving a tabindex of "1" by
the script. This seems to make it impossible to tab through the add item
form fields onto the save buttons. I don't see a reason to set an
explicit tabindex of "1," so this patch removes it.

To test, apply the patch and open an item for editing. Try tabbing
through the add item form fields. It should be possible to tab through
the fields and onto the submit buttons at the bottom. Test again when
adding a new item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12150] Use more placeholders in translatable javascript strings

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12150] Use more placeholders in translatable javascript strings

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12150

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #27697|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 28733
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28733&action=edit
[SIGNED-OFF] Bug 12150 - Use more javascript string formatting in intranet for
translated strings.

http://bugs.koha-community.org/show_bug.cgi?id=12150

Signed-off-by: Bernardo Gonzalez Kriegel 

No bug number on description
No commit message
No test plan
No koha-qa errors

I only signed this because it's useful for translations
but we can live without it, so is up to QA now

Tested some easy messages (e.g. syspref saving), and
updated PO files to check new strings.
Inspected the code, I think that there are no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12388] New: IssueSlip output should be sorted by date_due, not timestamp

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388

Bug ID: 12388
   Summary: IssueSlip output should be sorted by date_due, not
timestamp
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org

Sorting the quick slip output by date_due is more useful for patrons - the
timestamp when the issues was created is not as important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected.

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3144] anti-spam for opac-suggestions

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144

Mason James  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #107 from Katrin Fischer  ---
Another small one: Some time ago the email address was added to the information
displayed, with the patch we have a small regression there as it no longer
displays.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #106 from Katrin Fischer  ---
Found another tiny issue: missing space between category and type: Staff(S)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #105 from Katrin Fischer  ---
Giving this some quick tests for today, hopefully more soon:

Tested with problems:

1) Sending an empty search from the patrons module top search results in a perl
error: Can't use an undefined value as an ARRAY reference at
/usr/lib/perl5/DBI.pm line 2059.

2) There is a sort option on the first column with the checkboxes for the
patron list feature, but if you sort with checkboxes checked, all checkboxes
are unchecked.

3) I had it happen that my existing patron lists didn't show up in the pull
down - after switching to master and back to the branch with the patches
applied, I can't reproduce that. So for now this is mostly a note to keep an
eye out for that.

Suggestions:

3) It would be nice to be able to sort on the 'fines' column as well.

Tested OK:

1) Searching for % still returns all borrowers.

2) Alphabetic browse still works correctly.

Does someone know a good trick to add a few thousand borrowers easily? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12279] Diacritics in system preference editor broken

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12279

--- Comment #22 from Jonathan Druart  ---
(In reply to Jonathan Druart from comment #19)
> Created attachment 28614 [details] [review]
> Bug 12279: Diacritics in system preference editor broken

Patch provided on bug 11944 (actually it just reverts this one).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

--- Comment #203 from Jonathan Druart  ---
commit 35884cf951c2aaa7d57daef264be9eca3c2760bc
Author: Jonathan Druart 
Date:   Mon Jun 9 12:44:35 2014 +0200

Revert "Bug 12279: Diacritics in system preference editor broken"

This reverts commit 2fa2480447a58f9d5d3f7834bcfdcf62a0a95df3.

Conflicts:
admin/preferences.pl

It fixes regression introduced by bug 12279.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #202 from Jonathan Druart  ---
It's really a pain to upload/maintain these patches up-to-date on the bug
report. I pushed the patches on a remote branch:
  https://git.biblibre.com/biblibre/kohac/commits/ft/bug_11944

The url of the remote is http://git.biblibre.com/biblibre/kohac.git

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28046|0   |1
is obsolete||
  Attachment #28047|0   |1
is obsolete||
  Attachment #28048|0   |1
is obsolete||
  Attachment #28049|0   |1
is obsolete||
  Attachment #28050|0   |1
is obsolete||
  Attachment #28051|0   |1
is obsolete||
  Attachment #28052|0   |1
is obsolete||
  Attachment #28053|0   |1
is obsolete||
  Attachment #28054|0   |1
is obsolete||
  Attachment #28055|0   |1
is obsolete||
  Attachment #28056|0   |1
is obsolete||
  Attachment #28057|0   |1
is obsolete||
  Attachment #28059|0   |1
is obsolete||
  Attachment #28060|0   |1
is obsolete||
  Attachment #28061|0   |1
is obsolete||
  Attachment #28245|0   |1
is obsolete||
  Attachment #28246|0   |1
is obsolete||
  Attachment #28247|0   |1
is obsolete||
  Attachment #28248|0   |1
is obsolete||
  Attachment #28249|0   |1
is obsolete||
  Attachment #28250|0   |1
is obsolete||
  Attachment #28251|0   |1
is obsolete||
  Attachment #28253|0   |1
is obsolete||

--- Comment #201 from Jonathan Druart  ---
Created attachment 28732
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28732&action=edit
Bug 11944: (follow-up) Remove all utf8 filter from templates

This patch removes 2 new occurrences introduced by bug 11351 and bug
10493.

Signed-off-by: Magnus Enger 
Removes a nasty "Template process failed: plugin error - EncodeUTF8:
plugin not found at /home/magnus/scripts/kohaclone/C4/Templates.pm line 124"
from /cgi-bin/koha/admin/itemtypes.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28732|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12387] New: "Digests only?" can confuse patrons

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12387

Bug ID: 12387
   Summary: "Digests only?" can confuse patrons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org

The patron messaging preferences in OPAC shows a "Digests only?" -column. This
is apparently confusing for some patrons, so perhaps a tooltip or something
could make things clearer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12086] Hold priorities incorrect, when waiting status was reversed

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086

--- Comment #20 from Katrin Fischer  ---
Kyle, could you take another look at comments 16 and 19? 

I like Jonathan's suggestion on renaming the file to make the purpose more
clear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12293] Remove Problematic Logic from Patron Messaging Preferences Form - bootstrap

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12293

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12293] Remove Problematic Logic from Patron Messaging Preferences Form - bootstrap

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12293

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #28635|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 28731
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28731&action=edit
[PASSED QA] Bug 12293: Correct display for patron messaging preferences on OPAC
- bootstrap

This patch is a follow-up for bug 11125, it fixes the bootstrap theme.

Test plan:
1) Remove 'sms' from message_transport_types table.
2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading.
3) Apply patch => table is correctly displayed.

Signed-off-by: Axelle Clarisse 
Signed-off-by: Katrin Fischer 
With and without 'sms' existing the display of the table is now correct.
Template only change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12386] New: 'Days in advance' pull down in bootstrap OPAC is huge

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386

Bug ID: 12386
   Summary: 'Days in advance' pull down in bootstrap OPAC is huge
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Created attachment 28730
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28730&action=edit
screenshot of 'your messaging' in bootstrap OPAC

In the bootstrap opac the pull down to set the days in advance for the reminder
email is too long for the content it displays. Not sure if there is a reason
for it or of it is a problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Jonathan Druart  ---
(In reply to Kyle M Hall from comment #8)
> Problems:

Good catch Kyle, thanks!

> 1) If you create a new notice with the same module/code/branch as an
> existing letter  it will overwrite the existing letter without notice

Should be fixed.

> 2) If you choose to edit a notice, and change it's module/code/branch to
> match another letter, it will overwrite the other letter, while leaving the
> one you edited unmodified!

Should be fixed too.

> I think letters is in serious need of an id column.

Yes definitely, but it is a big change!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11742] Overdue notice/status triggers displaying the wrong notice for default

2014-06-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11742

--- Comment #9 from Jonathan Druart  ---
Created attachment 28729
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28729&action=edit
Bug 11742: FIX the code parameter was not take into account

In C4::Letters::GetLetters, the code filter was not used as a query
parameter.

Moreover, the JS code was buggy. We only need to check the letter code,
except if it is an edit and the letter code has not been changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >