[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #2 from David Cook dc...@prosentient.com.au ---
There's a bit of odd code in  Koha\QueryParser\Driver\PQF\query_plan\node.pm,
which is where a lot of the action happens in QP...

When doing a Library Catalog search, it tries to use the following code to
create a relevance query branch:

$fieldobj = $self-plan-QueryParser-bib1_mapping_by_name('field',
$relbump-{'classname'}, $relbump-{'field'}, $server);

This means $fieldobj, which should contain our CCL2RPN type mapping, will
always be null because $relbump-{'classname'} and $relbump-{'field'} don't
exist.

This is why the 2nd line in the following code doesn't have an @attr 1=1016 in
it. 

@attr 1=1016 @attr 5=1 @attr 4=6 test 
@or
@attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6 test

But we don't notice the error in the OPAC, as I think Zebra/Yaz/Zoom/whatever
silently treats the second branch as having @attr 1=1016 as a bare search will
usually be treated as a keyword (ie @attr 1=1016). 

--

Here is another odd bit of code, which is responsible for QueryParser's current
support for relevance.

my $relbumps = $self-plan-QueryParser-bib1_mapping_by_name('relevance_bump',
$self-classname, '', $server);

This line will return ALL the relevance_bump mappings under the keyword
class...which are 'titleext' and 'titlekw'.

I think these may have been example mappings...as it doesn't really make sense
to have them under a keyword class search. It should be a keyword class
search with a keyword field rather than a titleext field, in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (and has issues when using QueryParser)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #3 from David Cook dc...@prosentient.com.au ---
In any case, you can add relevance mappings to QueryParser by adding additional
config in queryparser.yaml.

For instance:
  title:
title:
  enabled: 1
  bib1_mapping:
biblioserver: 30

This will add relevance ranking to a title search with a field weight of 30.

However, it's worth noting that QueryParser seems to often fall back to
non-QueryParser mode for more complicated indexes like ti,phr, so...I
wouldn't go out and make a lot of QP mappings just yet...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #2 from Viktor Sarge viktor.sa...@regionhalland.se ---
(In reply to Nicole C. Engard from comment #1)
 Anyone have any ideas on this?

My understanding is that they have indeed found the problem and that the
maximum-scale attribute is often used to prevent content from being blown up
and get blurry images on for example iPad. It would be easy to remove I guess,
but since it will have all manners of effects on different platform I think
there should be more discussion on the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

Summary|Truncation disables |Truncation disables
   |relevance ranking (and has  |relevance ranking when not
   |issues when using   |using QueryParser
   |QueryParser)|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #4 from David Cook dc...@prosentient.com.au ---
Created attachment 28880
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28880action=edit
Bug 12430 - Truncation disables relevance ranking when not using QueryParser

The system preference QueryWeightFields is mutually exclusive with
the system preference QueryAutoTruncate and the * truncation
modifier, when not using QueryParser.

If you use truncation, relevance won't work anymore. (N.B. Relevance
doesn't work probably when using QueryParser, but for a very different
reason beyond the current scope of this bug.)

This patch adds relevance ranking when using truncation (or basically
when QueryWeightFields is disabled).

_TEST PLAN_

1) Turn on QueryWeightFields and QueryAutoTruncate
2) Turn off TryQueryParser
3) Do a keyword search in the OPAC
4) Note that the results are ordered by biblionumber ascending

5) Apply patch

6) Do the same keyword search in the OPAC
7) Note that the results are never ordered differently
(presumably in relevance order :P)

If you're a stickler, throw in some warns so that you can see
what CCL query is being sent to Zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12431] Relevance does not work properly when using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12431

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Try doing a Title search or a Subject search and you'll see that results
are returned in ascending biblionumber order and not in order of relevance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12431] New: Relevance does not work properly when using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12431

Bug ID: 12431
   Summary: Relevance does not work properly when using
QueryParser
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Currently, when using QueryParser, relevance will only work for keyword
queries.

queryparser.yaml either needs to be updated to include more weighted relevance
mappings, or QueryParser needs a mechanism to add relevance to queries beyond
the limited support it currently has.

More information available here:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

--- Comment #2 from Viktor Sarge viktor.sa...@regionhalland.se ---
*** Bug 11968 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11968] add RSS icon next to each search on search history

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11968

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||viktor.sarge@regionhalland.
   ||se
 Resolution|--- |DUPLICATE

--- Comment #1 from Viktor Sarge viktor.sa...@regionhalland.se ---


*** This bug has been marked as a duplicate of bug 5672 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

--- Comment #3 from Viktor Sarge viktor.sa...@regionhalland.se ---
Created attachment 28881
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28881action=edit
5672 Gives RSS icons to search history

This patch adds an extra column to the table for the search history (this
session and previous searches) with RSS icons for each search.

Test plan:
* Verify that there is no RSS icons for saved searches in opac
* Install the patch
* Verify that there is no RSS icons for saved searches and searches for the
current session in Opac.
* Test that the RSS links produce the expected result.

Note: I left out authority searches since I have very little experience with
authority searches and didn't feel I could test it properly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12432] New: Saved reports tabs not working

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432

Bug ID: 12432
   Summary: Saved reports tabs not working
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: PC
OS: Windows
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: k...@jsense.co.uk
QA Contact: testo...@bugs.koha-community.org

In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but
after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change
but the table of reports is not filtered. There are no errors reported in the
browser console.

IE version 11.0.9600.17107
Chrome version 35.0.1916.153 m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12328] report actions don't work in Chrome

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12328

Pete Edwards k...@jsense.co.uk changed:

   What|Removed |Added

 CC||k...@jsense.co.uk

--- Comment #2 from Pete Edwards k...@jsense.co.uk ---
I saw it first in 3.14.05.000 but it is still a problem in 3.16.00.000. I only
had 39 reports but you are right - anything beyond the 20th and the popup
doesn't appear until you click one of the first 20. Changing the sort order has
no effect - it is not the first 20 listed reports, nor reports up to ID=20 but
simply the first 20 in ID order. It is not a problem in IE version
11.0.9600.17107 but fails in Chrome 35.0.1916.153 m.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12432] Saved reports tabs not working

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #1 from Magnus Enger mag...@enger.priv.no ---
Confirmed! The table of reports stays the same no matter what tab is clicked.
Tested with Firefox 30.0 on Ubuntu 14.04.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11495] i18n toolchain misses one instance of text Select titles to: in bootstrap

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11495

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #5 from Frédéric Demians frede...@tamil.fr ---
Fridolyn: This patch would deserved to be pushed to 3.14. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #3 from Juhani Seppälä jsep...@student.uef.fi ---
Created attachment 28882
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28882action=edit
Bug 12261: Staff client next/previous links lead to unknown record

When using Staff client next/previous links after a search :
If the current record is the last of the results, clicking on next will lead
to the page of an unknown record with message :

The record you requested does not exist (NaN).

To test:
1) Do an intranet catalog search that has more than 1 results.
2) Click on the last search result and then click the Next-button from the
top-left navigation.
3) Confirm that you get thrown to a page with the message: The record you
requested does not exist (NaN)..
4) Apply patch.
5) Repeat steps 1 - 2.
6) Confirm that the navigation button for Next is greyed out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Frederic, this is a duplicate - one sec.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] New: Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

Bug ID: 12433
   Summary: Suggestion status 'Ordered' and 'Available' displayed
as 'Unknown'
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: frede...@tamil.fr
QA Contact: testo...@bugs.koha-community.org

In Acquisitions  Suggestions, there is a tabs bar displaying by default
five suggestion status. Two of them  are improperly displayed as
'Unknown'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
*** Bug 12433 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---


*** This bug has been marked as a duplicate of bug 10519 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr
   |ity.org |

--- Comment #3 from Frédéric Demians frede...@tamil.fr ---
Created attachment 28883
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28883action=edit
Proposed patch

Bug 12433 - Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

In Acquisitions  Suggestions, there is a tabs bar displaying by default
five suggestion status. Two of them  are improperly displayed as
'Unknown'.

To test:

1 Without the path, go to Acquisitions  Suggestions.
2 You can see two tabs labeled Unknown
3 Apply the patch
4 Go to Acquisitions  Suggestions
5 'Unknown' tabs are now displayed: Available and Ordered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #4 from Frédéric Demians frede...@tamil.fr ---
Created attachment 28884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28884action=edit
Screenshot without patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think maybe a little different, but pretty confident the bug I liked should
also solve this problem. Someone needs to try :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] New: Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

Bug ID: 12434
   Summary: Typos in help files
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Starting a new bug as I noticed some typos in the help files. One I can't find
again now, but this is the other:


intranet-tmpl/prog/en/modules/help/admin/smart-rules.tt:59
If you're allowing renewals you can control how long the renewal loan peiod
will be (in the units you have chosen) in the 'Renewal period' box
 peiod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I will try to take a look and confirm later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #6 from Frédéric Demians frede...@tamil.fr ---
(In reply to Katrin Fischer from comment #2)
 
 *** This bug has been marked as a duplicate of bug 10519 ***

Are you sure?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #5 from Frédéric Demians frede...@tamil.fr ---
Created attachment 28885
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28885action=edit
Screenshot with patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12435] New: Update MARC21 frameworks to Update No. 18 (April 2014)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12435

Bug ID: 12435
   Summary: Update MARC21 frameworks to Update No. 18 (April 2014)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Update No. 18 (April 2014) includes changes resulting from proposals that were
considered by the MARC 21 community during January 2014.[1]


[1] http://www.loc.gov/marc/bibliographic/bdapndxg.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12436] New: koha-offline-circulation menu database and link on circulation page

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12436

Bug ID: 12436
   Summary: koha-offline-circulation menu database and link on
circulation page
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: stephane.del...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

1/ From the page  ../cgi-bin/koha/circ/circulation-home.pl the link Get
desktop application is ko

2 / After installing the tool from this url
http://sourceforge.net/projects/koha-oc/files/?source=navbar
In the tool I do not have the Database menu to load the file borrower.db

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #9 from Frédéric Demians frede...@tamil.fr ---
You're correct. It's a duplicate! Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12433] Suggestion status 'Ordered' and 'Available' displayed as 'Unknown'

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12433

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx for checking Frederic, now you beat me to it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12435] Update MARC21 frameworks to Update No. 18 (April 2014)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12435

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|oleon...@myacpl.org |jsep...@student.uef.fi

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
(In reply to Juhani Seppälä from comment #3)
 Created attachment 28882 [details] [review]

Thanks for the patch Juhani! I'm assigning the bug to you (since you submitted
a patch) and setting the status of the bug to Needs signoff so that the bug
shows up in the queue of bugs to be tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496

--- Comment #3 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
There is no need amha to implement such logic, because for tighter matches,
even if the limit is high, only a few results will be returned.

ie: having a limit of 1000 will not slow down things for isbn, because only a
few isbn's will be returned.

We can safely have a high limit even for tighter matches.

As for your second point, 1000 could possibly fail, but very less likely than
with 10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #5 from Owen Leonard oleon...@myacpl.org ---
Testing in master I get a different buggy behavior than is described in this
bug report.

1) Did a search in the staff client which returned a few pages of results.
2) Clicked on the last page of results.
3) Clicked on the last result on the last page.
4) Clicked on the Next button.
5) Instead of getting an error, I'm redirected to a record which originally
appeared on the first page of the search results returned in step 1. It looks
like I'm redirected to the 12th record in particular.

I get the same behavior before and after the patch. Tested in FF30 and Chrome
35 on Windows 7.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12435] Update MARC21 frameworks to Update No. 18 (April 2014)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12435

--- Comment #1 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 28886
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28886action=edit
Bug 12435 - Update MARC21 frameworks to Update No. 18 (April 2014)

This patch updates MARC21 frameworks to Update No. 18 (April 2014)
Also updates values on database for MARC21 installs.

To test
1. Apply the patch
2. Run updatedatbase.pl, check that runs without error
3. Remove default framework, load again. Check that loads without
error.
4. Verify changes
Bibs
007/04 Sound recording - q Quadraphonic, multichannel, or surround
347f - Encoded bitrate
110/1,610/1,710/1,810/1 subfield c - repeatable
Auth
110/1,410/1,510/1,710/1 subfield c - repeatable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #384 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28889
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28889action=edit
Bug 6427 [Part 31] - Restore the lost item fee description

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12437] items.enumchron 952$h field not populated while sending Routing List Notice

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Binu,

are you creating real items for your subscriptions? Only then 952$h will be
populated. Else you might want to try serial.serialseq.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8836] Resurrect Rotating Collections

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Juhani Seppälä jsep...@student.uef.fi changed:

   What|Removed |Added

 CC||jsep...@student.uef.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12437] items.enumchron 952$h field not populated while sending Routing List Notice

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437

Binu Thomas b...@eclateng.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12437] New: items.enumchron 952$h field not populated while sending Routing List Notice

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12437

Bug ID: 12437
   Summary: items.enumchron 952$h field not populated while
sending Routing List Notice
 Change sponsored?: ---
   Product: Koha
   Version: 3.14
  Hardware: All
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: b...@eclateng.com
QA Contact: testo...@bugs.koha-community.org

Hi

The Routing List mail sent from Tools - Notices  Slips. The 952$h field is
mapped to items.enumchron in the Serial Framework. The data is populated in
MySQL items table also. But when the mail is sent, this value is not present in
the mail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #383 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 2
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2action=edit
Bug 6427 [Part 30] - Do not auto-print reciepts for manual invoices

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #382 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28887
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28887action=edit
Bug 6427 [Part 29] - Force the amount to pay to display as a two decimal float

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #385 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28890
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28890action=edit
Bug 6427 [Part 32] - Fix koha-qa.pl issues

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

--- Comment #1 from simith.dolive...@inlibro.com ---
Created attachment 28891
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28891action=edit
Bug 11062 - Invoice's shipment/shipping cost should be included PRE-gst tax (as
an option)

Koha's users don't have the option to enter shipping tax.
This fix allow to vendors add a specific tax (included in gist preference) to
shipping cost.

Modified:
added two columns, shippingincgst and sgstrate in aqbooksellers. Some files
changed:
C4/Bookseller.pm
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl
acqui/updatesupplier.pl
acqui/supplier.pl
acqui/parcels.pl
t/db_dependent/Bookseller.t

acqui/invoice.pl - total_gste_shipment and total_gsti_shipment calcul changed

koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/supplier.tt  - Shipping tax rate
and shipping include tax or don't include tax, added
koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/parcels.tt   - (tax exc.) or
(tax inc) added beside Shipping cost.
koha-tmpl/intranet-tmpl/prog/en/modiles/acqui/invoice.tt   - if shipping tax
exc, add Shipping cost (tax inc) below Shipping cost

0) Apply the patch
1) Run updatedatabase.pl to add the two columns to aqbooksellers
2) Add some tax rates in gist preferences
3) Edit a vendor
4) Chose shipping prices: include tax or not
5) Chose a shipping tax rate
6) Save
7) Create an order in a vendor's basket
8) click button receive shipment
9) Validate (tax exc.) or (tax inc) added beside Shipping cost.
10) Click link Receive order in pending orders
11) Save
12) Click Finish receiving
13) Validate shipping tax ex, add Shipping cost (tax inc) below Shipping
cost if shipping tax exc.
14) Validate last line Total + Shipment cost (CDN)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #39 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28892
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28892action=edit
MT8122: Adds Shibboleth authentication

 - Use the shibbolethAuthentication syspref to enable Shibboleth authentication
 - Configure the shibbolethLoginAttribute to specify which shibboleth user
   attribute matches the koha login
 - Make sure the OPACBaseURL is correctly set

MT8122, Follow-up: Adds Shibboleth authentication

 - Fix logout bug: shibboleth logout now occurs only when
   the session is a shibboleth one.
 - Do some refactoring: getting shibboleth username is now
   done in C4::Auth_with_Shibboleth.pm (get_login_shib function)

MT8122, Follow-up: Adds Shibboleth authentication

 - Adds redirect to opac after logout

MT8122, Follow-up: Adds Shibboleth authentication

 - Shibboleth is not compatible with basic http authentication
   in C4/Auth.pm. This patch fixes that.

MT8122, Follow-up: Adds Shibboleth authentication

 - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
   multiple vhosts.

MT8122, Follow-up: Adds Shibboleth authentication

 - Adds missing protocol for $ENV{'SERVER_NAME'}

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver pianohac...@gmail.com
(ByWater employee.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #40 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28893
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28893action=edit
BUG8446, Follow up: Adds Shibboleth authentication

- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
  work if koha is behind a reverse proxy.
  - To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325

BUG8446, Follow up: Adds Shibboleth authentication

- Ensure user is returned to requested page after authentication
  - Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345

BUG8446, Follow up: Remove unused imports from scripts

- Remove import of deprecated C4::Utils module from shibboleth
  authentication module: Auth_with_shibboleth.pm

Signed-off-by: Jesse Weaver pianohac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26760|0   |1
is obsolete||

--- Comment #42 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28895
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28895action=edit
BUG8446, Follow up: Improve local login fallback

- Local fallback was not very well implimented, this patch adds
  better handling for such cases allowing clearer failure messages
- This patch also adds the ability to use single sign on via the
  top bar menu in the bootstrap theme.

BUG8446, Follow up: Adds perldoc documentation

- Add some documentation to the Auth_with_Shibboleth module
  including some guidance as to configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #41 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28894
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28894action=edit
BUG8446, Follow up: Remove unnecessary sysprefs, move to config

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26762|0   |1
is obsolete||

--- Comment #44 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28897
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28897action=edit
BUG8446, Follow up: Correct paths after file rename

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26761|0   |1
is obsolete||

--- Comment #43 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28896
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28896action=edit
BUG8446, Follow up: Correct filenames to match guidlines

- Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match
  other files present on the system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26749|0   |1
is obsolete||

--- Comment #45 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28898action=edit
[SIGNED OFF] MT8122: Adds Shibboleth authentication

 - Use the shibbolethAuthentication syspref to enable Shibboleth authentication
 - Configure the shibbolethLoginAttribute to specify which shibboleth user
   attribute matches the koha login
 - Make sure the OPACBaseURL is correctly set

MT8122, Follow-up: Adds Shibboleth authentication

 - Fix logout bug: shibboleth logout now occurs only when
   the session is a shibboleth one.
 - Do some refactoring: getting shibboleth username is now
   done in C4::Auth_with_Shibboleth.pm (get_login_shib function)

MT8122, Follow-up: Adds Shibboleth authentication

 - Adds redirect to opac after logout

MT8122, Follow-up: Adds Shibboleth authentication

 - Shibboleth is not compatible with basic http authentication
   in C4/Auth.pm. This patch fixes that.

MT8122, Follow-up: Adds Shibboleth authentication

 - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with
   multiple vhosts.

MT8122, Follow-up: Adds Shibboleth authentication

 - Adds missing protocol for $ENV{'SERVER_NAME'}

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

http://bugs.koha-community.org/show_bug.cgi?id=8446
Signed-off-by: Jesse Weaver pianohac...@gmail.com
(ByWater employee.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26750|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28899
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28899action=edit
[SIGNED OFF] BUG8446, Follow up: Adds Shibboleth authentication

- Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont
  work if koha is behind a reverse proxy.
  - To use multiple vhosts, set OpacBaseURL per vhost explicitly with
'SetEnv OpacBaseURL Value' as per Bug 10325

BUG8446, Follow up: Adds Shibboleth authentication

- Ensure user is returned to requested page after authentication
  - Added querystring to the target path in shibboleth URL so
that when a user is authenticated he/she is returned to the
correct page they requested before authentication.
Example where this is important: When a user clicks a direct
biblio link of the form - /opac-detail.pl?biblionumber=12345

BUG8446, Follow up: Remove unused imports from scripts

- Remove import of deprecated C4::Utils module from shibboleth
  authentication module: Auth_with_shibboleth.pm

Signed-off-by: Jesse Weaver pianohac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #26751|0   |1
is obsolete||

--- Comment #47 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28900
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28900action=edit
[SIGNED OFF] BUG8446, Follow up: Remove unnecessary sysprefs, move to config

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28895|0   |1
is obsolete||

--- Comment #48 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28901
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28901action=edit
BUG8446, Follow up: Improve local login fallback

- Local fallback was not very well implimented, this patch adds
  better handling for such cases allowing clearer failure messages
- This patch also adds the ability to use single sign on via the
  top bar menu in the bootstrap theme.

BUG8446, Follow up: Adds perldoc documentation

- Add some documentation to the Auth_with_Shibboleth module
  including some guidance as to configuration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28897|0   |1
is obsolete||

--- Comment #50 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28903
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28903action=edit
BUG8446, Follow up: Correct paths after file rename

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28896|0   |1
is obsolete||

--- Comment #49 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 28902
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28902action=edit
BUG8446, Follow up: Correct filenames to match guidlines

- Moved Auth_with_Shibboleth.pm to Auth_with_shibboleth.pm to match
  other files present on the system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28892|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28893|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #28894|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
Asking the library to confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

  Attachment #28879|0   |1
is obsolete||

--- Comment #6 from Nicole C. Engard neng...@gmail.com ---
Created attachment 28904
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28904action=edit
[SIGNED-OFF] Bug 12407 - phone label or data switched

Fix for switched phone numbers on patron details page.

This patch fixes switched phone numbers on patron details page and also makes
phone number labels more uniform.

To Test:

1. Apply the patch.
2. Create/modify a patron entering some unique data into the Secondary phone:
and Other phone: fields (different data for each).
3. Save the patron record.
4. Go to the patrons details page and make sure the data entered into the
Secondary phone: field is displaying next to the Secondary phone: label and
that the data entered into the Other phone: field is displaying next to the
Other phone: label.

Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5672] Search History Should have RSS Feeds

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5672

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

  Attachment #28881|0   |1
is obsolete||

--- Comment #4 from Nicole C. Engard neng...@gmail.com ---
Created attachment 28905
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28905action=edit
[SIGNED-OFF] 5672 Gives RSS icons to search history

This patch adds an extra column to the table for the search history (this
session and previous searches) with RSS icons for each search.

Test plan:
* Verify that there is no RSS icons for saved searches in opac
* Install the patch
* Verify that there is no RSS icons for saved searches and searches for the
current session in Opac.
* Test that the RSS links produce the expected result.

Note: I left out authority searches since I have very little experience with
authority searches and didn't feel I could test it properly.
Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #6 from Juhani Seppälä jsep...@student.uef.fi ---
(In reply to Owen Leonard from comment #5)
 Testing in master I get a different buggy behavior than is described in this
 bug report.
 
 1) Did a search in the staff client which returned a few pages of results.
 2) Clicked on the last page of results.
 3) Clicked on the last result on the last page.
 4) Clicked on the Next button.
 5) Instead of getting an error, I'm redirected to a record which originally
 appeared on the first page of the search results returned in step 1. It
 looks like I'm redirected to the 12th record in particular.
 
 I get the same behavior before and after the patch. Tested in FF30 and
 Chrome 35 on Windows 7.

Ah, yes, sorry. Looks like I didn't properly test the patch with big search
results (multi-page). I can take another look at this later - should the status
be changed for this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option)

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
Created attachment 28906
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28906action=edit
Bug 12434: Fix Typo in Smart Rules Help

This patch fixes a typos in the help file on the circ and
fine rules.

To test:

Visit admin  circ and fine rules
Click help in the top right
Confirm that period is not spelled peiod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
Manual already patched, help file patch attached here for sign off.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

Juhani Seppälä jsep...@student.uef.fi changed:

   What|Removed |Added

  Attachment #28882|0   |1
is obsolete||

--- Comment #7 from Juhani Seppälä jsep...@student.uef.fi ---
Created attachment 28907
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28907action=edit
Bug 12261: Staff client next/previous links lead to unknown record

When using Staff client next/previous links after a search :
If the current record is the last of the results, clicking on next will lead
to the page of an unknown record with message :

The record you requested does not exist (NaN).

To test:
1) Do an intranet catalog search that has more than 1 results.
2) Click on the last search result and then click the Next-button from the
top-left navigation.
3) Confirm that you get thrown to a page with the message: The record you
requested does not exist (NaN)..
4) Apply patch.
5) Repeat steps 1 - 2.
6) Confirm that the navigation button for Next is greyed out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9321] holds queue printable version

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9321] holds queue printable version

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9321

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #14464|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28908
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28908action=edit
Bug 9321 - holds queue printable version

It would be nice if there were a printable stylesheet for the holds
queue.  Right now it's a print screen basically and that means that the
table doesn't always fit on the page.

Test plan:
1) Browse to the holds queue
2) Print preview the page
3) Note it does not print well
4) Apply this patch
5) Refresh the page
6) Print preview the page again
7) Note the improvement in printability

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #8 from Juhani Seppälä jsep...@student.uef.fi ---
Added small changes anyway - this one works for me on both single-page search
results  larger search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #386 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28909
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28909action=edit
Bug 6427 [Part 33] - Remove unescaped key value pairs

Titles and other values with double quotes will break the javascript.
We do not need these unescaped values for any reason.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28756|0   |1
is obsolete||
 CC||matthias.meusburger@biblibr
   ||e.com

--- Comment #5 from Matthias Meusburger matthias.meusbur...@biblibre.com ---
Created attachment 28910
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28910action=edit
signed patch

Only a few people have the ability to test and sign-off CAS-related patches
(mainly because of the lack of available CAS servers I guess).

Since I have a CAS server, I've tested it ok (it was indeed broken), and signed
it off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

Matthias Meusburger matthias.meusbur...@biblibre.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com

--- Comment #7 from Gaetan Boisson gaetan.bois...@biblibre.com ---
When one clicks on delete record, if the record has items attached, the
javascript alert is displayed very briefly, then skipped, and Koha proceeds to
the deletebiblio page.
The record will not be deleted but we end up with a disgraceful full page
message:

ERROR when DELETING BIBLIO 433 : This Biblio has items attached, please delete
them first before deleting this biblio

While there doesn't seem to be a risk of accidentally deleting data, it would
be good to fix this behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] Bad encoding in acquisition basket

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

URL||cgi-bin/koha/acqui/basket.p
   ||l?basketno=x

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] New: Bad encoding in acquisition basket

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

Bug ID: 12438
   Summary: Bad encoding in acquisition basket
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

We noticed a bad encoding (diacritics replaced by ?) in acquisition basket
when updating a server to Debian Wheezy.
We found it comes from a query containing biblio.title twice.
Maybe the mysql newer version creates this side-effect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] Bad encoding in acquisition basket

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] Bad encoding in acquisition basket

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 28911
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28911action=edit
Bug 12438 - Bad encoding in acquisition basket

We noticed a bad encoding (diacritics replaced by ?) in acquisition basket
when updating a server to Debian Wheezy.
We found it comes from a query containing biblio.title twice.
Maybe the mysql newer version creates this side-effect.

Test plan :
- Create an order on a record containing a diacritic in title
- Look at the basket : cgi-bin/koha/acqui/basket.pl?basketno=x
= Without the patch the record title is bad encoded (with ?)
= With this patch the record title is well encoded
- Check also basket CSV export

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11817] Staff client next/previous browse JavaScript interferes with other JS functions

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11817

--- Comment #8 from Gaetan Boisson gaetan.bois...@biblibre.com ---
I spoke a little too fast here : this seems to be fixed in master. But i also
can't see the link back to results right now, so this might be linked.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #93 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28912
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28912action=edit
Bug 9303 [QA Followup 6] - Allow patrons to set visibility from your personal
details

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #28160|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9393] Fix bad label and add note to circulation.pl if borrower has pending modifications

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28913
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28913action=edit
Bug 9393: Capitalization fixes

Call No.  Call no.

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Jason Robb jr...@sekls.org changed:

   What|Removed |Added

 CC||jr...@sekls.org

--- Comment #94 from Jason Robb jr...@sekls.org ---
I'm a little late to this party but I wanted clarification and to express a
concern we have.

Currently in the staff version of this, not only can guarantors see guarantee
checkouts, but if multiple guarantees are linked to one guarantor, the kids can
see each other's checkouts.

Put into a real scenario: a parent(A) has two guarantees, a child(B) and a
foster child(C).

For this situation we'd want A to see B  C's checkouts, but we don't want B to
see C's checkouts or the opposite. It doesn't seem like that's possible right
now if I'm reading correctly. If B wants to share with A, they must also share
with C.

It would solve a lot of possible issues and create flexibility for different
family situations to have it set up like:
Allow Relative A to see checkouts? Y/N
Allow Relative B to see checkouts? Y/N
Allow Relative C to see checkouts? Y/N

I don't want to throw additional wrenches into this as it's been through enough
but maybe for future consideration?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

--- Comment #2 from Christopher Brannon cbran...@cdalibrary.org ---
I tested patch in sandbox 7.  It works, but the sandbox won't let me sign off
on it.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12332] pay.pl and purchase-suggestions.pl tabs do not show selected

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

--- Comment #3 from Christopher Brannon cbran...@cdalibrary.org ---
Sandbox gives me the following message on either patch when I try to sign off
on them:

It seems you don't have applied a patch, so you cannot sign it off. If you
applied patches from the right report, check the commit message of the last
patch. It should start with Bug X, if not, please inform the author of
the patch.

I don't know what a commit message is or where to find it.

Christopher

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12319] Novelist content doesn't work in Bootstrap

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12319

Galen Charlton gmcha...@gmail.com changed:

   What|Removed |Added

 CC||gmcha...@gmail.com

--- Comment #1 from Galen Charlton gmcha...@gmail.com ---
Not sure if this is a general issue, but I have observed that in a 3.14.4
database that uses the Bootstrap and has configured Novelist Select content to
display below the holdings tab, that it didn't display unless the opacbookbag
system preference was turned on.

This was because a JavaScript error about MSG_IN_YOUR_CART not being defined
was emitted, preventing further JS from running, including the one to load the
Novelist content.

Nicole: did the Koha OPAC in question happen to have opacbookbag turned off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #95 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Kyle M Hall from comment #93)
 Created attachment 28912 [details] [review]
 Bug 9303 [QA Followup 6] - Allow patrons to set visibility from your
 personal details

While this now decouples from the opac privacy, there is now no way to turn
this feature on or off. It's on all the time.

Was that the desired outcome?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

--- Comment #96 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Jason Robb from comment #94)
 I'm a little late to this party but I wanted clarification and to express a
 concern we have.
 
 Currently in the staff version of this, not only can guarantors see
 guarantee checkouts, but if multiple guarantees are linked to one guarantor,
 the kids can see each other's checkouts.
 
 Put into a real scenario: a parent(A) has two guarantees, a child(B) and a
 foster child(C).
 
 For this situation we'd want A to see B  C's checkouts, but we don't want B
 to see C's checkouts or the opposite. It doesn't seem like that's possible
 right now if I'm reading correctly. If B wants to share with A, they must
 also share with C.
 
 It would solve a lot of possible issues and create flexibility for different
 family situations to have it set up like:
 Allow Relative A to see checkouts? Y/N
 Allow Relative B to see checkouts? Y/N
 Allow Relative C to see checkouts? Y/N
 
 I don't want to throw additional wrenches into this as it's been through
 enough but maybe for future consideration?

I also agree with this, younger brother seeing an older sisters (and vice
versa) reading list could be awkward and undesired.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Severity|major   |normal

--- Comment #5 from David Cook dc...@prosentient.com.au ---
Changing the importance of this one as I suppose its severity is debateable...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12434] Typos in help files

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12434

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

  Attachment #28906|0   |1
is obsolete||

--- Comment #3 from David Cook dc...@prosentient.com.au ---
Created attachment 28914
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28914action=edit
Bug 12434 [SIGNED OFF]: Fix Typo in Smart Rules Help

This patch fixes a typos in the help file on the circ and
fine rules.

To test:

Visit admin  circ and fine rules
Click help in the top right
Confirm that period is not spelled peiod

Signed-off-by: David Cook dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11270] Search Result highlighting should be refactored

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11270

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #3 from David Cook dc...@prosentient.com.au ---
Could you post a test plan?

Also, the code seems slightly different in opac-results.tt versus
opac-results-grouped.tt.

I've never used the latter (as I don't use pazpar2), so I'm not sure I can test
this one...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #97 from Liz Rea l...@catalyst.net.nz ---
Eek,yes, this should work just as the staff client does, that a guarantee only
sees their own issues, and a guarantor sees all guarantee's issues.

Another example is in a corporate library, the supervisor may want to see all
subordinates issues, but each subordinate should have the expectation of
privacy. This feature isn't only used for familial relationships.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

2014-06-17 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #6 from David Cook dc...@prosentient.com.au ---
It appears that this patch could break the Publication Date () search,
when using yr,st-numeric (which might be the case after bug 9368).

If we were to use yr,st-year instead, you might get results for a 2000-
query but they would only be for 2000. If you specified a full range
2000-2012, it would break.

It seems that relevance can't be run with date ranges (which is usually fine,
as we use date ranges as limits which are not affected by relevance ranking).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >