[Koha-bugs] [Bug 7572] Add Clubs & Services Feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Magnus Enger changed: What|Removed |Added CC||mag...@enger.priv.no --- Comment #42 from Magnus Enger --- (In reply to David Cook from comment #41) > I'm curious why you've marked this one as resolved won't fix, Kyle. > Is it because of no progress on the bug or other reasons? > I'd still be interested in this going forward at some stage. See "Bug 12461 - Add patron clubs feature", perhaps? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #16 from Robin Sheat --- ...I forgot the OpacHiddenItems thing again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Robin Sheat changed: What|Removed |Added Attachment #29159|0 |1 is obsolete|| --- Comment #15 from Robin Sheat --- Created attachment 29160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29160&action=edit Bug 12252 - include item data in OAI-PMH ListRecords result Same in spirit to the other patch, this also includes the item detail in ListRecords. Test plan: * Fetch a URL like: http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml * Verify that there are 952 entries in the returned records where appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #14 from Robin Sheat --- Created attachment 29159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29159&action=edit Bug 12252 - include item data in OAI-PMH ListRecords result Same in spirit to the other patch, this also includes the item detail in ListRecords. Test plan: * Fetch a URL like: http://koha/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml * Verify that there are 952 entries in the returned records where appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > I'd like to see some unit tests for such a sensitive core functionality. > I know it is an almost trivial change, but we are introducing a new function > to C4::Search which needs to be documented (ut-driven documentation). > > It does, OTOH, look fine to me and would push it soon. If help is needed on > writing those tests don't hesitate to write me. I was thinking about unit tests when I wrote the patch, but I'm not really sure what sort of test would be appropriate for this type of function. I can write the test, but I don't know what to test, if that makes sense. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7572] Add Clubs & Services Feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #41 from David Cook --- I'm curious why you've marked this one as resolved won't fix, Kyle. Is it because of no progress on the bug or other reasons? I'd still be interested in this going forward at some stage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #26798|0 |1 is obsolete|| --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 29158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29158&action=edit [SIGNED-OFF] Bug 11230 - Refactor C4::Stats::UpdateStats and add UT This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Additionnaly it also - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) To test : 1. run "prove t/db_dependant/Stats.t -v" 2. make some circulation operations (checkout, checkin, renew, localuse) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) 3. make some fine payments operations (writeoff, payment) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) Note that there is probably an issue to fix in Accounts.pm : the user is saved instead of the branch. But this is not the purpose of this patch, so I kept the previous behavior for the moment. Signed-off-by: Bernardo Gonzalez Kriegel Work, test pass, isse/return/writeoff recorded on statistics Removed a "=back" to make happy koha-qa No other errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #18297|0 |1 is obsolete|| --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 29157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29157&action=edit [SIGNED-OFF] Bug 10308 - local subjects can use authorities too This adds entries for 690-699 to the authorities linker, so they get linked up like everything else. To Test: * make sure your framework doesn't have 690 set up to link to authorities (or it'll get linked as part of cataloguing.) * add a subject with some term to the 690$a field. * add an authority for TOPIC_TERM with the matching term. * make sure zebra is up to date. * run link_bibs_to_authorities.pl over your system. * check that the authority is now linked to your record. * repeat with the other 69x fields if you like. Signed-off-by: Bernardo Gonzalez Kriegel Tested using 696a (PERSO_NAME). Works as described, no errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #32 from Bernardo Gonzalez Kriegel --- First two are signed. Test plan for the remaining? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch Rebuild Items Tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #23593|0 |1
is obsolete||
--- Comment #6 from Bernardo Gonzalez Kriegel ---
Created attachment 29156
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29156&action=edit
[SIGNED-OFF] Bug 11399: batch Rebuild Items Tables
You can/must use it when you change items mapping.
this script rebuilds the non-MARC DB items table from the MARC values
usage : batchRebuildItemsTables.pl [ -h ][ -c ][ -t ][ -where ]
Options:
-h --help (or without arguments) shows this help message
-c Confirm: rebuild non marc DB (may be long)
-t test only, change nothing in DB
--where add where condition on default query
(eg. -where 'biblio.biblionumber<100')
(copied test plan)
to test it :
create a test item (eg on biblionumber 3) with a non mapped subfield with a
test value.
check real items DB row ( SELECT * from items where biblionumber=3 ) => non
mapped value is in more_subfields_xml
map the non mapped subfield with unused items column
re-check in Db that nothing changes
run ./batchRebuildItemsTables.pl -c --where 'biblio.biblionumber=3'
check real items DB row ( SELECT * from items where biblionumber=3 ) => new
mapped value is not in more_subfields_xml anymore but in the mapped column
Signed-off-by: Bernardo Gonzalez Kriegel
Work as described, no koha-qa errors.
Add a new item to record, save with value in unmapped subfield ('x')
Change mapping, run script, value on newly mapped column
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12455] The module C4/SMS.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12455 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29086|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29155&action=edit [SIGNED-OFF] Bug 12455: adding unit tests for the module C4/SMS.pm The module C4/SMS.pm was not tested Test plan: 1/ Execute the command : prove t/SMS.t 2/ The result has to be a success without error or warning : t/SMS.t .. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.17 cusr 0.02 csys = 0.23 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Replace stub test, all test pass. Removed "use strict/warnings", no need for that with "use Modern::Perl" No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12455] The module C4/SMS.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12455 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29009|0 |1 is obsolete|| --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 29154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29154&action=edit [SIGNED-OFF] Bug 12427: Allow execution of UTs on a DB with issues Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12427] C4::Members::Attributes.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12427 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29008|0 |1 is obsolete|| --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 29153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29153&action=edit [SIGNED-OFF] Bug 12427: adding unit tests of module C4::Members::Attributes.pm The subroutines UpdateBorrowerAttribute, SearchIdMatchingAttribute, DeleteBorrowerAttribute, GetBorrowerAttributes, GetAttributes, GetBorrowerAttributeValue, SetBorrowerAttributes and CheckUniqueness of the module C4::Members::Attributes.pm were not tested. Test plan: 1/ Execute the command: prove t/db_dependent/Members_Attributes.t 2/ The result has to be: t/db_dependent/Members_Attributes.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.45 cusr 0.08 csys = 1.58 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Test with patrons on db having issues and attributes New test file, all test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #28864|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 29152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29152&action=edit [SIGNED-OFF] Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm The module Koha::Borrower::Files.pm was not tested To test: 1/ Execute the command: prove t/db_dependent/Borrower_Files.t 2/ The command has to print: t/db_dependent/Borrower_Files.t .. ok All tests successful. Files=1, Tests=23, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.47 cusr 0.08 csys = 1.60 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel New test file, all test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12294] Revert BZ9372
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #28374|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 29151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29151&action=edit [SIGNED-OFF] Bug 12294 : Cancel replacing carriage return on notices Cancel replacing carriage return with in printed html file as is needed in model for email notices when html format is checked Test plan : * define an OVERDUE notice with html activated, with at each end of line * make sur you've got some borrowers with overdues meeting your notices triggering rules (some with valid email and others without) * run overdue_notices.pl -html to generate html files for borrowers without email Without patch * email notifications are correctly formated as html content, with one at each end of line * in html file, is duplicated at each end of line With patch * nothing changes for email notification * html file is correctly formatted with only one at each end of line Signed-off-by: Bernardo Gonzalez Kriegel Copied test plan from comment. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12294] Revert BZ9372
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12393] OverDrive does not depend on SSL modules for LWP, causing searches to fail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12393 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #13 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Yohann! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12462] Fix some POD errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12462 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12296] OPAC search box should be customisable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12296 --- Comment #16 from Robin Sheat --- (In reply to Katrin Fischer from comment #14) > There are some small things with this patch: > - It includes lots of whitespace changes that would be better in a separate > patch. All it is is ensuring that the indentation remains consistent. Adding -w to the git commands (e.g. diff and show) will cause the things that are only whitespace changes to be hidden. > - It puts the new pref at the end of the alphabetized syspref file in its > own SQL statement. > - It includes changes to the prog theme. These I'll sort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Liz Rea changed: What|Removed |Added Depends on||12233 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12233] remove prog and CCSR OPAC themes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 Liz Rea changed: What|Removed |Added Status|RESOLVED|REOPENED CC||l...@catalyst.net.nz Blocks||11346 Resolution|DUPLICATE |--- --- Comment #2 from Liz Rea --- I think this is actually a dependent of bug 11346, as it will be one of the tasks necessary to deprecate the theme :) Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11346] Deprecate the PROG and CCSR themes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11346 Bug 11346 depends on bug 12233, which changed state. Bug 12233 Summary: remove prog and CCSR OPAC themes http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11586] Better default framework for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 mathieu saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #12 from Katrin Fischer --- Created attachment 29150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29150&action=edit [PASSED QA] Bug 12416: add new tests of DelUniqueDebarment The subroutine DelUniqueDebarment was not enough tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=31, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.44 cusr 0.08 csys = 1.56 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel All 31 test pass, no koha-qa errors Signed-off-by: Katrin Fischer All tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 --- Comment #11 from Katrin Fischer --- Created attachment 29149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29149&action=edit [PASSED QA] Bug 12416: the subroutine 'ok' is replaced by the subroutine 'is' The use of the subroutine 'is' is prefered over the subroutine 'is' To test: execute the commande prove t/db_dependent/Borrower_Debarments.t To command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.42 cusr 0.08 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comments on last patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12416] DelUniqueDebarment (Debarments.pm) is not tested in Borrower_Debarments.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12416 Katrin Fischer changed: What|Removed |Added Attachment #29139|0 |1 is obsolete|| Attachment #29140|0 |1 is obsolete|| Attachment #29141|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 29148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29148&action=edit [PASSED QA] Bug 12416: add the test of DelUniqueDebarment The subroutine DelUniqueDebarment was not tested To test: execute the command prove t/db_dependent/Borrower_Debarments.t The command has to print: t/db_dependent/Borrower_Debarments.t .. ok All tests successful. Files=1, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.43 cusr 0.07 csys = 1.54 CPU) Result: PASS Signed-off-by: Bernardo Gonzalez Kriegel Comments on last patch Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12462] Fix some POD errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12462 Katrin Fischer changed: What|Removed |Added Attachment #29136|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 29147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29147&action=edit [PASSED QA] Bug 12462: Fix some POD errors Bug 12041 made xt/author/podcorrectness.t consider files in the 'Koha' namespace. Some of them where failing. This patch fixes some of those POD problems. Best regards To+ Test: 1) run prove xt/author/podcorrectness.t it fails 2) apply patch 3) run again, now it's ok Signed-off-by: Bernardo Gonzalez Kriegel Before patch test fails. After it, it pass No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12462] Fix some POD errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12462 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer changed: What|Removed |Added Attachment #29145|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 29146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29146&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I am not sure if the attached patch fixes all cases and is ok as it is. Feedback very welcome! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #2 from Katrin Fischer --- Created attachment 29145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29145&action=edit Bug 12465: Improve display of MARC21 710 in intranet and OPAC Currently, 710$a and $b and $b will not display correctly. This patch tries to improve the display adding the missing space between both subfields. Please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 --- Comment #1 from Katrin Fischer --- Example: 710 2 _aDeutschland _bBundestag _0(DE-588b)2116123-9 _0(DE-576)193731266 _9167 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer changed: What|Removed |Added Component|OPAC|MARC Bibliographic data ||support Assignee|oleon...@myacpl.org |gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9820 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c (MARC21/XSLT)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12465 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12465] New: XSLT: Missing punctuation between 710$a and $b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12465 Bug ID: 12465 Summary: XSLT: Missing punctuation between 710$a and $b Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org If you have a record with 710$a and $b, there is no space or punctuation between the fields in result list and detail page in OPAC and staff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486 --- Comment #87 from Katrin Fischer --- Jesse, could you take a look at the problem Jonathan had (comment 84) please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron changed: What|Removed |Added Attachment #28327|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #4 from Marc Véron --- Created attachment 29144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29144&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12449] Routing list tab and Suggestions tab disappear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12449 Katrin Fischer changed: What|Removed |Added CC||pasi.kalli...@pttk.fi --- Comment #1 from Katrin Fischer --- *** Bug 11394 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11357] biblio.size value not correctly displayed in list emails sent from OPAC and intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11357 Katrin Fischer changed: What|Removed |Added Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11394] "Routing lists" -tab vanishes from patron info bar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11394 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12449 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12464] Bootstrap XSLT view no longer displaying 505 correctly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12464 --- Comment #1 from Katrin Fischer --- Created attachment 29143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29143&action=edit Staff detail page - 505 formatting present -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12464] Bootstrap XSLT view no longer displaying 505 correctly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12464 Katrin Fischer changed: What|Removed |Added CC||jcam...@cpbibliography.com See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6617 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6617] table of contents not printing right if entered right
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12464 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12464] New: Bootstrap XSLT view no longer displaying 505 correctly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12464 Bug ID: 12464 Summary: Bootstrap XSLT view no longer displaying 505 correctly formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Created attachment 29142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29142&action=edit Bootstrap detail page - 505 formatting missing Bug 6617 introduced a nicer display for the 505 footnotes in OPAC and staff. In staff this is still working correctly, but in Bootstrap the footnote is not correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
